RFR: 8090547: Allow for transparent backgrounds in WebView [v7]

Jose Pereda jpereda at openjdk.java.net
Thu Sep 9 08:47:08 UTC 2021


On Wed, 8 Sep 2021 21:08:40 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Jose Pereda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address feedback from reviewers
>
> modules/javafx.web/src/main/java/com/sun/webkit/WebPage.java line 2589:
> 
>> 2587:     private static int getIntRgba(Color color) {
>> 2588:         if (color == null) {
>> 2589:             return -1;
> 
> Maybe: `return 0xFFFFFFFF;` ? or else assign `color = Color.WHITE;` and fall through?

Probably better then to create a constant? 

private static final int DEFAULT_BACKGROUND_INT_RGBA = 0xFFFFFFFF; // Color.WHITE

-------------

PR: https://git.openjdk.java.net/jfx/pull/563


More information about the openjfx-dev mailing list