RFR: 8090547: Allow for transparent backgrounds in WebView [v8]
Jose Pereda
jpereda at openjdk.java.net
Thu Sep 9 17:28:08 UTC 2021
On Thu, 9 Sep 2021 08:52:31 GMT, Jose Pereda <jpereda at openjdk.org> wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but the class is not public. Therefore, public API is needed in `WebView` to allow developers access to it.
>>
>> In line with the `fontSmoothingType` property, this PR provides public support for setting the background color of a WebPage, by adding a `pageFill` property, and a CSR is required.
>>
>> The color for the background, that can be opaque, transparent or with any level of opacity, can be set via code or via CSS using `-fx-page-fill`.
>>
>> Unit tests and a system test are provided.
>
> Jose Pereda has updated the pull request incrementally with one additional commit since the last revision:
>
> Changes required per reviewer
Yes, I have been testing on MacOS (11.5.1), Linux (Ubuntu 20.04) and Windows (10) with a manual test. I do a quick visual test with transparent, translucent and solid color, including scrolling and selecting some text.
However, the `PageFillTest` system test (which was actually based on this manual test) involves also taking snapshots and pixel comparison.
On MacOS it works fine. On Linux I see this "ghosting" while scrolling, but snapshots are taken on a steady position, and it shouldn't be there. What assertion fails for you?
-------------
PR: https://git.openjdk.java.net/jfx/pull/563
More information about the openjfx-dev
mailing list