RFR: 8188026: TextFieldXXCell: NPE on calling startEdit [v4]

Marius Hanl mhanl at openjdk.java.net
Sun Sep 19 11:52:56 UTC 2021


On Thu, 19 Aug 2021 12:25:16 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Separated test and made the cell a supplier instead
>
> modules/javafx.controls/src/main/java/javafx/scene/control/cell/TextFieldTreeCell.java line 195:
> 
>> 193:         if (!isEditing()) {
>> 194:             return;
>> 195:         }
> 
> similar to ChoiceBox/ComboBoxTreeCell, except that a similar test fails both before/after the fix

hm interesting enough this tree cell has no `treeItem = null` guard (unlike the others). TreeCells are very weird ��

-------------

PR: https://git.openjdk.java.net/jfx/pull/569


More information about the openjfx-dev mailing list