math routine implementation with .s files

[Kandu, Rahul]

Hi Vladimir,

There is an issue with merging these .s files. All of these files use the same labels e.g. ..TXTST0:, ..B1.1, ..L2 etc. Merging them would mean we edit the .s files to change the labels for them everywhere, which can be error prone even with script/automation. 

Rahul

-----Original Message-----
From: panama-dev [mailto:panama-dev-bounces at openjdk.java.net] On Behalf Of Kandu, Rahul
Sent: Thursday, May 31, 2018 9:22 AM
To: Vladimir Ivanov <vladimir.x.ivanov at oracle.com>; panama-dev at openjdk.java.net
Subject: RE: math routine implementation with .s files

Hi Vladimir,

Re-naming files in more relevant way should be fine. It doesn't change underneath implementation. I'll look into merging the files. 

Rahul

-----Original Message-----
From: Vladimir Ivanov [mailto:vladimir.x.ivanov at oracle.com] 
Sent: Wednesday, May 30, 2018 11:27 PM
To: Kandu, Rahul <rahul.kandu at intel.com>; panama-dev at openjdk.java.net
Subject: Re: math routine implementation with .s files

Looks good!

As a side note, number of files added per operation looks like an overkill. What do you think about having a single .s file per operation?

   src/hotspot/os_cpu/linux_x86/svml_d_acos2_core_exha.s
   src/hotspot/os_cpu/linux_x86/svml_d_acos2_core_l9ha.s
   src/hotspot/os_cpu/linux_x86/svml_d_acos4_core_l9ha.s
   src/hotspot/os_cpu/linux_x86/svml_d_acos8_core_z0ha.s
   src/hotspot/os_cpu/linux_x86/svml_d_acos_cout_exha.s
   src/hotspot/os_cpu/linux_x86/svml_d_acos_data_exha.s

Also, some comments about naming. Current convention is to have os/cpu info duplicated in file name as well (e.g., src/hotspot/os_cpu/linux_x86/linux_x86_64.s or assembler_linux_x86.cpp). 
And I'd prefer the names clearly state their relation to Vector API (either in the file name or placed in a subdir).

(But that's not something requiring immediate attention.)

Best regards,
Vladimir Ivanov

On 31/05/2018 04:51, Kandu, Rahul wrote:
> Hi All,
> 
> Please find the patch which implements several transcendental and trigonometric vector math routines in from of assembly .s files.
> http://cr.openjdk.java.net/~rlupusoru/panama/webrev_linuxsvml_00/
> 
> This is an extension of the patch submitted by Razvan earlier which implemented the Infrastructure for calling math routines in .s files.
> 
> regards,
> Rahul
>