[vector] Small patch to rationalize species/shape factories

Viswanathan, Sandhya sandhya.viswanathan at intel.com
Sat Feb 2 23:26:55 UTC 2019


Please find below a webrev applying Brian's speciesFactories patch applied to the tip along with the generated sources:
 http://cr.openjdk.java.net/~sviswanathan/vectorIntrinsics/Brian/speciesFactories/webrev.00/

All the vector api jtreg tests continues to pass with this. 

Also a small performance test with preferredSpecies continues to show the same good quality code generation as before.

If it is ok I would like to push this on Monday to vectorIntrinsics branch on behalf of Brian and continue on our quest to getting the API ready for preview.

Best Regards,
Sandhya


-----Original Message-----
From: panama-dev [mailto:panama-dev-bounces at openjdk.java.net] On Behalf Of Brian Goetz
Sent: Tuesday, January 29, 2019 1:42 PM
To: panama-dev at openjdk.java.net
Subject: [vector] Small patch to rationalize species/shape factories

Please find attached a small patch to rationalize species/shape factory methods.  It compiles and tests cleanly against the last checkin for which the tests pass.  This is the patch for only the ungenerated sources (for ease of review.)


It moves the species factories to Species.of() / Species.ofPreferred(), and the Shape factory to Shape.forBitSize().




More information about the panama-dev mailing list