[vector] RFR 8218750: Vectorized ChaCha20 Benchmark

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Wed Feb 13 21:25:59 UTC 2019


Looks good! Pushed:
   http://hg.openjdk.java.net/panama/dev/rev/85e355bff037

Best regards,
Vladimir Ivanov

On 13/02/2019 07:42, Adam Petcher wrote:
> New webrev: https://cr.openjdk.java.net/~apetcher/8218750/webrev.02/
> 
> On 2/12/2019 1:08 PM, Vladimir Ivanov wrote:
>>
>> I suggest to shape it as follows:
>>
>>   private ChaChaVector cc20_S128 = new 
>> ChaChaVector(Vector.Shape.S_128_BIT);
>>
>>   @Benchmark
>>   public void encrypt128() {
>>       cc20_S128.chacha20(key, nonce, counter, in, out);
>>   }
>>
>> As I understand, ChaChaBench.runKAT is a unit test. You can put it 
>> either into ChaChaBench.setup() or leave in ChaChaBench ctor, but use 
>> cc20_S128/S256/S512 instead.
> 
> I believe I reorganized it as you suggested. I added a helper method 
> that invokes runKAT when each ChaChaVector object is constructed.
> 


More information about the panama-dev mailing list