[foreign-abi] RFR: 8248499: Add methods to allocate off heap arrays from Java arrays [v3]

Henry Jen henryjen at openjdk.java.net
Wed Jul 1 00:59:20 UTC 2020


On Tue, 30 Jun 2020 21:43:57 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This patch adds methods to NativeScope which allow clients to allocate off-heap arrays from Java on-heap arrays.
>> 
>> While in most cases the code for copying is straightforward, we have to take into account endianness mismatches (in
>> case the user wants to store the array elements off-heap in an endianness that doesn't match that of the platform).
>> To allow for that, I've added a new implementation method in AbstractMemorySegmentImpl, which is the same as
>> `copyFrom`, but adds the byte swap (a wrapper around `Unsafe::copySwapMemory`).
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Addressed review comments

Looks good.

-------------

Marked as reviewed by henryjen (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/222


More information about the panama-dev mailing list