[foreign-jextract] RFR: 8248415: Create VarHandles for pointer fields through the MemoryHandles API [v2]

Thu Jul 2 15:16:15 UTC 2020

On Thu, 2 Jul 2020 12:23:45 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Filip Krakowski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix some carrier entries within carrier map
>
> src/jdk.incubator.jextract/share/classes/jdk/incubator/jextract/tool/ConstantHelper.java line 141:
> 
>> 140:             Map.entry(Float.TYPE,               desc(Short.TYPE)),
>> 141:             Map.entry(Double.TYPE,              desc(Short.TYPE)),
>> 142:             Map.entry(MemoryAddress.class,      desc(Long.TYPE))
> 
> These should not use `Short.TYPE`, but the corresponding type of the key (Long.TYPE, Float.TYPE, Double.TYPE).

Looks like i forgot to change it after copy-pasting, sorry :facepalm: Will push a new commit in a minute.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/216