[foreign-abi] RFR: Copy stubs from Compile arena to nmethod stub array
Henry Jen
henryjen at openjdk.java.net
Thu Jul 2 17:13:19 UTC 2020
On Thu, 2 Jul 2020 14:39:07 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
> Hi,
>
> This is a small followup on the intrinsics patch (https://github.com/openjdk/panama-foreign/pull/219).
>
> @slowhog was seeing a crash when native invoker stubs were being freed, and it turned out that this was due to not
> copying the stubs properly from the compile arena to the nmethod stub array when creating the nmethod. This patch fixes
> that. I had wrongly assumed that this code path would be exercised by the current tests, but this is evidently not the
> case. I'll think of a way to add a test for this specific case, but in the mean time this is a stop-gap fix to resolve
> the crash. Thanks,
> Jorn
Looks reasonable to me.
-------------
Marked as reviewed by henryjen (Committer).
PR: https://git.openjdk.java.net/panama-foreign/pull/227
More information about the panama-dev
mailing list