[foreign-abi] RFR: AArch64 build fixes

Paul Sandoz psandoz at openjdk.java.net
Thu Jul 9 21:54:51 UTC 2020


On Thu, 9 Jul 2020 14:38:07 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> Hi,
> 
> This patch fixes several linker errors observed when building on aarch64, due to missing implementations of methods
> added for the C2 down call intrinsics.
> Currently C2 compilation will just bail out when trying to generate a the native call, but I think another strategy is
> possible where we generate a call to the fallback MethodHandle instead. This patch is just fixing the build.
> Thanks,
> Jorn

Marked as reviewed by psandoz (Committer).

src/hotspot/cpu/aarch64/vmreg_aarch64.cpp line 64:

> 63:     case VECTOR_TYPE: return ::as_FloatRegister(index)->as_VMReg();
> 64:     case STACK_TYPE: return VMRegImpl::stack2reg(index LP64_ONLY(* 2)); // numbering on x64 goes per 64-bits
> 65:   }

Referral to x64 in the comment

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/238


More information about the panama-dev mailing list