[foreign-abi] RFR: Miscellaneous cleanups

[Maurizio Cimadamore]

On Thu, 19 Mar 2020 18:08:58 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> Hi,
> 
> This patch applies some general cleanups suggested by IntelliJ, such as:
> - Removing unused imports
> - Fixing typos
> - Applying `final` when possible
> - Using Optional::orElseThrow instead of Optional::get where it's uncertain if the optional contains a value
> - Using StringBuilder::append instead of `+` in some places (to avoid indy concat).
> - Changing indexed to for-each loop
> - Fixing a link in javadoc
> - Removing a spurious semicolon
> - Removing an unused method
> 
> Jorn

While the changes look generally good, I think there's a problem with this PR as it seems to apply to both
foreign-memaccess and foregn-abi classes - I think you need to split it into two?

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/59