[foreign-jextract] [Rev 01] RFR: Improve jextract error reporting

[Athijegannathan Sundararajan]

On Fri, 6 Mar 2020 11:27:59 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> src/jdk.incubator.jextract/share/classes/jdk/internal/clang/LibClang.java line 39:
>> 
>>> 38:         Index_h.clang_toggleCrashRecovery(CRASH_RECOVERY ? 1 : 0);
>>> 39:         if (DEBUG && !CRASH_RECOVERY) {
>>> 40:             System.err.println("LibClang crash recovery disabled");
>> 
>> Crash recovery is disabled by default, right? Shouldn't the debug for enabling? (because that is the explicit config
>> behaviour - or else this message will be printed always)
>
> This was the way it was before when crash recovery was always being disabled. It would always print the message when
> running in debug mode.
> I guess now we can print whether the crash recovery is enabled or disabled instead.

Looks good. Go ahead!

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/40