[foreign-memaccess+abi] RFR: 8262118: Specialize upcalls [v2]
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Tue Feb 23 11:17:55 UTC 2021
On Tue, 23 Feb 2021 10:50:16 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Jorn Vernee has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Tab to spaces
>> - Added TestMatrix test that test all configurations of TestUpcall TestDowncall and TestUpcallHightArity
>
> src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/ProgrammableInvoker.java line 243:
>
>> 241:
>> 242: if (bufferCopySize > 0) {
>> 243: specializedHandle = SharedUtils.wrapWithAllocator(specializedHandle, argAllocatorPos, bufferCopySize, false);
>
> The variable leafType in this method is unused (I couldn't leave the comment there - for some reason GitHub doesn't allow me to add comments outside the highlighted areas...)
+1 for dedicated TWR routine - which is now cleanly shared by upcall and downcall logic.
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/457
More information about the panama-dev
mailing list