From alan.bateman at oracle.com Thu Jul 1 08:36:53 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 01 Jul 2010 15:36:53 +0000 Subject: hg: jdk7/tl/jdk: 6947216: Even more Dual-pivot quicksort improvements Message-ID: <20100701153723.EEB57476AD@hg.openjdk.java.net> Changeset: a5a34c696d62 Author: alanb Date: 2010-07-01 16:28 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a5a34c696d62 6947216: Even more Dual-pivot quicksort improvements Reviewed-by: jjb Contributed-by: vladimir.yaroslavskiy at sun.com ! src/share/classes/java/util/DualPivotQuicksort.java ! test/java/util/Arrays/Sorting.java From sean.mullan at oracle.com Thu Jul 1 13:16:01 2010 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Thu, 01 Jul 2010 20:16:01 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20100701201636.0BA42476B9@hg.openjdk.java.net> Changeset: 9bffc32b645d Author: mullan Date: 2010-07-01 15:20 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9bffc32b645d 6782979: Add JNLPAppletLauncher (6618105) to blacklist Reviewed-by: ohair ! make/java/security/Makefile Changeset: c0d2a097eb99 Author: mullan Date: 2010-07-01 15:30 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c0d2a097eb99 Merge From joe.darcy at oracle.com Tue Jul 6 18:57:58 2010 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 07 Jul 2010 01:57:58 +0000 Subject: hg: jdk7/tl/jdk: 6963723: Project Coin: Retrofit more JDK classes for ARM Message-ID: <20100707015825.8F78E477E4@hg.openjdk.java.net> Changeset: 425960cef714 Author: darcy Date: 2010-07-06 18:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/425960cef714 6963723: Project Coin: Retrofit more JDK classes for ARM Reviewed-by: alanb, malenkov, prr, amenkov ! src/share/classes/java/beans/XMLDecoder.java ! src/share/classes/java/beans/XMLEncoder.java ! src/share/classes/java/io/ObjectInput.java ! src/share/classes/java/io/ObjectOutput.java ! src/share/classes/java/util/Scanner.java ! src/share/classes/javax/sound/midi/MidiDevice.java ! src/share/classes/javax/sound/midi/Receiver.java ! src/share/classes/javax/sound/midi/Transmitter.java ! src/share/classes/javax/sound/sampled/Line.java From kelly.ohair at oracle.com Wed Jul 7 10:18:44 2010 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Wed, 07 Jul 2010 17:18:44 +0000 Subject: hg: jdk7/tl/jdk: 6954517: Testcase failure tools/launcher/UnicodeTest.sh Message-ID: <20100707171905.4289B47805@hg.openjdk.java.net> Changeset: d6f8ffc3c54a Author: ohair Date: 2010-07-07 10:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d6f8ffc3c54a 6954517: Testcase failure tools/launcher/UnicodeTest.sh Reviewed-by: ksrini ! test/tools/launcher/UnicodeTest.sh From kumar.x.srinivasan at oracle.com Fri Jul 9 09:54:24 2010 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Fri, 09 Jul 2010 16:54:24 +0000 Subject: hg: jdk7/tl/jdk: 6930056: (launcher) Need to remove or build as part of test these liblibrary.so files Message-ID: <20100709165439.08BD547879@hg.openjdk.java.net> Changeset: f13e94562d84 Author: ksrini Date: 2010-07-09 09:54 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f13e94562d84 6930056: (launcher) Need to remove or build as part of test these liblibrary.so files Reviewed-by: ohair, darcy - test/tools/launcher/Makefile.SolarisRunpath - test/tools/launcher/lib/i386/lib32/lib32/liblibrary.so - test/tools/launcher/lib/i386/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib64/lib64/liblibrary.so - test/tools/launcher/lib/sparc/lib64/liblibrary.so From martinrb at google.com Fri Jul 9 19:25:36 2010 From: martinrb at google.com (martinrb at google.com) Date: Sat, 10 Jul 2010 02:25:36 +0000 Subject: hg: jdk7/tl/jdk: 6967533: Epoch bug: ExceptionInInitializerError on systems with uninitialized clock Message-ID: <20100710022555.0036F47894@hg.openjdk.java.net> Changeset: da8526047e5f Author: martin Date: 2010-07-09 18:55 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/da8526047e5f 6967533: Epoch bug: ExceptionInInitializerError on systems with uninitialized clock Summary: Remove (hopefully!) unnecessary check of currentTimeMillis Reviewed-by: dholmes Contributed-by: Jon VanAlten ! src/share/classes/java/lang/System.java From chris.hegarty at oracle.com Mon Jul 12 10:19:31 2010 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 12 Jul 2010 17:19:31 +0000 Subject: hg: jdk7/tl/jdk: 3 new changesets Message-ID: <20100712172028.D9D334792A@hg.openjdk.java.net> Changeset: a7f8f269f741 Author: chegar Date: 2010-07-12 18:13 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a7f8f269f741 6967937: Scope id no longer being set after 6931566 Reviewed-by: alanb, dsamersoff ! src/solaris/native/java/net/NetworkInterface.c ! test/java/net/Inet6Address/B6214234.java Changeset: 1371a2d5f3a8 Author: chegar Date: 2010-07-12 18:16 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1371a2d5f3a8 6967684: httpserver using a non thread-safe SimpleDateFormat Reviewed-by: michaelm ! src/share/classes/sun/net/httpserver/ExchangeImpl.java Changeset: bb0b32ffefe9 Author: chegar Date: 2010-07-12 18:18 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bb0b32ffefe9 6966846: Incorrect assertion in java.net.Inet6Address.readObject Reviewed-by: michaelm ! src/share/classes/java/net/Inet6Address.java From kumar.x.srinivasan at oracle.com Mon Jul 12 15:37:45 2010 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Mon, 12 Jul 2010 22:37:45 +0000 Subject: hg: jdk7/tl/jdk: 6921472: RFE: java launcher code needs clean up Message-ID: <20100712223755.DE00747937@hg.openjdk.java.net> Changeset: d3fa95d0710c Author: ksrini Date: 2010-07-09 11:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d3fa95d0710c 6921472: RFE: java launcher code needs clean up Summary: This changeset also contains fixes for 6405284, 6753938 and 6922500 Reviewed-by: darcy ! src/share/bin/emessages.h ! src/share/bin/java.c ! src/share/bin/java.h ! src/share/bin/jli_util.c ! src/share/bin/jli_util.h ! src/solaris/bin/java_md.c ! src/windows/bin/java_md.c ! test/tools/launcher/Arrrghs.java From daniel.daugherty at oracle.com Mon Jul 12 15:52:42 2010 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Mon, 12 Jul 2010 22:52:42 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20100712225301.AA47C47939@hg.openjdk.java.net> Changeset: ddf825161d2d Author: dcubed Date: 2010-07-12 14:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ddf825161d2d 6968401: 3/3 disable tests added by 6942989 until 6964018 is fixed Summary: Disable AnonLoggerWeakRefLeak.sh and LoggerWeakRefLeak.sh Reviewed-by: ohair ! test/java/util/logging/AnonLoggerWeakRefLeak.sh ! test/java/util/logging/LoggerWeakRefLeak.sh Changeset: 4e365ef6576d Author: dcubed Date: 2010-07-12 15:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4e365ef6576d Merge From jonathan.gibbons at oracle.com Mon Jul 12 16:38:23 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 12 Jul 2010 23:38:23 +0000 Subject: hg: jdk7/tl/langtools: 6968497: localized text appears in raw diagnostic Message-ID: <20100712233826.BAF114793B@hg.openjdk.java.net> Changeset: 064468702a8d Author: jjg Date: 2010-07-12 16:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/064468702a8d 6968497: localized text appears in raw diagnostic Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/comp/Check.java ! test/tools/javac/generics/6946618/T6946618c.java ! test/tools/javac/generics/6946618/T6946618c.out From Weijun.Wang at Sun.COM Tue Jul 13 04:36:13 2010 From: Weijun.Wang at Sun.COM (Weijun Wang) Date: Tue, 13 Jul 2010 19:36:13 +0800 Subject: code review request: 6670889: Keystore created under Hindi Locale causing ArrayIndexOutOfBoundsException Message-ID: <4C3C4FAD.2030803@sun.com> 6670889: Keystore created under Hindi Locale causing ArrayIndexOutOfBoundsException Webrev: http://cr.openjdk.java.net/~weijun/6670889/webrev.00/ Thanks Max From dmitry.samersoff at sun.com Tue Jul 13 04:36:55 2010 From: dmitry.samersoff at sun.com (dmitry.samersoff at sun.com) Date: Tue, 13 Jul 2010 11:36:55 +0000 Subject: hg: jdk7/tl/jdk: 6964714: NetworkInterface getInetAddresses enumerates IPv6 addresses if java.net.preferIPvStack property set Message-ID: <20100713113711.343AB47956@hg.openjdk.java.net> Changeset: 25050030a320 Author: dsamersoff Date: 2010-07-13 15:32 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/25050030a320 6964714: NetworkInterface getInetAddresses enumerates IPv6 addresses if java.net.preferIPvStack property set Summary: User can disable ipv6 explicitly, have to check it Reviewed-by: chegar, alanb ! src/solaris/native/java/net/NetworkInterface.c + test/java/net/NetworkInterface/IPv4Only.java From chris.hegarty at oracle.com Tue Jul 13 05:12:14 2010 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 13 Jul 2010 13:12:14 +0100 Subject: code review request: 6670889: Keystore created under Hindi Locale causing ArrayIndexOutOfBoundsException In-Reply-To: <4C3C4FAD.2030803@sun.com> References: <4C3C4FAD.2030803@sun.com> Message-ID: <4C3C581E.9010301@oracle.com> This change looks fine. -Chris. On 07/13/10 12:36, Weijun Wang wrote: > 6670889: Keystore created under Hindi Locale causing > ArrayIndexOutOfBoundsException > > Webrev: > http://cr.openjdk.java.net/~weijun/6670889/webrev.00/ > > Thanks > Max > From weijun.wang at sun.com Tue Jul 13 05:27:38 2010 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Tue, 13 Jul 2010 12:27:38 +0000 Subject: hg: jdk7/tl/jdk: 6670889: Keystore created under Hindi Locale causing ArrayIndexOutOfBoundsException Message-ID: <20100713122748.2DCF547958@hg.openjdk.java.net> Changeset: f3a4c1947fd1 Author: weijun Date: 2010-07-13 20:27 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f3a4c1947fd1 6670889: Keystore created under Hindi Locale causing ArrayIndexOutOfBoundsException Reviewed-by: chegar ! src/share/classes/sun/security/util/DerOutputStream.java + test/sun/security/util/DerOutputStream/LocaleInTime.java From jonathan.gibbons at oracle.com Tue Jul 13 19:14:41 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 14 Jul 2010 02:14:41 +0000 Subject: hg: jdk7/tl/langtools: 6966732: replace use of static Log.getLocalizedString with non-static alternative where possible Message-ID: <20100714021442.CA9D247978@hg.openjdk.java.net> Changeset: a5454419dd46 Author: jjg Date: 2010-07-13 19:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a5454419dd46 6966732: replace use of static Log.getLocalizedString with non-static alternative where possible Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/Log.java From jonathan.gibbons at oracle.com Tue Jul 13 19:18:15 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 14 Jul 2010 02:18:15 +0000 Subject: hg: jdk7/tl/langtools: 6968434: test CheckResourceKeys fails on control builds Message-ID: <20100714021816.EDD5B47979@hg.openjdk.java.net> Changeset: 0e1fab5cffc8 Author: jjg Date: 2010-07-13 19:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/0e1fab5cffc8 6968434: test CheckResourceKeys fails on control builds Reviewed-by: darcy ! test/tools/javac/diags/CheckResourceKeys.java From Weijun.Wang at Sun.COM Tue Jul 13 19:20:52 2010 From: Weijun.Wang at Sun.COM (Weijun Wang) Date: Wed, 14 Jul 2010 10:20:52 +0800 Subject: code review request: 6968542: keytool -importcert cannot deal with duplicate certs Message-ID: <4C3D1F04.2070207@sun.com> Hi All 6968542: keytool -importcert cannot deal with duplicate certs Webrev: http://cr.openjdk.java.net/~weijun/6968542/webrev.00/ *Description* ============================================================ keytool does not eliminate duplicate certs when importing a reply. It may or may not report an error and the cert chain in keystore is invalid after import. This is a small regression since we decided to generate the whole chain in 6937978. Before 6937978, after generate a cert using keytool -gencert, we cat the output and all CA certs into keytool -importcert, now that the output already contains CA certs, dup entries should be removed. For example, if CA signs INT and INT signs ME. The -gencert output for ME now includes certs for ME and INT. If we cat this output and certs for INT and CA into "keytool -importcert -alias ME". The final imported cert chain will look like (ME, INT, CA, INT, CA). Thanks Max From jonathan.gibbons at oracle.com Tue Jul 13 19:21:30 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 14 Jul 2010 02:21:30 +0000 Subject: hg: jdk7/tl/langtools: 6968789: incorrect text in "diamond not supported" message Message-ID: <20100714022131.C8DAA4797A@hg.openjdk.java.net> Changeset: e57b27703e8b Author: jjg Date: 2010-07-13 19:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e57b27703e8b 6968789: incorrect text in "diamond not supported" message Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/resources/compiler.properties From Weijun.Wang at Sun.COM Wed Jul 14 23:12:43 2010 From: Weijun.Wang at Sun.COM (Weijun Wang) Date: Thu, 15 Jul 2010 14:12:43 +0800 Subject: code review request: 6969292: make DNS lookup for realm/kdc really work Message-ID: <4C3EA6DB.7050305@sun.com> Hi Valerie 6969292: make DNS lookup for realm/kdc really work Webrev: http://cr.openjdk.java.net/~weijun/6969292/webrev.00/ We've implemented DNS lookup for realm and kdc for some time, and have made it default turned on in JDK 7. However, it's still not 100% zero-configuration, a krb5.conf is needed to map hostname to realm. This fix iterates thru ResolverConfiguration.open().searchlist() which includes "search" or "domain" values in /etc/resolv.conf. The file normally always exists on a linux/unix system. It would be nice to directly get the "domain" name, but there's no public method to retrieve it. Maybe this trick should be performed at JNDI/DNS level, where a one-word query item be automatically appended with elements in srchlist. However, JNDI is quite stable and I don't want to touch it. Vinnie, any comment? I've tried this on brand new solaris-i586 and linux-x64 (VM) systems (inside the SunWAN) with no krb5.conf and it works fine. I also fix a small error, "_udp." -> "_udp", because the dot is added again in the getKerberosService(*,*) method. Several debug lines are added. Thanks Max From maurizio.cimadamore at oracle.com Thu Jul 15 08:46:07 2010 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 15 Jul 2010 15:46:07 +0000 Subject: hg: jdk7/tl/langtools: 2 new changesets Message-ID: <20100715154610.E9BD7479E1@hg.openjdk.java.net> Changeset: b49b0d72c071 Author: mcimadamore Date: 2010-07-15 16:31 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b49b0d72c071 6967002: JDK7 b99 javac compilation error (java.lang.AssertionError) Summary: bug in JavacParser related to parsing of type annotations in varargs position Reviewed-by: jjg Contributed-by: mahmood at notnoop.com ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/typeAnnotations/6967002/T6967002.java + test/tools/javac/typeAnnotations/6967002/T6967002.out Changeset: 472e74211e11 Author: mcimadamore Date: 2010-07-15 16:31 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/472e74211e11 6964669: javac reports error on miranda methods Summary: synthetic name clash check should not apply to miranda methods Reviewed-by: jjg Contributed-by: tomas.zezula at sun.com ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/miranda/6964669/T6964669.java + test/tools/javac/miranda/6964669/pkg/A.java + test/tools/javac/miranda/6964669/pkg/B.java + test/tools/javac/miranda/6964669/pkg/C.java From sean.mullan at oracle.com Thu Jul 15 09:57:13 2010 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 15 Jul 2010 12:57:13 -0400 Subject: DSA and ECDSA signature format is incompatible with XMLDSig Message-ID: <4C3F3DE9.3080204@oracle.com> Hi, I would like to try to fix a long-standing XMLDSig issue with the current DSA and ECDSA signature bytes format. The format of the Signature bytes for these algorithms is an ASN.1 encoded sequence of the integers r and s: SEQUENCE ::= { r INTEGER, s INTEGER } Unfortunately, this is not compatible with XMLDSig (and other signature formats like .NET), which doesn't ASN.1 encode them and simply base64 encodes the raw bytes of r and s concatenated (the IEEE P1363 format). So, our XMLDSig implementation always has to strip off, or decode the ASN.1 stuff after calling Signature.sign() when generating signatures, and ASN.1 encode the signature bytes before calling Signature.verify() when verifying signatures. I could live with this until now because it was limited to DSA which wasn't in wide use. But now the same problem comes up with ECDSA. I would really like to clean this up. There seems to be a couple of ways we could fix this: 1. Add new standard signature format strings that identify the format: ex: SHA1withDSAandP1363 SHA1withECDSAandP1363 SHA256withECDSAandP1363 SHA384withECDSAandP1363 SHA512withECDSAandP1363 I like this the best, but one issue with this is that the "and" extended format is reserved for MGF functions, ex: MD5withRSAandMGF1 and this is not a mask generation function. My suggestion is that we use a keyword (ex: Format) that clearly distinguishes it from an MGF: withandFormat ex: SHA256withECDSAandP1363Format 2. Add a new AlgorithmParameterSpec subclass that specifies the format, and then call Signature.setParameter before generating/verifying the signature. I'm not thrilled by this option, because this isn't really a standard input parameter, and will cause problems if/when you want to use it with an algorithm that does require input parameters (like an RSA PSSParameterSpec) 3. Add a higher level DSA/ECDSA Signer API that returns the r and s as BigIntegers and leaves the encoding of those bytes to the application. This is a very clean solution, but is more of a significant API change as it would be introducing a new higher level API for generating/validating signatures. 4. Do nothing Live with it :( ------- Any other comments, suggestions? Thanks, Sean From joe.darcy at oracle.com Thu Jul 15 18:03:16 2010 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 16 Jul 2010 01:03:16 +0000 Subject: hg: jdk7/tl/jdk: 6963622: Project Coin: Refinements to suppressed exceptions Message-ID: <20100716010326.819AA479F8@hg.openjdk.java.net> Changeset: ab65f46ae092 Author: darcy Date: 2010-07-15 18:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ab65f46ae092 6963622: Project Coin: Refinements to suppressed exceptions Reviewed-by: alanb, forax, jjb ! src/share/classes/java/lang/AutoCloseable.java ! src/share/classes/java/lang/Throwable.java ! test/java/lang/Throwable/SuppressedExceptions.java From Weijun.Wang at Sun.COM Thu Jul 15 23:23:11 2010 From: Weijun.Wang at Sun.COM (Weijun Wang) Date: Fri, 16 Jul 2010 14:23:11 +0800 Subject: code review request: 6969292: make DNS lookup for realm/kdc really work In-Reply-To: <4C3EA6DB.7050305@sun.com> References: <4C3EA6DB.7050305@sun.com> Message-ID: <4C3FFACF.8010203@sun.com> Updated webrev: http://cr.openjdk.java.net/~weijun/6969292/webrev.01/ Changes: checkRealm() return null instead of throwing an exception. (Thanks, Alan). Thanks Max On 07/15/2010 02:12 PM, Weijun Wang wrote: > Hi Valerie > > 6969292: make DNS lookup for realm/kdc really work > > Webrev: > http://cr.openjdk.java.net/~weijun/6969292/webrev.00/ > > We've implemented DNS lookup for realm and kdc for some time, and have > made it default turned on in JDK 7. However, it's still not 100% > zero-configuration, a krb5.conf is needed to map hostname to realm. > > This fix iterates thru ResolverConfiguration.open().searchlist() which > includes "search" or "domain" values in /etc/resolv.conf. The file > normally always exists on a linux/unix system. It would be nice to > directly get the "domain" name, but there's no public method to retrieve > it. > > Maybe this trick should be performed at JNDI/DNS level, where a one-word > query item be automatically appended with elements in srchlist. However, > JNDI is quite stable and I don't want to touch it. > > Vinnie, any comment? > > I've tried this on brand new solaris-i586 and linux-x64 (VM) systems > (inside the SunWAN) with no krb5.conf and it works fine. > > I also fix a small error, "_udp." -> "_udp", because the dot is added > again in the getKerberosService(*,*) method. Several debug lines are added. > > Thanks > Max > > From xueming.shen at oracle.com Fri Jul 16 13:49:30 2010 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Fri, 16 Jul 2010 20:49:30 +0000 Subject: hg: jdk7/tl/jdk: 6964313: Find sun/nio/cs/ext issue with CreateSymbols, then move sun/nio/cs/ext to charset.jar Message-ID: <20100716204952.8A78847A40@hg.openjdk.java.net> Changeset: a3747592bdf7 Author: sherman Date: 2010-07-16 16:45 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a3747592bdf7 6964313: Find sun/nio/cs/ext issue with CreateSymbols, then move sun/nio/cs/ext to charset.jar Summary: Removed the duplicate sun.nio.cs.ext entries from rt.jar and moved X11 charsets into charsets.jar Reviewed-by: ohair ! make/common/Release.gmk ! make/sun/nio/cs/Makefile From valerie.peng at oracle.com Fri Jul 16 15:06:19 2010 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Fri, 16 Jul 2010 15:06:19 -0700 Subject: code review request: 6969292: make DNS lookup for realm/kdc really work In-Reply-To: <4C3FFACF.8010203@sun.com> References: <4C3EA6DB.7050305@sun.com> <4C3FFACF.8010203@sun.com> Message-ID: <4C40D7DB.7020701@oracle.com> Looks fine except the following minor nit: - Why not return realm on line 1224 after a match is found? Doesn't seem necessary to continue w/ the whole for-loop. Thanks, Valerie On 07/15/10 23:23, Weijun Wang wrote: > Updated webrev: > > http://cr.openjdk.java.net/~weijun/6969292/webrev.01/ > > Changes: > > checkRealm() return null instead of throwing an exception. (Thanks, > Alan). > > Thanks > Max > > > On 07/15/2010 02:12 PM, Weijun Wang wrote: >> Hi Valerie >> >> 6969292: make DNS lookup for realm/kdc really work >> >> Webrev: >> http://cr.openjdk.java.net/~weijun/6969292/webrev.00/ >> >> We've implemented DNS lookup for realm and kdc for some time, and have >> made it default turned on in JDK 7. However, it's still not 100% >> zero-configuration, a krb5.conf is needed to map hostname to realm. >> >> This fix iterates thru ResolverConfiguration.open().searchlist() which >> includes "search" or "domain" values in /etc/resolv.conf. The file >> normally always exists on a linux/unix system. It would be nice to >> directly get the "domain" name, but there's no public method to retrieve >> it. >> >> Maybe this trick should be performed at JNDI/DNS level, where a one-word >> query item be automatically appended with elements in srchlist. However, >> JNDI is quite stable and I don't want to touch it. >> >> Vinnie, any comment? >> >> I've tried this on brand new solaris-i586 and linux-x64 (VM) systems >> (inside the SunWAN) with no krb5.conf and it works fine. >> >> I also fix a small error, "_udp." -> "_udp", because the dot is added >> again in the getKerberosService(*,*) method. Several debug lines are >> added. >> >> Thanks >> Max >> >> From joe.darcy at oracle.com Fri Jul 16 19:34:40 2010 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Sat, 17 Jul 2010 02:34:40 +0000 Subject: hg: jdk7/tl/langtools: 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler; ... Message-ID: <20100717023447.0088E47A51@hg.openjdk.java.net> Changeset: 13354e1abba7 Author: darcy Date: 2010-07-16 19:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/13354e1abba7 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler 6964740: Project Coin: More tests for ARM compiler changes 6965277: Project Coin: Correctness issues in ARM implementation 6967065: add -Xlint warning category for Automatic Resource Management (ARM) Reviewed-by: jjb, darcy, mcimadamore, jjg, briangoetz Contributed-by: tball at google.com ! make/build.properties ! src/share/classes/com/sun/source/tree/TryTree.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/CRTable.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! src/share/classes/com/sun/tools/javac/util/Names.java + test/tools/javac/TryWithResources/ArmLint.java + test/tools/javac/TryWithResources/ArmLint.out + test/tools/javac/TryWithResources/BadTwr.java + test/tools/javac/TryWithResources/BadTwr.out + test/tools/javac/TryWithResources/BadTwrSyntax.java + test/tools/javac/TryWithResources/BadTwrSyntax.out + test/tools/javac/TryWithResources/DuplicateResource.java + test/tools/javac/TryWithResources/DuplicateResourceDecl.java + test/tools/javac/TryWithResources/DuplicateResourceDecl.out + test/tools/javac/TryWithResources/ImplicitFinal.java + test/tools/javac/TryWithResources/ImplicitFinal.out + test/tools/javac/TryWithResources/PlainTry.java + test/tools/javac/TryWithResources/PlainTry.out + test/tools/javac/TryWithResources/PlainTry6.out + test/tools/javac/TryWithResources/ResourceOutsideTry.java + test/tools/javac/TryWithResources/ResourceOutsideTry.out + test/tools/javac/TryWithResources/ResourceTypeVar.java + test/tools/javac/TryWithResources/TwrFlow.java + test/tools/javac/TryWithResources/TwrFlow.out + test/tools/javac/TryWithResources/TwrInference.java + test/tools/javac/TryWithResources/TwrIntersection.java + test/tools/javac/TryWithResources/TwrIntersection02.java + test/tools/javac/TryWithResources/TwrIntersection02.out + test/tools/javac/TryWithResources/TwrMultiCatch.java + test/tools/javac/TryWithResources/TwrOnNonResource.java + test/tools/javac/TryWithResources/TwrOnNonResource.out + test/tools/javac/TryWithResources/TwrTests.java + test/tools/javac/TryWithResources/WeirdTwr.java + test/tools/javac/processing/model/element/TestResourceVariable.java From Alan.Bateman at oracle.com Sat Jul 17 01:28:26 2010 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Sat, 17 Jul 2010 09:28:26 +0100 Subject: code review request: 6969292: make DNS lookup for realm/kdc really work In-Reply-To: <4C40D7DB.7020701@oracle.com> References: <4C3EA6DB.7050305@sun.com> <4C3FFACF.8010203@sun.com> <4C40D7DB.7020701@oracle.com> Message-ID: <4C4169AA.1050800@oracle.com> Valerie (Yu-Ching) Peng wrote: > > Looks fine except the following minor nit: > - Why not return realm on line 1224 after a match is found? Doesn't > seem necessary to continue w/ the whole for-loop. Indeed, looks like it is missing a "break". -Alan. From maarten.bodewes at xs4all.nl Sat Jul 17 04:56:07 2010 From: maarten.bodewes at xs4all.nl (Maarten Bodewes) Date: Sat, 17 Jul 2010 13:56:07 +0200 Subject: DSA and ECDSA signature format is incompatible with XMLDSig In-Reply-To: <4C3F3DE9.3080204@oracle.com> References: <4C3F3DE9.3080204@oracle.com> Message-ID: On Thu, Jul 15, 2010 at 6:57 PM, Sean Mullan wrote: > I would like to try to fix a long-standing XMLDSig issue with the current > DSA and ECDSA signature bytes format. > > The format of the Signature bytes for these algorithms is an ASN.1 encoded > sequence of the integers r and s: > > SEQUENCE ::= { r INTEGER, s INTEGER } > > Unfortunately, this is not compatible with XMLDSig (and other signature > formats like .NET), which doesn't ASN.1 encode them and simply base64 > encodes the raw bytes of r and s concatenated (the IEEE P1363 format). > > There are more standards that use the P1363 format. Personally I'm involved with the EAC specification for ePassports & Java. You'll find this kind of signature if you look at the EAC certificates for the inspection systems (and their CA's). > So, our XMLDSig implementation always has to strip off, or decode the ASN.1 > stuff after calling Signature.sign() when generating signatures, and ASN.1 > encode the signature bytes before calling Signature.verify() when verifying > signatures. I could live with this until now because it was limited to DSA > which wasn't in wide use. But now the same problem comes up with ECDSA. > > That is a very well known situation for me :). I don't directly remember though if I had to do normalization on the integers as well (stripping of 00h bytes at the front or adding 00h bytes to get to the correct bit-size of the signature elements), or if s & r were encoded as ASN.1 octet strings. > I would really like to clean this up. There seems to be a couple of ways we > could fix this: > > 1. Add new standard signature format strings that identify the format: ex: > > SHA1withDSAandP1363 > SHA1withECDSAandP1363 > SHA256withECDSAandP1363 > SHA384withECDSAandP1363 > SHA512withECDSAandP1363 > > I like this the best, but one issue with this is that the "and" extended > format is reserved for MGF functions, ex: MD5withRSAandMGF1 and this is not > a mask generation function. My suggestion is that we use a keyword (ex: > Format) that clearly distinguishes it from an MGF: > > withandFormat > > ex: > > SHA256withECDSAandP1363Format > > I second this solution, since they would also be usable by other applications. I've got a serious problem with the solution though: hardware providers may not support it. And if HW providers do not support it then you need to work around it. Fortunately, if I'm not mistaken, you can work around this by creating a very simple provider that performs the wrapping/unwrapping of the signature (as you don't need to sign). Of course, by now the string build-up of the signature format is getting really complicated (you could say it is starting to imitate life). In the end it might be a good idea to replace it by something that can be selected/verified at compile time (e.g. a list of signature parameters). Currently it might be a good idea to create a constant somewhere for these kind of strings. > 2. Add a new AlgorithmParameterSpec subclass that specifies the format, and > then call Signature.setParameter before generating/verifying the signature. > > I'm not thrilled by this option, because this isn't really a standard input > parameter, and will cause problems if/when you want to use it with an > algorithm that does require input parameters (like an RSA PSSParameterSpec) > > I can see these problems as well. I would try to leave the parameter specs alone, they are more difficult in use. Maybe restrict their use to those places where changing integer input is required and such (against simple choices for the algorithm). > 3. Add a higher level DSA/ECDSA Signer API that returns the r and s as > BigIntegers and leaves the encoding of those bytes to the application. > > This is a very clean solution, but is more of a significant API change as > it would be introducing a new higher level API for generating/validating > signatures. > > Would that not be a *lower* level API, since it does not do the encoding? I don't directly see the need. If people want to step outside those algorithms that are standardized or generally used, they could choose a lower level API like Bouncy. Of course, in the end we might want to replace the current JCA with one that uses the factory principle and immutable Signer and Verifier classes, but that is an entirely different discussion :) > 4. Do nothing > > Live with it :( > > Nah, if you want to go for 1), then go for it. No current code would break, it's a standardized algorithm you are implementing and other people like me are using it. Regards, Maarten -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20100717/555882fe/attachment.html From chiralhelicity at gmail.com Sat Jul 17 23:30:06 2010 From: chiralhelicity at gmail.com (Jon Strauss) Date: Sat, 17 Jul 2010 23:30:06 -0700 Subject: "PKCS11" no longer supported for KeyStore Message-ID: <4C429F6E.6060603@gmail.com> Some time ago I came across a regression beginning after the sun-jdk 1.6.13 release. This regression continues into openjdk. The issue at hand is a single line found in the current SunPKCS#11 documentation: KeyStore ks = KeyStore.getInstance("PKCS11"); KeyStore ks = KeyStore.getInstance("PKCS11"); We have experienced a failure on this line under the current release of ubuntu and windows 7 running openjdk. SunJDK 1.6.13 performs as expected. -Sushi -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20100717/b51db385/attachment.html From Weijun.Wang at Sun.COM Sun Jul 18 05:57:56 2010 From: Weijun.Wang at Sun.COM (Weijun Wang) Date: Sun, 18 Jul 2010 20:57:56 +0800 Subject: "PKCS11" no longer supported for KeyStore In-Reply-To: <4C429F6E.6060603@gmail.com> References: <4C429F6E.6060603@gmail.com> Message-ID: What platform and openjdk release (or build) are you using? What kind of security providers are specified? When you say "regression", is it a regression of an earlier build of openjdk? If I understand correctly, a PKCS #11 security provider is needed to use PKCS11-based keystores. Currently, only JDK on Solaris includes out-of-box PKCS11 provider. For all other platforms, you need to supply your own. Thanks Max On Jul 18, 2010, at 2:30 PM, Jon Strauss wrote: > Some time ago I came across a regression beginning after the sun-jdk 1.6.13 release. This regression continues into openjdk. The issue at hand is a single line found in the current SunPKCS#11 documentation: > > KeyStore ks = KeyStore.getInstance("PKCS11"); > KeyStore ks = KeyStore.getInstance("PKCS11"); > > We have experienced a failure on this line under the current release of ubuntu and windows 7 running openjdk. SunJDK 1.6.13 performs as expected. > > -Sushi > > > From Weijun.Wang at Sun.COM Sun Jul 18 18:57:50 2010 From: Weijun.Wang at Sun.COM (Weijun Wang) Date: Mon, 19 Jul 2010 09:57:50 +0800 Subject: code review request: 6969292: make DNS lookup for realm/kdc really work In-Reply-To: <4C4169AA.1050800@oracle.com> References: <4C3EA6DB.7050305@sun.com> <4C3FFACF.8010203@sun.com> <4C40D7DB.7020701@oracle.com> <4C4169AA.1050800@oracle.com> Message-ID: <4C43B11E.80500@sun.com> Yes, you are correct. In fact, I've thought about this. The original code was: 1196 boolean found = false; 1197 for (int i = 0; i < records.length; i++) { 1198 if (records[i].equals(mapRealm)) { 1199 found = true; 1200 realm = records[i]; 1201 } 1202 } and I asked myself: should I also loop thru all elements? I'll add a break. This is not a good coding style. Thanks Max On 07/17/2010 04:28 PM, Alan Bateman wrote: > Valerie (Yu-Ching) Peng wrote: >> >> Looks fine except the following minor nit: >> - Why not return realm on line 1224 after a match is found? Doesn't >> seem necessary to continue w/ the whole for-loop. > Indeed, looks like it is missing a "break". > > -Alan. From weijun.wang at sun.com Sun Jul 18 19:04:09 2010 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Mon, 19 Jul 2010 02:04:09 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20100719020430.2242C47ACA@hg.openjdk.java.net> Changeset: 9a1bd20fc71c Author: weijun Date: 2010-07-19 10:02 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9a1bd20fc71c 6969683: Generify ResolverConfiguration codes Reviewed-by: alanb, chegar ! src/share/classes/com/sun/jndi/dns/DnsContextFactory.java ! src/share/classes/sun/net/dns/ResolverConfiguration.java ! src/share/classes/sun/net/spi/nameservice/dns/DNSNameService.java ! src/solaris/classes/sun/net/dns/ResolverConfigurationImpl.java ! src/windows/classes/sun/net/dns/ResolverConfigurationImpl.java Changeset: 4022e0c84507 Author: weijun Date: 2010-07-19 10:02 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4022e0c84507 6969292: make DNS lookup for realm/kdc really work Reviewed-by: alanb, valeriep ! src/share/classes/sun/security/krb5/Config.java From sean.mullan at oracle.com Mon Jul 19 12:36:10 2010 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 19 Jul 2010 15:36:10 -0400 Subject: DSA and ECDSA signature format is incompatible with XMLDSig In-Reply-To: References: <4C3F3DE9.3080204@oracle.com> Message-ID: <4C44A92A.70000@oracle.com> Hi Maarten, Thanks for the comments, a few replies below - Maarten Bodewes wrote: > > > On Thu, Jul 15, 2010 at 6:57 PM, Sean Mullan > wrote: > > I would like to try to fix a long-standing XMLDSig issue with the > current DSA and ECDSA signature bytes format. > > The format of the Signature bytes for these algorithms is an ASN.1 > encoded sequence of the integers r and s: > > SEQUENCE ::= { r INTEGER, s INTEGER } > > Unfortunately, this is not compatible with XMLDSig (and other > signature formats like .NET), which doesn't ASN.1 encode them and > simply base64 encodes the raw bytes of r and s concatenated (the > IEEE P1363 format). > > > There are more standards that use the P1363 format. Personally I'm > involved with the EAC specification for ePassports & Java. You'll find > this kind of signature if you look at the EAC certificates for the > inspection systems (and their CA's). > > > > So, our XMLDSig implementation always has to strip off, or decode > the ASN.1 stuff after calling Signature.sign() when generating > signatures, and ASN.1 encode the signature bytes before calling > Signature.verify() when verifying signatures. I could live with this > until now because it was limited to DSA which wasn't in wide use. > But now the same problem comes up with ECDSA. > > > That is a very well known situation for me :). I don't directly remember > though if I had to do normalization on the integers as well (stripping > of 00h bytes at the front or adding 00h bytes to get to the correct > bit-size of the signature elements), or if s & r were encoded as ASN.1 > octet strings. Yes, your memory is correct. > I would really like to clean this up. There seems to be a couple of > ways we could fix this: > > 1. Add new standard signature format strings that identify the > format: ex: > > SHA1withDSAandP1363 > SHA1withECDSAandP1363 > SHA256withECDSAandP1363 > SHA384withECDSAandP1363 > SHA512withECDSAandP1363 > > I like this the best, but one issue with this is that the "and" > extended format is reserved for MGF functions, ex: MD5withRSAandMGF1 > and this is not a mask generation function. My suggestion is that we > use a keyword (ex: Format) that clearly distinguishes it from an MGF: > > withandFormat > > ex: > > SHA256withECDSAandP1363Format > > > I second this solution, since they would also be usable by other > applications. I've got a serious problem with the solution though: > hardware providers may not support it. And if HW providers do not > support it then you need to work around it. Fortunately, if I'm not > mistaken, you can work around this by creating a very simple provider > that performs the wrapping/unwrapping of the signature (as you don't > need to sign). Yes, but I believe this is no different than what is done today. The Java provider does the DER encoding/decoding and the underlying hardware impl does the verification/signing. > Of course, by now the string build-up of the signature format is getting > really complicated (you could say it is starting to imitate life). In > the end it might be a good idea to replace it by something that can be > selected/verified at compile time (e.g. a list of signature parameters). > Currently it might be a good idea to create a constant somewhere for > these kind of strings. Yes, point taken. In practice though this should not be too much of an issue. We'll document the new algorithms in the standard algorithms document [1] so developers can cut-paste them into their code. > 3. Add a higher level DSA/ECDSA Signer API that returns the r and s > as BigIntegers and leaves the encoding of those bytes to the > application. > > This is a very clean solution, but is more of a significant API > change as it would be introducing a new higher level API for > generating/validating signatures. > > > Would that not be a *lower* level API, since it does not do the > encoding? Yes, if you look at it that way. Actually, probably another solution would be to enhance the Signature API to support algorithm-specific signature objects (instead of bytes), but I would be very hesitant to do that just to support this option. > Of course, in the end we might want to replace the current JCA with one > that uses the factory principle and immutable Signer and Verifier > classes, but that is an entirely different discussion :) > > > > 4. Do nothing > > Live with it :( > > > Nah, if you want to go for 1), then go for it. No current code would > break, it's a standardized algorithm you are implementing and other > people like me are using it. Thanks. --Sean [1] http://download-llnw.oracle.com/docs/cd/E17409_01/javase/6/docs/technotes/guides/security/StandardNames.html From maarten.bodewes at xs4all.nl Mon Jul 19 14:32:11 2010 From: maarten.bodewes at xs4all.nl (Maarten Bodewes) Date: Mon, 19 Jul 2010 23:32:11 +0200 Subject: DSA and ECDSA signature format is incompatible with XMLDSig In-Reply-To: <4C44A92A.70000@oracle.com> References: <4C3F3DE9.3080204@oracle.com> <4C44A92A.70000@oracle.com> Message-ID: Darn, that was a bit premature, I don't see how the PKCS#11 provider can support this. Currently it only lists the SHA256withECDSA and such. This would make it near impossible to directly perform XML signatures using a HSM or software PKCS#11 lib. I'm not sure what output is generated by PKCS#11 natively, but that does not matter as the provider will certainly generate the DER encoded structure. At a minimum I think that the algorithms should be included in the PKCS#11 provider, but it makes the argument for the new string less sound. Regards, Maarten -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20100719/51d1995a/attachment.html From sean.mullan at oracle.com Mon Jul 19 15:35:26 2010 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 19 Jul 2010 18:35:26 -0400 Subject: DSA and ECDSA signature format is incompatible with XMLDSig In-Reply-To: References: <4C3F3DE9.3080204@oracle.com> <4C44A92A.70000@oracle.com> Message-ID: <4C44D32E.7010000@oracle.com> On 7/19/10 5:32 PM, Maarten Bodewes wrote: > Darn, that was a bit premature, I don't see how the PKCS#11 provider can > support this. Currently it only lists the SHA256withECDSA and such. > > This would make it near impossible to directly perform XML signatures > using a HSM or software PKCS#11 lib. > > I'm not sure what output is generated by PKCS#11 natively, but that does > not matter as the provider will certainly generate the DER encoded > structure. > > At a minimum I think that the algorithms should be included in the > PKCS#11 provider, but it makes the argument for the new string less sound. Sorry, I'm not fully understanding what the issue is, can you clarify? Here's what the PKCS#11 (v 2.20) specification [1] says: section 12.2.8 DSA with SHA-1 "For the purposes of this mechanism, a DSA signature is a 40-byte string, corresponding to the concatenation of the DSA values r and s, each represented most-significant byte first." section 12.3.1 EC Signatures "For the purposes of these mechanisms, an ECDSA signature is an octet string of even length which is at most two times nLen octets, where nLen is the length in octets of the base point order n. The signature octets correspond to the concatenation of the ECDSA values r and s, both represented as an octet string of equal length of at most nLen with the most significant byte first. ..." --Sean [1] ftp://ftp.rsasecurity.com/pub/pkcs/pkcs-11/v2-20/pkcs-11v2-20.pdf From sean.mullan at oracle.com Tue Jul 20 09:22:30 2010 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Tue, 20 Jul 2010 16:22:30 +0000 Subject: hg: jdk7/tl/jdk: 6870553: X509Certificate.getSigAlgName method description uses non-standard algorithm name as example Message-ID: <20100720162240.9AED947B1F@hg.openjdk.java.net> Changeset: 9d1994d53a67 Author: mullan Date: 2010-07-20 10:41 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9d1994d53a67 6870553: X509Certificate.getSigAlgName method description uses non-standard algorithm name as example Reviewed-by: xuelei ! src/share/classes/java/security/cert/X509CRL.java ! src/share/classes/java/security/cert/X509Certificate.java From chris.hegarty at oracle.com Wed Jul 21 05:32:42 2010 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 21 Jul 2010 12:32:42 +0000 Subject: hg: jdk7/tl/jdk: 6969395: TEST_BUG: Tests in java/net sun/net problems Message-ID: <20100721123252.3BEE547B4C@hg.openjdk.java.net> Changeset: 58f325ba3e27 Author: chegar Date: 2010-07-21 13:29 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/58f325ba3e27 6969395: TEST_BUG: Tests in java/net sun/net problems Reviewed-by: alanb ! test/ProblemList.txt ! test/com/sun/net/httpserver/Test1.java ! test/com/sun/net/httpserver/Test11.java ! test/com/sun/net/httpserver/Test12.java ! test/com/sun/net/httpserver/Test13.java ! test/com/sun/net/httpserver/Test6a.java ! test/com/sun/net/httpserver/Test7a.java ! test/com/sun/net/httpserver/Test8a.java ! test/com/sun/net/httpserver/Test9.java ! test/com/sun/net/httpserver/Test9a.java ! test/com/sun/net/httpserver/bugs/B6361557.java ! test/com/sun/net/httpserver/bugs/B6373555.java ! test/java/net/DatagramSocket/DatagramTimeout.java ! test/java/net/DatagramSocket/SendSize.java ! test/java/net/Inet6Address/B6558853.java ! test/java/net/Inet6Address/serialize/Serialize.java ! test/java/net/InetAddress/CheckJNI.java ! test/java/net/MulticastSocket/SetOutgoingIf.java ! test/java/net/ResponseCache/B6181108.java ! test/java/net/ResponseCache/ResponseCacheTest.java ! test/java/net/ResponseCache/getResponseCode.java - test/java/net/Socket/AccurateTimeout.java ! test/java/net/Socket/CloseAvailable.java ! test/java/net/Socket/DeadlockTest.java ! test/java/net/Socket/LingerTest.java ! test/java/net/Socket/LinkLocal.java ! test/java/net/Socket/ProxyCons.java ! test/java/net/Socket/ReadTimeout.java ! test/java/net/Socket/SetReceiveBufferSize.java ! test/java/net/Socket/SetSoLinger.java ! test/java/net/Socket/ShutdownBoth.java ! test/java/net/Socket/SoTimeout.java ! test/java/net/Socket/Timeout.java ! test/java/net/Socket/UrgentDataTest.java ! test/java/net/Socket/asyncClose/BrokenPipe.java ! test/java/net/Socket/setReuseAddress/Restart.java ! test/java/net/SocketInputStream/SocketClosedException.java ! test/java/net/SocketInputStream/SocketTimeout.java ! test/java/net/URL/GetContent.java ! test/java/net/URLClassLoader/ClassLoad.java ! test/java/net/URLConnection/DisconnectAfterEOF.java ! test/java/net/URLConnection/HandleContentTypeWithAttrs.java ! test/java/net/URLConnection/HttpContinueStackOverflow.java ! test/java/net/URLConnection/Redirect307Test.java ! test/java/net/URLConnection/RedirectLimit.java ! test/java/net/URLConnection/ResendPostBody.java ! test/java/net/URLConnection/SetIfModifiedSince.java ! test/java/net/URLConnection/TimeoutTest.java ! test/java/net/URLConnection/URLConnectionHeaders.java ! test/java/net/URLConnection/ZeroContentLength.java ! test/java/net/ipv6tests/B6521014.java ! test/java/net/ipv6tests/TcpTest.java ! test/java/net/ipv6tests/Tests.java ! test/sun/net/ftp/FtpGetContent.java ! test/sun/net/ftp/FtpURL.java ! test/sun/net/www/http/ChunkedInputStream/ChunkedEncodingWithProgressMonitorTest.java ! test/sun/net/www/http/ChunkedOutputStream/Test.java ! test/sun/net/www/http/HttpClient/B6726695.java ! test/sun/net/www/http/HttpClient/MultiThreadTest.java ! test/sun/net/www/http/HttpClient/ProxyTest.java ! test/sun/net/www/http/KeepAliveCache/KeepAliveTimerThread.java ! test/sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java ! test/sun/net/www/httptest/HttpServer.java ! test/sun/net/www/protocol/http/DigestTest.java From chris.hegarty at oracle.com Wed Jul 21 05:53:06 2010 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 21 Jul 2010 12:53:06 +0000 Subject: hg: jdk7/tl/jdk: 6970262: TEST_BUG: test/java/net/NetworkInterface/IPv4Only.java has wrong test name in @run tag Message-ID: <20100721125315.3AAA847B4D@hg.openjdk.java.net> Changeset: f90999d7c404 Author: chegar Date: 2010-07-21 13:52 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f90999d7c404 6970262: TEST_BUG: test/java/net/NetworkInterface/IPv4Only.java has wrong test name in @run tag Reviewed-by: alanb, dsamersoff ! test/java/net/NetworkInterface/IPv4Only.java From alan.bateman at oracle.com Wed Jul 21 11:31:50 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 21 Jul 2010 18:31:50 +0000 Subject: hg: jdk7/tl/jdk: 6963907: (so) Socket adapter need to implement sendUrgentData Message-ID: <20100721183206.E5DFF47B65@hg.openjdk.java.net> Changeset: 3902c742b5b1 Author: alanb Date: 2010-07-21 18:08 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3902c742b5b1 6963907: (so) Socket adapter need to implement sendUrgentData Reviewed-by: chegar ! make/java/nio/mapfile-linux ! make/java/nio/mapfile-solaris ! src/share/classes/sun/nio/ch/SocketAdaptor.java ! src/share/classes/sun/nio/ch/SocketChannelImpl.java ! src/solaris/native/sun/nio/ch/SocketChannelImpl.c ! src/windows/native/sun/nio/ch/SocketChannelImpl.c + test/java/nio/channels/SocketChannel/OutOfBand.java From daniel.daugherty at oracle.com Wed Jul 21 19:26:46 2010 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Thu, 22 Jul 2010 02:26:46 +0000 Subject: hg: jdk7/tl/jdk: 3 new changesets Message-ID: <20100722022714.A10C847B78@hg.openjdk.java.net> Changeset: d899526a187a Author: dcubed Date: 2010-07-21 16:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d899526a187a 6941287: 4/4 jrunscriptTest.sh test does not work right under Cygwin Summary: Add golden_diff variable for doing proper golden file diffs on Cygwin. Reviewed-by: ohair, dholmes ! test/sun/tools/jrunscript/common.sh ! test/sun/tools/jrunscript/jrunscript-eTest.sh ! test/sun/tools/jrunscript/jrunscript-fTest.sh ! test/sun/tools/jrunscript/jrunscriptTest.sh Changeset: 946236dc5c96 Author: dcubed Date: 2010-07-21 16:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/946236dc5c96 6962804: 4/4 ShellScaffold tests can fail without a specific reason Summary: Add more diagnostics for failures. Only copy target file in grepForString when NL is missing. Reviewed-by: ohair, dholmes ! test/com/sun/jdi/ShellScaffold.sh Changeset: 9cb77130999f Author: dcubed Date: 2010-07-21 17:01 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9cb77130999f 6964018: 3/4 AnonLoggerWeakRefLeak and LoggerWeakRefLeak can fail in JPRT Summary: Refactor test/sun/tools/common/* code and refactor AnonLoggerWeakRefLeak and LoggerWeakRefLeak to use it. Reviewed-by: ohair, alanb ! test/java/util/logging/AnonLoggerWeakRefLeak.java ! test/java/util/logging/AnonLoggerWeakRefLeak.sh ! test/java/util/logging/LoggerWeakRefLeak.java ! test/java/util/logging/LoggerWeakRefLeak.sh ! test/sun/tools/common/ApplicationSetup.sh ! test/sun/tools/common/CommonSetup.sh + test/sun/tools/common/CommonTests.sh ! test/sun/tools/common/ShutdownSimpleApplication.java ! test/sun/tools/common/SimpleApplication.java + test/sun/tools/common/SleeperApplication.java ! test/sun/tools/jhat/ParseTest.sh ! test/sun/tools/jinfo/Basic.sh ! test/sun/tools/jmap/Basic.sh ! test/sun/tools/jstack/Basic.sh From jonathan.gibbons at oracle.com Thu Jul 22 11:03:33 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 22 Jul 2010 18:03:33 +0000 Subject: hg: jdk7/tl/langtools: 6968063: provide examples of code that generate diagnostics Message-ID: <20100722180335.8045E47BA3@hg.openjdk.java.net> Changeset: 3640b60bd0f6 Author: jjg Date: 2010-07-22 11:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3640b60bd0f6 6968063: provide examples of code that generate diagnostics Reviewed-by: mcimadamore ! make/build.xml + test/tools/javac/diags/CheckExamples.java + test/tools/javac/diags/Example.java + test/tools/javac/diags/FileManager.java + test/tools/javac/diags/HTMLWriter.java + test/tools/javac/diags/README.examples.txt + test/tools/javac/diags/RunExamples.java + test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/AbstractCantBeAccessed.java + test/tools/javac/diags/examples/AbstractCantBeInstantiated.java + test/tools/javac/diags/examples/AbstractMethodCantHaveBody.java + test/tools/javac/diags/examples/AlreadyDefined.java + test/tools/javac/diags/examples/AlreadyDefinedImport.java + test/tools/javac/diags/examples/AlreadyDefinedStaticImport/AlreadDefinedStaticImport.java + test/tools/javac/diags/examples/AlreadyDefinedStaticImport/p/E1.java + test/tools/javac/diags/examples/AlreadyDefinedStaticImport/p/E2.java + test/tools/javac/diags/examples/AnnoNotApplicable.java + test/tools/javac/diags/examples/AnnoNotValidForType.java + test/tools/javac/diags/examples/AnnoValueMustBeAnnotation.java + test/tools/javac/diags/examples/AnnoValueMustBeClassLiteral.java + test/tools/javac/diags/examples/AnnosWithoutProcessors/AnnosWithoutProcessors.java + test/tools/javac/diags/examples/AnnosWithoutProcessors/processors/AnnoProc.java + test/tools/javac/diags/examples/AnnotationMissingValue.java + test/tools/javac/diags/examples/AnnotationMustBeNameValue.java + test/tools/javac/diags/examples/AnnotationsNotSupported.java + test/tools/javac/diags/examples/AnonClassImplInterfaceNoArgs.java + test/tools/javac/diags/examples/AnonClassImplInterfaceNoQualForNew.java + test/tools/javac/diags/examples/AnonClassImplInterfaceNoTypeArgs.java + test/tools/javac/diags/examples/AnonymousClass.java + test/tools/javac/diags/examples/ArrayAndVarargs.java + test/tools/javac/diags/examples/ArrayDimMissing.java + test/tools/javac/diags/examples/ArrayRequired.java + test/tools/javac/diags/examples/AssertAsIdentifier.java + test/tools/javac/diags/examples/AssertAsIdentifier2.java + test/tools/javac/diags/examples/AttrMustBeConstant.java + test/tools/javac/diags/examples/BadSourceFileHeader/BadSourceFileHeader.java + test/tools/javac/diags/examples/BadSourceFileHeader/sourcepath/p/A.java + test/tools/javac/diags/examples/BreakOutsideSwitchLoop.java + test/tools/javac/diags/examples/CallMustBeFirst.java + test/tools/javac/diags/examples/CannotCreateArrayWithTypeArgs.java + test/tools/javac/diags/examples/CantApplyDiamond.java + test/tools/javac/diags/examples/CantAssignToFinal.java + test/tools/javac/diags/examples/CantDeref.java + test/tools/javac/diags/examples/CantExtendIntfAnno.java + test/tools/javac/diags/examples/CantImplement.java + test/tools/javac/diags/examples/CantInheritDiffArg.java + test/tools/javac/diags/examples/CantRefBeforeConstr.java + test/tools/javac/diags/examples/CantResolve.java + test/tools/javac/diags/examples/CantResolveArgs.java + test/tools/javac/diags/examples/CantResolveArgsParams.java + test/tools/javac/diags/examples/CantResolveLocation.java + test/tools/javac/diags/examples/CantResolveLocationArgs.java + test/tools/javac/diags/examples/CantResolveLocationArgsParams.java + test/tools/javac/diags/examples/CantReturnValueForVoid.java + test/tools/javac/diags/examples/CatchWithoutTry.java + test/tools/javac/diags/examples/ClashesWith.java + test/tools/javac/diags/examples/ClassCantWrite.java + test/tools/javac/diags/examples/ClassPublicInFile.java + test/tools/javac/diags/examples/ConcreteInheritanceConflict.java + test/tools/javac/diags/examples/ConstExprRequired.java + test/tools/javac/diags/examples/ConstantSVUID.java + test/tools/javac/diags/examples/ContinueOutsideLoop.java + test/tools/javac/diags/examples/CountError.java + test/tools/javac/diags/examples/CountErrorPlural.java + test/tools/javac/diags/examples/CountWarn.java + test/tools/javac/diags/examples/CountWarnPlural.java + test/tools/javac/diags/examples/CyclicAnnoElement.java + test/tools/javac/diags/examples/CyclicInheritance.java + test/tools/javac/diags/examples/DefaultAllowedInIntfAnnotationMember.java + test/tools/javac/diags/examples/DeprecatedFilename.java + test/tools/javac/diags/examples/DeprecatedFilenameAdditional.java + test/tools/javac/diags/examples/DeprecatedPlural/DeprecatedClass.java + test/tools/javac/diags/examples/DeprecatedPlural/DeprecatedFilename.java + test/tools/javac/diags/examples/DeprecatedPlural/DeprecatedPlural.java + test/tools/javac/diags/examples/DeprecatedPluralAdditional/DeprecatedClass.java + test/tools/javac/diags/examples/DeprecatedPluralAdditional/DeprecatedFilename.java + test/tools/javac/diags/examples/DeprecatedPluralAdditional/DeprecatedPlural.java + test/tools/javac/diags/examples/DeprecatedPluralAdditional/DeprecatedPluralAdditional.java + test/tools/javac/diags/examples/DiamondInvalidArg.java + test/tools/javac/diags/examples/DiamondInvalidArgs.java + test/tools/javac/diags/examples/DiamondNotSupported.java + test/tools/javac/diags/examples/DirPathElementNotFound.java + test/tools/javac/diags/examples/DivZero.java + test/tools/javac/diags/examples/DoesNotOverride.java + test/tools/javac/diags/examples/DoesntExist.java + test/tools/javac/diags/examples/DotClassExpected.java + test/tools/javac/diags/examples/DuplicateAnnotation.java + test/tools/javac/diags/examples/DuplicateAnnotationMemberValue.java + test/tools/javac/diags/examples/DuplicateCaseLabel.java + test/tools/javac/diags/examples/DuplicateClass.java + test/tools/javac/diags/examples/DuplicateDefaultLabel.java + test/tools/javac/diags/examples/ElseWithoutIf.java + test/tools/javac/diags/examples/EmptyBytecodeIdent.java + test/tools/javac/diags/examples/EmptyCharLiteral.java + test/tools/javac/diags/examples/EmptyIf.java + test/tools/javac/diags/examples/EnclClassRequired.java + test/tools/javac/diags/examples/EnumAnnoValueMustBeEnumConst.java + test/tools/javac/diags/examples/EnumAsIdentifier.java + test/tools/javac/diags/examples/EnumAsIdentifier2.java + test/tools/javac/diags/examples/EnumCantBeInstantiated.java + test/tools/javac/diags/examples/EnumConstRequired.java + test/tools/javac/diags/examples/EnumLabelUnqualified.java + test/tools/javac/diags/examples/EnumNoFinalize.java + test/tools/javac/diags/examples/EnumNoSubclassing.java + test/tools/javac/diags/examples/EnumTypesNotExtensible.java + test/tools/javac/diags/examples/EnumsMustBeStatic.java + test/tools/javac/diags/examples/EnumsNotSupported.java + test/tools/javac/diags/examples/ErrProcMessager/ErrProcMessager.java + test/tools/javac/diags/examples/ErrProcMessager/processors/AnnoProc.java + test/tools/javac/diags/examples/ErrSyntheticNameConflict.java + test/tools/javac/diags/examples/Error.java + test/tools/javac/diags/examples/ErrorReadingFile.java + test/tools/javac/diags/examples/ExceptAlreadyCaught.java + test/tools/javac/diags/examples/ExceptNeverThrown.java + test/tools/javac/diags/examples/Expected2.java + test/tools/javac/diags/examples/Expected3.java + test/tools/javac/diags/examples/FinalParamCantBeAssigned.java + test/tools/javac/diags/examples/FinallyCannotComplete.java + test/tools/javac/diags/examples/FinallyWithoutTry.java + test/tools/javac/diags/examples/FloatNumberTooLarge.java + test/tools/javac/diags/examples/FloatNumberTooSmall.java + test/tools/javac/diags/examples/ForeachNotApplicable.java + test/tools/javac/diags/examples/ForeachNotSupported.java + test/tools/javac/diags/examples/GenericArrayCreation.java + test/tools/javac/diags/examples/GenericThrowable.java + test/tools/javac/diags/examples/GenericsNotSupported.java + test/tools/javac/diags/examples/HasBeenDeprecated.java + test/tools/javac/diags/examples/IdentifierExpected.java + test/tools/javac/diags/examples/IllegalBytecodeIdentChar.java + test/tools/javac/diags/examples/IllegalChar.java + test/tools/javac/diags/examples/IllegalComboModifiers.java + test/tools/javac/diags/examples/IllegalEnumStaticRef.java + test/tools/javac/diags/examples/IllegalEscapeChar.java + test/tools/javac/diags/examples/IllegalForwardRef.java + test/tools/javac/diags/examples/IllegalInitializer.java + test/tools/javac/diags/examples/IllegalLineEndInCharLit.java + test/tools/javac/diags/examples/IllegalNonAsciiDigit.java + test/tools/javac/diags/examples/IllegalQualNotIcls.java + test/tools/javac/diags/examples/IllegalSelfRef.java + test/tools/javac/diags/examples/IllegalStartOfExpr.java + test/tools/javac/diags/examples/IllegalUnderscore.java + test/tools/javac/diags/examples/IllegalUnicodeEscape.java + test/tools/javac/diags/examples/ImportRequiresCanonical/ImportRequiresCanonical.java + test/tools/javac/diags/examples/ImportRequiresCanonical/p/Base.java + test/tools/javac/diags/examples/ImportRequiresCanonical/p/ExtendsBase.java + test/tools/javac/diags/examples/ImproperSVUID.java + test/tools/javac/diags/examples/ImproperTypeInnerRawParam.java + test/tools/javac/diags/examples/ImproperTypeParamMissing.java + test/tools/javac/diags/examples/IncomparableTypes.java + test/tools/javac/diags/examples/IncompatibleTypes1.java + test/tools/javac/diags/examples/InconvertibleTypes.java + test/tools/javac/diags/examples/InexactVarargsCall.java + test/tools/javac/diags/examples/InferredDoNotConformToBounds.java + test/tools/javac/diags/examples/InheritFromFinal.java + test/tools/javac/diags/examples/InitializerMustComplete.java + test/tools/javac/diags/examples/InnerClassCantHaveStatic.java + test/tools/javac/diags/examples/IntNumberTooLarge.java + test/tools/javac/diags/examples/InterfaceExpected.java + test/tools/javac/diags/examples/InterfaceNotAllowed.java + test/tools/javac/diags/examples/IntfAnnotationCantHaveTypeParams.java + test/tools/javac/diags/examples/IntfAnnotationMemberClash.java + test/tools/javac/diags/examples/IntfAnnotationsCantHaveParams.java + test/tools/javac/diags/examples/IntfAnnotationsCantHaveTypeParams.java + test/tools/javac/diags/examples/IntfMethodCantHaveBody.java + test/tools/javac/diags/examples/InvalidAnnoMemberType.java + test/tools/javac/diags/examples/InvalidBinaryNumber.java + test/tools/javac/diags/examples/InvalidHexNumber.java + test/tools/javac/diags/examples/InvalidInferredTypes.java + test/tools/javac/diags/examples/InvalidInstanceof.java + test/tools/javac/diags/examples/InvalidMethodDecl.java + test/tools/javac/diags/examples/KindnameClass.java + test/tools/javac/diags/examples/KindnameConstructor.java + test/tools/javac/diags/examples/KindnameMethod.java + test/tools/javac/diags/examples/KindnameVariable.java + test/tools/javac/diags/examples/LabelInUse.java + test/tools/javac/diags/examples/LocalEnum.java + test/tools/javac/diags/examples/LocalVarNeedsFinal.java + test/tools/javac/diags/examples/LongSVUID.java + test/tools/javac/diags/examples/MalformedFpLit.java + test/tools/javac/diags/examples/MalformedSupported/MalformedSupported.java + test/tools/javac/diags/examples/MalformedSupported/processors/AnnoProc.java + test/tools/javac/diags/examples/MethodDoesNotOverride.java + test/tools/javac/diags/examples/MightBeAssignedInLoop.java + test/tools/javac/diags/examples/MissingDeprecatedAnnotation.java + test/tools/javac/diags/examples/MissingMethodBody.java + test/tools/javac/diags/examples/MissingReturnStatement.java + test/tools/javac/diags/examples/MissingReturnValue.java + test/tools/javac/diags/examples/MissingSVUID.java + test/tools/javac/diags/examples/ModifierNotAllowed.java + test/tools/javac/diags/examples/MulticatchCantBeAssigned.java + test/tools/javac/diags/examples/MulticatchMustBeFinal.java + test/tools/javac/diags/examples/MulticatchNotSupported.java + test/tools/javac/diags/examples/NameClashSameErasure.java + test/tools/javac/diags/examples/NameClashSameErasureNoOverride.java + test/tools/javac/diags/examples/NativeMethodCantHaveBody.java + test/tools/javac/diags/examples/NeitherConditionalSubtype.java + test/tools/javac/diags/examples/NewNotAllowedInAnno.java + test/tools/javac/diags/examples/NoArgs.java + test/tools/javac/diags/examples/NoExplicitAnnoProcRequested.java + test/tools/javac/diags/examples/NoInterfaceExpected.java + test/tools/javac/diags/examples/NoInterfaceHere.java + test/tools/javac/diags/examples/NoJavaLang.java + test/tools/javac/diags/examples/NoSuperclass.java + test/tools/javac/diags/examples/NonStaticCantBeRef.java + test/tools/javac/diags/examples/NotDefAccessClassIntfCantAccess/NotDefAccessClassIntfCantAccess.java + test/tools/javac/diags/examples/NotDefAccessClassIntfCantAccess/p/C.java + test/tools/javac/diags/examples/NotDefPublicCantAccess/NotDefPublicCantAccess.java + test/tools/javac/diags/examples/NotDefPublicCantAccess/p/C.java + test/tools/javac/diags/examples/NotEnclClass.java + test/tools/javac/diags/examples/NotLoopLabel.java + test/tools/javac/diags/examples/NotWithinBounds.java + test/tools/javac/diags/examples/Note.java + test/tools/javac/diags/examples/NoteProcMessager/NoteProcMessager.java + test/tools/javac/diags/examples/NoteProcMessager/processors/AnnoProc.java + test/tools/javac/diags/examples/OperatorCantBeApplied.java + test/tools/javac/diags/examples/Orphaned.java + test/tools/javac/diags/examples/OverrideDoesntThrow.java + test/tools/javac/diags/examples/OverrideIncompatibleReturn.java + test/tools/javac/diags/examples/OverrideMeth.java + test/tools/javac/diags/examples/OverrideStatic.java + test/tools/javac/diags/examples/OverrideUncheckedReturn.java + test/tools/javac/diags/examples/OverrideUncheckedThrown.java + test/tools/javac/diags/examples/OverrideVarargsExtra.java + test/tools/javac/diags/examples/OverrideVarargsMissing.java + test/tools/javac/diags/examples/OverrideWeakerAccess.java + test/tools/javac/diags/examples/PackageAnnos.java + test/tools/javac/diags/examples/PackageInfoAlreadySeen/p/package-info.java + test/tools/javac/diags/examples/PackageInfoAlreadySeen/package-info.java + test/tools/javac/diags/examples/PathElementNotFound.java + test/tools/javac/diags/examples/PkgClashWithClass/p/q.java + test/tools/javac/diags/examples/PkgClashWithClass/p/q/C.java + test/tools/javac/diags/examples/PossibleFallThrough.java + test/tools/javac/diags/examples/PossibleLossPrecision.java + test/tools/javac/diags/examples/PrematureEOF.java + test/tools/javac/diags/examples/PrintProcessorInfo/PrintProcessorInfo.java + test/tools/javac/diags/examples/PrintProcessorInfo/processors/AnnoProc.java + test/tools/javac/diags/examples/PrintRounds/PrintRounds.java + test/tools/javac/diags/examples/PrintRounds/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcCantFindClass/ProcCantFindClass.java + test/tools/javac/diags/examples/ProcCantFindClass/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcFileReopening/ProcFileReopening.java + test/tools/javac/diags/examples/ProcFileReopening/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcIllegalFileName/ProcIllegalFileName.java + test/tools/javac/diags/examples/ProcIllegalFileName/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcIncompatibleSourceVersion/ProcIncompatibleSourceVersion.java + test/tools/javac/diags/examples/ProcIncompatibleSourceVersion/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcOnlyNoProcs.java + test/tools/javac/diags/examples/ProcPackageDoesNotExist/ProcPackageDoesNotExist.java + test/tools/javac/diags/examples/ProcPackageDoesNotExist/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcTypeRecreate/ProcTypeRecreate.java + test/tools/javac/diags/examples/ProcTypeRecreate/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcUnclosedTypeFiles/ProcUnclosedTypeFiles.java + test/tools/javac/diags/examples/ProcUnclosedTypeFiles/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcUseImplicit/ProcUseImplicit.java + test/tools/javac/diags/examples/ProcUseImplicit/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcUseImplicit/sourcepath/p/SomeClass.java + test/tools/javac/diags/examples/ProcUseProcOrImplicit/ProcUseProcOrImplicit.java + test/tools/javac/diags/examples/ProcUseProcOrImplicit/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcUseProcOrImplicit/sourcepath/p/SomeClass.java + test/tools/javac/diags/examples/ProcessorCantInstantiate/ProcessorCantInstantiate.java + test/tools/javac/diags/examples/ProcessorCantInstantiate/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcessorNotFound.java + test/tools/javac/diags/examples/ProcessorWrongType/ProcessorWrongType.java + test/tools/javac/diags/examples/ProcessorWrongType/processors/AnnoProc.java + test/tools/javac/diags/examples/QualifiedNewStaticClass.java + test/tools/javac/diags/examples/RawClassUse.java + test/tools/javac/diags/examples/RecursiveConstrInvocation.java + test/tools/javac/diags/examples/RedundantCast.java + test/tools/javac/diags/examples/RefAmbiguous.java + test/tools/javac/diags/examples/RepeatedAnnotationTarget.java + test/tools/javac/diags/examples/RepeatedInterface.java + test/tools/javac/diags/examples/RepeatedModifier.java + test/tools/javac/diags/examples/ReportAccess.java + test/tools/javac/diags/examples/ResourceClosed.java + test/tools/javac/diags/examples/ResourceMayNotBeAssigned.java + test/tools/javac/diags/examples/ResourceNotApplicableToType.java + test/tools/javac/diags/examples/ResourceNotReferenced.java + test/tools/javac/diags/examples/ReturnOutsideMethod.java + test/tools/javac/diags/examples/StaticImportNotSupported.java + test/tools/javac/diags/examples/StaticImportOnlyClassesAndInterfaces/Other.java + test/tools/javac/diags/examples/StaticImportOnlyClassesAndInterfaces/StaticImportOnlyClassesAndInterfaces.java + test/tools/javac/diags/examples/StaticNotQualifiedByType.java + test/tools/javac/diags/examples/StringConstRequired.java + test/tools/javac/diags/examples/StringSwitchNotSupported.java + test/tools/javac/diags/examples/SunApiFilename.java + test/tools/javac/diags/examples/SunApiFilenameAdditional.java + test/tools/javac/diags/examples/SunApiPlural/SunApiFilename.java + test/tools/javac/diags/examples/SunApiPlural/SunApiPlural.java + test/tools/javac/diags/examples/SunApiPluralAdditional/SunApiFilename.java + test/tools/javac/diags/examples/SunApiPluralAdditional/SunApiPlural.java + test/tools/javac/diags/examples/SunApiPluralAdditional/SunApiPluralAdditional.java + test/tools/javac/diags/examples/SunProprietary.java + test/tools/javac/diags/examples/SuperNotAllowedInEnum.java + test/tools/javac/diags/examples/ThrowsNotAllowedInAnno.java + test/tools/javac/diags/examples/TryResourceNotSupported.java + test/tools/javac/diags/examples/TryWithoutCatchOrFinally.java + test/tools/javac/diags/examples/TryWithoutCatchOrFinallyOrResource.java + test/tools/javac/diags/examples/TypeAnnotationsNotSupported.java + test/tools/javac/diags/examples/TypeFoundRequired.java + test/tools/javac/diags/examples/TypeNoParams.java + test/tools/javac/diags/examples/TypeReqClassArray.java + test/tools/javac/diags/examples/TypeReqRef.java + test/tools/javac/diags/examples/TypeVarCantBeDeref.java + test/tools/javac/diags/examples/TypeVarMayNotBeFollowedByOtherBounds.java + test/tools/javac/diags/examples/TypesIncompatible.java + test/tools/javac/diags/examples/UncheckedAssign.java + test/tools/javac/diags/examples/UncheckedAssignToVar.java + test/tools/javac/diags/examples/UncheckedCall.java + test/tools/javac/diags/examples/UncheckedCast.java + test/tools/javac/diags/examples/UncheckedClash.java + test/tools/javac/diags/examples/UncheckedFilename.java + test/tools/javac/diags/examples/UncheckedFilenameAdditional.java + test/tools/javac/diags/examples/UncheckedGenericArrayCreation.java + test/tools/javac/diags/examples/UncheckedImplement.java + test/tools/javac/diags/examples/UncheckedMethodInvocation.java + test/tools/javac/diags/examples/UncheckedPlural/UncheckedFilename.java + test/tools/javac/diags/examples/UncheckedPlural/UncheckedPlural.java + test/tools/javac/diags/examples/UncheckedPluralAdditional/UncheckedFilename1.java + test/tools/javac/diags/examples/UncheckedPluralAdditional/UncheckedFilename2.java + test/tools/javac/diags/examples/UncheckedPluralAdditional/UncheckedPluralAdditional.java + test/tools/javac/diags/examples/UnclosedBytecodeIdent.java + test/tools/javac/diags/examples/UnclosedCharLiteral.java + test/tools/javac/diags/examples/UnclosedComment.java + test/tools/javac/diags/examples/UnclosedStringLiteral.java + test/tools/javac/diags/examples/UndefinedLabel.java + test/tools/javac/diags/examples/UndeterminedType1.java + test/tools/javac/diags/examples/UnmatchedProcessorOptions/UnmatchedProcessorOptions.java + test/tools/javac/diags/examples/UnmatchedProcessorOptions/processors/AnnoProc.java + test/tools/javac/diags/examples/UnnamedPackage.java + test/tools/javac/diags/examples/UnreachableStatement.java + test/tools/javac/diags/examples/UnreportedException.java + test/tools/javac/diags/examples/UnreportedExceptionDefaultConstructor.java + test/tools/javac/diags/examples/UnsupportedBinaryLiteral.java + test/tools/javac/diags/examples/UnsupportedEncoding.java + test/tools/javac/diags/examples/UnsupportedFpLit.java + test/tools/javac/diags/examples/UnsupportedUnderscoreLiteral.java + test/tools/javac/diags/examples/VarMightAlreadyBeAssigned.java + test/tools/javac/diags/examples/VarMightNotHaveBeenInitialized.java + test/tools/javac/diags/examples/VarargsClash.java + test/tools/javac/diags/examples/VarargsFilename.java + test/tools/javac/diags/examples/VarargsFilenameAdditional.java + test/tools/javac/diags/examples/VarargsImplement.java + test/tools/javac/diags/examples/VarargsNonReifiableType.java + test/tools/javac/diags/examples/VarargsNotSupported.java + test/tools/javac/diags/examples/VarargsOverride.java + test/tools/javac/diags/examples/VarargsPlural/VarargsFilename.java + test/tools/javac/diags/examples/VarargsPlural/VarargsPlural.java + test/tools/javac/diags/examples/VarargsPluralAdditional/VarargsFilename.java + test/tools/javac/diags/examples/VarargsPluralAdditional/VarargsPlural.java + test/tools/javac/diags/examples/VarargsPluralAdditional/VarargsPluralAdditional.java + test/tools/javac/diags/examples/Verbose.java + test/tools/javac/diags/examples/VoidNotAllowed.java + test/tools/javac/diags/examples/WarnForwardRef.java + test/tools/javac/diags/examples/WarnProcMessager/WarnProcMessager.java + test/tools/javac/diags/examples/WarnProcMessager/processors/AnnoProc.java + test/tools/javac/diags/examples/WarnSelfRef.java + test/tools/javac/diags/examples/WarnSyntheticNameConflict.java + test/tools/javac/diags/examples/WarningAndWerror.java + test/tools/javac/diags/examples/WhereCaptured.java + test/tools/javac/diags/examples/WhereCaptured1.java + test/tools/javac/diags/examples/WhereIntersection.java + test/tools/javac/diags/examples/WhereTypeVar.java + test/tools/javac/diags/examples/WrongNumberTypeArgs.java From vincent.x.ryan at oracle.com Fri Jul 23 09:41:36 2010 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Fri, 23 Jul 2010 16:41:36 +0000 Subject: hg: jdk7/tl/jdk: 6676075: RegistryContext (com.sun.jndi.url.rmi.rmiURLContext) coding problem Message-ID: <20100723164145.8FF9A47BF7@hg.openjdk.java.net> Changeset: 748f004aeb5c Author: vinnie Date: 2010-07-23 17:41 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/748f004aeb5c 6676075: RegistryContext (com.sun.jndi.url.rmi.rmiURLContext) coding problem Reviewed-by: mullan ! src/share/classes/com/sun/jndi/rmi/registry/RegistryContext.java + test/com/sun/jndi/rmi/registry/RegistryContext/ContextWithNullProperties.java From xuelei.fan at sun.com Sat Jul 24 08:50:07 2010 From: xuelei.fan at sun.com (xuelei.fan at sun.com) Date: Sat, 24 Jul 2010 15:50:07 +0000 Subject: hg: jdk7/tl/jdk: 6867345: Turkish regional options cause NPE in sun.security.x509.AlgorithmId.algOID Message-ID: <20100724155038.B868B47C36@hg.openjdk.java.net> Changeset: 56217857ccd7 Author: xuelei Date: 2010-07-24 22:59 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/56217857ccd7 6867345: Turkish regional options cause NPE in sun.security.x509.AlgorithmId.algOID Reviewed-by: mullan, weijun ! src/share/classes/sun/security/krb5/Credentials.java ! src/share/classes/sun/security/pkcs/PKCS9Attribute.java ! src/share/classes/sun/security/pkcs11/P11Cipher.java ! src/share/classes/sun/security/pkcs11/P11RSACipher.java ! src/share/classes/sun/security/provider/certpath/URICertStore.java ! src/share/classes/sun/security/util/Debug.java ! src/share/classes/sun/security/x509/AVA.java ! src/share/classes/sun/security/x509/AlgorithmId.java ! src/share/classes/sun/security/x509/DNSName.java ! src/share/classes/sun/security/x509/RFC822Name.java + test/sun/security/x509/AlgorithmId/TurkishRegion.java From Weijun.Wang at Sun.COM Sun Jul 25 23:04:44 2010 From: Weijun.Wang at Sun.COM (Weijun Wang) Date: Mon, 26 Jul 2010 14:04:44 +0800 Subject: Fwd: CR 6972005 Created, P4 jgss/krb5plugin ConfPlusProp.java test failure when DNS has info for realm Message-ID: <4C4D257C.9010108@sun.com> Hi Xuelei A regression in test: *Change Request ID*: 6972005 *Synopsis*: ConfPlusProp.java test failure when DNS has info for realm webrev: http://cr.openjdk.java.net/~weijun/6972005/webrev.00/ Thanks Max === *Description* ============================================================ The ConfPlusProp.java test checks if the default realm is null when it's not specified in krb5.conf. However, after 6969292, Kerberos can get default realm from DNS. The test fails. *** (#1 of 1): 2010-07-26 05:55:28 GMT+00:00 weijun.wang at sun.com === *Evaluation* ============================================================= There are several places in the test to check if default realm is null. In the first two cases, a krb5.conf exists, we can add dns_lookup_realm = false there. In the 3rd case, there's no krb5.conf, and we have to ignore the check. *** (#1 of 1): 2010-07-26 05:55:29 GMT+00:00 weijun.wang at sun.com *** Last Edit: 2010-07-26 05:56:42 GMT+00:00 weijun.wang at sun.com Thanks Max From Xuelei.Fan at Sun.COM Mon Jul 26 01:59:08 2010 From: Xuelei.Fan at Sun.COM (Xuelei Fan) Date: Mon, 26 Jul 2010 16:59:08 +0800 Subject: Fwd: CR 6972005 Created, P4 jgss/krb5plugin ConfPlusProp.java test failure when DNS has info for realm In-Reply-To: <4C4D257C.9010108@sun.com> References: <4C4D257C.9010108@sun.com> Message-ID: <4C4D4E5C.6040107@Sun.COM> looks fine to me. Xuelei On 7/26/2010 2:04 PM, Weijun Wang wrote: > Hi Xuelei > > A regression in test: > > *Change Request ID*: 6972005 > *Synopsis*: ConfPlusProp.java test failure when DNS has info for realm > > webrev: > http://cr.openjdk.java.net/~weijun/6972005/webrev.00/ > > Thanks > Max > > === *Description* > ============================================================ > The ConfPlusProp.java test checks if the default realm is null when it's > not specified in krb5.conf. However, after 6969292, Kerberos can get > default realm from DNS. The test fails. > > *** (#1 of 1): 2010-07-26 05:55:28 GMT+00:00 weijun.wang at sun.com > > === *Evaluation* > ============================================================= > There are several places in the test to check if default realm is null. > > In the first two cases, a krb5.conf exists, we can add dns_lookup_realm > = false there. In the 3rd case, there's no krb5.conf, and we have to > ignore the check. > > *** (#1 of 1): 2010-07-26 05:55:29 GMT+00:00 weijun.wang at sun.com > *** Last Edit: 2010-07-26 05:56:42 GMT+00:00 weijun.wang at sun.com > > Thanks > Max > From weijun.wang at sun.com Mon Jul 26 02:22:52 2010 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Mon, 26 Jul 2010 09:22:52 +0000 Subject: hg: jdk7/tl/jdk: 6972005: ConfPlusProp.java test failure when DNS has info for realm Message-ID: <20100726092335.790C247C8A@hg.openjdk.java.net> Changeset: 402ff3e81922 Author: weijun Date: 2010-07-26 17:21 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/402ff3e81922 6972005: ConfPlusProp.java test failure when DNS has info for realm Reviewed-by: xuelei ! test/sun/security/krb5/ConfPlusProp.java ! test/sun/security/krb5/confplusprop.conf ! test/sun/security/krb5/confplusprop2.conf From martinrb at google.com Mon Jul 26 08:21:14 2010 From: martinrb at google.com (martinrb at google.com) Date: Mon, 26 Jul 2010 15:21:14 +0000 Subject: hg: jdk7/tl/jdk: 6717780: (coll spec) LinkedList api documentation provides the wrong method name Message-ID: <20100726152154.F3E9747C97@hg.openjdk.java.net> Changeset: db21b420d038 Author: martin Date: 2010-07-26 08:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db21b420d038 6717780: (coll spec) LinkedList api documentation provides the wrong method name Summary: Cleanup by simply making Deque equal status with List Reviewed-by: darcy ! src/share/classes/java/util/LinkedList.java From jonathan.gibbons at oracle.com Mon Jul 26 14:20:19 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 26 Jul 2010 21:20:19 +0000 Subject: hg: jdk7/tl/langtools: 6971882: Remove -XDstdout from javac test Message-ID: <20100726212021.A24C447CA5@hg.openjdk.java.net> Changeset: 4172cfff05f0 Author: jjg Date: 2010-07-26 14:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4172cfff05f0 6971882: Remove -XDstdout from javac test Reviewed-by: darcy ! test/tools/javac/4980495/static/Test.java ! test/tools/javac/4980495/std/Test.java ! test/tools/javac/6304921/T6304921.java ! test/tools/javac/6330920/T6330920.java ! test/tools/javac/6491592/T6491592.java ! test/tools/javac/6717241/T6717241a.java ! test/tools/javac/6717241/T6717241b.java ! test/tools/javac/ClassFileModifiers/ClassModifiers.java ! test/tools/javac/ClassFileModifiers/MemberModifiers.java ! test/tools/javac/CyclicInheritance.java ! test/tools/javac/Digits.java ! test/tools/javac/ExtendArray.java ! test/tools/javac/ExtendsAccess/ExtendsAccess.java ! test/tools/javac/FloatingPointChanges/BadConstructorModifiers.java ! test/tools/javac/IllegalAnnotation.java ! test/tools/javac/InnerNamedConstant_2.java ! test/tools/javac/InterfaceMemberClassModifiers.java ! test/tools/javac/LocalClasses_2.java ! test/tools/javac/NameCollision.java ! test/tools/javac/NestedInnerClassNames.java ! test/tools/javac/NonStaticFieldExpr1.java ! test/tools/javac/NonStaticFieldExpr2.java ! test/tools/javac/NonStaticFieldExpr3.java ! test/tools/javac/OverridePosition.java ! test/tools/javac/QualifiedAccess/QualifiedAccess_1.java ! test/tools/javac/QualifiedAccess/QualifiedAccess_2.java ! test/tools/javac/QualifiedAccess/QualifiedAccess_3.java ! test/tools/javac/StringsInSwitch/BadlyTypedLabel1.java ! test/tools/javac/StringsInSwitch/BadlyTypedLabel2.java ! test/tools/javac/StringsInSwitch/NonConstantLabel.java ! test/tools/javac/StringsInSwitch/RepeatedStringCaseLabels1.java ! test/tools/javac/StringsInSwitch/RepeatedStringCaseLabels2.java ! test/tools/javac/SynchronizedClass.java ! test/tools/javac/T4093617/T4093617.java ! test/tools/javac/T4906100.java ! test/tools/javac/T4994049/T4994049.java ! test/tools/javac/T5003235/T5003235a.java ! test/tools/javac/T5003235/T5003235b.java ! test/tools/javac/T5003235/T5003235c.java ! test/tools/javac/T5024091/T5024091.java ! test/tools/javac/T5048776.java ! test/tools/javac/T6214885.java ! test/tools/javac/T6224167.java ! test/tools/javac/T6227617.java ! test/tools/javac/T6230128.java ! test/tools/javac/T6231847.java ! test/tools/javac/T6241723.java ! test/tools/javac/T6245591.java ! test/tools/javac/T6247324.java ! test/tools/javac/T6394563.java ! test/tools/javac/annotations/6214965/T6214965.java ! test/tools/javac/annotations/6365854/T6365854.java ! test/tools/javac/danglingDep/DepX.java ! test/tools/javac/danglingDep/NoDepX.java ! test/tools/javac/danglingDep/Test1.java ! test/tools/javac/depDocComment/DeprecatedDocComment.java ! test/tools/javac/depDocComment/SuppressDeprecation.java ! test/tools/javac/depOverrides/annotation/Test1.java ! test/tools/javac/depOverrides/annotation/Test2.java ! test/tools/javac/depOverrides/annotation/Test3.java ! test/tools/javac/depOverrides/doccomment/Test1.java ! test/tools/javac/depOverrides/doccomment/Test2.java ! test/tools/javac/depOverrides/doccomment/Test3.java ! test/tools/javac/enum/6384542/T6384542.java ! test/tools/javac/enum/6384542/T6384542a.java ! test/tools/javac/enum/forwardRef/T6425594.java ! test/tools/javac/generics/5009937/T5009937.java ! test/tools/javac/generics/6207386/T6207386.java ! test/tools/javac/generics/6359951/T6359951.java ! test/tools/javac/generics/6677785/T6677785.java ! test/tools/javac/generics/6723444/T6723444.java ! test/tools/javac/generics/inference/6611449/T6611449.java ! test/tools/javac/generics/inference/6718364/T6718364.java ! test/tools/javac/generics/wildcards/6437894/T6437894.java ! test/tools/javac/lint/NoWarn.java ! test/tools/javac/mandatoryWarnings/deprecated/Test.java ! test/tools/javac/mandatoryWarnings/unchecked/Test.java ! test/tools/javac/miranda/T4666866.java ! test/tools/javac/missingSuperRecovery/MissingSuperRecovery.java ! test/tools/javac/policy/test1/Test1a.java ! test/tools/javac/policy/test2/Test.java ! test/tools/javac/positions/T6253161.java ! test/tools/javac/positions/T6253161a.java ! test/tools/javac/positions/T6264029.java ! test/tools/javac/processing/messager/6362067/T6362067.java ! test/tools/javac/processing/warnings/TestSourceVersionWarnings.java ! test/tools/javac/protectedAccess/ProtectedMemberAccess2.java ! test/tools/javac/protectedAccess/ProtectedMemberAccess3.java ! test/tools/javac/protectedAccess/ProtectedMemberAccess4.java ! test/tools/javac/rawDiags/Error.java ! test/tools/javac/rawDiags/Note.java ! test/tools/javac/rawDiags/Warning.java ! test/tools/javac/unicode/UnicodeNewline.java ! test/tools/javac/warnings/Deprecation.java ! test/tools/javac/warnings/DivZero.java ! test/tools/javac/warnings/FallThrough.java ! test/tools/javac/warnings/Unchecked.java From jonathan.gibbons at oracle.com Mon Jul 26 14:26:05 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 26 Jul 2010 21:26:05 +0000 Subject: hg: jdk7/tl/langtools: 6957438: improve code for generating warning messages containing option names Message-ID: <20100726212607.01F5247CA6@hg.openjdk.java.net> Changeset: d1bd93028447 Author: jjg Date: 2010-07-26 14:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d1bd93028447 6957438: improve code for generating warning messages containing option names Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/file/Paths.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/AbstractLog.java ! src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/MandatoryWarningHandler.java ! test/tools/javac/diags/examples/CountWarn.java ! test/tools/javac/diags/examples/CountWarnPlural.java ! test/tools/javac/diags/examples/Error.java From daniel.daugherty at oracle.com Mon Jul 26 14:44:18 2010 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Mon, 26 Jul 2010 21:44:18 +0000 Subject: hg: jdk7/tl/jdk: 6971847: 4/4 jmap '-histo:live' option is necessary for proper leak detection Message-ID: <20100726214427.EA96F47CA7@hg.openjdk.java.net> Changeset: 1bfa1c864553 Author: dcubed Date: 2010-07-26 09:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1bfa1c864553 6971847: 4/4 jmap '-histo:live' option is necessary for proper leak detection Summary: Add work around for 6971851. Abort if 'histo:live' option isn't supported. Reviewed-by: alanb, darcy ! test/java/util/logging/AnonLoggerWeakRefLeak.sh ! test/java/util/logging/LoggerWeakRefLeak.sh From Xuelei.Fan at Sun.COM Mon Jul 26 20:50:55 2010 From: Xuelei.Fan at Sun.COM (Xuelei Fan) Date: Tue, 27 Jul 2010 11:50:55 +0800 Subject: code review request: CR 6870947 15 sec delay detecting "socket closed" condition when a TCP connection is reset by an LDAP server Message-ID: <4C4E579F.1090102@sun.com> Hi Weijun, A JNDI bug. webrev: http://cr.openjdk.java.net/~xuelei/6870947/webrev.00/ bug desc: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6870947 Thanks, Xuelei From Weijun.Wang at Sun.COM Tue Jul 27 00:19:27 2010 From: Weijun.Wang at Sun.COM (Weijun Wang) Date: Tue, 27 Jul 2010 15:19:27 +0800 Subject: code review request: CR 6870947 15 sec delay detecting "socket closed" condition when a TCP connection is reset by an LDAP server In-Reply-To: <4C4E579F.1090102@sun.com> References: <4C4E579F.1090102@sun.com> Message-ID: <4C4E887F.7070109@sun.com> Fix looks fine. I finally find the "ldr.wait(15 * 1000)" line. -Max On 07/27/2010 11:50 AM, Xuelei Fan wrote: > Hi Weijun, > > A JNDI bug. > > webrev: http://cr.openjdk.java.net/~xuelei/6870947/webrev.00/ > bug desc: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6870947 > > Thanks, > Xuelei From xuelei.fan at sun.com Tue Jul 27 01:16:19 2010 From: xuelei.fan at sun.com (xuelei.fan at sun.com) Date: Tue, 27 Jul 2010 08:16:19 +0000 Subject: hg: jdk7/tl/jdk: 6870947: 15 sec delay detecting "socket closed" condition when a TCP connection is reset by an LDAP server Message-ID: <20100727081628.A284B47CC0@hg.openjdk.java.net> Changeset: 83be262e654c Author: xuelei Date: 2010-07-27 16:07 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/83be262e654c 6870947: 15 sec delay detecting "socket closed" condition when a TCP connection is reset by an LDAP server Reviewed-by: weijun ! src/share/classes/com/sun/jndi/ldap/Connection.java From vincent.x.ryan at oracle.com Tue Jul 27 04:51:52 2010 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Tue, 27 Jul 2010 11:51:52 +0000 Subject: hg: jdk7/tl/jdk: 6972409: Cease emitting LDAP filter debug messages Message-ID: <20100727115223.4B9DE47CC8@hg.openjdk.java.net> Changeset: 5ff8b884a92c Author: vinnie Date: 2010-07-27 11:40 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5ff8b884a92c 6972409: Cease emitting LDAP filter debug messages Reviewed-by: xuelei ! src/share/classes/com/sun/jndi/ldap/Filter.java From jonathan.gibbons at oracle.com Tue Jul 27 11:33:18 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 27 Jul 2010 18:33:18 +0000 Subject: hg: jdk7/tl/langtools: 6972327: JCTree.pos incorrect for annotations without modifiers and package Message-ID: <20100727183322.5C4D247CD7@hg.openjdk.java.net> Changeset: b29160d1b3e0 Author: jjg Date: 2010-07-27 11:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b29160d1b3e0 6972327: JCTree.pos incorrect for annotations without modifiers and package Reviewed-by: mcimadamore Contributed-by: jan.lahoda at sun.com ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java + test/tools/javac/T6972327.java From jonathan.gibbons at oracle.com Tue Jul 27 11:52:20 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 27 Jul 2010 18:52:20 +0000 Subject: hg: jdk7/tl/langtools: 6403456: -Werror should work with annotation processing Message-ID: <20100727185222.557A547CD8@hg.openjdk.java.net> Changeset: ed354a00f76b Author: jjg Date: 2010-07-27 11:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ed354a00f76b 6403456: -Werror should work with annotation processing Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/processing/JavacMessager.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + test/tools/javac/processing/werror/WError1.java + test/tools/javac/processing/werror/WError1.out + test/tools/javac/processing/werror/WErrorGen.java + test/tools/javac/processing/werror/WErrorGen.out + test/tools/javac/processing/werror/WErrorLast.java + test/tools/javac/processing/werror/WErrorLast.out From alan.bateman at oracle.com Thu Jul 29 06:33:59 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 29 Jul 2010 13:33:59 +0000 Subject: hg: jdk7/tl/jdk: 6934977: (bf) MappedByteBuffer.load can SIGBUS if file is truncated; ... Message-ID: <20100729133443.2AFCA47D4C@hg.openjdk.java.net> Changeset: 24741c4bf300 Author: alanb Date: 2010-07-29 13:08 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/24741c4bf300 6934977: (bf) MappedByteBuffer.load can SIGBUS if file is truncated 6799037: (fs) MappedByteBuffer.load crash with unaligned file-mapping (sol) Reviewed-by: chegar, forax ! src/share/classes/java/nio/Bits.java ! src/share/classes/java/nio/MappedByteBuffer.java ! src/solaris/native/java/nio/MappedByteBuffer.c ! src/windows/native/java/nio/MappedByteBuffer.c ! test/java/nio/MappedByteBuffer/Basic.java + test/java/nio/MappedByteBuffer/Truncate.java From maurizio.cimadamore at oracle.com Thu Jul 29 08:10:31 2010 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 29 Jul 2010 15:10:31 +0000 Subject: hg: jdk7/tl/langtools: 3 new changesets Message-ID: <20100729151037.22B5847D56@hg.openjdk.java.net> Changeset: 36c4ec4525b4 Author: mcimadamore Date: 2010-07-29 15:56 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/36c4ec4525b4 6938454: Unable to determine generic type in program that compiles under Java 6 Summary: a redundant dubtyping check causes spurious inference failure Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/generics/inference/6938454/T6938454a.java + test/tools/javac/generics/inference/6938454/T6938454b.java Changeset: e79e8efe1b3e Author: mcimadamore Date: 2010-07-29 15:57 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e79e8efe1b3e 6972747: CheckExamples fail when assertions are enabled Summary: The test calls the wrong version of JavacMessage constructor Reviewed-by: jjg ! test/tools/javac/diags/Example.java Changeset: 62f3f07002ea Author: mcimadamore Date: 2010-07-29 15:57 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/62f3f07002ea 6970833: Try-with-resource implementation throws an NPE during Flow analysis Summary: Updated logic not to rely upon Symbol.implementation (which check in superinterfaces) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java + test/tools/javac/TryWithResources/ResourceInterface.java + test/tools/javac/TryWithResources/ResourceInterface.out From chris.hegarty at oracle.com Thu Jul 29 09:05:58 2010 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 29 Jul 2010 16:05:58 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20100729160641.ACD2247D59@hg.openjdk.java.net> Changeset: a8a79f5b669e Author: chegar Date: 2010-07-29 10:02 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a8a79f5b669e 6972374: NetworkInterface.getNetworkInterfaces throws "java.net.SocketException" on Solaris zone Reviewed-by: alanb, dsamersoff ! src/solaris/native/java/net/NetworkInterface.c Changeset: d82ed433304e Author: chegar Date: 2010-07-29 17:04 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d82ed433304e Merge From jonathan.gibbons at oracle.com Thu Jul 29 18:07:23 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 30 Jul 2010 01:07:23 +0000 Subject: hg: jdk7/tl/langtools: 6972556: warning for using a file name instead of a binary name for Filer.createSourceFile Message-ID: <20100730010726.CDE1847D82@hg.openjdk.java.net> Changeset: 4a7979c3ce15 Author: jjg Date: 2010-07-29 18:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4a7979c3ce15 6972556: warning for using a file name instead of a binary name for Filer.createSourceFile Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/processing/JavacFiler.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/ProcSuspiciousClassName/ProcSuspiciousClassName.java + test/tools/javac/diags/examples/ProcSuspiciousClassName/processors/AnnoProc.java From jonathan.gibbons at oracle.com Thu Jul 29 19:27:50 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 30 Jul 2010 02:27:50 +0000 Subject: hg: jdk7/tl/langtools: 6340549: javax.tools.JavaCompilerTool.getStandardFileManager().list() includes directories Message-ID: <20100730022752.CF61D47D86@hg.openjdk.java.net> Changeset: 8a5c98a695ae Author: jjg Date: 2010-07-29 19:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8a5c98a695ae 6340549: javax.tools.JavaCompilerTool.getStandardFileManager().list() includes directories Reviewed-by: darcy + test/tools/javac/T6340549.java From jonathan.gibbons at oracle.com Thu Jul 29 19:30:40 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 30 Jul 2010 02:30:40 +0000 Subject: hg: jdk7/tl/langtools: 6966604: JavacFiler not correctly notified of lastRound Message-ID: <20100730023042.5EB2E47D87@hg.openjdk.java.net> Changeset: 2cf925ad67ab Author: jjg Date: 2010-07-29 19:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2cf925ad67ab 6966604: JavacFiler not correctly notified of lastRound Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/processing/JavacFiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/ProcFileCreateLastRound/ProcFileCreateLastRound.java + test/tools/javac/diags/examples/ProcFileCreateLastRound/processors/AnnoProc.java + test/tools/javac/processing/filer/TestLastRound.java + test/tools/javac/processing/filer/TestLastRound.out ! test/tools/javac/processing/werror/WErrorGen.java From lana.steuck at oracle.com Thu Jul 29 23:15:51 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 30 Jul 2010 06:15:51 +0000 Subject: hg: jdk7/tl: 9 new changesets Message-ID: <20100730061551.DB28D47D96@hg.openjdk.java.net> Changeset: 3b147bf5a0e9 Author: lana Date: 2010-06-21 22:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/3b147bf5a0e9 Merge Changeset: b218a53ec7d3 Author: lana Date: 2010-06-29 22:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/b218a53ec7d3 Merge Changeset: 4193eaf5f1b8 Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/4193eaf5f1b8 Added tag jdk7-b100 for changeset b218a53ec7d3 ! .hgtags Changeset: 055626b50d2d Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/055626b50d2d Added tag jdk7-b101 for changeset 4193eaf5f1b8 ! .hgtags Changeset: 9cda7c220c08 Author: lana Date: 2010-07-12 19:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/9cda7c220c08 Merge Changeset: a136a51f5113 Author: lana Date: 2010-07-20 22:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/a136a51f5113 Merge Changeset: 86a3df41c0c7 Author: mikejwre Date: 2010-07-23 16:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/86a3df41c0c7 Added tag jdk7-b102 for changeset a136a51f5113 ! .hgtags Changeset: f1ba69da5003 Author: ohair Date: 2010-07-26 14:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/f1ba69da5003 6972274: Fix the use of egrep -ci in the top level makefile sanity checks Reviewed-by: prr ! make/sanity-rules.gmk Changeset: be2aedc4e3b1 Author: mikejwre Date: 2010-07-28 21:03 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/be2aedc4e3b1 Merge From lana.steuck at oracle.com Thu Jul 29 23:15:57 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 30 Jul 2010 06:15:57 +0000 Subject: hg: jdk7/tl/corba: 7 new changesets Message-ID: <20100730061601.A0C9647D97@hg.openjdk.java.net> Changeset: 8eeca6e452de Author: lana Date: 2010-06-21 22:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/8eeca6e452de Merge Changeset: a56d734a1e97 Author: lana Date: 2010-06-29 22:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/a56d734a1e97 Merge Changeset: 86a239832646 Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/86a239832646 Added tag jdk7-b100 for changeset a56d734a1e97 ! .hgtags Changeset: d130544adab3 Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/d130544adab3 Added tag jdk7-b101 for changeset 86a239832646 ! .hgtags Changeset: 98da66f47273 Author: lana Date: 2010-07-12 19:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/98da66f47273 Merge Changeset: 78561a957790 Author: lana Date: 2010-07-20 22:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/78561a957790 Merge Changeset: 11e7678c3eb1 Author: mikejwre Date: 2010-07-23 16:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/11e7678c3eb1 Added tag jdk7-b102 for changeset 78561a957790 ! .hgtags From lana.steuck at oracle.com Thu Jul 29 23:20:21 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 30 Jul 2010 06:20:21 +0000 Subject: hg: jdk7/tl/hotspot: 56 new changesets Message-ID: <20100730062156.44E4E47D99@hg.openjdk.java.net> Changeset: e13a5c0ed5e2 Author: prr Date: 2010-06-29 16:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/e13a5c0ed5e2 6964882: 32 bit JDK does not build on 64 bit Windows platforms Reviewed-by: ohair, valeriep ! make/windows/makefiles/defs.make Changeset: ad1977f08c4d Author: mikejwre Date: 2010-06-30 18:57 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ad1977f08c4d Merge Changeset: 6c3a919105b6 Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/6c3a919105b6 Added tag jdk7-b100 for changeset ad1977f08c4d ! .hgtags Changeset: 75b254ea860e Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/75b254ea860e Added tag jdk7-b101 for changeset 6c3a919105b6 ! .hgtags Changeset: 136b78722a08 Author: jrose Date: 2010-06-09 18:50 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/136b78722a08 6939203: JSR 292 needs method handle constants Summary: Add new CP types CONSTANT_MethodHandle, CONSTANT_MethodType; extend 'ldc' bytecode. Reviewed-by: twisti, never ! agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeDisassembler.java ! agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeInvoke.java ! agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeLoadConstant.java ! agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeWithCPIndex.java ! agent/src/share/classes/sun/jvm/hotspot/interpreter/Bytecodes.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPool.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolCache.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolCacheEntry.java ! agent/src/share/classes/sun/jvm/hotspot/oops/GenerateOopMap.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/ClassConstants.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ByteCodeRewriter.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/ConstantTag.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/ci/ciCPCache.cpp ! src/share/vm/ci/ciCPCache.hpp ! src/share/vm/ci/ciClassList.hpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/ci/ciObjectFactory.hpp ! src/share/vm/ci/ciStreams.cpp ! src/share/vm/ci/ciStreams.hpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/classfile/verifier.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/includeDB_core ! src/share/vm/interpreter/bytecode.cpp ! src/share/vm/interpreter/bytecode.hpp ! src/share/vm/interpreter/bytecodeTracer.cpp ! src/share/vm/interpreter/bytecodes.cpp ! src/share/vm/interpreter/bytecodes.hpp ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/interpreter/templateTable.cpp ! src/share/vm/interpreter/templateTable.hpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/oops/constantPoolOop.hpp ! src/share/vm/oops/cpCacheOop.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/methodComparator.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/utilities/constantTag.cpp ! src/share/vm/utilities/constantTag.hpp Changeset: d93949c5bdcc Author: kvn Date: 2010-06-10 13:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d93949c5bdcc 6730276: JDI_REGRESSION tests fail with "Error: count must be non-zero" error on x86 Summary: Modify assembler code to check for 0 count for all copy routines. Reviewed-by: never, ysr, jcoomes ! src/os_cpu/linux_x86/vm/copy_linux_x86.inline.hpp ! src/os_cpu/linux_x86/vm/linux_x86_32.s ! src/os_cpu/solaris_x86/vm/solaris_x86_32.s ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vframeArray.cpp ! src/share/vm/utilities/copy.cpp ! src/share/vm/utilities/copy.hpp Changeset: b918d354830a Author: jrose Date: 2010-06-12 22:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b918d354830a 6960865: ldc of unloaded class throws an assert in ciTypeFlow Summary: Support java_mirror for unloaded klasses, arrays as well as instances. Simplify ciTypeFlow by removing unused path. Reviewed-by: kvn ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciKlass.cpp ! src/share/vm/ci/ciTypeFlow.cpp Changeset: d179e225c164 Author: twisti Date: 2010-06-14 00:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d179e225c164 6960550: Missing semicolon in Zero Summary: There is a missing semicolon in cppInterpreter_zero.cpp. Reviewed-by: twisti Contributed-by: Gary Benson ! src/cpu/zero/vm/cppInterpreter_zero.cpp Changeset: 0b4ee1df1b44 Author: never Date: 2010-06-15 12:03 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/0b4ee1df1b44 6952176: Remove debug flag from adlc makefile for 6Update trains Reviewed-by: kvn, twisti ! make/linux/makefiles/adlc.make Changeset: 78fc92dfd4ca Author: never Date: 2010-06-15 12:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/78fc92dfd4ca Merge Changeset: 2389669474a6 Author: jrose Date: 2010-06-15 15:57 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/2389669474a6 Merge ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/runtime/thread.cpp Changeset: 4311f23817fd Author: kvn Date: 2010-06-15 18:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/4311f23817fd 6959430: Make sure raw loads have control edge Summary: check that raw loads have control edge Reviewed-by: never, twisti ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/parse1.cpp Changeset: 79107c3a6bd5 Author: tonyp Date: 2010-05-07 13:14 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/79107c3a6bd5 6949307: G1: raise a vm error, do not core dump, if target pause time and target interval are inconsistent Summary: First, change the guarantee to raising a vm error. Second, set the interval dynamically, and based on the pause time target, if it is not set explicitly. Reviewed-by: ysr, johnc ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 215576b54709 Author: tonyp Date: 2010-04-22 15:20 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/215576b54709 6946048: G1: improvements to +PrintGCDetails output Summary: Small improvements to G1's PrintGCDetails output. It also includes minor formatting details. Reviewed-by: ysr, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp Changeset: fdde661c8e06 Author: jmasa Date: 2010-06-23 08:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/fdde661c8e06 6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008 Summary: Shrinking of a generation and the corresponding card table was causing part of the card table to be uncommitted. Reviewed-by: jcoomes ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.cpp ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.hpp ! src/share/vm/memory/cardTableModRefBS.cpp Changeset: 0d781caf0cbb Author: jmasa Date: 2010-06-23 15:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/0d781caf0cbb Merge Changeset: b8537b881421 Author: jmasa Date: 2010-06-24 15:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b8537b881421 Merge Changeset: ff38d05ea86f Author: never Date: 2010-06-18 16:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ff38d05ea86f 6956958: assert(is_clean() || is_call_to_compiled() || is_call_to_interpreted() || is_optimized() || is_megam Reviewed-by: kvn ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp Changeset: 38e8278318ca Author: never Date: 2010-06-21 14:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/38e8278318ca 6656830: assert((*p)->is_oop(),"expected an oop while scanning weak refs") Reviewed-by: dcubed, kvn, twisti ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/prims/jvmtiCodeBlobEvents.cpp ! src/share/vm/runtime/jniHandles.cpp Changeset: 9887b5e57f9e Author: iveresov Date: 2010-06-22 12:10 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/9887b5e57f9e 6962980: C1: stub area should take into account method handle deopt stub Reviewed-by: twisti, never ! src/share/vm/c1/c1_Compilation.cpp Changeset: 5f249b390094 Author: kvn Date: 2010-06-23 09:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5f249b390094 6947341: JVM Crash running Oracle ATG CRMDemo Summary: Missing protected page below heap with compressed oops on Linux with large pages use. Reviewed-by: never, phh, jcoomes ! src/share/vm/runtime/virtualspace.cpp Changeset: 5a297ea605c7 Author: jrose Date: 2010-06-26 00:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5a297ea605c7 Merge Changeset: d678e3277048 Author: kvn Date: 2010-06-28 10:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d678e3277048 6964479: widen normalization of small int and long values should be symmetric Summary: normalize widen value in xmeet() and xdual() methods for types Int and Long so the type meet will be symmetric. Reviewed-by: jrose ! src/share/vm/opto/type.cpp Changeset: 6027dddc26c6 Author: kvn Date: 2010-06-28 14:54 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/6027dddc26c6 6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist() Summary: Use replace_node() method instead of subsume_node(). Reviewed-by: jrose, never ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/opto/split_if.cpp ! src/share/vm/opto/superword.cpp Changeset: 76efbe666d6c Author: kvn Date: 2010-06-29 10:34 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/76efbe666d6c 6964774: Adjust optimization flags setting Summary: Adjust performance flags settings. Reviewed-by: never, phh ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/share/vm/runtime/arguments.cpp Changeset: fcbb92a1ab3b Author: jrose Date: 2010-06-29 16:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/fcbb92a1ab3b Merge ! src/share/vm/runtime/arguments.cpp Changeset: 726b40449bd2 Author: zgu Date: 2010-06-22 09:46 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/726b40449bd2 6939019: Source code adjustments for parfait compilation of hotspot Summary: Minor source code adjustments for parfait compilation, since it uses different compiler vs. JDK Reviewed-by: never, kamg ! src/os/solaris/vm/osThread_solaris.hpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp Changeset: 3e351982aac7 Author: zgu Date: 2010-06-22 10:03 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3e351982aac7 Merge Changeset: 1a11430e0326 Author: jcoomes Date: 2010-06-24 15:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1a11430e0326 6888573: class data sharing does not always disable large pages Reviewed-by: phh ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/runtime/arguments.cpp Changeset: c5f1ea9e15e8 Author: coleenp Date: 2010-06-28 12:03 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c5f1ea9e15e8 Merge ! src/share/vm/runtime/arguments.cpp Changeset: a00567c82f02 Author: coleenp Date: 2010-06-30 11:52 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a00567c82f02 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 871d2aa321f7 Author: trims Date: 2010-07-02 01:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/871d2aa321f7 Merge Changeset: 7cc68a696c62 Author: trims Date: 2010-07-02 01:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7cc68a696c62 6966252: Bump the HS19 build number to 04 Summary: Update the HS19 build number to 04 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 56cc7e01da2f Author: trims Date: 2010-07-09 00:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/56cc7e01da2f Added tag hs19-b03 for changeset ad1977f08c4d ! .hgtags Changeset: 1dbaff4aa23a Author: trims Date: 2010-07-09 00:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1dbaff4aa23a Merge Changeset: 65b0c03b165d Author: never Date: 2010-07-02 15:01 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/65b0c03b165d 6965671: fatal error: acquiring lock JNIGlobalHandle_lock/16 out of order with lock CodeCache_lock/1 Reviewed-by: kvn, dcubed ! src/share/vm/prims/jvmtiCodeBlobEvents.cpp Changeset: 60a14ad85270 Author: kvn Date: 2010-07-02 17:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/60a14ad85270 6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP Summary: Execute IGVN optimization before and after Escape Analysis Reviewed-by: never ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp Changeset: a693e51ac197 Author: never Date: 2010-07-07 12:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a693e51ac197 Merge Changeset: cf647374e044 Author: trims Date: 2010-07-09 00:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/cf647374e044 Merge Changeset: a2b581345549 Author: trims Date: 2010-07-15 19:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a2b581345549 Merge ! .hgtags Changeset: b2a00dd3117c Author: jcoomes Date: 2010-07-01 21:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b2a00dd3117c 6957084: simplify TaskQueue overflow handling Reviewed-by: ysr, jmasa ! src/share/vm/gc_implementation/includeDB_gc_parallelScavenge ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/utilities/taskqueue.cpp ! src/share/vm/utilities/taskqueue.hpp Changeset: 9ee05c8ab82f Author: ysr Date: 2010-07-12 12:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/9ee05c8ab82f Merge Changeset: bfc89697cccb Author: acorn Date: 2010-07-02 17:23 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/bfc89697cccb 6964164: MonitorInUseLists leak of contended objects Summary: fix MonitorInUseLists memory leak and MonitorBound now works Reviewed-by: chrisphi, dice ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/synchronizer.hpp ! src/share/vm/runtime/thread.hpp Changeset: 5087ecc10458 Author: acorn Date: 2010-07-07 14:12 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5087ecc10458 Merge Changeset: 0e7d2a08b605 Author: mchung Date: 2010-07-07 15:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/0e7d2a08b605 6967423: Hotspot support for modules image Summary: Add hotspot support for modules image Reviewed-by: acorn ! make/linux/makefiles/sa.make ! make/solaris/makefiles/sa.make ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/runtime/os.cpp Changeset: 1e7ec26380bd Author: apangin Date: 2010-07-14 17:52 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1e7ec26380bd Merge Changeset: 2a47bd84841f Author: never Date: 2010-07-08 14:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/2a47bd84841f 6965184: possible races in make_not_entrant_or_zombie Reviewed-by: kvn ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java - src/os/linux/vm/vtune_linux.cpp - src/os/solaris/vm/vtune_solaris.cpp - src/os/windows/vm/vtune_windows.cpp ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/code/codeBlob.cpp ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/code/vtableStubs.cpp ! src/share/vm/includeDB_core ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/init.cpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/stubCodeGenerator.cpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp ! src/share/vm/runtime/vmStructs.cpp - src/share/vm/runtime/vtune.hpp Changeset: 3941674cc7fa Author: never Date: 2010-07-12 10:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3941674cc7fa 6958668: repeated uncommon trapping for new of klass which is being initialized Reviewed-by: kvn, jrose ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciInstanceKlass.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parseHelper.cpp Changeset: 8d5934a77f10 Author: never Date: 2010-07-12 22:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/8d5934a77f10 6968385: malformed xml in sweeper logging Reviewed-by: kvn ! src/share/vm/runtime/sweeper.cpp Changeset: 079980c86f33 Author: kvn Date: 2010-07-14 14:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/079980c86f33 6968646: JVM crashes with SIGFPE during startup Summary: Check that cpuid returns valid values for processor topology (not zeros). Reviewed-by: never, twisti ! src/cpu/x86/vm/vm_version_x86.hpp Changeset: 8099e71601df Author: kvn Date: 2010-07-14 14:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/8099e71601df 6968368: SIGSEGV in the BCEscapeAnalyzer::copy_dependencies Summary: Use GrowableArray and VectorSet allocated in ciEnv arena. Reviewed-by: never, twisti ! src/share/vm/ci/bcEscapeAnalyzer.cpp ! src/share/vm/ci/bcEscapeAnalyzer.hpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/includeDB_compiler2 ! src/share/vm/includeDB_core Changeset: a528509c992b Author: never Date: 2010-07-15 08:54 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a528509c992b 6968336: VM crash guarantee(!nm->is_zombie()) failed: cannot lock a zombie method Reviewed-by: twisti ! src/share/vm/prims/jvmtiCodeBlobEvents.cpp Changeset: 61fdaf88f57f Author: never Date: 2010-07-15 13:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/61fdaf88f57f Merge - src/os/linux/vm/vtune_linux.cpp - src/os/solaris/vm/vtune_solaris.cpp - src/os/windows/vm/vtune_windows.cpp - src/share/vm/runtime/vtune.hpp Changeset: e55900b5c1b8 Author: trims Date: 2010-07-15 19:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/e55900b5c1b8 Merge - src/os/linux/vm/vtune_linux.cpp - src/os/solaris/vm/vtune_solaris.cpp - src/os/windows/vm/vtune_windows.cpp - src/share/vm/runtime/vtune.hpp Changeset: c5cadf1a0771 Author: trims Date: 2010-07-20 18:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c5cadf1a0771 Merge ! .hgtags Changeset: cb4250ef73b2 Author: mikejwre Date: 2010-07-23 16:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/cb4250ef73b2 Added tag jdk7-b102 for changeset c5cadf1a0771 ! .hgtags From lana.steuck at oracle.com Thu Jul 29 23:31:48 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 30 Jul 2010 06:31:48 +0000 Subject: hg: jdk7/tl/jaxp: 7 new changesets Message-ID: <20100730063148.B0C1447D9A@hg.openjdk.java.net> Changeset: 478835e100cd Author: lana Date: 2010-06-21 22:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/478835e100cd Merge Changeset: d524be5ef62e Author: lana Date: 2010-06-29 22:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/d524be5ef62e Merge Changeset: 17f62a566a20 Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/17f62a566a20 Added tag jdk7-b100 for changeset d524be5ef62e ! .hgtags Changeset: c9bd73f6d584 Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/c9bd73f6d584 Added tag jdk7-b101 for changeset 17f62a566a20 ! .hgtags Changeset: 70c8a34e2eb6 Author: lana Date: 2010-07-12 19:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/70c8a34e2eb6 Merge Changeset: 15573625af97 Author: lana Date: 2010-07-20 22:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/15573625af97 Merge Changeset: b7722e878864 Author: mikejwre Date: 2010-07-23 16:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/b7722e878864 Added tag jdk7-b102 for changeset 15573625af97 ! .hgtags From lana.steuck at oracle.com Thu Jul 29 23:31:53 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 30 Jul 2010 06:31:53 +0000 Subject: hg: jdk7/tl/jaxws: 7 new changesets Message-ID: <20100730063153.8225747D9B@hg.openjdk.java.net> Changeset: db63f482182d Author: lana Date: 2010-06-21 22:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/db63f482182d Merge Changeset: bd26d0ce0c3c Author: lana Date: 2010-06-29 22:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/bd26d0ce0c3c Merge Changeset: b55ce2744900 Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/b55ce2744900 Added tag jdk7-b100 for changeset bd26d0ce0c3c ! .hgtags Changeset: d1525c38428a Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/d1525c38428a Added tag jdk7-b101 for changeset b55ce2744900 ! .hgtags Changeset: 2b7a1ec9562e Author: lana Date: 2010-07-12 19:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/2b7a1ec9562e Merge Changeset: d8580443d181 Author: lana Date: 2010-07-20 22:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/d8580443d181 Merge Changeset: 267386d6b923 Author: mikejwre Date: 2010-07-23 16:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/267386d6b923 Added tag jdk7-b102 for changeset d8580443d181 ! .hgtags From Weijun.Wang at Sun.COM Thu Jul 29 23:39:27 2010 From: Weijun.Wang at Sun.COM (Weijun Wang) Date: Fri, 30 Jul 2010 14:39:27 +0800 Subject: code review request: 6973371: X509Factory should recognize PEM headers Message-ID: <4C52739F.6070208@sun.com> Hi Sean 6973371: X509Factory should recognize PEM headers Please review the webrev: http://cr.openjdk.java.net/~weijun/6973371/webrev.00/ There is one place I haven't touched, generateCertPath. PKCS #7 PEM block should begin with -----BEGIN PKCS7-----, or as described in [1], with -----BEGIN CERTIFICATE-----. But what about a PKIPATH data block? Thanks Max === *Description* ============================================================ Currently, when X509Factory tries to read certificate or CRL from a PEM file, it simply finds a block starting with "-----BEGIN STH-----" and ending with "-----END STH-----", and does not care what this STH is at all. There are third-party tools that generates a PEM file containing different kinds of PEM blocks. For example, "openssl pkcs12" can read in a PKCS #12 file and output private key and certficates into a single PEM file. If we want Java to read certificates from this file, we must take care to remove any private key block first. This is quite troublesome. *** (#1 of 1): 2010-07-30 03:40:21 GMT+00:00 weijun.wang at sun.com [1] http://www.openssl.org/docs/apps/pkcs7.html#NOTES From lana.steuck at oracle.com Thu Jul 29 23:35:09 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 30 Jul 2010 06:35:09 +0000 Subject: hg: jdk7/tl/jdk: 58 new changesets Message-ID: <20100730064427.EA6BE47D9C@hg.openjdk.java.net> Changeset: 4d55419ce99e Author: andrew Date: 2010-06-08 17:52 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4d55419ce99e 6959123: Remove use of obsolete png_check_sig function in splashscreen_png.c Summary: Avoid use of deprecated libpng macro (removed in some 1.4.x releases) Reviewed-by: prr ! src/share/native/sun/awt/splashscreen/splashscreen_png.c Changeset: 2574d999704a Author: igor Date: 2010-06-10 15:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2574d999704a 6952043: Incorrect JNI calls in fontpath.c Reviewed-by: jgodinez, prr ! src/windows/native/sun/font/fontpath.c Changeset: ae887ea4c772 Author: lana Date: 2010-06-10 18:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ae887ea4c772 Merge - make/com/sun/inputmethods/Makefile - make/com/sun/inputmethods/indicim/Makefile - make/com/sun/inputmethods/thaiim/Makefile - src/share/classes/com/sun/inputmethods/internal/indicim/DevanagariInputMethodDescriptor.java - src/share/classes/com/sun/inputmethods/internal/indicim/DevanagariTables.java - src/share/classes/com/sun/inputmethods/internal/indicim/IndicInputMethod.java - src/share/classes/com/sun/inputmethods/internal/indicim/IndicInputMethodImpl.java - src/share/classes/com/sun/inputmethods/internal/indicim/java.awt.im.spi.InputMethodDescriptor - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_de.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_es.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_fr.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_it.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_ja.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_ko.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_sv.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_zh_CN.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_zh_TW.properties - src/share/classes/com/sun/inputmethods/internal/thaiim/ThaiInputMethod.java - src/share/classes/com/sun/inputmethods/internal/thaiim/ThaiInputMethodDescriptor.java - src/share/classes/com/sun/inputmethods/internal/thaiim/ThaiInputMethodImpl.java - src/share/classes/com/sun/inputmethods/internal/thaiim/ThaiRules.java - src/share/classes/com/sun/inputmethods/internal/thaiim/java.awt.im.spi.InputMethodDescriptor - src/share/classes/com/sun/inputmethods/internal/thaiim/resources/DisplayNames.properties - src/share/classes/javax/swing/text/html/parser/html32.bdtd - src/share/classes/sun/security/tools/PolicyTool.java Changeset: 8b55669c7b7a Author: neugens Date: 2010-06-16 20:46 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8b55669c7b7a 6961732: FontMetrics.getLeading() may be negative in freetype-based OpenJDK builds. Summary: Fix premature integer roundings to preserve correct height, width and descent values for fonts Reviewed-by: prr ! src/share/native/sun/font/freetypeScaler.c Changeset: 83c7768292d7 Author: prr Date: 2010-06-18 11:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/83c7768292d7 6961633: gui applications cause a jvm crash on windows Reviewed-by: ceisserer, bae ! make/sun/pisces/Makefile ! src/share/classes/sun/java2d/pisces/META-INF/services/sun.java2d.pipe.RenderingEngine + src/solaris/classes/sun/java2d/pisces/META-INF/services/sun.java2d.pipe.RenderingEngine Changeset: 31d25fccdf1c Author: lana Date: 2010-06-21 22:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/31d25fccdf1c Merge Changeset: c02096d7b70e Author: anthony Date: 2010-06-16 11:26 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c02096d7b70e 6959787: java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html failed on 7b94 Summary: Add a delay to the test to make sure the filename filters are called. Reviewed-by: dcherepanov, art ! test/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java Changeset: fa06ad055c43 Author: coffeys Date: 2010-06-16 16:15 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fa06ad055c43 6860491: WRAP_TIME_MILLIS incorrectly set Summary: Alter WRAP_TIME_MILLIS to be unsigned Reviewed-by: yan ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: 8722b75c9ccd Author: anthony Date: 2010-06-18 17:09 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8722b75c9ccd 6959165: JVM crash during execution FileDialogBufferOverflowTest.html Summary: Add proper synchronization Reviewed-by: art, dcherepanov ! src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.c Changeset: 05eb107d6891 Author: anthony Date: 2010-06-18 17:13 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/05eb107d6891 6961754: JCK tests CvsEventTest0001 and CvsEventTest0002 fail under FF 3.5 on OEL 5 Summary: Check the return value of XlibUtil.translateCoordinates() for null Reviewed-by: art, dcherepanov ! src/solaris/classes/sun/awt/X11/XEmbeddedFramePeer.java ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: ae16c200341a Author: lana Date: 2010-06-21 22:05 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ae16c200341a Merge Changeset: ad5f65797249 Author: rupashka Date: 2010-06-02 11:59 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ad5f65797249 6857057: api/javax_swing/text/GlyphView/index.html#Methods test fails Reviewed-by: peterz ! src/share/classes/javax/swing/text/Utilities.java ! src/share/classes/javax/swing/text/WrappedPlainView.java + test/javax/swing/text/WrappedPlainView/6857057/StubBranchElement.java + test/javax/swing/text/WrappedPlainView/6857057/StubLeafElement.java + test/javax/swing/text/WrappedPlainView/6857057/bug6857057.java Changeset: dc14ee238fe3 Author: rupashka Date: 2010-06-02 12:53 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dc14ee238fe3 6636983: Japanese text does not display correctly in a JEditorPane Reviewed-by: peterz ! src/share/classes/javax/swing/text/DefaultStyledDocument.java ! src/share/classes/javax/swing/text/GlyphView.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/sun/swing/SwingUtilities2.java + test/javax/swing/text/DefaultStyledDocument/6636983/bug6636983.java Changeset: d1c875d94263 Author: lana Date: 2010-06-10 14:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d1c875d94263 Merge - src/share/classes/sun/security/tools/PolicyTool.java Changeset: 7a3d8fc0d2cd Author: malenkov Date: 2010-06-15 17:39 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7a3d8fc0d2cd 5066685: BorderFactory lacks SoftBevelBorder support Reviewed-by: alexp ! src/share/classes/javax/swing/BorderFactory.java Changeset: cf13f6389bdd Author: alexp Date: 2010-06-15 19:05 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cf13f6389bdd 6788484: NPE in DefaultTableCellHeaderRenderer.getColumnSortOrder() with null table Reviewed-by: rupashka ! src/share/classes/sun/swing/table/DefaultTableCellHeaderRenderer.java + test/javax/swing/JTable/6788484/bug6788484.java Changeset: 5e4969391538 Author: alexp Date: 2010-06-15 19:10 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5e4969391538 6735259: NPE at WindowsComboBoxUI$XPComboBoxButton.getState(WindowsComboBoxUI.java:408) Reviewed-by: rupashka ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsComboBoxUI.java Changeset: cd565c554dc6 Author: alexp Date: 2010-06-15 21:28 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cd565c554dc6 6771547: SynthParser throws StringIndexOutOfBoundsException parsing custom ColorTypes Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/synth/SynthParser.java + test/javax/swing/plaf/synth/6771547/SynthTest.java + test/javax/swing/plaf/synth/6771547/synthconfig.xml Changeset: 4d93c409ce87 Author: alexp Date: 2010-06-15 21:32 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4d93c409ce87 6739756: JToolBar leaves space for non-visible items under Nimbus L&F Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/synth/SynthToolBarUI.java + test/javax/swing/plaf/synth/SynthToolBarUI/6739756/bug6739756.java Changeset: aaa62c1f221e Author: lana Date: 2010-06-21 22:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/aaa62c1f221e Merge Changeset: 5438223734aa Author: lana Date: 2010-06-21 22:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5438223734aa Merge Changeset: 10a6319c9c15 Author: lana Date: 2010-06-29 22:34 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/10a6319c9c15 Merge Changeset: 861213cb02c3 Author: prr Date: 2010-06-29 16:34 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/861213cb02c3 6964882: 32 bit JDK does not build on 64 bit Windows platforms Reviewed-by: ohair, valeriep ! make/sun/security/mscapi/Makefile ! make/sun/security/pkcs11/Makefile Changeset: 511ddf6938ea Author: mikejwre Date: 2010-06-30 18:57 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/511ddf6938ea Merge Changeset: 820b4e843d51 Author: ohair Date: 2010-07-07 10:21 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/820b4e843d51 6967036: Need to fix links with // in Javadoc comments Reviewed-by: mchung ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/Base64.java ! src/share/classes/com/sun/security/auth/LdapPrincipal.java ! src/share/classes/com/sun/security/sasl/CramMD5Client.java ! src/share/classes/com/sun/security/sasl/CramMD5Server.java ! src/share/classes/com/sun/security/sasl/ExternalClient.java ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Client.java ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Server.java ! src/share/classes/java/net/URI.java ! src/share/classes/java/nio/charset/package.html ! src/share/classes/javax/management/remote/JMXServiceURL.java ! src/share/classes/javax/naming/ldap/LdapName.java ! src/share/classes/javax/naming/ldap/Rdn.java ! src/share/classes/javax/net/ssl/SSLContext.java ! src/share/classes/javax/print/DocFlavor.java ! src/share/classes/sun/awt/image/PNGImageDecoder.java Changeset: 93c4e6d14010 Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/93c4e6d14010 Added tag jdk7-b100 for changeset 820b4e843d51 ! .hgtags Changeset: d58354a69011 Author: bpatel Date: 2010-07-14 15:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d58354a69011 6955341: Oracle rebranding changes for man pages Reviewed-by: darcy ! src/linux/doc/man/appletviewer.1 ! src/linux/doc/man/apt.1 ! src/linux/doc/man/extcheck.1 ! src/linux/doc/man/idlj.1 ! src/linux/doc/man/ja/appletviewer.1 ! src/linux/doc/man/ja/apt.1 ! src/linux/doc/man/ja/extcheck.1 ! src/linux/doc/man/ja/idlj.1 ! src/linux/doc/man/ja/jar.1 ! src/linux/doc/man/ja/jarsigner.1 ! src/linux/doc/man/ja/java.1 ! src/linux/doc/man/ja/javac.1 ! src/linux/doc/man/ja/javadoc.1 ! src/linux/doc/man/ja/javah.1 ! src/linux/doc/man/ja/javap.1 ! src/linux/doc/man/ja/javaws.1 ! src/linux/doc/man/ja/jconsole.1 ! src/linux/doc/man/ja/jdb.1 ! src/linux/doc/man/ja/jhat.1 ! src/linux/doc/man/ja/jinfo.1 ! src/linux/doc/man/ja/jmap.1 ! src/linux/doc/man/ja/jps.1 ! src/linux/doc/man/ja/jrunscript.1 ! src/linux/doc/man/ja/jsadebugd.1 ! src/linux/doc/man/ja/jstack.1 ! src/linux/doc/man/ja/jstat.1 ! src/linux/doc/man/ja/jstatd.1 ! src/linux/doc/man/ja/keytool.1 - src/linux/doc/man/ja/kinit.1 - src/linux/doc/man/ja/klist.1 - src/linux/doc/man/ja/ktab.1 ! src/linux/doc/man/ja/native2ascii.1 ! src/linux/doc/man/ja/orbd.1 ! src/linux/doc/man/ja/pack200.1 ! src/linux/doc/man/ja/policytool.1 ! src/linux/doc/man/ja/rmic.1 ! src/linux/doc/man/ja/rmid.1 ! src/linux/doc/man/ja/rmiregistry.1 ! src/linux/doc/man/ja/schemagen.1 ! src/linux/doc/man/ja/serialver.1 ! src/linux/doc/man/ja/servertool.1 ! src/linux/doc/man/ja/tnameserv.1 ! src/linux/doc/man/ja/unpack200.1 ! src/linux/doc/man/ja/wsgen.1 ! src/linux/doc/man/ja/wsimport.1 ! src/linux/doc/man/ja/xjc.1 ! src/linux/doc/man/jar.1 ! src/linux/doc/man/jarsigner.1 ! src/linux/doc/man/java.1 ! src/linux/doc/man/javac.1 ! src/linux/doc/man/javadoc.1 ! src/linux/doc/man/javah.1 ! src/linux/doc/man/javap.1 ! src/linux/doc/man/javaws.1 ! src/linux/doc/man/jconsole.1 ! src/linux/doc/man/jdb.1 ! src/linux/doc/man/jhat.1 ! src/linux/doc/man/jinfo.1 ! src/linux/doc/man/jmap.1 ! src/linux/doc/man/jps.1 ! src/linux/doc/man/jrunscript.1 ! src/linux/doc/man/jsadebugd.1 ! src/linux/doc/man/jstack.1 ! src/linux/doc/man/jstat.1 ! src/linux/doc/man/jstatd.1 ! src/linux/doc/man/keytool.1 ! src/linux/doc/man/native2ascii.1 ! src/linux/doc/man/orbd.1 ! src/linux/doc/man/pack200.1 ! src/linux/doc/man/policytool.1 ! src/linux/doc/man/rmic.1 ! src/linux/doc/man/rmid.1 ! src/linux/doc/man/rmiregistry.1 ! src/linux/doc/man/schemagen.1 ! src/linux/doc/man/serialver.1 ! src/linux/doc/man/servertool.1 ! src/linux/doc/man/tnameserv.1 ! src/linux/doc/man/unpack200.1 ! src/linux/doc/man/wsgen.1 ! src/linux/doc/man/wsimport.1 ! src/linux/doc/man/xjc.1 ! src/solaris/doc/sun/man/man1/appletviewer.1 ! src/solaris/doc/sun/man/man1/apt.1 ! src/solaris/doc/sun/man/man1/extcheck.1 ! src/solaris/doc/sun/man/man1/idlj.1 ! src/solaris/doc/sun/man/man1/ja/appletviewer.1 ! src/solaris/doc/sun/man/man1/ja/apt.1 ! src/solaris/doc/sun/man/man1/ja/extcheck.1 ! src/solaris/doc/sun/man/man1/ja/idlj.1 ! src/solaris/doc/sun/man/man1/ja/jar.1 ! src/solaris/doc/sun/man/man1/ja/jarsigner.1 ! src/solaris/doc/sun/man/man1/ja/java.1 ! src/solaris/doc/sun/man/man1/ja/javac.1 ! src/solaris/doc/sun/man/man1/ja/javadoc.1 ! src/solaris/doc/sun/man/man1/ja/javah.1 ! src/solaris/doc/sun/man/man1/ja/javap.1 ! src/solaris/doc/sun/man/man1/ja/javaws.1 ! src/solaris/doc/sun/man/man1/ja/jconsole.1 ! src/solaris/doc/sun/man/man1/ja/jdb.1 ! src/solaris/doc/sun/man/man1/ja/jhat.1 ! src/solaris/doc/sun/man/man1/ja/jinfo.1 ! src/solaris/doc/sun/man/man1/ja/jmap.1 ! src/solaris/doc/sun/man/man1/ja/jps.1 ! src/solaris/doc/sun/man/man1/ja/jrunscript.1 ! src/solaris/doc/sun/man/man1/ja/jsadebugd.1 ! src/solaris/doc/sun/man/man1/ja/jstack.1 ! src/solaris/doc/sun/man/man1/ja/jstat.1 ! src/solaris/doc/sun/man/man1/ja/jstatd.1 ! src/solaris/doc/sun/man/man1/ja/keytool.1 ! src/solaris/doc/sun/man/man1/ja/native2ascii.1 ! src/solaris/doc/sun/man/man1/ja/orbd.1 ! src/solaris/doc/sun/man/man1/ja/pack200.1 ! src/solaris/doc/sun/man/man1/ja/policytool.1 ! src/solaris/doc/sun/man/man1/ja/rmic.1 ! src/solaris/doc/sun/man/man1/ja/rmid.1 ! src/solaris/doc/sun/man/man1/ja/rmiregistry.1 ! src/solaris/doc/sun/man/man1/ja/schemagen.1 ! src/solaris/doc/sun/man/man1/ja/serialver.1 ! src/solaris/doc/sun/man/man1/ja/servertool.1 ! src/solaris/doc/sun/man/man1/ja/tnameserv.1 ! src/solaris/doc/sun/man/man1/ja/unpack200.1 ! src/solaris/doc/sun/man/man1/ja/wsgen.1 ! src/solaris/doc/sun/man/man1/ja/wsimport.1 ! src/solaris/doc/sun/man/man1/ja/xjc.1 ! src/solaris/doc/sun/man/man1/jar.1 ! src/solaris/doc/sun/man/man1/jarsigner.1 ! src/solaris/doc/sun/man/man1/java.1 ! src/solaris/doc/sun/man/man1/javac.1 ! src/solaris/doc/sun/man/man1/javadoc.1 ! src/solaris/doc/sun/man/man1/javah.1 ! src/solaris/doc/sun/man/man1/javap.1 ! src/solaris/doc/sun/man/man1/javaws.1 ! src/solaris/doc/sun/man/man1/jconsole.1 ! src/solaris/doc/sun/man/man1/jdb.1 ! src/solaris/doc/sun/man/man1/jhat.1 ! src/solaris/doc/sun/man/man1/jinfo.1 ! src/solaris/doc/sun/man/man1/jmap.1 ! src/solaris/doc/sun/man/man1/jps.1 ! src/solaris/doc/sun/man/man1/jrunscript.1 ! src/solaris/doc/sun/man/man1/jsadebugd.1 ! src/solaris/doc/sun/man/man1/jstack.1 ! src/solaris/doc/sun/man/man1/jstat.1 ! src/solaris/doc/sun/man/man1/jstatd.1 ! src/solaris/doc/sun/man/man1/keytool.1 ! src/solaris/doc/sun/man/man1/native2ascii.1 ! src/solaris/doc/sun/man/man1/orbd.1 ! src/solaris/doc/sun/man/man1/pack200.1 ! src/solaris/doc/sun/man/man1/policytool.1 ! src/solaris/doc/sun/man/man1/rmic.1 ! src/solaris/doc/sun/man/man1/rmid.1 ! src/solaris/doc/sun/man/man1/rmiregistry.1 ! src/solaris/doc/sun/man/man1/schemagen.1 ! src/solaris/doc/sun/man/man1/serialver.1 ! src/solaris/doc/sun/man/man1/servertool.1 ! src/solaris/doc/sun/man/man1/tnameserv.1 ! src/solaris/doc/sun/man/man1/unpack200.1 ! src/solaris/doc/sun/man/man1/wsgen.1 ! src/solaris/doc/sun/man/man1/wsimport.1 ! src/solaris/doc/sun/man/man1/xjc.1 Changeset: 6c4450bbad6d Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6c4450bbad6d Added tag jdk7-b101 for changeset d58354a69011 ! .hgtags Changeset: c801686d91f4 Author: prr Date: 2010-06-29 09:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c801686d91f4 6943487: NPE in makeMultiCharsetString while printing on linux Reviewed-by: igor, jgodinez ! src/share/classes/sun/awt/PlatformFont.java ! src/share/classes/sun/java2d/HeadlessGraphicsEnvironment.java Changeset: 4da6837dd085 Author: lana Date: 2010-06-30 15:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4da6837dd085 Merge Changeset: ab55cb957830 Author: igor Date: 2010-07-06 18:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ab55cb957830 6967050: JDK build issues with cygwin/vc2010 Reviewed-by: prr, ohair ! make/common/shared/Defs-windows.gmk ! make/mkdemo/Makefile Changeset: e03065fc64e7 Author: igor Date: 2010-07-12 13:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e03065fc64e7 6959998: Return of SurfaceData_InitOps point not checked in all cases (parfait found these) Reviewed-by: prr Contributed-by: ohair ! src/share/native/sun/awt/image/BufImgSurfaceData.c ! src/solaris/native/sun/java2d/opengl/GLXSurfaceData.c ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c ! src/windows/native/sun/java2d/opengl/WGLSurfaceData.c ! src/windows/native/sun/java2d/windows/GDIWindowSurfaceData.cpp Changeset: 2ad69cb576b4 Author: igor Date: 2010-07-12 15:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2ad69cb576b4 6968373: FontUtilities static initializer throws AccessControlException Reviewed-by: prr ! src/share/classes/sun/font/FontUtilities.java ! test/java/awt/FontClass/FontPrivilege.java Changeset: 4a639bcd3361 Author: lana Date: 2010-07-12 19:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4a639bcd3361 Merge Changeset: f5145c7119c2 Author: yan Date: 2010-06-24 11:50 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f5145c7119c2 6957166: With XAWT, set arguments properly creating a MouseWheelEvent. Summary: swap some parameters to allow bigger values for click count. Reviewed-by: dav ! src/solaris/classes/sun/awt/X11/XWindow.java Changeset: bccf2a4ee318 Author: art Date: 2010-07-06 17:59 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bccf2a4ee318 6424157: java.awt.EventQueue push/pop might cause threading issues Reviewed-by: ant, dcherepanov ! src/share/classes/java/awt/EventDispatchThread.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/sun/awt/SunToolkit.java ! test/java/awt/EventDispatchThread/HandleExceptionOnEDT/HandleExceptionOnEDT.java ! test/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.java + test/java/awt/EventDispatchThread/PreserveDispathThread/PreserveDispatchThread.java ! test/java/awt/EventQueue/PushPopDeadlock2/PushPopTest.java Changeset: 21b17c64df74 Author: dcherepanov Date: 2010-07-06 18:23 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/21b17c64df74 6966643: GTK FileDialog hangs when user manually closes it Reviewed-by: art ! src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.c Changeset: 9950dc616615 Author: dcherepanov Date: 2010-07-07 14:20 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9950dc616615 6959174: Need to introduce sun.awt.disableGtkFileDialogs system property Reviewed-by: art, anthony ! src/share/classes/sun/awt/SunToolkit.java ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: 48aa2a1edd2b Author: lana Date: 2010-07-08 11:28 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/48aa2a1edd2b Merge Changeset: 2d8f060dd1c5 Author: lana Date: 2010-07-12 19:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2d8f060dd1c5 Merge Changeset: 69ddf06e616a Author: malenkov Date: 2010-06-22 12:06 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/69ddf06e616a 6707234: Method returned by Introspector.internalFindMethod not necessarily most specific Reviewed-by: peterz ! src/share/classes/com/sun/beans/finder/MethodFinder.java ! src/share/classes/java/beans/EventSetDescriptor.java ! src/share/classes/java/beans/IndexedPropertyDescriptor.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/MethodDescriptor.java ! src/share/classes/java/beans/PropertyDescriptor.java + test/java/beans/Introspector/Test6707234.java Changeset: 5af3b0430bbe Author: peterz Date: 2010-06-22 14:36 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5af3b0430bbe 6959260: javax/swing/JLabel/6501991/bug6501991.java failed on build 1.7.0-ea-b96 Reviewed-by: rupashka ! src/share/classes/sun/swing/SwingUtilities2.java ! test/ProblemList.txt ! test/com/sun/java/swing/plaf/gtk/Test6635110.java Changeset: dea63f6dda7a Author: alexp Date: 2010-06-22 19:38 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dea63f6dda7a 6777378: NullPointerException in XPDefaultRenderer.paint() Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/basic/BasicTableHeaderUI.java + test/javax/swing/JTable/6777378/bug6777378.java Changeset: a05e047c5b98 Author: alexp Date: 2010-06-22 20:36 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a05e047c5b98 6684401: JTree isExpanded should not call itself recursively Reviewed-by: rupashka ! src/share/classes/javax/swing/JTree.java Changeset: f1bafc4f249d Author: peterz Date: 2010-06-29 14:42 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f1bafc4f249d 6963870: NPE in CompoundBorder.getInsets() Reviewed-by: alexp Contributed-by: jon.vanalten at redhat.com ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKPainter.java + test/com/sun/java/swing/plaf/gtk/Test6963870.java Changeset: c0e785f055a7 Author: lana Date: 2010-06-30 19:05 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c0e785f055a7 Merge ! test/ProblemList.txt Changeset: d062afbe2107 Author: malenkov Date: 2010-07-01 18:09 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d062afbe2107 4129681: Cannot get a title border to display its label as disabled Reviewed-by: alexp, rupashka ! src/share/classes/javax/swing/border/TitledBorder.java + test/javax/swing/border/Test4129681.html + test/javax/swing/border/Test4129681.java + test/javax/swing/border/Test4760089.html + test/javax/swing/border/Test4760089.java Changeset: 46306a419ba3 Author: malenkov Date: 2010-07-01 18:47 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/46306a419ba3 6959266: test javax/swing/JInternalFrame/6725409/bug6725409.java should be modified Reviewed-by: alexp ! test/javax/swing/JInternalFrame/6725409/bug6725409.java Changeset: e94a94d176f9 Author: alexp Date: 2010-07-02 19:28 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e94a94d176f9 6711682: JCheckBox in JTable: checkbox doesn't alaways respond to the first mouse click Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/basic/BasicButtonListener.java + test/javax/swing/AbstractButton/6711682/bug6711682.java Changeset: 46d5aef470a3 Author: alexp Date: 2010-07-02 19:34 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/46d5aef470a3 6937415: Some components return undocumented default values under Nimbus LaF Reviewed-by: peterz ! src/share/classes/javax/swing/JSplitPane.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/plaf/nimbus/skin.laf Changeset: e12c92d2dc11 Author: rupashka Date: 2010-07-08 19:09 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e12c92d2dc11 6520101: FileChooser will cause OutOfMemory when application will run long time Reviewed-by: peterz ! src/share/classes/com/sun/java/swing/plaf/motif/MotifFileChooserUI.java + test/javax/swing/JFileChooser/6520101/bug6520101.java Changeset: d0bcc9aa5a7a Author: malenkov Date: 2010-07-09 19:42 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d0bcc9aa5a7a 6894597: test/closed/javax/swing/JPopupMenu/6495920/bug6495920.java fails Reviewed-by: alexp, peterz + test/javax/swing/JPopupMenu/6495920/bug6495920.java Changeset: 3dc686ecb4cd Author: malenkov Date: 2010-07-09 22:07 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3dc686ecb4cd 6963811: Deadlock-prone locking changes in Introspector Reviewed-by: peterz, rupashka ! src/share/classes/com/sun/beans/finder/InstanceFinder.java ! src/share/classes/com/sun/beans/finder/PersistenceDelegateFinder.java ! src/share/classes/com/sun/beans/finder/PropertyEditorFinder.java ! src/share/classes/java/beans/Encoder.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/PropertyEditorManager.java + test/java/beans/Introspector/Test6963811.java + test/java/beans/PropertyEditor/Test6963811.java + test/java/beans/XMLEncoder/Test6963811.java Changeset: a93a7ed5018c Author: lana Date: 2010-07-12 19:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a93a7ed5018c Merge Changeset: c5a436f053aa Author: lana Date: 2010-07-12 19:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c5a436f053aa Merge ! test/ProblemList.txt - test/java/nio/channels/ServerSocketChannel/AcceptAddress.java - test/java/nio/charset/coders/Surrogate.java - test/tools/launcher/Makefile.SolarisRunpath - test/tools/launcher/lib/i386/lib32/lib32/liblibrary.so - test/tools/launcher/lib/i386/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib64/lib64/liblibrary.so - test/tools/launcher/lib/sparc/lib64/liblibrary.so Changeset: 13029a61b16b Author: lana Date: 2010-07-20 22:21 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/13029a61b16b Merge - test/java/nio/channels/ServerSocketChannel/AcceptAddress.java - test/java/nio/charset/coders/Surrogate.java - test/tools/launcher/Makefile.SolarisRunpath - test/tools/launcher/lib/i386/lib32/lib32/liblibrary.so - test/tools/launcher/lib/i386/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib64/lib64/liblibrary.so - test/tools/launcher/lib/sparc/lib64/liblibrary.so Changeset: 6488b70a23cc Author: mikejwre Date: 2010-07-23 16:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6488b70a23cc Added tag jdk7-b102 for changeset 13029a61b16b ! .hgtags Changeset: 48e6f4807e5f Author: lana Date: 2010-07-29 22:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/48e6f4807e5f Merge - src/linux/doc/man/ja/kinit.1 - src/linux/doc/man/ja/klist.1 - src/linux/doc/man/ja/ktab.1 ! test/ProblemList.txt From lana.steuck at oracle.com Fri Jul 30 00:00:21 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 30 Jul 2010 07:00:21 +0000 Subject: hg: jdk7/tl/langtools: 8 new changesets Message-ID: <20100730070034.DE75947D9E@hg.openjdk.java.net> Changeset: 4cca8d7ce6c1 Author: lana Date: 2010-06-21 22:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4cca8d7ce6c1 Merge Changeset: d1d7595fa824 Author: lana Date: 2010-06-29 22:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d1d7595fa824 Merge ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/util/Names.java Changeset: 20a8fe72ee7b Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/20a8fe72ee7b Added tag jdk7-b100 for changeset d1d7595fa824 ! .hgtags Changeset: f87f1f3e23e1 Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f87f1f3e23e1 Added tag jdk7-b101 for changeset 20a8fe72ee7b ! .hgtags Changeset: eaab979c8b36 Author: lana Date: 2010-07-12 19:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/eaab979c8b36 Merge Changeset: ff9c0a0bf7ed Author: lana Date: 2010-07-20 22:22 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ff9c0a0bf7ed Merge Changeset: bd85271c580c Author: mikejwre Date: 2010-07-23 16:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/bd85271c580c Added tag jdk7-b102 for changeset ff9c0a0bf7ed ! .hgtags Changeset: 077eb94c912d Author: lana Date: 2010-07-29 22:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/077eb94c912d Merge From sean.mullan at oracle.com Fri Jul 30 09:46:55 2010 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 30 Jul 2010 12:46:55 -0400 Subject: code review request: 6973371: X509Factory should recognize PEM headers In-Reply-To: <4C52739F.6070208@sun.com> References: <4C52739F.6070208@sun.com> Message-ID: <4C5301FF.5020902@oracle.com> Hi Max, I'm not sure about this change. There's a definitely a change in behavior. Before generateCertificate would only read one PEM block from the stream, and throw an exception if it wasn't a certificate. But the current fix ignores non certificate blocks until it finds a certificate or end of stream, right? --Sean On 7/30/10 2:39 AM, Weijun Wang wrote: > Hi Sean > > 6973371: X509Factory should recognize PEM headers > > Please review the webrev: > http://cr.openjdk.java.net/~weijun/6973371/webrev.00/ > > There is one place I haven't touched, generateCertPath. PKCS #7 PEM > block should begin with -----BEGIN PKCS7-----, or as described in [1], > with -----BEGIN CERTIFICATE-----. But what about a PKIPATH data block? > > Thanks > Max > > > === *Description* > ============================================================ > Currently, when X509Factory tries to read certificate or CRL from a PEM > file, it simply finds a block starting with "-----BEGIN STH-----" and > ending with "-----END STH-----", and does not care what this STH is at all. > > There are third-party tools that generates a PEM file containing > different kinds of PEM blocks. For example, "openssl pkcs12" can read in > a PKCS #12 file and output private key and certficates into a single PEM > file. If we want Java to read certificates from this file, we must take > care to remove any private key block first. This is quite troublesome. > > *** (#1 of 1): 2010-07-30 03:40:21 GMT+00:00 weijun.wang at sun.com > > [1] http://www.openssl.org/docs/apps/pkcs7.html#NOTES From michael.x.mcmahon at oracle.com Fri Jul 30 10:17:18 2010 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Fri, 30 Jul 2010 17:17:18 +0000 Subject: hg: jdk7/tl/jdk: 6510892: com/sun/net/httpserver/bugs/B6361557.java fails Message-ID: <20100730171728.1DD8347DBB@hg.openjdk.java.net> Changeset: 4d72d0ec83f5 Author: michaelm Date: 2010-07-30 18:16 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4d72d0ec83f5 6510892: com/sun/net/httpserver/bugs/B6361557.java fails Reviewed-by: chegar ! test/com/sun/net/httpserver/bugs/B6361557.java From valerie.peng at oracle.com Fri Jul 30 17:01:26 2010 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Fri, 30 Jul 2010 17:01:26 -0700 Subject: code review request: 6960894: Better AS-REQ creation and processing In-Reply-To: <4C474B31.20806@oracle.com> References: <22057664.1276437650877.JavaMail.sbladm@swsblss3-new> <09BC881F-51C5-4004-9BF4-B7F826BC48AA@Sun.COM> <4C474B31.20806@oracle.com> Message-ID: <4C5367D6.5050305@oracle.com> Hi, Max, KrbAsRep.java => 1) the javadoc of its decrypt method only documents the first two arguments which seems incomplete. You meant to emphasize that there two are user-provided? Maybe you can just enhance the method description. In addition, only one of the keys and password arguments is used. Would it be clearer to separate this into two methods, one uses keys and the other uses password? => 2) one thing that I find somewhat confusing is the values of "creds". The old model sets all of its fields in the constructor. With the new model, creds is null until decrypt(...) is called. KrbKdcReq.java => 1) for the if-block between line 229 and 232, is it possible for the KRB_ERR_RESPONSE_TOO_BIG when 'useTCP' is true? And don't you have to check ibuf again after line 231? => 2) I am open for a name change since the current naming seems to imply an inheritance relationship which you've changed. KrbAsReqBuilder.java => 1) line 72 "one and only is non-null" may be clearer as "one of them must be null". => 2) keys(..) and pass(..) are initialization methods which must be called before getKeys(), right? Can you rename them so it's clearer? There is no checking in getKeys() and if called out of sequence, it looks to me that it'll error out w/ NPE since eType is still null. Thanks, Valerie On 07/21/10 12:32, Valerie (Yu-Ching) Peng wrote: > On 06/13/10 08:02, Weijun Wang wrote: >> Hi Valerie and Andrew >> >> Please review the following webrev: >> >> http://cr.openjdk.java.net/~weijun/6960894/webrev.00 >> >> The major enhancement is KrbAsReqBuilder which generates AS-REQ, sends it, parses any response, and returns a Credentials object. The other big change is KrbKdcReq, it's no longer base class for KrbAsReq and KrbTgsReq, but mainly a vehicle for both kinds of KDC-REQ messages. Maybe it needs a name change? >> >> Most other changes are about removing duplicate lines. >> >> Thanks >> Max >> >> Begin forwarded message: >> >> >>> *Change Request ID*: 6960894 >>> *Synopsis*: Better AS-REQ creation and processing >>> >>> >> >> >>> === *Description* ============================================================ >>> The current AS-REQ creation and processing implementation: >>> >>> 1. spread into multiple source files and have duplicate codes >>> 2. cannot deal with PA-DATA in AS-REP >>> 3. only use a single salt, and write it into PrincipalName permanently >>> 4. generate too many secret keys and have no consistent way to clear them >>> 5. does not handle the preferences of PA-ETYPE-INFO2, PA-ETYPE-INFO correctly >>> >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20100730/856b0a28/attachment.html From Weijun.Wang at Sun.COM Sat Jul 31 06:46:02 2010 From: Weijun.Wang at Sun.COM (Weijun Wang) Date: Sat, 31 Jul 2010 21:46:02 +0800 Subject: code review request: 6973371: X509Factory should recognize PEM headers In-Reply-To: <4C5301FF.5020902@oracle.com> References: <4C52739F.6070208@sun.com> <4C5301FF.5020902@oracle.com> Message-ID: Yes, you're correct. I regard "not-working" -> "working" a fix, not a regression. Thanks Max On Jul 31, 2010, at 12:46 AM, Sean Mullan wrote: > Hi Max, > > I'm not sure about this change. There's a definitely a change in behavior. Before generateCertificate would only read one PEM block from the stream, and throw an exception if it wasn't a certificate. But the current fix ignores non certificate blocks until it finds a certificate or end of stream, right? > > --Sean > > On 7/30/10 2:39 AM, Weijun Wang wrote: >> Hi Sean >> >> 6973371: X509Factory should recognize PEM headers >> >> Please review the webrev: >> http://cr.openjdk.java.net/~weijun/6973371/webrev.00/ >> >> There is one place I haven't touched, generateCertPath. PKCS #7 PEM >> block should begin with -----BEGIN PKCS7-----, or as described in [1], >> with -----BEGIN CERTIFICATE-----. But what about a PKIPATH data block? >> >> Thanks >> Max >> >> >> === *Description* >> ============================================================ >> Currently, when X509Factory tries to read certificate or CRL from a PEM >> file, it simply finds a block starting with "-----BEGIN STH-----" and >> ending with "-----END STH-----", and does not care what this STH is at all. >> >> There are third-party tools that generates a PEM file containing >> different kinds of PEM blocks. For example, "openssl pkcs12" can read in >> a PKCS #12 file and output private key and certficates into a single PEM >> file. If we want Java to read certificates from this file, we must take >> care to remove any private key block first. This is quite troublesome. >> >> *** (#1 of 1): 2010-07-30 03:40:21 GMT+00:00 weijun.wang at sun.com >> >> [1] http://www.openssl.org/docs/apps/pkcs7.html#NOTES