From bradford.wetmore at oracle.com Mon Jan 3 13:30:07 2011 From: bradford.wetmore at oracle.com (Brad Wetmore) Date: Mon, 03 Jan 2011 13:30:07 -0800 Subject: Please Review: required security algorithms for Java SE 7 implementations In-Reply-To: <4D1A0539.80600@oracle.com> References: <4D08DA8F.70607@oracle.com> <4D1A0539.80600@oracle.com> Message-ID: <4D223FDF.2060201@oracle.com> Sean, I didn't check that anything else changed, but textually looks good. One comment: you should consider including a link to RFC 5746 like we do for all of the other RFCs. If you have time, can you also add the link to the RFC where the TLS_EMPTY_RENEGOTIATION_INFO_SCSV is defined? And there were a couple spots in: http://cr.openjdk.java.net/~mullan/5001004/review.02/StandardNames.html#alg that are also missing the links to the RFC. Thanks, Brad On 12/28/2010 7:41 AM, Sean Mullan wrote: > I have posted the 3rd revision of the required algorithms list at: > > http://cr.openjdk.java.net/~mullan/5001004/review.02/StandardNames.html#impl > > > Changes since the initial (00) version are: > > - added MD5 and HmacMD5 to the required algorithms > - added the CertPath Encodings PKCS7 and PkiPath to the required algorithms > - specified that a TLSv1 implementation must also support the special > signaling cipher suite TLS_EMPTY_RENEGOTIATION_INFO_SCSV for safe > renegotiation (see RFC 5746) > > Unless there are any further substantial comments, the plan is to > proceed with this list for JDK 7. > > Thanks, > Sean > > On 12/15/10 10:11 AM, Sean Mullan wrote: >> Hello, >> >> Currently, the Java security APIs do not specify algorithm >> requirements for >> implementations of Java SE. This makes it difficult to develop >> conformance >> tests. Additionally, there is no guarantee that Java applications >> using these >> algorithms can inter-operate. See bug 5001004 for more information: >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5001004 >> >> We will be addressing this issue in Java SE 7 by defining a list of >> required >> algorithms that all implementations must support. This is the criteria >> we used >> to decide if an algorithm should be required: >> >> a) the algorithm is required by the JRE itself (ex: when validating >> signed jars) >> b) the algorithm is required by a higher level Java SE API such as >> JSSE/TLS or >> XML Signature >> c) the algorithm is in wide use >> >> Please review the following list: >> http://cr.openjdk.java.net/~mullan/5001004/review.00/StandardNames.html#impl >> >> >> For each required algorithm, a corresponding section will be added to >> the API >> class summary of the applicable engine class. For example, for >> java.security.cert.CertificateFactory, the following paragraph will be >> added: >> >> Every implementation of the Java platform is required to support the >> following standard CertificateFactory type: >> >> * X.509 >> >> This type is described in the CertificateFactory section of the Java >> Cryptography Architecture Standard Algorithm Names Document. Consult >> the release documentation for your implementation to see if any other >> types are supported. >> >> We are requesting feedback or any questions by December 22. >> >> Thanks, >> Sean >> >> >> >> From alan.bateman at oracle.com Tue Jan 4 10:02:02 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 04 Jan 2011 18:02:02 +0000 Subject: hg: jdk7/tl/jdk: 7010192: InetAddress.isReachable hits ShouldNotReachHere with hs20-b04 (win) Message-ID: <20110104180211.907A947972@hg.openjdk.java.net> Changeset: 6f2d19ef67b1 Author: alanb Date: 2011-01-04 17:49 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6f2d19ef67b1 7010192: InetAddress.isReachable hits ShouldNotReachHere with hs20-b04 (win) Reviewed-by: chegar ! src/windows/native/java/net/Inet4AddressImpl.c ! src/windows/native/java/net/Inet6AddressImpl.c From xueming.shen at oracle.com Tue Jan 4 14:13:00 2011 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 04 Jan 2011 22:13:00 +0000 Subject: hg: jdk7/tl/jdk: 7009618: regression test failed caused by the fix for 7003462 Message-ID: <20110104221317.3D89B4797B@hg.openjdk.java.net> Changeset: 4379c762ec50 Author: sherman Date: 2011-01-04 14:17 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4379c762ec50 7009618: regression test failed caused by the fix for 7003462 Summary: avoid caching the "ended" Inflater in ZipFile class Reviewed-by: alanb ! src/share/classes/java/util/zip/Inflater.java ! src/share/classes/java/util/zip/ZipFile.java + test/java/util/zip/ZipFile/FinalizeZipFile.java From lana.steuck at oracle.com Tue Jan 4 17:44:27 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 05 Jan 2011 01:44:27 +0000 Subject: hg: jdk7/tl: 6 new changesets Message-ID: <20110105014428.3AAD247983@hg.openjdk.java.net> Changeset: 4346ba98938b Author: ohair Date: 2010-12-21 16:44 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/4346ba98938b 6360517: ALT_MSDEVTOOLS_PATH and rc.exe location, and rebase location Reviewed-by: ksrini ! Makefile ! README-builds.html Changeset: dc9eb519c6ed Author: ohair Date: 2010-12-22 12:25 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/dc9eb519c6ed 7003845: README-builds document proper location of forest extension, provide alternatives Reviewed-by: robilad ! README ! README-builds.html + get_source.sh + make/scripts/hgforest.sh Changeset: 4d044e6e1080 Author: ohair Date: 2010-12-22 12:27 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/4d044e6e1080 Merge ! README-builds.html Changeset: c1af03f88627 Author: ohair Date: 2010-12-23 18:41 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/c1af03f88627 7008723: Remove binary plugs creation and use from openjdk Reviewed-by: mchung, andrew, aph, dholmes ! Makefile ! README-builds.html Changeset: d0eb51cc458a Author: ohair Date: 2010-12-24 11:16 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/d0eb51cc458a Merge Changeset: 024a6755895b Author: ohair Date: 2010-12-28 15:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/024a6755895b 6962318: Update copyright year Reviewed-by: xdono ! make/Defs-internal.gmk ! make/deploy-rules.gmk ! make/hotspot-rules.gmk ! make/install-rules.gmk ! make/jprt.gmk ! make/sanity-rules.gmk + make/scripts/update_copyright_year.sh From lana.steuck at oracle.com Tue Jan 4 17:44:34 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 05 Jan 2011 01:44:34 +0000 Subject: hg: jdk7/tl/corba: 6962318: Update copyright year Message-ID: <20110105014435.C846947984@hg.openjdk.java.net> Changeset: f90b3e014e83 Author: ohair Date: 2010-12-28 15:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/f90b3e014e83 6962318: Update copyright year Reviewed-by: xdono ! make/Makefile ! make/com/sun/corba/minclude/com_sun_corba_se_impl_io.jmk ! make/common/Defs-linux.gmk ! make/common/Defs-solaris.gmk ! make/common/Defs-windows.gmk ! make/common/Defs.gmk ! make/common/Rules.gmk ! make/common/shared/Defs-java.gmk ! make/common/shared/Defs-linux.gmk ! make/common/shared/Defs-solaris.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Defs.gmk ! make/org/omg/idl/Makefile ! make/sun/corba/Makefile ! make/sun/corba/core/Makefile ! make/sun/rmi/rmic/FILES.gmk ! src/share/classes/com/sun/corba/se/impl/encoding/BufferManagerWriteStream.java ! src/share/classes/com/sun/corba/se/impl/interceptors/ClientRequestInfoImpl.java ! src/share/classes/com/sun/corba/se/impl/interceptors/PIHandlerImpl.java ! src/share/classes/com/sun/corba/se/impl/interceptors/PINoOpHandlerImpl.java ! src/share/classes/com/sun/corba/se/impl/interceptors/RequestInfoImpl.java ! src/share/classes/com/sun/corba/se/impl/io/IIOPInputStream.java ! src/share/classes/com/sun/corba/se/impl/io/ObjectStreamClass.java ! src/share/classes/com/sun/corba/se/impl/orbutil/CorbaResourceUtil.java ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_pt_BR.properties ! src/share/classes/com/sun/corba/se/impl/presentation/rmi/ExceptionHandlerImpl.java ! src/share/classes/com/sun/corba/se/impl/transport/SocketOrChannelConnectionImpl.java ! src/share/classes/com/sun/corba/se/pept/transport/ConnectionCache.java ! src/share/classes/com/sun/corba/se/spi/protocol/PIHandler.java ! src/share/classes/com/sun/corba/se/spi/transport/CorbaConnection.java ! src/share/classes/com/sun/tools/corba/se/idl/constExpr/Expression.java ! src/share/classes/javax/rmi/PortableRemoteObject.java ! src/share/classes/org/omg/CORBA/ORB.java ! src/share/classes/org/omg/CORBA/SetOverrideType.java ! src/share/classes/org/omg/CORBA/TCKind.java ! src/share/classes/org/omg/CORBA/UnknownUserException.java ! src/share/classes/org/omg/CORBA/portable/ServantObject.java ! src/share/classes/org/omg/CosNaming/nameservice.idl ! src/share/classes/org/omg/PortableInterceptor/Interceptors.idl ! src/share/classes/sun/corba/Bridge.java From lana.steuck at oracle.com Tue Jan 4 17:45:14 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 05 Jan 2011 01:45:14 +0000 Subject: hg: jdk7/tl/hotspot: 7 new changesets Message-ID: <20110105014528.392D447985@hg.openjdk.java.net> Changeset: cd8189d84e92 Author: trims Date: 2010-12-22 19:20 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/cd8189d84e92 Added tag hs20-b04 for changeset 9669f9b28410 ! .hgtags Changeset: b03260081e9b Author: johnc Date: 2010-12-17 11:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b03260081e9b 7006113: G1: Initialize ReferenceProcessor::_is_alive_non_header field Summary: Initialize the _is_alive_non_header field of G1's reference processor with an instance of the G1CMIsAliveClosure. This will stop adding reference objects with live referents to the discovered reference lists unnecessarily. Reviewed-by: tonyp, ysr, jwilhelm, brutisso ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp Changeset: 74ee0db180fa Author: ysr Date: 2010-12-17 23:41 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/74ee0db180fa 6807801: CMS: could save/restore fewer header words during scavenge Summary: Age bits need not enter the mark-word preservation calculus; also affected, in addition to CMS, per CR synopsis above, were ParNew (but not DefNew), ParallelScavenge and G1, albeit to a lesser degree than CMS. Reviewed-by: tonyp, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/defNewGeneration.hpp ! src/share/vm/oops/markOop.inline.hpp Changeset: 7c5250dbd584 Author: tonyp Date: 2010-12-19 20:57 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7c5250dbd584 6896624: G1: hotspot:::gc and hotspot:::mem-pool-gc probes are not fired Summary: Fire the gc-begin and gc-end probes for G1. Reviewed-by: kamg, ysr, jcoomes ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/shared/vmGCOperations.hpp Changeset: 9026f05dc736 Author: johnc Date: 2010-12-23 12:19 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/9026f05dc736 Merge Changeset: 5ef9917b908d Author: trims Date: 2010-12-24 07:59 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5ef9917b908d 7008759: Bump the HS20 build number to 05 Summary: Update the HS20 build number to 05 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 0a8e0d4345b3 Author: trims Date: 2011-01-03 15:30 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/0a8e0d4345b3 7010068: Update all 2010 Oracle-changed OpenJDK files to have the proper copyright dates - first pass Summary: Update the copyright to be 2010 on all changed files in OpenJDK Reviewed-by: jcoomes ! agent/src/os/linux/libproc_impl.c ! agent/src/os/linux/ps_core.c ! agent/src/os/linux/ps_proc.c ! agent/src/os/linux/symtab.c ! agent/src/os/linux/symtab.h ! agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeInvoke.java ! agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeWithCPIndex.java ! agent/src/share/classes/sun/jvm/hotspot/interpreter/Bytecodes.java ! agent/src/share/classes/sun/jvm/hotspot/memory/CompactibleFreeListSpace.java ! agent/src/share/classes/sun/jvm/hotspot/memory/SystemDictionary.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolCache.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolCacheEntry.java ! agent/src/share/classes/sun/jvm/hotspot/oops/GenerateOopMap.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Oop.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ByteCodeRewriter.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js ! make/hotspot_distro ! make/hotspot_version ! make/jprt.gmk ! make/jprt.properties ! make/linux/makefiles/defs.make ! make/linux/makefiles/jvmti.make ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/linux/makefiles/product.make ! make/linux/makefiles/saproc.make ! make/linux/makefiles/shark.make ! make/linux/makefiles/sparcWorks.make ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/fastdebug.make ! make/solaris/makefiles/jvmti.make ! make/solaris/makefiles/optimized.make ! make/solaris/makefiles/product.make ! make/solaris/makefiles/saproc.make ! make/windows/build.bat ! make/windows/get_msc_ver.sh ! make/windows/makefiles/defs.make ! make/windows/makefiles/sanity.make ! src/os/solaris/dtrace/hotspot.d ! src/os_cpu/linux_x86/vm/linux_x86_32.s ! src/os_cpu/solaris_x86/vm/solaris_x86_32.il ! src/os_cpu/solaris_x86/vm/solaris_x86_32.s ! src/os_cpu/solaris_x86/vm/solaris_x86_64.il ! test/Makefile ! test/compiler/6431242/Test.java ! test/compiler/6857159/Test6857159.java ! test/compiler/6877254/Test.java ! test/compiler/6895383/Test.java ! test/compiler/6896727/Test.java From lana.steuck at oracle.com Tue Jan 4 17:45:59 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 05 Jan 2011 01:45:59 +0000 Subject: hg: jdk7/tl/jaxp: 2 new changesets Message-ID: <20110105014559.EB2D747986@hg.openjdk.java.net> Changeset: 57ed1f3bec72 Author: ohair Date: 2010-12-28 15:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/57ed1f3bec72 6962318: Update copyright year Reviewed-by: xdono ! build.properties ! make/Makefile Changeset: 3a829f5ba9d2 Author: lana Date: 2011-01-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/3a829f5ba9d2 Merge From lana.steuck at oracle.com Tue Jan 4 17:46:05 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 05 Jan 2011 01:46:05 +0000 Subject: hg: jdk7/tl/jaxws: 2 new changesets Message-ID: <20110105014605.0B6CC47987@hg.openjdk.java.net> Changeset: 86f60e5b3975 Author: ohair Date: 2010-12-28 15:53 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/86f60e5b3975 6962318: Update copyright year Reviewed-by: xdono ! build.properties ! jaxws.properties ! make/Makefile Changeset: 466e89f7e5be Author: lana Date: 2011-01-04 16:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/466e89f7e5be Merge ! jaxws.properties From lana.steuck at oracle.com Tue Jan 4 17:46:47 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 05 Jan 2011 01:46:47 +0000 Subject: hg: jdk7/tl/jdk: 6 new changesets Message-ID: <20110105014752.DBAE447988@hg.openjdk.java.net> Changeset: 4e70663f0163 Author: ohair Date: 2010-12-21 18:21 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4e70663f0163 6360517: ALT_MSDEVTOOLS_PATH and rc.exe location, and rebase location Reviewed-by: ksrini ! make/Makefile ! make/common/shared/Compiler-gcc.gmk ! make/common/shared/Compiler-msvc.gmk ! make/common/shared/Defs-solaris.gmk ! make/common/shared/Defs-versions.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Defs.gmk ! make/common/shared/Sanity-Settings.gmk ! make/common/shared/Sanity.gmk ! make/jdk_generic_profile.sh Changeset: 217c842d710b Author: ohair Date: 2010-12-23 18:50 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/217c842d710b 7008723: Remove binary plugs creation and use from openjdk Reviewed-by: mchung, andrew, aph, dholmes ! README ! make/Makefile ! make/com/sun/jmx/Makefile ! make/common/Defs.gmk ! make/common/Library.gmk ! make/common/Program.gmk ! make/common/Release.gmk ! make/common/Sanity.gmk - make/common/internal/BinaryPlugs.gmk ! make/common/shared/Sanity-Settings.gmk ! make/common/shared/Sanity.gmk ! make/java/redist/Makefile ! make/javax/sound/Makefile ! make/jdk_generic_profile.sh ! make/netbeans/README ! make/sun/dcpr/Makefile ! make/sun/font/t2k/Makefile ! make/sun/management/Makefile Changeset: ab960e856d18 Author: ohair Date: 2010-12-24 11:17 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ab960e856d18 Merge - make/common/internal/BinaryPlugs.gmk ! make/common/shared/Defs-versions.gmk ! make/common/shared/Sanity.gmk Changeset: a06412e13bf7 Author: ohair Date: 2010-12-28 15:53 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a06412e13bf7 6962318: Update copyright year Reviewed-by: xdono ! make/com/Makefile ! make/com/sun/Makefile ! make/com/sun/crypto/provider/Makefile ! make/com/sun/demo/Makefile ! make/com/sun/demo/jvmti/Makefile ! make/com/sun/java/Makefile ! make/com/sun/java/browser/Makefile ! make/com/sun/java/pack/Makefile ! make/com/sun/java/pack/prop/Makefile ! make/com/sun/jmx/Makefile ! make/com/sun/jndi/Makefile ! make/com/sun/jndi/cosnaming/Makefile ! make/com/sun/jndi/dns/Makefile ! make/com/sun/jndi/ldap/Makefile ! make/com/sun/jndi/rmi/Makefile ! make/com/sun/jndi/rmi/registry/Makefile ! make/com/sun/nio/Makefile ! make/com/sun/nio/sctp/FILES_java.gmk ! make/com/sun/nio/sctp/Makefile ! make/com/sun/nio/sctp/mapfile-vers ! make/com/sun/org/Makefile ! make/com/sun/org/apache/Makefile ! make/com/sun/org/apache/xml/Makefile ! make/com/sun/rowset/Makefile ! make/com/sun/script/Makefile ! make/com/sun/security/Makefile ! make/com/sun/security/auth/module/Makefile ! make/com/sun/servicetag/Makefile ! make/com/sun/tools/Makefile ! make/com/sun/tools/attach/Makefile ! make/com/sun/tracing/Makefile ! make/common/Cscope.gmk ! make/common/Defs-linux.gmk ! make/common/Defs-solaris.gmk ! make/common/Defs-windows.gmk ! make/common/Defs.gmk ! make/common/Demo.gmk ! make/common/Library.gmk ! make/common/Modules.gmk ! make/common/Program.gmk ! make/common/Release.gmk ! make/common/Sanity.gmk ! make/common/internal/Resources.gmk ! make/common/shared/Compiler-sun.gmk ! make/common/shared/Defs-control.gmk ! make/common/shared/Defs-java.gmk ! make/common/shared/Defs-linux.gmk ! make/common/shared/Defs-utils.gmk ! make/docs/CORE_PKGS.gmk ! make/docs/NON_CORE_PKGS.gmk ! make/java/Makefile ! make/java/awt/Makefile ! make/java/dyn/Makefile ! make/java/fdlibm/Makefile ! make/java/hpi/Makefile ! make/java/hpi/hpi_common.gmk ! make/java/hpi/native/Makefile ! make/java/hpi/windows/Makefile ! make/java/instrument/Makefile ! make/java/java/Makefile ! make/java/java/genlocales.gmk ! make/java/java_crw_demo/Makefile ! make/java/java_hprof_demo/Makefile ! make/java/jli/Makefile ! make/java/logging/Makefile ! make/java/main/Makefile ! make/java/main/java/Makefile ! make/java/main/javaw/Makefile ! make/java/management/Makefile ! make/java/net/FILES_c.gmk ! make/java/net/Makefile ! make/java/net/mapfile-vers ! make/java/nio/FILES_java.gmk ! make/java/nio/Makefile ! make/java/nio/mapfile-linux ! make/java/nio/mapfile-solaris ! make/java/npt/Makefile ! make/java/redist/Makefile ! make/java/redist/fonts/Makefile ! make/java/redist/sajdi/Makefile ! make/java/sql/Makefile ! make/java/sun_nio/Makefile ! make/java/text/base/Makefile ! make/java/util/FILES_java.gmk ! make/java/verify/Makefile ! make/java/zip/Makefile ! make/javax/Makefile ! make/javax/crypto/Makefile ! make/javax/imageio/Makefile ! make/javax/print/Makefile ! make/javax/rmi/Makefile ! make/javax/sound/Makefile ! make/javax/sound/jsoundalsa/Makefile ! make/javax/sound/jsoundds/Makefile ! make/javax/sql/Makefile ! make/javax/swing/FILES.gmk ! make/javax/swing/Makefile ! make/javax/swing/beaninfo/SwingBeans.gmk ! make/javax/swing/plaf/Makefile ! make/jpda/Makefile ! make/jpda/back/Makefile ! make/jpda/transport/Makefile ! make/jpda/transport/shmem/Makefile ! make/jpda/transport/socket/Makefile ! make/jpda/tty/Makefile ! make/jprt.gmk ! make/jprt.properties ! make/launchers/Makefile ! make/mkdemo/Makefile ! make/mkdemo/applets/Makefile ! make/mkdemo/jfc/Makefile ! make/mkdemo/jni/Makefile ! make/mkdemo/jvmti/hprof/Makefile ! make/mkdemo/management/Makefile ! make/mkdemo/nio/Makefile ! make/mkdemo/nio/zipfs/Makefile ! make/mkdemo/scripting/Makefile ! make/mksample/Makefile ! make/mksample/dtrace/Makefile ! make/mksample/jmx/Makefile ! make/mksample/jmx/jmx-scandir/Makefile ! make/mksample/nbproject/Makefile ! make/mksample/nio/Makefile ! make/mksample/nio/file/Makefile ! make/mksample/nio/multicast/Makefile ! make/mksample/nio/server/Makefile ! make/mksample/scripting/Makefile ! make/mksample/scripting/scriptpad/Makefile ! make/mksample/webservices/EbayClient/Makefile ! make/mksample/webservices/EbayServer/Makefile ! make/mksample/webservices/Makefile ! make/modules/Makefile ! make/modules/modules.config ! make/modules/optional.depconfig ! make/modules/tools/Makefile ! make/modules/tools/nbproject/project.properties ! make/modules/tools/src/com/sun/classanalyzer/Module.java ! make/netbeans/world/build.xml ! make/org/Makefile ! make/org/ietf/Makefile ! make/sun/Makefile ! make/sun/applet/Makefile ! make/sun/awt/FILES_c_unix.gmk ! make/sun/awt/FILES_c_windows.gmk ! make/sun/awt/FILES_export_unix.gmk ! make/sun/awt/FILES_export_windows.gmk ! make/sun/awt/Makefile ! make/sun/awt/mapfile-mawt-vers ! make/sun/awt/mapfile-vers ! make/sun/awt/mapfile-vers-linux ! make/sun/cmm/Makefile ! make/sun/cmm/kcms/Makefile ! make/sun/cmm/lcms/FILES_c_unix.gmk ! make/sun/cmm/lcms/FILES_c_windows.gmk ! make/sun/cmm/lcms/Makefile ! make/sun/dcpr/Makefile ! make/sun/font/FILES_c.gmk ! make/sun/font/Makefile ! make/sun/font/t2k/Makefile ! make/sun/headless/Makefile ! make/sun/headless/mapfile-vers ! make/sun/image/Makefile ! make/sun/image/generic/Makefile ! make/sun/image/vis/Makefile ! make/sun/jar/Makefile ! make/sun/javazic/Makefile ! make/sun/jawt/Makefile ! make/sun/jconsole/Makefile ! make/sun/jdbc/Makefile ! make/sun/jdga/Makefile ! make/sun/jkernel/Makefile ! make/sun/jpeg/Makefile ! make/sun/launcher/Makefile ! make/sun/management/Makefile ! make/sun/native2ascii/Makefile ! make/sun/net/FILES_java.gmk ! make/sun/net/Makefile ! make/sun/net/others/Makefile ! make/sun/net/spi/Makefile ! make/sun/net/spi/nameservice/Makefile ! make/sun/net/spi/nameservice/dns/Makefile ! make/sun/nio/Makefile ! make/sun/nio/cs/FILES_java.gmk ! make/sun/nio/cs/Makefile ! make/sun/org/Makefile ! make/sun/org/mozilla/Makefile ! make/sun/org/mozilla/javascript/Makefile ! make/sun/pisces/Makefile ! make/sun/rmi/Makefile ! make/sun/rmi/cgi/Makefile ! make/sun/rmi/oldtools/Makefile ! make/sun/rmi/registry/Makefile ! make/sun/rmi/rmi/Makefile ! make/sun/rmi/rmic/Makefile ! make/sun/rmi/rmid/Makefile ! make/sun/security/Makefile ! make/sun/security/ec/Makefile ! make/sun/security/jgss/wrapper/Makefile ! make/sun/security/krb5/Makefile ! make/sun/security/mscapi/Makefile ! make/sun/security/pkcs11/Makefile ! make/sun/security/smartcardio/Makefile ! make/sun/serialver/Makefile ! make/sun/splashscreen/Makefile ! make/sun/text/Makefile ! make/sun/tools/Makefile ! make/sun/tracing/Makefile ! make/sun/tracing/dtrace/Makefile ! make/sun/xawt/FILES_c_unix.gmk ! make/sun/xawt/FILES_export_unix.gmk ! make/sun/xawt/Makefile ! make/sun/xawt/mapfile-vers ! make/tools/Makefile ! make/tools/freetypecheck/freetypecheck.c ! make/tools/src/build/tools/charsetmapping/JIS0213.java ! make/tools/src/build/tools/charsetmapping/Main.java ! make/tools/src/build/tools/charsetmapping/SBCS.java ! make/tools/src/build/tools/charsetmapping/Utils.java ! make/tools/src/build/tools/generatecharacter/GenerateCharacter.java ! make/tools/src/build/tools/jarreorder/JarReorder.java ! make/tools/src/build/tools/javazic/RuleDay.java ! src/share/bin/main.c ! src/share/bin/parse_manifest.c ! src/share/bin/wildcard.c ! src/share/classes/com/sun/imageio/plugins/bmp/BMPImageReaderSpi.java ! src/share/classes/com/sun/imageio/plugins/bmp/BMPImageWriterSpi.java ! src/share/classes/com/sun/imageio/plugins/gif/GIFImageReaderSpi.java ! src/share/classes/com/sun/imageio/plugins/gif/GIFImageWriterSpi.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEG.java ! src/share/classes/com/sun/imageio/plugins/png/PNGImageReaderSpi.java ! src/share/classes/com/sun/imageio/plugins/png/PNGImageWriterSpi.java ! src/share/classes/com/sun/imageio/plugins/wbmp/WBMPImageReaderSpi.java ! src/share/classes/com/sun/imageio/plugins/wbmp/WBMPImageWriterSpi.java ! src/share/classes/com/sun/imageio/spi/FileImageInputStreamSpi.java ! src/share/classes/com/sun/imageio/spi/FileImageOutputStreamSpi.java ! src/share/classes/com/sun/imageio/spi/InputStreamImageInputStreamSpi.java ! src/share/classes/com/sun/imageio/spi/OutputStreamImageOutputStreamSpi.java ! src/share/classes/com/sun/imageio/spi/RAFImageInputStreamSpi.java ! src/share/classes/com/sun/imageio/spi/RAFImageOutputStreamSpi.java ! src/share/classes/com/sun/java/swing/plaf/gtk/PangoFonts.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsComboBoxUI.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTableHeaderUI.java ! src/share/classes/com/sun/java/util/jar/pack/AdaptiveCoding.java ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/ClassWriter.java ! src/share/classes/com/sun/java/util/jar/pack/Code.java ! src/share/classes/com/sun/java/util/jar/pack/Coding.java ! src/share/classes/com/sun/java/util/jar/pack/CodingChooser.java ! src/share/classes/com/sun/java/util/jar/pack/CodingMethod.java ! src/share/classes/com/sun/java/util/jar/pack/Fixups.java ! src/share/classes/com/sun/java/util/jar/pack/Histogram.java ! src/share/classes/com/sun/java/util/jar/pack/Instruction.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/classes/com/sun/java/util/jar/pack/PopulationCoding.java ! src/share/classes/com/sun/jndi/dns/DnsClient.java ! src/share/classes/com/sun/jndi/rmi/registry/RegistryContext.java ! src/share/classes/com/sun/media/sound/AbstractMidiDevice.java ! src/share/classes/com/sun/media/sound/AudioSynthesizerPropertyInfo.java ! src/share/classes/com/sun/media/sound/ModelByteBufferWavetable.java ! src/share/classes/com/sun/media/sound/ModelInstrument.java ! src/share/classes/com/sun/media/sound/SoftReceiver.java ! src/share/classes/com/sun/media/sound/SoftVoice.java ! src/share/classes/com/sun/net/httpserver/BasicAuthenticator.java ! src/share/classes/com/sun/net/httpserver/Filter.java ! src/share/classes/com/sun/net/httpserver/Headers.java ! src/share/classes/com/sun/net/httpserver/HttpsConfigurator.java ! src/share/classes/com/sun/net/httpserver/HttpsParameters.java ! src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java ! src/share/classes/com/sun/security/auth/LdapPrincipal.java ! src/share/classes/com/sun/security/sasl/CramMD5Client.java ! src/share/classes/com/sun/security/sasl/CramMD5Server.java ! src/share/classes/com/sun/security/sasl/ExternalClient.java ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Client.java ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Server.java ! src/share/classes/com/sun/servicetag/Registry.java ! src/share/classes/com/sun/servicetag/SunConnection.java ! src/share/classes/com/sun/servicetag/resources/register.html ! src/share/classes/com/sun/servicetag/resources/register_ja.html ! src/share/classes/com/sun/servicetag/resources/register_zh_CN.html ! src/share/classes/com/sun/tools/example/debug/tty/TTYResources.java ! src/share/classes/java/awt/AWTEvent.java ! src/share/classes/java/awt/AlphaComposite.java ! src/share/classes/java/awt/Canvas.java ! src/share/classes/java/awt/Color.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/Dialog.java ! src/share/classes/java/awt/EventDispatchThread.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/java/awt/FileDialog.java ! src/share/classes/java/awt/Font.java ! src/share/classes/java/awt/Frame.java ! src/share/classes/java/awt/GraphicsEnvironment.java ! src/share/classes/java/awt/GridBagConstraints.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/ScrollPane.java ! src/share/classes/java/awt/Scrollbar.java ! src/share/classes/java/awt/SequencedEvent.java ! src/share/classes/java/awt/SplashScreen.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/event/ActionEvent.java ! src/share/classes/java/awt/event/InputEvent.java ! src/share/classes/java/awt/image/IndexColorModel.java ! src/share/classes/java/awt/image/SampleModel.java ! src/share/classes/java/beans/MetaData.java ! src/share/classes/java/beans/XMLDecoder.java ! src/share/classes/java/dyn/Linkage.java ! src/share/classes/java/dyn/MethodType.java ! src/share/classes/java/dyn/package-info.java ! src/share/classes/java/io/Bits.java ! src/share/classes/java/io/BufferedInputStream.java ! src/share/classes/java/io/ByteArrayInputStream.java ! src/share/classes/java/io/ByteArrayOutputStream.java ! src/share/classes/java/io/Closeable.java ! src/share/classes/java/io/FileOutputStream.java ! src/share/classes/java/io/FilterInputStream.java ! src/share/classes/java/io/ObjectInput.java ! src/share/classes/java/io/ObjectOutput.java ! src/share/classes/java/io/PushbackInputStream.java ! src/share/classes/java/io/package.html ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/lang/AssertionError.java ! src/share/classes/java/lang/Deprecated.java ! src/share/classes/java/lang/Error.java ! src/share/classes/java/lang/Exception.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Iterable.java ! src/share/classes/java/lang/Math.java ! src/share/classes/java/lang/Object.java ! src/share/classes/java/lang/ProcessBuilder.java ! src/share/classes/java/lang/Readable.java ! src/share/classes/java/lang/RuntimeException.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/SuppressWarnings.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/Thread.java ! src/share/classes/java/lang/ThreadGroup.java ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/net/AbstractPlainSocketImpl.java ! src/share/classes/java/net/DatagramSocket.java ! src/share/classes/java/net/HttpCookie.java ! src/share/classes/java/net/HttpURLConnection.java ! src/share/classes/java/net/Inet6Address.java ! src/share/classes/java/net/InetAddress.java ! src/share/classes/java/net/NetPermission.java ! src/share/classes/java/net/NetworkInterface.java ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/java/net/SocketInputStream.java ! src/share/classes/java/net/SocksSocketImpl.java ! src/share/classes/java/net/URI.java ! src/share/classes/java/nio/Bits.java ! src/share/classes/java/nio/Direct-X-Buffer.java.template ! src/share/classes/java/nio/MappedByteBuffer.java ! src/share/classes/java/nio/StringCharBuffer.java ! src/share/classes/java/nio/channels/AsynchronousSocketChannel.java ! src/share/classes/java/nio/channels/FileLock.java ! src/share/classes/java/nio/channels/package-info.java ! src/share/classes/java/nio/channels/spi/AbstractInterruptibleChannel.java ! src/share/classes/java/nio/channels/spi/AbstractSelector.java ! src/share/classes/java/nio/channels/spi/AsynchronousChannelProvider.java ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/java/nio/charset/package.html ! src/share/classes/java/nio/file/DirectoryStream.java ! src/share/classes/java/nio/file/FileTreeWalker.java ! src/share/classes/java/nio/file/FileVisitOption.java ! src/share/classes/java/nio/file/FileVisitor.java ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/file/Path.java ! src/share/classes/java/nio/file/SecureDirectoryStream.java ! src/share/classes/java/nio/file/SimpleFileVisitor.java ! src/share/classes/java/security/IdentityScope.java ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/cert/PKIXParameters.java ! src/share/classes/java/text/CollationElementIterator.java ! src/share/classes/java/text/DateFormat.java ! src/share/classes/java/text/MessageFormat.java ! src/share/classes/java/text/NumberFormat.java ! src/share/classes/java/text/RuleBasedBreakIterator.java ! src/share/classes/java/util/AbstractCollection.java ! src/share/classes/java/util/AbstractList.java ! src/share/classes/java/util/AbstractMap.java ! src/share/classes/java/util/ArrayList.java ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/Collection.java ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/ConcurrentModificationException.java ! src/share/classes/java/util/Currency.java ! src/share/classes/java/util/Date.java ! src/share/classes/java/util/FormattableFlags.java ! src/share/classes/java/util/Formatter.java ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/Iterator.java ! src/share/classes/java/util/LinkedList.java ! src/share/classes/java/util/List.java ! src/share/classes/java/util/ListResourceBundle.java ! src/share/classes/java/util/PriorityQueue.java ! src/share/classes/java/util/Properties.java ! src/share/classes/java/util/Random.java ! src/share/classes/java/util/Scanner.java ! src/share/classes/java/util/Stack.java ! src/share/classes/java/util/TreeMap.java ! src/share/classes/java/util/TreeSet.java ! src/share/classes/java/util/Vector.java ! src/share/classes/java/util/XMLUtils.java ! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java ! src/share/classes/java/util/jar/JarInputStream.java ! src/share/classes/java/util/logging/LogRecord.java ! src/share/classes/java/util/regex/Pattern.java ! src/share/classes/java/util/spi/CurrencyNameProvider.java ! src/share/classes/java/util/spi/LocaleServiceProvider.java ! src/share/classes/java/util/zip/Deflater.java ! src/share/classes/java/util/zip/ZipFile.java ! src/share/classes/javax/imageio/stream/ImageInputStream.java ! src/share/classes/javax/management/remote/JMXServiceURL.java ! src/share/classes/javax/naming/event/EventDirContext.java ! src/share/classes/javax/naming/ldap/Control.java ! src/share/classes/javax/naming/ldap/ControlFactory.java ! src/share/classes/javax/naming/ldap/ExtendedRequest.java ! src/share/classes/javax/naming/ldap/ExtendedResponse.java ! src/share/classes/javax/naming/ldap/LdapName.java ! src/share/classes/javax/naming/ldap/Rdn.java ! src/share/classes/javax/naming/ldap/UnsolicitedNotification.java ! src/share/classes/javax/naming/ldap/UnsolicitedNotificationListener.java ! src/share/classes/javax/net/SocketFactory.java ! src/share/classes/javax/net/ssl/SSLContext.java ! src/share/classes/javax/print/DocFlavor.java ! src/share/classes/javax/sound/midi/MidiDevice.java ! src/share/classes/javax/sound/midi/MidiSystem.java ! src/share/classes/javax/sound/midi/Receiver.java ! src/share/classes/javax/sound/midi/Transmitter.java ! src/share/classes/javax/sound/sampled/Line.java ! src/share/classes/javax/swing/AbstractButton.java ! src/share/classes/javax/swing/DebugGraphics.java ! src/share/classes/javax/swing/DefaultDesktopManager.java ! src/share/classes/javax/swing/GroupLayout.java ! src/share/classes/javax/swing/JColorChooser.java ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JDesktopPane.java ! src/share/classes/javax/swing/JEditorPane.java ! src/share/classes/javax/swing/JLayer.java ! src/share/classes/javax/swing/JList.java ! src/share/classes/javax/swing/JSplitPane.java ! src/share/classes/javax/swing/JTabbedPane.java ! src/share/classes/javax/swing/JTextField.java ! src/share/classes/javax/swing/JTree.java ! src/share/classes/javax/swing/JViewport.java ! src/share/classes/javax/swing/Popup.java ! src/share/classes/javax/swing/RepaintManager.java ! src/share/classes/javax/swing/SwingUtilities.java ! src/share/classes/javax/swing/ToolTipManager.java ! src/share/classes/javax/swing/UIDefaults.java ! src/share/classes/javax/swing/plaf/LayerUI.java ! src/share/classes/javax/swing/plaf/basic/BasicButtonListener.java ! src/share/classes/javax/swing/plaf/basic/BasicComboPopup.java ! src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java ! src/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java ! src/share/classes/javax/swing/plaf/basic/BasicMenuUI.java ! src/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java ! src/share/classes/javax/swing/plaf/basic/BasicScrollPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicSliderUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTableHeaderUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTextUI.java ! src/share/classes/javax/swing/plaf/basic/BasicViewportUI.java ! src/share/classes/javax/swing/plaf/metal/MetalComboBoxUI.java ! src/share/classes/javax/swing/plaf/metal/MetalScrollPaneUI.java ! src/share/classes/javax/swing/plaf/nimbus/NimbusStyle.java ! src/share/classes/javax/swing/plaf/synth/SynthButtonUI.java ! src/share/classes/javax/swing/plaf/synth/SynthColorChooserUI.java ! src/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java ! src/share/classes/javax/swing/plaf/synth/SynthDesktopIconUI.java ! src/share/classes/javax/swing/plaf/synth/SynthDesktopPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthEditorPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthInternalFrameUI.java ! src/share/classes/javax/swing/plaf/synth/SynthLabelUI.java ! src/share/classes/javax/swing/plaf/synth/SynthListUI.java ! src/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuItemUI.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuUI.java ! src/share/classes/javax/swing/plaf/synth/SynthOptionPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthPanelUI.java ! src/share/classes/javax/swing/plaf/synth/SynthParser.java ! src/share/classes/javax/swing/plaf/synth/SynthPopupMenuUI.java ! src/share/classes/javax/swing/plaf/synth/SynthProgressBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthRootPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthScrollBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthScrollPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSeparatorUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSliderUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSpinnerUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSplitPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTableHeaderUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTableUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextAreaUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextFieldUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthToolBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthToolTipUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTreeUI.java ! src/share/classes/javax/swing/plaf/synth/SynthViewportUI.java ! src/share/classes/javax/swing/table/DefaultTableCellRenderer.java ! src/share/classes/javax/swing/text/DefaultCaret.java ! src/share/classes/javax/swing/text/DefaultEditorKit.java ! src/share/classes/javax/swing/text/DefaultFormatter.java ! src/share/classes/javax/swing/text/DefaultHighlighter.java ! src/share/classes/javax/swing/text/DefaultStyledDocument.java ! src/share/classes/javax/swing/text/GlyphView.java ! src/share/classes/javax/swing/text/InternationalFormatter.java ! src/share/classes/javax/swing/text/JTextComponent.java ! src/share/classes/javax/swing/text/MaskFormatter.java ! src/share/classes/javax/swing/text/NumberFormatter.java ! src/share/classes/javax/swing/text/PlainDocument.java ! src/share/classes/javax/swing/text/TabSet.java ! src/share/classes/javax/swing/text/Utilities.java ! src/share/classes/javax/swing/text/WrappedPlainView.java ! src/share/classes/javax/swing/text/html/FormView.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/javax/swing/text/html/MinimalHTMLWriter.java ! src/share/classes/javax/swing/text/html/StyleSheet.java ! src/share/classes/javax/swing/text/html/parser/Parser.java ! src/share/classes/javax/swing/text/rtf/AbstractFilter.java ! src/share/classes/sun/applet/resources/MsgAppletViewer.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_pt_BR.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_zh_CN.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/share/classes/sun/awt/EmbeddedFrame.java ! src/share/classes/sun/awt/HKSCS.java ! src/share/classes/sun/awt/PlatformFont.java ! src/share/classes/sun/awt/SunToolkit.java ! src/share/classes/sun/awt/UngrabEvent.java ! src/share/classes/sun/awt/dnd/SunDropTargetContextPeer.java ! src/share/classes/sun/awt/image/BufImgSurfaceData.java ! src/share/classes/sun/awt/image/ImageRepresentation.java ! src/share/classes/sun/awt/image/PNGImageDecoder.java ! src/share/classes/sun/dyn/AdapterMethodHandle.java ! src/share/classes/sun/dyn/BoundMethodHandle.java ! src/share/classes/sun/dyn/CallSiteImpl.java ! src/share/classes/sun/dyn/FilterGeneric.java ! src/share/classes/sun/dyn/FilterOneArgument.java ! src/share/classes/sun/dyn/FromGeneric.java ! src/share/classes/sun/dyn/Invokers.java ! src/share/classes/sun/dyn/MethodTypeImpl.java ! src/share/classes/sun/dyn/SpreadGeneric.java ! src/share/classes/sun/dyn/ToGeneric.java ! src/share/classes/sun/dyn/empty/Empty.java ! src/share/classes/sun/dyn/package-info.java ! src/share/classes/sun/dyn/util/BytecodeDescriptor.java ! src/share/classes/sun/dyn/util/BytecodeName.java ! src/share/classes/sun/dyn/util/ValueConversions.java ! src/share/classes/sun/dyn/util/VerifyAccess.java ! src/share/classes/sun/dyn/util/VerifyType.java ! src/share/classes/sun/dyn/util/Wrapper.java ! src/share/classes/sun/font/FontManagerFactory.java ! src/share/classes/sun/font/FontUtilities.java ! src/share/classes/sun/font/StrikeCache.java ! src/share/classes/sun/font/SunFontManager.java ! src/share/classes/sun/io/ByteToCharBig5.java ! src/share/classes/sun/io/ByteToCharBig5_HKSCS.java ! src/share/classes/sun/io/ByteToCharBig5_Solaris.java ! src/share/classes/sun/io/ByteToCharISO2022.java ! src/share/classes/sun/io/ByteToCharISO2022JP.java ! src/share/classes/sun/io/ByteToCharJISAutoDetect.java ! src/share/classes/sun/io/ByteToCharMS950_HKSCS.java ! src/share/classes/sun/io/ByteToCharUTF8.java ! src/share/classes/sun/io/CharToByteBig5.java ! src/share/classes/sun/io/CharToByteBig5_HKSCS.java ! src/share/classes/sun/io/CharToByteBig5_Solaris.java ! src/share/classes/sun/io/CharToByteDBCS_ASCII.java ! src/share/classes/sun/io/CharToByteDBCS_EBCDIC.java ! src/share/classes/sun/io/CharToByteMS950_HKSCS.java ! src/share/classes/sun/io/CharToBytePCK.java ! src/share/classes/sun/io/CharToByteUnicode.java ! src/share/classes/sun/io/Converters.java ! src/share/classes/sun/java2d/Disposer.java ! src/share/classes/sun/java2d/HeadlessGraphicsEnvironment.java ! src/share/classes/sun/java2d/SurfaceData.java ! src/share/classes/sun/java2d/cmm/CMSManager.java ! src/share/classes/sun/java2d/cmm/lcms/LCMS.java ! src/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java ! src/share/classes/sun/java2d/loops/DrawParallelogram.java ! src/share/classes/sun/java2d/loops/FillParallelogram.java ! src/share/classes/sun/java2d/loops/GraphicsPrimitive.java ! src/share/classes/sun/java2d/loops/RenderLoops.java ! src/share/classes/sun/java2d/pipe/BufferedPaints.java ! src/share/classes/sun/java2d/pipe/LoopPipe.java ! src/share/classes/sun/java2d/pipe/RenderBuffer.java ! src/share/classes/sun/java2d/pisces/Curve.java ! src/share/classes/sun/java2d/pisces/Dasher.java ! src/share/classes/sun/java2d/pisces/Helpers.java ! src/share/classes/sun/java2d/pisces/PiscesCache.java ! src/share/classes/sun/java2d/pisces/PiscesRenderingEngine.java ! src/share/classes/sun/java2d/pisces/Renderer.java ! src/share/classes/sun/java2d/pisces/Stroker.java ! src/share/classes/sun/java2d/pisces/TransformingPathConsumer2D.java ! src/share/classes/sun/jkernel/DownloadManager.java ! src/share/classes/sun/jvmstat/monitor/AbstractMonitor.java ! src/share/classes/sun/jvmstat/monitor/Monitor.java ! src/share/classes/sun/jvmstat/monitor/Units.java ! src/share/classes/sun/jvmstat/monitor/Variability.java ! src/share/classes/sun/jvmstat/perfdata/monitor/PerfByteArrayMonitor.java ! src/share/classes/sun/jvmstat/perfdata/monitor/PerfIntegerMonitor.java ! src/share/classes/sun/jvmstat/perfdata/monitor/PerfLongMonitor.java ! src/share/classes/sun/jvmstat/perfdata/monitor/PerfStringConstantMonitor.java ! src/share/classes/sun/jvmstat/perfdata/monitor/PerfStringMonitor.java ! src/share/classes/sun/jvmstat/perfdata/monitor/PerfStringVariableMonitor.java ! src/share/classes/sun/jvmstat/perfdata/monitor/v1_0/PerfDataBuffer.java ! src/share/classes/sun/jvmstat/perfdata/monitor/v2_0/PerfDataBuffer.java ! src/share/classes/sun/launcher/resources/launcher_de.properties ! src/share/classes/sun/launcher/resources/launcher_es.properties ! src/share/classes/sun/launcher/resources/launcher_fr.properties ! src/share/classes/sun/launcher/resources/launcher_it.properties ! src/share/classes/sun/launcher/resources/launcher_ja.properties ! src/share/classes/sun/launcher/resources/launcher_ko.properties ! src/share/classes/sun/launcher/resources/launcher_pt_BR.properties ! src/share/classes/sun/launcher/resources/launcher_sv.properties ! src/share/classes/sun/launcher/resources/launcher_zh_CN.properties ! src/share/classes/sun/launcher/resources/launcher_zh_TW.properties ! src/share/classes/sun/management/Flag.java ! src/share/classes/sun/management/resources/agent_de.properties ! src/share/classes/sun/management/resources/agent_es.properties ! src/share/classes/sun/management/resources/agent_fr.properties ! src/share/classes/sun/management/resources/agent_it.properties ! src/share/classes/sun/management/resources/agent_ja.properties ! src/share/classes/sun/management/resources/agent_ko.properties ! src/share/classes/sun/management/resources/agent_pt_BR.properties ! src/share/classes/sun/management/resources/agent_sv.properties ! src/share/classes/sun/management/resources/agent_zh_CN.properties ! src/share/classes/sun/management/resources/agent_zh_TW.properties ! src/share/classes/sun/misc/BootClassLoaderHook.java ! src/share/classes/sun/misc/Launcher.java ! src/share/classes/sun/misc/VM.java ! src/share/classes/sun/net/InetAddressCachePolicy.java ! src/share/classes/sun/net/NetworkClient.java ! src/share/classes/sun/net/ftp/impl/FtpClient.java ! src/share/classes/sun/net/httpserver/ChunkedInputStream.java ! src/share/classes/sun/net/httpserver/Event.java ! src/share/classes/sun/net/httpserver/ExchangeImpl.java ! src/share/classes/sun/net/httpserver/FixedLengthInputStream.java ! src/share/classes/sun/net/httpserver/HttpConnection.java ! src/share/classes/sun/net/httpserver/Request.java ! src/share/classes/sun/net/httpserver/SSLStreams.java ! src/share/classes/sun/net/httpserver/ServerConfig.java ! src/share/classes/sun/net/httpserver/ServerImpl.java ! src/share/classes/sun/net/www/MessageHeader.java ! src/share/classes/sun/net/www/MimeTable.java ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/protocol/file/FileURLConnection.java ! src/share/classes/sun/net/www/protocol/ftp/FtpURLConnection.java ! src/share/classes/sun/net/www/protocol/http/AuthenticationInfo.java ! src/share/classes/sun/net/www/protocol/http/BasicAuthentication.java ! src/share/classes/sun/nio/ch/AsynchronousSocketChannelImpl.java ! src/share/classes/sun/nio/ch/CompletedFuture.java ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/share/classes/sun/nio/ch/DatagramSocketAdaptor.java ! src/share/classes/sun/nio/ch/FileChannelImpl.java ! src/share/classes/sun/nio/ch/FileDispatcher.java ! src/share/classes/sun/nio/ch/IOUtil.java ! src/share/classes/sun/nio/ch/IOVecWrapper.java ! src/share/classes/sun/nio/ch/Interruptible.java ! src/share/classes/sun/nio/ch/ServerSocketAdaptor.java ! src/share/classes/sun/nio/ch/ServerSocketChannelImpl.java ! src/share/classes/sun/nio/ch/SocketAdaptor.java ! src/share/classes/sun/nio/ch/SocketChannelImpl.java ! src/share/classes/sun/nio/ch/Util.java ! src/share/classes/sun/nio/cs/AbstractCharsetProvider.java ! src/share/classes/sun/nio/cs/UTF_32Coder.java ! src/share/classes/sun/nio/cs/UTF_8.java ! src/share/classes/sun/nio/cs/UnicodeEncoder.java ! src/share/classes/sun/nio/cs/ext/Big5_HKSCS_2001.java ! src/share/classes/sun/nio/cs/ext/Big5_Solaris.java ! src/share/classes/sun/nio/cs/ext/DoubleByte.java ! src/share/classes/sun/nio/cs/ext/EUC_JP.java ! src/share/classes/sun/nio/cs/ext/EUC_JP_LINUX.java ! src/share/classes/sun/nio/cs/ext/EUC_JP_Open.java ! src/share/classes/sun/nio/cs/ext/EUC_TW.java ! src/share/classes/sun/nio/cs/ext/ExtendedCharsets.java ! src/share/classes/sun/nio/cs/ext/GB18030.java ! src/share/classes/sun/nio/cs/ext/IBM33722.java ! src/share/classes/sun/nio/cs/ext/IBM964.java ! src/share/classes/sun/nio/cs/ext/ISO2022.java ! src/share/classes/sun/nio/cs/ext/JISAutoDetect.java ! src/share/classes/sun/nio/cs/ext/MS950_HKSCS_XP.java ! src/share/classes/sun/nio/cs/ext/PCK.java ! src/share/classes/sun/nio/cs/ext/SJIS.java ! src/share/classes/sun/nio/fs/AbstractPath.java ! src/share/classes/sun/nio/fs/AbstractWatchKey.java ! src/share/classes/sun/rmi/registry/resources/rmiregistry_pt_BR.properties ! src/share/classes/sun/rmi/rmic/BatchEnvironment.java ! src/share/classes/sun/rmi/rmic/resources/rmic.properties ! src/share/classes/sun/rmi/rmic/resources/rmic_ja.properties ! src/share/classes/sun/rmi/rmic/resources/rmic_zh_CN.properties ! src/share/classes/sun/rmi/server/resources/rmid_pt_BR.properties ! src/share/classes/sun/security/jca/Providers.java ! src/share/classes/sun/security/jgss/krb5/InitialToken.java ! src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java ! src/share/classes/sun/security/pkcs11/wrapper/PKCS11Exception.java ! src/share/classes/sun/security/provider/JavaKeyStore.java ! src/share/classes/sun/security/ssl/Krb5Helper.java ! src/share/classes/sun/security/ssl/Krb5Proxy.java ! src/share/classes/sun/security/ssl/krb5/Krb5ProxyImpl.java ! src/share/classes/sun/security/tools/JarSignerResources_ja.java ! src/share/classes/sun/security/tools/JarSignerResources_zh_CN.java ! src/share/classes/sun/security/util/AuthResources_de.java ! src/share/classes/sun/security/util/AuthResources_es.java ! src/share/classes/sun/security/util/AuthResources_fr.java ! src/share/classes/sun/security/util/AuthResources_it.java ! src/share/classes/sun/security/util/AuthResources_ja.java ! src/share/classes/sun/security/util/AuthResources_ko.java ! src/share/classes/sun/security/util/AuthResources_pt_BR.java ! src/share/classes/sun/security/util/AuthResources_sv.java ! src/share/classes/sun/security/util/AuthResources_zh_CN.java ! src/share/classes/sun/security/util/AuthResources_zh_TW.java ! src/share/classes/sun/security/util/Resources_fr.java ! src/share/classes/sun/security/util/Resources_it.java ! src/share/classes/sun/security/util/Resources_pt_BR.java ! src/share/classes/sun/security/x509/X509Key.java ! src/share/classes/sun/swing/SwingUtilities2.java ! src/share/classes/sun/swing/plaf/synth/SynthFileChooserUIImpl.java ! src/share/classes/sun/swing/table/DefaultTableCellHeaderRenderer.java ! src/share/classes/sun/text/resources/FormatData_be.java ! src/share/classes/sun/text/resources/FormatData_fr.java ! src/share/classes/sun/text/resources/FormatData_fr_BE.java ! src/share/classes/sun/text/resources/FormatData_fr_CA.java ! src/share/classes/sun/text/resources/FormatData_fr_CH.java ! src/share/classes/sun/tools/jar/Main.java ! src/share/classes/sun/tools/jar/resources/jar_pt_BR.properties ! src/share/classes/sun/tools/jconsole/resources/JConsoleResources.java ! src/share/classes/sun/tools/jconsole/resources/JConsoleResources_ja.java ! src/share/classes/sun/tools/jconsole/resources/JConsoleResources_zh_CN.java ! src/share/classes/sun/tools/jstat/Arguments.java ! src/share/classes/sun/tools/jstat/ExpressionResolver.java ! src/share/classes/sun/tools/jstat/JStatLogger.java ! src/share/classes/sun/tools/jstat/Jstat.java ! src/share/classes/sun/tools/jstat/OptionFinder.java ! src/share/classes/sun/tools/jstat/OptionLister.java ! src/share/classes/sun/tools/jstat/resources/jstat_options ! src/share/classes/sun/tools/native2ascii/resources/MsgNative2ascii.java ! src/share/classes/sun/util/BuddhistCalendar.java ! src/share/classes/sun/util/calendar/ZoneInfoFile.java ! src/share/classes/sun/util/logging/PlatformLogger.java ! src/share/classes/sun/util/logging/resources/logging_pt_BR.properties ! src/share/classes/sun/util/resources/CalendarData_hu.properties ! src/share/classes/sun/util/resources/CurrencyNames_uk_UA.properties ! src/share/classes/sun/util/resources/LocaleNames.properties ! src/share/classes/sun/util/resources/LocaleNames_nl.properties ! src/share/classes/sun/util/resources/LocaleNames_zh.properties ! src/share/classes/sun/util/resources/LocaleNames_zh_TW.properties ! src/share/demo/java2d/J2DBench/src/j2dbench/J2DBench.java ! src/share/demo/java2d/J2DBench/src/j2dbench/Option.java ! src/share/demo/java2d/J2DBench/src/j2dbench/Result.java ! src/share/demo/java2d/J2DBench/src/j2dbench/report/J2DAnalyzer.java ! src/share/demo/java2d/J2DBench/src/j2dbench/tests/GraphicsTests.java ! src/share/demo/java2d/J2DBench/src/j2dbench/tests/text/TextTests.java ! src/share/demo/jvmti/hprof/sample.makefile.txt ! src/share/javavm/export/classfile_constants.h ! src/share/native/com/sun/java/util/jar/pack/bytes.cpp ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! src/share/native/common/check_code.c ! src/share/native/common/jdk_util.c ! src/share/native/common/jni_util.c ! src/share/native/java/io/RandomAccessFile.c ! src/share/native/java/io/io_util.c ! src/share/native/java/io/io_util.h ! src/share/native/java/lang/Class.c ! src/share/native/java/lang/ClassLoader.c ! src/share/native/java/lang/System.c ! src/share/native/java/lang/fdlibm/include/fdlibm.h ! src/share/native/java/lang/java_props.h ! src/share/native/java/lang/reflect/Proxy.c ! src/share/native/java/net/net_util.c ! src/share/native/java/nio/Bits.c ! src/share/native/java/util/zip/Deflater.c ! src/share/native/java/util/zip/Inflater.c ! src/share/native/java/util/zip/ZipFile.c ! src/share/native/java/util/zip/zip_util.c ! src/share/native/java/util/zip/zip_util.h ! src/share/native/sun/awt/image/BufImgSurfaceData.c ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c ! src/share/native/sun/awt/medialib/awt_ImagingLib.c ! src/share/native/sun/awt/medialib/mlib_ImageLookUp_64.c ! src/share/native/sun/awt/medialib/safe_alloc.h ! src/share/native/sun/awt/splashscreen/splashscreen_gif.c ! src/share/native/sun/awt/splashscreen/splashscreen_png.c ! src/share/native/sun/font/AccelGlyphCache.c ! src/share/native/sun/font/fontscalerdefs.h ! src/share/native/sun/font/freetypeScaler.c ! src/share/native/sun/font/sunFont.c ! src/share/native/sun/java2d/cmm/lcms/LCMS.c ! src/share/native/sun/java2d/loops/Any3Byte.c ! src/share/native/sun/java2d/loops/Any4Byte.c ! src/share/native/sun/java2d/loops/AnyByte.c ! src/share/native/sun/java2d/loops/AnyInt.c ! src/share/native/sun/java2d/loops/AnyShort.c ! src/share/native/sun/java2d/loops/DrawParallelogram.c ! src/share/native/sun/java2d/loops/FillParallelogram.c ! src/share/native/sun/java2d/loops/GraphicsPrimitiveMgr.c ! src/share/native/sun/java2d/loops/GraphicsPrimitiveMgr.h ! src/share/native/sun/java2d/loops/LoopMacros.h ! src/share/native/sun/java2d/loops/ProcessPath.c ! src/share/native/sun/java2d/opengl/OGLTextRenderer.c ! src/share/native/sun/management/Flag.c ! src/share/native/sun/misc/VM.c ! src/share/native/sun/misc/VMSupport.c ! src/share/native/sun/security/ec/ECC_JNI.cpp ! src/share/sample/nio/file/Chmod.java ! src/share/sample/nio/file/Copy.java ! src/share/sample/nio/file/WatchDir.java ! src/solaris/bin/jexec.c ! src/solaris/classes/java/io/UnixFileSystem.java ! src/solaris/classes/java/lang/ProcessImpl.java ! src/solaris/classes/java/lang/UNIXProcess.java.linux ! src/solaris/classes/java/lang/UNIXProcess.java.solaris ! src/solaris/classes/sun/awt/UNIXToolkit.java ! src/solaris/classes/sun/awt/X11/InfoWindow.java ! src/solaris/classes/sun/awt/X11/XBaseWindow.java ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java ! src/solaris/classes/sun/awt/X11/XEmbeddedFrame.java ! src/solaris/classes/sun/awt/X11/XEmbeddedFramePeer.java ! src/solaris/classes/sun/awt/X11/XFileDialogPeer.java ! src/solaris/classes/sun/awt/X11/XFramePeer.java ! src/solaris/classes/sun/awt/X11/XRobotPeer.java ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java ! src/solaris/classes/sun/awt/X11/XTrayIconPeer.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/solaris/classes/sun/awt/X11GraphicsDevice.java ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java ! src/solaris/classes/sun/awt/X11InputMethod.java ! src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Fedora.properties ! src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Ubuntu.properties ! src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.properties ! src/solaris/classes/sun/awt/motif/MToolkit.java ! src/solaris/classes/sun/java2d/UnixSurfaceManagerFactory.java ! src/solaris/classes/sun/java2d/x11/X11SurfaceData.java ! src/solaris/classes/sun/net/NetHooks.java ! src/solaris/classes/sun/net/sdp/SdpProvider.java ! src/solaris/classes/sun/nio/ch/DevPollSelectorImpl.java ! src/solaris/classes/sun/nio/ch/EPollSelectorImpl.java ! src/solaris/classes/sun/nio/ch/FileDispatcherImpl.java ! src/solaris/classes/sun/nio/ch/InheritedChannel.java ! src/solaris/classes/sun/nio/ch/LinuxAsynchronousChannelProvider.java ! src/solaris/classes/sun/nio/ch/PipeImpl.java ! src/solaris/classes/sun/nio/ch/PollSelectorImpl.java ! src/solaris/classes/sun/nio/ch/SctpChannelImpl.java ! src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java ! src/solaris/classes/sun/nio/ch/SctpNet.java ! src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java ! src/solaris/classes/sun/nio/ch/SolarisAsynchronousChannelProvider.java ! src/solaris/classes/sun/nio/cs/ext/COMPOUND_TEXT_Encoder.java ! src/solaris/classes/sun/nio/cs/ext/CompoundTextSupport.java ! src/solaris/classes/sun/nio/fs/LinuxFileStore.java ! src/solaris/classes/sun/nio/fs/SolarisFileStore.java ! src/solaris/classes/sun/nio/fs/UnixDirectoryStream.java ! src/solaris/classes/sun/nio/fs/UnixFileStore.java ! src/solaris/classes/sun/nio/fs/UnixPath.java ! src/solaris/classes/sun/nio/fs/UnixSecureDirectoryStream.java ! src/solaris/classes/sun/tools/attach/LinuxVirtualMachine.java ! src/solaris/classes/sun/tools/attach/SolarisVirtualMachine.java ! src/solaris/demo/jni/Poller/Poller.c ! src/solaris/native/java/io/FileOutputStream_md.c ! src/solaris/native/java/io/UnixFileSystem_md.c ! src/solaris/native/java/io/canonicalize_md.c ! src/solaris/native/java/io/io_util_md.c ! src/solaris/native/java/io/io_util_md.h ! src/solaris/native/java/lang/java_props_md.c ! src/solaris/native/java/lang/locale_str.h ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c ! src/solaris/native/java/net/NetworkInterface.c ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/solaris/native/java/net/PlainSocketImpl.c ! src/solaris/native/java/net/net_util_md.c ! src/solaris/native/java/net/net_util_md.h ! src/solaris/native/java/nio/MappedByteBuffer.c ! src/solaris/native/sun/awt/awt.h ! src/solaris/native/sun/awt/awt_DrawingSurface.c ! src/solaris/native/sun/awt/awt_InputMethod.c ! src/solaris/native/sun/awt/awt_Robot.c ! src/solaris/native/sun/awt/awt_UNIXToolkit.c ! src/solaris/native/sun/awt/medialib/mlib_v_ImageLookUpS32S16Func.c ! src/solaris/native/sun/awt/medialib/mlib_v_ImageLookUpS32U16Func.c ! src/solaris/native/sun/awt/medialib/mlib_v_ImageLookUpSIS32S16Func.c ! src/solaris/native/sun/awt/medialib/mlib_v_ImageLookUpSIS32U16Func.c ! src/solaris/native/sun/awt/swing_GTKStyle.c ! src/solaris/native/sun/java2d/loops/java2d_Mlib.c ! src/solaris/native/sun/java2d/loops/vis_FuncArray.c ! src/solaris/native/sun/java2d/opengl/GLXSurfaceData.c ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c ! src/solaris/native/sun/java2d/x11/X11SurfaceData.h ! src/solaris/native/sun/net/sdp/SdpSupport.c ! src/solaris/native/sun/net/spi/DefaultProxySelector.c ! src/solaris/native/sun/nio/ch/IOUtil.c ! src/solaris/native/sun/nio/ch/Net.c ! src/solaris/native/sun/nio/ch/SctpNet.c ! src/solaris/native/sun/nio/ch/SocketChannelImpl.c ! src/solaris/native/sun/nio/ch/UnixAsynchronousSocketChannelImpl.c ! src/solaris/native/sun/xawt/XlibWrapper.c ! src/solaris/native/sun/xawt/awt_Desktop.c ! src/windows/classes/java/io/Win32FileSystem.java ! src/windows/classes/java/lang/ProcessImpl.java ! src/windows/classes/sun/awt/Win32GraphicsDevice.java ! src/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WEmbeddedFrame.java ! src/windows/classes/sun/awt/windows/WFileDialogPeer.java ! src/windows/classes/sun/awt/windows/WFramePeer.java ! src/windows/classes/sun/awt/windows/WInputMethod.java ! src/windows/classes/sun/awt/windows/WPrintDialogPeer.java ! src/windows/classes/sun/awt/windows/WToolkit.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java ! src/windows/classes/sun/awt/windows/fontconfig.properties ! src/windows/classes/sun/java2d/d3d/D3DScreenUpdateManager.java ! src/windows/classes/sun/nio/ch/FileDispatcherImpl.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousChannelProvider.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java ! src/windows/classes/sun/nio/ch/WindowsSelectorImpl.java ! src/windows/classes/sun/nio/fs/WindowsChannelFactory.java ! src/windows/classes/sun/nio/fs/WindowsDirectoryStream.java ! src/windows/native/com/sun/media/sound/PLATFORM_API_WinOS_DirectSound.cpp ! src/windows/native/common/jni_util_md.c ! src/windows/native/java/io/FileOutputStream_md.c ! src/windows/native/java/io/WinNTFileSystem_md.c ! src/windows/native/java/io/io_util_md.c ! src/windows/native/java/io/io_util_md.h ! src/windows/native/java/lang/ProcessImpl_md.c ! src/windows/native/java/lang/java_props_md.c ! src/windows/native/java/net/NetworkInterface_winXP.c ! src/windows/native/java/net/TwoStacksPlainDatagramSocketImpl.c ! src/windows/native/java/net/net_util_md.h ! src/windows/native/java/nio/MappedByteBuffer.c ! src/windows/native/java/util/TimeZone_md.c ! src/windows/native/sun/font/fontpath.c ! src/windows/native/sun/java2d/d3d/D3DGraphicsDevice.cpp ! src/windows/native/sun/java2d/d3d/D3DPipelineManager.cpp ! src/windows/native/sun/java2d/d3d/D3DPipelineManager.h ! src/windows/native/sun/java2d/opengl/WGLSurfaceData.c ! src/windows/native/sun/java2d/windows/GDIWindowSurfaceData.cpp ! src/windows/native/sun/java2d/windows/GDIWindowSurfaceData.h ! src/windows/native/sun/java2d/windows/WindowsFlags.cpp ! src/windows/native/sun/jkernel/DownloadDialog.cpp ! src/windows/native/sun/jkernel/DownloadHelper.cpp ! src/windows/native/sun/jkernel/kernel.rc ! src/windows/native/sun/jkernel/kernel_pt_BR.rc ! src/windows/native/sun/jkernel/stdafx.h ! src/windows/native/sun/net/spi/DefaultProxySelector.c ! src/windows/native/sun/nio/ch/DatagramChannelImpl.c ! src/windows/native/sun/nio/ch/FileDispatcherImpl.c ! src/windows/native/sun/nio/ch/Net.c ! src/windows/native/sun/nio/ch/ServerSocketChannelImpl.c ! src/windows/native/sun/nio/ch/SocketChannelImpl.c ! src/windows/native/sun/nio/ch/SocketDispatcher.c ! src/windows/native/sun/nio/ch/WindowsAsynchronousFileChannelImpl.c ! src/windows/native/sun/nio/ch/WindowsSelectorImpl.c ! src/windows/native/sun/nio/ch/nio_util.h ! src/windows/native/sun/windows/WPrinterJob.cpp ! src/windows/native/sun/windows/awt.h ! src/windows/native/sun/windows/awt_BitmapUtil.cpp ! src/windows/native/sun/windows/awt_Choice.cpp ! src/windows/native/sun/windows/awt_Choice.h ! src/windows/native/sun/windows/awt_DataTransferer.cpp ! src/windows/native/sun/windows/awt_Desktop.cpp ! src/windows/native/sun/windows/awt_DesktopProperties.cpp ! src/windows/native/sun/windows/awt_Dialog.cpp ! src/windows/native/sun/windows/awt_DnDDS.cpp ! src/windows/native/sun/windows/awt_DrawingSurface.h ! src/windows/native/sun/windows/awt_FileDialog.cpp ! src/windows/native/sun/windows/awt_FileDialog.h ! src/windows/native/sun/windows/awt_Font.cpp ! src/windows/native/sun/windows/awt_InputMethod.cpp ! src/windows/native/sun/windows/awt_MenuItem.cpp ! src/windows/native/sun/windows/awt_PrintJob.cpp ! src/windows/native/sun/windows/awt_Robot.cpp ! src/windows/native/sun/windows/awt_TextArea.cpp ! src/windows/native/sun/windows/awt_TextComponent.h ! src/windows/native/sun/windows/awt_TextField.cpp ! src/windows/native/sun/windows/awt_TextField.h ! src/windows/native/sun/windows/awt_Toolkit.cpp ! src/windows/native/sun/windows/awt_Toolkit.h ! src/windows/native/sun/windows/awt_Win32GraphicsEnv.cpp ! src/windows/native/sun/windows/awt_Window.cpp ! src/windows/native/sun/windows/awtmsg.h ! test/com/sun/crypto/provider/KeyFactory/TestProviderLeak.java ! test/com/sun/crypto/provider/TLS/TestPremaster.java ! test/com/sun/crypto/provider/TLS/Utils.java ! test/com/sun/java/swing/plaf/gtk/Test6635110.java ! test/com/sun/jdi/PopAndInvokeTest.java ! test/com/sun/jdi/connect/spi/JdiLoadedByCustomLoader.sh ! test/com/sun/net/httpserver/Test.java ! test/com/sun/net/httpserver/Test1.java ! test/com/sun/net/httpserver/Test11.java ! test/com/sun/net/httpserver/Test12.java ! test/com/sun/net/httpserver/Test13.java ! test/com/sun/net/httpserver/Test6a.java ! test/com/sun/net/httpserver/Test7a.java ! test/com/sun/net/httpserver/Test8a.java ! test/com/sun/net/httpserver/Test9.java ! test/com/sun/net/httpserver/Test9a.java ! test/com/sun/net/httpserver/bugs/6725892/Test.java ! test/com/sun/net/httpserver/bugs/B6361557.java ! test/com/sun/net/httpserver/bugs/B6373555.java ! test/com/sun/net/httpserver/bugs/B6401598.java ! test/com/sun/nio/sctp/SctpChannel/Connect.java ! test/com/sun/nio/sctp/SctpChannel/Send.java ! test/com/sun/nio/sctp/SctpChannel/SocketOptionTests.java ! test/com/sun/nio/sctp/SctpMultiChannel/Send.java ! test/com/sun/servicetag/FindServiceTags.java ! test/com/sun/servicetag/JavaServiceTagTest1.java ! test/com/sun/servicetag/SystemRegistryTest.java ! test/com/sun/servicetag/Util.java ! test/com/sun/tools/attach/ProviderTests.sh ! test/com/sun/tracing/BasicFunctionality.java ! test/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.java ! test/java/awt/EventQueue/PushPopDeadlock2/PushPopTest.java ! test/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java ! test/java/awt/TextArea/UsingWithMouse/SelectionAutoscrollTest.java ! test/java/awt/TextField/ScrollSelectionTest/ScrollSelectionTest.java ! test/java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_3.java ! test/java/awt/regtesthelpers/process/ProcessCommunicator.java ! test/java/beans/Beans/Test4080522.java ! test/java/beans/EventHandler/Test6277246.java ! test/java/beans/EventHandler/Test6277266.java ! test/java/beans/Introspector/Test6277246.java ! test/java/beans/XMLEncoder/java_awt_GridBagConstraints.java ! test/java/io/BufferedReader/BigMark.java ! test/java/io/BufferedReader/ReadLineSync.java ! test/java/io/DataInputStream/OpsAfterClose.java ! test/java/io/DataInputStream/ReadFully.java ! test/java/io/File/Basic.java ! test/java/io/File/DeleteOnExit.java ! test/java/io/File/DeleteOnExitNPE.java ! test/java/io/File/IsHidden.java ! test/java/io/File/SetAccess.java ! test/java/io/File/SetReadOnly.java ! test/java/io/FileInputStream/LeadingSlash.java ! test/java/io/InputStream/OpsAfterClose.java ! test/java/io/InputStream/ReadParams.java ! test/java/io/InputStreamReader/GrowAfterEOF.java ! test/java/io/ObjectInputStream/ResolveProxyClass.java ! test/java/io/RandomAccessFile/EOF.java ! test/java/io/RandomAccessFile/ParameterCheck.java ! test/java/io/RandomAccessFile/ReadLine.java ! test/java/io/RandomAccessFile/Seek.java ! test/java/io/RandomAccessFile/WriteBytesChars.java ! test/java/io/RandomAccessFile/WriteUTF.java ! test/java/io/RandomAccessFile/skipBytes/SkipBytes.java ! test/java/io/Reader/Skip.java ! test/java/io/Reader/SkipNegative.java ! test/java/io/Serializable/ClassCastExceptionDetail/Read.java ! test/java/io/Serializable/auditStreamSubclass/AuditStreamSubclass.java ! test/java/io/Serializable/backRefCNFException/Read.java ! test/java/io/Serializable/checkModifiers/CheckModifiers.java ! test/java/io/Serializable/classDescFlagConflict/Read.java ! test/java/io/Serializable/classDescHooks/ClassDescHooks.java ! test/java/io/Serializable/duplicateSerialFields/Test.java ! test/java/io/Serializable/enum/badResolve/Read.java ! test/java/io/Serializable/enum/constantSubclasses/Read.java ! test/java/io/Serializable/enum/missingConstant/Read.java ! test/java/io/Serializable/evolution/RenamePackage/run.sh ! test/java/io/Serializable/fieldTypeString/Read.java ! test/java/io/Serializable/illegalHandle/Test.java ! test/java/io/Serializable/longString/LongString.java ! test/java/io/Serializable/oldTests/AnnotateClass.java ! test/java/io/Serializable/oldTests/ArrayFields.java ! test/java/io/Serializable/oldTests/ArraysOfArrays.java ! test/java/io/Serializable/oldTests/BinaryTree.java ! test/java/io/Serializable/oldTests/CircularList.java ! test/java/io/Serializable/oldTests/SimpleArrays.java ! test/java/io/Serializable/oldTests/WritePrimitive.java ! test/java/io/Serializable/packageAccess/Test.java ! test/java/io/Serializable/parents/EvolvedClass.java ! test/java/io/Serializable/parents/OriginalClass.java ! test/java/io/Serializable/proxy/Basic.java ! test/java/io/Serializable/proxy/skipMissing/Read.java ! test/java/io/Serializable/proxy/skipMissing/Write.java ! test/java/io/Serializable/readObjectNoData/Read.java ! test/java/io/Serializable/serialver/classpath/run.sh ! test/java/io/Serializable/serialver/nested/run.sh ! test/java/io/Serializable/skipWriteObject/Read.java ! test/java/io/Serializable/skippedObjCNFException/Read.java ! test/java/io/Serializable/stopCustomDeserialization/Read.java ! test/java/io/Serializable/unresolvedClassDesc/Read.java ! test/java/io/Serializable/unshared/Read.java ! test/java/io/Serializable/wrongReturnTypes/Read.java ! test/java/io/StreamTokenizer/Comment.java ! test/java/io/pathNames/GeneralWin32.java ! test/java/io/readBytes/ReadBytesBounds.java ! test/java/lang/ClassLoader/UninitializedParent.java ! test/java/lang/ClassLoader/deadlock/TestCrossDelegate.sh ! test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh ! test/java/lang/ClassLoader/defineClass/DefineClassByteBuffer.java ! test/java/lang/ClassLoader/findSystemClass/Loader.java ! test/java/lang/ProcessBuilder/Basic.java ! test/java/lang/Runtime/exec/ExecWithDir.java ! test/java/lang/String/Supplementary.java ! test/java/lang/StringBuffer/Supplementary.java ! test/java/lang/StringBuilder/Supplementary.java ! test/java/lang/StringCoding/CheckEncodings.sh ! test/java/lang/System/ExitFinalizersAndJIT.java ! test/java/lang/System/IgnoreNullSecurityManager.java ! test/java/lang/Thread/GenerifyStackTraces.java ! test/java/lang/Thread/StackTraces.java ! test/java/lang/annotation/ParameterAnnotations.java ! test/java/lang/management/ClassLoadingMXBean/LoadCounts.java ! test/java/lang/management/ManagementFactory/MXBeanProxyTest.java ! test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java ! test/java/lang/management/MemoryMXBean/CollectionUsageThresholdConcMarkSweepGC.sh ! test/java/lang/management/MemoryMXBean/LowMemoryTest.java ! test/java/lang/management/MemoryMXBean/MemoryManagement.java ! test/java/lang/management/MemoryMXBean/Pending.java ! test/java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java ! test/java/lang/management/MemoryPoolMXBean/ThresholdTest.java ! test/java/lang/management/RuntimeMXBean/UpTime.java ! test/java/lang/management/ThreadMXBean/AllThreadIds.java ! test/java/lang/management/ThreadMXBean/DisableTest.java ! test/java/lang/management/ThreadMXBean/EnableTest.java ! test/java/lang/management/ThreadMXBean/FindDeadlocks.java ! test/java/lang/management/ThreadMXBean/FindMonitorDeadlock.java ! test/java/lang/management/ThreadMXBean/Locks.java ! test/java/lang/reflect/Proxy/Boxing.java ! test/java/lang/reflect/Proxy/ClassRestrictions.java ! test/java/lang/reflect/Proxy/returnTypes/Test.java ! test/java/net/Authenticator/B4769350.java ! test/java/net/BindException/Test.java ! test/java/net/CookieHandler/CookieHandlerTest.java ! test/java/net/CookieHandler/TestHttpCookie.java ! test/java/net/DatagramSocket/DatagramTimeout.java ! test/java/net/DatagramSocket/SendSize.java ! test/java/net/Inet6Address/B6214234.java ! test/java/net/Inet6Address/B6558853.java ! test/java/net/Inet6Address/serialize/Serialize.java ! test/java/net/InetAddress/CheckJNI.java ! test/java/net/MulticastSocket/NoLoopbackPackets.java ! test/java/net/MulticastSocket/SetOutgoingIf.java ! test/java/net/ProxySelector/B6737819.java ! test/java/net/ResponseCache/B6181108.java ! test/java/net/ResponseCache/ResponseCacheTest.java ! test/java/net/ResponseCache/getResponseCode.java ! test/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java ! test/java/net/Socket/CloseAvailable.java ! test/java/net/Socket/DeadlockTest.java ! test/java/net/Socket/LingerTest.java ! test/java/net/Socket/LinkLocal.java ! test/java/net/Socket/ProxyCons.java ! test/java/net/Socket/ReadTimeout.java ! test/java/net/Socket/SetReceiveBufferSize.java ! test/java/net/Socket/SetSoLinger.java ! test/java/net/Socket/ShutdownBoth.java ! test/java/net/Socket/SoTimeout.java ! test/java/net/Socket/Timeout.java ! test/java/net/Socket/UrgentDataTest.java ! test/java/net/Socket/asyncClose/BrokenPipe.java ! test/java/net/Socket/setReuseAddress/Restart.java ! test/java/net/SocketInputStream/SocketClosedException.java ! test/java/net/SocketInputStream/SocketTimeout.java ! test/java/net/URI/Test.java ! test/java/net/URL/GetContent.java ! test/java/net/URL/TestIPv6Addresses.java ! test/java/net/URLClassLoader/ClassLoad.java ! test/java/net/URLClassLoader/HttpTest.java ! test/java/net/URLClassLoader/closetest/CloseTest.java ! test/java/net/URLConnection/B5052093.java ! test/java/net/URLConnection/DisconnectAfterEOF.java ! test/java/net/URLConnection/HandleContentTypeWithAttrs.java ! test/java/net/URLConnection/HttpContinueStackOverflow.java ! test/java/net/URLConnection/Redirect307Test.java ! test/java/net/URLConnection/RedirectLimit.java ! test/java/net/URLConnection/ResendPostBody.java ! test/java/net/URLConnection/SetIfModifiedSince.java ! test/java/net/URLConnection/TimeoutTest.java ! test/java/net/URLConnection/URLConnectionHeaders.java ! test/java/net/URLConnection/ZeroContentLength.java ! test/java/net/URLConnection/contentHandler/UserContentHandler.java ! test/java/net/ipv6tests/B6521014.java ! test/java/net/ipv6tests/TcpTest.java ! test/java/net/ipv6tests/Tests.java ! test/java/nio/Buffer/StringCharBufferSliceTest.java ! test/java/nio/BufferPoolMXBean/Basic.java ! test/java/nio/MappedByteBuffer/Basic.java ! test/java/nio/MappedByteBuffer/Force.java ! test/java/nio/MappedByteBuffer/ZeroMap.java ! test/java/nio/channels/AsyncCloseAndInterrupt.java ! test/java/nio/channels/AsynchronousChannelGroup/Basic.java ! test/java/nio/channels/AsynchronousChannelGroup/GroupOfOne.java ! test/java/nio/channels/AsynchronousChannelGroup/Identity.java ! test/java/nio/channels/AsynchronousFileChannel/Basic.java ! test/java/nio/channels/AsynchronousFileChannel/Lock.java ! test/java/nio/channels/AsynchronousServerSocketChannel/Basic.java ! test/java/nio/channels/AsynchronousSocketChannel/Basic.java ! test/java/nio/channels/AsynchronousSocketChannel/Leaky.java ! test/java/nio/channels/Channels/Basic2.java ! test/java/nio/channels/Channels/Write.java ! test/java/nio/channels/DatagramChannel/AdaptDatagramSocket.java ! test/java/nio/channels/DatagramChannel/Connect.java ! test/java/nio/channels/DatagramChannel/EmptyBuffer.java ! test/java/nio/channels/DatagramChannel/NoSender.java ! test/java/nio/channels/DatagramChannel/ReceiveISA.java ! test/java/nio/channels/DatagramChannel/SRTest.java ! test/java/nio/channels/DatagramChannel/Sender.java ! test/java/nio/channels/DatagramChannel/SocketOptionTests.java ! test/java/nio/channels/FileChannel/Args.java ! test/java/nio/channels/FileChannel/ClosedChannelTransfer.java ! test/java/nio/channels/FileChannel/ExpandingMap.java ! test/java/nio/channels/FileChannel/Lock.java ! test/java/nio/channels/FileChannel/MapOverEnd.java ! test/java/nio/channels/FileChannel/MapReadOnly.java ! test/java/nio/channels/FileChannel/MapTest.java ! test/java/nio/channels/FileChannel/Mode.java ! test/java/nio/channels/FileChannel/Position.java ! test/java/nio/channels/FileChannel/Pread.java ! test/java/nio/channels/FileChannel/Pwrite.java ! test/java/nio/channels/FileChannel/Read.java ! test/java/nio/channels/FileChannel/ReadFull.java ! test/java/nio/channels/FileChannel/ReadToLimit.java ! test/java/nio/channels/FileChannel/ReleaseOnCloseDeadlock.java ! test/java/nio/channels/FileChannel/ScatteringRead.java ! test/java/nio/channels/FileChannel/Size.java ! test/java/nio/channels/FileChannel/Transfer.java ! test/java/nio/channels/FileChannel/TransferToChannel.java ! test/java/nio/channels/FileChannel/TransferToNonWritable.java ! test/java/nio/channels/FileChannel/Transfers.java ! test/java/nio/channels/FileChannel/Truncate.java ! test/java/nio/channels/FileChannel/TryLock.java ! test/java/nio/channels/FileChannel/Write.java ! test/java/nio/channels/Pipe/NonBlocking.java ! test/java/nio/channels/Pipe/SelectPipe.java ! test/java/nio/channels/SelectionKey/AtomicAttachTest.java ! test/java/nio/channels/Selector/BasicAccept.java ! test/java/nio/channels/Selector/BasicConnect.java ! test/java/nio/channels/Selector/ByteServer.java ! test/java/nio/channels/Selector/CheckLocking.java ! test/java/nio/channels/Selector/CloseInvalidatesKeys.java ! test/java/nio/channels/Selector/CloseThenRegister.java ! test/java/nio/channels/Selector/CloseWhenKeyIdle.java ! test/java/nio/channels/Selector/Connect.java ! test/java/nio/channels/Selector/ConnectWrite.java ! test/java/nio/channels/Selector/HelperSlowToDie.java ! test/java/nio/channels/Selector/KeysReady.java ! test/java/nio/channels/Selector/LotsOfChannels.java ! test/java/nio/channels/Selector/OpRead.java ! test/java/nio/channels/Selector/ReadAfterConnect.java ! test/java/nio/channels/Selector/RegAfterPreClose.java ! test/java/nio/channels/Selector/SelectAfterRead.java ! test/java/nio/channels/Selector/SelectAndCancel.java ! test/java/nio/channels/Selector/SelectWrite.java ! test/java/nio/channels/Selector/SelectorLimit.java ! test/java/nio/channels/Selector/SelectorTest.java ! test/java/nio/channels/Selector/WakeupNow.java ! test/java/nio/channels/Selector/WakeupOverflow.java ! test/java/nio/channels/Selector/WakeupSpeed.java ! test/java/nio/channels/Selector/lots_of_updates.sh ! test/java/nio/channels/ServerSocketChannel/SocketOptionTests.java ! test/java/nio/channels/SocketChannel/AdaptSocket.java ! test/java/nio/channels/SocketChannel/BigReadWrite.java ! test/java/nio/channels/SocketChannel/Bind.java ! test/java/nio/channels/SocketChannel/Close.java ! test/java/nio/channels/SocketChannel/CloseRegisteredChannel.java ! test/java/nio/channels/SocketChannel/CloseTimeoutChannel.java ! test/java/nio/channels/SocketChannel/IsConnectable.java ! test/java/nio/channels/SocketChannel/LocalAddress.java ! test/java/nio/channels/SocketChannel/OpenLeak.java ! test/java/nio/channels/SocketChannel/SocketInheritance.java ! test/java/nio/channels/SocketChannel/SocketOptionTests.java ! test/java/nio/channels/SocketChannel/Trivial.java ! test/java/nio/channels/SocketChannel/UnboundSocketTests.java ! test/java/nio/channels/SocketChannel/VectorIO.java ! test/java/nio/channels/SocketChannel/Write.java ! test/java/nio/channels/etc/Shadow.java ! test/java/nio/channels/spi/AsynchronousChannelProvider/Provider1.java ! test/java/nio/channels/spi/AsynchronousChannelProvider/Provider2.java ! test/java/nio/channels/spi/AsynchronousChannelProvider/custom_provider.sh ! test/java/nio/channels/spi/SelectorProvider/inheritedChannel/ClosedStreams.java ! test/java/nio/channels/spi/SelectorProvider/inheritedChannel/EchoTest.java ! test/java/nio/file/DirectoryStream/Basic.java ! test/java/nio/file/DirectoryStream/SecureDS.java ! test/java/nio/file/FileStore/Basic.java ! test/java/nio/file/Files/Misc.java ! test/java/nio/file/Files/PrintFileTree.java ! test/java/nio/file/Files/SkipSiblings.java ! test/java/nio/file/Files/TerminateWalk.java ! test/java/nio/file/Files/WalkWithSecurity.java ! test/java/nio/file/Files/walk_file_tree.sh ! test/java/nio/file/Path/CheckPermissions.java ! test/java/nio/file/Path/CopyAndMove.java ! test/java/nio/file/Path/InterruptCopy.java ! test/java/nio/file/Path/Misc.java ! test/java/nio/file/Path/PathOps.java ! test/java/nio/file/Path/delete_on_close.sh ! test/java/nio/file/TestUtil.java ! test/java/security/Provider/Turkish.java ! test/java/security/Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh ! test/java/util/Collection/BiggernYours.java ! test/java/util/Collection/IteratorAtEnd.java ! test/java/util/Collection/MOAT.java ! test/java/util/Collections/RacingCollections.java ! test/java/util/Deque/ChorusLine.java ! test/java/util/Formatter/Constructors.java ! test/java/util/Locale/PrintDefaultLocale.java ! test/java/util/Locale/data/deflocale.c ! test/java/util/Locale/data/deflocale.sh ! test/java/util/PluggableLocale/ExecTest.sh ! test/java/util/ResourceBundle/Bug4168625Test.java ! test/java/util/ResourceBundle/Bug6299235Test.sh ! test/java/util/ResourceBundle/Bug6359330.java ! test/java/util/ResourceBundle/Control/ExpirationTest.sh ! test/java/util/ResourceBundle/Test4300693.java ! test/java/util/ResourceBundle/TestBug4179766.java ! test/java/util/ServiceLoader/basic.sh ! test/java/util/concurrent/BlockingQueue/Interrupt.java ! test/java/util/concurrent/ConcurrentQueues/OfferRemoveLoops.java ! test/java/util/concurrent/CopyOnWriteArrayList/EqualsRace.java ! test/java/util/concurrent/CopyOnWriteArraySet/RacingCows.java ! test/java/util/concurrent/CyclicBarrier/Basic.java ! test/java/util/concurrent/Executors/AutoShutdown.java ! test/java/util/concurrent/Executors/Throws.java ! test/java/util/concurrent/FutureTask/BlockingTaskExecutor.java ! test/java/util/concurrent/FutureTask/Customized.java ! test/java/util/concurrent/ThreadPoolExecutor/ConfigChanges.java ! test/java/util/concurrent/ThreadPoolExecutor/Custom.java ! test/java/util/concurrent/ThreadPoolExecutor/ScheduledTickleService.java ! test/java/util/concurrent/ThreadPoolExecutor/ShutdownNowExecuteRace.java ! test/java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java ! test/java/util/concurrent/atomic/VMSupportsCS8.java ! test/java/util/concurrent/locks/Lock/FlakyMutex.java ! test/java/util/concurrent/locks/Lock/TimedAcquireLeak.java ! test/java/util/concurrent/locks/ReentrantReadWriteLock/Bug6571733.java ! test/java/util/regex/RegExTest.java ! test/java/util/zip/ZipFile/ReadZip.java ! test/javax/imageio/CachePremissionsTest/CachePermissionsTest.java ! test/javax/print/attribute/ServiceDialogTest.java ! test/javax/print/attribute/SidesPageRangesTest.java ! test/javax/script/ProviderTest.sh ! test/javax/sound/midi/Gervill/AudioFloatConverter/ToFloatArray.java ! test/javax/sound/midi/Gervill/SoftAudioSynthesizer/DummySourceDataLine.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/DummySourceDataLine.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/LoadAllInstruments.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/LoadInstrument.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/LoadInstruments.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/RemapInstrument.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/UnloadAllInstruments.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/UnloadInstrument.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/UnloadInstruments.java ! test/javax/swing/AbstractButton/6711682/bug6711682.java ! test/javax/swing/JLayer/SerializationTest/SerializationTest.java ! test/javax/swing/JTextArea/Test6593649.java ! test/javax/swing/plaf/nimbus/Test6919629.java ! test/javax/swing/system/6799345/TestShutdown.java ! test/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java ! test/sun/java2d/GdiRendering/InsetClipping.java ! test/sun/java2d/SunGraphics2D/DrawImageBilinear.java ! test/sun/java2d/SunGraphics2D/SourceClippingBlitTest/SourceClippingBlitTest.java ! test/sun/java2d/X11SurfaceData/SharedMemoryPixmapsTest/SharedMemoryPixmapsTest.java ! test/sun/java2d/pipe/MutableColorTest/MutableColorTest.java ! test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh ! test/sun/jvmstat/testlibrary/utils.sh ! test/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh ! test/sun/misc/BootClassLoaderHook/TestHook.java ! test/sun/net/ftp/FtpGetContent.java ! test/sun/net/ftp/FtpURL.java ! test/sun/net/sdp/ProbeIB.java ! test/sun/net/sdp/sanity.sh ! test/sun/net/www/http/ChunkedInputStream/ChunkedEncodingTest.java ! test/sun/net/www/http/ChunkedInputStream/ChunkedEncodingWithProgressMonitorTest.java ! test/sun/net/www/http/ChunkedOutputStream/Test.java ! test/sun/net/www/http/HttpClient/B6726695.java ! test/sun/net/www/http/HttpClient/MultiThreadTest.java ! test/sun/net/www/http/HttpClient/ProxyTest.java ! test/sun/net/www/http/KeepAliveCache/B5045306.java ! test/sun/net/www/http/KeepAliveCache/KeepAliveTimerThread.java ! test/sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java ! test/sun/net/www/httptest/HttpServer.java ! test/sun/net/www/protocol/http/ChunkedErrorStream.java ! test/sun/net/www/protocol/http/DigestTest.java ! test/sun/nio/ch/Basic.java ! test/sun/nio/ch/TempBuffer.java ! test/sun/nio/cs/CheckHistoricalNames.java ! test/sun/nio/cs/FindDecoderBugs.java ! test/sun/nio/cs/ReadZero.java ! test/sun/nio/cs/Test4200310.sh ! test/sun/nio/cs/Test4206507.java ! test/sun/nio/cs/TestStringCoding.java ! test/sun/nio/cs/TestX11CNS.java ! test/sun/rmi/rmic/manifestClassPath/run.sh ! test/sun/security/krb5/auto/Context.java ! test/sun/security/pkcs11/KeyGenerator/TestKeyGenerator.java ! test/sun/security/pkcs11/tls/TestPremaster.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/ClientModeClientAuth.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/B6226610.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/HttpsPost.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/Redirect.java ! test/sun/text/resources/LocaleDataTest.java ! test/sun/tools/jps/jps-Vvml_2.sh ! test/sun/tools/jps/jps-help.sh ! test/sun/tools/jps/jps-m_2.sh ! test/sun/tools/jstat/jstatHelp.sh ! test/sun/tools/jstat/jstatOptions1.sh ! test/sun/tools/jstatd/jstatdDefaults.sh ! test/sun/tools/jstatd/jstatdExternalRegistry.sh ! test/sun/tools/jstatd/jstatdPort.sh ! test/sun/tools/jstatd/jstatdServerName.sh ! test/sun/tools/jstatd/jstatdUsage1.sh ! test/sun/util/logging/PlatformLoggerTest.java ! test/sun/util/resources/TimeZone/Bug6317929.java ! test/tools/jar/JarEntryTime.java ! test/tools/jar/index/MetaInf.java ! test/tools/launcher/ChangeDataModel.sh ! test/tools/launcher/DefaultLocaleTest.sh ! test/tools/launcher/UnicodeTest.sh Changeset: 1c72adc9d5f3 Author: ohair Date: 2010-12-28 16:12 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1c72adc9d5f3 6991482: Add global jdk makefile options to silence some VS2010 warnings Reviewed-by: prr ! make/common/Defs-windows.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Sanity-Settings.gmk Changeset: 58aa8eadae5f Author: lana Date: 2011-01-04 17:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/58aa8eadae5f Merge - make/common/internal/BinaryPlugs.gmk ! src/share/classes/com/sun/java/util/jar/pack/AdaptiveCoding.java ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/ClassWriter.java ! src/share/classes/com/sun/java/util/jar/pack/Code.java ! src/share/classes/com/sun/java/util/jar/pack/Coding.java ! src/share/classes/com/sun/java/util/jar/pack/CodingChooser.java ! src/share/classes/com/sun/java/util/jar/pack/Fixups.java ! src/share/classes/com/sun/java/util/jar/pack/Histogram.java ! src/share/classes/com/sun/java/util/jar/pack/Instruction.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/classes/com/sun/java/util/jar/pack/PopulationCoding.java ! src/share/classes/java/io/FileOutputStream.java ! src/share/classes/java/lang/ProcessBuilder.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/Thread.java ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/util/AbstractList.java ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/Formatter.java ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/LinkedList.java ! src/share/classes/java/util/ListResourceBundle.java ! src/share/classes/java/util/PriorityQueue.java ! src/share/classes/java/util/Properties.java ! src/share/classes/java/util/TreeMap.java ! src/share/classes/java/util/TreeSet.java ! src/share/classes/java/util/logging/LogRecord.java ! src/share/classes/java/util/regex/Pattern.java ! src/share/classes/java/util/zip/ZipFile.java ! src/share/classes/sun/io/Converters.java ! src/share/classes/sun/tools/jstat/resources/jstat_options ! src/share/classes/sun/util/logging/PlatformLogger.java ! test/sun/security/krb5/auto/Context.java From lana.steuck at oracle.com Tue Jan 4 17:48:49 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 05 Jan 2011 01:48:49 +0000 Subject: hg: jdk7/tl/langtools: 2 new changesets Message-ID: <20110105014854.9369B47989@hg.openjdk.java.net> Changeset: 4868a36f6fd8 Author: ohair Date: 2010-12-28 15:54 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4868a36f6fd8 6962318: Update copyright year Reviewed-by: xdono ! make/Makefile ! make/build.properties ! make/tools/CompileProperties/CompileProperties.java ! make/tools/CompileProperties/CompilePropertiesTask.java ! src/share/classes/com/sun/mirror/util/SourceOrderDeclScanner.java ! src/share/classes/com/sun/source/tree/MethodTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/tree/TryTree.java ! src/share/classes/com/sun/source/tree/TypeParameterTree.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/source/util/Trees.java ! src/share/classes/com/sun/tools/apt/comp/Apt.java ! src/share/classes/com/sun/tools/apt/main/CommandLine.java ! src/share/classes/com/sun/tools/apt/main/Main.java ! src/share/classes/com/sun/tools/apt/mirror/apt/FilerImpl.java ! src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationProxyMaker.java ! src/share/classes/com/sun/tools/apt/mirror/declaration/DeclarationImpl.java ! src/share/classes/com/sun/tools/apt/mirror/type/TypeMirrorImpl.java ! src/share/classes/com/sun/tools/apt/resources/apt_ja.properties ! src/share/classes/com/sun/tools/apt/resources/apt_zh_CN.properties ! src/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/share/classes/com/sun/tools/classfile/ExtendedAnnotation.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/DeprecatedListWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SingleIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SplitIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeOptionalMemberWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeRequiredMemberWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ClassWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ConstantsSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ConstructorWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/EnumConstantWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/FieldWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/MemberSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/MethodWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/NestedClassWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/PackageSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/SerializedFormWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeOptionalMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstantsSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstructorBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/EnumConstantBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/FieldBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/LayoutParser.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MethodBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclet.xml ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DirectoryManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/doclets/standard/Standard.java ! src/share/classes/com/sun/tools/javac/Launcher.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/file/Paths.java ! src/share/classes/com/sun/tools/javac/jvm/CRTable.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Items.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java ! src/share/classes/com/sun/tools/javac/main/CommandLine.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/main/OptionName.java ! src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java ! src/share/classes/com/sun/tools/javac/model/AnnotationProxyMaker.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java ! src/share/classes/com/sun/tools/javac/nio/PathFileObject.java ! src/share/classes/com/sun/tools/javac/parser/Keywords.java ! src/share/classes/com/sun/tools/javac/processing/JavacFiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacMessager.java ! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/resources/compiler_ja.properties ! src/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! src/share/classes/com/sun/tools/javac/resources/javac_ja.properties ! src/share/classes/com/sun/tools/javac/resources/javac_zh_CN.properties ! src/share/classes/com/sun/tools/javac/resources/legacy.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/AbstractLog.java ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java ! src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/Bits.java ! src/share/classes/com/sun/tools/javac/util/FatalError.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/LayoutCharacters.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/MandatoryWarningHandler.java ! src/share/classes/com/sun/tools/javac/util/Options.java ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/Warner.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java ! src/share/classes/com/sun/tools/javadoc/JavadocClassReader.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! src/share/classes/com/sun/tools/javadoc/Start.java ! src/share/classes/com/sun/tools/javadoc/resources/javadoc.properties ! src/share/classes/com/sun/tools/javah/JNI.java ! src/share/classes/com/sun/tools/javah/LLNI.java ! src/share/classes/com/sun/tools/javah/Mangle.java ! src/share/classes/com/sun/tools/javah/TypeSignature.java ! src/share/classes/com/sun/tools/javah/resources/version.properties-template ! src/share/classes/com/sun/tools/javap/AnnotationWriter.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! src/share/classes/com/sun/tools/javap/ClassWriter.java ! src/share/classes/com/sun/tools/javap/CodeWriter.java ! src/share/classes/com/sun/tools/javap/SourceWriter.java ! src/share/classes/javax/lang/model/element/ElementKind.java ! src/share/classes/javax/lang/model/element/ElementVisitor.java ! src/share/classes/javax/lang/model/type/MirroredTypeException.java ! src/share/classes/javax/lang/model/type/MirroredTypesException.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor6.java ! src/share/classes/javax/lang/model/util/ElementScanner6.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor6.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor6.java ! src/share/classes/javax/tools/ToolProvider.java ! src/share/sample/javac/processing/src/CheckNamesProcessor.java ! test/com/sun/javadoc/AccessAsciiArt/AccessAsciiArt.java ! test/com/sun/javadoc/AccessH1/AccessH1.java ! test/com/sun/javadoc/AccessSkipNav/AccessSkipNav.java ! test/com/sun/javadoc/AccessSummary/AccessSummary.java ! test/com/sun/javadoc/AuthorDD/AuthorDD.java ! test/com/sun/javadoc/JavascriptWinTitle/JavascriptWinTitle.java ! test/com/sun/javadoc/MetaTag/MetaTag.java ! test/com/sun/javadoc/ValidHtml/ValidHtml.java ! test/com/sun/javadoc/VersionNumber/VersionNumber.java ! test/com/sun/javadoc/WindowTitles/WindowTitles.java ! test/com/sun/javadoc/constantValues/TestConstantValuesDriver.java ! test/com/sun/javadoc/testClassCrossReferences/TestClassCrossReferences.java ! test/com/sun/javadoc/testClassTree/TestClassTree.java ! test/com/sun/javadoc/testConstructorIndent/TestConstructorIndent.java ! test/com/sun/javadoc/testDeprecatedDocs/TestDeprecatedDocs.java ! test/com/sun/javadoc/testDocRootInlineTag/TestDocRootInlineTag.java ! test/com/sun/javadoc/testExternalOverridenMethod/TestExternalOverridenMethod.java ! test/com/sun/javadoc/testHeadings/TestHeadings.java ! test/com/sun/javadoc/testHelpOption/TestHelpOption.java ! test/com/sun/javadoc/testHref/TestHref.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testHtmlStrongTag/TestHtmlStrongTag.java ! test/com/sun/javadoc/testHtmlTableTags/TestHtmlTableTags.java ! test/com/sun/javadoc/testHtmlTag/TestHtmlTag.java ! test/com/sun/javadoc/testIndex/TestIndex.java ! test/com/sun/javadoc/testInlineLinkLabel/TestInlineLinkLabel.java ! test/com/sun/javadoc/testInterface/TestInterface.java ! test/com/sun/javadoc/testJavascript/TestJavascript.java ! test/com/sun/javadoc/testLinkOption/TestLinkOption.java ! test/com/sun/javadoc/testLinkTaglet/TestLinkTaglet.java ! test/com/sun/javadoc/testLinkToSerialForm/TestLinkToSerialForm.java ! test/com/sun/javadoc/testMemberInheritence/TestMemberInheritence.java ! test/com/sun/javadoc/testMemberSummary/TestMemberSummary.java ! test/com/sun/javadoc/testNavagation/TestNavagation.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testOverridenMethods/TestMultiInheritence.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenMethodDocCopy.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethods.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPackageFlag.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPrivateFlag.java ! test/com/sun/javadoc/testPackagePage/TestPackagePage.java ! test/com/sun/javadoc/testParamTaglet/TestParamTaglet.java ! test/com/sun/javadoc/testPrivateClasses/TestPrivateClasses.java ! test/com/sun/javadoc/testSerializedForm/TestSerializedForm.java ! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java ! test/com/sun/javadoc/testSimpleTag/TestSimpleTag.java ! test/com/sun/javadoc/testStylesheet/TestStylesheet.java ! test/com/sun/javadoc/testSummaryHeading/TestSummaryHeading.java ! test/com/sun/javadoc/testSuperclassInSerialForm/TestSuperClassInSerialForm.java ! test/com/sun/javadoc/testTagInheritence/TestTagInheritence.java ! test/com/sun/javadoc/testTaglets/TestTaglets.java ! test/com/sun/javadoc/testTaglets/taglets/Foo.java ! test/com/sun/javadoc/testThrowsHead/TestThrowsHead.java ! test/com/sun/javadoc/testThrowsTag/TestThrowsTag.java ! test/com/sun/javadoc/testTitleInHref/TestTitleInHref.java ! test/com/sun/javadoc/testTypeParams/TestTypeParameters.java ! test/com/sun/javadoc/testUnnamedPackage/TestUnnamedPackage.java ! test/com/sun/javadoc/testValueTag/TestValueTag.java ! test/com/sun/javadoc/testWarnings/TestWarnings.java ! test/tools/javac/6341866/Anno.java ! test/tools/javac/6341866/T6341866.java ! test/tools/javac/6402516/CheckLocalElements.java ! test/tools/javac/ClassFileModifiers/ClassModifiers.java ! test/tools/javac/ClassFileModifiers/MemberModifiers.java ! test/tools/javac/EarlyAssert.java ! test/tools/javac/InterfaceAssert.java ! test/tools/javac/OverrideChecks/6738538/T6738538a.java ! test/tools/javac/OverrideChecks/6738538/T6738538b.java ! test/tools/javac/T6358024.java ! test/tools/javac/T6403466.java ! test/tools/javac/T6411379.java ! test/tools/javac/T6423583.java ! test/tools/javac/T6705935.java ! test/tools/javac/ThrowsIntersection_1.java ! test/tools/javac/ThrowsIntersection_2.java ! test/tools/javac/ThrowsIntersection_3.java ! test/tools/javac/ThrowsIntersection_4.java ! test/tools/javac/annotations/6214965/T6214965.java ! test/tools/javac/annotations/6365854/T6365854.java ! test/tools/javac/annotations/neg/Constant.java ! test/tools/javac/annotations/neg/Dep.java ! test/tools/javac/annotations/pos/TrailingComma.java ! test/tools/javac/api/6421111/T6421111.java ! test/tools/javac/api/6468404/T6468404.java ! test/tools/javac/api/6731573/T6731573.java ! test/tools/javac/api/T6392782.java ! test/tools/javac/api/T6412669.java ! test/tools/javac/api/TestOperators.java ! test/tools/javac/cast/6548436/T6548436d.java ! test/tools/javac/cast/6558559/T6558559a.java ! test/tools/javac/cast/6558559/T6558559b.java ! test/tools/javac/cast/6586091/T6586091.java ! test/tools/javac/danglingDep/DepX.java ! test/tools/javac/danglingDep/NoDepX.java ! test/tools/javac/danglingDep/Test1.java ! test/tools/javac/depOverrides/annotation/Test1.java ! test/tools/javac/depOverrides/annotation/Test2.java ! test/tools/javac/depOverrides/doccomment/Test1.java ! test/tools/javac/depOverrides/doccomment/Test2.java ! test/tools/javac/diags/examples/BadSourceFileHeader/sourcepath/p/A.java ! test/tools/javac/enum/6424358/T6424358.java ! test/tools/javac/enum/T6724345.java ! test/tools/javac/generics/Casting.java ! test/tools/javac/generics/Casting3.java ! test/tools/javac/generics/Casting4.java ! test/tools/javac/generics/InnerInterface1.java ! test/tools/javac/generics/InnerInterface2.java ! test/tools/javac/generics/Multibound1.java ! test/tools/javac/generics/MultipleInheritance.java ! test/tools/javac/generics/NameOrder.java ! test/tools/javac/generics/PermuteBound.java ! test/tools/javac/generics/PrimitiveVariant.java ! test/tools/javac/generics/T6557954.java ! test/tools/javac/generics/T6751514.java ! test/tools/javac/generics/T6869075.java ! test/tools/javac/generics/inference/6569789/T6569789.java ! test/tools/javac/generics/inference/6650759/T6650759a.java ! test/tools/javac/generics/typevars/5060485/Compatibility.java ! test/tools/javac/generics/typevars/5060485/Compatibility02.java ! test/tools/javac/generics/typevars/T6880344.java ! test/tools/javac/generics/wildcards/T6732484.java ! test/tools/javac/mandatoryWarnings/deprecated/Test.java ! test/tools/javac/mandatoryWarnings/unchecked/Test.java ! test/tools/javac/meth/InvokeMHTrans.java ! test/tools/javac/nio/compileTest/CompileTest.java ! test/tools/javac/policy/test1/Test1a.java ! test/tools/javac/policy/test2/Test.java ! test/tools/javac/processing/model/util/elements/Foo.java ! test/tools/javac/rawDiags/Note.java ! test/tools/javac/tree/TreeKindTest.java ! test/tools/javac/typeAnnotations/newlocations/BasicTest.java ! test/tools/javac/varargs/T6746184.java ! test/tools/javac/varargs/warning/Warn1.java ! test/tools/javadoc/T4994049/FileWithTabs.java ! test/tools/javadoc/T4994049/T4994049.java ! test/tools/javap/T6715251.java ! test/tools/javap/T6715753.java ! test/tools/javap/T6729471.java ! test/tools/javap/T6868539.java Changeset: e63b1f8341ce Author: lana Date: 2011-01-04 17:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e63b1f8341ce Merge ! make/Makefile ! src/share/classes/com/sun/tools/javac/file/Paths.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java ! test/tools/javac/nio/compileTest/CompileTest.java From maurizio.cimadamore at oracle.com Wed Jan 5 02:00:53 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Wed, 05 Jan 2011 10:00:53 +0000 Subject: hg: jdk7/tl/langtools: 7010194: several langtools regression failures after JSR 292 changes (b123) Message-ID: <20110105100058.2E57F479A4@hg.openjdk.java.net> Changeset: 15484cb7e5ae Author: mcimadamore Date: 2011-01-05 09:59 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/15484cb7e5ae 7010194: several langtools regression failures after JSR 292 changes (b123) Summary: Some regression tests rely on unsupported JSR 292 features Reviewed-by: jjg ! test/tools/javac/diags/examples/TypeParameterOnPolymorphicSignature.java - test/tools/javac/meth/InvokeDyn.java - test/tools/javac/meth/InvokeDynTrans.java ! test/tools/javac/meth/XlintWarn.java From stuart.marks at oracle.com Wed Jan 5 15:57:31 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Wed, 05 Jan 2011 15:57:31 -0800 Subject: review request for 7005608, update 1: diamond conversion of JCA and crypto providers Message-ID: <4D25056B.4070600@oracle.com> Here's an updated webrev for 7005608. I've removed the changes that use diamond in assignment statements. In these cases the variable is declared elsewhere, so using diamond for these makes the code somewhat less understandable. I've left in the use of diamond for variable initializers (which occur at the point of declaration, so the inferred type is right there) and for return statements (where the inferred type is the return type of the method). There were a couple cases where the variable declaration was just a "few" lines above the assignment statement, so using diamond wouldn't be too bad here. However, I still found myself hunting around a bit for the declaration. I also couldn't decide how far away was too far for using diamond: 5 lines? 10 lines? In the end, I decided not to use diamond for any assignment statements, if only for consistency. Also, I've added a space after the comma in Map at Brad's request. Note that I did not update the copyright years, as it seems that this will be handled by an automated process. Updated webrev here: http://cr.openjdk.java.net/~smarks/reviews/7005608/webrev.1/ Thanks! s'marks From tolmasky at gmail.com Wed Jan 5 20:48:52 2011 From: tolmasky at gmail.com (Francisco Tolmasky) Date: Wed, 5 Jan 2011 20:48:52 -0800 Subject: OpenJDK SSL problems Message-ID: Hi, First time poster, sorry if this is the wrong list (please point me to the right one if it is). Running the following line: javax.net.SSLContext.getInstance("Default") Gives me this error: java.net.SocketException: java.security.NoSuchAlgorithmException: Default SSLContext not available This is running OpenJDK 64-Bit Server VM (build 19.0-b09, mixed mode) on Ubuntu 64 bit 10.10 Not sure if this is relevant, but I'm running it from within VMWare Fusion. Thanks, Francisco From bradford.wetmore at oracle.com Wed Jan 5 21:10:07 2011 From: bradford.wetmore at oracle.com (Bradford Wetmore) Date: Wed, 05 Jan 2011 21:10:07 -0800 Subject: OpenJDK SSL problems In-Reply-To: References: Message-ID: <4D254EAF.2000003@oracle.com> Francisco, Sorry, but security-dev is not a support mailing list. I encourage you to see the API docs for SSLContext at: http://download.oracle.com/javase/6/docs/api/javax/net/ssl/SSLContext.html Best wishes, Brad On 1/5/2011 8:48 PM, Francisco Tolmasky wrote: > Hi, > > First time poster, sorry if this is the wrong list (please point me to the right one if it is). Running the following line: > > javax.net.SSLContext.getInstance("Default") > > Gives me this error: > > java.net.SocketException: java.security.NoSuchAlgorithmException: Default SSLContext not available > > This is running OpenJDK 64-Bit Server VM (build 19.0-b09, mixed mode) on Ubuntu 64 bit 10.10 > > Not sure if this is relevant, but I'm running it from within VMWare Fusion. > > Thanks, > > Francisco > From jonathan.gibbons at oracle.com Thu Jan 6 14:32:30 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 06 Jan 2011 22:32:30 +0000 Subject: hg: jdk7/tl/jdk: 7010537: javah no longer depends on javadoc Message-ID: <20110106223240.2813347A12@hg.openjdk.java.net> Changeset: d56c111ec6dc Author: jjg Date: 2011-01-06 14:32 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d56c111ec6dc 7010537: javah no longer depends on javadoc Reviewed-by: ohair ! make/common/shared/Defs-java.gmk From stuart.marks at oracle.com Thu Jan 6 16:16:04 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Thu, 06 Jan 2011 16:16:04 -0800 Subject: review request for 7008728, update 1: diamond conversion of basic security, permissions, authentication Message-ID: <4D265B44.9050605@oracle.com> Hi Sean, Here's an updated webrev for 7008728 which we had discussed earlier. Basically this webrev includes ONLY changes that use diamond in the initializer of a variable or field declaration, where the inferred type of the diamond is right there in the declaration. I've removed all the use of diamond from assignments, where the declaration (and thus the inferred type) is elsewhere. I've also removed the use of diamond from the problematic cases that we noted, such as within the ternary (?:) operator and within method arguments. http://cr.openjdk.java.net/~smarks/reviews/7008728/webrev.1/ Thanks! s'marks From chris.hegarty at oracle.com Fri Jan 7 05:09:19 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 07 Jan 2011 13:09:19 +0000 Subject: hg: jdk7/tl/jdk: 7000511: PrintStream, PrintWriter, Formatter, Scanner leave files open when exception thrown Message-ID: <20110107130940.CD02747A5C@hg.openjdk.java.net> Changeset: b8663921f5d7 Author: chegar Date: 2011-01-07 13:08 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b8663921f5d7 7000511: PrintStream, PrintWriter, Formatter, Scanner leave files open when exception thrown Reviewed-by: alanb, mduigou ! src/share/classes/java/io/PrintStream.java ! src/share/classes/java/io/PrintWriter.java ! src/share/classes/java/util/Formatter.java ! src/share/classes/java/util/Scanner.java ! test/ProblemList.txt + test/java/io/PrintStream/FailingConstructors.java + test/java/io/PrintWriter/FailingConstructors.java ! test/java/util/Formatter/Constructors.java + test/java/util/Formatter/FailingConstructors.java + test/java/util/Scanner/FailingConstructors.java From alan.bateman at oracle.com Fri Jan 7 07:52:13 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 07 Jan 2011 15:52:13 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110107155232.0A1D147A64@hg.openjdk.java.net> Changeset: 5124c2a50539 Author: alanb Date: 2011-01-07 15:49 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5124c2a50539 6993732: Remove the HPI Reviewed-by: ohair, lancea, chegar, mduigou, mchung, mr ! make/common/Defs-linux.gmk ! make/common/Defs-solaris.gmk ! make/common/Defs-windows.gmk ! make/common/Defs.gmk ! make/common/Modules.gmk ! make/common/Release.gmk ! make/java/Makefile ! make/java/fdlibm/Makefile - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile ! make/tools/reorder/Makefile - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c Changeset: ddaffd64796c Author: alanb Date: 2011-01-07 15:51 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ddaffd64796c Merge From sean.mullan at oracle.com Fri Jan 7 08:35:09 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 07 Jan 2011 11:35:09 -0500 Subject: review request for 7008728, update 1: diamond conversion of basic security, permissions, authentication In-Reply-To: <4D265B44.9050605@oracle.com> References: <4D265B44.9050605@oracle.com> Message-ID: <4D2740BD.7080604@oracle.com> Hi Stuart, It all looks good to me. One minor comment: Security.java [662]: add a space: s/Map/Map --Sean On 1/6/11 7:16 PM, Stuart Marks wrote: > Hi Sean, > > Here's an updated webrev for 7008728 which we had discussed earlier. > > Basically this webrev includes ONLY changes that use diamond in the initializer > of a variable or field declaration, where the inferred type of the diamond is > right there in the declaration. I've removed all the use of diamond from > assignments, where the declaration (and thus the inferred type) is elsewhere. > I've also removed the use of diamond from the problematic cases that we noted, > such as within the ternary (?:) operator and within method arguments. > > http://cr.openjdk.java.net/~smarks/reviews/7008728/webrev.1/ > > Thanks! > > s'marks From chris.hegarty at oracle.com Fri Jan 7 13:04:21 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 07 Jan 2011 21:04:21 +0000 Subject: hg: jdk7/tl/jdk: 7009760: Possible stack corruption in Java_java_net_TwoStacksPlainSocketImpl_socketGetOption Message-ID: <20110107210432.28CAC47A77@hg.openjdk.java.net> Changeset: 6bf1c5958c22 Author: chegar Date: 2011-01-07 21:02 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6bf1c5958c22 7009760: Possible stack corruption in Java_java_net_TwoStacksPlainSocketImpl_socketGetOption Summary: SOCKET_ADDRESS -> SOCKETADDRESS Reviewed-by: alanb ! src/windows/native/java/net/TwoStacksPlainSocketImpl.c From stuart.marks at oracle.com Fri Jan 7 15:36:58 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Fri, 07 Jan 2011 15:36:58 -0800 Subject: review request for 7008728, update 1: diamond conversion of basic security, permissions, authentication In-Reply-To: <4D2740BD.7080604@oracle.com> References: <4D265B44.9050605@oracle.com> <4D2740BD.7080604@oracle.com> Message-ID: <4D27A39A.7040004@oracle.com> Great, I'll make this change and push the changeset. Thanks! s'marks On 1/7/11 8:35 AM, Sean Mullan wrote: > Hi Stuart, > > It all looks good to me. One minor comment: > > Security.java > > [662]: add a space: s/Map/Map > > --Sean > > On 1/6/11 7:16 PM, Stuart Marks wrote: >> Hi Sean, >> >> Here's an updated webrev for 7008728 which we had discussed earlier. >> >> Basically this webrev includes ONLY changes that use diamond in the initializer >> of a variable or field declaration, where the inferred type of the diamond is >> right there in the declaration. I've removed all the use of diamond from >> assignments, where the declaration (and thus the inferred type) is elsewhere. >> I've also removed the use of diamond from the problematic cases that we noted, >> such as within the ternary (?:) operator and within method arguments. >> >> http://cr.openjdk.java.net/~smarks/reviews/7008728/webrev.1/ >> >> Thanks! >> >> s'marks From stuart.marks at oracle.com Fri Jan 7 16:18:31 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Sat, 08 Jan 2011 00:18:31 +0000 Subject: hg: jdk7/tl/jdk: 7008728: diamond conversion of basic security, permissions, authentication Message-ID: <20110108001841.DFF9847A81@hg.openjdk.java.net> Changeset: 3dbc783a8073 Author: smarks Date: 2011-01-07 15:39 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3dbc783a8073 7008728: diamond conversion of basic security, permissions, authentication Reviewed-by: mullan ! src/share/classes/com/sun/security/auth/PolicyFile.java ! src/share/classes/com/sun/security/auth/callback/DialogCallbackHandler.java ! src/share/classes/com/sun/security/auth/login/ConfigFile.java ! src/share/classes/com/sun/security/auth/module/JndiLoginModule.java ! src/share/classes/com/sun/security/auth/module/KeyStoreLoginModule.java ! src/share/classes/com/sun/security/auth/module/SolarisLoginModule.java ! src/share/classes/com/sun/security/auth/module/UnixLoginModule.java ! src/share/classes/java/security/AccessControlContext.java ! src/share/classes/java/security/BasicPermission.java ! src/share/classes/java/security/CodeSource.java ! src/share/classes/java/security/Permissions.java ! src/share/classes/java/security/ProtectionDomain.java ! src/share/classes/java/security/Provider.java ! src/share/classes/java/security/SecureClassLoader.java ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/UnresolvedPermission.java ! src/share/classes/java/security/UnresolvedPermissionCollection.java ! src/share/classes/javax/security/auth/PrivateCredentialPermission.java ! src/share/classes/javax/security/auth/SubjectDomainCombiner.java ! src/share/classes/javax/security/auth/kerberos/DelegationPermission.java ! src/share/classes/javax/security/auth/kerberos/ServicePermission.java ! src/share/classes/sun/security/acl/AclEntryImpl.java ! src/share/classes/sun/security/acl/AclImpl.java ! src/share/classes/sun/security/acl/GroupImpl.java ! test/com/sun/security/auth/module/LdapLoginModule/CheckConfigs.java ! test/com/sun/security/auth/module/LdapLoginModule/CheckOptions.java From stuart.marks at oracle.com Fri Jan 7 17:33:21 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Fri, 07 Jan 2011 17:33:21 -0800 Subject: review request for 7008728, update 1: diamond conversion of basic security, permissions, authentication In-Reply-To: <4D27A39A.7040004@oracle.com> References: <4D265B44.9050605@oracle.com> <4D2740BD.7080604@oracle.com> <4D27A39A.7040004@oracle.com> Message-ID: <4D27BEE1.5010306@oracle.com> Oops! I made this change (and rebuilt and tested) but I forgot to qrefresh before pushing it, so this didn't actually get in. Hrmm, well, I guess I'll piggyback this onto one of the other pending changes in the security area. Sorry about that Chief, s'marks On 1/7/11 3:36 PM, Stuart Marks wrote: > Great, I'll make this change and push the changeset. > > Thanks! > > s'marks > > On 1/7/11 8:35 AM, Sean Mullan wrote: >> Hi Stuart, >> >> It all looks good to me. One minor comment: >> >> Security.java >> >> [662]: add a space: s/Map/Map >> >> --Sean >> >> On 1/6/11 7:16 PM, Stuart Marks wrote: >>> Hi Sean, >>> >>> Here's an updated webrev for 7008728 which we had discussed earlier. >>> >>> Basically this webrev includes ONLY changes that use diamond in the initializer >>> of a variable or field declaration, where the inferred type of the diamond is >>> right there in the declaration. I've removed all the use of diamond from >>> assignments, where the declaration (and thus the inferred type) is elsewhere. >>> I've also removed the use of diamond from the problematic cases that we noted, >>> such as within the ternary (?:) operator and within method arguments. >>> >>> http://cr.openjdk.java.net/~smarks/reviews/7008728/webrev.1/ >>> >>> Thanks! >>> >>> s'marks From alan.bateman at oracle.com Mon Jan 10 01:33:25 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 10 Jan 2011 09:33:25 +0000 Subject: hg: jdk7/tl/jdk: 7002957: (fc) FileChannel.transferTo fails to load libsendfile on Solaris 64-bit Message-ID: <20110110093352.360CA47AFA@hg.openjdk.java.net> Changeset: ee5bf287d0c4 Author: alanb Date: 2011-01-10 09:32 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ee5bf287d0c4 7002957: (fc) FileChannel.transferTo fails to load libsendfile on Solaris 64-bit Reviewed-by: chegar ! make/java/nio/Makefile ! src/solaris/native/sun/nio/ch/FileChannelImpl.c From lance.andersen at oracle.com Mon Jan 10 11:44:21 2011 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Mon, 10 Jan 2011 19:44:21 +0000 Subject: hg: jdk7/tl/jdk: 6544224: Remove the need of sun.reflect.misc Message-ID: <20110110194439.C6FB447B1F@hg.openjdk.java.net> Changeset: f4d755bbdabe Author: lancea Date: 2011-01-10 14:43 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f4d755bbdabe 6544224: Remove the need of sun.reflect.misc Reviewed-by: alanb ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java From jonathan.gibbons at oracle.com Mon Jan 10 14:59:14 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 10 Jan 2011 22:59:14 +0000 Subject: hg: jdk7/tl/langtools: 6992999: fully remove JSR 308 from langtools Message-ID: <20110110225918.7849547B33@hg.openjdk.java.net> Changeset: d17f37522154 Author: jjg Date: 2011-01-10 14:57 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d17f37522154 6992999: fully remove JSR 308 from langtools Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/tree/MethodTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/tree/TypeParameterTree.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java - src/share/classes/com/sun/tools/classfile/ExtendedAnnotation.java - src/share/classes/com/sun/tools/classfile/RuntimeInvisibleTypeAnnotations_attribute.java - src/share/classes/com/sun/tools/classfile/RuntimeTypeAnnotations_attribute.java - src/share/classes/com/sun/tools/classfile/RuntimeVisibleTypeAnnotations_attribute.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java - src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! src/share/classes/com/sun/tools/javap/AnnotationWriter.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! src/share/classes/com/sun/tools/javap/CodeWriter.java ! src/share/classes/com/sun/tools/javap/InstructionDetailWriter.java - src/share/classes/com/sun/tools/javap/TypeAnnotationWriter.java ! test/tools/javac/diags/examples.not-yet.txt From jonathan.gibbons at oracle.com Mon Jan 10 15:08:58 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 10 Jan 2011 23:08:58 +0000 Subject: hg: jdk7/tl/langtools: 6396503: javac should not require assertions enabled Message-ID: <20110110230900.A161047B35@hg.openjdk.java.net> Changeset: 7c537f4298fb Author: jjg Date: 2011-01-10 15:08 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7c537f4298fb 6396503: javac should not require assertions enabled Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/Main.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Scope.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndexArchive.java ! src/share/classes/com/sun/tools/javac/jvm/CRTable.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Items.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java + src/share/classes/com/sun/tools/javac/util/Assert.java ! src/share/classes/com/sun/tools/javac/util/Bits.java ! src/share/classes/com/sun/tools/javac/util/Context.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/UnsharedNameTable.java ! src/share/classes/javax/tools/ToolProvider.java From bradford.wetmore at oracle.com Mon Jan 10 16:44:16 2011 From: bradford.wetmore at oracle.com (Bradford Wetmore) Date: Mon, 10 Jan 2011 16:44:16 -0800 Subject: review request for 7005608, update 1: diamond conversion of JCA and crypto providers In-Reply-To: <4D25056B.4070600@oracle.com> References: <4D25056B.4070600@oracle.com> Message-ID: <4D2BA7E0.2050906@oracle.com> On 1/5/2011 3:57 PM, Stuart Marks wrote: > Here's an updated webrev for 7005608. > > I've removed the changes that use diamond in assignment statements. In > these cases the variable is declared elsewhere, so using diamond for > these makes the code somewhat less understandable. I've left in the use > of diamond for variable initializers (which occur at the point of > declaration, so the inferred type is right there) and for return > statements (where the inferred type is the return type of the method). > > There were a couple cases where the variable declaration was just a > "few" lines above the assignment statement, so using diamond wouldn't be > too bad here. However, I still found myself hunting around a bit for the > declaration. I also couldn't decide how far away was too far for using > diamond: 5 lines? 10 lines? In the end, I decided not to use diamond for > any assignment statements, if only for consistency. Ok, sounds reasonable. > Also, I've added a space after the comma in > > Map > > at Brad's request. I could go either way, as long as it's consistent. vs. looks a little strange, but not as strange as Map But ultimately could get used to either way. > Note that I did not update the copyright years, as it seems that this > will be handled by an automated process. Them's the marching orders we got, so I'll trust it actually works. > Updated webrev here: > > http://cr.openjdk.java.net/~smarks/reviews/7005608/webrev.1/ Looks fine. Brad From stuart.marks at oracle.com Mon Jan 10 17:20:26 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Tue, 11 Jan 2011 01:20:26 +0000 Subject: hg: jdk7/tl/jdk: 7005608: diamond conversion of JCA and crypto providers Message-ID: <20110111012043.BEB7A47B3A@hg.openjdk.java.net> Changeset: 2a0ff59928de Author: smarks Date: 2011-01-10 17:06 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2a0ff59928de 7005608: diamond conversion of JCA and crypto providers Reviewed-by: wetmore ! src/share/classes/java/security/Security.java ! src/share/classes/sun/security/jca/ProviderList.java ! src/share/classes/sun/security/jca/Providers.java ! src/share/classes/sun/security/provider/PolicyFile.java ! src/share/classes/sun/security/provider/Sun.java ! src/share/classes/sun/security/provider/VerificationProvider.java ! src/share/classes/sun/security/provider/X509Factory.java ! src/share/classes/sun/security/rsa/RSACore.java ! src/share/classes/sun/security/rsa/SunRsaSign.java From jonathan.gibbons at oracle.com Tue Jan 11 08:07:21 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 11 Jan 2011 16:07:21 +0000 Subject: hg: jdk7/tl/langtools: 6993305: starting position of a method without modifiers and with type parameters is incorrect Message-ID: <20110111160725.276BF47B74@hg.openjdk.java.net> Changeset: 17b271281525 Author: jjg Date: 2011-01-11 08:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/17b271281525 6993305: starting position of a method without modifiers and with type parameters is incorrect Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/tree/T6993305.java From lance.andersen at oracle.com Tue Jan 11 09:37:12 2011 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Tue, 11 Jan 2011 17:37:12 +0000 Subject: hg: jdk7/tl/jdk: 7000693: java.sql.Timestamp compareTo() issues using low values Message-ID: <20110111173730.9A2D347B78@hg.openjdk.java.net> Changeset: befe813e24d2 Author: lancea Date: 2011-01-11 12:36 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/befe813e24d2 7000693: java.sql.Timestamp compareTo() issues using low values Reviewed-by: okutsu ! src/share/classes/java/sql/Timestamp.java From stuart.marks at oracle.com Tue Jan 11 14:24:24 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Tue, 11 Jan 2011 22:24:24 +0000 Subject: hg: jdk7/tl/jdk: 7011095: revert diamond changes from 6880112 that occur in method args Message-ID: <20110111222434.61AC447B86@hg.openjdk.java.net> Changeset: 6d0217114886 Author: smarks Date: 2011-01-11 13:42 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6d0217114886 7011095: revert diamond changes from 6880112 that occur in method args Reviewed-by: darcy, alanb ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/java/io/ObjectStreamClass.java ! src/share/classes/java/lang/StringCoding.java ! src/share/classes/java/util/logging/Logger.java From stuart.marks at oracle.com Tue Jan 11 16:06:40 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Tue, 11 Jan 2011 16:06:40 -0800 Subject: review request for 7008713, update 1: diamond conversion of kerberos5 and security tools Message-ID: <4D2CF090.9020901@oracle.com> Hi Max, Here, finally, is an updated webrev for 7008713. Like the other updates, this is the automated diamond conversion but with diamonds removed from assignment statements. This is mostly diamonds used in variable initializers. I think there's one in a return statement in there too. I've adjusted whitespace that ended up around the diamond operator itself. I think there's a pretty strong convention not to have any space within or around a diamond. There are several places where I made changes like the following: new HashMap<> () ===> new HashMap<>() For their webrevs both Sean and Brad had asked me to tweak whitespace after the comma in the list of generic type arguments. For example, like the following: Map ===> Map However, I did *not* make such changes in this webrev. I didn't know whether you would have wanted such changes; there are rather a lot of them to change, and it's also not clear to me whether it actually would have improved the consistency of the spacing in this section of code. But, let me know if you'd like me to adjust this whitespace as well. Here's a link to the updated webrev. http://cr.openjdk.java.net/~smarks/reviews/7008713/webrev.1/ Thanks! s'marks From stuart.marks at oracle.com Tue Jan 11 19:04:40 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Tue, 11 Jan 2011 19:04:40 -0800 Subject: review request for 7008713, update 1: diamond conversion of kerberos5 and security tools In-Reply-To: <4D2D02EC.3080706@oracle.com> References: <4D2CF090.9020901@oracle.com> <4D2D02EC.3080706@oracle.com> Message-ID: <4D2D1A48.7040303@oracle.com> Hi Max, thanks for reviewing the webrev. On 1/11/11 5:25 PM, Weijun Wang wrote: > On 01/12/2011 08:06 AM, Stuart Marks wrote: >> I think there's one in a return statement in there too. > > You mean this one? > > public static Pair of(A a, B b) { > - return new Pair(a,b); > + return new Pair<>(a,b); > } > > I wonder if it should be included. The reason why people don't like "<>" in > non-initializer, which I guess, is that it's too faraway from the declaration > and people want to read the full generics parameters as a reminder. This is > also true for a return statement when the method declaration is normally > faraway from it. > > Of course, in this particular case, the return line is very near to the return > type declaration, so it doesn't seem too bad. Just don't know how your > automated conversion deals with other cases. Yes, this is the one return statement I recall seeing. I think you've correctly identified the issue. For a return statement, the inferred type is the return type of the method, which is usually not too far away. In this case it's quite close but in other cases it could be pretty far away, but still at the top of the current method, which is usually not too hard to find. This isn't as bad as field assignment, whose declarations can be arbitrarily far away (though usually in the same file). It's even worse for method args, where the inferred type can even be in a different file. The automated conversion tool applies diamond everywhere it possibly can. For this set of changes I've manually filtered out the changes we don't want to apply, such as assignment statements. I left this diamond on the return statement, though, since there didn't seem to be a compelling reason to take it out. Of course, diamond hardly buys anything here since it's just the type parameters . I can leave this in or take it out as you prefer. (There is a newer version of the tool that allows one to configure which cases diamond is applied to. I'll start using that in subsequent rounds of diamond changes.) >> I've adjusted whitespace that ended up around the diamond operator >> itself. I think there's a pretty strong convention not to have any space >> within or around a diamond. There are several places where I made >> changes like the following: >> >> new HashMap<> () ===> new HashMap<>() > > Do you also change the declaration? > > Map map ===> Map map > > In src/share/classes/sun/security/tools/KeyTool.java, I see > > @@ -153,11 +153,11 @@ > ... > - private List ids = new ArrayList (); // used in GENCRL > - private List v3ext = new ArrayList (); > + private List ids = new ArrayList<>(); // used in GENCRL > + private List v3ext = new ArrayList<>(); > > so, "List v3ext" is changed to "List v3ext". Oh yes, good catch, I happened to see an extra space before the type arguments so I took it out. This was me making changes by hand, not the automated tool. > but, in the same file, > > @@ -3873,8 +3873,7 @@ > break; > case 2: // EKU > if(value != null) { > - Vector v = > - new Vector (); > + Vector v = new Vector<>(); > for (String s: value.split(",")) { > int p = oneOf(s, > "anyExtendedKeyUsage", > > Here, there's still a whitespace in "Vector ". Yeah, I missed that one. I'd say the space after "Vector" should be removed. > There are also lines in this file with only the declaration: > > 127: private Set> providers = null; > 499: providers = new HashSet> (3); > 663: for (Pair provider: providers) { These cases aren't as clear-cut. Sure, maybe there shouldn't be a space before the '<' but if there's a space after the comma (see below) then it makes things confusing. >> For their webrevs both Sean and Brad had asked me to tweak whitespace >> after the comma in the list of generic type arguments. For example, like >> the following: >> >> Map ===> Map >> >> However, I did *not* make such changes in this webrev. I didn't know >> whether you would have wanted such changes; there are rather a lot of >> them to change, and it's also not clear to me whether it actually would >> have improved the consistency of the spacing in this section of code. >> But, let me know if you'd like me to adjust this whitespace as well. > > My style was no whitespace after "," but probably it's not good. Now I think > is OK but is better. Page 130 of "Effective Java 2nd > version" seems to support this. Yeah, no space after the comma for cases like this Map seem reasonable, but space after comma for cases like this Map also seems reasonable. But what about more complex generic types? This code unfortunately has a lot of them. Like the examples you cite above, which is better? This HashSet> or HashSet> or even HashSet> ? Actually there are even more complex cases such as this one from src/share/classes/sun/security/krb5/Config.java: Hashtable>> temp = ... Where should the spaces go in that? I'm not sure.... > Since this code change is about coinification, I really don't care about > whitespace styles here. Yeah the whitespace is basically a distraction from coinification. I'm inclined to do the following: - use diamond in the return statement discussed above - remove whitespace from "Vector " - leave whitespace in complex generic types alone but I'm happy to do otherwise on these if you prefer, or to make other changes you might suggest. Thanks. s'marks > > Thanks > Max > >> >> Here's a link to the updated webrev. >> >> http://cr.openjdk.java.net/~smarks/reviews/7008713/webrev.1/ >> >> Thanks! >> >> s'marks From weijun.wang at oracle.com Tue Jan 11 17:25:00 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 12 Jan 2011 09:25:00 +0800 Subject: review request for 7008713, update 1: diamond conversion of kerberos5 and security tools In-Reply-To: <4D2CF090.9020901@oracle.com> References: <4D2CF090.9020901@oracle.com> Message-ID: <4D2D02EC.3080706@oracle.com> Hi Stuart On 01/12/2011 08:06 AM, Stuart Marks wrote: > Hi Max, > > Here, finally, is an updated webrev for 7008713. Like the other updates, > this is the automated diamond conversion but with diamonds removed from > assignment statements. This is mostly diamonds used in variable > initializers. I think there's one in a return statement in there too. You mean this one? public static Pair of(A a, B b) { - return new Pair(a,b); + return new Pair<>(a,b); } I wonder if it should be included. The reason why people don't like "<>" in non-initializer, which I guess, is that it's too faraway from the declaration and people want to read the full generics parameters as a reminder. This is also true for a return statement when the method declaration is normally faraway from it. Of course, in this particular case, the return line is very near to the return type declaration, so it doesn't seem too bad. Just don't know how your automated conversion deals with other cases. > > I've adjusted whitespace that ended up around the diamond operator > itself. I think there's a pretty strong convention not to have any space > within or around a diamond. There are several places where I made > changes like the following: > > new HashMap<> () ===> new HashMap<>() Do you also change the declaration? Map map ===> Map map In src/share/classes/sun/security/tools/KeyTool.java, I see @@ -153,11 +153,11 @@ ... - private List ids = new ArrayList (); // used in GENCRL - private List v3ext = new ArrayList (); + private List ids = new ArrayList<>(); // used in GENCRL + private List v3ext = new ArrayList<>(); so, "List v3ext" is changed to "List v3ext". but, in the same file, @@ -3873,8 +3873,7 @@ break; case 2: // EKU if(value != null) { - Vector v = - new Vector (); + Vector v = new Vector<>(); for (String s: value.split(",")) { int p = oneOf(s, "anyExtendedKeyUsage", Here, there's still a whitespace in "Vector ". There are also lines in this file with only the declaration: 127: private Set> providers = null; 499: providers = new HashSet> (3); 663: for (Pair provider: providers) { > > For their webrevs both Sean and Brad had asked me to tweak whitespace > after the comma in the list of generic type arguments. For example, like > the following: > > Map ===> Map > > However, I did *not* make such changes in this webrev. I didn't know > whether you would have wanted such changes; there are rather a lot of > them to change, and it's also not clear to me whether it actually would > have improved the consistency of the spacing in this section of code. > But, let me know if you'd like me to adjust this whitespace as well. My style was no whitespace after "," but probably it's not good. Now I think is OK but is better. Page 130 of "Effective Java 2nd version" seems to support this. Since this code change is about coinification, I really don't care about whitespace styles here. Thanks Max > > Here's a link to the updated webrev. > > http://cr.openjdk.java.net/~smarks/reviews/7008713/webrev.1/ > > Thanks! > > s'marks From weijun.wang at oracle.com Tue Jan 11 19:30:19 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 12 Jan 2011 11:30:19 +0800 Subject: review request for 7008713, update 1: diamond conversion of kerberos5 and security tools In-Reply-To: <4D2D1A48.7040303@oracle.com> References: <4D2CF090.9020901@oracle.com> <4D2D02EC.3080706@oracle.com> <4D2D1A48.7040303@oracle.com> Message-ID: <4D2D204B.20404@oracle.com> Hi Stuart In fact, I'm quite OK with the previous webrev. There can be more tweaks or manual editing, but not too necessary. As for writing codes as a human, I will certainly use it in the initializer, where it looks ugly with the same parameter appears twice in a single line of code. As for other cases, I don't know yet. If NetBeans keeps on showing warnings for all possible coinifications, I might start use it everywhere, the yellow bulb is really frustrating. And I prefer HashSet>, my rule is that space is only inserted after "," unless *all* parameters have only one letter. Thanks Max On 01/12/2011 11:04 AM, Stuart Marks wrote: > Hi Max, thanks for reviewing the webrev. > > On 1/11/11 5:25 PM, Weijun Wang wrote: >> On 01/12/2011 08:06 AM, Stuart Marks wrote: >>> I think there's one in a return statement in there too. >> >> You mean this one? >> >> public static Pair of(A a, B b) { >> - return new Pair(a,b); >> + return new Pair<>(a,b); >> } >> >> I wonder if it should be included. The reason why people don't like >> "<>" in >> non-initializer, which I guess, is that it's too faraway from the >> declaration >> and people want to read the full generics parameters as a reminder. >> This is >> also true for a return statement when the method declaration is normally >> faraway from it. >> >> Of course, in this particular case, the return line is very near to >> the return >> type declaration, so it doesn't seem too bad. Just don't know how your >> automated conversion deals with other cases. > > Yes, this is the one return statement I recall seeing. I think you've > correctly identified the issue. For a return statement, the inferred > type is the return type of the method, which is usually not too far > away. In this case it's quite close but in other cases it could be > pretty far away, but still at the top of the current method, which is > usually not too hard to find. This isn't as bad as field assignment, > whose declarations can be arbitrarily far away (though usually in the > same file). It's even worse for method args, where the inferred type can > even be in a different file. > > The automated conversion tool applies diamond everywhere it possibly > can. For this set of changes I've manually filtered out the changes we > don't want to apply, such as assignment statements. I left this diamond > on the return statement, though, since there didn't seem to be a > compelling reason to take it out. Of course, diamond hardly buys > anything here since it's just the type parameters . > > I can leave this in or take it out as you prefer. > > (There is a newer version of the tool that allows one to configure which > cases diamond is applied to. I'll start using that in subsequent rounds > of diamond changes.) > >>> I've adjusted whitespace that ended up around the diamond operator >>> itself. I think there's a pretty strong convention not to have any space >>> within or around a diamond. There are several places where I made >>> changes like the following: >>> >>> new HashMap<> () ===> new HashMap<>() >> >> Do you also change the declaration? >> >> Map map ===> Map map >> >> In src/share/classes/sun/security/tools/KeyTool.java, I see >> >> @@ -153,11 +153,11 @@ >> ... >> - private List ids = new ArrayList (); // used in >> GENCRL >> - private List v3ext = new ArrayList (); >> + private List ids = new ArrayList<>(); // used in GENCRL >> + private List v3ext = new ArrayList<>(); >> >> so, "List v3ext" is changed to "List v3ext". > > Oh yes, good catch, I happened to see an extra space before the type > arguments so I took it out. This was me making changes by hand, not the > automated tool. > >> but, in the same file, >> >> @@ -3873,8 +3873,7 @@ >> break; >> case 2: // EKU >> if(value != null) { >> - Vector v = >> - new Vector (); >> + Vector v = new Vector<>(); >> for (String s: value.split(",")) { >> int p = oneOf(s, >> "anyExtendedKeyUsage", >> >> Here, there's still a whitespace in "Vector ". > > Yeah, I missed that one. I'd say the space after "Vector" should be > removed. > >> There are also lines in this file with only the declaration: >> >> 127: private Set> providers = null; >> 499: providers = new HashSet> (3); >> 663: for (Pair provider: providers) { > > These cases aren't as clear-cut. Sure, maybe there shouldn't be a space > before the '<' but if there's a space after the comma (see below) then > it makes things confusing. > >>> For their webrevs both Sean and Brad had asked me to tweak whitespace >>> after the comma in the list of generic type arguments. For example, like >>> the following: >>> >>> Map ===> Map >>> >>> However, I did *not* make such changes in this webrev. I didn't know >>> whether you would have wanted such changes; there are rather a lot of >>> them to change, and it's also not clear to me whether it actually would >>> have improved the consistency of the spacing in this section of code. >>> But, let me know if you'd like me to adjust this whitespace as well. >> >> My style was no whitespace after "," but probably it's not good. Now I >> think >> is OK but is better. Page 130 of "Effective >> Java 2nd >> version" seems to support this. > > Yeah, no space after the comma for cases like this > > Map > > seem reasonable, but space after comma for cases like this > > Map > > also seems reasonable. But what about more complex generic types? This > code unfortunately has a lot of them. Like the examples you cite above, > which is better? This > > HashSet> > > or > > HashSet> > > or even > > HashSet> > > ? Actually there are even more complex cases such as this one from > src/share/classes/sun/security/krb5/Config.java: > > Hashtable>> temp = ... > > Where should the spaces go in that? I'm not sure.... > >> Since this code change is about coinification, I really don't care about >> whitespace styles here. > > Yeah the whitespace is basically a distraction from coinification. > > I'm inclined to do the following: > > - use diamond in the return statement discussed above > - remove whitespace from "Vector " > - leave whitespace in complex generic types alone > > but I'm happy to do otherwise on these if you prefer, or to make other > changes you might suggest. > > Thanks. > > s'marks > >> >> Thanks >> Max >> >>> >>> Here's a link to the updated webrev. >>> >>> http://cr.openjdk.java.net/~smarks/reviews/7008713/webrev.1/ >>> >>> Thanks! >>> >>> s'marks From chris.hegarty at oracle.com Wed Jan 12 06:42:07 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 12 Jan 2011 14:42:07 +0000 Subject: hg: jdk7/tl/jdk: 7005424: Resync java.util.concurrent classes with Dougs CVS - Jan 2011 Message-ID: <20110112144218.4BB9A47BB3@hg.openjdk.java.net> Changeset: cb3ecb5e4ce5 Author: dl Date: 2011-01-12 14:40 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cb3ecb5e4ce5 7005424: Resync java.util.concurrent classes with Dougs CVS - Jan 2011 Reviewed-by: dholmes, chegar, mduigou ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/LinkedList.java ! src/share/classes/java/util/concurrent/ArrayBlockingQueue.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedDeque.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ForkJoinTask.java ! src/share/classes/java/util/concurrent/ForkJoinWorkerThread.java ! src/share/classes/java/util/concurrent/LinkedBlockingDeque.java ! src/share/classes/java/util/concurrent/LinkedBlockingQueue.java ! src/share/classes/java/util/concurrent/LinkedTransferQueue.java ! src/share/classes/java/util/concurrent/Phaser.java ! src/share/classes/java/util/concurrent/PriorityBlockingQueue.java ! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java ! src/share/classes/java/util/concurrent/SynchronousQueue.java ! src/share/classes/java/util/concurrent/ThreadPoolExecutor.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicMarkableReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicStampedReference.java ! src/share/classes/java/util/concurrent/locks/Condition.java ! test/ProblemList.txt ! test/java/util/WeakHashMap/GCDuringIteration.java ! test/java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java ! test/java/util/concurrent/BlockingQueue/MultipleProducersSingleConsumerLoops.java ! test/java/util/concurrent/BlockingQueue/ProducerConsumerLoops.java ! test/java/util/concurrent/BlockingQueue/SingleProducerMultipleConsumerLoops.java ! test/java/util/concurrent/ConcurrentQueues/IteratorWeakConsistency.java ! test/java/util/concurrent/Executors/AutoShutdown.java ! test/java/util/concurrent/Phaser/Basic.java + test/java/util/concurrent/Phaser/FickleRegister.java + test/java/util/concurrent/Phaser/PhaseOverflow.java + test/java/util/concurrent/Phaser/TieredArriveLoops.java ! test/java/util/concurrent/ThreadPoolExecutor/CoreThreadTimeOut.java From stuart.marks at oracle.com Wed Jan 12 13:31:30 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Wed, 12 Jan 2011 13:31:30 -0800 Subject: review request for 7008713, update 1: diamond conversion of kerberos5 and security tools In-Reply-To: <4D2D204B.20404@oracle.com> References: <4D2CF090.9020901@oracle.com> <4D2D02EC.3080706@oracle.com> <4D2D1A48.7040303@oracle.com> <4D2D204B.20404@oracle.com> Message-ID: <4D2E1DB2.8090509@oracle.com> Great, thanks, I'll go ahead and push the change. Regarding NetBeans and warnings, I've been in contact with the NetBeans folks and I've asked them to make the hint engine configurable. It's quite clear from this and the foregoing discussion that we want to use diamond in certain cases but not others. Having NB raise warnings everywhere diamond can possibly be used is clearly inappropriate. I don't know exactly how it will end up, but maybe the warnings will be configurable, or maybe there will be a batch mode "diamond finder" that will offer to apply diamond to a list of sites, and you can pick and choose where you want it applied. s'marks On 1/11/11 7:30 PM, Weijun Wang wrote: > Hi Stuart > > In fact, I'm quite OK with the previous webrev. There can be more tweaks or > manual editing, but not too necessary. > > As for writing codes as a human, I will certainly use it in the initializer, > where it looks ugly with the same parameter appears twice in a single line of > code. As for other cases, I don't know yet. If NetBeans keeps on showing > warnings for all possible coinifications, I might start use it everywhere, the > yellow bulb is really frustrating. > > And I prefer HashSet>, my rule is that space is only > inserted after "," unless *all* parameters have only one letter. > > Thanks > Max > > > On 01/12/2011 11:04 AM, Stuart Marks wrote: >> Hi Max, thanks for reviewing the webrev. >> >> On 1/11/11 5:25 PM, Weijun Wang wrote: >>> On 01/12/2011 08:06 AM, Stuart Marks wrote: >>>> I think there's one in a return statement in there too. >>> >>> You mean this one? >>> >>> public static Pair of(A a, B b) { >>> - return new Pair(a,b); >>> + return new Pair<>(a,b); >>> } >>> >>> I wonder if it should be included. The reason why people don't like >>> "<>" in >>> non-initializer, which I guess, is that it's too faraway from the >>> declaration >>> and people want to read the full generics parameters as a reminder. >>> This is >>> also true for a return statement when the method declaration is normally >>> faraway from it. >>> >>> Of course, in this particular case, the return line is very near to >>> the return >>> type declaration, so it doesn't seem too bad. Just don't know how your >>> automated conversion deals with other cases. >> >> Yes, this is the one return statement I recall seeing. I think you've >> correctly identified the issue. For a return statement, the inferred >> type is the return type of the method, which is usually not too far >> away. In this case it's quite close but in other cases it could be >> pretty far away, but still at the top of the current method, which is >> usually not too hard to find. This isn't as bad as field assignment, >> whose declarations can be arbitrarily far away (though usually in the >> same file). It's even worse for method args, where the inferred type can >> even be in a different file. >> >> The automated conversion tool applies diamond everywhere it possibly >> can. For this set of changes I've manually filtered out the changes we >> don't want to apply, such as assignment statements. I left this diamond >> on the return statement, though, since there didn't seem to be a >> compelling reason to take it out. Of course, diamond hardly buys >> anything here since it's just the type parameters . >> >> I can leave this in or take it out as you prefer. >> >> (There is a newer version of the tool that allows one to configure which >> cases diamond is applied to. I'll start using that in subsequent rounds >> of diamond changes.) >> >>>> I've adjusted whitespace that ended up around the diamond operator >>>> itself. I think there's a pretty strong convention not to have any space >>>> within or around a diamond. There are several places where I made >>>> changes like the following: >>>> >>>> new HashMap<> () ===> new HashMap<>() >>> >>> Do you also change the declaration? >>> >>> Map map ===> Map map >>> >>> In src/share/classes/sun/security/tools/KeyTool.java, I see >>> >>> @@ -153,11 +153,11 @@ >>> ... >>> - private List ids = new ArrayList (); // used in >>> GENCRL >>> - private List v3ext = new ArrayList (); >>> + private List ids = new ArrayList<>(); // used in GENCRL >>> + private List v3ext = new ArrayList<>(); >>> >>> so, "List v3ext" is changed to "List v3ext". >> >> Oh yes, good catch, I happened to see an extra space before the type >> arguments so I took it out. This was me making changes by hand, not the >> automated tool. >> >>> but, in the same file, >>> >>> @@ -3873,8 +3873,7 @@ >>> break; >>> case 2: // EKU >>> if(value != null) { >>> - Vector v = >>> - new Vector (); >>> + Vector v = new Vector<>(); >>> for (String s: value.split(",")) { >>> int p = oneOf(s, >>> "anyExtendedKeyUsage", >>> >>> Here, there's still a whitespace in "Vector ". >> >> Yeah, I missed that one. I'd say the space after "Vector" should be >> removed. >> >>> There are also lines in this file with only the declaration: >>> >>> 127: private Set> providers = null; >>> 499: providers = new HashSet> (3); >>> 663: for (Pair provider: providers) { >> >> These cases aren't as clear-cut. Sure, maybe there shouldn't be a space >> before the '<' but if there's a space after the comma (see below) then >> it makes things confusing. >> >>>> For their webrevs both Sean and Brad had asked me to tweak whitespace >>>> after the comma in the list of generic type arguments. For example, like >>>> the following: >>>> >>>> Map ===> Map >>>> >>>> However, I did *not* make such changes in this webrev. I didn't know >>>> whether you would have wanted such changes; there are rather a lot of >>>> them to change, and it's also not clear to me whether it actually would >>>> have improved the consistency of the spacing in this section of code. >>>> But, let me know if you'd like me to adjust this whitespace as well. >>> >>> My style was no whitespace after "," but probably it's not good. Now I >>> think >>> is OK but is better. Page 130 of "Effective >>> Java 2nd >>> version" seems to support this. >> >> Yeah, no space after the comma for cases like this >> >> Map >> >> seem reasonable, but space after comma for cases like this >> >> Map >> >> also seems reasonable. But what about more complex generic types? This >> code unfortunately has a lot of them. Like the examples you cite above, >> which is better? This >> >> HashSet> >> >> or >> >> HashSet> >> >> or even >> >> HashSet> >> >> ? Actually there are even more complex cases such as this one from >> src/share/classes/sun/security/krb5/Config.java: >> >> Hashtable>> temp = ... >> >> Where should the spaces go in that? I'm not sure.... >> >>> Since this code change is about coinification, I really don't care about >>> whitespace styles here. >> >> Yeah the whitespace is basically a distraction from coinification. >> >> I'm inclined to do the following: >> >> - use diamond in the return statement discussed above >> - remove whitespace from "Vector " >> - leave whitespace in complex generic types alone >> >> but I'm happy to do otherwise on these if you prefer, or to make other >> changes you might suggest. >> >> Thanks. >> >> s'marks >> >>> >>> Thanks >>> Max >>> >>>> >>>> Here's a link to the updated webrev. >>>> >>>> http://cr.openjdk.java.net/~smarks/reviews/7008713/webrev.1/ >>>> >>>> Thanks! >>>> >>>> s'marks From stuart.marks at oracle.com Wed Jan 12 14:08:54 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Wed, 12 Jan 2011 22:08:54 +0000 Subject: hg: jdk7/tl/jdk: 7008713: diamond conversion of kerberos5 and security tools Message-ID: <20110112220904.CB17C47BC6@hg.openjdk.java.net> Changeset: a5a22f93e4c5 Author: smarks Date: 2011-01-12 13:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a5a22f93e4c5 7008713: diamond conversion of kerberos5 and security tools Reviewed-by: weijun ! src/share/classes/sun/security/krb5/Config.java ! src/share/classes/sun/security/krb5/KdcComm.java ! src/share/classes/sun/security/krb5/PrincipalName.java ! src/share/classes/sun/security/krb5/Realm.java ! src/share/classes/sun/security/krb5/internal/Authenticator.java ! src/share/classes/sun/security/krb5/internal/AuthorizationData.java ! src/share/classes/sun/security/krb5/internal/EncAPRepPart.java ! src/share/classes/sun/security/krb5/internal/HostAddresses.java ! src/share/classes/sun/security/krb5/internal/KDCReq.java ! src/share/classes/sun/security/krb5/internal/KDCReqBody.java ! src/share/classes/sun/security/krb5/internal/KRBCred.java ! src/share/classes/sun/security/krb5/internal/KRBError.java ! src/share/classes/sun/security/krb5/internal/KrbCredInfo.java ! src/share/classes/sun/security/krb5/internal/LastReq.java ! src/share/classes/sun/security/krb5/internal/ccache/FileCredentialsCache.java ! src/share/classes/sun/security/krb5/internal/crypto/EType.java ! src/share/classes/sun/security/krb5/internal/ktab/KeyTab.java ! src/share/classes/sun/security/tools/JarSigner.java ! src/share/classes/sun/security/tools/KeyTool.java ! src/share/classes/sun/security/tools/policytool/PolicyTool.java ! test/sun/security/krb5/IPv6.java ! test/sun/security/krb5/auto/CleanState.java ! test/sun/security/krb5/auto/Context.java ! test/sun/security/krb5/auto/HttpNegotiateServer.java ! test/sun/security/krb5/auto/KDC.java ! test/sun/security/krb5/auto/LoginModuleOptions.java ! test/sun/security/krb5/tools/KtabCheck.java From stuart.marks at oracle.com Wed Jan 12 17:30:39 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Wed, 12 Jan 2011 17:30:39 -0800 Subject: review request for 7011998: diamond conversion for jgss and pkcs11 Message-ID: <4D2E55BF.6080106@oracle.com> Hi Valerie, You're up next for diamond conversion. :-) These should be pretty straightforward. Almost all changes are variable initializations. There's one return statement, one use of diamond in a ternary operator (a ? b : c), and one whitespace fixup. Webrev is here: http://cr.openjdk.java.net/~smarks/reviews/7011998/webrev.0/ Thanks! s'marks From stuart.marks at oracle.com Wed Jan 12 17:45:35 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Wed, 12 Jan 2011 17:45:35 -0800 Subject: review request for 7012003: diamond conversion for ssl Message-ID: <4D2E593F.8030208@oracle.com> Hi Andrew, Here's another round of diamond conversion changes, this time for ssl. This changeset is also pretty straightforward: all diamonds are in declarations with the exception of one return statement. Here's the webrev: http://cr.openjdk.java.net/~smarks/reviews/7012003/webrev.0/ Thanks! s'marks From valerie.peng at oracle.com Wed Jan 12 19:06:02 2011 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Wed, 12 Jan 2011 19:06:02 -0800 Subject: review request for 7011998: diamond conversion for jgss and pkcs11 In-Reply-To: <4D2E55BF.6080106@oracle.com> References: <4D2E55BF.6080106@oracle.com> Message-ID: <4D2E6C1A.1050102@oracle.com> The changes look good to me. BTW, I recall seeing in one of your earlier email that the byte code is the same w/ the usage of this diamond operator. Is this so? If not, then we need to update the sunpkcs11.jar also. Thanks, Valerie On 01/12/11 05:30 PM, Stuart Marks wrote: > Hi Valerie, > > You're up next for diamond conversion. :-) > > These should be pretty straightforward. Almost all changes are > variable initializations. There's one return statement, one use of > diamond in a ternary operator (a ? b : c), and one whitespace fixup. > > Webrev is here: > > http://cr.openjdk.java.net/~smarks/reviews/7011998/webrev.0/ > > Thanks! > > s'marks From keith.mcguigan at oracle.com Wed Jan 12 20:14:33 2011 From: keith.mcguigan at oracle.com (keith.mcguigan at oracle.com) Date: Thu, 13 Jan 2011 04:14:33 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110113041515.C12E747BD8@hg.openjdk.java.net> Changeset: f5c0b3cbee2f Author: kamg Date: 2011-01-12 11:47 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f5c0b3cbee2f 6436034: Instance filter doesn't filter event if it occurs in native method Summary: Use 'GetLocalInstance' JVMTI extension if it exists Reviewed-by: coleenp, dcubed ! src/share/back/debugInit.c ! src/share/back/eventFilter.c ! src/share/instrument/JPLISAgent.c ! src/share/javavm/export/jvmti.h + test/com/sun/jdi/NativeInstanceFilter.java + test/com/sun/jdi/NativeInstanceFilterTarg.java Changeset: 295f6b861c12 Author: kamg Date: 2011-01-12 15:27 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/295f6b861c12 Merge From bradford.wetmore at oracle.com Wed Jan 12 21:52:25 2011 From: bradford.wetmore at oracle.com (Bradford Wetmore) Date: Wed, 12 Jan 2011 21:52:25 -0800 Subject: review request for 7012003: diamond conversion for ssl In-Reply-To: <4D2E593F.8030208@oracle.com> References: <4D2E593F.8030208@oracle.com> Message-ID: <4D2E9319.8000908@oracle.com> Looks fine to me. Andrew can also review if you like. Brad On 1/12/2011 5:45 PM, Stuart Marks wrote: > Hi Andrew, > > Here's another round of diamond conversion changes, this time for ssl. > This changeset is also pretty straightforward: all diamonds are in > declarations with the exception of one return statement. > > Here's the webrev: > > http://cr.openjdk.java.net/~smarks/reviews/7012003/webrev.0/ > > Thanks! > > s'marks From xuelei.fan at oracle.com Thu Jan 13 01:48:49 2011 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Thu, 13 Jan 2011 17:48:49 +0800 Subject: review request for 7012003: diamond conversion for ssl In-Reply-To: <4D2E9319.8000908@oracle.com> References: <4D2E593F.8030208@oracle.com> <4D2E9319.8000908@oracle.com> Message-ID: <4D2ECA81.7070307@oracle.com> Thank you very much for the review, Brad. Stuart, please go ahead with update. I'm swamped by other priorities, as Brad has reviewed the update, I will not review it any more. Thanks, Andrew On 1/13/2011 1:52 PM, Bradford Wetmore wrote: > Looks fine to me. Andrew can also review if you like. > > Brad > > > On 1/12/2011 5:45 PM, Stuart Marks wrote: >> Hi Andrew, >> >> Here's another round of diamond conversion changes, this time for ssl. >> This changeset is also pretty straightforward: all diamonds are in >> declarations with the exception of one return statement. >> >> Here's the webrev: >> >> http://cr.openjdk.java.net/~smarks/reviews/7012003/webrev.0/ >> >> Thanks! >> >> s'marks From michael.x.mcmahon at oracle.com Thu Jan 13 03:04:15 2011 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Thu, 13 Jan 2011 11:04:15 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110113110446.11CD447BE8@hg.openjdk.java.net> Changeset: 538f913777cf Author: michaelm Date: 2011-01-13 11:01 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/538f913777cf 6896088: URLClassLoader.close() apparently not working for JAR URLs on Windows Reviewed-by: chegar ! src/share/classes/sun/misc/URLClassPath.java + test/java/net/URLClassLoader/B6896088.java Changeset: 9f265d55c1c4 Author: michaelm Date: 2011-01-13 11:02 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9f265d55c1c4 Merge From xuelei.fan at oracle.com Thu Jan 13 03:38:37 2011 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Thu, 13 Jan 2011 19:38:37 +0800 Subject: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm Message-ID: <4D2EE43D.4050508@oracle.com> Hi Sean, Would you please review the fix for CR 7011497? http://cr.openjdk.java.net/~xuelei/7011497/webrev/ Thanks, Xuelei From chris.hegarty at oracle.com Thu Jan 13 05:30:26 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 13 Jan 2011 13:30:26 +0000 Subject: hg: jdk7/tl/jdk: 6964547: Impossible to set useV4 in SocksSocketImpl Message-ID: <20110113133042.D42E447BF0@hg.openjdk.java.net> Changeset: 694951adefec Author: chegar Date: 2011-01-13 13:24 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/694951adefec 6964547: Impossible to set useV4 in SocksSocketImpl Summary: Add socksProxyVersion property Reviewed-by: alanb, michaelm ! make/sun/net/FILES_java.gmk ! src/share/classes/java/io/PrintStream.java ! src/share/classes/java/net/SocksSocketImpl.java ! src/share/classes/java/net/doc-files/net-properties.html + src/share/classes/sun/net/SocksProxy.java ! src/share/classes/sun/net/spi/DefaultProxySelector.java + test/java/net/Socks/SocksProxyVersion.java From michael.x.mcmahon at oracle.com Thu Jan 13 06:42:22 2011 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Thu, 13 Jan 2011 14:42:22 +0000 Subject: hg: jdk7/tl/jdk: 3 new changesets Message-ID: <20110113144251.51A3C47BF3@hg.openjdk.java.net> Changeset: 38729ba6eb4f Author: michaelm Date: 2011-01-12 15:05 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/38729ba6eb4f 6829919: URLClassLoader.close() doesn't close resource file if getResourceAsStream(...) was called before Reviewed-by: chegar ! src/share/classes/java/net/URLClassLoader.java ! test/java/net/URLClassLoader/closetest/CloseTest.java + test/java/net/URLClassLoader/closetest/Common.java + test/java/net/URLClassLoader/closetest/GetResourceAsStream.java + test/java/net/URLClassLoader/closetest/build2.sh Changeset: ed390b2e5ca4 Author: michaelm Date: 2011-01-13 11:10 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ed390b2e5ca4 Merge Changeset: 067b5f603fc8 Author: michaelm Date: 2011-01-13 14:41 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/067b5f603fc8 Merge From sean.mullan at oracle.com Thu Jan 13 08:05:09 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 13 Jan 2011 11:05:09 -0500 Subject: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm In-Reply-To: <4D2EE43D.4050508@oracle.com> References: <4D2EE43D.4050508@oracle.com> Message-ID: <4D2F22B5.2020103@oracle.com> On 1/13/11 6:38 AM, Xuelei Fan wrote: > Hi Sean, > > Would you please review the fix for CR 7011497? > > http://cr.openjdk.java.net/~xuelei/7011497/webrev/ > > Thanks, > Xuelei CPValidatorEndEntity.java: 307 /* coment out useless trust anchor 308 is = new ByteArrayInputStream(trustAnchor_SHA1withRSA_512.getBytes()); 309 cert = cf.generateCertificate(is); 310 anchor = new TrustAnchor((X509Certificate)cert, null); 311 anchors.add(anchor); 312 */ Why do you leave this code in with this comment? Otherwise, looks good. --Sean From xuelei.fan at oracle.com Thu Jan 13 08:27:51 2011 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Fri, 14 Jan 2011 00:27:51 +0800 Subject: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm In-Reply-To: <4D2F22B5.2020103@oracle.com> References: <4D2EE43D.4050508@oracle.com> <4D2F22B5.2020103@oracle.com> Message-ID: <4D2F2807.4050908@oracle.com> On 1/14/2011 12:05 AM, Sean Mullan wrote: > On 1/13/11 6:38 AM, Xuelei Fan wrote: >> Hi Sean, >> >> Would you please review the fix for CR 7011497? >> >> http://cr.openjdk.java.net/~xuelei/7011497/webrev/ >> >> Thanks, >> Xuelei > > CPValidatorEndEntity.java: > > 307 /* coment out useless trust anchor > 308 is = new > ByteArrayInputStream(trustAnchor_SHA1withRSA_512.getBytes()); > 309 cert = cf.generateCertificate(is); > 310 anchor = new TrustAnchor((X509Certificate)cert, null); > 311 anchors.add(anchor); > 312 */ > > Why do you leave this code in with this comment? > If I have this block. The cert path validation cannot find the proper trust anchor. As there are two trusted certificates, they are almost the same except the key size (one key size is 1024, another one is 512). In cert path validation, once a trust anchor found, if the signature is not valid, I think no more effort to test more trust anchors. I was wondering whether it is worthy to try more trust anchors. It's expensive! Thanks for the review. Xuelei > Otherwise, looks good. > > --Sean From michael.x.mcmahon at oracle.com Thu Jan 13 08:37:49 2011 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Thu, 13 Jan 2011 16:37:49 +0000 Subject: hg: jdk7/tl/jdk: 7003398: NetworkInterface equals() and hashCode() behaviors depend on permissions granted Message-ID: <20110113163759.376EC47BF8@hg.openjdk.java.net> Changeset: 3215b22cd90e Author: michaelm Date: 2011-01-13 16:33 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3215b22cd90e 7003398: NetworkInterface equals() and hashCode() behaviors depend on permissions granted Reviewed-by: chegar, alanb ! src/share/classes/java/net/NetworkInterface.java + test/java/net/NetworkInterface/Equals.java From jonathan.gibbons at oracle.com Thu Jan 13 11:48:42 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 13 Jan 2011 19:48:42 +0000 Subject: hg: jdk7/tl/langtools: 6430241: Hard to disable symbol file feature through API Message-ID: <20110113194846.097C147C06@hg.openjdk.java.net> Changeset: d33d8c381aa1 Author: jjg Date: 2011-01-13 11:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d33d8c381aa1 6430241: Hard to disable symbol file feature through API Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/Paths.java + test/tools/javac/api/T6430241.java From stuart.marks at oracle.com Thu Jan 13 16:08:17 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Thu, 13 Jan 2011 16:08:17 -0800 Subject: review request for 7012003: diamond conversion for ssl In-Reply-To: <4D2ECA81.7070307@oracle.com> References: <4D2E593F.8030208@oracle.com> <4D2E9319.8000908@oracle.com> <4D2ECA81.7070307@oracle.com> Message-ID: <4D2F93F1.8040801@oracle.com> OK guys, thanks for taking a look. I'll proceed with the push. s'marks On 1/13/11 1:48 AM, Xuelei Fan wrote: > Thank you very much for the review, Brad. > > Stuart, please go ahead with update. I'm swamped by other priorities, as > Brad has reviewed the update, I will not review it any more. > > Thanks, > Andrew > > On 1/13/2011 1:52 PM, Bradford Wetmore wrote: >> Looks fine to me. Andrew can also review if you like. >> >> Brad >> >> >> On 1/12/2011 5:45 PM, Stuart Marks wrote: >>> Hi Andrew, >>> >>> Here's another round of diamond conversion changes, this time for ssl. >>> This changeset is also pretty straightforward: all diamonds are in >>> declarations with the exception of one return statement. >>> >>> Here's the webrev: >>> >>> http://cr.openjdk.java.net/~smarks/reviews/7012003/webrev.0/ >>> >>> Thanks! >>> >>> s'marks > From stuart.marks at oracle.com Thu Jan 13 16:15:14 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Thu, 13 Jan 2011 16:15:14 -0800 Subject: review request for 7011998: diamond conversion for jgss and pkcs11 In-Reply-To: <4D2E6C1A.1050102@oracle.com> References: <4D2E55BF.6080106@oracle.com> <4D2E6C1A.1050102@oracle.com> Message-ID: <4D2F9592.1060504@oracle.com> Yes, the byte codes are identical. I compiled with -g:none before and after the changes and the classfiles are all identical. (Even though the bytecodes are identical, the classfiles would differ because of changed line number information, which is disabled with -g:none.) So, I assume this means that sunpkcs11.jar doesn't need to be updated, and that I can push this changeset without further changes? s'marks On 1/12/11 7:06 PM, Valerie (Yu-Ching) Peng wrote: > > The changes look good to me. > BTW, I recall seeing in one of your earlier email that the byte code is the > same w/ the usage of this diamond operator. Is this so? > If not, then we need to update the sunpkcs11.jar also. > Thanks, > Valerie > > On 01/12/11 05:30 PM, Stuart Marks wrote: >> Hi Valerie, >> >> You're up next for diamond conversion. :-) >> >> These should be pretty straightforward. Almost all changes are variable >> initializations. There's one return statement, one use of diamond in a >> ternary operator (a ? b : c), and one whitespace fixup. >> >> Webrev is here: >> >> http://cr.openjdk.java.net/~smarks/reviews/7011998/webrev.0/ >> >> Thanks! >> >> s'marks > From valerie.peng at oracle.com Thu Jan 13 16:41:37 2011 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Thu, 13 Jan 2011 16:41:37 -0800 Subject: review request for 7011998: diamond conversion for jgss and pkcs11 In-Reply-To: <4D2F9592.1060504@oracle.com> References: <4D2E55BF.6080106@oracle.com> <4D2E6C1A.1050102@oracle.com> <4D2F9592.1060504@oracle.com> Message-ID: <4D2F9BC1.8040206@oracle.com> Which particular class did you compared? Just to double check... Thanks, Valerie On 01/13/11 04:15 PM, Stuart Marks wrote: > Yes, the byte codes are identical. I compiled with -g:none before and > after the changes and the classfiles are all identical. (Even though > the bytecodes are identical, the classfiles would differ because of > changed line number information, which is disabled with -g:none.) > > So, I assume this means that sunpkcs11.jar doesn't need to be updated, > and that I can push this changeset without further changes? > > s'marks > > On 1/12/11 7:06 PM, Valerie (Yu-Ching) Peng wrote: >> >> The changes look good to me. >> BTW, I recall seeing in one of your earlier email that the byte code >> is the >> same w/ the usage of this diamond operator. Is this so? >> If not, then we need to update the sunpkcs11.jar also. >> Thanks, >> Valerie >> >> On 01/12/11 05:30 PM, Stuart Marks wrote: >>> Hi Valerie, >>> >>> You're up next for diamond conversion. :-) >>> >>> These should be pretty straightforward. Almost all changes are variable >>> initializations. There's one return statement, one use of diamond in a >>> ternary operator (a ? b : c), and one whitespace fixup. >>> >>> Webrev is here: >>> >>> http://cr.openjdk.java.net/~smarks/reviews/7011998/webrev.0/ >>> >>> Thanks! >>> >>> s'marks >> From weijun.wang at oracle.com Thu Jan 13 16:50:44 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 14 Jan 2011 08:50:44 +0800 Subject: review request for 7011998: diamond conversion for jgss and pkcs11 In-Reply-To: <4D2F9592.1060504@oracle.com> References: <4D2E55BF.6080106@oracle.com> <4D2E6C1A.1050102@oracle.com> <4D2F9592.1060504@oracle.com> Message-ID: <4D2F9DE4.2010409@oracle.com> If sunpkcs11.jar includes line number info (which I think yes), then it needs to be updated. Otherwise, line numbers shown in the exception stack info will not match the source code. Max On 01/14/2011 08:15 AM, Stuart Marks wrote: > Yes, the byte codes are identical. I compiled with -g:none before and > after the changes and the classfiles are all identical. (Even though the > bytecodes are identical, the classfiles would differ because of changed > line number information, which is disabled with -g:none.) > > So, I assume this means that sunpkcs11.jar doesn't need to be updated, > and that I can push this changeset without further changes? > > s'marks > > On 1/12/11 7:06 PM, Valerie (Yu-Ching) Peng wrote: >> >> The changes look good to me. >> BTW, I recall seeing in one of your earlier email that the byte code >> is the >> same w/ the usage of this diamond operator. Is this so? >> If not, then we need to update the sunpkcs11.jar also. >> Thanks, >> Valerie >> >> On 01/12/11 05:30 PM, Stuart Marks wrote: >>> Hi Valerie, >>> >>> You're up next for diamond conversion. :-) >>> >>> These should be pretty straightforward. Almost all changes are variable >>> initializations. There's one return statement, one use of diamond in a >>> ternary operator (a ? b : c), and one whitespace fixup. >>> >>> Webrev is here: >>> >>> http://cr.openjdk.java.net/~smarks/reviews/7011998/webrev.0/ >>> >>> Thanks! >>> >>> s'marks >> From stuart.marks at oracle.com Thu Jan 13 19:02:31 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Thu, 13 Jan 2011 19:02:31 -0800 Subject: review request for 7011998: diamond conversion for jgss and pkcs11 In-Reply-To: <4D2F9BC1.8040206@oracle.com> References: <4D2E55BF.6080106@oracle.com> <4D2E6C1A.1050102@oracle.com> <4D2F9592.1060504@oracle.com> <4D2F9BC1.8040206@oracle.com> Message-ID: <4D2FBCC7.60009@oracle.com> I did full clean builds of the JDK repo with -g:none, both with and without the diamond changes. I then compared all of the .class files in the two builds using the "cmp" command. The files were all identical, with the exception of two version classes which I think are auto-generated with date stamps or something. In any case all of the .class files corresponding to .java files in my changeset were byte-for-byte identical. s'marks On 1/13/11 4:41 PM, Valerie (Yu-Ching) Peng wrote: > > Which particular class did you compared? Just to double check... > Thanks, > Valerie > > On 01/13/11 04:15 PM, Stuart Marks wrote: >> Yes, the byte codes are identical. I compiled with -g:none before and after >> the changes and the classfiles are all identical. (Even though the bytecodes >> are identical, the classfiles would differ because of changed line number >> information, which is disabled with -g:none.) >> >> So, I assume this means that sunpkcs11.jar doesn't need to be updated, and >> that I can push this changeset without further changes? >> >> s'marks >> >> On 1/12/11 7:06 PM, Valerie (Yu-Ching) Peng wrote: >>> >>> The changes look good to me. >>> BTW, I recall seeing in one of your earlier email that the byte code is the >>> same w/ the usage of this diamond operator. Is this so? >>> If not, then we need to update the sunpkcs11.jar also. >>> Thanks, >>> Valerie >>> >>> On 01/12/11 05:30 PM, Stuart Marks wrote: >>>> Hi Valerie, >>>> >>>> You're up next for diamond conversion. :-) >>>> >>>> These should be pretty straightforward. Almost all changes are variable >>>> initializations. There's one return statement, one use of diamond in a >>>> ternary operator (a ? b : c), and one whitespace fixup. >>>> >>>> Webrev is here: >>>> >>>> http://cr.openjdk.java.net/~smarks/reviews/7011998/webrev.0/ >>>> >>>> Thanks! >>>> >>>> s'marks >>> > From stuart.marks at oracle.com Thu Jan 13 19:06:13 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Thu, 13 Jan 2011 19:06:13 -0800 Subject: review request for 7011998: diamond conversion for jgss and pkcs11 In-Reply-To: <4D2F9DE4.2010409@oracle.com> References: <4D2E55BF.6080106@oracle.com> <4D2E6C1A.1050102@oracle.com> <4D2F9592.1060504@oracle.com> <4D2F9DE4.2010409@oracle.com> Message-ID: <4D2FBDA5.1060209@oracle.com> Is there something in the source tree that needs to be modified so that sunpkcs11.jar gets updated properly? I see this file in my build output area: build/linux-i586/lib/ext/sunpkcs11.jar but I presume this is created automatically by the build process, from .class files that are built from source. If not, can you (or someone) direct me as to what additional changes might be necessary? s'marks On 1/13/11 4:50 PM, Weijun Wang wrote: > If sunpkcs11.jar includes line number info (which I think yes), then it needs > to be updated. Otherwise, line numbers shown in the exception stack info will > not match the source code. > > Max > > On 01/14/2011 08:15 AM, Stuart Marks wrote: >> Yes, the byte codes are identical. I compiled with -g:none before and >> after the changes and the classfiles are all identical. (Even though the >> bytecodes are identical, the classfiles would differ because of changed >> line number information, which is disabled with -g:none.) >> >> So, I assume this means that sunpkcs11.jar doesn't need to be updated, >> and that I can push this changeset without further changes? >> >> s'marks >> >> On 1/12/11 7:06 PM, Valerie (Yu-Ching) Peng wrote: >>> >>> The changes look good to me. >>> BTW, I recall seeing in one of your earlier email that the byte code >>> is the >>> same w/ the usage of this diamond operator. Is this so? >>> If not, then we need to update the sunpkcs11.jar also. >>> Thanks, >>> Valerie >>> >>> On 01/12/11 05:30 PM, Stuart Marks wrote: >>>> Hi Valerie, >>>> >>>> You're up next for diamond conversion. :-) >>>> >>>> These should be pretty straightforward. Almost all changes are variable >>>> initializations. There's one return statement, one use of diamond in a >>>> ternary operator (a ? b : c), and one whitespace fixup. >>>> >>>> Webrev is here: >>>> >>>> http://cr.openjdk.java.net/~smarks/reviews/7011998/webrev.0/ >>>> >>>> Thanks! >>>> >>>> s'marks >>> From xuelei.fan at oracle.com Thu Jan 13 19:10:49 2011 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Fri, 14 Jan 2011 11:10:49 +0800 Subject: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm In-Reply-To: <4D2F2BF2.6030207@oracle.com> References: <4D2EE43D.4050508@oracle.com> <4D2F22B5.2020103@oracle.com> <4D2F2807.4050908@oracle.com> <4D2F2BF2.6030207@oracle.com> Message-ID: <4D2FBEB9.9020103@oracle.com> We don't checking the SKID and AKID during searching for the trust anchor. I have filled a new CR for the issue, 7012357, Improve trust anchor searching method during cert path validation. I will have this commented out block in CPValidatorEndEntity.java. I will use this test case for CR 7012357. Thanks, Xuelei On 1/14/2011 12:44 AM, Xuelei Fan wrote: > I just realized, if subject KID and issuer KID works, the cert path > validation should be able to find the proper trust anchor. I will look > into the issue tomorrow. > > Xuelei > > On 1/14/2011 12:27 AM, Xuelei Fan wrote: >> On 1/14/2011 12:05 AM, Sean Mullan wrote: >>> On 1/13/11 6:38 AM, Xuelei Fan wrote: >>>> Hi Sean, >>>> >>>> Would you please review the fix for CR 7011497? >>>> >>>> http://cr.openjdk.java.net/~xuelei/7011497/webrev/ >>>> >>>> Thanks, >>>> Xuelei >>> >>> CPValidatorEndEntity.java: >>> >>> 307 /* coment out useless trust anchor >>> 308 is = new >>> ByteArrayInputStream(trustAnchor_SHA1withRSA_512.getBytes()); >>> 309 cert = cf.generateCertificate(is); >>> 310 anchor = new TrustAnchor((X509Certificate)cert, null); >>> 311 anchors.add(anchor); >>> 312 */ >>> >>> Why do you leave this code in with this comment? >>> >> If I have this block. The cert path validation cannot find the proper >> trust anchor. As there are two trusted certificates, they are almost the >> same except the key size (one key size is 1024, another one is 512). >> >> In cert path validation, once a trust anchor found, if the signature is >> not valid, I think no more effort to test more trust anchors. >> >> I was wondering whether it is worthy to try more trust anchors. It's >> expensive! >> >> Thanks for the review. >> >> Xuelei >> >>> Otherwise, looks good. >>> >>> --Sean >> > From xuelei.fan at oracle.com Thu Jan 13 19:15:37 2011 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Fri, 14 Jan 2011 11:15:37 +0800 Subject: review request for 7011998: diamond conversion for jgss and pkcs11 In-Reply-To: <4D2FBCC7.60009@oracle.com> References: <4D2E55BF.6080106@oracle.com> <4D2E6C1A.1050102@oracle.com> <4D2F9592.1060504@oracle.com> <4D2F9BC1.8040206@oracle.com> <4D2FBCC7.60009@oracle.com> Message-ID: <4D2FBFD9.6020406@oracle.com> Sorry, I did not look into this too much. I have a question about the diamond conversion. Why we want to make the change like the following code? What's the benefits? private final static Map availableCache = - new HashMap(8); + new HashMap<>(8); Thanks, Andrew On 1/14/2011 11:02 AM, Stuart Marks wrote: > I did full clean builds of the JDK repo with -g:none, both with and > without the diamond changes. I then compared all of the .class files in > the two builds using the "cmp" command. The files were all identical, > with the exception of two version classes which I think are > auto-generated with date stamps or something. In any case all of the > .class files corresponding to .java files in my changeset were > byte-for-byte identical. > > s'marks > > On 1/13/11 4:41 PM, Valerie (Yu-Ching) Peng wrote: >> >> Which particular class did you compared? Just to double check... >> Thanks, >> Valerie >> >> On 01/13/11 04:15 PM, Stuart Marks wrote: >>> Yes, the byte codes are identical. I compiled with -g:none before and >>> after >>> the changes and the classfiles are all identical. (Even though the >>> bytecodes >>> are identical, the classfiles would differ because of changed line >>> number >>> information, which is disabled with -g:none.) >>> >>> So, I assume this means that sunpkcs11.jar doesn't need to be >>> updated, and >>> that I can push this changeset without further changes? >>> >>> s'marks >>> >>> On 1/12/11 7:06 PM, Valerie (Yu-Ching) Peng wrote: >>>> >>>> The changes look good to me. >>>> BTW, I recall seeing in one of your earlier email that the byte code >>>> is the >>>> same w/ the usage of this diamond operator. Is this so? >>>> If not, then we need to update the sunpkcs11.jar also. >>>> Thanks, >>>> Valerie >>>> >>>> On 01/12/11 05:30 PM, Stuart Marks wrote: >>>>> Hi Valerie, >>>>> >>>>> You're up next for diamond conversion. :-) >>>>> >>>>> These should be pretty straightforward. Almost all changes are >>>>> variable >>>>> initializations. There's one return statement, one use of diamond in a >>>>> ternary operator (a ? b : c), and one whitespace fixup. >>>>> >>>>> Webrev is here: >>>>> >>>>> http://cr.openjdk.java.net/~smarks/reviews/7011998/webrev.0/ >>>>> >>>>> Thanks! >>>>> >>>>> s'marks >>>> >> From mike.duigou at oracle.com Thu Jan 13 20:33:04 2011 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Fri, 14 Jan 2011 04:33:04 +0000 Subject: hg: jdk7/tl/jdk: 6728865: Provide a better heuristics for Collections.disjoint method Message-ID: <20110114043327.CB14047C34@hg.openjdk.java.net> Changeset: 29f2e311cce7 Author: mduigou Date: 2011-01-13 20:32 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/29f2e311cce7 6728865: Provide a better heuristics for Collections.disjoint method Reviewed-by: alanb, dholmes, chegar, forax ! src/share/classes/java/util/Collections.java From bhavesh.patel at sun.com Thu Jan 13 21:31:47 2011 From: bhavesh.patel at sun.com (bhavesh.patel at sun.com) Date: Fri, 14 Jan 2011 05:31:47 +0000 Subject: hg: jdk7/tl/langtools: 7010528: javadoc performance regression Message-ID: <20110114053151.1E31C47C37@hg.openjdk.java.net> Changeset: a466f00c5cd2 Author: bpatel Date: 2011-01-13 21:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a466f00c5cd2 7010528: javadoc performance regression Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java From joe.darcy at oracle.com Thu Jan 13 22:22:37 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 14 Jan 2011 06:22:37 +0000 Subject: hg: jdk7/tl/jdk: 7012279: Project Coin: Clarify AutoCloseable and Throwable javadoc Message-ID: <20110114062253.F175A47C3A@hg.openjdk.java.net> Changeset: 59e352561146 Author: darcy Date: 2011-01-13 22:21 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/59e352561146 7012279: Project Coin: Clarify AutoCloseable and Throwable javadoc Reviewed-by: jjb ! src/share/classes/java/lang/AutoCloseable.java ! src/share/classes/java/lang/Throwable.java From stuart.marks at oracle.com Thu Jan 13 22:47:47 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Thu, 13 Jan 2011 22:47:47 -0800 Subject: review request for 7011998: diamond conversion for jgss and pkcs11 In-Reply-To: <4D2FBFD9.6020406@oracle.com> References: <4D2E55BF.6080106@oracle.com> <4D2E6C1A.1050102@oracle.com> <4D2F9592.1060504@oracle.com> <4D2F9BC1.8040206@oracle.com> <4D2FBCC7.60009@oracle.com> <4D2FBFD9.6020406@oracle.com> Message-ID: <4D2FF193.8070606@oracle.com> Diamond conversion doesn't do very much other than to make the code shorter, by removing redundancy. The meaning and function of the program aren't changed at all. Given a diamond, the compiler infers type arguments based on the context. In many cases where a variable is declared and initialized at the same location, the type arguments in the initializer are identical to those in the declaration. So, using diamond lets us get rid of a bit of noise. In the example you chose the benefit is fairly small. There are other cases where the benefit is greater, such as this one from src/share/classes/sun/security/pkcs11/SunPKCS11.java: - final Map supportedAlgs = - new HashMap(); + final Map supportedAlgs = new HashMap<>(); The shorter initializer lets us fold things back onto a single line. Not a really big deal, but a little nicer I think. s'marks On 1/13/11 7:15 PM, Xuelei Fan wrote: > Sorry, I did not look into this too much. I have a question about the > diamond conversion. Why we want to make the change like the following > code? What's the benefits? > > private final static Map availableCache = > - new HashMap(8); > + new HashMap<>(8); > > Thanks, > Andrew > > On 1/14/2011 11:02 AM, Stuart Marks wrote: >> I did full clean builds of the JDK repo with -g:none, both with and >> without the diamond changes. I then compared all of the .class files in >> the two builds using the "cmp" command. The files were all identical, >> with the exception of two version classes which I think are >> auto-generated with date stamps or something. In any case all of the >> .class files corresponding to .java files in my changeset were >> byte-for-byte identical. >> >> s'marks >> >> On 1/13/11 4:41 PM, Valerie (Yu-Ching) Peng wrote: >>> >>> Which particular class did you compared? Just to double check... >>> Thanks, >>> Valerie >>> >>> On 01/13/11 04:15 PM, Stuart Marks wrote: >>>> Yes, the byte codes are identical. I compiled with -g:none before and >>>> after >>>> the changes and the classfiles are all identical. (Even though the >>>> bytecodes >>>> are identical, the classfiles would differ because of changed line >>>> number >>>> information, which is disabled with -g:none.) >>>> >>>> So, I assume this means that sunpkcs11.jar doesn't need to be >>>> updated, and >>>> that I can push this changeset without further changes? >>>> >>>> s'marks >>>> >>>> On 1/12/11 7:06 PM, Valerie (Yu-Ching) Peng wrote: >>>>> >>>>> The changes look good to me. >>>>> BTW, I recall seeing in one of your earlier email that the byte code >>>>> is the >>>>> same w/ the usage of this diamond operator. Is this so? >>>>> If not, then we need to update the sunpkcs11.jar also. >>>>> Thanks, >>>>> Valerie >>>>> >>>>> On 01/12/11 05:30 PM, Stuart Marks wrote: >>>>>> Hi Valerie, >>>>>> >>>>>> You're up next for diamond conversion. :-) >>>>>> >>>>>> These should be pretty straightforward. Almost all changes are >>>>>> variable >>>>>> initializations. There's one return statement, one use of diamond in a >>>>>> ternary operator (a ? b : c), and one whitespace fixup. >>>>>> >>>>>> Webrev is here: >>>>>> >>>>>> http://cr.openjdk.java.net/~smarks/reviews/7011998/webrev.0/ >>>>>> >>>>>> Thanks! >>>>>> >>>>>> s'marks >>>>> >>> > From weijun.wang at oracle.com Fri Jan 14 00:31:34 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 14 Jan 2011 16:31:34 +0800 Subject: code review request: 7012160: read SF file in signed jar in streaming mode Message-ID: <4D3009E6.8020003@oracle.com> Hi Sean http://cr.openjdk.java.net/~weijun/7012160/webrev.00/ I've made changes to the following classes to enable streaming mode SF file reading: - java/util/jar/JarVerifier.java: 1. New verifyBlock method. 2. Change the constructor from JarVerifier(byte[]) to JarVerifier(byte[], Manifest). In SignatureFileVerifier.processImpl(), if we already confirm the *-Digest-Manifest header in the SF file matches the whole MANIFEST.MF, there'se no need to parse the rest of the SF file, since we can be sure that entries in the SF file are identical to those in MANIFEST.MF. Of course, the content of the SF file still needs to be fed into PKCS7Verifier to verify the signature. - java/util/jar/JarFile.java: Read DSA file in byte[] and SF file in InputStream, and call JarVerifier.verifyBlock() to verify. - java/util/jar/Manifest.java: Adding update(byte[]) to read manifest in streaming mode. This is a new public API. - sun/security/pkcs/PKCS7.java: New PKCS7Verifier class to verify SignedData in streaming mode. I basically divide the SignerInfo.verify(PKCS7 block, byte[] data) method into 3 parts and make them the 3 methods of this class. - sun/security/util/SignatureFileVerifier.java: Rewrite the processImpl(*) method to make use of new methods in PKCS7 and Manifest. No new regression tests, use existing ones. I've tried NetBeans profiler to look at the memory. The program simply calls JarSigner.main(new String[]{"-verify", "x.jar"}) and the signed jar x.jar has 10000 files inside. Before After byte[] 3.6MB 2.8MB char[] 2.0MB 1.3MB String 1.1MB 650KB So it does have some difference. Thanks Max -------- Original Message -------- *Change Request ID*: 7012160 *Synopsis*: read SF file in signed jar in streaming mode === *Description* ============================================================ When a signed jar is verified, its SF file is read into a byte array and verified against the signature. When there are many files in the jar, the SF file can be very big. It will be better if the file can be read in streaming mode. *** (#1 of 1): 2011-01-13 12:23:25 GMT+00:00 weijun.wang at oracle.com From xuelei.fan at oracle.com Fri Jan 14 00:38:56 2011 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Fri, 14 Jan 2011 16:38:56 +0800 Subject: review request for 7011998: diamond conversion for jgss and pkcs11 In-Reply-To: <4D2FF193.8070606@oracle.com> References: <4D2E55BF.6080106@oracle.com> <4D2E6C1A.1050102@oracle.com> <4D2F9592.1060504@oracle.com> <4D2F9BC1.8040206@oracle.com> <4D2FBCC7.60009@oracle.com> <4D2FBFD9.6020406@oracle.com> <4D2FF193.8070606@oracle.com> Message-ID: <4D300BA0.1090803@oracle.com> Get it! Thanks! Andrew On 1/14/2011 2:47 PM, Stuart Marks wrote: > Diamond conversion doesn't do very much other than to make the code > shorter, by removing redundancy. The meaning and function of the program > aren't changed at all. Given a diamond, the compiler infers type > arguments based on the context. In many cases where a variable is > declared and initialized at the same location, the type arguments in the > initializer are identical to those in the declaration. So, using diamond > lets us get rid of a bit of noise. > > In the example you chose the benefit is fairly small. There are other > cases where the benefit is greater, such as this one from > src/share/classes/sun/security/pkcs11/SunPKCS11.java: > > - final Map supportedAlgs = > - new HashMap(); > + final Map supportedAlgs = new HashMap<>(); > > The shorter initializer lets us fold things back onto a single line. Not > a really big deal, but a little nicer I think. > > s'marks > > > On 1/13/11 7:15 PM, Xuelei Fan wrote: >> Sorry, I did not look into this too much. I have a question about the >> diamond conversion. Why we want to make the change like the following >> code? What's the benefits? >> >> private final static Map availableCache = >> - new HashMap(8); >> + new HashMap<>(8); >> >> Thanks, >> Andrew >> >> On 1/14/2011 11:02 AM, Stuart Marks wrote: >>> I did full clean builds of the JDK repo with -g:none, both with and >>> without the diamond changes. I then compared all of the .class files in >>> the two builds using the "cmp" command. The files were all identical, >>> with the exception of two version classes which I think are >>> auto-generated with date stamps or something. In any case all of the >>> .class files corresponding to .java files in my changeset were >>> byte-for-byte identical. >>> >>> s'marks >>> >>> On 1/13/11 4:41 PM, Valerie (Yu-Ching) Peng wrote: >>>> >>>> Which particular class did you compared? Just to double check... >>>> Thanks, >>>> Valerie >>>> >>>> On 01/13/11 04:15 PM, Stuart Marks wrote: >>>>> Yes, the byte codes are identical. I compiled with -g:none before and >>>>> after >>>>> the changes and the classfiles are all identical. (Even though the >>>>> bytecodes >>>>> are identical, the classfiles would differ because of changed line >>>>> number >>>>> information, which is disabled with -g:none.) >>>>> >>>>> So, I assume this means that sunpkcs11.jar doesn't need to be >>>>> updated, and >>>>> that I can push this changeset without further changes? >>>>> >>>>> s'marks >>>>> >>>>> On 1/12/11 7:06 PM, Valerie (Yu-Ching) Peng wrote: >>>>>> >>>>>> The changes look good to me. >>>>>> BTW, I recall seeing in one of your earlier email that the byte code >>>>>> is the >>>>>> same w/ the usage of this diamond operator. Is this so? >>>>>> If not, then we need to update the sunpkcs11.jar also. >>>>>> Thanks, >>>>>> Valerie >>>>>> >>>>>> On 01/12/11 05:30 PM, Stuart Marks wrote: >>>>>>> Hi Valerie, >>>>>>> >>>>>>> You're up next for diamond conversion. :-) >>>>>>> >>>>>>> These should be pretty straightforward. Almost all changes are >>>>>>> variable >>>>>>> initializations. There's one return statement, one use of diamond >>>>>>> in a >>>>>>> ternary operator (a ? b : c), and one whitespace fixup. >>>>>>> >>>>>>> Webrev is here: >>>>>>> >>>>>>> http://cr.openjdk.java.net/~smarks/reviews/7011998/webrev.0/ >>>>>>> >>>>>>> Thanks! >>>>>>> >>>>>>> s'marks >>>>>> >>>> >> From maurizio.cimadamore at oracle.com Fri Jan 14 01:50:32 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Fri, 14 Jan 2011 09:50:32 +0000 Subject: hg: jdk7/tl/langtools: 3 new changesets Message-ID: <20110114095039.0B6DC47C43@hg.openjdk.java.net> Changeset: 2d5aff89aaa3 Author: mcimadamore Date: 2011-01-14 09:45 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2d5aff89aaa3 6992698: JSR 292: remove support for transient syntax in polymorphic signature calls Summary: special syntax to denote indy return type through type parameters should be removed (and cast shall be used instead) Reviewed-by: jjg, jrose ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Items.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/Names.java - test/tools/javac/diags/examples/TypeParameterOnPolymorphicSignature.java - test/tools/javac/meth/InvokeDynTrans.out - test/tools/javac/meth/InvokeMHTrans.java - test/tools/javac/meth/InvokeMHTrans.out ! test/tools/javac/meth/TestCP.java ! test/tools/javac/meth/XlintWarn.java Changeset: c8d312dd17bc Author: mcimadamore Date: 2011-01-14 09:45 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c8d312dd17bc 7007432: Test generic types well-formedness Summary: add a new kind of check (well-formedness of generic type w.r.t. declared bounds) in the type-harness Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/types/GenericTypeWellFormednessTest.java ! test/tools/javac/types/TypeHarness.java Changeset: 712be35e40b5 Author: mcimadamore Date: 2011-01-14 09:46 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/712be35e40b5 6949040: java.dyn package must be compiled with -target 7 or better Summary: issue error (rather than warning) when @PolymorphicSignature is found and target < 7 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/diags/examples.not-yet.txt From xuelei.fan at oracle.com Fri Jan 14 09:30:27 2011 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Sat, 15 Jan 2011 01:30:27 +0800 Subject: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm In-Reply-To: <4D2FBEB9.9020103@oracle.com> References: <4D2EE43D.4050508@oracle.com> <4D2F22B5.2020103@oracle.com> <4D2F2807.4050908@oracle.com> <4D2F2BF2.6030207@oracle.com> <4D2FBEB9.9020103@oracle.com> Message-ID: <4D308833.4030601@oracle.com> Hi Sean, webrev: Would you please review the update again. I integrate the fix for 7011497 and 7012357 together. Comparing with previous webrev, the following updates are unchanged: src/share/classes/java/security/cert/CertPathValidatorException.java src/share/classes/sun/security/provider/certpath/AlgorithmChecker.java src/share/classes/sun/security/validator/SimpleValidator.java other test files. The following are new changes for CR 7012357: src/share/classes/sun/security/provider/certpath/ForwardBuilder.java src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorEndEntity.java Thanks, Xuelei On 1/14/2011 11:10 AM, Xuelei Fan wrote: > We don't checking the SKID and AKID during searching for the trust anchor. > > I have filled a new CR for the issue, 7012357, Improve trust anchor > searching method during cert path validation. > > I will have this commented out block in CPValidatorEndEntity.java. I > will use this test case for CR 7012357. > > Thanks, > Xuelei > > On 1/14/2011 12:44 AM, Xuelei Fan wrote: >> I just realized, if subject KID and issuer KID works, the cert path >> validation should be able to find the proper trust anchor. I will look >> into the issue tomorrow. >> >> Xuelei >> >> On 1/14/2011 12:27 AM, Xuelei Fan wrote: >>> On 1/14/2011 12:05 AM, Sean Mullan wrote: >>>> On 1/13/11 6:38 AM, Xuelei Fan wrote: >>>>> Hi Sean, >>>>> >>>>> Would you please review the fix for CR 7011497? >>>>> >>>>> http://cr.openjdk.java.net/~xuelei/7011497/webrev/ >>>>> >>>>> Thanks, >>>>> Xuelei >>>> >>>> CPValidatorEndEntity.java: >>>> >>>> 307 /* coment out useless trust anchor >>>> 308 is = new >>>> ByteArrayInputStream(trustAnchor_SHA1withRSA_512.getBytes()); >>>> 309 cert = cf.generateCertificate(is); >>>> 310 anchor = new TrustAnchor((X509Certificate)cert, null); >>>> 311 anchors.add(anchor); >>>> 312 */ >>>> >>>> Why do you leave this code in with this comment? >>>> >>> If I have this block. The cert path validation cannot find the proper >>> trust anchor. As there are two trusted certificates, they are almost the >>> same except the key size (one key size is 1024, another one is 512). >>> >>> In cert path validation, once a trust anchor found, if the signature is >>> not valid, I think no more effort to test more trust anchors. >>> >>> I was wondering whether it is worthy to try more trust anchors. It's >>> expensive! >>> >>> Thanks for the review. >>> >>> Xuelei >>> >>>> Otherwise, looks good. >>>> >>>> --Sean >>> >> > From xuelei.fan at oracle.com Fri Jan 14 09:32:41 2011 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Sat, 15 Jan 2011 01:32:41 +0800 Subject: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm In-Reply-To: <4D308833.4030601@oracle.com> References: <4D2EE43D.4050508@oracle.com> <4D2F22B5.2020103@oracle.com> <4D2F2807.4050908@oracle.com> <4D2F2BF2.6030207@oracle.com> <4D2FBEB9.9020103@oracle.com> <4D308833.4030601@oracle.com> Message-ID: <4D3088B9.5010105@oracle.com> On 1/15/2011 1:30 AM, Xuelei Fan wrote: > Hi Sean, > > webrev: http://cr.openjdk.java.net/~xuelei/7011497/webrev/ > Would you please review the update again. I integrate the fix for > 7011497 and 7012357 together. > > Comparing with previous webrev, the following updates are unchanged: > src/share/classes/java/security/cert/CertPathValidatorException.java > src/share/classes/sun/security/provider/certpath/AlgorithmChecker.java > src/share/classes/sun/security/validator/SimpleValidator.java > other test files. > > > The following are new changes for CR 7012357: > src/share/classes/sun/security/provider/certpath/ForwardBuilder.java > src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java > test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorEndEntity.java > > > Thanks, > Xuelei > > On 1/14/2011 11:10 AM, Xuelei Fan wrote: >> We don't checking the SKID and AKID during searching for the trust anchor. >> >> I have filled a new CR for the issue, 7012357, Improve trust anchor >> searching method during cert path validation. >> >> I will have this commented out block in CPValidatorEndEntity.java. I >> will use this test case for CR 7012357. >> >> Thanks, >> Xuelei >> >> On 1/14/2011 12:44 AM, Xuelei Fan wrote: >>> I just realized, if subject KID and issuer KID works, the cert path >>> validation should be able to find the proper trust anchor. I will look >>> into the issue tomorrow. >>> >>> Xuelei >>> >>> On 1/14/2011 12:27 AM, Xuelei Fan wrote: >>>> On 1/14/2011 12:05 AM, Sean Mullan wrote: >>>>> On 1/13/11 6:38 AM, Xuelei Fan wrote: >>>>>> Hi Sean, >>>>>> >>>>>> Would you please review the fix for CR 7011497? >>>>>> >>>>>> http://cr.openjdk.java.net/~xuelei/7011497/webrev/ >>>>>> >>>>>> Thanks, >>>>>> Xuelei >>>>> >>>>> CPValidatorEndEntity.java: >>>>> >>>>> 307 /* coment out useless trust anchor >>>>> 308 is = new >>>>> ByteArrayInputStream(trustAnchor_SHA1withRSA_512.getBytes()); >>>>> 309 cert = cf.generateCertificate(is); >>>>> 310 anchor = new TrustAnchor((X509Certificate)cert, null); >>>>> 311 anchors.add(anchor); >>>>> 312 */ >>>>> >>>>> Why do you leave this code in with this comment? >>>>> >>>> If I have this block. The cert path validation cannot find the proper >>>> trust anchor. As there are two trusted certificates, they are almost the >>>> same except the key size (one key size is 1024, another one is 512). >>>> >>>> In cert path validation, once a trust anchor found, if the signature is >>>> not valid, I think no more effort to test more trust anchors. >>>> >>>> I was wondering whether it is worthy to try more trust anchors. It's >>>> expensive! >>>> >>>> Thanks for the review. >>>> >>>> Xuelei >>>> >>>>> Otherwise, looks good. >>>>> >>>>> --Sean >>>> >>> >> > From jonathan.gibbons at oracle.com Fri Jan 14 11:45:48 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 14 Jan 2011 19:45:48 +0000 Subject: hg: jdk7/tl/langtools: 6419926: JSR 199: FileObject.toUri() generates URI without schema (Solaris) Message-ID: <20110114194551.A7AFC47C62@hg.openjdk.java.net> Changeset: 7c7c1787fbbe Author: jjg Date: 2011-01-14 11:45 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7c7c1787fbbe 6419926: JSR 199: FileObject.toUri() generates URI without schema (Solaris) Reviewed-by: mcimadamore + test/tools/javac/api/T6419926.java From jonathan.gibbons at oracle.com Fri Jan 14 11:56:21 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 14 Jan 2011 19:56:21 +0000 Subject: hg: jdk7/tl/langtools: 6571165: Minor doc bugs in JavaCompiler.java Message-ID: <20110114195623.B939147C63@hg.openjdk.java.net> Changeset: 0a509c765657 Author: jjg Date: 2011-01-14 11:55 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/0a509c765657 6571165: Minor doc bugs in JavaCompiler.java Reviewed-by: mcimadamore ! src/share/classes/javax/tools/JavaCompiler.java From sean.mullan at oracle.com Fri Jan 14 13:37:54 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 14 Jan 2011 16:37:54 -0500 Subject: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm In-Reply-To: <4D3088B9.5010105@oracle.com> References: <4D2EE43D.4050508@oracle.com> <4D2F22B5.2020103@oracle.com> <4D2F2807.4050908@oracle.com> <4D2F2BF2.6030207@oracle.com> <4D2FBEB9.9020103@oracle.com> <4D308833.4030601@oracle.com> <4D3088B9.5010105@oracle.com> Message-ID: <4D30C232.4000802@oracle.com> Hi Andrew, Did you consider using the existing X509CertSelector class to match on the authority key identifier? I actually think this should work, and it will avoid having to create the AKIDMatchState class. Take a look at the ForwardBuilder.getMatchingCACerts method towards the end, where it gets the AuthorityKeyIdentifierExtension. Can you create a similar X509CertSelector to select the proper trust anchor? --Sean On 1/14/11 12:32 PM, Xuelei Fan wrote: > On 1/15/2011 1:30 AM, Xuelei Fan wrote: >> Hi Sean, >> >> webrev: > http://cr.openjdk.java.net/~xuelei/7011497/webrev/ > >> Would you please review the update again. I integrate the fix for >> 7011497 and 7012357 together. >> >> Comparing with previous webrev, the following updates are unchanged: >> src/share/classes/java/security/cert/CertPathValidatorException.java >> src/share/classes/sun/security/provider/certpath/AlgorithmChecker.java >> src/share/classes/sun/security/validator/SimpleValidator.java >> other test files. >> >> >> The following are new changes for CR 7012357: >> src/share/classes/sun/security/provider/certpath/ForwardBuilder.java >> src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java >> test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorEndEntity.java >> >> >> Thanks, >> Xuelei >> >> On 1/14/2011 11:10 AM, Xuelei Fan wrote: >>> We don't checking the SKID and AKID during searching for the trust anchor. >>> >>> I have filled a new CR for the issue, 7012357, Improve trust anchor >>> searching method during cert path validation. >>> >>> I will have this commented out block in CPValidatorEndEntity.java. I >>> will use this test case for CR 7012357. >>> >>> Thanks, >>> Xuelei >>> >>> On 1/14/2011 12:44 AM, Xuelei Fan wrote: >>>> I just realized, if subject KID and issuer KID works, the cert path >>>> validation should be able to find the proper trust anchor. I will look >>>> into the issue tomorrow. >>>> >>>> Xuelei >>>> >>>> On 1/14/2011 12:27 AM, Xuelei Fan wrote: >>>>> On 1/14/2011 12:05 AM, Sean Mullan wrote: >>>>>> On 1/13/11 6:38 AM, Xuelei Fan wrote: >>>>>>> Hi Sean, >>>>>>> >>>>>>> Would you please review the fix for CR 7011497? >>>>>>> >>>>>>> http://cr.openjdk.java.net/~xuelei/7011497/webrev/ >>>>>>> >>>>>>> Thanks, >>>>>>> Xuelei >>>>>> >>>>>> CPValidatorEndEntity.java: >>>>>> >>>>>> 307 /* coment out useless trust anchor >>>>>> 308 is = new >>>>>> ByteArrayInputStream(trustAnchor_SHA1withRSA_512.getBytes()); >>>>>> 309 cert = cf.generateCertificate(is); >>>>>> 310 anchor = new TrustAnchor((X509Certificate)cert, null); >>>>>> 311 anchors.add(anchor); >>>>>> 312 */ >>>>>> >>>>>> Why do you leave this code in with this comment? >>>>>> >>>>> If I have this block. The cert path validation cannot find the proper >>>>> trust anchor. As there are two trusted certificates, they are almost the >>>>> same except the key size (one key size is 1024, another one is 512). >>>>> >>>>> In cert path validation, once a trust anchor found, if the signature is >>>>> not valid, I think no more effort to test more trust anchors. >>>>> >>>>> I was wondering whether it is worthy to try more trust anchors. It's >>>>> expensive! >>>>> >>>>> Thanks for the review. >>>>> >>>>> Xuelei >>>>> >>>>>> Otherwise, looks good. >>>>>> >>>>>> --Sean >>>>> >>>> >>> >> > From kumar.x.srinivasan at oracle.com Fri Jan 14 13:59:59 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Fri, 14 Jan 2011 21:59:59 +0000 Subject: hg: jdk7/tl/langtools: 7011272: langtools build.xml should provide a patch target Message-ID: <20110114220003.1D22747C6B@hg.openjdk.java.net> Changeset: 19f9b6548c70 Author: ksrini Date: 2011-01-14 13:59 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/19f9b6548c70 7011272: langtools build.xml should provide a patch target Reviewed-by: jonathan, jjh ! make/build.xml From chris.hegarty at oracle.com Fri Jan 14 14:35:55 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 14 Jan 2011 22:35:55 +0000 Subject: hg: jdk7/tl/jdk: 7010903: impl. of http.maxConnections is different from the description in JavaSE document Message-ID: <20110114223617.9332B47C76@hg.openjdk.java.net> Changeset: 983364897f72 Author: chegar Date: 2011-01-14 22:34 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/983364897f72 7010903: impl. of http.maxConnections is different from the description in JavaSE document Reviewed-by: alanb, michaelm ! src/share/classes/sun/net/www/http/KeepAliveCache.java From stuart.marks at oracle.com Fri Jan 14 16:52:22 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Sat, 15 Jan 2011 00:52:22 +0000 Subject: hg: jdk7/tl/jdk: 7012003: diamond conversion for ssl Message-ID: <20110115005251.95E5947C8C@hg.openjdk.java.net> Changeset: d61d9bf190f5 Author: smarks Date: 2011-01-14 15:31 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d61d9bf190f5 7012003: diamond conversion for ssl Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/CipherSuiteList.java ! src/share/classes/sun/security/ssl/ClientHandshaker.java ! src/share/classes/sun/security/ssl/DefaultSSLContextImpl.java ! src/share/classes/sun/security/ssl/HandshakeMessage.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/HelloExtensions.java ! src/share/classes/sun/security/ssl/ProtocolList.java ! src/share/classes/sun/security/ssl/SSLAlgorithmConstraints.java ! src/share/classes/sun/security/ssl/SSLSessionImpl.java ! src/share/classes/sun/security/ssl/SignatureAndHashAlgorithm.java ! src/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java ! src/share/classes/sun/security/ssl/TrustManagerFactoryImpl.java ! src/share/classes/sun/security/ssl/X509KeyManagerImpl.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CookieHandlerTest.java From sundararajan.a at sun.com Sun Jan 16 23:59:49 2011 From: sundararajan.a at sun.com (sundararajan.a at sun.com) Date: Mon, 17 Jan 2011 07:59:49 +0000 Subject: hg: jdk7/tl/jdk: 6508943: small typo in the documentation; ... Message-ID: <20110117080018.EEC5747DCD@hg.openjdk.java.net> Changeset: 507627325c81 Author: sundar Date: 2011-01-17 13:29 +0530 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/507627325c81 6508943: small typo in the documentation 6759414: javascript engine can not write to StringWriter 6869617: RhinoScriptEngine bug : ScriptException cause not set (with fix) 7012701: Add a test to check that Rhino's RegExp parser accepts unescaped '[' Reviewed-by: alanb, jjh ! src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java ! src/share/classes/javax/script/CompiledScript.java + test/javax/script/CauseExceptionTest.java + test/javax/script/StringWriterPrintTest.java + test/javax/script/UnescapedBracketRegExTest.java From weijun.wang at oracle.com Mon Jan 17 00:59:04 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 17 Jan 2011 16:59:04 +0800 Subject: Request for Comment: adding chain info to keytool -list Message-ID: <4D3404D8.3020705@oracle.com> Hi All I have a keystore with a bunch of testing root CA, intermediate CA and entity certs, some PrivateKeyEntry and some TrustedCertEntry, and it's quite difficult to know who signs who. Therefore I suggest some enhancement for the simple "keytool -list". (by simple, I mean no "-v"). The entry will look like: user, Sep 6, 2007, PrivateKeyEntry, user - signer - rootca(self) Here, "user - signer - bigca(self)" means the entry's cert chain has 3 certs, which matches aliases user, signer, and rootca in the same keystore, and rootca is a self-signed cert. When a cert is not inside this keystore, its distinguished name can be printed, like this: user, Sep 6, 2007, PrivateKeyEntry, user - signer - "CN=Root CA"(self) Also, if the last cert is not self-signed, its signed can also be added after "--", like this: user, Sep 6, 2007, PrivateKeyEntry, user - signer -- "CN=Another CA"(self) Do you find this useful? Thanks Max From xuelei.fan at oracle.com Mon Jan 17 17:26:07 2011 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Tue, 18 Jan 2011 09:26:07 +0800 Subject: Request for Comment: adding chain info to keytool -list In-Reply-To: <4D3404D8.3020705@oracle.com> References: <4D3404D8.3020705@oracle.com> Message-ID: <4D34EC2F.5070306@oracle.com> I would like to see a option to display the intuitive tree. For example: $ keytool -list -tree -keystore ... + root CA alias + intermediate CA alias + entity cert 1 alias + entity cert 2 alias Andrew On 1/17/2011 4:59 PM, Weijun Wang wrote: > Hi All > > I have a keystore with a bunch of testing root CA, intermediate CA and > entity certs, some PrivateKeyEntry and some TrustedCertEntry, and it's > quite difficult to know who signs who. Therefore I suggest some > enhancement for the simple "keytool -list". (by simple, I mean no "-v"). > > The entry will look like: > > user, Sep 6, 2007, PrivateKeyEntry, user - signer - rootca(self) > > Here, "user - signer - bigca(self)" means the entry's cert chain has 3 > certs, which matches aliases user, signer, and rootca in the same > keystore, and rootca is a self-signed cert. > > When a cert is not inside this keystore, its distinguished name can be > printed, like this: > > user, Sep 6, 2007, PrivateKeyEntry, user - signer - "CN=Root CA"(self) > > Also, if the last cert is not self-signed, its signed can also be added > after "--", like this: > > user, Sep 6, 2007, PrivateKeyEntry, > user - signer -- "CN=Another CA"(self) > > Do you find this useful? > > Thanks > Max > > From weijun.wang at oracle.com Mon Jan 17 17:40:16 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 18 Jan 2011 09:40:16 +0800 Subject: Request for Comment: adding chain info to keytool -list In-Reply-To: <4D34EC2F.5070306@oracle.com> References: <4D3404D8.3020705@oracle.com> <4D34EC2F.5070306@oracle.com> Message-ID: <4D34EF80.4060901@oracle.com> You mean a tree of the whole keystore, but not chain for each entry. Right? Max On 01/18/2011 09:26 AM, Xuelei Fan wrote: > I would like to see a option to display the intuitive tree. For example: > $ keytool -list -tree -keystore ... > + root CA alias > + intermediate CA alias > + entity cert 1 alias > + entity cert 2 alias > > Andrew > > On 1/17/2011 4:59 PM, Weijun Wang wrote: >> Hi All >> >> I have a keystore with a bunch of testing root CA, intermediate CA and >> entity certs, some PrivateKeyEntry and some TrustedCertEntry, and it's >> quite difficult to know who signs who. Therefore I suggest some >> enhancement for the simple "keytool -list". (by simple, I mean no "-v"). >> >> The entry will look like: >> >> user, Sep 6, 2007, PrivateKeyEntry, user - signer - rootca(self) >> >> Here, "user - signer - bigca(self)" means the entry's cert chain has 3 >> certs, which matches aliases user, signer, and rootca in the same >> keystore, and rootca is a self-signed cert. >> >> When a cert is not inside this keystore, its distinguished name can be >> printed, like this: >> >> user, Sep 6, 2007, PrivateKeyEntry, user - signer - "CN=Root CA"(self) >> >> Also, if the last cert is not self-signed, its signed can also be added >> after "--", like this: >> >> user, Sep 6, 2007, PrivateKeyEntry, >> user - signer -- "CN=Another CA"(self) >> >> Do you find this useful? >> >> Thanks >> Max >> >> > From xuelei.fan at oracle.com Mon Jan 17 17:45:27 2011 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Tue, 18 Jan 2011 09:45:27 +0800 Subject: Request for Comment: adding chain info to keytool -list In-Reply-To: <4D34EF80.4060901@oracle.com> References: <4D3404D8.3020705@oracle.com> <4D34EC2F.5070306@oracle.com> <4D34EF80.4060901@oracle.com> Message-ID: <4D34F0B7.6020105@oracle.com> On 1/18/2011 9:40 AM, Weijun Wang wrote: > You mean a tree of the whole keystore, but not chain for each entry. Right? > Right. Andrew > Max > > On 01/18/2011 09:26 AM, Xuelei Fan wrote: >> I would like to see a option to display the intuitive tree. For example: >> $ keytool -list -tree -keystore ... >> + root CA alias >> + intermediate CA alias >> + entity cert 1 alias >> + entity cert 2 alias >> >> Andrew >> >> On 1/17/2011 4:59 PM, Weijun Wang wrote: >>> Hi All >>> >>> I have a keystore with a bunch of testing root CA, intermediate CA and >>> entity certs, some PrivateKeyEntry and some TrustedCertEntry, and it's >>> quite difficult to know who signs who. Therefore I suggest some >>> enhancement for the simple "keytool -list". (by simple, I mean no "-v"). >>> >>> The entry will look like: >>> >>> user, Sep 6, 2007, PrivateKeyEntry, user - signer - rootca(self) >>> >>> Here, "user - signer - bigca(self)" means the entry's cert chain has 3 >>> certs, which matches aliases user, signer, and rootca in the same >>> keystore, and rootca is a self-signed cert. >>> >>> When a cert is not inside this keystore, its distinguished name can be >>> printed, like this: >>> >>> user, Sep 6, 2007, PrivateKeyEntry, user - signer - "CN=Root >>> CA"(self) >>> >>> Also, if the last cert is not self-signed, its signed can also be added >>> after "--", like this: >>> >>> user, Sep 6, 2007, PrivateKeyEntry, >>> user - signer -- "CN=Another CA"(self) >>> >>> Do you find this useful? >>> >>> Thanks >>> Max >>> >>> >> From kumar.x.srinivasan at oracle.com Tue Jan 18 08:38:47 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Tue, 18 Jan 2011 16:38:47 +0000 Subject: hg: jdk7/tl/langtools: 6982999: tools must support -target 7 bytecodes Message-ID: <20110118163851.AD27447EA9@hg.openjdk.java.net> Changeset: 5cf6c432ef2f Author: ksrini Date: 2011-01-18 08:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5cf6c432ef2f 6982999: tools must support -target 7 bytecodes Reviewed-by: jjg, jrose ! src/share/classes/com/sun/tools/classfile/Attribute.java + src/share/classes/com/sun/tools/classfile/BootstrapMethods_attribute.java ! src/share/classes/com/sun/tools/classfile/ClassTranslator.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/share/classes/com/sun/tools/classfile/ConstantPool.java ! src/share/classes/com/sun/tools/classfile/Dependencies.java ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! src/share/classes/com/sun/tools/javap/ConstantWriter.java From weijun.wang at oracle.com Wed Jan 19 01:34:26 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 19 Jan 2011 17:34:26 +0800 Subject: Request for Comment: adding chain info to keytool -list In-Reply-To: <4D34F0B7.6020105@oracle.com> References: <4D3404D8.3020705@oracle.com> <4D34EC2F.5070306@oracle.com> <4D34EF80.4060901@oracle.com> <4D34F0B7.6020105@oracle.com> Message-ID: <4D36B022.3060003@oracle.com> Oh, I have a design now. keytool -list -tree will show: ****************************************** * Chained entries ****************************************** b, PrivateKeyEntry + h, PrivateKeyEntry + f, PrivateKeyEntry + i, PrivateKeyEntry [ca], TrustedCertificateEntry + "CN=j" + k, PrivateKeyEntry "CN=a" + e, PrivateKeyEntry + d, PrivateKeyEntry + g, TrustedCertificateEntry Non self signed: + "CN=l" + m, PrivateKeyEntry ****************************************** * Other entries: ****************************************** x, SecretKeyEntry which means: 1. b signs h, h signs f and i. b, h, i, and f are aliases in this keystore. 2. [ca] is not in this keystore, but in cacerts. 3. "CN=j" is neither in this keystore or cacerts 4. b, [ca] and "CN=a" are all self-signed certs, which are listed at top level of the tree. "CN=l" is not a self-signed cert, so it's listed under "Not self signed". But we still know "CN=l" signs m. 5. x is a SecretKeyEntry so not put inside chained entries. Any suggestions? Thanks Max On 01/18/2011 09:45 AM, Xuelei Fan wrote: > On 1/18/2011 9:40 AM, Weijun Wang wrote: >> You mean a tree of the whole keystore, but not chain for each entry. Right? >> > Right. > > Andrew > >> Max >> >> On 01/18/2011 09:26 AM, Xuelei Fan wrote: >>> I would like to see a option to display the intuitive tree. For example: >>> $ keytool -list -tree -keystore ... >>> + root CA alias >>> + intermediate CA alias >>> + entity cert 1 alias >>> + entity cert 2 alias >>> >>> Andrew >>> >>> On 1/17/2011 4:59 PM, Weijun Wang wrote: >>>> Hi All >>>> >>>> I have a keystore with a bunch of testing root CA, intermediate CA and >>>> entity certs, some PrivateKeyEntry and some TrustedCertEntry, and it's >>>> quite difficult to know who signs who. Therefore I suggest some >>>> enhancement for the simple "keytool -list". (by simple, I mean no "-v"). >>>> >>>> The entry will look like: >>>> >>>> user, Sep 6, 2007, PrivateKeyEntry, user - signer - rootca(self) >>>> >>>> Here, "user - signer - bigca(self)" means the entry's cert chain has 3 >>>> certs, which matches aliases user, signer, and rootca in the same >>>> keystore, and rootca is a self-signed cert. >>>> >>>> When a cert is not inside this keystore, its distinguished name can be >>>> printed, like this: >>>> >>>> user, Sep 6, 2007, PrivateKeyEntry, user - signer - "CN=Root >>>> CA"(self) >>>> >>>> Also, if the last cert is not self-signed, its signed can also be added >>>> after "--", like this: >>>> >>>> user, Sep 6, 2007, PrivateKeyEntry, >>>> user - signer -- "CN=Another CA"(self) >>>> >>>> Do you find this useful? >>>> >>>> Thanks >>>> Max >>>> >>>> >>> > From xuelei.fan at oracle.com Wed Jan 19 06:50:24 2011 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 19 Jan 2011 22:50:24 +0800 Subject: Request for Comment: adding chain info to keytool -list In-Reply-To: <4D36B022.3060003@oracle.com> References: <4D3404D8.3020705@oracle.com> <4D34EC2F.5070306@oracle.com> <4D34EF80.4060901@oracle.com> <4D34F0B7.6020105@oracle.com> <4D36B022.3060003@oracle.com> Message-ID: <4D36FA30.2030802@oracle.com> I'm not sure I understand the proposal completely. Please read in-lines comments. On 1/19/2011 5:34 PM, Weijun Wang wrote: > Oh, I have a design now. keytool -list -tree will show: > > ****************************************** > * Chained entries > ****************************************** > b, PrivateKeyEntry > + h, PrivateKeyEntry > + f, PrivateKeyEntry > + i, PrivateKeyEntry What the criterion to make the private key entries hierarchical? I don't think there is hierarchical relations between private key entry. Do you mean the hierarchical relation of the certificate chain of the target private key entries? I'm confused here. > [ca], TrustedCertificateEntry > + "CN=j" > + k, PrivateKeyEntry > "CN=a" > + e, PrivateKeyEntry > + d, PrivateKeyEntry > + g, TrustedCertificateEntry I don't think I understand the above two trees. Is there any connection between privaeKeyEntry and TrustedCertificateEntry? It is not intuitive to me. > Non self signed: > + "CN=l" > + m, PrivateKeyEntry > ****************************************** > * Other entries: > ****************************************** > x, SecretKeyEntry > > which means: > > 1. b signs h, h signs f and i. b, h, i, and f are aliases in this keystore. > > 2. [ca] is not in this keystore, but in cacerts. > Do you mean that the keyTool will try to parse the cacerts keystore? > 3. "CN=j" is neither in this keystore or cacerts > If it is not in this keystore, where does it come from? > 4. b, [ca] and "CN=a" are all self-signed certs, which are listed at top > level of the tree. "CN=l" is not a self-signed cert, so it's listed > under "Not self signed". But we still know "CN=l" signs m. > I guess I can understand your purpose. Do you want to category the entries into private key entries, intermediate certificates, authorities and others? > 5. x is a SecretKeyEntry so not put inside chained entries. > > Any suggestions? > >From my understand,a key store contains three types of entries: 1. secret key entry 2. trusted certificate 3. private key entry and the related certificate chain. Of course, the chain concept does not apply to secret key entry. Normally, the trusted certificates do not store in chains. Most of the time, they are only individual certificate. That's to say, if we want to show them in trees, the tree normally only has multiple root, but no branches. It may looks like: + trusted cert 1 + trusted cert 2 + trusted cert 3 So if only for trusted certificates, I don't think it is necessary to display the key store in tree style, or mark the signing sequence in any other method. BTW, I think we may not want to introduce the concept of self-signed certificate. It adds confusion. The trusted certificate is the root certificate. As I don't care, I may be lazy to tell whether it is a self-signed, self-issued, non-self signed, non-self issued certificate. Considering the private key entry, it is accompanied by a certificate chain for the corresponding public key. To display the chain in order, I think that's the purpose to display the key store in tree, or adding chain info to keytool list command. >From my understanding of KeyStore, I think the tree may looks like (if we still want to category the entities into three) + private key entries + PrivateKeyEntry instance 1 [alias] + the top issuer's certificate [subject, KID] + ... the intermediate issuer's certificates ... + the certificate of the private key entry + PrivateKeyEntry instance 2 [alias] + the top issuer's certificate [subject, KID] + ... the intermediate issuer's certificates ... + the certificate of the private key entry ... + PrivateKeyEntry instance n [alias] + the top issuer's certificate [subject, KID] + ... the intermediate issuer's certificates ... + the certificate of the private key entry + trusted certificates + trusted cert 1 [alias] + trusted cert 2 [alias] ... + trusted cert n [alias] + secret entries + secret entry 1 [alias] + secret entry 2 [alias] ... + secret entry n [alias] Xuelei > Thanks > Max > > On 01/18/2011 09:45 AM, Xuelei Fan wrote: >> On 1/18/2011 9:40 AM, Weijun Wang wrote: >>> You mean a tree of the whole keystore, but not chain for each entry. >>> Right? >>> >> Right. >> >> Andrew >> >>> Max >>> >>> On 01/18/2011 09:26 AM, Xuelei Fan wrote: >>>> I would like to see a option to display the intuitive tree. For >>>> example: >>>> $ keytool -list -tree -keystore ... >>>> + root CA alias >>>> + intermediate CA alias >>>> + entity cert 1 alias >>>> + entity cert 2 alias >>>> >>>> Andrew >>>> >>>> On 1/17/2011 4:59 PM, Weijun Wang wrote: >>>>> Hi All >>>>> >>>>> I have a keystore with a bunch of testing root CA, intermediate CA and >>>>> entity certs, some PrivateKeyEntry and some TrustedCertEntry, and it's >>>>> quite difficult to know who signs who. Therefore I suggest some >>>>> enhancement for the simple "keytool -list". (by simple, I mean no >>>>> "-v"). >>>>> >>>>> The entry will look like: >>>>> >>>>> user, Sep 6, 2007, PrivateKeyEntry, user - signer - rootca(self) >>>>> >>>>> Here, "user - signer - bigca(self)" means the entry's cert chain has 3 >>>>> certs, which matches aliases user, signer, and rootca in the same >>>>> keystore, and rootca is a self-signed cert. >>>>> >>>>> When a cert is not inside this keystore, its distinguished name can be >>>>> printed, like this: >>>>> >>>>> user, Sep 6, 2007, PrivateKeyEntry, user - signer - "CN=Root >>>>> CA"(self) >>>>> >>>>> Also, if the last cert is not self-signed, its signed can also be >>>>> added >>>>> after "--", like this: >>>>> >>>>> user, Sep 6, 2007, PrivateKeyEntry, >>>>> user - signer -- "CN=Another CA"(self) >>>>> >>>>> Do you find this useful? >>>>> >>>>> Thanks >>>>> Max >>>>> >>>>> >>>> >> From weijun.wang at oracle.com Wed Jan 19 20:33:36 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 20 Jan 2011 12:33:36 +0800 Subject: Request for Comment: adding chain info to keytool -list In-Reply-To: <4D36FA30.2030802@oracle.com> References: <4D3404D8.3020705@oracle.com> <4D34EC2F.5070306@oracle.com> <4D34EF80.4060901@oracle.com> <4D34F0B7.6020105@oracle.com> <4D36B022.3060003@oracle.com> <4D36FA30.2030802@oracle.com> Message-ID: <4D37BB20.3090307@oracle.com> First, commenting on your proposal: It's a bunch of independent chains, not a tree. It's more similar to my original proposal, which was: user, Sep 6, 2007, PrivateKeyEntry, user - signer - rootca(self) In your format, it becomes: user, Sep 6, 2007, PrivateKeyEntry CN=Root CA CN=Signer CN=User Certainly it looks better (dnames are usually quite long), but not what I think of a tree. What I think of a tree, is that if two certs are signed by the same issuer, then the two certs (or entity) should be the branches of this single signer. Thus the tree shows the relationship of signing. In this tree, each node represents an entity (which normally has a certificate and a dname), whether it's a root CA, an intermediate CA or an end-entity, and each entity appears only once. The tree is constructed so that a node signs its direct children. If it happens to be an entry in this keystore (which means it equals to the getCertificate() for that entry), the alias and entry type is printed. If it can be found in cacerts, [alias] is shown. Otherwise, the "distinguished name" is shown. Because not all entities can be connected by signing, so he tree has a special root node that has all self-signed certs as its children. This root has another special child whose children are certs that are not self-signed but their signers are not available, aka, incomplete chains. I understand that sometimes certs sign each other to form a loop. I haven't yet figured out how to best show this in a tree. More description below inline. On 01/19/2011 10:50 PM, Xuelei Fan wrote: > I'm not sure I understand the proposal completely. Please read in-lines > comments. > > On 1/19/2011 5:34 PM, Weijun Wang wrote: >> Oh, I have a design now. keytool -list -tree will show: >> >> ****************************************** >> * Chained entries >> ****************************************** >> b, PrivateKeyEntry >> + h, PrivateKeyEntry >> + f, PrivateKeyEntry >> + i, PrivateKeyEntry These are all PrivateKeyEntries, and b signs h, h signs f, and f signs i. > > What the criterion to make the private key entries hierarchical? I don't > think there is hierarchical relations between private key entry. Do you Yes, there are. The entries are created with: kt -genkeypair -alias b kt -genkeypair -alias h kt -genkeypair -alias f kt -certreq -alias h | kt -gencert -alias b | kt -import -alias h kt -certreq -alias f | kt -gencert -alias h | kt -import -alias f > mean the hierarchical relation of the certificate chain of the target > private key entries? I'm confused here. > >> [ca], TrustedCertificateEntry >> + "CN=j" >> + k, PrivateKeyEntry This is the most typical case in a keystore for a privateKeyEntry. The user k gets the chain from a CA. The chain ends with a root CA [ca] in cacerts, the intermediate CA is "CN=j" but it's neither listed in this keystore or cacerts. >> "CN=a" >> + e, PrivateKeyEntry >> + d, PrivateKeyEntry >> + g, TrustedCertificateEntry > > I don't think I understand the above two trees. Is there any connection > between privaeKeyEntry and TrustedCertificateEntry? It is not intuitive > to me. It's just that the entry with alias g is a TrustedCertificateEntry. > >> Non self signed: >> + "CN=l" >> + m, PrivateKeyEntry >> ****************************************** >> * Other entries: >> ****************************************** >> x, SecretKeyEntry >> >> which means: >> >> 1. b signs h, h signs f and i. b, h, i, and f are aliases in this keystore. >> >> 2. [ca] is not in this keystore, but in cacerts. >> > Do you mean that the keyTool will try to parse the cacerts keystore? Yes, but it only shows those related to this keystore. > >> 3. "CN=j" is neither in this keystore or cacerts >> > If it is not in this keystore, where does it come from? It's in the cert chain for privateKeyEntry k. As I said, the tree shows all entities, whether it's an alias in this keystore, in cacerts, or neither. > >> 4. b, [ca] and "CN=a" are all self-signed certs, which are listed at top >> level of the tree. "CN=l" is not a self-signed cert, so it's listed >> under "Not self signed". But we still know "CN=l" signs m. >> > I guess I can understand your purpose. Do you want to category the > entries into private key entries, intermediate certificates, authorities > and others? No, still only PrivateKeyEntry and TrustedCerticateEntry (and others). Thanks Max > >> 5. x is a SecretKeyEntry so not put inside chained entries. >> >> Any suggestions? >> > From my understand,a key store contains three types of entries: > 1. secret key entry > 2. trusted certificate > 3. private key entry and the related certificate chain. > > Of course, the chain concept does not apply to secret key entry. > Normally, the trusted certificates do not store in chains. Most > of the time, they are only individual certificate. That's to say, if we > want to show them in trees, the tree normally only has multiple root, > but no branches. It may looks like: > + trusted cert 1 > + trusted cert 2 > + trusted cert 3 > > So if only for trusted certificates, I don't think it is necessary to > display the key store in tree style, or mark the signing sequence in any > other method. > > BTW, I think we may not want to introduce the concept of self-signed > certificate. It adds confusion. The trusted certificate is the root > certificate. As I don't care, I may be lazy to tell whether it is a > self-signed, self-issued, non-self signed, non-self issued certificate. > > Considering the private key entry, it is accompanied by a certificate > chain for the corresponding public key. To display the chain in order, I > think that's the purpose to display the key store in tree, or adding > chain info to keytool list command. > > From my understanding of KeyStore, I think the tree may looks like (if > we still want to category the entities into three) > + private key entries > + PrivateKeyEntry instance 1 [alias] > + the top issuer's certificate [subject, KID] > + ... the intermediate issuer's certificates ... > + the certificate of the private key entry > + PrivateKeyEntry instance 2 [alias] > + the top issuer's certificate [subject, KID] > + ... the intermediate issuer's certificates ... > + the certificate of the private key entry > ... > + PrivateKeyEntry instance n [alias] > + the top issuer's certificate [subject, KID] > + ... the intermediate issuer's certificates ... > + the certificate of the private key entry > > + trusted certificates > + trusted cert 1 [alias] > + trusted cert 2 [alias] > ... > + trusted cert n [alias] > > + secret entries > + secret entry 1 [alias] > + secret entry 2 [alias] > ... > + secret entry n [alias] > > Xuelei > >> Thanks >> Max >> >> On 01/18/2011 09:45 AM, Xuelei Fan wrote: >>> On 1/18/2011 9:40 AM, Weijun Wang wrote: >>>> You mean a tree of the whole keystore, but not chain for each entry. >>>> Right? >>>> >>> Right. >>> >>> Andrew >>> >>>> Max >>>> >>>> On 01/18/2011 09:26 AM, Xuelei Fan wrote: >>>>> I would like to see a option to display the intuitive tree. For >>>>> example: >>>>> $ keytool -list -tree -keystore ... >>>>> + root CA alias >>>>> + intermediate CA alias >>>>> + entity cert 1 alias >>>>> + entity cert 2 alias >>>>> >>>>> Andrew >>>>> >>>>> On 1/17/2011 4:59 PM, Weijun Wang wrote: >>>>>> Hi All >>>>>> >>>>>> I have a keystore with a bunch of testing root CA, intermediate CA and >>>>>> entity certs, some PrivateKeyEntry and some TrustedCertEntry, and it's >>>>>> quite difficult to know who signs who. Therefore I suggest some >>>>>> enhancement for the simple "keytool -list". (by simple, I mean no >>>>>> "-v"). >>>>>> >>>>>> The entry will look like: >>>>>> >>>>>> user, Sep 6, 2007, PrivateKeyEntry, user - signer - rootca(self) >>>>>> >>>>>> Here, "user - signer - bigca(self)" means the entry's cert chain has 3 >>>>>> certs, which matches aliases user, signer, and rootca in the same >>>>>> keystore, and rootca is a self-signed cert. >>>>>> >>>>>> When a cert is not inside this keystore, its distinguished name can be >>>>>> printed, like this: >>>>>> >>>>>> user, Sep 6, 2007, PrivateKeyEntry, user - signer - "CN=Root >>>>>> CA"(self) >>>>>> >>>>>> Also, if the last cert is not self-signed, its signed can also be >>>>>> added >>>>>> after "--", like this: >>>>>> >>>>>> user, Sep 6, 2007, PrivateKeyEntry, >>>>>> user - signer -- "CN=Another CA"(self) >>>>>> >>>>>> Do you find this useful? >>>>>> >>>>>> Thanks >>>>>> Max >>>>>> >>>>>> >>>>> >>> > From lana.steuck at oracle.com Wed Jan 19 20:56:03 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 20 Jan 2011 04:56:03 +0000 Subject: hg: jdk7/tl: 2 new changesets Message-ID: <20110120045603.ED7C547F97@hg.openjdk.java.net> Changeset: 5c4df7e99277 Author: cl Date: 2011-01-06 20:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/5c4df7e99277 Added tag jdk7-b124 for changeset 024a6755895b ! .hgtags Changeset: b566d4909056 Author: cl Date: 2011-01-13 16:43 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/b566d4909056 Added tag jdk7-b125 for changeset 5c4df7e99277 ! .hgtags From lana.steuck at oracle.com Wed Jan 19 20:56:09 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 20 Jan 2011 04:56:09 +0000 Subject: hg: jdk7/tl/corba: 2 new changesets Message-ID: <20110120045610.2F37A47F98@hg.openjdk.java.net> Changeset: 1ce58c72b789 Author: cl Date: 2011-01-06 20:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/1ce58c72b789 Added tag jdk7-b124 for changeset f90b3e014e83 ! .hgtags Changeset: d7532bcd3742 Author: cl Date: 2011-01-13 16:43 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/d7532bcd3742 Added tag jdk7-b125 for changeset 1ce58c72b789 ! .hgtags From lana.steuck at oracle.com Wed Jan 19 21:01:37 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 20 Jan 2011 05:01:37 +0000 Subject: hg: jdk7/tl/hotspot: 43 new changesets Message-ID: <20110120050253.8275447F9B@hg.openjdk.java.net> Changeset: 09d92cbb793b Author: cl Date: 2011-01-06 20:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/09d92cbb793b Added tag jdk7-b124 for changeset 0a8e0d4345b3 ! .hgtags Changeset: f6a707dbaddb Author: trims Date: 2011-01-07 19:09 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/f6a707dbaddb Added tag hs20-b05 for changeset 0a8e0d4345b3 ! .hgtags Changeset: 9fc3ffb1e0b1 Author: trims Date: 2011-01-07 22:42 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/9fc3ffb1e0b1 7011125: Bump the HS20 build number to 06 Summary: Update the HS20 build number to 06 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 6da3527317ff Author: kevinw Date: 2010-12-17 12:14 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/6da3527317ff 7003487: clhsdbproc stacktrace fails on x64 Reviewed-by: phh ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java Changeset: 02895c6a2f82 Author: bobv Date: 2010-12-20 14:30 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/02895c6a2f82 7007769: VM crashes with SIGBUS writing PerfData if tmp space is full Summary: Fill perfdata file with zeros to verify available disk space Reviewed-by: coleenp, kamg ! src/os/linux/vm/perfMemory_linux.cpp Changeset: e58d06a8037e Author: dholmes Date: 2010-12-21 23:39 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/e58d06a8037e 7008444: Remove unnecessary include of stdint.h in java_md.c Summary: Remove unnecessary include of stdint.h in java_md.c Reviewed-by: brutisso, kvn ! src/os/posix/launcher/java_md.c Changeset: 1e637defdda6 Author: zgu Date: 2010-12-22 11:24 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1e637defdda6 6961186: Better VM handling of unexpected exceptions from application native code Summary: Trap uncaught C++ exception on Windows and Solaris and generate hs_err report. Reviewed-by: coleenp, bobv, dholmes ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp Changeset: c19157304e08 Author: zgu Date: 2010-12-22 11:52 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c19157304e08 Merge ! src/os/windows/vm/os_windows.cpp Changeset: 3da13a976363 Author: coleenp Date: 2010-12-22 12:24 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3da13a976363 Merge ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java Changeset: 07c62ff47437 Author: coleenp Date: 2010-12-22 16:52 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/07c62ff47437 Merge Changeset: d6cd0d55d0b5 Author: dcubed Date: 2010-12-23 07:58 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d6cd0d55d0b5 6987812: 2/3 SAJDI: "gHotSpotVMTypes was not initialized properly in the remote process" Summary: Change ExportDirectoryTableImpl to return the 'Export RVA' field without modification. Read 'Base Of Data' field in optional header when PE32 format COFF file is read. Refine search for dbgeng.dll and dbghelp.dll. Other cleanups. Reviewed-by: swamyv, poonam ! agent/src/share/classes/sun/jvm/hotspot/HotSpotTypeDataBase.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/win32/coff/COFFFileParser.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/win32/coff/DumpExports.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/win32/coff/TestParser.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgDebuggerLocal.java Changeset: e0c969b97f66 Author: zgu Date: 2010-12-27 09:30 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/e0c969b97f66 6975480: VS2010 says _STATIC_CPPLIB is deprecated, may need to change this usage Summary: Disabled the warning message during compiling. Reviewed-by: coleenp, dholmes ! make/windows/makefiles/compile.make Changeset: dbf8dcf069d1 Author: zgu Date: 2010-12-27 09:56 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/dbf8dcf069d1 Merge ! make/windows/makefiles/compile.make Changeset: 06e4b9c9db76 Author: coleenp Date: 2010-12-28 09:54 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/06e4b9c9db76 Merge Changeset: 7737fa7ec2b5 Author: twisti Date: 2010-12-14 12:44 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7737fa7ec2b5 7006044: materialize cheap non-oop pointers on 64-bit SPARC Summary: After 6961690 we load non-oop pointers for the constant table which could easily be materialized in a few instructions. Reviewed-by: never, kvn ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/sparc.ad Changeset: 781072b12368 Author: never Date: 2010-12-14 23:17 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/781072b12368 6765546: Wrong sscanf used to parse CompilerOracle command >= 32 characters could lead to crash Reviewed-by: kvn, iveresov ! src/share/vm/compiler/compilerOracle.cpp Changeset: 4042471b7419 Author: iveresov Date: 2010-12-16 01:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/4042471b7419 Merge Changeset: cccd1b172b85 Author: never Date: 2010-12-16 12:47 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/cccd1b172b85 6839888: Array overrun in vm adlc Reviewed-by: kvn, iveresov ! src/share/vm/adlc/dict2.cpp Changeset: c04052fd6ae1 Author: kvn Date: 2010-12-16 14:15 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c04052fd6ae1 7006505: Use kstat info to identify SPARC processor Summary: read Solaris kstat data to get more precise CPU information Reviewed-by: iveresov, never, twisti, dholmes ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/vm.make ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.hpp ! src/os/solaris/vm/os_solaris.cpp ! src/os_cpu/solaris_sparc/vm/vm_version_solaris_sparc.cpp ! src/share/vm/memory/universe.cpp Changeset: 7223744c2784 Author: never Date: 2010-12-17 15:55 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7223744c2784 6579789: Internal error "c1_LinearScan.cpp:1429 Error: assert(false,"")" in debuggee with fastdebug VM Reviewed-by: kvn, iveresov ! src/share/vm/c1/c1_LinearScan.cpp ! src/share/vm/c1/c1_LinearScan.hpp + test/compiler/6579789/Test6579789.java Changeset: 52d615436cef Author: never Date: 2010-12-18 06:40 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/52d615436cef Merge Changeset: 7d9caaedafce Author: twisti Date: 2010-12-18 01:15 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7d9caaedafce 6990933: assert(sender_cb) failed: sanity in frame::sender_for_interpreter_frame Reviewed-by: never ! src/share/vm/code/nmethod.cpp Changeset: 1fb0500f550e Author: twisti Date: 2010-12-18 08:38 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1fb0500f550e Merge Changeset: ef3c5db0b3ae Author: twisti Date: 2010-12-21 04:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ef3c5db0b3ae 7008165: Garbage in ClassFormatError message Summary: When bootstrap_method_ref in BootstrapMethods attribute points to a wrong CP entry (non-MethodHandle), JVM throws ClassFormatError with a message, where method index and class file name is garbage. Reviewed-by: iveresov ! src/share/vm/classfile/classFileParser.cpp Changeset: a21ff35351ec Author: kvn Date: 2010-12-21 13:56 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a21ff35351ec 7003130: assert(iterations start) failed: need enough space to divide up Summary: Codebuffer can overflow on test with large number of calls Reviewed-by: dholmes, collins ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Compilation.hpp Changeset: 4537d449ba57 Author: bobv Date: 2011-01-07 15:57 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/4537d449ba57 Merge Changeset: b1a2afa37ec4 Author: phh Date: 2011-01-07 10:42 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b1a2afa37ec4 7003271: Hotspot should track cumulative Java heap bytes allocated on a per-thread basis Summary: Track allocated bytes in Thread's, update on TLAB retirement and direct allocation in Eden and tenured, add JNI methods for ThreadMXBean. Reviewed-by: coleenp, kvn, dholmes, ysr ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/c1_MacroAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_MacroAssembler_sparc.hpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/c1_MacroAssembler_x86.cpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/thread_solaris.inline.hpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/memory/threadLocalAllocBuffer.cpp ! src/share/vm/memory/threadLocalAllocBuffer.hpp ! src/share/vm/opto/macro.cpp ! src/share/vm/prims/jvmti.xml ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/services/jmm.h ! src/share/vm/services/management.cpp ! src/share/vm/services/threadService.cpp ! src/share/vm/services/threadService.hpp Changeset: 55d7d18ccff9 Author: dcubed Date: 2011-01-07 13:59 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/55d7d18ccff9 Merge Changeset: 84f36150fcc3 Author: dcubed Date: 2011-01-07 15:54 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/84f36150fcc3 Merge ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/os/solaris/vm/os_solaris.cpp Changeset: e24ab3fa6aaf Author: trims Date: 2011-01-07 22:56 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/e24ab3fa6aaf Merge ! make/jprt.properties Changeset: 4c851c931d00 Author: cl Date: 2011-01-13 16:43 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/4c851c931d00 Added tag jdk7-b125 for changeset e24ab3fa6aaf ! .hgtags From lana.steuck at oracle.com Wed Jan 19 21:04:14 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 20 Jan 2011 05:04:14 +0000 Subject: hg: jdk7/tl/jaxp: 4 new changesets Message-ID: <20110120050414.DC4E747F9C@hg.openjdk.java.net> Changeset: 6c9bdee0cc3a Author: cl Date: 2011-01-06 20:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/6c9bdee0cc3a Added tag jdk7-b124 for changeset 57ed1f3bec72 ! .hgtags Changeset: 116b935148bc Author: cl Date: 2011-01-13 16:43 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/116b935148bc Added tag jdk7-b125 for changeset 6c9bdee0cc3a ! .hgtags Changeset: 64c84c62ec2a Author: lana Date: 2011-01-13 14:55 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/64c84c62ec2a Merge Changeset: 2fde639439c1 Author: lana Date: 2011-01-14 13:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/2fde639439c1 Merge From lana.steuck at oracle.com Wed Jan 19 21:04:19 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 20 Jan 2011 05:04:19 +0000 Subject: hg: jdk7/tl/jaxws: 4 new changesets Message-ID: <20110120050419.D9C8C47F9D@hg.openjdk.java.net> Changeset: d72eea121c3b Author: cl Date: 2011-01-06 20:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/d72eea121c3b Added tag jdk7-b124 for changeset 86f60e5b3975 ! .hgtags Changeset: e8fc02b4c889 Author: cl Date: 2011-01-13 16:43 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/e8fc02b4c889 Added tag jdk7-b125 for changeset d72eea121c3b ! .hgtags Changeset: dba69d6345d9 Author: lana Date: 2011-01-13 14:55 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/dba69d6345d9 Merge Changeset: 6d772c5119d5 Author: lana Date: 2011-01-14 13:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/6d772c5119d5 Merge From lana.steuck at oracle.com Wed Jan 19 21:07:52 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 20 Jan 2011 05:07:52 +0000 Subject: hg: jdk7/tl/jdk: 56 new changesets Message-ID: <20110120051721.A712847FA2@hg.openjdk.java.net> Changeset: 0a56bdd709d0 Author: cl Date: 2011-01-06 20:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0a56bdd709d0 Added tag jdk7-b124 for changeset 1c72adc9d5f3 ! .hgtags Changeset: 3972926bc8f1 Author: cl Date: 2011-01-13 16:44 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3972926bc8f1 Added tag jdk7-b125 for changeset 0a56bdd709d0 ! .hgtags Changeset: 4d6f9aaa2600 Author: flar Date: 2010-12-14 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4d6f9aaa2600 6766342: Improve performance of Ductus rasterizer Reviewed-by: jgodinez, prr ! make/sun/awt/make.depend ! make/sun/awt/mapfile-vers ! make/sun/awt/mapfile-vers-linux ! src/share/classes/sun/dc/DuctusRenderingEngine.java ! src/share/classes/sun/java2d/SurfaceData.java ! src/share/classes/sun/java2d/loops/CompositeType.java ! src/share/classes/sun/java2d/loops/MaskFill.java ! src/share/classes/sun/java2d/pipe/AAShapePipe.java ! src/share/classes/sun/java2d/pipe/AlphaColorPipe.java ! src/share/classes/sun/java2d/pipe/RenderingEngine.java ! src/share/classes/sun/java2d/pisces/PiscesRenderingEngine.java ! src/share/native/sun/java2d/loops/DrawParallelogram.c ! src/share/native/sun/java2d/loops/FillParallelogram.c ! src/share/native/sun/java2d/loops/MaskFill.c + src/share/native/sun/java2d/loops/ParallelogramUtils.h ! src/solaris/native/sun/java2d/loops/vis_IntArgbPre_Mask.c ! src/solaris/native/sun/java2d/loops/vis_SrcMaskFill.c + test/java/awt/Graphics2D/RenderClipTest/6766342.tests + test/java/awt/Graphics2D/RenderClipTest/RenderClipTest.java Changeset: 9d0eebb55003 Author: bae Date: 2010-12-15 19:47 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9d0eebb55003 6782574: AffineTransformOp.filter(BufferedImage, BufferedImage) fails with InternalError Reviewed-by: igor, prr ! src/share/classes/java/awt/image/SinglePixelPackedSampleModel.java ! src/share/native/sun/awt/image/awt_parseImage.c + test/java/awt/image/IncorrectSampleMaskTest.java Changeset: 6a219e5ccfd7 Author: bae Date: 2010-12-17 13:18 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6a219e5ccfd7 7006948: FindBugs warning in IndexColorModel class Reviewed-by: igor, prr ! src/share/classes/java/awt/image/IndexColorModel.java Changeset: 33a0f66771d5 Author: jgodinez Date: 2010-12-17 09:39 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/33a0f66771d5 6635462: D3D: REGRESSION: XOR rendering is extremly slow Reviewed-by: igor, prr ! src/share/classes/javax/swing/DefaultDesktopManager.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/java2d/d3d/D3DSurfaceData.java Changeset: 0125062d65b6 Author: bae Date: 2010-12-20 10:38 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0125062d65b6 6736178: java.awt.image.SampleModel constructor unexpectedly throws IllegalArgumentException Reviewed-by: jgodinez, prr ! src/share/classes/java/awt/image/SampleModel.java Changeset: b0f9760f3103 Author: prr Date: 2010-12-22 13:32 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b0f9760f3103 7007299: FileFontStrike appears not to be threadsafe? Reviewed-by: igor, jgodinez ! src/share/classes/sun/font/FileFontStrike.java Changeset: 1513ccf103a9 Author: prr Date: 2010-12-22 13:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1513ccf103a9 6996867: Garbage rendering of LCD text with SRC composite mode Reviewed-by: igor, jgodinez ! src/share/classes/sun/java2d/SurfaceData.java + test/java/awt/Graphics2D/DrawString/LCDTextSrcEa.java Changeset: 78d0a8d449fd Author: bae Date: 2010-12-23 14:27 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/78d0a8d449fd 7002627: JNI Critical Arrays should be released with the original (unmodified) pointer Reviewed-by: jgodinez, prr ! src/share/native/sun/java2d/pipe/BufferedMaskBlit.c Changeset: cb3c0ffb27bb Author: lana Date: 2010-12-23 00:03 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cb3c0ffb27bb Merge - src/share/classes/java/dyn/BootstrapMethod.java - src/share/classes/java/dyn/LinkagePermission.java - src/share/classes/java/dyn/MethodHandleProvider.java - src/share/classes/sun/dyn/JavaMethodHandle.java - src/share/demo/nio/zipfs/META-INF/services/java.nio.file.spi.FileSystemProvider - src/share/demo/nio/zipfs/com/sun/nio/zipfs/JarFileSystemProvider.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipCoder.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipConstants.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipDirectoryStream.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileAttributeView.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileAttributes.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileStore.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileSystem.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileSystemProvider.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipInfo.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipPath.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipUtils.java - test/java/dyn/JavaDocExamples.java Changeset: 155d91257957 Author: lana Date: 2010-12-23 08:47 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/155d91257957 Merge Changeset: 7fff69f28bf4 Author: jgodinez Date: 2010-12-23 10:38 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7fff69f28bf4 6913300: Missing serialVersionUID in javax.print.attribute.standard.DialogTypeSelection Reviewed-by: igor, prr ! src/share/classes/javax/print/attribute/standard/DialogTypeSelection.java Changeset: b22c74e20a1b Author: jgodinez Date: 2010-12-23 11:01 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b22c74e20a1b 6949749: regression cases need to be updated by removing "System.exit(0)" Reviewed-by: igor, prr ! test/java/awt/PrintJob/Text/StringWidth.java Changeset: 417acb7e8fa1 Author: prr Date: 2010-12-23 15:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/417acb7e8fa1 6891551: Font rasterisation uses more heap than needed for some strikes. Reviewed-by: jgodinez ! src/share/classes/sun/font/FileFontStrike.java Changeset: 4e47e55dd717 Author: prr Date: 2010-12-23 21:58 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4e47e55dd717 6927458: font system should cache transient strikes with weak references. Reviewed-by: igor, jgodinez ! src/share/classes/sun/font/Font2D.java Changeset: 99c540ac926c Author: bae Date: 2010-12-24 14:05 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/99c540ac926c 6983028: java/awt/FontClass/FontPrivilege.java Reviewed-by: prr ! test/java/awt/FontClass/FontPrivilege.java Changeset: 14033e1600ac Author: prr Date: 2010-12-24 09:31 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/14033e1600ac 6997210: Solaris 11 has no development support for DGA: Cannot build JDK Reviewed-by: bae, ohair ! make/sun/Makefile Changeset: 70bfa0af3969 Author: bae Date: 2010-12-30 11:33 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/70bfa0af3969 7003434: test/closed/java/awt/FullScreen/DisplayChangeVITest/DisplayChangeVITest.java fails with ClassCastExc Reviewed-by: jgodinez, prr ! src/windows/classes/sun/java2d/opengl/WGLVolatileSurfaceManager.java Changeset: 9320dcfb5398 Author: lana Date: 2011-01-05 11:21 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9320dcfb5398 Merge - make/common/internal/BinaryPlugs.gmk ! make/sun/Makefile ! make/sun/awt/mapfile-vers ! make/sun/awt/mapfile-vers-linux ! src/share/classes/java/awt/image/IndexColorModel.java ! src/share/classes/java/awt/image/SampleModel.java ! src/share/classes/javax/swing/DefaultDesktopManager.java ! src/share/classes/sun/java2d/SurfaceData.java ! src/share/classes/sun/java2d/pisces/PiscesRenderingEngine.java ! src/share/native/sun/java2d/loops/DrawParallelogram.c ! src/share/native/sun/java2d/loops/FillParallelogram.c ! src/windows/classes/sun/awt/windows/WComponentPeer.java Changeset: 3db5ac2b4c62 Author: andrew Date: 2010-12-14 13:51 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3db5ac2b4c62 6444769: java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.html fails Summary: Remove unneeded test Reviewed-by: anthony - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.html - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.java Changeset: b9706aff91a3 Author: lana Date: 2010-12-15 11:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b9706aff91a3 Merge - src/share/classes/sun/net/httpserver/SelectorCache.java Changeset: 4a0970a420d5 Author: anthony Date: 2010-12-16 21:48 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4a0970a420d5 6993803: Request to update SplashScreen specification 6984255: Request for java.awt.SplashScreen spec update: mention possibility of having custom "-splash" option 6992416: [Spec clarification request] Is color deviation for splash screen image allowed? 6992833: [Spec clarification request] point (0,0) in SplashScreen.createGraphics() 6993071: java.awt.SplashScreen should mention that no unnecessary distortions to the image are allowed 6993113: [Spec clarification request] getSplashScreen(): null or HeadlessException? 6996439: [Spec clarification request] Is any delay with splashscreen appearance allowed? Summary: Update SplashScreen specification Reviewed-by: art ! src/share/classes/java/awt/SplashScreen.java Changeset: 8dbb797793b0 Author: anthony Date: 2010-12-22 17:37 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8dbb797793b0 6998323: Unexpected color change after invoking SplashScreen.update() Summary: Fix the blendRGB() function Reviewed-by: art, dcherepanov ! src/share/native/sun/awt/splashscreen/splashscreen_gfx_impl.h Changeset: 15c45fdd572c Author: lana Date: 2010-12-23 10:20 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/15c45fdd572c Merge - src/share/classes/java/dyn/BootstrapMethod.java - src/share/classes/java/dyn/LinkagePermission.java - src/share/classes/java/dyn/MethodHandleProvider.java - src/share/classes/sun/dyn/JavaMethodHandle.java - src/share/demo/nio/zipfs/META-INF/services/java.nio.file.spi.FileSystemProvider - src/share/demo/nio/zipfs/com/sun/nio/zipfs/JarFileSystemProvider.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipCoder.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipConstants.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipDirectoryStream.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileAttributeView.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileAttributes.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileStore.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileSystem.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileSystemProvider.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipInfo.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipPath.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipUtils.java - src/share/native/sun/font/layout/HebrewLigatureData.cpp - src/share/native/sun/font/layout/HebrewShaping.cpp - src/share/native/sun/font/layout/HebrewShaping.h - test/java/dyn/JavaDocExamples.java Changeset: 6e4d9f4466f6 Author: dcherepanov Date: 2010-12-27 18:37 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6e4d9f4466f6 4887645: Remove "awt.threadgroup" system property Reviewed-by: art, anthony ! src/share/classes/sun/awt/SunToolkit.java Changeset: a0a4f73b3d1d Author: dcherepanov Date: 2010-12-27 18:42 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a0a4f73b3d1d 6957765: Test Bug - javax/swing/SwingWorker/6480289/bug6480289.java failed on 1.7.0b94 but passed on previous Reviewed-by: art, alexp - test/javax/swing/SwingWorker/6480289/bug6480289.java Changeset: 33d4e0de0424 Author: dcherepanov Date: 2010-12-27 18:43 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/33d4e0de0424 6866808: nsk/stress/jck12a/jck12a014 crashes with SIGSEGV at [libjvm.so+0xc5b10] Reviewed-by: art ! src/solaris/native/sun/xawt/XToolkit.c Changeset: c90a0da7649e Author: dcherepanov Date: 2010-12-27 18:45 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c90a0da7649e 6921598: PrinterDialog hidden behind other frames Reviewed-by: art ! src/windows/native/sun/windows/awt_Dialog.cpp ! src/windows/native/sun/windows/awt_Dialog.h Changeset: 39e9d5613145 Author: dav Date: 2010-12-28 17:13 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/39e9d5613145 6999766: Changes to correct c/c++ language issues for use of parfait Reviewed-by: uta, amenkov ! src/windows/native/sun/windows/Devices.h ! src/windows/native/sun/windows/awt.h ! src/windows/native/sun/windows/awt_Debug.cpp ! src/windows/native/sun/windows/awt_Debug.h ! src/windows/native/sun/windows/awt_DesktopProperties.cpp ! src/windows/native/sun/windows/awt_TextArea.h ! src/windows/native/sun/windows/awt_Toolkit.h Changeset: 8b05f9b91765 Author: dav Date: 2010-12-29 15:13 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8b05f9b91765 7008106: com/sun/awt/Translucency/WindowOpacity.java test fails just against jdk7 b122 Reviewed-by: dcherepanov ! test/com/sun/awt/Translucency/WindowOpacity.java Changeset: 78364959fc73 Author: dav Date: 2010-12-29 17:36 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/78364959fc73 6963357: After clicking the "Load" button,the case FileDialogUserFilterTest.html crashes in jdk7 b98. Reviewed-by: dcherepanov ! src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.c Changeset: aa03f76d0e80 Author: lana Date: 2011-01-05 15:54 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/aa03f76d0e80 Merge - make/common/internal/BinaryPlugs.gmk ! src/share/classes/java/awt/SplashScreen.java ! src/share/classes/sun/awt/SunToolkit.java ! src/windows/native/sun/windows/awt.h ! src/windows/native/sun/windows/awt_DesktopProperties.cpp ! src/windows/native/sun/windows/awt_Dialog.cpp ! src/windows/native/sun/windows/awt_Toolkit.h Changeset: bde32b5becf1 Author: lana Date: 2011-01-06 18:01 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bde32b5becf1 Merge - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.html - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.java - test/javax/swing/SwingWorker/6480289/bug6480289.java Changeset: ec02d02d3409 Author: okutsu Date: 2010-12-15 11:38 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ec02d02d3409 6990037: font warnings in the build, missing fonts Reviewed-by: peytoia ! make/sun/awt/Makefile ! src/share/classes/sun/awt/FontConfiguration.java Changeset: cd7b5fb40005 Author: okutsu Date: 2010-12-17 16:56 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cd7b5fb40005 7007583: (tz) Windows-only: update tzmappings for KB2443685 Reviewed-by: peytoia ! src/windows/lib/tzmappings Changeset: 7c7e4a0330bc Author: okutsu Date: 2010-12-17 17:13 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7c7e4a0330bc 6644493: [Fmt-Da] SimpleDateFormat parsing RFC822 time offset is slow Reviewed-by: peytoia ! src/share/classes/java/text/SimpleDateFormat.java ! test/java/text/Format/DateFormat/ISO8601ZoneTest.java Changeset: f710204034fd Author: okutsu Date: 2010-12-17 18:06 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f710204034fd 6983207: API: MessageFormat quote handling discrepancy Reviewed-by: peytoia ! src/share/classes/java/text/MessageFormat.java Changeset: 89d065844fb6 Author: okutsu Date: 2010-12-21 10:58 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/89d065844fb6 6943959: NumericShaper API doc doesn't describe ARABIC/EASTERN_ARABIC precedence Reviewed-by: peytoia ! src/share/classes/java/awt/font/NumericShaper.java Changeset: 8da79c7d137e Author: okutsu Date: 2010-12-21 11:20 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8da79c7d137e 7007905: javazic produces wrong line numbers Reviewed-by: peytoia ! make/tools/src/build/tools/javazic/Zoneinfo.java Changeset: 55d9205735e1 Author: naoto Date: 2010-12-21 16:14 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/55d9205735e1 4940539: Constructor of java.util.Locale should handle ISO 639-2 Language Codes Reviewed-by: okutsu ! src/share/classes/java/util/Locale.java ! test/java/util/Locale/LocaleTest.java Changeset: 403a88eeac15 Author: lana Date: 2010-12-22 16:57 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/403a88eeac15 Merge - src/share/classes/java/dyn/BootstrapMethod.java - src/share/classes/java/dyn/LinkagePermission.java - src/share/classes/java/dyn/MethodHandleProvider.java - src/share/classes/sun/dyn/JavaMethodHandle.java - src/share/demo/nio/zipfs/META-INF/services/java.nio.file.spi.FileSystemProvider - src/share/demo/nio/zipfs/com/sun/nio/zipfs/JarFileSystemProvider.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipCoder.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipConstants.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipDirectoryStream.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileAttributeView.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileAttributes.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileStore.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileSystem.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileSystemProvider.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipInfo.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipPath.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipUtils.java - src/share/native/sun/font/layout/HebrewLigatureData.cpp - src/share/native/sun/font/layout/HebrewShaping.cpp - src/share/native/sun/font/layout/HebrewShaping.h - test/java/dyn/JavaDocExamples.java Changeset: c8b383fd8adf Author: rupashka Date: 2010-12-23 17:39 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c8b383fd8adf 6973773: JCK manual case JSliderTests.html#JSlider fails in jdk7 b100 Reviewed-by: alexp ! src/share/classes/javax/swing/JSlider.java Changeset: 69b2e5838eee Author: rupashka Date: 2010-12-23 18:25 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/69b2e5838eee 7007708: TEST: javax/swing/JScrollBar/6542335/bug6542335.java failes agaisnt jdk7 on solaris/linux Reviewed-by: alexp ! test/javax/swing/JScrollBar/6542335/bug6542335.java Changeset: 94e0438c74c3 Author: okutsu Date: 2010-12-27 14:13 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/94e0438c74c3 7003643: [Fmt-Me] MessageFormat.toPattern produces wrong quoted string and subformat modifiers 7008195: [Fmt-Me] Improve MessageFormat.applyPattern performance Reviewed-by: naoto, peytoia ! src/share/classes/java/text/MessageFormat.java + test/java/text/Format/MessageFormat/Bug7003643.java ! test/java/util/PluggableLocale/DateFormatProviderTest.java ! test/java/util/PluggableLocale/DateFormatProviderTest.sh ! test/java/util/PluggableLocale/NumberFormatProviderTest.java ! test/java/util/PluggableLocale/NumberFormatProviderTest.sh ! test/java/util/PluggableLocale/fooprovider.jar ! test/java/util/PluggableLocale/providersrc/DateFormatProviderImpl.java + test/java/util/PluggableLocale/providersrc/FooDateFormat.java + test/java/util/PluggableLocale/providersrc/FooNumberFormat.java ! test/java/util/PluggableLocale/providersrc/Makefile ! test/java/util/PluggableLocale/providersrc/NumberFormatProviderImpl.java Changeset: c06d4327c0f2 Author: rupashka Date: 2010-12-27 15:28 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c06d4327c0f2 6959584: closed/javax/swing/JFileChooser/4847375/bug4847375.java : compilation failed Reviewed-by: alexp + test/javax/swing/JFileChooser/4847375/bug4847375.java Changeset: 72f1247e9ff5 Author: rupashka Date: 2010-12-27 17:41 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/72f1247e9ff5 6532833: PIT: Metal LAF - The right side border is not shown for the Spinner after the removing the buttons Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/basic/BasicSpinnerUI.java + test/javax/swing/JSpinner/6532833/bug6532833.java Changeset: 2c3c88a389b0 Author: amenkov Date: 2010-12-28 16:37 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2c3c88a389b0 6842956: Assertion error in javax_sound on 64-bit RHEL 5.3 with 32-bit JDK Reviewed-by: bae ! src/solaris/native/com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_MidiIn.c Changeset: ac1e3f99a69e Author: amenkov Date: 2010-12-29 16:26 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ac1e3f99a69e 7006997: A typo in MidiSystem.getTransmitter() implementation code Reviewed-by: dav ! src/share/classes/javax/sound/midi/MidiSystem.java Changeset: be27227ff554 Author: amenkov Date: 2010-12-30 14:57 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/be27227ff554 6989702: sound native code compiler warnings Reviewed-by: bae ! src/solaris/native/com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_CommonUtils.c ! src/solaris/native/com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_MidiUtils.c ! src/solaris/native/com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c ! src/solaris/native/com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCMUtils.h ! src/solaris/native/com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_Ports.c Changeset: 349b67ae3e08 Author: lana Date: 2011-01-04 23:41 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/349b67ae3e08 Merge - make/common/internal/BinaryPlugs.gmk ! make/sun/awt/Makefile ! src/share/classes/java/text/MessageFormat.java ! src/share/classes/javax/sound/midi/MidiSystem.java Changeset: fff6fd437f4a Author: lana Date: 2011-01-06 18:03 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fff6fd437f4a Merge Changeset: c4ec4f80f44e Author: lana Date: 2011-01-06 18:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c4ec4f80f44e Merge - test/javax/script/E4XErrorTest.java - test/sun/security/krb5/auto/basic.sh Changeset: 1513e13fae08 Author: lana Date: 2011-01-13 15:03 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1513e13fae08 Merge - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.html - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.java - test/javax/script/E4XErrorTest.java - test/javax/swing/SwingWorker/6480289/bug6480289.java - test/sun/security/krb5/auto/basic.sh Changeset: 8361ef97a0f9 Author: lana Date: 2011-01-14 13:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8361ef97a0f9 Merge Changeset: 9596a600758c Author: lana Date: 2011-01-19 19:00 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9596a600758c Merge - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.html - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.java - test/javax/swing/SwingWorker/6480289/bug6480289.java From lana.steuck at oracle.com Wed Jan 19 21:20:47 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 20 Jan 2011 05:20:47 +0000 Subject: hg: jdk7/tl/langtools: 5 new changesets Message-ID: <20110120052056.A882D47FA3@hg.openjdk.java.net> Changeset: 4b0560c72b52 Author: cl Date: 2011-01-06 20:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4b0560c72b52 Added tag jdk7-b124 for changeset 4868a36f6fd8 ! .hgtags Changeset: 62bdb6767734 Author: cl Date: 2011-01-13 16:44 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/62bdb6767734 Added tag jdk7-b125 for changeset 4b0560c72b52 ! .hgtags Changeset: 20fec1b88bc1 Author: lana Date: 2011-01-13 15:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/20fec1b88bc1 Merge - test/tools/javac/meth/InvokeDyn.java - test/tools/javac/meth/InvokeDynTrans.java Changeset: 438a8ad60f7a Author: lana Date: 2011-01-14 13:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/438a8ad60f7a Merge Changeset: b6f95173e769 Author: lana Date: 2011-01-19 19:01 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b6f95173e769 Merge From chris.hegarty at oracle.com Thu Jan 20 07:24:44 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 20 Jan 2011 15:24:44 +0000 Subject: hg: jdk7/tl/jdk: 7011857: java/util/concurrent/Phaser/FickleRegister.java fails on solaris-sparc Message-ID: <20110120152454.076F747FBD@hg.openjdk.java.net> Changeset: e64b1f11cd0b Author: chegar Date: 2011-01-20 15:23 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e64b1f11cd0b 7011857: java/util/concurrent/Phaser/FickleRegister.java fails on solaris-sparc Summary: Remove from ProblemList, failure resolved by 7009231 Reviewed-by: alanb ! test/ProblemList.txt From vincent.x.ryan at oracle.com Thu Jan 20 11:06:21 2011 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Thu, 20 Jan 2011 19:06:21 +0000 Subject: code review request for CR 6989705: ECC security code native code compiler warnings Message-ID: <4D3887AD.9090607@oracle.com> Hello Alan, Please review the following webrev which removes 100's of nuisance compiler warnings generated by our ECC code: http://rialto.ireland.sun.com/~vinnie/webrevs/jdk7/6989705/webrev/ From vincent.x.ryan at oracle.com Thu Jan 20 11:15:36 2011 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Thu, 20 Jan 2011 19:15:36 +0000 Subject: code review request for CR 6989705: ECC security code native code compiler warnings In-Reply-To: <4D3887AD.9090607@oracle.com> References: <4D3887AD.9090607@oracle.com> Message-ID: <4D3889D8.5060307@oracle.com> On 20/01/2011 19:06, Vincent Ryan wrote: > Hello Alan, > > Please review the following webrev which removes 100's of nuisance compiler > warnings generated by our ECC code: > > http://rialto.ireland.sun.com/~vinnie/webrevs/jdk7/6989705/webrev/ > > Also available at: http://cr.openjdk.java.net/~vinnie/6989705/webrev.00/ From weijun.wang at oracle.com Thu Jan 20 20:25:57 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 21 Jan 2011 12:25:57 +0800 Subject: Relook at 6937978: let keytool -gencert generate the chain Message-ID: <4D390AD5.4020701@oracle.com> Hi Sean Some time ago we enhanced "keytool -gencert" to generate a cert chain, including certicates from the end-entity to the secondary level CA, except the root CA. I have some different opinion now, and think maybe it's better to include the root CA. 1. There is no spec saying a chain cannot include the root CA. In fact, in MSIE's certificate exporting dialog, when p7b format is selected and a chain is exported, it includes the root CA cert. 2. No matter if the root CA cert is there or not, when we call "keytool -importcert" on the chain, if the root CA is already trusted, the reply can be imported silently, and inside the PrivateKeyEntry, the root CA cert will be added anyway. 3. *Here comes the important reason*: If the root CA is not already trusted, "keytool -importcert" command will show a warning asking the user to accept the last cert in the chain. I'm quite sure the user would like to see the root CA info here, but not the secondary CA. The code change will be a simple diff --git a/src/share/classes/sun/security/tools/KeyTool.java b/src/share/classes/sun/security/tools/KeyTool.java --- a/src/share/classes/sun/security/tools/KeyTool.java +++ b/src/share/classes/sun/security/tools/KeyTool.java @@ -1249,9 +1249,7 @@ for (Certificate ca: keyStore.getCertificateChain(alias)) { if (ca instanceof X509Certificate) { X509Certificate xca = (X509Certificate)ca; - if (!isSelfSigned(xca)) { dumpCert(xca, out); - } } } } Thanks Max -------- Original Message -------- Subject: hg: jdk7/tl/jdk: 6937978: let keytool -gencert generate the chain Date: Fri, 16 Apr 2010 02:06:34 +0000 From: Weijun.Wang at Sun.COM To: jdk7-changes at openjdk.java.net, compiler-dev at openjdk.java.net, core-libs-dev at openjdk.java.net, serviceability-dev at openjdk.java.net, security-dev at openjdk.java.net, net-dev at openjdk.java.net Changeset: db4fd2fdf196 Author: weijun Date: 2010-04-16 10:06 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db4fd2fdf196 6937978: let keytool -gencert generate the chain Reviewed-by: mullan ! src/share/classes/sun/security/tools/KeyTool.java ! test/sun/security/tools/keytool/selfissued.sh From mandy.chung at oracle.com Thu Jan 20 22:27:06 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Fri, 21 Jan 2011 06:27:06 +0000 Subject: hg: jdk7/tl: 7013739: jdk_rmi target is missing in the top repo's test/Makefile Message-ID: <20110121062706.6940A47018@hg.openjdk.java.net> Changeset: f722c246ce71 Author: mchung Date: 2011-01-20 22:16 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/f722c246ce71 7013739: jdk_rmi target is missing in the top repo's test/Makefile Reviewed-by: ohair, igor ! test/Makefile From mandy.chung at oracle.com Thu Jan 20 22:27:46 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Fri, 21 Jan 2011 06:27:46 +0000 Subject: hg: jdk7/tl/jdk: 7013739: jdk_rmi target is missing in the top repo's test/Makefile Message-ID: <20110121062807.21C8047019@hg.openjdk.java.net> Changeset: cc195c981ae2 Author: mchung Date: 2011-01-20 22:17 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cc195c981ae2 7013739: jdk_rmi target is missing in the top repo's test/Makefile Reviewed-by: ohair, igor ! test/ProblemList.txt From xuelei.fan at oracle.com Fri Jan 21 00:12:05 2011 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Fri, 21 Jan 2011 16:12:05 +0800 Subject: Relook at 6937978: let keytool -gencert generate the chain In-Reply-To: <4D390AD5.4020701@oracle.com> References: <4D390AD5.4020701@oracle.com> Message-ID: <4D393FD5.9000002@oracle.com> Is there any impact on the return value of KeyStore.getCertificateChain(String)? Andrew On 1/21/2011 12:25 PM, Weijun Wang wrote: > Hi Sean > > Some time ago we enhanced "keytool -gencert" to generate a cert chain, > including certicates from the end-entity to the secondary level CA, > except the root CA. I have some different opinion now, and think maybe > it's better to include the root CA. > > 1. There is no spec saying a chain cannot include the root CA. In fact, > in MSIE's certificate exporting dialog, when p7b format is selected and > a chain is exported, it includes the root CA cert. > > 2. No matter if the root CA cert is there or not, when we call "keytool > -importcert" on the chain, if the root CA is already trusted, the reply > can be imported silently, and inside the PrivateKeyEntry, the root CA > cert will be added anyway. > > 3. *Here comes the important reason*: If the root CA is not already > trusted, "keytool -importcert" command will show a warning asking the > user to accept the last cert in the chain. I'm quite sure the user would > like to see the root CA info here, but not the secondary CA. > > The code change will be a simple > > diff --git a/src/share/classes/sun/security/tools/KeyTool.java > b/src/share/classes/sun/security/tools/KeyTool.java > --- a/src/share/classes/sun/security/tools/KeyTool.java > +++ b/src/share/classes/sun/security/tools/KeyTool.java > @@ -1249,9 +1249,7 @@ > for (Certificate ca: keyStore.getCertificateChain(alias)) { > if (ca instanceof X509Certificate) { > X509Certificate xca = (X509Certificate)ca; > - if (!isSelfSigned(xca)) { > dumpCert(xca, out); > - } > } > } > } > > Thanks > Max > > > > > -------- Original Message -------- > Subject: hg: jdk7/tl/jdk: 6937978: let keytool -gencert generate the chain > Date: Fri, 16 Apr 2010 02:06:34 +0000 > From: Weijun.Wang at Sun.COM > To: jdk7-changes at openjdk.java.net, compiler-dev at openjdk.java.net, > core-libs-dev at openjdk.java.net, serviceability-dev at openjdk.java.net, > security-dev at openjdk.java.net, net-dev at openjdk.java.net > > Changeset: db4fd2fdf196 > Author: weijun > Date: 2010-04-16 10:06 +0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db4fd2fdf196 > > 6937978: let keytool -gencert generate the chain > Reviewed-by: mullan > > ! src/share/classes/sun/security/tools/KeyTool.java > ! test/sun/security/tools/keytool/selfissued.sh > From weijun.wang at oracle.com Fri Jan 21 00:23:32 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 21 Jan 2011 16:23:32 +0800 Subject: Relook at 6937978: let keytool -gencert generate the chain In-Reply-To: <4D393FD5.9000002@oracle.com> References: <4D390AD5.4020701@oracle.com> <4D393FD5.9000002@oracle.com> Message-ID: <4D394284.803@oracle.com> On 01/21/2011 04:12 PM, Xuelei Fan wrote: > Is there any impact on the return value of > KeyStore.getCertificateChain(String)? Nothing. This method returns what's actually inside the KeyStore entry. My proposal only make the output of "keytool -gencert -file certs" command different. As described in my number 2 reason below, it won't even make any changes to the "keytool -import -file certs" result. Max > > Andrew > > On 1/21/2011 12:25 PM, Weijun Wang wrote: >> Hi Sean >> >> Some time ago we enhanced "keytool -gencert" to generate a cert chain, >> including certicates from the end-entity to the secondary level CA, >> except the root CA. I have some different opinion now, and think maybe >> it's better to include the root CA. >> >> 1. There is no spec saying a chain cannot include the root CA. In fact, >> in MSIE's certificate exporting dialog, when p7b format is selected and >> a chain is exported, it includes the root CA cert. >> >> 2. No matter if the root CA cert is there or not, when we call "keytool >> -importcert" on the chain, if the root CA is already trusted, the reply >> can be imported silently, and inside the PrivateKeyEntry, the root CA >> cert will be added anyway. >> >> 3. *Here comes the important reason*: If the root CA is not already >> trusted, "keytool -importcert" command will show a warning asking the >> user to accept the last cert in the chain. I'm quite sure the user would >> like to see the root CA info here, but not the secondary CA. >> >> The code change will be a simple >> >> diff --git a/src/share/classes/sun/security/tools/KeyTool.java >> b/src/share/classes/sun/security/tools/KeyTool.java >> --- a/src/share/classes/sun/security/tools/KeyTool.java >> +++ b/src/share/classes/sun/security/tools/KeyTool.java >> @@ -1249,9 +1249,7 @@ >> for (Certificate ca: keyStore.getCertificateChain(alias)) { >> if (ca instanceof X509Certificate) { >> X509Certificate xca = (X509Certificate)ca; >> - if (!isSelfSigned(xca)) { >> dumpCert(xca, out); >> - } >> } >> } >> } >> >> Thanks >> Max >> >> >> >> >> -------- Original Message -------- >> Subject: hg: jdk7/tl/jdk: 6937978: let keytool -gencert generate the chain >> Date: Fri, 16 Apr 2010 02:06:34 +0000 >> From: Weijun.Wang at Sun.COM >> To: jdk7-changes at openjdk.java.net, compiler-dev at openjdk.java.net, >> core-libs-dev at openjdk.java.net, serviceability-dev at openjdk.java.net, >> security-dev at openjdk.java.net, net-dev at openjdk.java.net >> >> Changeset: db4fd2fdf196 >> Author: weijun >> Date: 2010-04-16 10:06 +0800 >> URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db4fd2fdf196 >> >> 6937978: let keytool -gencert generate the chain >> Reviewed-by: mullan >> >> ! src/share/classes/sun/security/tools/KeyTool.java >> ! test/sun/security/tools/keytool/selfissued.sh >> > From xuelei.fan at oracle.com Fri Jan 21 00:32:22 2011 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Fri, 21 Jan 2011 16:32:22 +0800 Subject: Relook at 6937978: let keytool -gencert generate the chain In-Reply-To: <4D394284.803@oracle.com> References: <4D390AD5.4020701@oracle.com> <4D393FD5.9000002@oracle.com> <4D394284.803@oracle.com> Message-ID: <4D394496.9030101@oracle.com> OK. Thanks, Xuelei On 1/21/2011 4:23 PM, Weijun Wang wrote: > > > On 01/21/2011 04:12 PM, Xuelei Fan wrote: >> Is there any impact on the return value of >> KeyStore.getCertificateChain(String)? > > Nothing. This method returns what's actually inside the KeyStore entry. > > My proposal only make the output of "keytool -gencert -file certs" > command different. As described in my number 2 reason below, it won't > even make any changes to the "keytool -import -file certs" result. > > Max > >> >> Andrew >> >> On 1/21/2011 12:25 PM, Weijun Wang wrote: >>> Hi Sean >>> >>> Some time ago we enhanced "keytool -gencert" to generate a cert chain, >>> including certicates from the end-entity to the secondary level CA, >>> except the root CA. I have some different opinion now, and think maybe >>> it's better to include the root CA. >>> >>> 1. There is no spec saying a chain cannot include the root CA. In fact, >>> in MSIE's certificate exporting dialog, when p7b format is selected and >>> a chain is exported, it includes the root CA cert. >>> >>> 2. No matter if the root CA cert is there or not, when we call "keytool >>> -importcert" on the chain, if the root CA is already trusted, the reply >>> can be imported silently, and inside the PrivateKeyEntry, the root CA >>> cert will be added anyway. >>> >>> 3. *Here comes the important reason*: If the root CA is not already >>> trusted, "keytool -importcert" command will show a warning asking the >>> user to accept the last cert in the chain. I'm quite sure the user would >>> like to see the root CA info here, but not the secondary CA. >>> >>> The code change will be a simple >>> >>> diff --git a/src/share/classes/sun/security/tools/KeyTool.java >>> b/src/share/classes/sun/security/tools/KeyTool.java >>> --- a/src/share/classes/sun/security/tools/KeyTool.java >>> +++ b/src/share/classes/sun/security/tools/KeyTool.java >>> @@ -1249,9 +1249,7 @@ >>> for (Certificate ca: keyStore.getCertificateChain(alias)) { >>> if (ca instanceof X509Certificate) { >>> X509Certificate xca = (X509Certificate)ca; >>> - if (!isSelfSigned(xca)) { >>> dumpCert(xca, out); >>> - } >>> } >>> } >>> } >>> >>> Thanks >>> Max >>> >>> >>> >>> >>> -------- Original Message -------- >>> Subject: hg: jdk7/tl/jdk: 6937978: let keytool -gencert generate the >>> chain >>> Date: Fri, 16 Apr 2010 02:06:34 +0000 >>> From: Weijun.Wang at Sun.COM >>> To: jdk7-changes at openjdk.java.net, compiler-dev at openjdk.java.net, >>> core-libs-dev at openjdk.java.net, serviceability-dev at openjdk.java.net, >>> security-dev at openjdk.java.net, net-dev at openjdk.java.net >>> >>> Changeset: db4fd2fdf196 >>> Author: weijun >>> Date: 2010-04-16 10:06 +0800 >>> URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db4fd2fdf196 >>> >>> 6937978: let keytool -gencert generate the chain >>> Reviewed-by: mullan >>> >>> ! src/share/classes/sun/security/tools/KeyTool.java >>> ! test/sun/security/tools/keytool/selfissued.sh >>> >> From Alan.Bateman at oracle.com Fri Jan 21 06:42:06 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 21 Jan 2011 14:42:06 +0000 Subject: code review request for CR 6989705: ECC security code native code compiler warnings In-Reply-To: <4D3887AD.9090607@oracle.com> References: <4D3887AD.9090607@oracle.com> Message-ID: <4D399B3E.9040707@oracle.com> Vincent Ryan wrote: > Hello Alan, > > Please review the following webrev which removes 100's of nuisance compiler > warnings generated by our ECC code: > > http://rialto.ireland.sun.com/~vinnie/webrevs/jdk7/6989705/webrev/ > > > Getting rid of the #pragmas and the other changes look okay to me. The only concern is the Makefile changes to hide the remaining warnings. Would there be many changes required to address those so that those warnings can be re-enabled? -Alan From vincent.x.ryan at oracle.com Fri Jan 21 07:08:47 2011 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Fri, 21 Jan 2011 15:08:47 +0000 Subject: code review request for CR 6989705: ECC security code native code compiler warnings In-Reply-To: <4D399B3E.9040707@oracle.com> References: <4D3887AD.9090607@oracle.com> <4D399B3E.9040707@oracle.com> Message-ID: <4D39A17F.2080100@oracle.com> On 21/01/2011 14:42, Alan Bateman wrote: > Vincent Ryan wrote: >> Hello Alan, >> >> Please review the following webrev which removes 100's of nuisance compiler >> warnings generated by our ECC code: >> >> http://rialto.ireland.sun.com/~vinnie/webrevs/jdk7/6989705/webrev/ >> >> >> > Getting rid of the #pragmas and the other changes look okay to me. The only > concern is the Makefile changes to hide the remaining warnings. Would there be > many changes required to address those so that those warnings can be re-enabled? > > -Alan The remaining warnings are mostly loss-of-precision warnings - which are safe to inhibit because they are due to wide data types which have been masked down to narrower data types before assignment. I'll take another pass through the code to examine whether any of these warnings can also be eliminated. From chris.hegarty at oracle.com Fri Jan 21 09:05:10 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 21 Jan 2011 17:05:10 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110121170529.A448447034@hg.openjdk.java.net> Changeset: 2a8d1a0a2418 Author: chegar Date: 2011-01-21 17:02 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2a8d1a0a2418 7012768: InetAddress lookupTable leaks/deadlocks when using unsupported name service spi Reviewed-by: alanb, michaelm ! src/share/classes/java/net/InetAddress.java - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java + test/sun/net/InetAddress/nameservice/chaining/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor + test/sun/net/InetAddress/nameservice/chaining/Providers.java + test/sun/net/InetAddress/nameservice/chaining/Simple1NameServiceDescriptor.java + test/sun/net/InetAddress/nameservice/chaining/Simple2NameServiceDescriptor.java + test/sun/net/InetAddress/nameservice/chaining/SimpleNameService.java + test/sun/net/InetAddress/nameservice/deadlock/Hang.java + test/sun/net/InetAddress/nameservice/deadlock/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor + test/sun/net/InetAddress/nameservice/deadlock/ThrowingNameService.java + test/sun/net/InetAddress/nameservice/deadlock/ThrowingNameServiceDescriptor.java + test/sun/net/InetAddress/nameservice/simple/CacheTest.java + test/sun/net/InetAddress/nameservice/simple/DefaultCaching.java + test/sun/net/InetAddress/nameservice/simple/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor + test/sun/net/InetAddress/nameservice/simple/SimpleNameService.java + test/sun/net/InetAddress/nameservice/simple/SimpleNameServiceDescriptor.java Changeset: 6a7b8406a1b9 Author: chegar Date: 2011-01-21 17:04 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6a7b8406a1b9 Merge From kelly.ohair at oracle.com Fri Jan 21 09:11:33 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 21 Jan 2011 09:11:33 -0800 Subject: code review request for CR 6989705: ECC security code native code compiler warnings In-Reply-To: <4D39A17F.2080100@oracle.com> References: <4D3887AD.9090607@oracle.com> <4D399B3E.9040707@oracle.com> <4D39A17F.2080100@oracle.com> Message-ID: On Jan 21, 2011, at 7:08 AM, Vincent Ryan wrote: > On 21/01/2011 14:42, Alan Bateman wrote: >> Vincent Ryan wrote: >>> Hello Alan, >>> >>> Please review the following webrev which removes 100's of nuisance >>> compiler >>> warnings generated by our ECC code: >>> >>> http://rialto.ireland.sun.com/~vinnie/webrevs/jdk7/6989705/webrev/ >>> >>> >>> >> Getting rid of the #pragmas and the other changes look okay to me. >> The only >> concern is the Makefile changes to hide the remaining warnings. >> Would there be >> many changes required to address those so that those warnings can >> be re-enabled? >> >> -Alan > > The remaining warnings are mostly loss-of-precision warnings - which > are safe > to inhibit because they are due to wide data types which have been > masked down > to narrower data types before assignment. I'll take another pass > through the > code to examine whether any of these warnings can also be eliminated. Normally explicit casts tend to get rid of the narrowing warnings, and makes it obvious in the code that we know it is happening and want it to be happening. It's the 'long' type you have to watch out for, on 64bit Windows it's 32bits as I recall. I'm ok with some special cases warnings that we decide we never want to see because they are like 90% useless or broken, but it makes me nervous to just shut down all occurrences if there might be some value to that warning. I know fixing these warnings is a bit of a pain, but I do think it's worth it in the long run. I appreciate all efforts in this area. Thanks. -kto From mandy.chung at oracle.com Fri Jan 21 09:47:11 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Fri, 21 Jan 2011 17:47:11 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110121174730.8E70547037@hg.openjdk.java.net> Changeset: f26d1a7fe4d2 Author: mchung Date: 2011-01-21 09:43 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f26d1a7fe4d2 6912013: Remove the temporary launcher fix to add modules in the bootclasspath Reviewed-by: ksrini ! src/share/bin/java.c ! src/share/bin/java.h ! src/share/classes/sun/launcher/LauncherHelper.java Changeset: 9c18818e7a5f Author: mchung Date: 2011-01-21 09:45 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9c18818e7a5f Merge - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java From Alan.Bateman at oracle.com Fri Jan 21 06:42:06 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 21 Jan 2011 14:42:06 +0000 Subject: code review request for CR 6989705: ECC security code native code compiler warnings In-Reply-To: <4D3887AD.9090607@oracle.com> References: <4D3887AD.9090607@oracle.com> Message-ID: <4D399B3E.9040707@oracle.com> Vincent Ryan wrote: > Hello Alan, > > Please review the following webrev which removes 100's of nuisance compiler > warnings generated by our ECC code: > > http://rialto.ireland.sun.com/~vinnie/webrevs/jdk7/6989705/webrev/ > > > Getting rid of the #pragmas and the other changes look okay to me. The only concern is the Makefile changes to hide the remaining warnings. Would there be many changes required to address those so that those warnings can be re-enabled? -Alan From zhengyu.gu at oracle.com Fri Jan 21 17:09:10 2011 From: zhengyu.gu at oracle.com (zhengyu.gu at oracle.com) Date: Sat, 22 Jan 2011 01:09:10 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110122010930.1992047056@hg.openjdk.java.net> Changeset: 2381e810330b Author: zgu Date: 2011-01-20 10:45 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2381e810330b 6983248: net/net001 and net/net003 fail on WinXP with JDK7-B108 Summary: Using closesocket to close socket handler to avoid invalid C runtime parameter exception. Reviewed-by: alanb, phh, dcubed, dsamersoff, coleenp, acorn ! src/windows/demo/jvmti/hprof/hprof_md.c Changeset: d03e47de3a89 Author: zgu Date: 2011-01-21 11:38 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d03e47de3a89 Merge From paul.hohensee at oracle.com Sat Jan 22 10:11:53 2011 From: paul.hohensee at oracle.com (paul.hohensee at oracle.com) Date: Sat, 22 Jan 2011 18:11:53 +0000 Subject: hg: jdk7/tl/jdk: 4 new changesets Message-ID: <20110122181232.2BEE34707D@hg.openjdk.java.net> Changeset: c73c178159d8 Author: phh Date: 2011-01-20 19:34 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c73c178159d8 6173675: M&M: approximate memory allocation rate/amount per thread Summary: Subclass com.sun.management.ThreadMXBean from java.lang.management.ThreadMXBean, add getAllocatedBytes() and friends to c.s.m.ThreadMXBean and have sun.management.ThreadImpl implement c.s.m.ThreadMXBean rather than j.l.m.ThreadMXBean. Reviewed-by: mchung, alanb, dholmes, emcmanus ! make/java/management/mapfile-vers + src/share/classes/com/sun/management/ThreadMXBean.java ! src/share/classes/sun/management/ThreadImpl.java ! src/share/classes/sun/management/VMManagement.java ! src/share/classes/sun/management/VMManagementImpl.java ! src/share/javavm/export/jmm.h ! src/share/native/sun/management/ThreadImpl.c ! src/share/native/sun/management/VMManagementImpl.c + test/com/sun/management/ThreadMXBean/ThreadAllocatedMemory.java + test/com/sun/management/ThreadMXBean/ThreadAllocatedMemoryArray.java + test/com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java Changeset: 64ef2f52d781 Author: phh Date: 2011-01-21 07:29 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/64ef2f52d781 7013682: two test checking cpuTime filed java/lang/management/ThreadMXBean Summary: Typo in 6173675 fix dropped getThreadCpuTime(long) result on the floor. Reviewed-by: mchung, dholmes ! src/share/classes/sun/management/ThreadImpl.java Changeset: cd13b2114f2e Author: phh Date: 2011-01-22 08:42 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cd13b2114f2e Merge ! src/share/classes/sun/management/ThreadImpl.java Changeset: d1365fdfb3ea Author: phh Date: 2011-01-22 08:43 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d1365fdfb3ea Merge - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java From maurizio.cimadamore at oracle.com Mon Jan 24 08:00:33 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Mon, 24 Jan 2011 16:00:33 +0000 Subject: hg: jdk7/tl/langtools: 5 new changesets Message-ID: <20110124160044.AC846470EB@hg.openjdk.java.net> Changeset: 19c900c703c6 Author: mcimadamore Date: 2011-01-24 15:44 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/19c900c703c6 6943278: spurious error message for inference and type-variable with erroneous bound Summary: type-inference should ignore erroneous bounds Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/generics/inference/6943278/T6943278.java + test/tools/javac/generics/inference/6943278/T6943278.out Changeset: ce6175cfe11e Author: mcimadamore Date: 2011-01-24 15:44 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ce6175cfe11e 6968793: issues with diagnostics Summary: several diagnostic improvements Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/6304921/T6304921.out ! test/tools/javac/6330920/T6330920.out ! test/tools/javac/6717241/T6717241a.out ! test/tools/javac/6717241/T6717241b.out ! test/tools/javac/6857948/T6857948.out ! test/tools/javac/6863465/T6863465c.out ! test/tools/javac/6863465/T6863465d.out ! test/tools/javac/T6247324.out ! test/tools/javac/TryWithResources/ResourceOutsideTry.out ! test/tools/javac/diags/examples.not-yet.txt ! test/tools/javac/diags/examples/CantResolve.java ! test/tools/javac/diags/examples/CantResolveArgsParams.java ! test/tools/javac/diags/examples/CantResolveLocation.java ! test/tools/javac/diags/examples/CantResolveLocationArgs.java ! test/tools/javac/diags/examples/CantResolveLocationArgsParams.java - test/tools/javac/diags/examples/EnumConstRequired.java ! test/tools/javac/diags/examples/ForeachNotApplicable.java ! test/tools/javac/diags/examples/KindnameClass.java ! test/tools/javac/diags/examples/KindnameMethod.java ! test/tools/javac/diags/examples/KindnameVariable.java + test/tools/javac/diags/examples/Location.java + test/tools/javac/diags/examples/Location1.java ! test/tools/javac/diags/examples/OperatorCantBeApplied.java + test/tools/javac/diags/examples/OperatorCantBeApplied1.java ! test/tools/javac/diags/examples/StaticImportOnlyClassesAndInterfaces/StaticImportOnlyClassesAndInterfaces.java ! test/tools/javac/failover/FailOver01.out ! test/tools/javac/failover/FailOver02.out ! test/tools/javac/failover/FailOver04.out ! test/tools/javac/generics/6711619/T6711619a.out ! test/tools/javac/generics/diamond/neg/Neg01.out ! test/tools/javac/generics/diamond/neg/Neg02.out ! test/tools/javac/generics/diamond/neg/Neg03.out ! test/tools/javac/generics/diamond/neg/Neg04.out ! test/tools/javac/generics/diamond/neg/Neg11.out ! test/tools/javac/generics/inference/6943278/T6943278.out ! test/tools/javac/generics/typevars/5060485/Compatibility.out ! test/tools/javac/generics/typevars/5060485/Compatibility02.out + test/tools/javac/generics/typevars/6968793/T6968793.java + test/tools/javac/generics/typevars/6968793/T6968793.out ! test/tools/javac/policy/test1/byfile.ABD.out ! test/tools/javac/policy/test1/bytodo.ABD.out ! test/tools/javac/policy/test1/simple.ABD.out Changeset: 02e6e7dd1a64 Author: mcimadamore Date: 2011-01-24 15:45 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/02e6e7dd1a64 6510286: Wording of javac error for inner classes Summary: 'inner classes cannot have static declarations' message needs to be reworked Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/InnerNamedConstant_2.out Changeset: 812c6251ea78 Author: mcimadamore Date: 2011-01-24 15:45 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/812c6251ea78 6569633: Varargs: parser error when varargs element type is an array Summary: explicit error message when old-style array syntax is mixed with varargs Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/VarargsAndOldArraySyntax.java + test/tools/javac/varargs/6569633/T6569633.java + test/tools/javac/varargs/6569633/T6569633.out Changeset: 57e3b9bc7fb8 Author: mcimadamore Date: 2011-01-24 15:45 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/57e3b9bc7fb8 7013865: varargs: javac crashes during overload resolution with generic varargs Summary: fixed regression with varargs overload resolution that leads javac to crash Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/varargs/T7013865.java From xueming.shen at oracle.com Mon Jan 24 11:51:58 2011 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Mon, 24 Jan 2011 19:51:58 +0000 Subject: hg: jdk7/tl/jdk: 7006576: (zipfs) Path.exists() always returns false on dirs when zip/JAR file built without dirs; ... Message-ID: <20110124195208.2CBC5470F4@hg.openjdk.java.net> Changeset: 4cc447291326 Author: sherman Date: 2011-01-24 11:47 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4cc447291326 7006576: (zipfs) Path.exists() always returns false on dirs when zip/JAR file built without dirs 7009092: (zipfs) ZipPath.isSameFile() should always return true if this Path and the given Path are equal. 7009085: (zipfs) ZipPath.normalize("/./.") returns null. 7009102: (zipfs) ZipPath.toRealPath() should always return absolute path. Summary: zip filesystem provider update Reviewed-by: alanb ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipPath.java ! test/demo/zipfs/PathOps.java ! test/demo/zipfs/ZipFSTester.java ! test/demo/zipfs/basic.sh From jonathan.gibbons at oracle.com Mon Jan 24 16:18:02 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 25 Jan 2011 00:18:02 +0000 Subject: hg: jdk7/tl/langtools: 6963934: JCCompilationUnit.getImports does not report all imports Message-ID: <20110125001804.98E73470FF@hg.openjdk.java.net> Changeset: 73ab0b128918 Author: jjg Date: 2011-01-24 16:17 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/73ab0b128918 6963934: JCCompilationUnit.getImports does not report all imports Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/tree/JCTree.java + test/tools/javac/tree/T6963934.java From jonathan.gibbons at oracle.com Mon Jan 24 16:34:45 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 25 Jan 2011 00:34:45 +0000 Subject: hg: jdk7/tl/langtools: 6581775: Fix the white space problem in javac shell tests Message-ID: <20110125003447.2287F47100@hg.openjdk.java.net> Changeset: 22a040cbf0e0 Author: jjg Date: 2011-01-24 16:34 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/22a040cbf0e0 6581775: Fix the white space problem in javac shell tests Reviewed-by: mcimadamore ! test/tools/javac/ClassPathTest/ClassPathTest.sh ! test/tools/javac/ExtDirs/ExtDirs.sh ! test/tools/javac/Paths/Help.sh ! test/tools/javac/javazip/Test.sh ! test/tools/javac/versions/check.sh From jonathan.gibbons at oracle.com Mon Jan 24 16:39:15 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 25 Jan 2011 00:39:15 +0000 Subject: hg: jdk7/tl/langtools: 6988106: javac report 'java.lang.IllegalMonitorStateException' Message-ID: <20110125003917.C4ED947102@hg.openjdk.java.net> Changeset: a8437c34fdc7 Author: jjg Date: 2011-01-24 16:38 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a8437c34fdc7 6988106: javac report 'java.lang.IllegalMonitorStateException' Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/file/CacheFSInfo.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java + src/share/classes/com/sun/tools/javac/file/ZipFileIndexCache.java ! test/tools/javac/T6725036.java From xuelei.fan at oracle.com Mon Jan 24 18:28:36 2011 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Tue, 25 Jan 2011 10:28:36 +0800 Subject: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm In-Reply-To: <4D30C232.4000802@oracle.com> References: <4D2EE43D.4050508@oracle.com> <4D2F22B5.2020103@oracle.com> <4D2F2807.4050908@oracle.com> <4D2F2BF2.6030207@oracle.com> <4D2FBEB9.9020103@oracle.com> <4D308833.4030601@oracle.com> <4D3088B9.5010105@oracle.com> <4D30C232.4000802@oracle.com> Message-ID: <4D3E3554.30802@oracle.com> webrev: http://cr.openjdk.java.net/~xuelei/7011497/webrev/ Changed to use X509CertSelector to select the trust certificate. Comparing with the previous webrev, the following files are updated to use X509CertSelector: DistributionPointFetcher.java ForwardBuilder.java PKIXCertPathValidator.java AdaptableX509CertSelector.java You can only review the above updates. Thanks, Xuelei On 1/15/2011 5:37 AM, Sean Mullan wrote: > Hi Andrew, > > Did you consider using the existing X509CertSelector class to match on > the authority key identifier? I actually think this should work, and it > will avoid having to create the AKIDMatchState class. Take a look at the > ForwardBuilder.getMatchingCACerts method towards the end, where it gets > the AuthorityKeyIdentifierExtension. Can you create a similar > X509CertSelector to select the proper trust anchor? > > --Sean > > > On 1/14/11 12:32 PM, Xuelei Fan wrote: >> On 1/15/2011 1:30 AM, Xuelei Fan wrote: >>> Hi Sean, >>> >>> webrev: >> http://cr.openjdk.java.net/~xuelei/7011497/webrev/ >> >>> Would you please review the update again. I integrate the fix for >>> 7011497 and 7012357 together. >>> >>> Comparing with previous webrev, the following updates are unchanged: >>> src/share/classes/java/security/cert/CertPathValidatorException.java >>> src/share/classes/sun/security/provider/certpath/AlgorithmChecker.java >>> src/share/classes/sun/security/validator/SimpleValidator.java >>> other test files. >>> >>> >>> The following are new changes for CR 7012357: >>> src/share/classes/sun/security/provider/certpath/ForwardBuilder.java >>> src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java >>> >>> test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorEndEntity.java >>> >>> >>> >>> Thanks, >>> Xuelei >>> >>> On 1/14/2011 11:10 AM, Xuelei Fan wrote: >>>> We don't checking the SKID and AKID during searching for the trust >>>> anchor. >>>> >>>> I have filled a new CR for the issue, 7012357, Improve trust anchor >>>> searching method during cert path validation. >>>> >>>> I will have this commented out block in CPValidatorEndEntity.java. I >>>> will use this test case for CR 7012357. >>>> >>>> Thanks, >>>> Xuelei >>>> >>>> On 1/14/2011 12:44 AM, Xuelei Fan wrote: >>>>> I just realized, if subject KID and issuer KID works, the cert path >>>>> validation should be able to find the proper trust anchor. I will >>>>> look >>>>> into the issue tomorrow. >>>>> >>>>> Xuelei >>>>> >>>>> On 1/14/2011 12:27 AM, Xuelei Fan wrote: >>>>>> On 1/14/2011 12:05 AM, Sean Mullan wrote: >>>>>>> On 1/13/11 6:38 AM, Xuelei Fan wrote: >>>>>>>> Hi Sean, >>>>>>>> >>>>>>>> Would you please review the fix for CR 7011497? >>>>>>>> >>>>>>>> http://cr.openjdk.java.net/~xuelei/7011497/webrev/ >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Xuelei >>>>>>> >>>>>>> CPValidatorEndEntity.java: >>>>>>> >>>>>>> 307 /* coment out useless trust anchor >>>>>>> 308 is = new >>>>>>> ByteArrayInputStream(trustAnchor_SHA1withRSA_512.getBytes()); >>>>>>> 309 cert = cf.generateCertificate(is); >>>>>>> 310 anchor = new TrustAnchor((X509Certificate)cert, null); >>>>>>> 311 anchors.add(anchor); >>>>>>> 312 */ >>>>>>> >>>>>>> Why do you leave this code in with this comment? >>>>>>> >>>>>> If I have this block. The cert path validation cannot find the proper >>>>>> trust anchor. As there are two trusted certificates, they are >>>>>> almost the >>>>>> same except the key size (one key size is 1024, another one is 512). >>>>>> >>>>>> In cert path validation, once a trust anchor found, if the >>>>>> signature is >>>>>> not valid, I think no more effort to test more trust anchors. >>>>>> >>>>>> I was wondering whether it is worthy to try more trust anchors. It's >>>>>> expensive! >>>>>> >>>>>> Thanks for the review. >>>>>> >>>>>> Xuelei >>>>>> >>>>>>> Otherwise, looks good. >>>>>>> >>>>>>> --Sean >>>>>> >>>>> >>>> >>> >> From joe.darcy at oracle.com Mon Jan 24 20:05:01 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 25 Jan 2011 04:05:01 +0000 Subject: hg: jdk7/tl/jdk: 7006578: Project Coin: Retrofit JDK libraries with @SafeVarargs Message-ID: <20110125040510.DB26047113@hg.openjdk.java.net> Changeset: dbfc1e419cb2 Author: darcy Date: 2011-01-24 20:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dbfc1e419cb2 7006578: Project Coin: Retrofit JDK libraries with @SafeVarargs Reviewed-by: mduigou, alexp ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/EnumSet.java ! src/share/classes/javax/swing/SwingWorker.java ! src/share/classes/sun/swing/AccumulativeRunnable.java From sean.mullan at oracle.com Tue Jan 25 06:44:35 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 25 Jan 2011 09:44:35 -0500 Subject: Relook at 6937978: let keytool -gencert generate the chain In-Reply-To: <4D390AD5.4020701@oracle.com> References: <4D390AD5.4020701@oracle.com> Message-ID: <4D3EE1D3.2050905@oracle.com> Hi Max, For #3 below, have you considered whether it would be better to enhance keytool -import to recognize (without prompting) chains that don't include the trust anchor, but contain a certificate issued directly by one of the trust anchors in the cacerts file? That seems to be a more flexible solution to me since it accomodates chains with or without a root certificate. --Sean On 1/20/11 11:25 PM, Weijun Wang wrote: > Hi Sean > > Some time ago we enhanced "keytool -gencert" to generate a cert chain, including > certicates from the end-entity to the secondary level CA, except the root CA. I > have some different opinion now, and think maybe it's better to include the root > CA. > > 1. There is no spec saying a chain cannot include the root CA. In fact, in > MSIE's certificate exporting dialog, when p7b format is selected and a chain is > exported, it includes the root CA cert. > > 2. No matter if the root CA cert is there or not, when we call "keytool > -importcert" on the chain, if the root CA is already trusted, the reply can be > imported silently, and inside the PrivateKeyEntry, the root CA cert will be > added anyway. > > 3. *Here comes the important reason*: If the root CA is not already trusted, > "keytool -importcert" command will show a warning asking the user to accept the > last cert in the chain. I'm quite sure the user would like to see the root CA > info here, but not the secondary CA. > > The code change will be a simple > > diff --git a/src/share/classes/sun/security/tools/KeyTool.java > b/src/share/classes/sun/security/tools/KeyTool.java > --- a/src/share/classes/sun/security/tools/KeyTool.java > +++ b/src/share/classes/sun/security/tools/KeyTool.java > @@ -1249,9 +1249,7 @@ > for (Certificate ca: keyStore.getCertificateChain(alias)) { > if (ca instanceof X509Certificate) { > X509Certificate xca = (X509Certificate)ca; > - if (!isSelfSigned(xca)) { > dumpCert(xca, out); > - } > } > } > } > > Thanks > Max > > > > > -------- Original Message -------- > Subject: hg: jdk7/tl/jdk: 6937978: let keytool -gencert generate the chain > Date: Fri, 16 Apr 2010 02:06:34 +0000 > From: Weijun.Wang at Sun.COM > To: jdk7-changes at openjdk.java.net, compiler-dev at openjdk.java.net, > core-libs-dev at openjdk.java.net, serviceability-dev at openjdk.java.net, > security-dev at openjdk.java.net, net-dev at openjdk.java.net > > Changeset: db4fd2fdf196 > Author: weijun > Date: 2010-04-16 10:06 +0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db4fd2fdf196 > > 6937978: let keytool -gencert generate the chain > Reviewed-by: mullan > > ! src/share/classes/sun/security/tools/KeyTool.java > ! test/sun/security/tools/keytool/selfissued.sh > From weijun.wang at oracle.com Tue Jan 25 07:09:37 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 25 Jan 2011 23:09:37 +0800 Subject: Relook at 6937978: let keytool -gencert generate the chain In-Reply-To: <4D3EE1D3.2050905@oracle.com> References: <4D390AD5.4020701@oracle.com> <4D3EE1D3.2050905@oracle.com> Message-ID: <4D3EE7B1.2010001@oracle.com> On 01/25/2011 10:44 PM, Sean Mullan wrote: > Hi Max, > > For #3 below, have you considered whether it would be better to enhance > keytool -import to recognize (without prompting) chains that don't > include the trust anchor, but contain a certificate issued directly by > one of the trust anchors in the cacerts file? That seems to be a more > flexible solution to me since it accomodates chains with or without a > root certificate. This is what we are doing now: If the last cert in the chain is issued by (or itself being) a cert in this keystore or cacerts (if -trustcacerts is provided), the reply will be imported silently. My concern is that if the above is not true, the last cert will be printed on the screen and there will be a prompt. I hope this printed cert is a root CA cert, since normally only the root CA cert is published for user lookup. Max > > --Sean > > On 1/20/11 11:25 PM, Weijun Wang wrote: >> Hi Sean >> >> Some time ago we enhanced "keytool -gencert" to generate a cert chain, >> including >> certicates from the end-entity to the secondary level CA, except the >> root CA. I >> have some different opinion now, and think maybe it's better to >> include the root >> CA. >> >> 1. There is no spec saying a chain cannot include the root CA. In >> fact, in >> MSIE's certificate exporting dialog, when p7b format is selected and a >> chain is >> exported, it includes the root CA cert. >> >> 2. No matter if the root CA cert is there or not, when we call "keytool >> -importcert" on the chain, if the root CA is already trusted, the >> reply can be >> imported silently, and inside the PrivateKeyEntry, the root CA cert >> will be >> added anyway. >> >> 3. *Here comes the important reason*: If the root CA is not already >> trusted, >> "keytool -importcert" command will show a warning asking the user to >> accept the >> last cert in the chain. I'm quite sure the user would like to see the >> root CA >> info here, but not the secondary CA. >> >> The code change will be a simple >> >> diff --git a/src/share/classes/sun/security/tools/KeyTool.java >> b/src/share/classes/sun/security/tools/KeyTool.java >> --- a/src/share/classes/sun/security/tools/KeyTool.java >> +++ b/src/share/classes/sun/security/tools/KeyTool.java >> @@ -1249,9 +1249,7 @@ >> for (Certificate ca: keyStore.getCertificateChain(alias)) { >> if (ca instanceof X509Certificate) { >> X509Certificate xca = (X509Certificate)ca; >> - if (!isSelfSigned(xca)) { >> dumpCert(xca, out); >> - } >> } >> } >> } >> >> Thanks >> Max >> >> >> >> >> -------- Original Message -------- >> Subject: hg: jdk7/tl/jdk: 6937978: let keytool -gencert generate the >> chain >> Date: Fri, 16 Apr 2010 02:06:34 +0000 >> From: Weijun.Wang at Sun.COM >> To: jdk7-changes at openjdk.java.net, compiler-dev at openjdk.java.net, >> core-libs-dev at openjdk.java.net, serviceability-dev at openjdk.java.net, >> security-dev at openjdk.java.net, net-dev at openjdk.java.net >> >> Changeset: db4fd2fdf196 >> Author: weijun >> Date: 2010-04-16 10:06 +0800 >> URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db4fd2fdf196 >> >> 6937978: let keytool -gencert generate the chain >> Reviewed-by: mullan >> >> ! src/share/classes/sun/security/tools/KeyTool.java >> ! test/sun/security/tools/keytool/selfissued.sh >> From sean.mullan at oracle.com Tue Jan 25 08:23:55 2011 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Tue, 25 Jan 2011 16:23:55 +0000 Subject: hg: jdk7/tl/jdk: 4 new changesets Message-ID: <20110125162433.AC82447130@hg.openjdk.java.net> Changeset: ae38d1374e31 Author: mullan Date: 2011-01-24 14:56 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ae38d1374e31 5001004: Required Security Algorithms need to be defined Reviewed-by: wetmore ! src/share/classes/java/security/AlgorithmParameterGenerator.java ! src/share/classes/java/security/AlgorithmParameters.java ! src/share/classes/java/security/KeyFactory.java ! src/share/classes/java/security/KeyPairGenerator.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/MessageDigest.java ! src/share/classes/java/security/Policy.java ! src/share/classes/java/security/SecureRandom.java ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/Signature.java ! src/share/classes/java/security/cert/CertPath.java ! src/share/classes/java/security/cert/CertPathBuilder.java ! src/share/classes/java/security/cert/CertPathValidator.java ! src/share/classes/java/security/cert/CertStore.java ! src/share/classes/java/security/cert/Certificate.java ! src/share/classes/java/security/cert/CertificateFactory.java ! src/share/classes/java/security/cert/CertificateFactorySpi.java ! src/share/classes/java/security/cert/package.html ! src/share/classes/java/security/package.html ! src/share/classes/javax/crypto/Cipher.java ! src/share/classes/javax/crypto/ExemptionMechanism.java ! src/share/classes/javax/crypto/KeyAgreement.java ! src/share/classes/javax/crypto/KeyGenerator.java ! src/share/classes/javax/crypto/Mac.java ! src/share/classes/javax/crypto/SecretKeyFactory.java ! src/share/classes/javax/crypto/package.html ! src/share/classes/javax/net/ssl/SSLContext.java ! src/share/classes/javax/net/ssl/package.html ! src/share/classes/javax/security/auth/login/Configuration.java ! src/share/classes/javax/security/auth/login/package.html Changeset: b33e9b15835e Author: mullan Date: 2011-01-24 15:08 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b33e9b15835e Merge - make/common/internal/BinaryPlugs.gmk - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile - src/share/classes/java/dyn/JavaMethodHandle.java - src/share/classes/java/dyn/LinkagePermission.java - src/share/classes/java/nio/channels/AsynchronousDatagramChannel.java ! src/share/classes/java/security/Security.java ! src/share/classes/javax/net/ssl/SSLContext.java - src/share/classes/sun/java2d/pisces/LineSink.java - src/share/classes/sun/net/httpserver/SelectorCache.java - src/share/classes/sun/nio/ch/SimpleAsynchronousDatagramChannelImpl.java - src/share/classes/sun/security/krb5/KrbKdcReq.java - src/share/classes/sun/security/krb5/internal/TCPClient.java - src/share/classes/sun/security/krb5/internal/UDPClient.java - src/share/demo/nio/zipfs/META-INF/services/java.nio.file.spi.FileSystemProvider - src/share/demo/nio/zipfs/com/sun/nio/zipfs/JarFileSystemProvider.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipCoder.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipConstants.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipDirectoryStream.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileAttributeView.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileAttributes.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileStore.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileSystem.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileSystemProvider.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipInfo.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipPath.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipUtils.java - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/share/native/sun/font/layout/HebrewLigatureData.cpp - src/share/native/sun/font/layout/HebrewShaping.cpp - src/share/native/sun/font/layout/HebrewShaping.h - src/solaris/classes/sun/net/www/protocol/http/NTLMAuthentication.java - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.html - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.java - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/java/nio/channels/AsynchronousDatagramChannel/Basic.java - test/javax/script/E4XErrorTest.java - test/javax/swing/SwingWorker/6480289/bug6480289.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java - test/sun/security/krb5/auto/basic.sh Changeset: 6ac9383640c6 Author: mullan Date: 2011-01-24 15:46 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6ac9383640c6 Merge Changeset: 6e7bed89ce84 Author: mullan Date: 2011-01-25 08:41 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6e7bed89ce84 Merge From sean.mullan at oracle.com Tue Jan 25 10:50:36 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 25 Jan 2011 13:50:36 -0500 Subject: Relook at 6937978: let keytool -gencert generate the chain In-Reply-To: <4D3EE7B1.2010001@oracle.com> References: <4D390AD5.4020701@oracle.com> <4D3EE1D3.2050905@oracle.com> <4D3EE7B1.2010001@oracle.com> Message-ID: <4D3F1B7C.1020706@oracle.com> On 1/25/11 10:09 AM, Weijun Wang wrote: > > > On 01/25/2011 10:44 PM, Sean Mullan wrote: >> Hi Max, >> >> For #3 below, have you considered whether it would be better to enhance >> keytool -import to recognize (without prompting) chains that don't >> include the trust anchor, but contain a certificate issued directly by >> one of the trust anchors in the cacerts file? That seems to be a more >> flexible solution to me since it accomodates chains with or without a >> root certificate. > > This is what we are doing now: If the last cert in the chain is issued by (or > itself being) a cert in this keystore or cacerts (if -trustcacerts is provided), > the reply will be imported silently. > > My concern is that if the above is not true, the last cert will be printed on > the screen and there will be a prompt. I hope this printed cert is a root CA > cert, since normally only the root CA cert is published for user lookup. I see your point about the potential confusion to the user. The gencert command is quite useful for creating test certificate chains with test CAs, so I can also see how exclusion of the root CA cert would cause some inconvenience. So, I think I agree that we should change it to include the root CA certificate, especially if most tools/browsers do the same. Do you have any other data besides IE? --Sean > > Max > >> >> --Sean >> >> On 1/20/11 11:25 PM, Weijun Wang wrote: >>> Hi Sean >>> >>> Some time ago we enhanced "keytool -gencert" to generate a cert chain, >>> including >>> certicates from the end-entity to the secondary level CA, except the >>> root CA. I >>> have some different opinion now, and think maybe it's better to >>> include the root >>> CA. >>> >>> 1. There is no spec saying a chain cannot include the root CA. In >>> fact, in >>> MSIE's certificate exporting dialog, when p7b format is selected and a >>> chain is >>> exported, it includes the root CA cert. >>> >>> 2. No matter if the root CA cert is there or not, when we call "keytool >>> -importcert" on the chain, if the root CA is already trusted, the >>> reply can be >>> imported silently, and inside the PrivateKeyEntry, the root CA cert >>> will be >>> added anyway. >>> >>> 3. *Here comes the important reason*: If the root CA is not already >>> trusted, >>> "keytool -importcert" command will show a warning asking the user to >>> accept the >>> last cert in the chain. I'm quite sure the user would like to see the >>> root CA >>> info here, but not the secondary CA. >>> >>> The code change will be a simple >>> >>> diff --git a/src/share/classes/sun/security/tools/KeyTool.java >>> b/src/share/classes/sun/security/tools/KeyTool.java >>> --- a/src/share/classes/sun/security/tools/KeyTool.java >>> +++ b/src/share/classes/sun/security/tools/KeyTool.java >>> @@ -1249,9 +1249,7 @@ >>> for (Certificate ca: keyStore.getCertificateChain(alias)) { >>> if (ca instanceof X509Certificate) { >>> X509Certificate xca = (X509Certificate)ca; >>> - if (!isSelfSigned(xca)) { >>> dumpCert(xca, out); >>> - } >>> } >>> } >>> } >>> >>> Thanks >>> Max >>> >>> >>> >>> >>> -------- Original Message -------- >>> Subject: hg: jdk7/tl/jdk: 6937978: let keytool -gencert generate the >>> chain >>> Date: Fri, 16 Apr 2010 02:06:34 +0000 >>> From: Weijun.Wang at Sun.COM >>> To: jdk7-changes at openjdk.java.net, compiler-dev at openjdk.java.net, >>> core-libs-dev at openjdk.java.net, serviceability-dev at openjdk.java.net, >>> security-dev at openjdk.java.net, net-dev at openjdk.java.net >>> >>> Changeset: db4fd2fdf196 >>> Author: weijun >>> Date: 2010-04-16 10:06 +0800 >>> URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db4fd2fdf196 >>> >>> 6937978: let keytool -gencert generate the chain >>> Reviewed-by: mullan >>> >>> ! src/share/classes/sun/security/tools/KeyTool.java >>> ! test/sun/security/tools/keytool/selfissued.sh >>> From joe.darcy at oracle.com Tue Jan 25 17:03:21 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 26 Jan 2011 01:03:21 +0000 Subject: hg: jdk7/tl/langtools: 7013420: Project Coin: remove general expression support from try-with-resources statement Message-ID: <20110126010324.AF3FA4714A@hg.openjdk.java.net> Changeset: 7f8794f9cc14 Author: darcy Date: 2011-01-25 17:02 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7f8794f9cc14 7013420: Project Coin: remove general expression support from try-with-resources statement Reviewed-by: mcimadamore, jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/TryWithResources/BadTwrSyntax.out ! test/tools/javac/TryWithResources/DuplicateResource.java + test/tools/javac/TryWithResources/ExplicitFinal.java ! test/tools/javac/TryWithResources/ImplicitFinal.java ! test/tools/javac/TryWithResources/ImplicitFinal.out ! test/tools/javac/TryWithResources/TwrFlow.java ! test/tools/javac/TryWithResources/TwrFlow.out - test/tools/javac/TryWithResources/TwrInference.java - test/tools/javac/TryWithResources/TwrIntersection.java - test/tools/javac/TryWithResources/TwrIntersection02.java - test/tools/javac/TryWithResources/TwrIntersection02.out ! test/tools/javac/TryWithResources/TwrMultiCatch.java ! test/tools/javac/TryWithResources/TwrOnNonResource.java ! test/tools/javac/TryWithResources/TwrOnNonResource.out + test/tools/javac/diags/examples/TryResourceTrailingSemi.java From weijun.wang at oracle.com Tue Jan 25 22:58:56 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 26 Jan 2011 14:58:56 +0800 Subject: Relook at 6937978: let keytool -gencert generate the chain In-Reply-To: <4D3F1B7C.1020706@oracle.com> References: <4D390AD5.4020701@oracle.com> <4D3EE1D3.2050905@oracle.com> <4D3EE7B1.2010001@oracle.com> <4D3F1B7C.1020706@oracle.com> Message-ID: <4D3FC630.9090408@oracle.com> > So, I think I agree that we should change it to include the root CA > certificate, especially if most tools/browsers do the same. Do you > have any other data besides IE? Firefox also exports a full chain if PKCS #7 or PKCS #12 is selected. Chrome only exports to a PKCS #12 file, and the chain is also complete. It's a shame I haven't seen a cert request reply from a real CA. :( Here's the webrev, please take a look: http://cr.openjdk.java.net/~weijun/7014799/webrev.00/ I've added a check: + if (ca.getPublicKey().equals(cert.getPublicKey())) { + break; } Now if A signs B and B signs A again, there would be a loop. This should seldom happen I guess. Thanks Max On 01/26/2011 02:50 AM, Sean Mullan wrote: > On 1/25/11 10:09 AM, Weijun Wang wrote: >> >> >> On 01/25/2011 10:44 PM, Sean Mullan wrote: >>> Hi Max, >>> >>> For #3 below, have you considered whether it would be better to >>> enhance keytool -import to recognize (without prompting) chains >>> that don't include the trust anchor, but contain a certificate >>> issued directly by one of the trust anchors in the cacerts file? >>> That seems to be a more flexible solution to me since it >>> accomodates chains with or without a root certificate. >> >> This is what we are doing now: If the last cert in the chain is >> issued by (or itself being) a cert in this keystore or cacerts (if >> -trustcacerts is provided), the reply will be imported silently. >> >> My concern is that if the above is not true, the last cert will be >> printed on the screen and there will be a prompt. I hope this >> printed cert is a root CA cert, since normally only the root CA >> cert is published for user lookup. > > I see your point about the potential confusion to the user. The > gencert command is quite useful for creating test certificate chains > with test CAs, so I can also see how exclusion of the root CA cert > would cause some inconvenience. > > So, I think I agree that we should change it to include the root CA > certificate, especially if most tools/browsers do the same. Do you > have any other data besides IE? > > --Sean > >> >> Max >> >>> >>> --Sean >>> >>> On 1/20/11 11:25 PM, Weijun Wang wrote: >>>> Hi Sean >>>> >>>> Some time ago we enhanced "keytool -gencert" to generate a cert >>>> chain, including certicates from the end-entity to the >>>> secondary level CA, except the root CA. I have some different >>>> opinion now, and think maybe it's better to include the root >>>> CA. >>>> >>>> 1. There is no spec saying a chain cannot include the root CA. >>>> In fact, in MSIE's certificate exporting dialog, when p7b >>>> format is selected and a chain is exported, it includes the >>>> root CA cert. >>>> >>>> 2. No matter if the root CA cert is there or not, when we call >>>> "keytool -importcert" on the chain, if the root CA is already >>>> trusted, the reply can be imported silently, and inside the >>>> PrivateKeyEntry, the root CA cert will be added anyway. >>>> >>>> 3. *Here comes the important reason*: If the root CA is not >>>> already trusted, "keytool -importcert" command will show a >>>> warning asking the user to accept the last cert in the chain. >>>> I'm quite sure the user would like to see the root CA info >>>> here, but not the secondary CA. >>>> >>>> The code change will be a simple >>>> >>>> diff --git a/src/share/classes/sun/security/tools/KeyTool.java >>>> b/src/share/classes/sun/security/tools/KeyTool.java --- >>>> a/src/share/classes/sun/security/tools/KeyTool.java +++ >>>> b/src/share/classes/sun/security/tools/KeyTool.java @@ -1249,9 >>>> +1249,7 @@ for (Certificate ca: >>>> keyStore.getCertificateChain(alias)) { if (ca instanceof >>>> X509Certificate) { X509Certificate xca = (X509Certificate)ca; - >>>> if (!isSelfSigned(xca)) { dumpCert(xca, out); - } } } } >>>> >>>> Thanks Max >>>> >>>> >>>> >>>> >>>> -------- Original Message -------- Subject: hg: jdk7/tl/jdk: >>>> 6937978: let keytool -gencert generate the chain Date: Fri, 16 >>>> Apr 2010 02:06:34 +0000 From: Weijun.Wang at Sun.COM To: >>>> jdk7-changes at openjdk.java.net, compiler-dev at openjdk.java.net, >>>> core-libs-dev at openjdk.java.net, >>>> serviceability-dev at openjdk.java.net, >>>> security-dev at openjdk.java.net, net-dev at openjdk.java.net >>>> >>>> Changeset: db4fd2fdf196 Author: weijun Date: 2010-04-16 10:06 >>>> +0800 URL: >>>> http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db4fd2fdf196 >>>> >>>> 6937978: let keytool -gencert generate the chain Reviewed-by: >>>> mullan >>>> >>>> ! src/share/classes/sun/security/tools/KeyTool.java ! >>>> test/sun/security/tools/keytool/selfissued.sh >>>> From sean.mullan at oracle.com Wed Jan 26 06:32:38 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 26 Jan 2011 09:32:38 -0500 Subject: Relook at 6937978: let keytool -gencert generate the chain In-Reply-To: <4D3FC630.9090408@oracle.com> References: <4D390AD5.4020701@oracle.com> <4D3EE1D3.2050905@oracle.com> <4D3EE7B1.2010001@oracle.com> <4D3F1B7C.1020706@oracle.com> <4D3FC630.9090408@oracle.com> Message-ID: <4D403086.9050500@oracle.com> On 1/26/11 1:58 AM, Weijun Wang wrote: >> So, I think I agree that we should change it to include the root CA >> certificate, especially if most tools/browsers do the same. Do you >> have any other data besides IE? > > Firefox also exports a full chain if PKCS #7 or PKCS #12 is selected. Chrome > only exports to a PKCS #12 file, and the chain is also complete. > > It's a shame I haven't seen a cert request reply from a real CA. :( > > Here's the webrev, please take a look: > > http://cr.openjdk.java.net/~weijun/7014799/webrev.00/ The fix looks fine. --Sean > > I've added a check: > > + if (ca.getPublicKey().equals(cert.getPublicKey())) { > + break; > } > > Now if A signs B and B signs A again, there would be a loop. This should seldom > happen I guess. > > Thanks > Max > > > On 01/26/2011 02:50 AM, Sean Mullan wrote: >> On 1/25/11 10:09 AM, Weijun Wang wrote: >>> >>> >>> On 01/25/2011 10:44 PM, Sean Mullan wrote: >>>> Hi Max, >>>> >>>> For #3 below, have you considered whether it would be better to >>>> enhance keytool -import to recognize (without prompting) chains >>>> that don't include the trust anchor, but contain a certificate >>>> issued directly by one of the trust anchors in the cacerts file? >>>> That seems to be a more flexible solution to me since it >>>> accomodates chains with or without a root certificate. >>> >>> This is what we are doing now: If the last cert in the chain is >>> issued by (or itself being) a cert in this keystore or cacerts (if >>> -trustcacerts is provided), the reply will be imported silently. >>> >>> My concern is that if the above is not true, the last cert will be >>> printed on the screen and there will be a prompt. I hope this >>> printed cert is a root CA cert, since normally only the root CA >>> cert is published for user lookup. >> >> I see your point about the potential confusion to the user. The >> gencert command is quite useful for creating test certificate chains >> with test CAs, so I can also see how exclusion of the root CA cert >> would cause some inconvenience. >> >> So, I think I agree that we should change it to include the root CA >> certificate, especially if most tools/browsers do the same. Do you >> have any other data besides IE? >> >> --Sean >> >>> >>> Max >>> >>>> >>>> --Sean >>>> >>>> On 1/20/11 11:25 PM, Weijun Wang wrote: >>>>> Hi Sean >>>>> >>>>> Some time ago we enhanced "keytool -gencert" to generate a cert >>>>> chain, including certicates from the end-entity to the >>>>> secondary level CA, except the root CA. I have some different >>>>> opinion now, and think maybe it's better to include the root >>>>> CA. >>>>> >>>>> 1. There is no spec saying a chain cannot include the root CA. >>>>> In fact, in MSIE's certificate exporting dialog, when p7b >>>>> format is selected and a chain is exported, it includes the >>>>> root CA cert. >>>>> >>>>> 2. No matter if the root CA cert is there or not, when we call >>>>> "keytool -importcert" on the chain, if the root CA is already >>>>> trusted, the reply can be imported silently, and inside the >>>>> PrivateKeyEntry, the root CA cert will be added anyway. >>>>> >>>>> 3. *Here comes the important reason*: If the root CA is not >>>>> already trusted, "keytool -importcert" command will show a >>>>> warning asking the user to accept the last cert in the chain. >>>>> I'm quite sure the user would like to see the root CA info >>>>> here, but not the secondary CA. >>>>> >>>>> The code change will be a simple >>>>> >>>>> diff --git a/src/share/classes/sun/security/tools/KeyTool.java >>>>> b/src/share/classes/sun/security/tools/KeyTool.java --- >>>>> a/src/share/classes/sun/security/tools/KeyTool.java +++ >>>>> b/src/share/classes/sun/security/tools/KeyTool.java @@ -1249,9 >>>>> +1249,7 @@ for (Certificate ca: >>>>> keyStore.getCertificateChain(alias)) { if (ca instanceof >>>>> X509Certificate) { X509Certificate xca = (X509Certificate)ca; - >>>>> if (!isSelfSigned(xca)) { dumpCert(xca, out); - } } } } >>>>> >>>>> Thanks Max >>>>> >>>>> >>>>> >>>>> >>>>> -------- Original Message -------- Subject: hg: jdk7/tl/jdk: >>>>> 6937978: let keytool -gencert generate the chain Date: Fri, 16 >>>>> Apr 2010 02:06:34 +0000 From: Weijun.Wang at Sun.COM To: >>>>> jdk7-changes at openjdk.java.net, compiler-dev at openjdk.java.net, >>>>> core-libs-dev at openjdk.java.net, >>>>> serviceability-dev at openjdk.java.net, >>>>> security-dev at openjdk.java.net, net-dev at openjdk.java.net >>>>> >>>>> Changeset: db4fd2fdf196 Author: weijun Date: 2010-04-16 10:06 >>>>> +0800 URL: >>>>> http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db4fd2fdf196 >>>>> >>>>> 6937978: let keytool -gencert generate the chain Reviewed-by: >>>>> mullan >>>>> >>>>> ! src/share/classes/sun/security/tools/KeyTool.java ! >>>>> test/sun/security/tools/keytool/selfissued.sh >>>>> From sean.mullan at oracle.com Wed Jan 26 09:41:29 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 26 Jan 2011 12:41:29 -0500 Subject: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm In-Reply-To: <4D3E3554.30802@oracle.com> References: <4D2EE43D.4050508@oracle.com> <4D2F22B5.2020103@oracle.com> <4D2F2807.4050908@oracle.com> <4D2F2BF2.6030207@oracle.com> <4D2FBEB9.9020103@oracle.com> <4D308833.4030601@oracle.com> <4D3088B9.5010105@oracle.com> <4D30C232.4000802@oracle.com> <4D3E3554.30802@oracle.com> Message-ID: <4D405CC9.3060108@oracle.com> On 1/24/11 9:28 PM, Xuelei Fan wrote: > webrev: http://cr.openjdk.java.net/~xuelei/7011497/webrev/ > > Changed to use X509CertSelector to select the trust certificate. > Comparing with the previous webrev, the following files are updated to > use X509CertSelector: > DistributionPointFetcher.java > ForwardBuilder.java > PKIXCertPathValidator.java > AdaptableX509CertSelector.java > > You can only review the above updates. * PKIXCertPathValidator [234-238]: these fields are set to null by default. I don't think you need to invoke the set methods. [240,248]: s/trust/trusted [242]: You don't need to check the length of the array here. If X509Certificate.getKeyUsage returned an array of the wrong length then that would be a non-compliant implementation and you should just let the code throw an ArrayIndexOOB exception. * AdaptableX509CertSelector [151-154]: this block could be moved into the previous conditional block since version is < 3. Also, can you explain this block? It seems like you would want to return false (as X509CertSelector.match does) if there is no subject key id, but I assume there is an important use case that I'm missing here. * DistributionPointFetcher [703-707] Same comment as PKIXCertPathValidator[234-238] above. [711] Same comment as PKIXCertPathValidator[242] above. Why did you remove the signature verification check of the CRL that was previously in ForwardBuilder.issues. Is that because we verify it later (line 642)? --Sean > > Thanks, > Xuelei > > On 1/15/2011 5:37 AM, Sean Mullan wrote: >> Hi Andrew, >> >> Did you consider using the existing X509CertSelector class to match on >> the authority key identifier? I actually think this should work, and it >> will avoid having to create the AKIDMatchState class. Take a look at the >> ForwardBuilder.getMatchingCACerts method towards the end, where it gets >> the AuthorityKeyIdentifierExtension. Can you create a similar >> X509CertSelector to select the proper trust anchor? >> >> --Sean >> >> >> On 1/14/11 12:32 PM, Xuelei Fan wrote: >>> On 1/15/2011 1:30 AM, Xuelei Fan wrote: >>>> Hi Sean, >>>> >>>> webrev: >>> http://cr.openjdk.java.net/~xuelei/7011497/webrev/ >>> >>>> Would you please review the update again. I integrate the fix for >>>> 7011497 and 7012357 together. >>>> >>>> Comparing with previous webrev, the following updates are unchanged: >>>> src/share/classes/java/security/cert/CertPathValidatorException.java >>>> src/share/classes/sun/security/provider/certpath/AlgorithmChecker.java >>>> src/share/classes/sun/security/validator/SimpleValidator.java >>>> other test files. >>>> >>>> >>>> The following are new changes for CR 7012357: >>>> src/share/classes/sun/security/provider/certpath/ForwardBuilder.java >>>> src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java >>>> >>>> test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorEndEntity.java >>>> >>>> >>>> >>>> Thanks, >>>> Xuelei >>>> >>>> On 1/14/2011 11:10 AM, Xuelei Fan wrote: >>>>> We don't checking the SKID and AKID during searching for the trust >>>>> anchor. >>>>> >>>>> I have filled a new CR for the issue, 7012357, Improve trust anchor >>>>> searching method during cert path validation. >>>>> >>>>> I will have this commented out block in CPValidatorEndEntity.java. I >>>>> will use this test case for CR 7012357. >>>>> >>>>> Thanks, >>>>> Xuelei >>>>> >>>>> On 1/14/2011 12:44 AM, Xuelei Fan wrote: >>>>>> I just realized, if subject KID and issuer KID works, the cert path >>>>>> validation should be able to find the proper trust anchor. I will >>>>>> look >>>>>> into the issue tomorrow. >>>>>> >>>>>> Xuelei >>>>>> >>>>>> On 1/14/2011 12:27 AM, Xuelei Fan wrote: >>>>>>> On 1/14/2011 12:05 AM, Sean Mullan wrote: >>>>>>>> On 1/13/11 6:38 AM, Xuelei Fan wrote: >>>>>>>>> Hi Sean, >>>>>>>>> >>>>>>>>> Would you please review the fix for CR 7011497? >>>>>>>>> >>>>>>>>> http://cr.openjdk.java.net/~xuelei/7011497/webrev/ >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Xuelei >>>>>>>> >>>>>>>> CPValidatorEndEntity.java: >>>>>>>> >>>>>>>> 307 /* coment out useless trust anchor >>>>>>>> 308 is = new >>>>>>>> ByteArrayInputStream(trustAnchor_SHA1withRSA_512.getBytes()); >>>>>>>> 309 cert = cf.generateCertificate(is); >>>>>>>> 310 anchor = new TrustAnchor((X509Certificate)cert, null); >>>>>>>> 311 anchors.add(anchor); >>>>>>>> 312 */ >>>>>>>> >>>>>>>> Why do you leave this code in with this comment? >>>>>>>> >>>>>>> If I have this block. The cert path validation cannot find the proper >>>>>>> trust anchor. As there are two trusted certificates, they are >>>>>>> almost the >>>>>>> same except the key size (one key size is 1024, another one is 512). >>>>>>> >>>>>>> In cert path validation, once a trust anchor found, if the >>>>>>> signature is >>>>>>> not valid, I think no more effort to test more trust anchors. >>>>>>> >>>>>>> I was wondering whether it is worthy to try more trust anchors. It's >>>>>>> expensive! >>>>>>> >>>>>>> Thanks for the review. >>>>>>> >>>>>>> Xuelei >>>>>>> >>>>>>>> Otherwise, looks good. >>>>>>>> >>>>>>>> --Sean >>>>>>> >>>>>> >>>>> >>>> >>> > From alan.bateman at oracle.com Wed Jan 26 10:02:32 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 26 Jan 2011 18:02:32 +0000 Subject: hg: jdk7/tl/jdk: 7012663: javadoc warning in javax.swing.JComponent and javax.swing.plaf.synth.SynthTextPaneUI Message-ID: <20110126180241.F2FF947171@hg.openjdk.java.net> Changeset: bf1b937076db Author: alanb Date: 2011-01-26 18:01 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bf1b937076db 7012663: javadoc warning in javax.swing.JComponent and javax.swing.plaf.synth.SynthTextPaneUI Reviewed-by: alexp ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/plaf/synth/SynthTextPaneUI.java From jonathan.gibbons at oracle.com Wed Jan 26 11:20:54 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 26 Jan 2011 19:20:54 +0000 Subject: hg: jdk7/tl/langtools: 6554097: "final" confuses @SuppressWarnings Message-ID: <20110126192056.29B2B47174@hg.openjdk.java.net> Changeset: df371fd16386 Author: jjg Date: 2011-01-26 11:20 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/df371fd16386 6554097: "final" confuses @SuppressWarnings Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java + test/tools/javac/T6554097.java + test/tools/javac/T6554097.out From joe.darcy at oracle.com Wed Jan 26 12:32:39 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 26 Jan 2011 20:32:39 +0000 Subject: hg: jdk7/tl/jdk: 7013420: Project Coin: remove general expression support from try-with-resources statement Message-ID: <20110126203249.7183C47178@hg.openjdk.java.net> Changeset: abab55565eda Author: darcy Date: 2011-01-26 12:32 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/abab55565eda 7013420: Project Coin: remove general expression support from try-with-resources statement Reviewed-by: alanb ! test/java/nio/channels/FileChannel/Truncate.java From jonathan.gibbons at oracle.com Wed Jan 26 13:46:00 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 26 Jan 2011 21:46:00 +0000 Subject: hg: jdk7/tl/langtools: 7013272: Automatically generate info about how compiler resource keys are used Message-ID: <20110126214602.DFCAD4717E@hg.openjdk.java.net> Changeset: 3da26790ccb7 Author: jjg Date: 2011-01-26 13:45 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3da26790ccb7 7013272: Automatically generate info about how compiler resource keys are used Reviewed-by: mcimadamore ! make/build.xml ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/ArgTypeCompilerFactory.java ! test/tools/javac/diags/Example.java + test/tools/javac/diags/MessageFile.java + test/tools/javac/diags/MessageInfo.java ! test/tools/javac/diags/RunExamples.java From Xuelei.Fan at Oracle.COM Thu Jan 27 03:43:52 2011 From: Xuelei.Fan at Oracle.COM (Xuelei Fan) Date: Thu, 27 Jan 2011 19:43:52 +0800 Subject: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm In-Reply-To: <4D405CC9.3060108@oracle.com> References: <4D2EE43D.4050508@oracle.com> <4D2F22B5.2020103@oracle.com> <4D2F2807.4050908@oracle.com> <4D2F2BF2.6030207@oracle.com> <4D2FBEB9.9020103@oracle.com> <4D308833.4030601@oracle.com> <4D3088B9.5010105@oracle.com> <4D30C232.4000802@oracle.com> <4D3E3554.30802@oracle.com> <4D405CC9.3060108@oracle.com> Message-ID: <4D415A78.5020501@Oracle.COM> webrev: http://cr.openjdk.java.net/~xuelei/7011497/webrev/ On 1/27/2011 1:41 AM, Sean Mullan wrote: > On 1/24/11 9:28 PM, Xuelei Fan wrote: >> webrev: http://cr.openjdk.java.net/~xuelei/7011497/webrev/ >> >> Changed to use X509CertSelector to select the trust certificate. >> Comparing with the previous webrev, the following files are updated to >> use X509CertSelector: >> DistributionPointFetcher.java >> ForwardBuilder.java >> PKIXCertPathValidator.java >> AdaptableX509CertSelector.java >> >> You can only review the above updates. > > * PKIXCertPathValidator > > [234-238]: these fields are set to null by default. I don't think you > need to invoke the set methods. Yes. But in order to remind that we don't want to check the validity, I have one line comment: "// no certificate and private key valid check for trusted certificate" > > [240,248]: s/trust/trusted > Updated. > [242]: You don't need to check the length of the array here. If > X509Certificate.getKeyUsage returned an array of the wrong length then > that would be a non-compliant implementation and you should just let > the code throw an ArrayIndexOOB exception. > Good catch. I don't like runtime exception here, as it expose to DOS attack if the client send improper data. I updated the code to throw CRLException or CertPathValidatorException, "Encounter non-compliant X.509 certificate: no enought KeyUsage bits". Does it sound reasonable to you? > * AdaptableX509CertSelector > > [151-154]: this block could be moved into the previous conditional > block since version is < 3. Also, can you explain this block? It seems > like you would want to return false (as X509CertSelector.match does) > if there is no subject key id, but I assume there is an important use > case that I'm missing here. > Ooops, there was a mistake in my code. The logic connector should be "||" but not "&&": - 151 if (version< 3&& xcert.getExtensionValue("2.5.29.14") == null) { + 151 if (version< 3 || xcert.getExtensionValue("2.5.29.14") == null) { The purpose of the block is to ensure, conservatively, that if there is no SubjectKID extension in the certificate, we don't check it by force for compatibility. > * DistributionPointFetcher > > [703-707] Same comment as PKIXCertPathValidator[234-238] above. > > [711] Same comment as PKIXCertPathValidator[242] above. > Updated as the updates in PKIXCertPathValidator. > Why did you remove the signature verification check of the CRL that > was previously in ForwardBuilder.issues. Is that because we verify it > later (line 642)? > Yes, I think the signature will be finally be verified later in line 642. Another point that I think we can remove the check is that for version 1 and 2 certificates, the CA should not issue multiple CRL signers with the same subject; and for version 3 certificate, the AKID and AKID should be used instead. So we don't need to verify the signature twice. Thanks, Xuelei > --Sean > > >> Thanks, >> Xuelei >> >> On 1/15/2011 5:37 AM, Sean Mullan wrote: >>> Hi Andrew, >>> >>> Did you consider using the existing X509CertSelector class to match on >>> the authority key identifier? I actually think this should work, and it >>> will avoid having to create the AKIDMatchState class. Take a look at >>> the >>> ForwardBuilder.getMatchingCACerts method towards the end, where it gets >>> the AuthorityKeyIdentifierExtension. Can you create a similar >>> X509CertSelector to select the proper trust anchor? >>> >>> --Sean >>> >>> >>> On 1/14/11 12:32 PM, Xuelei Fan wrote: >>>> On 1/15/2011 1:30 AM, Xuelei Fan wrote: >>>>> Hi Sean, >>>>> >>>>> webrev: >>>> http://cr.openjdk.java.net/~xuelei/7011497/webrev/ >>>> >>>>> Would you please review the update again. I integrate the fix for >>>>> 7011497 and 7012357 together. >>>>> >>>>> Comparing with previous webrev, the following updates are unchanged: >>>>> src/share/classes/java/security/cert/CertPathValidatorException.java >>>>> src/share/classes/sun/security/provider/certpath/AlgorithmChecker.java >>>>> >>>>> src/share/classes/sun/security/validator/SimpleValidator.java >>>>> other test files. >>>>> >>>>> >>>>> The following are new changes for CR 7012357: >>>>> src/share/classes/sun/security/provider/certpath/ForwardBuilder.java >>>>> src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java >>>>> >>>>> >>>>> test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorEndEntity.java >>>>> >>>>> >>>>> >>>>> >>>>> Thanks, >>>>> Xuelei >>>>> >>>>> On 1/14/2011 11:10 AM, Xuelei Fan wrote: >>>>>> We don't checking the SKID and AKID during searching for the trust >>>>>> anchor. >>>>>> >>>>>> I have filled a new CR for the issue, 7012357, Improve trust anchor >>>>>> searching method during cert path validation. >>>>>> >>>>>> I will have this commented out block in CPValidatorEndEntity.java. I >>>>>> will use this test case for CR 7012357. >>>>>> >>>>>> Thanks, >>>>>> Xuelei >>>>>> >>>>>> On 1/14/2011 12:44 AM, Xuelei Fan wrote: >>>>>>> I just realized, if subject KID and issuer KID works, the cert path >>>>>>> validation should be able to find the proper trust anchor. I will >>>>>>> look >>>>>>> into the issue tomorrow. >>>>>>> >>>>>>> Xuelei >>>>>>> >>>>>>> On 1/14/2011 12:27 AM, Xuelei Fan wrote: >>>>>>>> On 1/14/2011 12:05 AM, Sean Mullan wrote: >>>>>>>>> On 1/13/11 6:38 AM, Xuelei Fan wrote: >>>>>>>>>> Hi Sean, >>>>>>>>>> >>>>>>>>>> Would you please review the fix for CR 7011497? >>>>>>>>>> >>>>>>>>>> http://cr.openjdk.java.net/~xuelei/7011497/webrev/ >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Xuelei >>>>>>>>> >>>>>>>>> CPValidatorEndEntity.java: >>>>>>>>> >>>>>>>>> 307 /* coment out useless trust anchor >>>>>>>>> 308 is = new >>>>>>>>> ByteArrayInputStream(trustAnchor_SHA1withRSA_512.getBytes()); >>>>>>>>> 309 cert = cf.generateCertificate(is); >>>>>>>>> 310 anchor = new TrustAnchor((X509Certificate)cert, >>>>>>>>> null); >>>>>>>>> 311 anchors.add(anchor); >>>>>>>>> 312 */ >>>>>>>>> >>>>>>>>> Why do you leave this code in with this comment? >>>>>>>>> >>>>>>>> If I have this block. The cert path validation cannot find the >>>>>>>> proper >>>>>>>> trust anchor. As there are two trusted certificates, they are >>>>>>>> almost the >>>>>>>> same except the key size (one key size is 1024, another one is >>>>>>>> 512). >>>>>>>> >>>>>>>> In cert path validation, once a trust anchor found, if the >>>>>>>> signature is >>>>>>>> not valid, I think no more effort to test more trust anchors. >>>>>>>> >>>>>>>> I was wondering whether it is worthy to try more trust anchors. >>>>>>>> It's >>>>>>>> expensive! >>>>>>>> >>>>>>>> Thanks for the review. >>>>>>>> >>>>>>>> Xuelei >>>>>>>> >>>>>>>>> Otherwise, looks good. >>>>>>>>> >>>>>>>>> --Sean >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >> From sean.mullan at oracle.com Thu Jan 27 06:20:49 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 27 Jan 2011 09:20:49 -0500 Subject: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm In-Reply-To: <4D415A78.5020501@Oracle.COM> References: <4D2EE43D.4050508@oracle.com> <4D2F22B5.2020103@oracle.com> <4D2F2807.4050908@oracle.com> <4D2F2BF2.6030207@oracle.com> <4D2FBEB9.9020103@oracle.com> <4D308833.4030601@oracle.com> <4D3088B9.5010105@oracle.com> <4D30C232.4000802@oracle.com> <4D3E3554.30802@oracle.com> <4D405CC9.3060108@oracle.com> <4D415A78.5020501@Oracle.COM> Message-ID: <4D417F41.3080404@oracle.com> On 1/27/11 6:43 AM, Xuelei Fan wrote: > webrev: http://cr.openjdk.java.net/~xuelei/7011497/webrev/ >> * PKIXCertPathValidator >> >> [234-238]: these fields are set to null by default. I don't think you need to >> invoke the set methods. > Yes. But in order to remind that we don't want to check the validity, I have one > line comment: > "// no certificate and private key valid check for trusted certificate" I don't really think this comment is necessary, since we didn't check these fields prior to your changes. Can we just leave it out? BTW, I recommend you post each revision of the webrev (ex: webrev.00, webrev.01, ...) This way you can still go back and get the previous version which can be useful as you make incremental updates and review each revision. >> [242]: You don't need to check the length of the array here. If >> X509Certificate.getKeyUsage returned an array of the wrong length then that >> would be a non-compliant implementation and you should just let the code throw >> an ArrayIndexOOB exception. >> > Good catch. > > I don't like runtime exception here, as it expose to DOS attack if the client > send improper data. I updated the code to throw CRLException or > CertPathValidatorException, "Encounter non-compliant X.509 certificate: no > enought KeyUsage bits". Does it sound reasonable to you? I don't really think this is necessary. X509Certificate.getKeyUsage states that it returns null or a boolean array of length 9. These X509Certificates are instantiated from an CertificateFactory from a trusted provider. We shouldn't have to code around potentially non-compliant implementations that don't conform to the standard API. >> * AdaptableX509CertSelector >> >> [151-154]: this block could be moved into the previous conditional block since >> version is < 3. Also, can you explain this block? It seems like you would want >> to return false (as X509CertSelector.match does) if there is no subject key >> id, but I assume there is an important use case that I'm missing here. >> > Ooops, there was a mistake in my code. The logic connector should be "||" but > not "&&": > > - 151 if (version< 3&& xcert.getExtensionValue("2.5.29.14") == null) { > + 151 if (version< 3 || xcert.getExtensionValue("2.5.29.14") == null) { > > > The purpose of the block is to ensure, conservatively, that if there is no > SubjectKID extension in the certificate, we don't check it by force for > compatibility. Ok. >> Why did you remove the signature verification check of the CRL that was >> previously in ForwardBuilder.issues. Is that because we verify it later (line >> 642)? >> > Yes, I think the signature will be finally be verified later in line 642. > > Another point that I think we can remove the check is that for version 1 and 2 > certificates, the CA should not issue multiple CRL signers with the same > subject; and for version 3 certificate, the AKID and AKID should be used > instead. So we don't need to verify the signature twice. Ok. --Sean From Xuelei.Fan at oracle.com Thu Jan 27 15:41:40 2011 From: Xuelei.Fan at oracle.com (Xuelei Fan) Date: Fri, 28 Jan 2011 07:41:40 +0800 Subject: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm In-Reply-To: <4D417F41.3080404@oracle.com> References: <4D2EE43D.4050508@oracle.com> <4D2F22B5.2020103@oracle.com> <4D2F2807.4050908@oracle.com> <4D2F2BF2.6030207@oracle.com> <4D2FBEB9.9020103@oracle.com> <4D308833.4030601@oracle.com> <4D3088B9.5010105@oracle.com> <4D30C232.4000802@oracle.com> <4D3E3554.30802@oracle.com> <4D405CC9.3060108@oracle.com> <4D415A78.5020501@Oracle.COM> <4D417F41.3080404@oracle.com> Message-ID: <4D4202B4.2000404@Oracle.COM> All suggestion are accepted. The new webrev: http://cr.openjdk.java.net/~xuelei/7011497/webrev.01/ Thanks, Xuelei On 1/27/2011 10:20 PM, Sean Mullan wrote: > On 1/27/11 6:43 AM, Xuelei Fan wrote: >> webrev: http://cr.openjdk.java.net/~xuelei/7011497/webrev/ > >>> * PKIXCertPathValidator >>> >>> [234-238]: these fields are set to null by default. I don't think >>> you need to >>> invoke the set methods. >> Yes. But in order to remind that we don't want to check the validity, >> I have one >> line comment: >> "// no certificate and private key valid check for trusted certificate" > > I don't really think this comment is necessary, since we didn't check > these fields prior to your changes. Can we just leave it out? > > BTW, I recommend you post each revision of the webrev (ex: webrev.00, > webrev.01, ...) This way you can still go back and get the previous > version which can be useful as you make incremental updates and review > each revision. > >>> [242]: You don't need to check the length of the array here. If >>> X509Certificate.getKeyUsage returned an array of the wrong length >>> then that >>> would be a non-compliant implementation and you should just let the >>> code throw >>> an ArrayIndexOOB exception. >>> >> Good catch. >> >> I don't like runtime exception here, as it expose to DOS attack if >> the client >> send improper data. I updated the code to throw CRLException or >> CertPathValidatorException, "Encounter non-compliant X.509 >> certificate: no >> enought KeyUsage bits". Does it sound reasonable to you? > > I don't really think this is necessary. X509Certificate.getKeyUsage > states that it returns null or a boolean array of length 9. These > X509Certificates are instantiated from an CertificateFactory from a > trusted provider. We shouldn't have to code around potentially > non-compliant implementations that don't conform to the standard API. > >>> * AdaptableX509CertSelector >>> >>> [151-154]: this block could be moved into the previous conditional >>> block since >>> version is < 3. Also, can you explain this block? It seems like you >>> would want >>> to return false (as X509CertSelector.match does) if there is no >>> subject key >>> id, but I assume there is an important use case that I'm missing here. >>> >> Ooops, there was a mistake in my code. The logic connector should be >> "||" but >> not "&&": >> >> - 151 if (version< 3&& xcert.getExtensionValue("2.5.29.14") == null) { >> + 151 if (version< 3 || xcert.getExtensionValue("2.5.29.14") == null) { >> >> >> The purpose of the block is to ensure, conservatively, that if there >> is no >> SubjectKID extension in the certificate, we don't check it by force for >> compatibility. > > Ok. > >>> Why did you remove the signature verification check of the CRL that was >>> previously in ForwardBuilder.issues. Is that because we verify it >>> later (line >>> 642)? >>> >> Yes, I think the signature will be finally be verified later in line >> 642. >> >> Another point that I think we can remove the check is that for >> version 1 and 2 >> certificates, the CA should not issue multiple CRL signers with the same >> subject; and for version 3 certificate, the AKID and AKID should be used >> instead. So we don't need to verify the signature twice. > > Ok. > > --Sean From jim.holmlund at sun.com Fri Jan 28 00:10:52 2011 From: jim.holmlund at sun.com (jim.holmlund at sun.com) Date: Fri, 28 Jan 2011 08:10:52 +0000 Subject: hg: jdk7/tl/langtools: 7015482: jtreg test tools/javac/diags/MessageInfo.java fails when test/ dir is not in langtools repo Message-ID: <20110128081054.75DCA47210@hg.openjdk.java.net> Changeset: 92ab09ed59fd Author: jjh Date: 2011-01-28 00:09 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/92ab09ed59fd 7015482: jtreg test tools/javac/diags/MessageInfo.java fails when test/ dir is not in langtools repo Summary: Don't fail if the needed file isn't present, if running under jtreg. Reviewed-by: jjg ! test/tools/javac/diags/MessageInfo.java From maurizio.cimadamore at oracle.com Fri Jan 28 04:19:17 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Fri, 28 Jan 2011 12:19:17 +0000 Subject: hg: jdk7/tl/langtools: 3 new changesets Message-ID: <20110128121926.12B594721C@hg.openjdk.java.net> Changeset: 2088e674f0e0 Author: mcimadamore Date: 2011-01-28 12:01 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2088e674f0e0 6910550: javac 1.5.0_17 fails with incorrect error message Summary: multiple clashing members declared in same class should be added to the class' scope in order to avoid downstream spurious diagnostics Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/generics/6910550/T6910550a.java + test/tools/javac/generics/6910550/T6910550a.out + test/tools/javac/generics/6910550/T6910550b.java + test/tools/javac/generics/6910550/T6910550b.out + test/tools/javac/generics/6910550/T6910550c.java + test/tools/javac/generics/6910550/T6910550c.out + test/tools/javac/generics/6910550/T6910550d.java + test/tools/javac/generics/6910550/T6910550d.out + test/tools/javac/generics/6910550/T6910550e.java + test/tools/javac/generics/6910550/T6910550e.out Changeset: 5a43b245aed1 Author: mcimadamore Date: 2011-01-28 12:03 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5a43b245aed1 6313164: javac generates code that fails byte code verification for the varargs feature Summary: method applicability check should fail if formal varargs element type is not accessible Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/InaccessibleVarargsType/InaccessibleVarargsType.java + test/tools/javac/diags/examples/InaccessibleVarargsType/p1/A.java + test/tools/javac/diags/examples/InaccessibleVarargsType/p1/B.java ! test/tools/javac/generics/inference/6638712/T6638712c.out ! test/tools/javac/generics/inference/6638712/T6638712d.out + test/tools/javac/varargs/6313164/T6313164.java + test/tools/javac/varargs/6313164/T6313164.out + test/tools/javac/varargs/6313164/p1/A.java + test/tools/javac/varargs/6313164/p1/B.java + test/tools/javac/varargs/6313164/p1/C.java Changeset: 17bafae67e9d Author: mcimadamore Date: 2011-01-28 12:06 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/17bafae67e9d 6838943: inference: javac is not handling type-variable substitution properly Summary: free type-variables are being replaced with type-variables bound to forall type leading to unsoundness Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/generics/inference/6838943/T6838943.java + test/tools/javac/generics/inference/6838943/T6838943.out From alan.bateman at oracle.com Fri Jan 28 04:28:58 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 28 Jan 2011 12:28:58 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110128122932.A2C7F4721E@hg.openjdk.java.net> Changeset: 236e3f2d0a6b Author: alanb Date: 2011-01-28 09:28 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/236e3f2d0a6b 7006126: (fs) Updates to file system API (1/2011) Reviewed-by: chegar, sherman ! make/java/java/FILES_java.gmk ! make/java/nio/FILES_java.gmk ! make/mkdemo/Makefile ! src/share/classes/java/io/BufferedReader.java ! src/share/classes/java/io/BufferedWriter.java ! src/share/classes/java/io/File.java ! src/share/classes/java/io/FileInputStream.java ! src/share/classes/java/io/FileOutputStream.java ! src/share/classes/java/io/FilePermission.java ! src/share/classes/java/io/SerialCallbackContext.java - src/share/classes/java/io/TempFileHelper.java ! src/share/classes/java/nio/channels/FileChannel.java ! src/share/classes/java/nio/channels/SeekableByteChannel.java ! src/share/classes/java/nio/file/AccessMode.java + src/share/classes/java/nio/file/CopyMoveHelper.java ! src/share/classes/java/nio/file/CopyOption.java ! src/share/classes/java/nio/file/DirectoryStream.java - src/share/classes/java/nio/file/FileRef.java ! src/share/classes/java/nio/file/FileStore.java ! src/share/classes/java/nio/file/FileSystem.java ! src/share/classes/java/nio/file/FileSystems.java ! src/share/classes/java/nio/file/FileTreeWalker.java ! src/share/classes/java/nio/file/FileVisitor.java ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/file/LinkOption.java ! src/share/classes/java/nio/file/LinkPermission.java ! src/share/classes/java/nio/file/OpenOption.java ! src/share/classes/java/nio/file/Path.java ! src/share/classes/java/nio/file/PathMatcher.java ! src/share/classes/java/nio/file/Paths.java ! src/share/classes/java/nio/file/SecureDirectoryStream.java + src/share/classes/java/nio/file/TempFileHelper.java ! src/share/classes/java/nio/file/WatchEvent.java ! src/share/classes/java/nio/file/WatchKey.java ! src/share/classes/java/nio/file/WatchService.java ! src/share/classes/java/nio/file/attribute/AclEntry.java ! src/share/classes/java/nio/file/attribute/AclFileAttributeView.java - src/share/classes/java/nio/file/attribute/Attributes.java ! src/share/classes/java/nio/file/attribute/BasicFileAttributeView.java ! src/share/classes/java/nio/file/attribute/BasicFileAttributes.java ! src/share/classes/java/nio/file/attribute/DosFileAttributeView.java ! src/share/classes/java/nio/file/attribute/DosFileAttributes.java ! src/share/classes/java/nio/file/attribute/FileAttribute.java ! src/share/classes/java/nio/file/attribute/FileAttributeView.java ! src/share/classes/java/nio/file/attribute/FileOwnerAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java ! src/share/classes/java/nio/file/attribute/FileTime.java ! src/share/classes/java/nio/file/attribute/PosixFileAttributeView.java ! src/share/classes/java/nio/file/attribute/PosixFileAttributes.java ! src/share/classes/java/nio/file/attribute/PosixFilePermission.java ! src/share/classes/java/nio/file/attribute/PosixFilePermissions.java ! src/share/classes/java/nio/file/attribute/UserDefinedFileAttributeView.java ! src/share/classes/java/nio/file/attribute/package-info.java ! src/share/classes/java/nio/file/package-info.java ! src/share/classes/java/nio/file/spi/FileSystemProvider.java ! src/share/classes/java/nio/file/spi/FileTypeDetector.java ! src/share/classes/java/util/Scanner.java ! src/share/classes/sun/nio/fs/AbstractAclFileAttributeView.java ! src/share/classes/sun/nio/fs/AbstractBasicFileAttributeView.java + src/share/classes/sun/nio/fs/AbstractFileSystemProvider.java ! src/share/classes/sun/nio/fs/AbstractFileTypeDetector.java ! src/share/classes/sun/nio/fs/AbstractPath.java ! src/share/classes/sun/nio/fs/AbstractPoller.java ! src/share/classes/sun/nio/fs/AbstractUserDefinedFileAttributeView.java ! src/share/classes/sun/nio/fs/AbstractWatchKey.java ! src/share/classes/sun/nio/fs/AbstractWatchService.java ! src/share/classes/sun/nio/fs/DynamicFileAttributeView.java ! src/share/classes/sun/nio/fs/FileOwnerAttributeViewImpl.java ! src/share/classes/sun/nio/fs/PollingWatchService.java ! src/share/classes/sun/security/provider/SeedGenerator.java ! src/share/classes/sun/tools/jar/Main.java ! src/share/sample/nio/file/AclEdit.java ! src/share/sample/nio/file/Chmod.java ! src/share/sample/nio/file/Copy.java ! src/share/sample/nio/file/DiskUsage.java ! src/share/sample/nio/file/FileType.java ! src/share/sample/nio/file/WatchDir.java ! src/share/sample/nio/file/Xdd.java ! src/solaris/classes/sun/nio/fs/GnomeFileTypeDetector.java ! src/solaris/classes/sun/nio/fs/LinuxDosFileAttributeView.java ! src/solaris/classes/sun/nio/fs/LinuxFileSystem.java ! src/solaris/classes/sun/nio/fs/LinuxFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/LinuxUserDefinedFileAttributeView.java ! src/solaris/classes/sun/nio/fs/LinuxWatchService.java ! src/solaris/classes/sun/nio/fs/SolarisAclFileAttributeView.java ! src/solaris/classes/sun/nio/fs/SolarisFileSystem.java ! src/solaris/classes/sun/nio/fs/SolarisFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/SolarisUserDefinedFileAttributeView.java ! src/solaris/classes/sun/nio/fs/SolarisWatchService.java ! src/solaris/classes/sun/nio/fs/UnixCopyFile.java ! src/solaris/classes/sun/nio/fs/UnixFileAttributeViews.java ! src/solaris/classes/sun/nio/fs/UnixFileAttributes.java ! src/solaris/classes/sun/nio/fs/UnixFileStore.java ! src/solaris/classes/sun/nio/fs/UnixFileSystem.java ! src/solaris/classes/sun/nio/fs/UnixFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/UnixPath.java ! src/solaris/classes/sun/nio/fs/UnixSecureDirectoryStream.java ! src/windows/classes/sun/nio/fs/RegistryFileTypeDetector.java ! src/windows/classes/sun/nio/fs/WindowsFileAttributeViews.java ! src/windows/classes/sun/nio/fs/WindowsFileCopy.java ! src/windows/classes/sun/nio/fs/WindowsFileStore.java ! src/windows/classes/sun/nio/fs/WindowsFileSystem.java ! src/windows/classes/sun/nio/fs/WindowsFileSystemProvider.java ! src/windows/classes/sun/nio/fs/WindowsPath.java ! src/windows/classes/sun/nio/fs/WindowsPathParser.java ! src/windows/classes/sun/nio/fs/WindowsSecurityDescriptor.java ! src/windows/classes/sun/nio/fs/WindowsUserDefinedFileAttributeView.java ! src/windows/classes/sun/nio/fs/WindowsWatchService.java ! test/demo/zipfs/basic.sh ! test/java/io/File/IsHidden.java ! test/java/io/File/SetAccess.java ! test/java/io/File/SymLinks.java ! test/java/io/FileInputStream/LargeFileAvailable.java ! test/java/nio/channels/FileChannel/AtomicAppend.java ! test/java/nio/channels/FileChannel/Transfer.java ! test/java/nio/file/DirectoryStream/Basic.java ! test/java/nio/file/DirectoryStream/DriveLetter.java ! test/java/nio/file/DirectoryStream/SecureDS.java ! test/java/nio/file/FileStore/Basic.java + test/java/nio/file/Files/BytesAndLines.java + test/java/nio/file/Files/CheckPermissions.java - test/java/nio/file/Files/ContentType.java + test/java/nio/file/Files/CopyAndMove.java - test/java/nio/file/Files/CreateFileTree.java + test/java/nio/file/Files/DeleteOnClose.java + test/java/nio/file/Files/FileAttributes.java - test/java/nio/file/Files/ForceLoad.java + test/java/nio/file/Files/InterruptCopy.java + test/java/nio/file/Files/Links.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java ! test/java/nio/file/Files/Misc.java + test/java/nio/file/Files/PassThroughFileSystem.java - test/java/nio/file/Files/PrintFileTree.java + test/java/nio/file/Files/SBC.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java + test/java/nio/file/Files/TemporaryFiles.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java + test/java/nio/file/Files/delete_on_close.sh - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy + test/java/nio/file/Files/probeContentType/Basic.java + test/java/nio/file/Files/probeContentType/ForceLoad.java + test/java/nio/file/Files/probeContentType/META-INF/services/java.nio.file.spi.FileTypeDetector + test/java/nio/file/Files/probeContentType/SimpleFileTypeDetector.java + test/java/nio/file/Files/walkFileTree/CreateFileTree.java + test/java/nio/file/Files/walkFileTree/MaxDepth.java + test/java/nio/file/Files/walkFileTree/Nulls.java + test/java/nio/file/Files/walkFileTree/PrintFileTree.java + test/java/nio/file/Files/walkFileTree/SkipSiblings.java + test/java/nio/file/Files/walkFileTree/TerminateWalk.java + test/java/nio/file/Files/walkFileTree/WalkWithSecurity.java + test/java/nio/file/Files/walkFileTree/denyAll.policy + test/java/nio/file/Files/walkFileTree/grantAll.policy + test/java/nio/file/Files/walkFileTree/grantTopOnly.policy + test/java/nio/file/Files/walkFileTree/walk_file_tree.sh - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java ! test/java/nio/file/Path/Misc.java - test/java/nio/file/Path/PassThroughFileSystem.java ! test/java/nio/file/Path/PathOps.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh ! test/java/nio/file/TestUtil.java ! test/java/nio/file/WatchService/Basic.java ! test/java/nio/file/WatchService/FileTreeModifier.java ! test/java/nio/file/WatchService/LotsOfEvents.java ! test/java/nio/file/WatchService/SensitivityModifier.java ! test/java/nio/file/attribute/AclFileAttributeView/Basic.java ! test/java/nio/file/attribute/BasicFileAttributeView/Basic.java ! test/java/nio/file/attribute/DosFileAttributeView/Basic.java - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java ! test/java/nio/file/attribute/FileTime/Basic.java ! test/java/nio/file/attribute/PosixFileAttributeView/Basic.java ! test/java/nio/file/attribute/UserDefinedFileAttributeView/Basic.java ! test/java/nio/file/spi/SetDefaultProvider.java ! test/java/nio/file/spi/TestProvider.java Changeset: 60d347deb54d Author: alanb Date: 2011-01-28 09:31 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/60d347deb54d Merge - src/share/classes/java/io/TempFileHelper.java - src/share/classes/java/nio/file/FileRef.java - src/share/classes/java/nio/file/attribute/Attributes.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java ! test/demo/zipfs/basic.sh - test/java/nio/file/Files/ContentType.java - test/java/nio/file/Files/CreateFileTree.java - test/java/nio/file/Files/ForceLoad.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java - test/java/nio/file/Files/PrintFileTree.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java - test/java/nio/file/Path/PassThroughFileSystem.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java From alan.bateman at oracle.com Fri Jan 28 04:38:03 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 28 Jan 2011 12:38:03 +0000 Subject: hg: jdk7/tl/langtools: 2 new changesets Message-ID: <20110128123809.712844721F@hg.openjdk.java.net> Changeset: babf86a1ac92 Author: alanb Date: 2011-01-28 09:25 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/babf86a1ac92 7006126: (fs) Updates to file system API (1/2011) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java ! src/share/classes/com/sun/tools/javac/nio/PathFileObject.java ! test/tools/javac/nio/compileTest/CompileTest.java Changeset: df3394337b04 Author: alanb Date: 2011-01-28 12:36 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/df3394337b04 Merge From alan.bateman at oracle.com Fri Jan 28 05:26:57 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 28 Jan 2011 13:26:57 +0000 Subject: hg: jdk7/tl/jdk: 7015410: test/java/net/Socks/SocksProxyVersion.java needs to be updated due to 7013420 Message-ID: <20110128132714.47E3B47223@hg.openjdk.java.net> Changeset: dea360853f8b Author: alanb Date: 2011-01-28 13:26 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dea360853f8b 7015410: test/java/net/Socks/SocksProxyVersion.java needs to be updated due to 7013420 Reviewed-by: chegar ! test/java/net/Socks/SocksProxyVersion.java From joe.darcy at oracle.com Fri Jan 28 16:54:39 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Sat, 29 Jan 2011 00:54:39 +0000 Subject: hg: jdk7/tl/langtools: 7015530: Reiterate API specializations in javax.lang.model.elment subinterfaces Message-ID: <20110129005443.4B84347245@hg.openjdk.java.net> Changeset: 7a75a1803c7a Author: darcy Date: 2011-01-28 16:54 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7a75a1803c7a 7015530: Reiterate API specializations in javax.lang.model.elment subinterfaces Reviewed-by: jjg ! src/share/classes/javax/lang/model/element/Element.java ! src/share/classes/javax/lang/model/element/ExecutableElement.java ! src/share/classes/javax/lang/model/element/PackageElement.java ! src/share/classes/javax/lang/model/element/TypeElement.java ! src/share/classes/javax/lang/model/element/TypeParameterElement.java ! src/share/classes/javax/lang/model/element/VariableElement.java From joe.darcy at oracle.com Fri Jan 28 17:10:05 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Sat, 29 Jan 2011 01:10:05 +0000 Subject: hg: jdk7/tl/jdk: 7015156: Remove JSR 308 changes from core libraries Message-ID: <20110129011030.15EA847247@hg.openjdk.java.net> Changeset: d21a1ce074a7 Author: darcy Date: 2011-01-28 17:09 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d21a1ce074a7 7015156: Remove JSR 308 changes from core libraries Reviewed-by: mduigou ! src/share/classes/java/lang/SuppressWarnings.java ! src/share/classes/java/lang/annotation/ElementType.java From joe.darcy at oracle.com Mon Jan 31 19:07:21 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 01 Feb 2011 03:07:21 +0000 Subject: hg: jdk7/tl/langtools: 7014734: Project Coin: Allow optional trailing semicolon to terminate resources list in try-with-resources Message-ID: <20110201030726.335F9472E8@hg.openjdk.java.net> Changeset: 2ab47c4cd618 Author: darcy Date: 2011-01-31 19:06 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2ab47c4cd618 7014734: Project Coin: Allow optional trailing semicolon to terminate resources list in try-with-resources Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/TryWithResources/BadTwrSyntax.java ! test/tools/javac/TryWithResources/BadTwrSyntax.out - test/tools/javac/diags/examples/TryResourceTrailingSemi.java