From xueming.shen at oracle.com Sat Dec 1 11:35:44 2012 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Sat, 01 Dec 2012 19:35:44 +0000 Subject: hg: jdk8/tl/jdk: 8004212: java.util.Base64 methods decodeArray and decodeBuffer should return the number of bytes written Message-ID: <20121201193555.3FF4E47C75@hg.openjdk.java.net> Changeset: fd8ba2d8baec Author: sherman Date: 2012-12-01 11:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fd8ba2d8baec 8004212: java.util.Base64 methods decodeArray and decodeBuffer should return the number of bytes written Summary: to return the length instead of position Reviewed-by: alanb ! src/share/classes/java/util/Base64.java ! test/java/util/Base64/TestBase64.java From xuelei.fan at oracle.com Sat Dec 1 18:49:28 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Sun, 02 Dec 2012 10:49:28 +0800 Subject: Code Review Request, 8004184, security tests leave JSSEServer running Message-ID: <50BAC1B8.5070504@oracle.com> Hi, Please review the test bug that does not release the server resources. bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004184webrev: http://cr.openjdk.java.net./~xuelei/8004184/webrev.00/ Thanks, Xuelei From chris.hegarty at oracle.com Sun Dec 2 07:38:17 2012 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Sun, 2 Dec 2012 15:38:17 +0000 Subject: Code Review Request, 8004184, security tests leave JSSEServer running In-Reply-To: <50BAC1B8.5070504@oracle.com> References: <50BAC1B8.5070504@oracle.com> Message-ID: Your description talks about releasing resources, but the comment in the source mentions initialising system properties. Are you using othervm mode to get around releasing resources or an issues with previously set system properties? -Chris On 2 Dec 2012, at 02:49, Xuelei Fan wrote: > Hi, > > Please review the test bug that does not release the server resources. > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004184webrev: > http://cr.openjdk.java.net./~xuelei/8004184/webrev.00/ > > > Thanks, > Xuelei From alan.bateman at oracle.com Sun Dec 2 08:37:41 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sun, 02 Dec 2012 16:37:41 +0000 Subject: hg: jdk8/tl/jdk: 8003846: Override mechanism for currency data should not require creating currency.properties in java.home Message-ID: <20121202163810.B846F47C8F@hg.openjdk.java.net> Changeset: f657adf4fe78 Author: alanb Date: 2012-12-02 16:37 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f657adf4fe78 8003846: Override mechanism for currency data should not require creating currency.properties in java.home Reviewed-by: naoto ! src/share/classes/java/util/Currency.java ! test/java/util/Currency/PropertiesTest.java ! test/java/util/Currency/PropertiesTest.sh From david.holmes at oracle.com Sun Dec 2 16:18:20 2012 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Mon, 03 Dec 2012 00:18:20 +0000 Subject: hg: jdk8/tl/jdk: 7200297: agent code does not handle multiple boot library path elements correctly Message-ID: <20121203001847.3487F47CB8@hg.openjdk.java.net> Changeset: 60550cd2b527 Author: dholmes Date: 2012-12-02 19:16 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60550cd2b527 7200297: agent code does not handle multiple boot library path elements correctly Summary: When bug 6819213 was fixed it enabled sun.boot.library.path property to contain multiple paths. Code in agents does not handle multiple paths when attempting to find dependent shared libs. Reviewed-by: dholmes, sspitsyn, dsamersoff Contributed-by: Bill Pittore ! src/share/back/debugInit.c ! src/share/back/error_messages.c ! src/share/back/transport.c ! src/share/demo/jvmti/hprof/hprof.h ! src/share/demo/jvmti/hprof/hprof_init.c ! src/solaris/back/linker_md.c ! src/solaris/demo/jvmti/hprof/hprof_md.c ! src/solaris/npt/npt_md.h ! src/windows/back/linker_md.c ! src/windows/demo/jvmti/hprof/hprof_md.c ! src/windows/npt/npt_md.h From xuelei.fan at oracle.com Sun Dec 2 17:28:28 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Mon, 03 Dec 2012 09:28:28 +0800 Subject: Code Review Request, 8004184, security tests leave JSSEServer running In-Reply-To: References: <50BAC1B8.5070504@oracle.com> Message-ID: <50BC003C.2080402@oracle.com> On 12/2/2012 11:38 PM, Chris Hegarty wrote: > Your description talks about releasing resources, but the comment > in the source mentions initialising system properties. Are you > using othervm mode to get around releasing resources or an issues > with previously set system properties? > JSSE cannot support agentvm mode because some system properties will be only called one time at every VM. Othervm mode is used to release resources. And it is also used to correct the previous system properties issues. I normally put the comments to all JSSE test, so that the code readers can understand why the test must be run in othervm mode. Thanks, Xuelei > -Chris > > On 2 Dec 2012, at 02:49, Xuelei Fan wrote: > >> Hi, >> >> Please review the test bug that does not release the server resources. >> >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004184webrev: >> http://cr.openjdk.java.net./~xuelei/8004184/webrev.00/ >> >> >> Thanks, >> Xuelei From weijun.wang at oracle.com Mon Dec 3 01:14:21 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 03 Dec 2012 09:14:21 +0000 Subject: hg: jdk8/tl/jdk: 7198507: [TEST_BUG] sun/security/tools/keytool/console.sh should be rewritten Message-ID: <20121203091444.97B8347CD1@hg.openjdk.java.net> Changeset: a42da685dfca Author: weijun Date: 2012-12-03 17:14 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a42da685dfca 7198507: [TEST_BUG] sun/security/tools/keytool/console.sh should be rewritten Reviewed-by: xuelei ! test/sun/security/tools/keytool/console.sh From chris.hegarty at oracle.com Mon Dec 3 01:34:54 2012 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Mon, 03 Dec 2012 09:34:54 +0000 Subject: Code Review Request, 8004184, security tests leave JSSEServer running In-Reply-To: <50BC003C.2080402@oracle.com> References: <50BAC1B8.5070504@oracle.com> <50BC003C.2080402@oracle.com> Message-ID: <50BC723E.2050605@oracle.com> OK, if this resolves this issue, then I'm fine with it. -Chris. On 03/12/2012 01:28, Xuelei Fan wrote: > On 12/2/2012 11:38 PM, Chris Hegarty wrote: >> Your description talks about releasing resources, but the comment >> in the source mentions initialising system properties. Are you >> using othervm mode to get around releasing resources or an issues >> with previously set system properties? >> > JSSE cannot support agentvm mode because some system properties will be > only called one time at every VM. Othervm mode is used to release > resources. And it is also used to correct the previous system > properties issues. I normally put the comments to all JSSE test, so > that the code readers can understand why the test must be run in othervm > mode. > > Thanks, > Xuelei > > >> -Chris >> >> On 2 Dec 2012, at 02:49, Xuelei Fan wrote: >> >>> Hi, >>> >>> Please review the test bug that does not release the server resources. >>> >>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004184webrev: >>> http://cr.openjdk.java.net./~xuelei/8004184/webrev.00/ >>> >>> >>> Thanks, >>> Xuelei > From xuelei.fan at oracle.com Mon Dec 3 05:50:00 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Mon, 03 Dec 2012 21:50:00 +0800 Subject: Code Review Request, 8004184, security tests leave JSSEServer running In-Reply-To: <50BC723E.2050605@oracle.com> References: <50BAC1B8.5070504@oracle.com> <50BC003C.2080402@oracle.com> <50BC723E.2050605@oracle.com> Message-ID: <50BCAE08.9080606@oracle.com> Thanks, Chris! Xuelei On 12/3/2012 5:34 PM, Chris Hegarty wrote: > OK, if this resolves this issue, then I'm fine with it. > > -Chris. > > On 03/12/2012 01:28, Xuelei Fan wrote: >> On 12/2/2012 11:38 PM, Chris Hegarty wrote: >>> Your description talks about releasing resources, but the comment >>> in the source mentions initialising system properties. Are you >>> using othervm mode to get around releasing resources or an issues >>> with previously set system properties? >>> >> JSSE cannot support agentvm mode because some system properties will be >> only called one time at every VM. Othervm mode is used to release >> resources. And it is also used to correct the previous system >> properties issues. I normally put the comments to all JSSE test, so >> that the code readers can understand why the test must be run in othervm >> mode. >> >> Thanks, >> Xuelei >> >> >>> -Chris >>> >>> On 2 Dec 2012, at 02:49, Xuelei Fan wrote: >>> >>>> Hi, >>>> >>>> Please review the test bug that does not release the server resources. >>>> >>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004184webrev: >>>> http://cr.openjdk.java.net./~xuelei/8004184/webrev.00/ >>>> >>>> >>>> Thanks, >>>> Xuelei >> From xuelei.fan at oracle.com Mon Dec 3 06:01:35 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Mon, 03 Dec 2012 14:01:35 +0000 Subject: hg: jdk8/tl/jdk: 8004184: security tests leave JSSEServer running Message-ID: <20121203140215.00D5D47CDD@hg.openjdk.java.net> Changeset: ead651efb271 Author: xuelei Date: 2012-12-03 06:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ead651efb271 8004184: security tests leave JSSEServer running Summary: Use othervm mode to release resources, and correct the system properties issues in JSSE Reviewed-by: chegar ! test/sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java From sean.mullan at oracle.com Mon Dec 3 08:17:10 2012 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Mon, 03 Dec 2012 16:17:10 +0000 Subject: hg: jdk8/tl/jdk: 7199143: RFE: OCSP revocation checker should provide possibility to specify connection timeout Message-ID: <20121203161732.2584F47CEC@hg.openjdk.java.net> Changeset: ee9846f351d7 Author: mullan Date: 2012-12-03 11:07 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee9846f351d7 7199143: RFE: OCSP revocation checker should provide possibility to specify connection timeout Summary: Added com.sun.security.ocsp.timeout system property to control timeout Reviewed-by: mullan, vinnie Contributed-by: jason.uh at oracle.com ! src/share/classes/sun/security/provider/certpath/OCSP.java From jason.uh at oracle.com Mon Dec 3 14:18:58 2012 From: jason.uh at oracle.com (Jason Uh) Date: Mon, 03 Dec 2012 14:18:58 -0800 Subject: Code Review Request: 8004188: Rename src/share/lib/security/java.security to java.security-linux Message-ID: <50BD2552.3040706@oracle.com> Could I please get a review of http://cr.openjdk.java.net/~juh/8004188/webrev.00/ Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004188 This change renames src/share/lib/security/java.security to java.security-linux to avoid confusion. The Makefile has been updated to accommodate the change. Thanks, Jason From bradford.wetmore at oracle.com Mon Dec 3 16:49:56 2012 From: bradford.wetmore at oracle.com (Brad Wetmore) Date: Mon, 03 Dec 2012 16:49:56 -0800 Subject: Code Review Request, 8004184, security tests leave JSSEServer running In-Reply-To: <50BC003C.2080402@oracle.com> References: <50BAC1B8.5070504@oracle.com> <50BC003C.2080402@oracle.com> Message-ID: <50BD48B4.5050603@oracle.com> Looks ok to me too. Brad On 12/2/2012 5:28 PM, Xuelei Fan wrote: > On 12/2/2012 11:38 PM, Chris Hegarty wrote: >> Your description talks about releasing resources, but the comment >> in the source mentions initialising system properties. Are you >> using othervm mode to get around releasing resources or an issues >> with previously set system properties? >> > JSSE cannot support agentvm mode because some system properties will be > only called one time at every VM. Othervm mode is used to release > resources. And it is also used to correct the previous system > properties issues. I normally put the comments to all JSSE test, so > that the code readers can understand why the test must be run in othervm > mode. > > Thanks, > Xuelei > > >> -Chris >> >> On 2 Dec 2012, at 02:49, Xuelei Fan wrote: >> >>> Hi, >>> >>> Please review the test bug that does not release the server resources. >>> >>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004184webrev: >>> http://cr.openjdk.java.net./~xuelei/8004184/webrev.00/ >>> >>> >>> Thanks, >>> Xuelei > From alan.bateman at oracle.com Tue Dec 4 06:13:58 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 04 Dec 2012 14:13:58 +0000 Subject: hg: jdk8/tl/jdk: 7142921: (fs) Files.probeContentType reports a MIME type of "text/plain" on Ubuntu 11.04; ... Message-ID: <20121204141424.2273947D7C@hg.openjdk.java.net> Changeset: 38ec2838dd86 Author: dxu Date: 2012-12-04 14:07 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/38ec2838dd86 7142921: (fs) Files.probeContentType reports a MIME type of "text/plain" on Ubuntu 11.04 7144997: (fs) Files.probeContentType returns null on Solaris 64-bit Reviewed-by: alanb, mduigou ! make/java/nio/Makefile ! make/java/nio/mapfile-linux ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/mapfiles/libnio/mapfile-linux ! src/solaris/classes/sun/nio/fs/BsdFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/LinuxFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/MacOSXFileSystemProvider.java + src/solaris/classes/sun/nio/fs/MagicFileTypeDetector.java + src/solaris/classes/sun/nio/fs/MimeTypesFileTypeDetector.java ! src/solaris/classes/sun/nio/fs/SolarisFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/UnixFileSystemProvider.java + src/solaris/native/sun/nio/fs/MagicFileTypeDetector.c From xuelei.fan at oracle.com Tue Dec 4 07:07:18 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Tue, 04 Dec 2012 23:07:18 +0800 Subject: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115) In-Reply-To: <50AE3DF0.1020400@oracle.com> References: <50AE3DF0.1020400@oracle.com> Message-ID: <50BE11A6.2070205@oracle.com> Ping ... On 11/22/2012 11:00 PM, Xuelei Fan wrote: > Hi Valerie, Max or Brad, > > Can you review the update for JDK-7030966? It is the JSSE part of JEP 115. > > webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.00/ > JEP 115: http://openjdk.java.net/jeps/115 > > In the update, I have not remove the debug synchronization. I will > remove them before pushing the changeset. > > Thanks, > Xuelei > From alan.bateman at oracle.com Tue Dec 4 07:11:01 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 04 Dec 2012 15:11:01 +0000 Subject: hg: jdk8/tl/jdk: 8004066: TEST_BUG: test/java/lang/Math/DivModTests.java assumes ArithmeticException message Message-ID: <20121204151120.8597847D7F@hg.openjdk.java.net> Changeset: 2e8863c4f7d0 Author: kmo Date: 2012-12-04 15:10 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2e8863c4f7d0 8004066: TEST_BUG: test/java/lang/Math/DivModTests.java assumes ArithmeticException message Reviewed-by: twisti, alanb, dholmes ! test/java/lang/Math/DivModTests.java From sean.mullan at oracle.com Tue Dec 4 07:56:16 2012 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 04 Dec 2012 10:56:16 -0500 Subject: Code Review Request: 8004188: Rename src/share/lib/security/java.security to java.security-linux In-Reply-To: <50BD2552.3040706@oracle.com> References: <50BD2552.3040706@oracle.com> Message-ID: <50BE1D20.9000809@oracle.com> Fix looks good, and I can push this for you. Could you also add the noreg-build label to the bug? Thanks, Sean On 12/03/2012 05:18 PM, Jason Uh wrote: > Could I please get a review of > http://cr.openjdk.java.net/~juh/8004188/webrev.00/ > > Bug: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004188 > > This change renames src/share/lib/security/java.security to > java.security-linux to avoid confusion. The Makefile has been updated to > accommodate the change. > > Thanks, > Jason From maurizio.cimadamore at oracle.com Tue Dec 4 09:59:37 2012 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Tue, 04 Dec 2012 17:59:37 +0000 Subject: hg: jdk8/tl/langtools: 8004360: regression test DefaultMethodRegressionTests fails in langtools Message-ID: <20121204175941.ADEE447D98@hg.openjdk.java.net> Changeset: 0e70eb71fec0 Author: mcimadamore Date: 2012-12-04 17:19 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0e70eb71fec0 8004360: regression test DefaultMethodRegressionTests fails in langtools Summary: ignore broken failing test Reviewed-by: jjg - test/tools/javac/defaultMethodExecution/DefaultMethodRegressionTests.java + test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMethodRegressionTests.java From alan.bateman at oracle.com Tue Dec 4 12:21:47 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 04 Dec 2012 20:21:47 +0000 Subject: hg: jdk8/tl/jdk: 8003596: TEST_BUG: java/util/logging/CheckLockLocationTest.java failing [win] Message-ID: <20121204202227.EC74B47DA4@hg.openjdk.java.net> Changeset: 7004848974a2 Author: jgish Date: 2012-12-04 20:21 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7004848974a2 8003596: TEST_BUG: java/util/logging/CheckLockLocationTest.java failing [win] Reviewed-by: alanb ! test/ProblemList.txt ! test/java/util/logging/CheckLockLocationTest.java From sean.mullan at oracle.com Tue Dec 4 14:42:45 2012 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Tue, 04 Dec 2012 22:42:45 +0000 Subject: hg: jdk8/tl/jdk: 8004188: Rename src/share/lib/security/java.security to java.security-linux Message-ID: <20121204224256.AAADD47DD0@hg.openjdk.java.net> Changeset: 44ae777564eb Author: mullan Date: 2012-12-04 17:40 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44ae777564eb 8004188: Rename src/share/lib/security/java.security to java.security-linux Reviewed-by: mullan, mchung Contributed-by: jason.uh at oracle.com ! make/java/security/Makefile - src/share/lib/security/java.security + src/share/lib/security/java.security-linux From alan.bateman at oracle.com Wed Dec 5 04:55:51 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 05 Dec 2012 12:55:51 +0000 Subject: hg: jdk8/tl/jdk: 8004491: Build breakage on Linux due to 8004188 Message-ID: <20121205125631.21EC047E25@hg.openjdk.java.net> Changeset: b54a5b7d2e65 Author: alanb Date: 2012-12-05 12:20 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b54a5b7d2e65 8004491: Build breakage on Linux due to 8004188 Reviewed-by: chegar, erikj ! makefiles/CopyFiles.gmk From jason.uh at oracle.com Wed Dec 5 16:16:27 2012 From: jason.uh at oracle.com (Jason Uh) Date: Wed, 05 Dec 2012 16:16:27 -0800 Subject: Request for Review: 7193792: sun/security/pkcs11/ec/TestECDSA.java failing intermittently Message-ID: <50BFE3DB.7050109@oracle.com> Could I please get a review of: http://cr.openjdk.java.net/~juh/7193792/webrev.00/ Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7193792 This change fixes sun/security/pkcs11/ec/TestECDSA.java, which fails on Solaris due to what seems to be an unintended back-to-back call to Signature.initSign(privateKey). On the second initSign, the test fails with CKR_OPERATION_ACTIVE, which means: > There is already an active operation (or combination of active > operations) which prevents Cryptoki from activating the specified > operation. ... (http://www.cryptsoft.com/pkcs11doc/v220/pkcs11__all_8h.html#aCKR_OPERATION_ACTIVE) Thanks, Jason From xuelei.fan at oracle.com Wed Dec 5 16:44:07 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Thu, 06 Dec 2012 08:44:07 +0800 Subject: Request for Review: 7193792: sun/security/pkcs11/ec/TestECDSA.java failing intermittently In-Reply-To: <50BFE3DB.7050109@oracle.com> References: <50BFE3DB.7050109@oracle.com> Message-ID: <50BFEA57.30001@oracle.com> Looks fine to me. Thanks, Xuelei On 12/6/2012 8:16 AM, Jason Uh wrote: > Could I please get a review of: > http://cr.openjdk.java.net/~juh/7193792/webrev.00/ > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7193792 > > This change fixes sun/security/pkcs11/ec/TestECDSA.java, which fails on > Solaris due to what seems to be an unintended back-to-back call to > Signature.initSign(privateKey). On the second initSign, the test fails > with CKR_OPERATION_ACTIVE, which means: > >> There is already an active operation (or combination of active >> operations) which prevents Cryptoki from activating the specified >> operation. ... > (http://www.cryptsoft.com/pkcs11doc/v220/pkcs11__all_8h.html#aCKR_OPERATION_ACTIVE) > > > Thanks, > Jason From stuart.marks at oracle.com Wed Dec 5 21:12:03 2012 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Thu, 06 Dec 2012 05:12:03 +0000 Subject: hg: jdk8/tl/jdk: 8004317: TestLibrary.getUnusedRandomPort() fails intermittently, but exception not reported Message-ID: <20121206051214.7A1D447EF1@hg.openjdk.java.net> Changeset: a971516029ab Author: jgish Date: 2012-12-05 21:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a971516029ab 8004317: TestLibrary.getUnusedRandomPort() fails intermittently, but exception not reported Reviewed-by: alanb, dmocek, smarks ! test/java/rmi/testlibrary/TestLibrary.java From vincent.x.ryan at oracle.com Thu Dec 6 01:05:20 2012 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Thu, 6 Dec 2012 09:05:20 +0000 Subject: Request for Review: 7193792: sun/security/pkcs11/ec/TestECDSA.java failing intermittently In-Reply-To: <50BFE3DB.7050109@oracle.com> References: <50BFE3DB.7050109@oracle.com> Message-ID: <05584BD0-B2E8-449C-BF4A-98A52E0D6566@oracle.com> Fix looks good. On 6 Dec 2012, at 00:16, Jason Uh wrote: > Could I please get a review of: > http://cr.openjdk.java.net/~juh/7193792/webrev.00/ > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7193792 > > This change fixes sun/security/pkcs11/ec/TestECDSA.java, which fails on Solaris due to what seems to be an unintended back-to-back call to Signature.initSign(privateKey). On the second initSign, the test fails with CKR_OPERATION_ACTIVE, which means: > > > There is already an active operation (or combination of active > > operations) which prevents Cryptoki from activating the specified > > operation. ... > (http://www.cryptsoft.com/pkcs11doc/v220/pkcs11__all_8h.html#aCKR_OPERATION_ACTIVE) > > Thanks, > Jason From lance.andersen at oracle.com Thu Dec 6 12:52:41 2012 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Thu, 06 Dec 2012 20:52:41 +0000 Subject: hg: jdk8/tl/jdk: 8004374: CachedRowSetSwriter.writeData reports wrong number of conflicts in SyncProviderException Message-ID: <20121206205310.E808047F56@hg.openjdk.java.net> Changeset: 41a1b110f34d Author: lancea Date: 2012-12-06 15:51 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41a1b110f34d 8004374: CachedRowSetSwriter.writeData reports wrong number of conflicts in SyncProviderException Reviewed-by: naoto ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java From bradford.wetmore at oracle.com Thu Dec 6 12:57:43 2012 From: bradford.wetmore at oracle.com (Brad Wetmore) Date: Thu, 06 Dec 2012 12:57:43 -0800 Subject: Request for Review: 7193792: sun/security/pkcs11/ec/TestECDSA.java failing intermittently In-Reply-To: <05584BD0-B2E8-449C-BF4A-98A52E0D6566@oracle.com> References: <50BFE3DB.7050109@oracle.com> <05584BD0-B2E8-449C-BF4A-98A52E0D6566@oracle.com> Message-ID: <50C106C7.7040902@oracle.com> Ditto. Thanks for also removing from ProblemList. brad On 12/6/2012 1:05 AM, Vincent Ryan wrote: > Fix looks good. > > On 6 Dec 2012, at 00:16, Jason Uh wrote: > >> Could I please get a review of: >> http://cr.openjdk.java.net/~juh/7193792/webrev.00/ >> >> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7193792 >> >> This change fixes sun/security/pkcs11/ec/TestECDSA.java, which fails on Solaris due to what seems to be an unintended back-to-back call to Signature.initSign(privateKey). On the second initSign, the test fails with CKR_OPERATION_ACTIVE, which means: >> >>> There is already an active operation (or combination of active >>> operations) which prevents Cryptoki from activating the specified >>> operation. ... >> (http://www.cryptsoft.com/pkcs11doc/v220/pkcs11__all_8h.html#aCKR_OPERATION_ACTIVE) >> >> Thanks, >> Jason > From mike.duigou at oracle.com Thu Dec 6 15:39:14 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 06 Dec 2012 23:39:14 +0000 Subject: hg: jdk8/tl: 8004685: add java.util.function to CORE_PKGS.gmk Message-ID: <20121206233914.9C9E847F5F@hg.openjdk.java.net> Changeset: fb1bf5e5bc9e Author: henryjen Date: 2012-12-06 15:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/fb1bf5e5bc9e 8004685: add java.util.function to CORE_PKGS.gmk Reviewed-by: mduigou ! common/makefiles/javadoc/CORE_PKGS.gmk From weijun.wang at oracle.com Fri Dec 7 02:39:16 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 07 Dec 2012 18:39:16 +0800 Subject: Code review request: 8004235: Disable native JGSS provider on Mac Message-ID: <50C1C754.7010504@oracle.com> The native JGSS provider on Mac is not ready yet. Disable the native lib creation. Please review the code changes at http://cr.openjdk.java.net/~weijun/8004235/webrev.00/ *build-dev*: I don't know how to write 2 ifneq on a single line. Thanks Max From kelly.ohair at oracle.com Fri Dec 7 09:39:13 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 7 Dec 2012 09:39:13 -0800 Subject: Code review request: 8004235: Disable native JGSS provider on Mac In-Reply-To: <50C1C754.7010504@oracle.com> References: <50C1C754.7010504@oracle.com> Message-ID: <91FE5067-66EA-4300-962E-1D479AE87590@oracle.com> Looks ok to me. Thanks. -kto On Dec 7, 2012, at 2:39 AM, Weijun Wang wrote: > The native JGSS provider on Mac is not ready yet. Disable the native lib creation. Please review the code changes at > > http://cr.openjdk.java.net/~weijun/8004235/webrev.00/ > > *build-dev*: I don't know how to write 2 ifneq on a single line. > > Thanks > Max > From robert.field at oracle.com Thu Dec 6 21:57:22 2012 From: robert.field at oracle.com (robert.field at oracle.com) Date: Fri, 07 Dec 2012 05:57:22 +0000 Subject: hg: jdk8/tl/jdk: 8003881: Prevent lambda implementing inner classes from allowing the creation of new instances Message-ID: <20121207055741.6431447FA8@hg.openjdk.java.net> Changeset: 896d4af2ebfd Author: rfield Date: 2012-12-06 21:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/896d4af2ebfd 8003881: Prevent lambda implementing inner classes from allowing the creation of new instances Summary: Lambda implementing inner classes now has private constructor (thanks Kumar) Reviewed-by: ksrini ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java + test/java/lang/invoke/lambda/LambdaAccessControlDoPrivilegedTest.java + test/java/lang/invoke/lambda/LambdaAccessControlTest.java From erik.joelsson at oracle.com Fri Dec 7 03:02:37 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 07 Dec 2012 12:02:37 +0100 Subject: Code review request: 8004235: Disable native JGSS provider on Mac In-Reply-To: <50C1C754.7010504@oracle.com> References: <50C1C754.7010504@oracle.com> Message-ID: <50C1CCCD.8050805@oracle.com> From a build point of view, this looks ok. I don't know of an easy way to write 2 ifneqs on the same line either. The way you did it is at least readable and as far as I know the common way of doing it in make. /Erik On 2012-12-07 11:39, Weijun Wang wrote: > The native JGSS provider on Mac is not ready yet. Disable the native > lib creation. Please review the code changes at > > http://cr.openjdk.java.net/~weijun/8004235/webrev.00/ > > *build-dev*: I don't know how to write 2 ifneq on a single line. > > Thanks > Max > From sean.mullan at oracle.com Fri Dec 7 13:05:38 2012 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 07 Dec 2012 16:05:38 -0500 Subject: [8] Code Review Request for 8004064: Downgrade normative references to ${java.home}/lib/security/java.security Message-ID: <50C25A22.5000001@oracle.com> As part of the effort to prepare the platform for modules (see http://openjdk.java.net/jeps/162) we need to re-examine all normative references to files/resources in ${java.home} as these may be candidates to be replaced or candidates to move to module-private locations in the future. The focus of this change are the various security APIs that specify that the default values of security properties are loaded from ${java.home}/lib/security/java.security. We need the flexibility to be able to re-locate this file and its properties to ease the transition to a modular system. The proposed changes remove all references to ${java.home}/lib/security/java.security or "security properties file" from the APIs and adds a reference to the java.security.Security API for more information about security properties. The class definition of the Security class has been adjusted to note that the loading of the default values of security properties is implementation-specific, but that they are typically loaded from the ${java.home}/lib/security/java.security file. webrev: http://cr.openjdk.java.net/~mullan/webrevs/8004064/webrev.00/ bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004064 Thanks, Sean From valerie.peng at oracle.com Fri Dec 7 17:23:00 2012 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Fri, 07 Dec 2012 17:23:00 -0800 Subject: Code Review Request for 6996769: support AEAD ciphers In-Reply-To: <509B481A.6010307@oracle.com> References: <50945D35.8010201@oracle.com> <5098CECB.3020409@oracle.com> <509AE548.4020804@oracle.com> <509B481A.6010307@oracle.com> Message-ID: <50C29674.6000800@oracle.com> Max, The webrev has been updated so that different key + iv values have to be used for AES/GCM encryption. Latest version at: http://cr.openjdk.java.net/~valeriep/6996769/webrev.03/ Please review and send me comments. Thanks! Valerie On 11/07/12 21:50, Valerie (Yu-Ching) Peng wrote: > Max, > > Update: I removed the block (starting line 580 in CipherCore.java) for > handling RC2 since it's never used. > > It turns out that the current impl in RC2Cipher always convert the > AlgorithmParameters object to RC2ParameterSpec and only uses > CipherCore.init(..., AlgorithmParameterSpec,...) method. Thus, I won't > be adding a regression test, but rather simply document the current > RC2Cipher behavior in CipherCore.java to clarify things up. > > The updated webrev is at: > http://cr.openjdk.java.net/~valeriep/6996769/webrev.01/ > > Xuelei brought up the issue of enforcing (Key+IV) uniqueness for GCM > mode during this afternoon's meeting. > I think more changes may be made after we decide what to do. > So, there may be a webrev.02 coming... Just a heads up. > > Thanks! > Valerie > > On 11/07/12 14:48, Valerie (Yu-Ching) Peng wrote: >>> 580 } else if (key.getAlgorithm().equals("RC2")) { >>> >>> This seems a bug fix. Is there a regression test for it? >> I just noticed this problem when make the enhancement for GCM mode. >> I will add a regression test for this. From kumar.x.srinivasan at oracle.com Sun Dec 9 09:17:55 2012 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Sun, 09 Dec 2012 17:17:55 +0000 Subject: hg: jdk8/tl/jdk: 8004042: Arrrghs.java test failed on windows with access error. Message-ID: <20121209171842.20CC747FF6@hg.openjdk.java.net> Changeset: da387f0cecb7 Author: ksrini Date: 2012-12-09 07:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da387f0cecb7 8004042: Arrrghs.java test failed on windows with access error. Reviewed-by: smarks, jjh, ksrini Contributed-by: david.dehaven at oracle.com ! test/tools/launcher/Arrrghs.java ! test/tools/launcher/TestHelper.java From alan.bateman at oracle.com Sun Dec 9 11:13:03 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sun, 09 Dec 2012 19:13:03 +0000 Subject: hg: jdk8/tl/jdk: 7194370: (fs) WatchService fails if volume S/N is 0 [win] Message-ID: <20121209191314.ADFA647FF9@hg.openjdk.java.net> Changeset: 343615aa0539 Author: dxu Date: 2012-12-09 19:13 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/343615aa0539 7194370: (fs) WatchService fails if volume S/N is 0 [win] Reviewed-by: alanb, forax ! src/windows/classes/sun/nio/fs/WindowsFileAttributes.java From xuelei.fan at oracle.com Sun Dec 9 17:59:00 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Mon, 10 Dec 2012 09:59:00 +0800 Subject: [8] Code Review Request for 8004064: Downgrade normative references to ${java.home}/lib/security/java.security In-Reply-To: <50C25A22.5000001@oracle.com> References: <50C25A22.5000001@oracle.com> Message-ID: <50C541E4.4020605@oracle.com> Looks fine to me. A pretty minor comment: src/share/classes/javax/security/auth/login/LoginContext.java ------------------------ 166 * auth.login.defaultCallbackHandler security property for the Do you want to use the "code" tag here, {@code auth.login.defaultCallbackHandler}? Xuelei On 12/8/2012 5:05 AM, Sean Mullan wrote: > As part of the effort to prepare the platform for modules (see > http://openjdk.java.net/jeps/162) we need to re-examine all normative > references to files/resources in ${java.home} as these may be candidates > to be replaced or candidates to move to module-private locations in the > future. > > The focus of this change are the various security APIs that specify that > the default values of security properties are loaded from > ${java.home}/lib/security/java.security. We need the flexibility to be > able to re-locate this file and its properties to ease the transition to > a modular system. > > The proposed changes remove all references to > ${java.home}/lib/security/java.security or "security properties file" > from the APIs and adds a reference to the java.security.Security API for > more information about security properties. The class definition of the > Security class has been adjusted to note that the loading of the default > values of security properties is implementation-specific, but that they > are typically loaded from the ${java.home}/lib/security/java.security file. > > webrev: http://cr.openjdk.java.net/~mullan/webrevs/8004064/webrev.00/ > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004064 > > Thanks, > Sean From masayoshi.okutsu at oracle.com Sun Dec 9 18:01:06 2012 From: masayoshi.okutsu at oracle.com (masayoshi.okutsu at oracle.com) Date: Mon, 10 Dec 2012 02:01:06 +0000 Subject: hg: jdk8/tl/jdk: 8000983: Support narrow display names for calendar fields; ... Message-ID: <20121210020127.5EB7747FFC@hg.openjdk.java.net> Changeset: fda257689786 Author: okutsu Date: 2012-12-10 10:52 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fda257689786 8000983: Support narrow display names for calendar fields 8003267: Support generic time zone names in TimeZoneNameProvider (SPI) Reviewed-by: naoto ! make/tools/src/build/tools/cldrconverter/Bundle.java ! make/tools/src/build/tools/cldrconverter/BundleGenerator.java ! make/tools/src/build/tools/cldrconverter/CLDRConverter.java ! make/tools/src/build/tools/cldrconverter/LDMLParseHandler.java ! make/tools/src/build/tools/cldrconverter/MetaZonesParseHandler.java ! make/tools/src/build/tools/cldrconverter/ResourceBundleGenerator.java ! src/share/classes/java/text/DateFormatSymbols.java ! src/share/classes/java/text/SimpleDateFormat.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/JapaneseImperialCalendar.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/java/util/spi/CalendarNameProvider.java ! src/share/classes/java/util/spi/TimeZoneNameProvider.java ! src/share/classes/sun/text/resources/FormatData.java ! src/share/classes/sun/text/resources/ar/FormatData_ar.java ! src/share/classes/sun/text/resources/be/FormatData_be.java ! src/share/classes/sun/text/resources/bg/FormatData_bg.java ! src/share/classes/sun/text/resources/ca/FormatData_ca.java ! src/share/classes/sun/text/resources/cs/FormatData_cs.java ! src/share/classes/sun/text/resources/da/FormatData_da.java ! src/share/classes/sun/text/resources/de/FormatData_de.java ! src/share/classes/sun/text/resources/el/FormatData_el.java ! src/share/classes/sun/text/resources/es/FormatData_es.java ! src/share/classes/sun/text/resources/et/FormatData_et.java ! src/share/classes/sun/text/resources/fi/FormatData_fi.java ! src/share/classes/sun/text/resources/fr/FormatData_fr.java ! src/share/classes/sun/text/resources/hi/FormatData_hi_IN.java ! src/share/classes/sun/text/resources/hr/FormatData_hr.java ! src/share/classes/sun/text/resources/hu/FormatData_hu.java ! src/share/classes/sun/text/resources/is/FormatData_is.java ! src/share/classes/sun/text/resources/it/FormatData_it.java ! src/share/classes/sun/text/resources/iw/FormatData_iw.java ! src/share/classes/sun/text/resources/ja/FormatData_ja.java ! src/share/classes/sun/text/resources/ko/FormatData_ko.java ! src/share/classes/sun/text/resources/lt/FormatData_lt.java ! src/share/classes/sun/text/resources/lv/FormatData_lv.java ! src/share/classes/sun/text/resources/mk/FormatData_mk.java ! src/share/classes/sun/text/resources/ms/FormatData_ms.java ! src/share/classes/sun/text/resources/mt/FormatData_mt.java ! src/share/classes/sun/text/resources/nl/FormatData_nl.java ! src/share/classes/sun/text/resources/pl/FormatData_pl.java ! src/share/classes/sun/text/resources/pt/FormatData_pt.java ! src/share/classes/sun/text/resources/ro/FormatData_ro.java ! src/share/classes/sun/text/resources/ru/FormatData_ru.java ! src/share/classes/sun/text/resources/sk/FormatData_sk.java ! src/share/classes/sun/text/resources/sl/FormatData_sl.java ! src/share/classes/sun/text/resources/sq/FormatData_sq.java ! src/share/classes/sun/text/resources/sr/FormatData_sr.java ! src/share/classes/sun/text/resources/sv/FormatData_sv.java ! src/share/classes/sun/text/resources/th/FormatData_th.java ! src/share/classes/sun/text/resources/tr/FormatData_tr.java ! src/share/classes/sun/text/resources/uk/FormatData_uk.java ! src/share/classes/sun/text/resources/vi/FormatData_vi.java ! src/share/classes/sun/text/resources/zh/FormatData_zh.java ! src/share/classes/sun/util/cldr/CLDRLocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/CalendarDataUtility.java ! src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/LocaleResources.java ! src/share/classes/sun/util/locale/provider/SPILocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameUtility.java ! src/share/classes/sun/util/resources/LocaleData.java ! src/share/classes/sun/util/resources/OpenListResourceBundle.java ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/TimeZoneNamesBundle.java + test/java/util/Calendar/GenericTimeZoneNamesTest.java + test/java/util/Calendar/GenericTimeZoneNamesTest.sh + test/java/util/Calendar/NarrowNamesTest.java + test/java/util/Calendar/NarrowNamesTest.sh ! test/java/util/PluggableLocale/GenericTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.sh ! test/java/util/PluggableLocale/barprovider.jar + test/java/util/PluggableLocale/providersrc/GenericTimeZoneNameProviderImpl.java ! test/java/util/PluggableLocale/providersrc/Makefile ! test/java/util/PluggableLocale/providersrc/java.util.spi.TimeZoneNameProvider ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java From xuelei.fan at oracle.com Sun Dec 9 19:07:07 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Mon, 10 Dec 2012 11:07:07 +0800 Subject: 7194075: Various classes of sunec.jar are duplicated in rt.jar In-Reply-To: <50B431A3.3080808@oracle.com> References: <50B431A3.3080808@oracle.com> Message-ID: <50C551DB.9060404@oracle.com> Hi Stephen, The update in JsseJce.java update the behaviors of SunJSSE provider. Need more time to evaluate the impact. For a particular standard named curve of EC, I think the ECParameterSpec does not change in different providers. I was wondering, is it necessary to bind the ECParameterSpec with a particular provider? in ECUtil, you have methods like this one: ECParameterSpec getECParameterSpec(Provider p, ECParameterSpec spec) I think it converts from one ECParameterSpec object to another ECParameterSpec object. What's the usage of this method? And this one: ECParameterSpec getECParameterSpec(Provider p, String name) For named curves, is it possible to make methods like this one to be provider independent? Regards, Xuelei On 11/27/2012 11:21 AM, Stephen Flores wrote: > Vincent, Sean, > > Please review the fix for: > > CR 7194075: Various classes of sunec.jar are duplicated in rt.jar > > http://cr.openjdk.java.net/~sflores/7194075/webrev-1/ > > Changes: > > *Changed/renamed any of methods that did not support the public API to > package private. > > *Moved the decode and encode point methods out of ECParameters to a new > class sun.security.util.ECUtil. > > *Changed any "new byte[], System.arraycopy" blocks in ECUtil point > methods to Arrays.copyOfRange. > > *Added a new AlgorithmParameterSpec in sun.security.util to get curves > by key size, for PKCS11 to use. > > *Moved all of static lookup methods in ECParameters, NamedCurve and the > curve repository to separate class (CurveDB). This made ECParameters and > NamedCurve cleaner and easier work on (there was some ECParameters cleanup. > > *In JSSE and PKCS11 and changed the references to ECParmeters and > NamedCurve to the ECUtil which has utility methods that use the public > APIs. > > *Changed to the EC unit test to use the list of supported curves in the > property that the SunEC provider has already. > > *Changed SunECEntries to build the list of supported curves property > from the collection in CurveDB. > > *Changed the JDK makefiles to not duplicate EC classes in rt.jar. > > Thanks, > > Steve. From Alan.Bateman at oracle.com Mon Dec 10 03:14:24 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 10 Dec 2012 11:14:24 +0000 Subject: [8] Code Review Request for 8004064: Downgrade normative references to ${java.home}/lib/security/java.security In-Reply-To: <50C25A22.5000001@oracle.com> References: <50C25A22.5000001@oracle.com> Message-ID: <50C5C410.6060904@oracle.com> On 07/12/2012 21:05, Sean Mullan wrote: > As part of the effort to prepare the platform for modules (see > http://openjdk.java.net/jeps/162) we need to re-examine all normative > references to files/resources in ${java.home} as these may be > candidates to be replaced or candidates to move to module-private > locations in the future. > > The focus of this change are the various security APIs that specify > that the default values of security properties are loaded from > ${java.home}/lib/security/java.security. We need the flexibility to be > able to re-locate this file and its properties to ease the transition > to a modular system. > > The proposed changes remove all references to > ${java.home}/lib/security/java.security or "security properties file" > from the APIs and adds a reference to the java.security.Security API > for more information about security properties. The class definition > of the Security class has been adjusted to note that the loading of > the default values of security properties is implementation-specific, > but that they are typically loaded from the > ${java.home}/lib/security/java.security file. > > webrev: http://cr.openjdk.java.net/~mullan/webrevs/8004064/webrev.00/ > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004064 This looks fine to me. I see Xuelei's comment suggesting changing the .. usages to {@code ..} and that seems a good idea while you are there. -Alan From maurizio.cimadamore at oracle.com Mon Dec 10 04:31:47 2012 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Mon, 10 Dec 2012 12:31:47 +0000 Subject: hg: jdk8/tl/langtools: 8004094: Javac compiler error - synthetic method accessor generated with duplicate name Message-ID: <20121210123154.906744700B@hg.openjdk.java.net> Changeset: c78acf6c2f3e Author: mcimadamore Date: 2012-12-10 12:10 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c78acf6c2f3e 8004094: Javac compiler error - synthetic method accessor generated with duplicate name Summary: method clash check logic should skip methods marked with ACC_SYNTHETIC Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/8004094/B.java + test/tools/javac/generics/8004094/T8004094.java From martin.goldhahn at uis.no Mon Dec 10 05:05:29 2012 From: martin.goldhahn at uis.no (Martin Goldhahn) Date: Mon, 10 Dec 2012 13:05:29 +0000 Subject: LdapLoginModule bug or intention? Message-ID: <0DBE160126BFB549A3C98820868B0D180B122AC3@EXMB02.uis.no> I have the following login config to get UserPrincipals for groups: COMBI { com.sun.security.auth.module.LdapLoginModule REQUIRED debug="true" userProvider="ldaps://ad01.uis.no/dc=uis,dc=no" userFilter="(&(sAMAccountName={USERNAME})(objectClass=user))" java.naming.security.principal="AD_DN" java.naming.security.credentials="PASSWORD" storePass="true" ; com.sun.security.auth.module.LdapLoginModule OPTIONAL debug="true" userProvider="ldaps://ad01.uis.no/dc=uis,dc=no" userFilter="(&(sAMAccountName={USERNAME})(objectClass=user)(memberOf=CN=Solr-Admin,OU=ServiceGroup,OU=Operation,OU=UIS,DC=uis,DC=no))" authzIdentity="SolrAdmin" java.naming.security.principal="AD_DN" java.naming.security.credentials="PASSWORD" useFirstPass="true" ; com.sun.security.auth.module.LdapLoginModule OPTIONAL debug="true" userProvider="ldaps://ad01.uis.no/dc=uis,dc=no" userFilter="(&(sAMAccountName={USERNAME})(objectClass=user)(memberOf=CN=FullServerAdmin_Utvikling,OU=AdminGroups,OU=Administration,DC=uis,DC=no))" authzIdentity="ServerAdmin" java.naming.security.principal="AD_DN" java.naming.security.credentials="PASSWORD" useFirstPass="true" ; }; The first component succeeds, the second fails (due to the filter returning nothing), the third is supposed to succeed, but fails. The reason is that the sharedState's password is cleared, even though clearPass is false (https://github.com/openjdk-mirror/jdk7u-jdk/blob/master/src/share/classes/com/sun/security/auth/module/LdapLoginModule.java#L1000) Should it be username=null; if (clearPass) { Arrays.fill(password, ' '); } password = null; OR is this by design? -- Martin From sean.mullan at oracle.com Mon Dec 10 06:15:33 2012 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 10 Dec 2012 09:15:33 -0500 Subject: [8] Code Review Request for 8004064: Downgrade normative references to ${java.home}/lib/security/java.security In-Reply-To: <50C541E4.4020605@oracle.com> References: <50C25A22.5000001@oracle.com> <50C541E4.4020605@oracle.com> Message-ID: <50C5EE85.4080202@oracle.com> On 12/09/2012 08:59 PM, Xuelei Fan wrote: > Looks fine to me. A pretty minor comment: > > src/share/classes/javax/security/auth/login/LoginContext.java > ------------------------ > 166 * auth.login.defaultCallbackHandler security property for the > > Do you want to use the "code" tag here, {@code > auth.login.defaultCallbackHandler}? Sure, I can make that change. Thanks, Sean > > > Xuelei > > On 12/8/2012 5:05 AM, Sean Mullan wrote: >> As part of the effort to prepare the platform for modules (see >> http://openjdk.java.net/jeps/162) we need to re-examine all normative >> references to files/resources in ${java.home} as these may be candidates >> to be replaced or candidates to move to module-private locations in the >> future. >> >> The focus of this change are the various security APIs that specify that >> the default values of security properties are loaded from >> ${java.home}/lib/security/java.security. We need the flexibility to be >> able to re-locate this file and its properties to ease the transition to >> a modular system. >> >> The proposed changes remove all references to >> ${java.home}/lib/security/java.security or "security properties file" >> from the APIs and adds a reference to the java.security.Security API for >> more information about security properties. The class definition of the >> Security class has been adjusted to note that the loading of the default >> values of security properties is implementation-specific, but that they >> are typically loaded from the ${java.home}/lib/security/java.security file. >> >> webrev: http://cr.openjdk.java.net/~mullan/webrevs/8004064/webrev.00/ >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004064 >> >> Thanks, >> Sean > From michael.x.mcmahon at oracle.com Mon Dec 10 07:06:03 2012 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Mon, 10 Dec 2012 15:06:03 +0000 Subject: hg: jdk8/tl/jdk: 8003948: NTLM/Negotiate authentication problem Message-ID: <20121210150632.D753A47015@hg.openjdk.java.net> Changeset: fda2b2b5b98b Author: michaelm Date: 2012-12-10 14:56 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fda2b2b5b98b 8003948: NTLM/Negotiate authentication problem Reviewed-by: chegar, weijun ! src/share/classes/sun/net/www/MessageHeader.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/net/www/MessageHeaderTest.java From mandy.chung at oracle.com Mon Dec 10 15:17:53 2012 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Mon, 10 Dec 2012 23:17:53 +0000 Subject: hg: jdk8/tl/jdk: 4819681: Typo in http://java.sun.com/j2se/1.4.1/docs/api/java/util/logging/LogManager.html Message-ID: <20121210231812.B49ED47020@hg.openjdk.java.net> Changeset: cac1bfaceaaa Author: mchung Date: 2012-12-10 15:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cac1bfaceaaa 4819681: Typo in http://java.sun.com/j2se/1.4.1/docs/api/java/util/logging/LogManager.html Summary: Simple capitalization typo in LogManager() description Reviewed-by: darcy, mchung ! src/share/classes/java/util/logging/LogManager.java From luchsh at linux.vnet.ibm.com Mon Dec 10 18:42:58 2012 From: luchsh at linux.vnet.ibm.com (luchsh at linux.vnet.ibm.com) Date: Tue, 11 Dec 2012 02:42:58 +0000 Subject: hg: jdk8/tl/jdk: 6512101: Incorrect encoding in NetworkInterface.getDisplayName() Message-ID: <20121211024324.4C83147036@hg.openjdk.java.net> Changeset: 883feced1cdd Author: dingxmin Date: 2012-12-11 10:42 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/883feced1cdd 6512101: Incorrect encoding in NetworkInterface.getDisplayName() Reviewed-by: chegar, dsamersoff ! src/windows/native/java/net/NetworkInterface.c From weijun.wang at oracle.com Mon Dec 10 21:15:30 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Tue, 11 Dec 2012 05:15:30 +0000 Subject: hg: jdk8/tl/jdk: 8004488: wrong permissions checked in krb5 Message-ID: <20121211051541.92D194703D@hg.openjdk.java.net> Changeset: d206e52bf8a6 Author: weijun Date: 2012-12-11 13:14 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d206e52bf8a6 8004488: wrong permissions checked in krb5 Reviewed-by: xuelei ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java ! src/share/classes/sun/security/jgss/krb5/Krb5Util.java + test/sun/security/krb5/auto/KeyPermissions.java ! test/sun/security/krb5/auto/KeyTabCompat.java From jonathan.gibbons at oracle.com Tue Dec 11 08:28:33 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 11 Dec 2012 16:28:33 +0000 Subject: hg: jdk8/tl/langtools: 8003967: detect and remove all mutable implicit static enum fields in langtools Message-ID: <20121211162835.DAC7347067@hg.openjdk.java.net> Changeset: fcf89720ae71 Author: vromero Date: 2012-12-10 16:21 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fcf89720ae71 8003967: detect and remove all mutable implicit static enum fields in langtools Reviewed-by: jjg ! src/share/classes/com/sun/tools/classfile/Opcode.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFileFactory.java ! src/share/classes/com/sun/tools/javac/Server.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/TargetType.java ! src/share/classes/com/sun/tools/javac/code/TypeTag.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/ConstFold.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/MandatoryWarningHandler.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javah/JavahTask.java ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/share/classes/javax/lang/model/element/Modifier.java ! src/share/classes/javax/lang/model/util/ElementFilter.java ! src/share/classes/javax/tools/StandardLocation.java + test/tools/javac/T8003967/DetectMutableStaticFields.java From jonathan.gibbons at oracle.com Tue Dec 11 15:05:56 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 11 Dec 2012 23:05:56 +0000 Subject: hg: jdk8/tl/langtools: 8004828: refactor init of *DocImpl classes Message-ID: <20121211230601.6FED947097@hg.openjdk.java.net> Changeset: cfde9737131e Author: jjg Date: 2012-12-11 15:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cfde9737131e 8004828: refactor init of *DocImpl classes Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ConstructorDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java ! src/share/classes/com/sun/tools/javadoc/MemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ProgramElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java From mike.duigou at oracle.com Tue Dec 11 15:49:54 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Tue, 11 Dec 2012 23:49:54 +0000 Subject: hg: jdk8/tl/jdk: 8003246: Add InitialValue Supplier to ThreadLocal Message-ID: <20121211235017.14A764709A@hg.openjdk.java.net> Changeset: c4bd81de2868 Author: akhil Date: 2012-12-11 15:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4bd81de2868 8003246: Add InitialValue Supplier to ThreadLocal Reviewed-by: mduigou, forax, dl, chegar, briangoetz ! src/share/classes/java/lang/ThreadLocal.java + test/java/lang/ThreadLocal/ThreadLocalSupplierTest.java From xuelei.fan at oracle.com Tue Dec 11 17:12:25 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 12 Dec 2012 09:12:25 +0800 Subject: Code Review Request, 7109274, Consider disabling support for X.509 certificates with RSA keys less than 1024 bits Message-ID: <50C7D9F9.8080503@oracle.com> Hi, Please review the update for JDK-7109274, Consider disabling support for X.509 certificates with RSA keys less than 1024 bits. Webrev: http://cr.openjdk.java.net./~xuelei/7109274/webrev.00/ The bug description is not available at bugs.sun.com at present. The purpose of this update is to disable the support of X.509 certificates with RSA keys less than 1024 bits. The key length is an important security parameter to determine the strength of public key based cryptographic algorithms. RSA keys less than 1024 bits are considered breakable [1][2]. In this update, we are proposing to restrict the use of certificates with RSA keys less than 1024 bits in length. This restriction is applied via the Java Security property, "jdk.certpath.disabledAlgorithms" [1]. This will impact providers that adhere to this security property, for example, the Sun provider and the SunJSSE provider. The security property, "jdk.certpath.disabledAlgorithms", also covers the use of the static keys (the key in X.509 certificate) used in TLS. Therefore, we don't need to add any further restrictions to the "jdk.tls.disabledAlgorithms" security property. With this key size restriction, those who use X.509 certificates based on RSA keys less than 1024 bits will encounter compatibility issues with certification path building and validation. This key size restriction also impacts JDK components that validate X.509 certificates, for example signed JAR verification, SSL/TLS transportation, HTTPS connections, etc. In order to avoid the compatibility issue, users who use X.509 certificates with RSA keys less than 1024 bits are recommended to renew their certificates with stronger keys. As a workaround, at their own risks, users can adjust the key size restriction security property ("jdk.certpath.disabledAlgorithms") or use the java.security.AlgorithmConstraints (introduced in JDK 7) to permit smaller key sizes. Thanks, Xuelei [1]: http://blogs.rsa.com/rsa-768-factored/ [2]: http://technet.microsoft.com/en-us/security/advisory/2661254 From weijun.wang at oracle.com Tue Dec 11 19:32:46 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 12 Dec 2012 11:32:46 +0800 Subject: Code review: 8004904: Makefile for ntlm (was Re: com/sun/security/ntlm) In-Reply-To: <50C7DDBE.7060501@oracle.com> References: <3664010d-a5c4-43f2-9c2a-abdce4e93621@default> <50C77272.7000905@oracle.com> <50C7DDBE.7060501@oracle.com> Message-ID: <50C7FADE.2090709@oracle.com> Hi Chris/Mark I've added a makefile, please take a look http://cr.openjdk.java.net/~weijun/8004904/webrev.00/ *build-dev* guys, I guess this won't affect the new build style. Thanks Max On 12/12/2012 09:28 AM, Weijun Wang wrote: > > > On 12/12/2012 01:50 AM, Chris Hegarty wrote: >> Max, >> >> Mark is looking to recompile com/sun/security/ntlm/Client.java during an >> incremental build. I cannot find explicit targets for the >> com/sun/security/ntlm files, are these compiled implicitly by reference >> from other source? Is there a way of forcing these to be recompiled? >> >> I admit, it is strange to me to find a complete package without some >> kind of explicit reference in the makefiles, but maybe I just cannot >> find it! > > No, you cannot find it. There was no Makefile when those files were added: > > http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9be643e70f42 > > Thanks > Max > > >> >> -Chris. >> >> On 12/11/2012 05:36 PM, Mark Sheppard wrote: >>> >>> Client.java >>> >>> I modified files in other parts of jdk under sun.net >>> and these were rebuilt >>> >>> >>> regards >>> Mark >>> ----- Original Message ----- >>> From: chris.hegarty at oracle.com >>> To: mark.sheppard at oracle.com >>> Sent: Tuesday, December 11, 2012 5:32:32 PM GMT +00:00 GMT Britain, >>> Ireland, Portugal >>> Subject: Re: com/sun/security/ntlm >>> >>> What's the actual filename? >>> >>> -Chris. >>> >>> On 12/11/2012 05:15 PM, Mark Sheppard wrote: >>>> >>>> Hi Chris, >>>> I need some extra debug and modified a few files e.g. >>>> com.sun.security.ntlm.Client.java. But the modified files >>>> do not seem to have been rebuilt. >>>> >>>> Can you think of anything obvious that I may have overlooked. >>>> >>>> How can I force a rebuild of this component - partial build >>>> >>>> regards >>>> Mark >>>> From mike.duigou at oracle.com Tue Dec 11 20:50:55 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Wed, 12 Dec 2012 04:50:55 +0000 Subject: hg: jdk8/tl/jdk: 8004905: Correct license of test to remove classpath exception Message-ID: <20121212045118.9651C470AE@hg.openjdk.java.net> Changeset: 6c795437f212 Author: mduigou Date: 2012-12-11 20:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6c795437f212 8004905: Correct license of test to remove classpath exception Reviewed-by: akhil ! test/java/lang/ThreadLocal/ThreadLocalSupplierTest.java From erik.joelsson at oracle.com Wed Dec 12 00:47:45 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 12 Dec 2012 09:47:45 +0100 Subject: Code review: 8004904: Makefile for ntlm (was Re: com/sun/security/ntlm) In-Reply-To: <50C7FADE.2090709@oracle.com> References: <3664010d-a5c4-43f2-9c2a-abdce4e93621@default> <50C77272.7000905@oracle.com> <50C7DDBE.7060501@oracle.com> <50C7FADE.2090709@oracle.com> Message-ID: <50C844B1.3040909@oracle.com> That is correct, the new build will already handle incremental building of any changed java file, so this won't make a difference. Thanks for the heads up anyway! /Erik On 2012-12-12 04:32, Weijun Wang wrote: > Hi Chris/Mark > > I've added a makefile, please take a look > > http://cr.openjdk.java.net/~weijun/8004904/webrev.00/ > > *build-dev* guys, I guess this won't affect the new build style. > > Thanks > Max > > > On 12/12/2012 09:28 AM, Weijun Wang wrote: >> >> >> On 12/12/2012 01:50 AM, Chris Hegarty wrote: >>> Max, >>> >>> Mark is looking to recompile com/sun/security/ntlm/Client.java >>> during an >>> incremental build. I cannot find explicit targets for the >>> com/sun/security/ntlm files, are these compiled implicitly by reference >>> from other source? Is there a way of forcing these to be recompiled? >>> >>> I admit, it is strange to me to find a complete package without some >>> kind of explicit reference in the makefiles, but maybe I just cannot >>> find it! >> >> No, you cannot find it. There was no Makefile when those files were >> added: >> >> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9be643e70f42 >> >> Thanks >> Max >> >> >>> >>> -Chris. >>> >>> On 12/11/2012 05:36 PM, Mark Sheppard wrote: >>>> >>>> Client.java >>>> >>>> I modified files in other parts of jdk under sun.net >>>> and these were rebuilt >>>> >>>> >>>> regards >>>> Mark >>>> ----- Original Message ----- >>>> From: chris.hegarty at oracle.com >>>> To: mark.sheppard at oracle.com >>>> Sent: Tuesday, December 11, 2012 5:32:32 PM GMT +00:00 GMT Britain, >>>> Ireland, Portugal >>>> Subject: Re: com/sun/security/ntlm >>>> >>>> What's the actual filename? >>>> >>>> -Chris. >>>> >>>> On 12/11/2012 05:15 PM, Mark Sheppard wrote: >>>>> >>>>> Hi Chris, >>>>> I need some extra debug and modified a few files e.g. >>>>> com.sun.security.ntlm.Client.java. But the modified files >>>>> do not seem to have been rebuilt. >>>>> >>>>> Can you think of anything obvious that I may have overlooked. >>>>> >>>>> How can I force a rebuild of this component - partial build >>>>> >>>>> regards >>>>> Mark >>>>> From chris.hegarty at oracle.com Wed Dec 12 01:43:32 2012 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 12 Dec 2012 09:43:32 +0000 Subject: Code review: 8004904: Makefile for ntlm (was Re: com/sun/security/ntlm) In-Reply-To: <50C7FADE.2090709@oracle.com> References: <3664010d-a5c4-43f2-9c2a-abdce4e93621@default> <50C77272.7000905@oracle.com> <50C7DDBE.7060501@oracle.com> <50C7FADE.2090709@oracle.com> Message-ID: <50C851C4.3060105@oracle.com> Thank you Max, looks fine to me. -Chris. On 12/12/2012 03:32, Weijun Wang wrote: > Hi Chris/Mark > > I've added a makefile, please take a look > > http://cr.openjdk.java.net/~weijun/8004904/webrev.00/ > > *build-dev* guys, I guess this won't affect the new build style. > > Thanks > Max > > > On 12/12/2012 09:28 AM, Weijun Wang wrote: >> >> >> On 12/12/2012 01:50 AM, Chris Hegarty wrote: >>> Max, >>> >>> Mark is looking to recompile com/sun/security/ntlm/Client.java during an >>> incremental build. I cannot find explicit targets for the >>> com/sun/security/ntlm files, are these compiled implicitly by reference >>> from other source? Is there a way of forcing these to be recompiled? >>> >>> I admit, it is strange to me to find a complete package without some >>> kind of explicit reference in the makefiles, but maybe I just cannot >>> find it! >> >> No, you cannot find it. There was no Makefile when those files were >> added: >> >> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9be643e70f42 >> >> Thanks >> Max >> >> >>> >>> -Chris. >>> >>> On 12/11/2012 05:36 PM, Mark Sheppard wrote: >>>> >>>> Client.java >>>> >>>> I modified files in other parts of jdk under sun.net >>>> and these were rebuilt >>>> >>>> >>>> regards >>>> Mark >>>> ----- Original Message ----- >>>> From: chris.hegarty at oracle.com >>>> To: mark.sheppard at oracle.com >>>> Sent: Tuesday, December 11, 2012 5:32:32 PM GMT +00:00 GMT Britain, >>>> Ireland, Portugal >>>> Subject: Re: com/sun/security/ntlm >>>> >>>> What's the actual filename? >>>> >>>> -Chris. >>>> >>>> On 12/11/2012 05:15 PM, Mark Sheppard wrote: >>>>> >>>>> Hi Chris, >>>>> I need some extra debug and modified a few files e.g. >>>>> com.sun.security.ntlm.Client.java. But the modified files >>>>> do not seem to have been rebuilt. >>>>> >>>>> Can you think of anything obvious that I may have overlooked. >>>>> >>>>> How can I force a rebuild of this component - partial build >>>>> >>>>> regards >>>>> Mark >>>>> From weijun.wang at oracle.com Wed Dec 12 02:41:08 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 12 Dec 2012 10:41:08 +0000 Subject: hg: jdk8/tl/jdk: 8004904: Makefile for ntlm Message-ID: <20121212104501.70F4F470BB@hg.openjdk.java.net> Changeset: 12fba0974a9d Author: weijun Date: 2012-12-12 18:39 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/12fba0974a9d 8004904: Makefile for ntlm Reviewed-by: erikj, chegar ! make/com/sun/security/Makefile + make/com/sun/security/ntlm/Makefile From chris.hegarty at oracle.com Wed Dec 12 03:36:21 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 12 Dec 2012 11:36:21 +0000 Subject: hg: jdk8/tl/jdk: 8004921: Trivial javadoc warnings in Base64 Message-ID: <20121212113645.3471B470BD@hg.openjdk.java.net> Changeset: 806cf26e5063 Author: chegar Date: 2012-12-12 11:35 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/806cf26e5063 8004921: Trivial javadoc warnings in Base64 Reviewed-by: darcy ! src/share/classes/java/util/Base64.java From alan.bateman at oracle.com Wed Dec 12 05:06:39 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 12 Dec 2012 13:06:39 +0000 Subject: hg: jdk8/tl/jdk: 8004874: Reduce dependency on java.beans to only add/removePropertyChangeListener Message-ID: <20121212130702.533D2470BE@hg.openjdk.java.net> Changeset: 81640e75c7a7 Author: alanb Date: 2012-12-12 13:03 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81640e75c7a7 8004874: Reduce dependency on java.beans to only add/removePropertyChangeListener Reviewed-by: ksrini, mchung, dholmes ! src/share/classes/com/sun/java/util/jar/pack/PropMap.java ! src/share/classes/java/util/logging/LogManager.java From sean.mullan at oracle.com Wed Dec 12 06:48:39 2012 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Wed, 12 Dec 2012 14:48:39 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20121212144946.95267470C0@hg.openjdk.java.net> Changeset: 346c0af4af41 Author: mullan Date: 2012-12-12 09:25 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/346c0af4af41 8004064: Downgrade normative references to ${java.home}/lib/security/java.security Reviewed-by: alanb, vinnie, xuelei ! src/share/classes/com/sun/net/ssl/KeyManagerFactory.java ! src/share/classes/com/sun/net/ssl/TrustManagerFactory.java ! src/share/classes/com/sun/security/auth/PolicyFile.java ! src/share/classes/com/sun/security/auth/login/ConfigFile.java ! src/share/classes/java/net/doc-files/net-properties.html ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/Policy.java ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/cert/CertPathBuilder.java ! src/share/classes/java/security/cert/CertPathValidator.java ! src/share/classes/java/security/cert/CertStore.java ! src/share/classes/javax/net/ssl/KeyManagerFactory.java ! src/share/classes/javax/net/ssl/TrustManagerFactory.java ! src/share/classes/javax/security/auth/Policy.java ! src/share/classes/javax/security/auth/callback/CallbackHandler.java ! src/share/classes/javax/security/auth/login/Configuration.java ! src/share/classes/javax/security/auth/login/LoginContext.java ! src/share/classes/javax/security/cert/X509Certificate.java Changeset: c7f86908d5fd Author: mullan Date: 2012-12-12 09:27 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c7f86908d5fd Merge - src/share/lib/security/java.security From rob.mckenna at oracle.com Wed Dec 12 07:53:52 2012 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Wed, 12 Dec 2012 15:53:52 +0000 Subject: hg: jdk8/tl/jdk: 8004337: java/sql tests aren't run in test/Makefile Message-ID: <20121212155414.29B01470C5@hg.openjdk.java.net> Changeset: 68374c6e65c1 Author: robm Date: 2012-12-12 15:57 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68374c6e65c1 8004337: java/sql tests aren't run in test/Makefile Reviewed-by: lancea, alanb ! test/Makefile From sean.mullan at oracle.com Wed Dec 12 09:52:26 2012 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 12 Dec 2012 12:52:26 -0500 Subject: [8] Code Review Request for 8004234: Downgrade normative references to ${java.home}/lib/security/krb5.conf Message-ID: <50C8C45A.300@oracle.com> The rationale for this fix is the same as the previous review request [1] to downgrade normative references to ${java.home}/lib/security/java.security. This change is much smaller and only affects the javax.security.auth.kerberos package description. webrev: http://cr.openjdk.java.net/~mullan/webrevs/8004234/webrev.00 bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004234 Thanks, Sean [1] http://mail.openjdk.java.net/pipermail/security-dev/2012-December/006144.html From stuart.marks at oracle.com Wed Dec 12 10:16:18 2012 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Wed, 12 Dec 2012 18:16:18 +0000 Subject: hg: jdk8/tl/jdk: 8004748: clean up @build tags in RMI tests Message-ID: <20121212181630.EDE2E470CD@hg.openjdk.java.net> Changeset: bd84d0927a2e Author: smarks Date: 2012-12-12 09:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd84d0927a2e 8004748: clean up @build tags in RMI tests Reviewed-by: alanb, darcy, mchung ! test/java/rmi/MarshalledObject/compare/Compare.java ! test/java/rmi/MarshalledObject/compare/HashCode.java ! test/java/rmi/MarshalledObject/compare/NullReference.java ! test/java/rmi/Naming/DefaultRegistryPort.java ! test/java/rmi/Naming/LookupIPv6.java ! test/java/rmi/Naming/RmiIsNoScheme.java ! test/java/rmi/Naming/UnderscoreHost.java ! test/java/rmi/Naming/legalRegistryNames/LegalRegistryNames.java ! test/java/rmi/RMISecurityManager/checkPackageAccess/CheckPackageAccess.java ! test/java/rmi/activation/Activatable/checkActivateRef/CheckActivateRef.java ! test/java/rmi/activation/Activatable/checkAnnotations/CheckAnnotations.java ! test/java/rmi/activation/Activatable/checkImplClassLoader/CheckImplClassLoader.java ! test/java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java ! test/java/rmi/activation/Activatable/createPrivateActivable/CreatePrivateActivatable.java ! test/java/rmi/activation/Activatable/downloadParameterClass/DownloadParameterClass.java ! test/java/rmi/activation/Activatable/elucidateNoSuchMethod/ElucidateNoSuchMethod.java ! test/java/rmi/activation/Activatable/extLoadedImpl/ext.sh ! test/java/rmi/activation/Activatable/forceLogSnapshot/ForceLogSnapshot.java ! test/java/rmi/activation/Activatable/inactiveGroup/InactiveGroup.java ! test/java/rmi/activation/Activatable/lookupActivationSystem/LookupActivationSystem.java ! test/java/rmi/activation/Activatable/nestedActivate/NestedActivate.java ! test/java/rmi/activation/Activatable/nonExistentActivatable/NonExistentActivatable.java ! test/java/rmi/activation/Activatable/restartCrashedService/RestartCrashedService.java ! test/java/rmi/activation/Activatable/restartLatecomer/RestartLatecomer.java ! test/java/rmi/activation/Activatable/restartService/RestartService.java ! test/java/rmi/activation/Activatable/shutdownGracefully/ShutdownGracefully.java ! test/java/rmi/activation/Activatable/unregisterInactive/UnregisterInactive.java ! test/java/rmi/activation/ActivateFailedException/activateFails/ActivateFails.java ! test/java/rmi/activation/ActivationGroup/downloadActivationGroup/DownloadActivationGroup.java ! test/java/rmi/activation/ActivationGroupDesc/checkDefaultGroupName/CheckDefaultGroupName.java ! test/java/rmi/activation/ActivationSystem/activeGroup/IdempotentActiveGroup.java ! test/java/rmi/activation/ActivationSystem/modifyDescriptor/ModifyDescriptor.java ! test/java/rmi/activation/ActivationSystem/stubClassesPermitted/StubClassesPermitted.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup.java ! test/java/rmi/activation/CommandEnvironment/NullOptions.java ! test/java/rmi/activation/CommandEnvironment/SetChildEnv.java ! test/java/rmi/activation/checkusage/CheckUsage.java ! test/java/rmi/activation/log/LogTest.java ! test/java/rmi/activation/rmidViaInheritedChannel/InheritedChannelNotServerSocket.java ! test/java/rmi/activation/rmidViaInheritedChannel/RmidViaInheritedChannel.java ! test/java/rmi/dgc/VMID/CheckVMID.java ! test/java/rmi/dgc/dgcAckFailure/DGCAckFailure.java ! test/java/rmi/dgc/dgcImplInsulation/DGCImplInsulation.java ! test/java/rmi/dgc/retryDirtyCalls/RetryDirtyCalls.java ! test/java/rmi/invalidName/InvalidName.java ! test/java/rmi/registry/altSecurityManager/AltSecurityManager.java ! test/java/rmi/registry/checkusage/CheckUsage.java ! test/java/rmi/registry/classPathCodebase/ClassPathCodebase.java ! test/java/rmi/registry/interfaceHash/InterfaceHash.java ! test/java/rmi/registry/multipleRegistries/MultipleRegistries.java ! test/java/rmi/registry/readTest/readTest.sh ! test/java/rmi/registry/reexport/Reexport.java ! test/java/rmi/reliability/benchmark/runRmiBench.sh ! test/java/rmi/reliability/benchmark/runSerialBench.sh ! test/java/rmi/reliability/juicer/AppleUserImpl.java ! test/java/rmi/server/ObjID/randomIDs/RandomIDs.java ! test/java/rmi/server/RMIClassLoader/delegateBeforePermissionCheck/DelegateBeforePermissionCheck.java ! test/java/rmi/server/RMIClassLoader/delegateToContextLoader/DelegateToContextLoader.java ! test/java/rmi/server/RMIClassLoader/downloadArrayClass/DownloadArrayClass.java ! test/java/rmi/server/RMIClassLoader/getClassAnnotation/NullClass.java ! test/java/rmi/server/RMIClassLoader/getClassLoader/GetClassLoader.java ! test/java/rmi/server/RMIClassLoader/loadProxyClasses/LoadProxyClasses.java ! test/java/rmi/server/RMIClassLoader/noSecurityManager/NoSecurityManager.java ! test/java/rmi/server/RMIClassLoader/spi/ContextInsulation.java ! test/java/rmi/server/RMIClassLoader/spi/DefaultProperty.java ! test/java/rmi/server/RMIClassLoader/spi/Installed.java ! test/java/rmi/server/RMIClassLoader/spi/InvalidProperty.java ! test/java/rmi/server/RMIClassLoader/spi/Property.java ! test/java/rmi/server/RMIClassLoader/useCodebaseOnly/UseCodebaseOnly.java ! test/java/rmi/server/RMIClassLoader/useGetURLs/UseGetURLs.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/UseCustomSocketFactory.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/registry/UseCustomSocketFactory.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/UseCustomSocketFactory.java ! test/java/rmi/server/RemoteObject/notExtending/NotExtending.java ! test/java/rmi/server/RemoteObject/verifyRemoteEquals/VerifyRemoteEquals.java ! test/java/rmi/server/RemoteServer/AddrInUse.java ! test/java/rmi/server/UnicastRemoteObject/changeHostName/ChangeHostName.java ! test/java/rmi/server/UnicastRemoteObject/exportObject/GcDuringExport.java ! test/java/rmi/server/UnicastRemoteObject/keepAliveDuringCall/KeepAliveDuringCall.java ! test/java/rmi/server/UnicastRemoteObject/marshalAfterUnexport/MarshalAfterUnexport.java ! test/java/rmi/server/UnicastRemoteObject/marshalAfterUnexport/MarshalAfterUnexport2.java ! test/java/rmi/server/UnicastRemoteObject/unexportObject/UnexportLeak.java ! test/java/rmi/server/Unmarshal/PrimitiveClasses.java + test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshal.java ! test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshalOnStopThread.java - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java ! test/java/rmi/server/Unreferenced/finiteGCLatency/FiniteGCLatency.java ! test/java/rmi/server/Unreferenced/leaseCheckInterval/LeaseCheckInterval.java ! test/java/rmi/server/Unreferenced/marshalledObjectGet/MarshalledObjectGet.java ! test/java/rmi/server/Unreferenced/unreferencedContext/UnreferencedContext.java ! test/java/rmi/server/clientStackTrace/ClientStackTrace.java ! test/java/rmi/server/getRemoteClass/GetRemoteClass.java ! test/java/rmi/server/serverStackTrace/ServerStackTrace.java ! test/java/rmi/server/serverStackTrace/SuppressStackTraces.java ! test/java/rmi/server/useCustomRef/UseCustomRef.java ! test/java/rmi/transport/acceptLoop/CloseServerSocketOnTermination.java ! test/java/rmi/transport/checkFQDN/CheckFQDN.java ! test/java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java ! test/java/rmi/transport/closeServerSocket/CloseServerSocket.java ! test/java/rmi/transport/dgcDeadLock/DGCDeadLock.java ! test/java/rmi/transport/handshakeFailure/HandshakeFailure.java ! test/java/rmi/transport/handshakeTimeout/HandshakeTimeout.java ! test/java/rmi/transport/httpSocket/HttpSocketTest.java ! test/java/rmi/transport/rapidExportUnexport/RapidExportUnexport.java ! test/java/rmi/transport/readTimeout/ReadTimeoutTest.java ! test/java/rmi/transport/reuseDefaultPort/ReuseDefaultPort.java ! test/java/rmi/transport/runtimeThreadInheritanceLeak/RuntimeThreadInheritanceLeak.java ! test/javax/rmi/ssl/SocketFactoryTest.java ! test/sun/rmi/log/ReliableLog/LogAlignmentTest.java ! test/sun/rmi/log/ReliableLog/SnapshotSize.java ! test/sun/rmi/rmic/RMIGenerator/RmicDefault.java ! test/sun/rmi/rmic/newrmic/equivalence/run.sh ! test/sun/rmi/runtime/Log/6409194/NoConsoleOutput.java ! test/sun/rmi/runtime/Log/checkLogging/CheckLogStreams.java ! test/sun/rmi/runtime/Log/checkLogging/CheckLogging.java ! test/sun/rmi/server/MarshalOutputStream/marshalForeignStub/MarshalForeignStub.java ! test/sun/rmi/transport/proxy/EagerHttpFallback.java ! test/sun/rmi/transport/tcp/DeadCachedConnection.java ! test/sun/rmi/transport/tcp/blockAccept/BlockAcceptTest.java ! test/sun/rmi/transport/tcp/disableMultiplexing/DisableMultiplexing.java From jonathan.gibbons at oracle.com Wed Dec 12 14:42:06 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 12 Dec 2012 22:42:06 +0000 Subject: hg: jdk8/tl/langtools: 8004504: ListBuffer could reuse List.nil() as the sentinel element Message-ID: <20121212224208.B5808470ED@hg.openjdk.java.net> Changeset: 170e486632d9 Author: jlahoda Date: 2012-12-12 20:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/170e486632d9 8004504: ListBuffer could reuse List.nil() as the sentinel element Summary: ListBuffer.last now points to the last elements with client data, or null if none. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/util/ListBuffer.java + test/tools/javac/util/list/ListBufferTest.java From stuart.marks at oracle.com Wed Dec 12 15:36:13 2012 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Wed, 12 Dec 2012 23:36:13 +0000 Subject: hg: jdk8/tl/jdk: 8004651: TEST: java/util/logging/CheckLockLocationTest.java failed to delete file (win) Message-ID: <20121212233633.B1748470F0@hg.openjdk.java.net> Changeset: 56fd5479a98f Author: jgish Date: 2012-12-12 15:37 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56fd5479a98f 8004651: TEST: java/util/logging/CheckLockLocationTest.java failed to delete file (win) Summary: Failure to delete test log file should be a warning instead of test failure Reviewed-by: mduigou, smarks ! test/java/util/logging/CheckLockLocationTest.java From weijun.wang at oracle.com Wed Dec 12 16:12:35 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Thu, 13 Dec 2012 00:12:35 +0000 Subject: hg: jdk8/tl/jdk: 8004235: Disable native JGSS provider on Mac Message-ID: <20121213001247.26992470F2@hg.openjdk.java.net> Changeset: 5a2ab2c3f106 Author: weijun Date: 2012-12-13 08:11 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5a2ab2c3f106 8004235: Disable native JGSS provider on Mac Reviewed-by: erikj, valeriep ! make/sun/security/Makefile ! makefiles/CompileNativeLibraries.gmk ! src/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java From lance.andersen at oracle.com Wed Dec 12 17:59:14 2012 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Thu, 13 Dec 2012 01:59:14 +0000 Subject: hg: jdk8/tl/jdk: 8004357: Implement various methods in SerialBlob/Clob/Array and specify Thread Safety Message-ID: <20121213015927.3E708470F5@hg.openjdk.java.net> Changeset: 7a8978a5bb6e Author: lancea Date: 2012-12-12 20:57 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a8978a5bb6e 8004357: Implement various methods in SerialBlob/Clob/Array and specify Thread Safety Reviewed-by: naoto ! src/share/classes/javax/sql/rowset/serial/SerialArray.java ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialClob.java ! src/share/classes/javax/sql/rowset/serial/SerialDatalink.java ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java From weijun.wang at oracle.com Wed Dec 12 18:48:34 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 13 Dec 2012 10:48:34 +0800 Subject: Code Review Request for 6996769: support AEAD ciphers In-Reply-To: <50C29674.6000800@oracle.com> References: <50945D35.8010201@oracle.com> <5098CECB.3020409@oracle.com> <509AE548.4020804@oracle.com> <509B481A.6010307@oracle.com> <50C29674.6000800@oracle.com> Message-ID: <50C94202.7080103@oracle.com> Hi Valerie The code changes work. However, I'm only not quite comfortable with the passKeyAndIvCheck flag. It sounds like it should be only required for GCM/encoding but now it's used everywhere. I especially find this line in doFinal() confusing: passKeyAndIvCheck = (cipherMode != GCM_MODE); Maybe you can use a negative value called "requireInit"? Also, there seems no need to update the flag in the following lines and a local variable is ok: // check key+iv for encryption in GCM mode passKeyAndIvCheck = !Arrays.equals(ivBytes, lastEncIv) || !Arrays.equals(keyBytes, lastEncKey); The flag will be set at the end of the method when real init is fine. Thanks Max On 12/08/2012 09:23 AM, Valerie (Yu-Ching) Peng wrote: > Max, > > The webrev has been updated so that different key + iv values have to be > used for AES/GCM encryption. > Latest version at: http://cr.openjdk.java.net/~valeriep/6996769/webrev.03/ > > Please review and send me comments. > Thanks! > Valerie > > On 11/07/12 21:50, Valerie (Yu-Ching) Peng wrote: >> Max, >> >> Update: I removed the block (starting line 580 in CipherCore.java) for >> handling RC2 since it's never used. >> >> It turns out that the current impl in RC2Cipher always convert the >> AlgorithmParameters object to RC2ParameterSpec and only uses >> CipherCore.init(..., AlgorithmParameterSpec,...) method. Thus, I won't >> be adding a regression test, but rather simply document the current >> RC2Cipher behavior in CipherCore.java to clarify things up. >> >> The updated webrev is at: >> http://cr.openjdk.java.net/~valeriep/6996769/webrev.01/ >> >> Xuelei brought up the issue of enforcing (Key+IV) uniqueness for GCM >> mode during this afternoon's meeting. >> I think more changes may be made after we decide what to do. >> So, there may be a webrev.02 coming... Just a heads up. >> >> Thanks! >> Valerie >> >> On 11/07/12 14:48, Valerie (Yu-Ching) Peng wrote: >>>> 580 } else if (key.getAlgorithm().equals("RC2")) { >>>> >>>> This seems a bug fix. Is there a regression test for it? >>> I just noticed this problem when make the enhancement for GCM mode. >>> I will add a regression test for this. > From chris.hegarty at oracle.com Thu Dec 13 01:57:15 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 13 Dec 2012 09:57:15 +0000 Subject: hg: jdk8/tl/jdk: 8004925: java/net/Socks/SocksV4Test.java failing on all platforms Message-ID: <20121213095811.50B2E470FE@hg.openjdk.java.net> Changeset: 775b0050144a Author: chegar Date: 2012-12-13 09:55 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/775b0050144a 8004925: java/net/Socks/SocksV4Test.java failing on all platforms Reviewed-by: alanb, dsamersoff ! test/java/net/Socks/SocksV4Test.java From weijun.wang at oracle.com Thu Dec 13 05:10:04 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 13 Dec 2012 21:10:04 +0800 Subject: [8] Code Review Request for 8004234: Downgrade normative references to ${java.home}/lib/security/krb5.conf In-Reply-To: <50C8C45A.300@oracle.com> References: <50C8C45A.300@oracle.com> Message-ID: <50C9D3AC.5000204@oracle.com> The code change looks fine. Thanks Max On 12/13/2012 01:52 AM, Sean Mullan wrote: > The rationale for this fix is the same as the previous review request > [1] to downgrade normative references to > ${java.home}/lib/security/java.security. > > This change is much smaller and only affects the > javax.security.auth.kerberos package description. > > webrev: http://cr.openjdk.java.net/~mullan/webrevs/8004234/webrev.00 > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004234 > > Thanks, > Sean > > [1] > http://mail.openjdk.java.net/pipermail/security-dev/2012-December/006144.html > From chris.hegarty at oracle.com Thu Dec 13 06:34:33 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 13 Dec 2012 14:34:33 +0000 Subject: hg: jdk8/tl/jdk: 8004675: Inet6Address.getHostAddress should use string scope identifier where available Message-ID: <20121213143445.2B5D047108@hg.openjdk.java.net> Changeset: 682d2d3ccff5 Author: chegar Date: 2012-12-13 14:33 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/682d2d3ccff5 8004675: Inet6Address.getHostAddress should use string scope identifier where available Summary: ...and some minor stylistic cleanup Reviewed-by: khazra, dsamersoff, michaelm ! src/share/classes/java/net/Inet6Address.java ! src/share/native/java/net/Inet6Address.c + test/java/net/Inet6Address/StringScope.java From sean.mullan at oracle.com Thu Dec 13 06:37:41 2012 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Thu, 13 Dec 2012 14:37:41 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20121213143805.4F23147109@hg.openjdk.java.net> Changeset: c97618a3c8c2 Author: juh Date: 2012-12-13 09:35 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c97618a3c8c2 7193792: sun/security/pkcs11/ec/TestECDSA.java failing intermittently Reviewed-by: vinnie, wetmore ! test/ProblemList.txt ! test/sun/security/pkcs11/ec/TestECDSA.java Changeset: 7b697da6626a Author: mullan Date: 2012-12-13 09:37 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b697da6626a Merge From chris.hegarty at oracle.com Thu Dec 13 06:48:45 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 13 Dec 2012 14:48:45 +0000 Subject: hg: jdk8/tl/jdk: 8003890: corelibs test scripts should pass TESTVMOPTS Message-ID: <20121213144857.1B39D4710A@hg.openjdk.java.net> Changeset: ae5d04dbacd6 Author: chegar Date: 2012-12-13 14:47 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ae5d04dbacd6 8003890: corelibs test scripts should pass TESTVMOPTS Reviewed-by: chegar, alanb Contributed-by: Mark Sheppard ! test/com/oracle/net/sanity.sh ! test/com/sun/corba/cachedSocket/7056731.sh ! test/com/sun/management/OperatingSystemMXBean/TestTotalSwap.sh ! test/com/sun/management/UnixOperatingSystemMXBean/GetMaxFileDescriptorCount.sh ! test/com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh ! test/com/sun/tools/attach/ApplicationSetup.sh ! test/com/sun/tools/attach/BasicTests.sh ! test/com/sun/tools/attach/PermissionTests.sh ! test/com/sun/tools/attach/ProviderTests.sh ! test/com/sun/tools/extcheck/TestExtcheckArgs.sh ! test/demo/zipfs/basic.sh ! test/java/io/File/GetXSpace.sh ! test/java/io/File/MacPathTest.sh ! test/java/io/File/basic.sh ! test/java/io/FileOutputStream/FileOpen.sh ! test/java/io/Serializable/class/run.sh ! test/java/io/Serializable/evolution/AddedExternField/run.sh ! test/java/io/Serializable/evolution/RenamePackage/run.sh ! test/java/io/Serializable/maskSyntheticModifier/run.sh ! test/java/io/Serializable/packageAccess/run.sh ! test/java/io/Serializable/resolveClass/consTest/run.sh ! test/java/io/Serializable/resolveClass/deserializeButton/run.sh ! test/java/io/Serializable/subclass/run.sh ! test/java/io/Serializable/superclassDataLoss/run.sh ! test/java/io/Serializable/unnamedPackageSwitch/run.sh ! test/java/lang/Class/forName/NonJavaNames.sh ! test/java/lang/ClassLoader/Assert.sh ! test/java/lang/ClassLoader/deadlock/TestCrossDelegate.sh ! test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh ! test/java/lang/ClassLoader/getdotresource.sh ! test/java/lang/Runtime/exec/setcwd.sh ! test/java/lang/StringCoding/CheckEncodings.sh ! test/java/lang/System/finalization/FinExit.sh ! test/java/lang/annotation/loaderLeak/LoaderLeak.sh ! test/java/lang/management/OperatingSystemMXBean/TestSystemLoadAvg.sh ! test/java/net/Authenticator/B4933582.sh ! test/java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.sh ! test/java/net/InetAddress/ptr/lookup.sh ! test/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.sh ! test/java/net/Socket/OldSocketImpl.sh ! test/java/net/URL/B5086147.sh ! test/java/net/URL/runconstructor.sh ! test/java/net/URLClassLoader/B5077773.sh ! test/java/net/URLClassLoader/getresourceasstream/test.sh ! test/java/net/URLClassLoader/sealing/checksealed.sh ! test/java/net/URLConnection/6212146/test.sh ! test/java/net/URLConnection/UNCTest.sh ! test/java/nio/Buffer/LimitDirectMemory.sh ! test/java/nio/channels/AsynchronousChannelGroup/run_any_task.sh ! test/java/nio/channels/spi/AsynchronousChannelProvider/custom_provider.sh ! test/java/nio/charset/Charset/default.sh ! test/java/nio/charset/coders/CheckSJISMappingProp.sh ! test/java/nio/charset/spi/basic.sh ! test/java/nio/file/Files/delete_on_close.sh ! test/java/nio/file/Files/walkFileTree/walk_file_tree.sh ! test/java/nio/file/Path/MacPathTest.sh ! test/java/rmi/activation/Activatable/extLoadedImpl/ext.sh ! test/java/rmi/registry/readTest/readTest.sh ! test/java/rmi/reliability/benchmark/runSerialBench.sh ! test/java/security/Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh ! test/java/security/Security/ClassLoaderDeadlock/Deadlock.sh ! test/java/security/Security/ClassLoaderDeadlock/Deadlock2.sh ! test/java/security/Security/signedfirst/Dyn.sh ! test/java/security/Security/signedfirst/Static.sh ! test/java/security/cert/CertificateFactory/slowstream.sh ! test/java/util/Currency/PropertiesTest.sh ! test/java/util/Locale/LocaleCategory.sh ! test/java/util/Locale/LocaleProviders.sh ! test/java/util/PluggableLocale/ExecTest.sh ! test/java/util/ResourceBundle/Bug6299235Test.sh ! test/java/util/ResourceBundle/Control/MissingResourceCauseTest.sh ! test/java/util/ServiceLoader/basic.sh ! test/java/util/TimeZone/OldIDMappingTest.sh ! test/java/util/TimeZone/TimeZoneDatePermissionCheck.sh ! test/java/util/prefs/CheckUserPrefsStorage.sh ! test/java/util/prefs/PrefsSpi.sh ! test/java/util/spi/ResourceBundleControlProvider/UserDefaultControlTest.sh ! test/java/util/zip/3GBZipFiles.sh ! test/java/util/zip/ZipFile/deletetempjar.sh ! test/javax/crypto/SecretKeyFactory/FailOverTest.sh ! test/javax/print/applet/AppletPrintLookup.sh ! test/javax/script/ProviderTest.sh ! test/javax/security/auth/Subject/doAs/Test.sh ! test/lib/security/java.policy/Ext_AllPolicy.sh ! test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh ! test/sun/management/jmxremote/bootstrap/CustomLauncherTest.sh ! test/sun/management/jmxremote/bootstrap/LocalManagementTest.sh ! test/sun/management/jmxremote/bootstrap/PasswordFilePermissionTest.sh ! test/sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.sh ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh ! test/sun/misc/Cleaner/exitOnThrow.sh ! test/sun/net/InetAddress/nameservice/dns/cname.sh ! test/sun/net/sdp/sanity.sh ! test/sun/net/www/MarkResetTest.sh ! test/sun/net/www/http/HttpClient/RetryPost.sh ! test/sun/net/www/protocol/file/DirPermissionDenied.sh ! test/sun/net/www/protocol/jar/B5105410.sh ! test/sun/net/www/protocol/jar/getcontenttype.sh ! test/sun/net/www/protocol/jar/jarbug/run.sh ! test/sun/rmi/rmic/manifestClassPath/run.sh ! test/sun/rmi/rmic/minimizeWrapperInstances/run.sh ! test/sun/rmi/rmic/oldjavacRemoved/sunToolsJavacMain.sh ! test/sun/security/krb5/runNameEquals.sh ! test/sun/security/krb5/tools/ktcheck.sh ! test/sun/security/mscapi/AccessKeyStore.sh ! test/sun/security/mscapi/IsSunMSCAPIAvailable.sh ! test/sun/security/mscapi/KeyStoreCompatibilityMode.sh ! test/sun/security/mscapi/PublicKeyInterop.sh ! test/sun/security/mscapi/RSAEncryptDecrypt.sh ! test/sun/security/mscapi/ShortRSAKey1024.sh ! test/sun/security/mscapi/SignUsingNONEwithRSA.sh ! test/sun/security/mscapi/SignUsingSHA2withRSA.sh ! test/sun/security/pkcs11/KeyStore/Basic.sh ! test/sun/security/pkcs11/KeyStore/ClientAuth.sh ! test/sun/security/pkcs11/KeyStore/SecretKeysBasic.sh ! test/sun/security/pkcs11/KeyStore/Solaris.sh ! test/sun/security/pkcs11/Provider/ConfigQuotedString.sh ! test/sun/security/pkcs11/Provider/Login.sh ! test/sun/security/provider/PolicyFile/GrantAllPermToExtWhenNoPolicy.sh ! test/sun/security/provider/PolicyFile/getinstance/getinstance.sh ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOneExtraByte.sh ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/NotifyHandshakeTest.sh ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxyWithAuth.sh ! test/sun/security/tools/jarsigner/emptymanifest.sh ! test/sun/security/tools/jarsigner/ts.sh ! test/sun/security/tools/keytool/printssl.sh ! test/sun/security/tools/keytool/standard.sh ! test/sun/security/validator/certreplace.sh ! test/sun/security/validator/samedn.sh ! test/tools/launcher/6842838/Test6842838.sh ! test/tools/launcher/MultipleJRE.sh From rob.mckenna at oracle.com Thu Dec 13 07:24:20 2012 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Thu, 13 Dec 2012 15:24:20 +0000 Subject: hg: jdk8/tl/jdk: 8000525: Java.net.httpcookie api does not support 2-digit year format Message-ID: <20121213152432.0C2154710D@hg.openjdk.java.net> Changeset: 087425441a48 Author: robm Date: 2012-12-13 15:28 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/087425441a48 8000525: Java.net.httpcookie api does not support 2-digit year format Reviewed-by: chegar ! src/share/classes/java/net/HttpCookie.java ! test/java/net/CookieHandler/B6791927.java ! test/java/net/CookieHandler/CookieManagerTest.java + test/java/net/HttpCookie/ExpiredCookieTest.java From vincent.x.ryan at oracle.com Thu Dec 13 08:24:28 2012 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Thu, 13 Dec 2012 16:24:28 +0000 Subject: [7u12] Review request for 8004846: Time-specific certpath validation applies to OCSP response validity period Message-ID: <63FBFC48-95A1-404C-B912-24315EC7C290@oracle.com> Please review these changes to JDK 7 to correct the validation of OCSP responses when cert path validation is being performed at a _specific_ time (rather than performed using the current time). 8004846: Time-specific certpath validation applies to OCSP response validity period http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004846 Webrev: http://cr.openjdk.java.net/~vinnie/8004846/webrev.00/ Thanks. From sean.mullan at oracle.com Thu Dec 13 10:18:33 2012 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 13 Dec 2012 13:18:33 -0500 Subject: Code Review Request, 7109274, Consider disabling support for X.509 certificates with RSA keys less than 1024 bits In-Reply-To: <50C7D9F9.8080503@oracle.com> References: <50C7D9F9.8080503@oracle.com> Message-ID: <50CA1BF9.6000306@oracle.com> Hi Xuelei, This looks good, although I was wondering if you considered re-generating the test certificates with larger keys? This would allow the tests to continue to run in samevm mode. --Sean On 12/11/2012 08:12 PM, Xuelei Fan wrote: > Hi, > > Please review the update for JDK-7109274, Consider disabling support for > X.509 certificates with RSA keys less than 1024 bits. > > Webrev: http://cr.openjdk.java.net./~xuelei/7109274/webrev.00/ > > The bug description is not available at bugs.sun.com at present. The > purpose of this update is to disable the support of X.509 certificates > with RSA keys less than 1024 bits. > > The key length is an important security parameter to determine the > strength of public key based cryptographic algorithms. RSA keys less > than 1024 bits are considered breakable [1][2]. > > In this update, we are proposing to restrict the use of certificates > with RSA keys less than 1024 bits in length. This restriction is > applied via the Java Security property, > "jdk.certpath.disabledAlgorithms" [1]. This will impact providers that > adhere to this security property, for example, the Sun provider and the > SunJSSE provider. > > The security property, "jdk.certpath.disabledAlgorithms", also covers > the use of the static keys (the key in X.509 certificate) used in TLS. > Therefore, we don't need to add any further restrictions to the > "jdk.tls.disabledAlgorithms" security property. > > With this key size restriction, those who use X.509 certificates based > on RSA keys less than 1024 bits will encounter compatibility issues with > certification path building and validation. This key size restriction > also impacts JDK components that validate X.509 certificates, for > example signed JAR verification, SSL/TLS transportation, HTTPS > connections, etc. > > In order to avoid the compatibility issue, users who use X.509 > certificates with RSA keys less than 1024 bits are recommended to renew > their certificates with stronger keys. As a workaround, at their own > risks, users can adjust the key size restriction security property > ("jdk.certpath.disabledAlgorithms") or use the > java.security.AlgorithmConstraints (introduced in JDK 7) to permit > smaller key sizes. > > Thanks, > Xuelei > > [1]: http://blogs.rsa.com/rsa-768-factored/ > [2]: http://technet.microsoft.com/en-us/security/advisory/2661254 > From sean.mullan at oracle.com Thu Dec 13 13:44:40 2012 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 13 Dec 2012 16:44:40 -0500 Subject: [7u12] Review request for 8004846: Time-specific certpath validation applies to OCSP response validity period In-Reply-To: <63FBFC48-95A1-404C-B912-24315EC7C290@oracle.com> References: <63FBFC48-95A1-404C-B912-24315EC7C290@oracle.com> Message-ID: <50CA4C48.6010606@oracle.com> Looks good to me. Can you add a regression test or is it too hard to write one? --Sean On 12/13/2012 11:24 AM, Vincent Ryan wrote: > > Please review these changes to JDK 7 to correct the validation of OCSP responses when cert > path validation is being performed at a _specific_ time (rather than performed using the current time). > > 8004846: Time-specific certpath validation applies to OCSP response validity period > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004846 > > Webrev: > http://cr.openjdk.java.net/~vinnie/8004846/webrev.00/ > > Thanks. > From jonathan.gibbons at oracle.com Thu Dec 13 17:50:14 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 14 Dec 2012 01:50:14 +0000 Subject: hg: jdk8/tl/langtools: 8001114: Container annotation is not checked for semantic correctness Message-ID: <20121214015018.AA5C947136@hg.openjdk.java.net> Changeset: 376d6c1b49e5 Author: jfranck Date: 2012-12-03 11:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/376d6c1b49e5 8001114: Container annotation is not checked for semantic correctness Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Annotations.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase1.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase1.out ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase2.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase2.out ! test/tools/javac/annotations/repeatingAnnotations/NoRepeatableAnno.out + test/tools/javac/annotations/repeatingAnnotations/RepeatingTargetNotAllowed.java + test/tools/javac/annotations/repeatingAnnotations/RepeatingTargetNotAllowed.out ! test/tools/javac/diags/examples/ContainedByNonDefault.java + test/tools/javac/diags/examples/InvalidDuplicateAnnotation.java From david.holmes at oracle.com Thu Dec 13 18:19:03 2012 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Fri, 14 Dec 2012 02:19:03 +0000 Subject: hg: jdk8/tl/jdk: 8003632: HPROF class file version java.lang.RuntimeException errors Message-ID: <20121214021924.3C81647137@hg.openjdk.java.net> Changeset: 8d7323a9d8ed Author: dholmes Date: 2012-12-13 21:18 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d7323a9d8ed 8003632: HPROF class file version java.lang.RuntimeException errors Reviewed-by: mchung, lancea ! src/share/javavm/export/classfile_constants.h From xuelei.fan at oracle.com Thu Dec 13 18:35:16 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Fri, 14 Dec 2012 10:35:16 +0800 Subject: Code Review Request, 7109274, Consider disabling support for X.509 certificates with RSA keys less than 1024 bits In-Reply-To: <50CA1BF9.6000306@oracle.com> References: <50C7D9F9.8080503@oracle.com> <50CA1BF9.6000306@oracle.com> Message-ID: <50CA9064.80503@oracle.com> On 12/14/2012 2:18 AM, Sean Mullan wrote: > Hi Xuelei, > > This looks good, although I was wondering if you considered > re-generating the test certificates with larger keys? This would allow > the tests to continue to run in samevm mode. > I will look into test cases to replace the certificates with stronger ones. Thanks for the review. Xuelei > --Sean > > On 12/11/2012 08:12 PM, Xuelei Fan wrote: >> Hi, >> >> Please review the update for JDK-7109274, Consider disabling support for >> X.509 certificates with RSA keys less than 1024 bits. >> >> Webrev: http://cr.openjdk.java.net./~xuelei/7109274/webrev.00/ >> >> The bug description is not available at bugs.sun.com at present. The >> purpose of this update is to disable the support of X.509 certificates >> with RSA keys less than 1024 bits. >> >> The key length is an important security parameter to determine the >> strength of public key based cryptographic algorithms. RSA keys less >> than 1024 bits are considered breakable [1][2]. >> >> In this update, we are proposing to restrict the use of certificates >> with RSA keys less than 1024 bits in length. This restriction is >> applied via the Java Security property, >> "jdk.certpath.disabledAlgorithms" [1]. This will impact providers that >> adhere to this security property, for example, the Sun provider and the >> SunJSSE provider. >> >> The security property, "jdk.certpath.disabledAlgorithms", also covers >> the use of the static keys (the key in X.509 certificate) used in TLS. >> Therefore, we don't need to add any further restrictions to the >> "jdk.tls.disabledAlgorithms" security property. >> >> With this key size restriction, those who use X.509 certificates based >> on RSA keys less than 1024 bits will encounter compatibility issues with >> certification path building and validation. This key size restriction >> also impacts JDK components that validate X.509 certificates, for >> example signed JAR verification, SSL/TLS transportation, HTTPS >> connections, etc. >> >> In order to avoid the compatibility issue, users who use X.509 >> certificates with RSA keys less than 1024 bits are recommended to renew >> their certificates with stronger keys. As a workaround, at their own >> risks, users can adjust the key size restriction security property >> ("jdk.certpath.disabledAlgorithms") or use the >> java.security.AlgorithmConstraints (introduced in JDK 7) to permit >> smaller key sizes. >> >> Thanks, >> Xuelei >> >> [1]: http://blogs.rsa.com/rsa-768-factored/ >> [2]: http://technet.microsoft.com/en-us/security/advisory/2661254 >> > From mstjohns at comcast.net Thu Dec 13 19:21:37 2012 From: mstjohns at comcast.net (Michael StJohns) Date: Thu, 13 Dec 2012 22:21:37 -0500 Subject: Code Review Request, 7109274, Consider disabling support for X.509 certificates with RSA keys less than 1024 bits In-Reply-To: <50C7D9F9.8080503@oracle.com> References: <50C7D9F9.8080503@oracle.com> Message-ID: <20121214032125.E1529615B@mail.openjdk.java.net> Does this go far enough? If you're going with NIST recommendations, anything less that 112 bits of strength is now considered weak. The guidance is those strengths are deprecated now, and prohibited after the end of 2013. In addition, SHA1 is deprecated now and prohibited after 2013 for signatures (still acceptable for other things). RSA 1024 bits is about 80 bits of security so the relative key bit lengths are DSA and RSA < 1024 and EC < 160 should probably be disabled in this pass. After the end of next year, DSA and RSA < 2048 and EC < 224 as well as SHA1 for signatures should be disabled. Mike At 08:12 PM 12/11/2012, Xuelei Fan wrote: >Hi, > >Please review the update for JDK-7109274, Consider disabling support for >X.509 certificates with RSA keys less than 1024 bits. > >Webrev: http://cr.openjdk.java.net./~xuelei/7109274/webrev.00/ > >The bug description is not available at bugs.sun.com at present. The >purpose of this update is to disable the support of X.509 certificates >with RSA keys less than 1024 bits. > >The key length is an important security parameter to determine the >strength of public key based cryptographic algorithms. RSA keys less >than 1024 bits are considered breakable [1][2]. > >In this update, we are proposing to restrict the use of certificates >with RSA keys less than 1024 bits in length. This restriction is >applied via the Java Security property, >"jdk.certpath.disabledAlgorithms" [1]. This will impact providers that >adhere to this security property, for example, the Sun provider and the >SunJSSE provider. > >The security property, "jdk.certpath.disabledAlgorithms", also covers >the use of the static keys (the key in X.509 certificate) used in TLS. >Therefore, we don't need to add any further restrictions to the >"jdk.tls.disabledAlgorithms" security property. > >With this key size restriction, those who use X.509 certificates based >on RSA keys less than 1024 bits will encounter compatibility issues with >certification path building and validation. This key size restriction >also impacts JDK components that validate X.509 certificates, for >example signed JAR verification, SSL/TLS transportation, HTTPS >connections, etc. > >In order to avoid the compatibility issue, users who use X.509 >certificates with RSA keys less than 1024 bits are recommended to renew >their certificates with stronger keys. As a workaround, at their own >risks, users can adjust the key size restriction security property >("jdk.certpath.disabledAlgorithms") or use the >java.security.AlgorithmConstraints (introduced in JDK 7) to permit >smaller key sizes. > >Thanks, >Xuelei > >[1]: http://blogs.rsa.com/rsa-768-factored/ >[2]: http://technet.microsoft.com/en-us/security/advisory/2661254 From xuelei.fan at oracle.com Thu Dec 13 19:48:45 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Fri, 14 Dec 2012 11:48:45 +0800 Subject: Code Review Request, 7109274, Consider disabling support for X.509 certificates with RSA keys less than 1024 bits In-Reply-To: <201212140321.qBE3LS2o020544@aserp1020.oracle.com> References: <50C7D9F9.8080503@oracle.com> <201212140321.qBE3LS2o020544@aserp1020.oracle.com> Message-ID: <50CAA19D.50501@oracle.com> We cannot go that far in crypto libraries because of compatibilities. Applications need to take the responsibilities to use proper strength. In crypto library level, we are only able to enforce very weak algorithms and key sizes restrictions, as MD2 and RSA-512. Otherwise, those applications that still need to use RSA-1024, SHA1/MD5 will run into serious compatibility issues. Xuelei On 12/14/2012 11:21 AM, Michael StJohns wrote: > Does this go far enough? > > If you're going with NIST recommendations, anything less that 112 bits of strength is now considered weak. The guidance is those strengths are deprecated now, and prohibited after the end of 2013. In addition, SHA1 is deprecated now and prohibited after 2013 for signatures (still acceptable for other things). > > RSA 1024 bits is about 80 bits of security so the relative key bit lengths are DSA and RSA < 1024 and EC < 160 should probably be disabled in this pass. > > After the end of next year, DSA and RSA < 2048 and EC < 224 as well as SHA1 for signatures should be disabled. > > Mike > > > At 08:12 PM 12/11/2012, Xuelei Fan wrote: >> Hi, >> >> Please review the update for JDK-7109274, Consider disabling support for >> X.509 certificates with RSA keys less than 1024 bits. >> >> Webrev: http://cr.openjdk.java.net./~xuelei/7109274/webrev.00/ >> >> The bug description is not available at bugs.sun.com at present. The >> purpose of this update is to disable the support of X.509 certificates >> with RSA keys less than 1024 bits. >> >> The key length is an important security parameter to determine the >> strength of public key based cryptographic algorithms. RSA keys less >> than 1024 bits are considered breakable [1][2]. >> >> In this update, we are proposing to restrict the use of certificates >> with RSA keys less than 1024 bits in length. This restriction is >> applied via the Java Security property, >> "jdk.certpath.disabledAlgorithms" [1]. This will impact providers that >> adhere to this security property, for example, the Sun provider and the >> SunJSSE provider. >> >> The security property, "jdk.certpath.disabledAlgorithms", also covers >> the use of the static keys (the key in X.509 certificate) used in TLS. >> Therefore, we don't need to add any further restrictions to the >> "jdk.tls.disabledAlgorithms" security property. >> >> With this key size restriction, those who use X.509 certificates based >> on RSA keys less than 1024 bits will encounter compatibility issues with >> certification path building and validation. This key size restriction >> also impacts JDK components that validate X.509 certificates, for >> example signed JAR verification, SSL/TLS transportation, HTTPS >> connections, etc. >> >> In order to avoid the compatibility issue, users who use X.509 >> certificates with RSA keys less than 1024 bits are recommended to renew >> their certificates with stronger keys. As a workaround, at their own >> risks, users can adjust the key size restriction security property >> ("jdk.certpath.disabledAlgorithms") or use the >> java.security.AlgorithmConstraints (introduced in JDK 7) to permit >> smaller key sizes. >> >> Thanks, >> Xuelei >> >> [1]: http://blogs.rsa.com/rsa-768-factored/ >> [2]: http://technet.microsoft.com/en-us/security/advisory/2661254 > > From mstjohns at comcast.net Thu Dec 13 20:07:29 2012 From: mstjohns at comcast.net (Michael StJohns) Date: Thu, 13 Dec 2012 23:07:29 -0500 Subject: Code Review Request for 6996769: support AEAD ciphers In-Reply-To: <50C29674.6000800@oracle.com> References: <50945D35.8010201@oracle.com> <5098CECB.3020409@oracle.com> <509AE548.4020804@oracle.com> <509B481A.6010307@oracle.com> <50C29674.6000800@oracle.com> Message-ID: <20121214040717.40ACA6164@mail.openjdk.java.net> Sorry for the late comment - You might want to consider section 9.1, first paragraph of SP800-38D which defines the GCM mode. Basically, for FIPS validated implementations, to prevent accidental reuse, the IV needs to be generated inside the cryptographic boundary using one of the defined mechanism. Obviously, that's on the ENCRYPT side since you need to match the IV on the DECRYPT side. I think you may need to add a GCMParameterSpec that allows you to specify either the IV or the IV length as a subclass of IvParameterSpec. Mike At 08:23 PM 12/7/2012, Valerie (Yu-Ching) Peng wrote: >Max, > >The webrev has been updated so that different key + iv values have to be used for AES/GCM encryption. >Latest version at: http://cr.openjdk.java.net/~valeriep/6996769/webrev.03/ > >Please review and send me comments. >Thanks! >Valerie > >On 11/07/12 21:50, Valerie (Yu-Ching) Peng wrote: >>Max, >> >>Update: I removed the block (starting line 580 in CipherCore.java) for handling RC2 since it's never used. >> >>It turns out that the current impl in RC2Cipher always convert the AlgorithmParameters object to RC2ParameterSpec and only uses CipherCore.init(..., AlgorithmParameterSpec,...) method. Thus, I won't be adding a regression test, but rather simply document the current RC2Cipher behavior in CipherCore.java to clarify things up. >> >>The updated webrev is at: >>http://cr.openjdk.java.net/~valeriep/6996769/webrev.01/ >> >>Xuelei brought up the issue of enforcing (Key+IV) uniqueness for GCM mode during this afternoon's meeting. >>I think more changes may be made after we decide what to do. >>So, there may be a webrev.02 coming... Just a heads up. >> >>Thanks! >>Valerie >> >>On 11/07/12 14:48, Valerie (Yu-Ching) Peng wrote: >>>>580 } else if (key.getAlgorithm().equals("RC2")) { >>>> >>>>This seems a bug fix. Is there a regression test for it? >>>I just noticed this problem when make the enhancement for GCM mode. >>>I will add a regression test for this. From mstjohns at comcast.net Thu Dec 13 20:24:23 2012 From: mstjohns at comcast.net (Michael StJohns) Date: Thu, 13 Dec 2012 23:24:23 -0500 Subject: Code Review Request, 7109274, Consider disabling support for X.509 certificates with RSA keys less than 1024 bits In-Reply-To: <50CAA19D.50501@oracle.com> References: <50C7D9F9.8080503@oracle.com> <201212140321.qBE3LS2o020544@aserp1020.oracle.com> <50CAA19D.50501@oracle.com> Message-ID: <20121214042414.DD1976168@mail.openjdk.java.net> At 10:48 PM 12/13/2012, Xuelei Fan wrote: >We cannot go that far in crypto libraries because of compatibilities. >Applications need to take the responsibilities to use proper strength. >In crypto library level, we are only able to enforce very weak >algorithms and key sizes restrictions, as MD2 and RSA-512. Otherwise, >those applications that still need to use RSA-1024, SHA1/MD5 will run >into serious compatibility issues. I agree. But I'd still disable EC < 160 and DSA < 1024 in the same place where you disable RSA < 1024 in this patch. I'd also probably consider updating the release notes to note that the default could change again in 2013 or 2014 to the even stronger values (and SHA1 removed) and how to re-enable the weaker strengths. Thanks - Mike >Xuelei > >On 12/14/2012 11:21 AM, Michael StJohns wrote: >> Does this go far enough? >> >> If you're going with NIST recommendations, anything less that 112 bits of strength is now considered weak. The guidance is those strengths are deprecated now, and prohibited after the end of 2013. In addition, SHA1 is deprecated now and prohibited after 2013 for signatures (still acceptable for other things). >> >> RSA 1024 bits is about 80 bits of security so the relative key bit lengths are DSA and RSA < 1024 and EC < 160 should probably be disabled in this pass. >> >> After the end of next year, DSA and RSA < 2048 and EC < 224 as well as SHA1 for signatures should be disabled. >> >> Mike >> >> >> At 08:12 PM 12/11/2012, Xuelei Fan wrote: >>> Hi, >>> >>> Please review the update for JDK-7109274, Consider disabling support for >>> X.509 certificates with RSA keys less than 1024 bits. >>> >>> Webrev: http://cr.openjdk.java.net./~xuelei/7109274/webrev.00/ >>> >>> The bug description is not available at bugs.sun.com at present. The >>> purpose of this update is to disable the support of X.509 certificates >>> with RSA keys less than 1024 bits. >>> >>> The key length is an important security parameter to determine the >>> strength of public key based cryptographic algorithms. RSA keys less >>> than 1024 bits are considered breakable [1][2]. >>> >>> In this update, we are proposing to restrict the use of certificates >>> with RSA keys less than 1024 bits in length. This restriction is >>> applied via the Java Security property, >>> "jdk.certpath.disabledAlgorithms" [1]. This will impact providers that >>> adhere to this security property, for example, the Sun provider and the >>> SunJSSE provider. >>> >>> The security property, "jdk.certpath.disabledAlgorithms", also covers >>> the use of the static keys (the key in X.509 certificate) used in TLS. >>> Therefore, we don't need to add any further restrictions to the >>> "jdk.tls.disabledAlgorithms" security property. >>> >>> With this key size restriction, those who use X.509 certificates based >>> on RSA keys less than 1024 bits will encounter compatibility issues with >>> certification path building and validation. This key size restriction >>> also impacts JDK components that validate X.509 certificates, for >>> example signed JAR verification, SSL/TLS transportation, HTTPS >>> connections, etc. >>> >>> In order to avoid the compatibility issue, users who use X.509 >>> certificates with RSA keys less than 1024 bits are recommended to renew >>> their certificates with stronger keys. As a workaround, at their own >>> risks, users can adjust the key size restriction security property >>> ("jdk.certpath.disabledAlgorithms") or use the >>> java.security.AlgorithmConstraints (introduced in JDK 7) to permit >>> smaller key sizes. >>> >>> Thanks, >>> Xuelei >>> >>> [1]: http://blogs.rsa.com/rsa-768-factored/ >>> [2]: http://technet.microsoft.com/en-us/security/advisory/2661254 >> >> From xuelei.fan at oracle.com Thu Dec 13 20:34:07 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Fri, 14 Dec 2012 12:34:07 +0800 Subject: Code Review Request, 7109274, Consider disabling support for X.509 certificates with RSA keys less than 1024 bits In-Reply-To: <201212140424.qBE4OEDp019941@userp1030.oracle.com> References: <50C7D9F9.8080503@oracle.com> <201212140321.qBE3LS2o020544@aserp1020.oracle.com> <50CAA19D.50501@oracle.com> <201212140424.qBE4OEDp019941@userp1030.oracle.com> Message-ID: <50CAAC3F.50005@oracle.com> On 12/14/2012 12:24 PM, Michael StJohns wrote: > At 10:48 PM 12/13/2012, Xuelei Fan wrote: >> We cannot go that far in crypto libraries because of compatibilities. >> Applications need to take the responsibilities to use proper strength. >> In crypto library level, we are only able to enforce very weak >> algorithms and key sizes restrictions, as MD2 and RSA-512. Otherwise, >> those applications that still need to use RSA-1024, SHA1/MD5 will run >> into serious compatibility issues. > > I agree. But I'd still disable EC < 160 and DSA < 1024 in the same place where you disable RSA < 1024 in this patch. > That's a very good practice! I recommend that applications always use the stronger strength according to NIST recommendation, or other recommendations. > I'd also probably consider updating the release notes to note that the default could change again in 2013 or 2014 to the even stronger values (and SHA1 removed) and how to re-enable the weaker strengths. > Good point. Thanks, Xuelei > Thanks - Mike > > > > >> Xuelei >> >> On 12/14/2012 11:21 AM, Michael StJohns wrote: >>> Does this go far enough? >>> >>> If you're going with NIST recommendations, anything less that 112 bits of strength is now considered weak. The guidance is those strengths are deprecated now, and prohibited after the end of 2013. In addition, SHA1 is deprecated now and prohibited after 2013 for signatures (still acceptable for other things). >>> >>> RSA 1024 bits is about 80 bits of security so the relative key bit lengths are DSA and RSA < 1024 and EC < 160 should probably be disabled in this pass. >>> >>> After the end of next year, DSA and RSA < 2048 and EC < 224 as well as SHA1 for signatures should be disabled. >>> >>> Mike >>> >>> >>> At 08:12 PM 12/11/2012, Xuelei Fan wrote: >>>> Hi, >>>> >>>> Please review the update for JDK-7109274, Consider disabling support for >>>> X.509 certificates with RSA keys less than 1024 bits. >>>> >>>> Webrev: http://cr.openjdk.java.net./~xuelei/7109274/webrev.00/ >>>> >>>> The bug description is not available at bugs.sun.com at present. The >>>> purpose of this update is to disable the support of X.509 certificates >>>> with RSA keys less than 1024 bits. >>>> >>>> The key length is an important security parameter to determine the >>>> strength of public key based cryptographic algorithms. RSA keys less >>>> than 1024 bits are considered breakable [1][2]. >>>> >>>> In this update, we are proposing to restrict the use of certificates >>>> with RSA keys less than 1024 bits in length. This restriction is >>>> applied via the Java Security property, >>>> "jdk.certpath.disabledAlgorithms" [1]. This will impact providers that >>>> adhere to this security property, for example, the Sun provider and the >>>> SunJSSE provider. >>>> >>>> The security property, "jdk.certpath.disabledAlgorithms", also covers >>>> the use of the static keys (the key in X.509 certificate) used in TLS. >>>> Therefore, we don't need to add any further restrictions to the >>>> "jdk.tls.disabledAlgorithms" security property. >>>> >>>> With this key size restriction, those who use X.509 certificates based >>>> on RSA keys less than 1024 bits will encounter compatibility issues with >>>> certification path building and validation. This key size restriction >>>> also impacts JDK components that validate X.509 certificates, for >>>> example signed JAR verification, SSL/TLS transportation, HTTPS >>>> connections, etc. >>>> >>>> In order to avoid the compatibility issue, users who use X.509 >>>> certificates with RSA keys less than 1024 bits are recommended to renew >>>> their certificates with stronger keys. As a workaround, at their own >>>> risks, users can adjust the key size restriction security property >>>> ("jdk.certpath.disabledAlgorithms") or use the >>>> java.security.AlgorithmConstraints (introduced in JDK 7) to permit >>>> smaller key sizes. >>>> >>>> Thanks, >>>> Xuelei >>>> >>>> [1]: http://blogs.rsa.com/rsa-768-factored/ >>>> [2]: http://technet.microsoft.com/en-us/security/advisory/2661254 >>> >>> > > From huizhe.wang at oracle.com Fri Dec 14 13:21:58 2012 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Fri, 14 Dec 2012 21:21:58 +0000 Subject: hg: jdk8/tl/jaxp: 8003260: [findbug] some fields should be package protected Message-ID: <20121214212203.216C64717E@hg.openjdk.java.net> Changeset: b1fdb101c82e Author: joehw Date: 2012-12-14 13:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/b1fdb101c82e 8003260: [findbug] some fields should be package protected Summary: change public or protected mutable static fields to private or package private. Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityScanner.java From valerie.peng at oracle.com Fri Dec 14 17:32:45 2012 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Fri, 14 Dec 2012 17:32:45 -0800 Subject: Code Review Request for 6996769: support AEAD ciphers In-Reply-To: <201212140407.qBE47J5R021114@aserp1020.oracle.com> References: <50945D35.8010201@oracle.com> <5098CECB.3020409@oracle.com> <509AE548.4020804@oracle.com> <509B481A.6010307@oracle.com> <50C29674.6000800@oracle.com> <201212140407.qBE47J5R021114@aserp1020.oracle.com> Message-ID: <50CBD33D.9050902@oracle.com> Mike, Thanks for the comments... With the current API, it is still possible to have the IV generated at the provider level by calling Cipher.init(...) without GCM parameters. This means that provider will generate IVs using provider-default iv length as well as provider-default value for tag length. Of course, things may be a little awkward if you need to use custom tag length and a different iv length from what the provider uses as default. SunJCE provider uses 128-bit tag length as well as 96-bit IVs as default. If there are demands to use other non-default values, then we should see if something can be done to facilitate these scenarios. As for preventing the same IV from being re-used, I think it takes more than just adding a new constructor for GCMParameterSpec. Generally, AlgorithmParameterSpec objects can be converted to AlgorithmParameters objects and vice versa. If the GCMParameterSpec only specifies iv length, would you expect the provider to automatically generate a new IV w/o explicit re-init? If yes, then what should the Cipher.getParameters() return, the new one or the old one? Regardless which way we choose, it introduces a window on when Cipher.getParameters() should be called. Valerie On 12/13/12 20:07, Michael StJohns wrote: > Sorry for the late comment - > > You might want to consider section 9.1, first paragraph of SP800-38D which defines the GCM mode. Basically, for FIPS validated implementations, to prevent accidental reuse, the IV needs to be generated inside the cryptographic boundary using one of the defined mechanism. Obviously, that's on the ENCRYPT side since you need to match the IV on the DECRYPT side. > > I think you may need to add a GCMParameterSpec that allows you to specify either the IV or the IV length as a subclass of IvParameterSpec. > > Mike > > > > > At 08:23 PM 12/7/2012, Valerie (Yu-Ching) Peng wrote: >> Max, >> >> The webrev has been updated so that different key + iv values have to be used for AES/GCM encryption. >> Latest version at: http://cr.openjdk.java.net/~valeriep/6996769/webrev.03/ >> >> Please review and send me comments. >> Thanks! >> Valerie >> >> On 11/07/12 21:50, Valerie (Yu-Ching) Peng wrote: >>> Max, >>> >>> Update: I removed the block (starting line 580 in CipherCore.java) for handling RC2 since it's never used. >>> >>> It turns out that the current impl in RC2Cipher always convert the AlgorithmParameters object to RC2ParameterSpec and only uses CipherCore.init(..., AlgorithmParameterSpec,...) method. Thus, I won't be adding a regression test, but rather simply document the current RC2Cipher behavior in CipherCore.java to clarify things up. >>> >>> The updated webrev is at: >>> http://cr.openjdk.java.net/~valeriep/6996769/webrev.01/ >>> >>> Xuelei brought up the issue of enforcing (Key+IV) uniqueness for GCM mode during this afternoon's meeting. >>> I think more changes may be made after we decide what to do. >>> So, there may be a webrev.02 coming... Just a heads up. >>> >>> Thanks! >>> Valerie >>> >>> On 11/07/12 14:48, Valerie (Yu-Ching) Peng wrote: >>>>> 580 } else if (key.getAlgorithm().equals("RC2")) { >>>>> >>>>> This seems a bug fix. Is there a regression test for it? >>>> I just noticed this problem when make the enhancement for GCM mode. >>>> I will add a regression test for this. > From alan.bateman at oracle.com Sat Dec 15 07:11:18 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sat, 15 Dec 2012 15:11:18 +0000 Subject: hg: jdk8/tl/jdk: 8004963: URLConnection, downgrade normative reference to ${java.home}/lib/content-types.properties Message-ID: <20121215151130.417F44719C@hg.openjdk.java.net> Changeset: 69fd3f3d20c1 Author: alanb Date: 2012-12-15 15:07 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69fd3f3d20c1 8004963: URLConnection, downgrade normative reference to ${java.home}/lib/content-types.properties Reviewed-by: chegar ! src/share/classes/java/net/URLConnection.java From weijun.wang at oracle.com Sun Dec 16 18:25:30 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 17 Dec 2012 10:25:30 +0800 Subject: Ping again (Re: code review request: 7197159: accept different kvno if there no match) In-Reply-To: <504C6F29.20108@oracle.com> References: <10921938.1347183410442.JavaMail.sbladm@swsblss4-new.central.sun.com> <504C6F29.20108@oracle.com> Message-ID: <50CE829A.7070002@oracle.com> Xuelei or Valerie, Can you review this code change? Some customers really likes this fallback. Thanks Max On 09/09/2012 06:27 PM, Weijun Wang wrote: > Please take a review at this > > http://cr.openjdk.java.net/~weijun/7197159/webrev.00/ > > In 6893158, we started kvno checking when parsing AP-REQ. Since then, we > have compatibility reports that keytab created with JDK's ktab.exe fail > because of this change. In 6984764, we added an option to ktab.exe so > that users can specify the correct kvno when creating a keytab, but it > seems not enough. > > This fix adds another fallback to the kvno check. If none of the keys in > a keytab matches the required kvno, instead of reporting a > KRB_AP_ERR_BADKEYVER error, we now returns a key of the same etype with > the highest kvno. > > Hope this stops the compatibility problem. > > *Mala*: this is the alternative way I propose to solve the problem. It > should be applicable to 6u and 7u. > > Thanks > Max > > > -------- Original Message -------- > 7197159: accept different kvno if there no match > > === *Description* > ============================================================ > 6893158 introduced kvno (key version number) check in AP-REQ parsing. > This is a correct behavior but might cause interop/compatibility > problems if the server uses a keytab with wrong kvno values. In fact, > our vey own ktab.exe tool included in JDK can generate such keytab files > because it does not know what the correct kvno is. (Other keytab > generation tools like the kadmin or ktpass know the correct kvno because > they need to connect to the KDC to work, but ktab.exe is a completely > standalone tool) > > Through 6984764, we've updated the ktab.exe tool so that user can > specify the correct kvno on the command line, or specify it as 0 if it's > unknown (0 will be accepted by the check). However, first it's quite > difficult to find out the correct kvno. Second, there are old kaytab > files that just contain wrong kvno. > > This fix intends to add a fallback to the kvno checking, that when no > key with matched kvno can be found, we will return the key of the same > etype with the highest kvno, hoping it's the last one added to the > keytab and therefore likely to be also the latest. > From xuelei.fan at oracle.com Sun Dec 16 18:50:29 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Mon, 17 Dec 2012 10:50:29 +0800 Subject: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115) In-Reply-To: <50BE11A6.2070205@oracle.com> References: <50AE3DF0.1020400@oracle.com> <50BE11A6.2070205@oracle.com> Message-ID: <50CE8875.3060104@oracle.com> Ping again ... ;-) On 12/4/2012 11:07 PM, Xuelei Fan wrote: > Ping ... > > On 11/22/2012 11:00 PM, Xuelei Fan wrote: >> Hi Valerie, Max or Brad, >> >> Can you review the update for JDK-7030966? It is the JSSE part of JEP 115. >> >> webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.00/ >> JEP 115: http://openjdk.java.net/jeps/115 >> >> In the update, I have not remove the debug synchronization. I will >> remove them before pushing the changeset. >> >> Thanks, >> Xuelei >> > From xuelei.fan at oracle.com Sun Dec 16 18:53:46 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Mon, 17 Dec 2012 10:53:46 +0800 Subject: Ping again (Re: code review request: 7197159: accept different kvno if there no match) In-Reply-To: <50CE829A.7070002@oracle.com> References: <10921938.1347183410442.JavaMail.sbladm@swsblss4-new.central.sun.com> <504C6F29.20108@oracle.com> <50CE829A.7070002@oracle.com> Message-ID: <50CE893A.1070208@oracle.com> Looks fine to me. Good to have for compatibility. Xuelei On 12/17/2012 10:25 AM, Weijun Wang wrote: > Xuelei or Valerie, > > Can you review this code change? Some customers really likes this fallback. > > Thanks > Max > > On 09/09/2012 06:27 PM, Weijun Wang wrote: >> Please take a review at this >> >> http://cr.openjdk.java.net/~weijun/7197159/webrev.00/ >> >> In 6893158, we started kvno checking when parsing AP-REQ. Since then, we >> have compatibility reports that keytab created with JDK's ktab.exe fail >> because of this change. In 6984764, we added an option to ktab.exe so >> that users can specify the correct kvno when creating a keytab, but it >> seems not enough. >> >> This fix adds another fallback to the kvno check. If none of the keys in >> a keytab matches the required kvno, instead of reporting a >> KRB_AP_ERR_BADKEYVER error, we now returns a key of the same etype with >> the highest kvno. >> >> Hope this stops the compatibility problem. >> >> *Mala*: this is the alternative way I propose to solve the problem. It >> should be applicable to 6u and 7u. >> >> Thanks >> Max >> >> >> -------- Original Message -------- >> 7197159: accept different kvno if there no match >> >> === *Description* >> ============================================================ >> 6893158 introduced kvno (key version number) check in AP-REQ parsing. >> This is a correct behavior but might cause interop/compatibility >> problems if the server uses a keytab with wrong kvno values. In fact, >> our vey own ktab.exe tool included in JDK can generate such keytab files >> because it does not know what the correct kvno is. (Other keytab >> generation tools like the kadmin or ktpass know the correct kvno because >> they need to connect to the KDC to work, but ktab.exe is a completely >> standalone tool) >> >> Through 6984764, we've updated the ktab.exe tool so that user can >> specify the correct kvno on the command line, or specify it as 0 if it's >> unknown (0 will be accepted by the check). However, first it's quite >> difficult to find out the correct kvno. Second, there are old kaytab >> files that just contain wrong kvno. >> >> This fix intends to add a fallback to the kvno checking, that when no >> key with matched kvno can be found, we will return the key of the same >> etype with the highest kvno, hoping it's the last one added to the >> keytab and therefore likely to be also the latest. >> From weijun.wang at oracle.com Sun Dec 16 20:42:00 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 17 Dec 2012 04:42:00 +0000 Subject: hg: jdk8/tl/jdk: 7197159: accept different kvno if there no match Message-ID: <20121217044222.4A03C471B5@hg.openjdk.java.net> Changeset: eaaec81aa974 Author: weijun Date: 2012-12-17 12:18 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eaaec81aa974 7197159: accept different kvno if there no match Reviewed-by: xuelei ! src/share/classes/sun/security/krb5/EncryptionKey.java ! test/sun/security/krb5/auto/DynamicKeytab.java + test/sun/security/krb5/auto/KvnoNA.java ! test/sun/security/krb5/auto/MoreKvno.java From lana.steuck at oracle.com Sun Dec 16 23:36:21 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 17 Dec 2012 07:36:21 +0000 Subject: hg: jdk8/tl: 13 new changesets Message-ID: <20121217073622.E5498471B9@hg.openjdk.java.net> Changeset: 98a7af257bee Author: erikj Date: 2012-12-03 10:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/98a7af257bee 8003819: build-infra: backslashes at end of LIB and INCLUDE in spec.gmk Summary: Removing trailing backslash from LIB and INCLUDE. Reviewed-by: ohrstrom, ohair ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain_windows.m4 Changeset: 754f91d22e1c Author: erikj Date: 2012-12-05 09:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/754f91d22e1c 8001541: Cannot build on Solaris using softlinks Summary: Fixed softlink resolver macro in configure. Reviewed-by: tbell, ohair ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh Changeset: ec187d02c95e Author: erikj Date: 2012-12-05 10:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ec187d02c95e 8004281: build-infra: Move all jar creation to images target and put jars in images/lib Summary: Fixed bug in setting up make dependencies in SetupArchive. Reviewed-by: ohair, tbell, dholmes ! common/makefiles/JavaCompilation.gmk Changeset: bd32ef0789ca Author: erikj Date: 2012-12-05 16:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/bd32ef0789ca 8003414: build-infra: fails on on windows Summary: Added extra check that windows sdk is valid. Reviewed-by: tbell, ohrstrom, ohair ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain_windows.m4 Changeset: 9a6ec97ec45c Author: katleman Date: 2012-12-05 12:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/9a6ec97ec45c Merge Changeset: c91c581321ce Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/c91c581321ce Added tag jdk8-b67 for changeset 9a6ec97ec45c ! .hgtags Changeset: 04435608c613 Author: lana Date: 2012-12-10 20:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/04435608c613 Merge Changeset: 6b96b7744913 Author: erikj Date: 2012-12-07 17:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/6b96b7744913 8004045: build-infra: Error 12 from zip when updating src.zip Summary: Hiding this error from make so that it doesn't fail Reviewed-by: ohrstrom, dholmes ! common/makefiles/JavaCompilation.gmk Changeset: 2795874efd16 Author: erikj Date: 2012-12-11 11:29 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/2795874efd16 8003945: build-infra: problems finding compiler when using --with-dev-kit Summary: Search all compiler names in dev-kit dir first. Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 Changeset: e175ecff1391 Author: erikj Date: 2012-12-11 11:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e175ecff1391 8001753: build-infra: mismatch with full debug symbol control for hotspot Summary: Enabling hotspot to use the FDS settings established at configure time Reviewed-by: dholmes, ohair ! common/autoconf/generated-configure.sh ! common/autoconf/hotspot-spec.gmk.in ! common/autoconf/jdk-options.m4 ! common/makefiles/NativeCompilation.gmk Changeset: cdb401a60cea Author: katleman Date: 2012-12-12 13:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/cdb401a60cea Merge Changeset: e9ec00893bb4 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e9ec00893bb4 Added tag jdk8-b68 for changeset cdb401a60cea ! .hgtags Changeset: 2ed5be3dd506 Author: lana Date: 2012-12-16 22:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/2ed5be3dd506 Merge From lana.steuck at oracle.com Sun Dec 16 23:36:21 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 17 Dec 2012 07:36:21 +0000 Subject: hg: jdk8/tl/corba: 2 new changesets Message-ID: <20121217073624.2ABCA471BA@hg.openjdk.java.net> Changeset: 82000531feaa Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/82000531feaa Added tag jdk8-b67 for changeset 394515ad2a55 ! .hgtags Changeset: 22ddcac208a8 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/22ddcac208a8 Added tag jdk8-b68 for changeset 82000531feaa ! .hgtags From lana.steuck at oracle.com Sun Dec 16 23:36:21 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 17 Dec 2012 07:36:21 +0000 Subject: hg: jdk8/tl/jaxws: 2 new changesets Message-ID: <20121217073630.41FAB471BB@hg.openjdk.java.net> Changeset: d3fe408f3a9a Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/d3fe408f3a9a Added tag jdk8-b67 for changeset eb06aa51dfc2 ! .hgtags Changeset: 756323c99011 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/756323c99011 Added tag jdk8-b68 for changeset d3fe408f3a9a ! .hgtags From lana.steuck at oracle.com Sun Dec 16 23:36:21 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 17 Dec 2012 07:36:21 +0000 Subject: hg: jdk8/tl/jaxp: 3 new changesets Message-ID: <20121217073633.F1ED7471BC@hg.openjdk.java.net> Changeset: b854e7008421 Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/b854e7008421 Added tag jdk8-b67 for changeset 83df3493ca3c ! .hgtags Changeset: 789a855de959 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/789a855de959 Added tag jdk8-b68 for changeset b854e7008421 ! .hgtags Changeset: 8a20e948b806 Author: lana Date: 2012-12-16 22:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/8a20e948b806 Merge From lana.steuck at oracle.com Sun Dec 16 23:36:24 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 17 Dec 2012 07:36:24 +0000 Subject: hg: jdk8/tl/langtools: 4 new changesets Message-ID: <20121217073636.62D0F471BD@hg.openjdk.java.net> Changeset: e9a13a6c9d5d Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e9a13a6c9d5d Added tag jdk8-b67 for changeset 303b09787a69 ! .hgtags Changeset: 014a6a11dfe5 Author: lana Date: 2012-12-10 20:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/014a6a11dfe5 Merge - test/tools/javac/defaultMethodExecution/DefaultMethodRegressionTests.java - test/tools/javac/diags/examples/InvalidGenericDescInFunctionalInterface.java - test/tools/javac/lambda/LambdaConversionTest.java Changeset: 13ccb5269f3d Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/13ccb5269f3d Added tag jdk8-b68 for changeset 014a6a11dfe5 ! .hgtags Changeset: f72dc656a306 Author: lana Date: 2012-12-16 22:10 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f72dc656a306 Merge From lana.steuck at oracle.com Sun Dec 16 23:36:38 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 17 Dec 2012 07:36:38 +0000 Subject: hg: jdk8/tl/hotspot: 48 new changesets Message-ID: <20121217073813.AEFEA471BE@hg.openjdk.java.net> Changeset: e1d42ba865de Author: amurillo Date: 2012-11-16 09:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e1d42ba865de 8003541: new hotspot build - hs25-b11 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 49cbd3e25ba9 Author: zgu Date: 2012-11-16 09:05 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/49cbd3e25ba9 8003487: NMT: incorrect assertion in VMMemPointerIterator::remove_released_region method (memSnapshot.cpp) Summary: The assertion is applied to only the region to be released, also performs region integrity checking Reviewed-by: acorn, coleenp ! src/share/vm/services/memSnapshot.cpp ! src/share/vm/services/memSnapshot.hpp Changeset: 3ed6de6e139b Author: coleenp Date: 2012-11-20 20:27 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3ed6de6e139b Merge Changeset: 73e64867adb7 Author: mikael Date: 2012-11-21 09:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/73e64867adb7 8003690: Example code in JVMTI GetStackTrace documentation is broken Summary: Fixed to minor errors in example code Reviewed-by: sspitsyn, dholmes ! src/share/vm/prims/jvmti.xml Changeset: 6b881a6b0665 Author: dholmes Date: 2012-11-21 20:07 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6b881a6b0665 8003591: Abstract_VM_Version::internal_vm_info_string needs to stringify FLOAT_ARCH for ease of use Reviewed-by: coleenp, kvn ! src/share/vm/runtime/vm_version.cpp Changeset: ca1be5fbe6ff Author: dholmes Date: 2012-11-21 21:26 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ca1be5fbe6ff Merge Changeset: 7c15faa95ce7 Author: mikael Date: 2012-11-27 07:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7c15faa95ce7 8003879: Duplicate definitions in vmStructs Summary: Removed duplicate entries Reviewed-by: dholmes, sspitsyn ! src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vmStructs.hpp Changeset: bbc14465e7db Author: zgu Date: 2012-11-28 09:19 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bbc14465e7db 8003689: MemTracker::init_tracking_options() reads outside array if commandline argument is empty Summary: Fixed potential buffer overrun when giving empty option to NativeMemoryTracking commandline option Reviewed-by: ctornqvi, hseigel, kvn ! src/share/vm/services/memTracker.cpp Changeset: 5de2a5bd519e Author: zgu Date: 2012-11-28 06:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5de2a5bd519e Merge Changeset: fe81517cfb77 Author: hseigel Date: 2012-11-28 08:17 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fe81517cfb77 6924920: Class Data Sharing limit on the java version string can create failures Summary: Truncate the java version string and add a hash value if it is too long. Reviewed-by: dholmes, coleenp ! src/share/vm/memory/filemap.cpp Changeset: b51dc8df86e5 Author: coleenp Date: 2012-11-28 08:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b51dc8df86e5 Merge Changeset: 59c790074993 Author: coleenp Date: 2012-11-28 17:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/59c790074993 8003635: NPG: AsynchGetCallTrace broken by Method* virtual call Summary: Make metaspace::contains be lock free and used to see if something is in metaspace, also compare Method* with vtbl pointer. Reviewed-by: dholmes, sspitsyn, dcubed, jmasa ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/compiledICHolder.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/forte.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 53715fb1597d Author: brutisso Date: 2012-11-20 11:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/53715fb1597d 7198334: UseNUMA modifies system parameters on non-NUMA system Summary: The flags MinHeapDeltaBytes and UseNUMAInterleaving must be adjusted after the OS have adjusted the UseNUMA flag in the method os::init_2. Reviewed-by: dholmes, brutisso Contributed-by: erik.helin at oracle.com ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/thread.cpp Changeset: 19c1bd641922 Author: coleenp Date: 2012-11-26 12:31 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/19c1bd641922 8003722: More gcc 4.7 compilation errors Summary: Add a few more this->qualifications. Reviewed-by: coleenp, dholmes Contributed-by: duboscq at ssw.jku.at ! src/share/vm/memory/binaryTreeDictionary.cpp Changeset: d0aa87f04bd5 Author: stefank Date: 2012-11-27 10:13 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d0aa87f04bd5 8003720: NPG: Method in interpreter stack frame can be deallocated Summary: Pass down a closure during root scanning to keep the class of the method alive. Reviewed-by: coleenp, jcoomes ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/memory/iterator.cpp ! src/share/vm/memory/iterator.hpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/runtime/vmThread.hpp + test/runtime/8003720/Asmator.java + test/runtime/8003720/Test8003720.java + test/runtime/8003720/Victim.java + test/runtime/8003720/VictimClassLoader.java Changeset: f34d701e952e Author: stefank Date: 2012-11-27 14:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f34d701e952e 8003935: Simplify the needed includes for using Thread::current() Reviewed-by: dholmes, rbackman, coleenp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/stubRoutines_sparc.cpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.cpp ! src/cpu/zero/vm/interp_masm_zero.cpp ! src/cpu/zero/vm/stubGenerator_zero.cpp ! src/cpu/zero/vm/stubRoutines_zero.cpp ! src/os/bsd/vm/mutex_bsd.cpp ! src/os/bsd/vm/mutex_bsd.inline.hpp ! src/os/bsd/vm/os_bsd.cpp ! src/os/bsd/vm/threadCritical_bsd.cpp ! src/os/bsd/vm/thread_bsd.inline.hpp ! src/os/linux/vm/mutex_linux.cpp ! src/os/linux/vm/mutex_linux.inline.hpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/threadCritical_linux.cpp ! src/os/linux/vm/thread_linux.inline.hpp ! src/os/solaris/vm/mutex_solaris.cpp ! src/os/solaris/vm/mutex_solaris.inline.hpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/threadCritical_solaris.cpp ! src/os/solaris/vm/thread_solaris.inline.hpp ! src/os/windows/vm/mutex_windows.cpp ! src/os/windows/vm/mutex_windows.inline.hpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/threadCritical_windows.cpp ! src/os/windows/vm/thread_windows.inline.hpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/bsd_x86/vm/threadLS_bsd_x86.cpp ! src/os_cpu/bsd_x86/vm/thread_bsd_x86.cpp ! src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp ! src/os_cpu/bsd_zero/vm/threadLS_bsd_zero.cpp ! src/os_cpu/bsd_zero/vm/thread_bsd_zero.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_sparc/vm/threadLS_linux_sparc.cpp ! src/os_cpu/linux_sparc/vm/thread_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_x86/vm/threadLS_linux_x86.cpp ! src/os_cpu/linux_x86/vm/thread_linux_x86.cpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/linux_zero/vm/threadLS_linux_zero.cpp ! src/os_cpu/linux_zero/vm/thread_linux_zero.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/threadLS_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/thread_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/threadLS_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/thread_solaris_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/os_cpu/windows_x86/vm/threadLS_windows_x86.cpp ! src/os_cpu/windows_x86/vm/thread_windows_x86.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.hpp ! src/share/vm/gc_implementation/g1/dirtyCardQueue.cpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp ! src/share/vm/gc_implementation/g1/ptrQueue.cpp ! src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/freeBlockDictionary.cpp ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/resourceArea.cpp ! src/share/vm/memory/resourceArea.hpp ! src/share/vm/memory/threadLocalAllocBuffer.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/markOop.cpp ! src/share/vm/oops/oop.cpp ! src/share/vm/oops/oopsHierarchy.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/runtime/fprofiler.hpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/handles.inline.hpp ! src/share/vm/runtime/interfaceSupport.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/javaCalls.cpp ! src/share/vm/runtime/javaCalls.hpp ! src/share/vm/runtime/jniHandles.cpp ! src/share/vm/runtime/memprofiler.cpp ! src/share/vm/runtime/mutex.cpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/objectMonitor.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/task.cpp ! src/share/vm/runtime/thread.cpp + src/share/vm/runtime/thread.inline.hpp ! src/share/vm/runtime/threadLocalStorage.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/runtime/vmThread.hpp ! src/share/vm/runtime/vm_operations.cpp ! src/share/vm/services/memTracker.hpp ! src/share/vm/utilities/array.cpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/events.cpp ! src/share/vm/utilities/exceptions.cpp ! src/share/vm/utilities/growableArray.cpp ! src/share/vm/utilities/preserveException.hpp ! src/share/vm/utilities/taskqueue.cpp ! src/share/vm/utilities/workgroup.hpp Changeset: 2fc0334f613a Author: johnc Date: 2012-11-27 14:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2fc0334f613a 7194633: G1: Assertion and guarantee failures in block offset table Summary: Add detailed error messages to assertions and guarantees in G1's block offset table. Reviewed-by: ysr, brutisso ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.hpp ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.inline.hpp ! src/share/vm/memory/space.cpp Changeset: c24f778e9401 Author: johnc Date: 2012-11-29 11:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c24f778e9401 Merge ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: b2dbd323c668 Author: jiangli Date: 2012-11-27 17:03 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b2dbd323c668 8003848: Make ConstMethod::generic_signature_index optional and move Method::_max_stack to ConstMethod. Summary: Make ConstMethod::generic_signature_index optional and move Method::_max_stack to ConstMethod. Reviewed-by: bdelsart, sspitsyn, coleenp ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstMethod.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 5505fbbae3d3 Author: cjplummer Date: 2012-11-29 13:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5505fbbae3d3 Merge ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 90273fc0a981 Author: coleenp Date: 2012-11-29 16:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/90273fc0a981 8000662: NPG: nashorn ant clean test262 out-of-memory with Java heap Summary: Add ClassLoaderData object for each anonymous class with metaspaces to allocate in. Reviewed-by: twisti, jrose, stefank ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/ci/ciReplay.hpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/classfile/classLoaderData.inline.hpp ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/loaderConstraints.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/memory/metachunk.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/prims/unsafe.cpp Changeset: dad48145e775 Author: stefank Date: 2012-11-29 23:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dad48145e775 8004199: Change the ASM package for Test8003720 Reviewed-by: kvn, jrose ! test/runtime/8003720/Asmator.java ! test/runtime/8003720/Test8003720.java Changeset: 5fafdef522c6 Author: johnc Date: 2012-11-30 12:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5fafdef522c6 Merge ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp Changeset: b61d9c88b759 Author: amurillo Date: 2012-11-30 16:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b61d9c88b759 Merge Changeset: 25bdce771bb3 Author: amurillo Date: 2012-11-30 16:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/25bdce771bb3 Added tag hs25-b11 for changeset b61d9c88b759 ! .hgtags Changeset: 10587a580c51 Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/10587a580c51 Added tag jdk8-b67 for changeset 25bdce771bb3 ! .hgtags Changeset: 816b7e5bf2ed Author: amurillo Date: 2012-11-30 17:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/816b7e5bf2ed 8004248: new hotspot build - hs25-b12 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 7cc69864a29b Author: kvn Date: 2012-11-16 15:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7cc69864a29b 7146636: compiler/6865265/StackOverflowBug.java fails due to changed stack minimum Summary: Increase the stack size in the run parameters. Reviewed-by: kvn Contributed-by: david.r.chase at oracle.com ! test/compiler/6865265/StackOverflowBug.java Changeset: ee32440febeb Author: vlivanov Date: 2012-11-21 05:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ee32440febeb 8001538: hs_err file does not list anymore compiled methods in compilation events Summary: Fixed message buffer size calculation. Reviewed-by: kvn, twisti ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/utilities/events.hpp Changeset: beebba0acc11 Author: twisti Date: 2012-11-26 17:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/beebba0acc11 7172640: C2: instrinsic implementations in LibraryCallKit should use argument() instead of pop() Reviewed-by: kvn, jrose ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/ci/ciSignature.hpp ! src/share/vm/interpreter/bytecodes.hpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/locknode.cpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/type.hpp Changeset: 2cd5e15048e6 Author: twisti Date: 2012-11-27 12:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2cd5e15048e6 8003868: fix shark for latest HotSpot and LLVM Reviewed-by: twisti Contributed-by: Roman Kennke ! src/cpu/zero/vm/assembler_zero.cpp ! src/cpu/zero/vm/assembler_zero.hpp ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/cpu/zero/vm/globals_zero.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/shark/llvmHeaders.hpp ! src/share/vm/shark/llvmValue.hpp ! src/share/vm/shark/sharkBlock.cpp ! src/share/vm/shark/sharkBuilder.cpp ! src/share/vm/shark/sharkBuilder.hpp ! src/share/vm/shark/sharkCacheDecache.cpp ! src/share/vm/shark/sharkCacheDecache.hpp ! src/share/vm/shark/sharkCodeBuffer.hpp ! src/share/vm/shark/sharkCompiler.cpp ! src/share/vm/shark/sharkConstant.cpp ! src/share/vm/shark/sharkContext.cpp ! src/share/vm/shark/sharkContext.hpp ! src/share/vm/shark/sharkFunction.hpp ! src/share/vm/shark/sharkIntrinsics.cpp ! src/share/vm/shark/sharkMemoryManager.cpp ! src/share/vm/shark/sharkMemoryManager.hpp ! src/share/vm/shark/sharkNativeWrapper.cpp ! src/share/vm/shark/sharkStack.cpp ! src/share/vm/shark/sharkStack.hpp ! src/share/vm/shark/sharkState.cpp ! src/share/vm/shark/sharkTopLevelBlock.cpp ! src/share/vm/shark/sharkTopLevelBlock.hpp ! src/share/vm/shark/sharkType.hpp ! src/share/vm/shark/sharkValue.cpp ! src/share/vm/shark/shark_globals.hpp Changeset: 2aff40cb4703 Author: bharadwaj Date: 2012-11-27 17:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2aff40cb4703 7092905: C2: Keep track of the number of dead nodes Summary: keep an (almost) accurate running count of the reachable (live) flow graph nodes. Reviewed-by: kvn, twisti, jrose, vlivanov ! src/share/tools/LogCompilation/README ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/CallSite.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCompilation.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Phase.java ! src/share/vm/opto/block.hpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/chaitin.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/ifg.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopUnswitch.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/postaloc.cpp ! src/share/vm/opto/reg_split.cpp ! src/share/vm/opto/stringopts.cpp Changeset: 1acccb7c0b01 Author: kvn Date: 2012-11-27 17:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1acccb7c0b01 8003850: add support for constants in stub code Summary: remember the code section and switch back to the proper one when adding constants. Reviewed-by: twisti, kvn Contributed-by: goetz.lindenmaier at sap.com ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/codeBuffer.cpp Changeset: 6ab62ad83507 Author: twisti Date: 2012-11-30 11:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6ab62ad83507 8003195: AbstractAssembler should not store code pointers but use the CodeSection directly Reviewed-by: twisti, kvn Contributed-by: Bharadwaj Yadavalli ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/assembler_x86.inline.hpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/assembler.inline.hpp ! src/share/vm/asm/codeBuffer.hpp Changeset: cd3d6a6b95d9 Author: twisti Date: 2012-11-30 15:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cd3d6a6b95d9 8003240: x86: move MacroAssembler into separate file Reviewed-by: kvn ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/codeBuffer_sparc.hpp ! src/cpu/sparc/vm/frame_sparc.hpp ! src/cpu/sparc/vm/frame_sparc.inline.hpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/assembler_x86.inline.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/cpu/x86/vm/icBuffer_x86.cpp ! src/cpu/x86/vm/icache_x86.cpp ! src/cpu/x86/vm/interp_masm_x86_32.hpp ! src/cpu/x86/vm/interp_masm_x86_64.hpp ! src/cpu/x86/vm/interpreter_x86_32.cpp ! src/cpu/x86/vm/interpreter_x86_64.cpp ! src/cpu/x86/vm/jniFastGetField_x86_32.cpp ! src/cpu/x86/vm/jniFastGetField_x86_64.cpp + src/cpu/x86/vm/macroAssembler_x86.cpp + src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/x86/vm/metaspaceShared_x86_32.cpp ! src/cpu/x86/vm/metaspaceShared_x86_64.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/nativeInst_x86.cpp ! src/cpu/x86/vm/relocInfo_x86.cpp ! src/cpu/x86/vm/runtime_x86_32.cpp ! src/cpu/x86/vm/runtime_x86_64.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vtableStubs_x86_32.cpp ! src/cpu/x86/vm/vtableStubs_x86_64.cpp ! src/os/bsd/vm/osThread_bsd.cpp ! src/os/bsd/vm/os_bsd.cpp ! src/os/bsd/vm/os_bsd.inline.hpp ! src/os/linux/vm/osThread_linux.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.inline.hpp ! src/os/solaris/vm/osThread_solaris.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.inline.hpp ! src/os/windows/vm/osThread_windows.cpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.inline.hpp ! src/os_cpu/bsd_x86/vm/assembler_bsd_x86.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/linux_x86/vm/assembler_linux_x86.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/solaris_x86/vm/assembler_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/orderAccess_solaris_x86.inline.hpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/windows_x86/vm/assembler_windows_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/assembler.inline.hpp ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/asm/codeBuffer.hpp + src/share/vm/asm/macroAssembler.hpp + src/share/vm/asm/macroAssembler.inline.hpp ! src/share/vm/c1/c1_MacroAssembler.hpp ! src/share/vm/code/icBuffer.cpp ! src/share/vm/code/relocInfo.cpp ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/runtime/atomic.cpp ! src/share/vm/runtime/atomic.hpp + src/share/vm/runtime/atomic.inline.hpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/stubCodeGenerator.cpp Changeset: dd38cfd12c3a Author: twisti Date: 2012-12-03 15:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dd38cfd12c3a 8004319: test/gc/7168848/HumongousAlloc.java fails after 7172640 Reviewed-by: kvn, johnc ! src/share/vm/opto/library_call.cpp Changeset: c5d414e98fd4 Author: neliasso Date: 2012-11-26 15:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c5d414e98fd4 8003983: LogCompilation tool is broken since c1 support Summary: Fixed emitting and parsing Reviewed-by: jrose, kvn ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCompilation.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java ! src/share/vm/c1/c1_Compilation.cpp Changeset: b7ff5879152e Author: neliasso Date: 2012-12-06 09:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b7ff5879152e 8003934: Fix generation of malformed options to Projectcreator Summary: Makefile produces unmatched quotes due to nmake bug Reviewed-by: jwilhelm, brutisso ! make/windows/projectfiles/common/Makefile Changeset: 228a94f37a67 Author: neliasso Date: 2012-12-06 14:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/228a94f37a67 Merge Changeset: f0c2369fda5a Author: twisti Date: 2012-12-06 09:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f0c2369fda5a 8003250: SPARC: move MacroAssembler into separate file Reviewed-by: jrose, kvn ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/frame_sparc.inline.hpp ! src/cpu/sparc/vm/icBuffer_sparc.cpp ! src/cpu/sparc/vm/icache_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.hpp ! src/cpu/sparc/vm/interpreter_sparc.cpp ! src/cpu/sparc/vm/jniFastGetField_sparc.cpp + src/cpu/sparc/vm/macroAssembler_sparc.cpp + src/cpu/sparc/vm/macroAssembler_sparc.hpp + src/cpu/sparc/vm/macroAssembler_sparc.inline.hpp ! src/cpu/sparc/vm/metaspaceShared_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/nativeInst_sparc.cpp ! src/cpu/sparc/vm/nativeInst_sparc.hpp ! src/cpu/sparc/vm/relocInfo_sparc.cpp ! src/cpu/sparc/vm/runtime_sparc.cpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vmreg_sparc.cpp ! src/cpu/sparc/vm/vtableStubs_sparc.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/zero/vm/assembler_zero.cpp ! src/cpu/zero/vm/assembler_zero.hpp ! src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/share/vm/adlc/main.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/macroAssembler.hpp ! src/share/vm/asm/macroAssembler.inline.hpp ! src/share/vm/asm/register.hpp ! src/share/vm/code/vmreg.hpp Changeset: 522662fa9c16 Author: twisti Date: 2012-12-06 11:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/522662fa9c16 Merge Changeset: d2f8c38e543d Author: roland Date: 2012-12-07 01:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d2f8c38e543d Merge ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/thread.cpp Changeset: 0f80645e9c26 Author: johnc Date: 2012-11-30 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0f80645e9c26 8004170: G1: Verbose GC output is not getting flushed to log file using JDK 8 Summary: Add flushes to G1CollectedHeap::log_gc_footer() and TraceCPUTime destructor. Reviewed-by: jwilhelm, azeemj, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/runtime/timer.cpp Changeset: eade6b2e4782 Author: jmasa Date: 2012-11-29 10:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/eade6b2e4782 8003554: NPG: move Metablock and Metachunk code out of metaspace.cpp Reviewed-by: coleenp + src/share/vm/memory/metablock.cpp + src/share/vm/memory/metachunk.cpp ! src/share/vm/memory/metaspace.cpp Changeset: cbe736bc70fa Author: jwilhelm Date: 2012-12-07 07:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cbe736bc70fa Merge Changeset: a35a72dd2e12 Author: amurillo Date: 2012-12-07 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a35a72dd2e12 Merge Changeset: 121aa71316af Author: amurillo Date: 2012-12-07 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/121aa71316af Added tag hs25-b12 for changeset a35a72dd2e12 ! .hgtags Changeset: 8af7d22f1f8f Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8af7d22f1f8f Added tag jdk8-b68 for changeset 121aa71316af ! .hgtags From lana.steuck at oracle.com Sun Dec 16 23:37:33 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 17 Dec 2012 07:37:33 +0000 Subject: hg: jdk8/tl/jdk: 31 new changesets Message-ID: <20121217074324.6403E471BF@hg.openjdk.java.net> Changeset: b0f008ab45d7 Author: twisti Date: 2012-11-30 11:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b0f008ab45d7 8001885: JSR 292 classes should use jdk.internal.org.objectweb.asm Reviewed-by: kvn, jrose, twisti Contributed-by: David Chase ! src/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java Changeset: 0fda013e4638 Author: erikj Date: 2012-12-05 10:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0fda013e4638 8004281: build-infra: Move all jar creation to images target and put jars in images/lib Reviewed-by: ohair, tbell, dholmes ! makefiles/CompileDemos.gmk ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk ! makefiles/Images.gmk ! makefiles/Import.gmk Changeset: ce9b02a3a17e Author: katleman Date: 2012-12-05 12:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce9b02a3a17e Merge Changeset: ea0d3a9d0d01 Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ea0d3a9d0d01 Added tag jdk8-b67 for changeset ce9b02a3a17e ! .hgtags Changeset: 39f9b2cc5738 Author: bae Date: 2012-11-28 12:28 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/39f9b2cc5738 4649812: GIFImageReader handles transparency incorrectly Reviewed-by: bae, prr Contributed-by: Vadim Pakhnushev ! src/share/classes/com/sun/imageio/plugins/gif/GIFImageReader.java Changeset: 6569819eb2fe Author: bae Date: 2012-11-28 12:38 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6569819eb2fe 5082749: GIF stream metadata specification of aspect ratio is incorrect Reviewed-by: bae, prr Contributed-by: Vadim Pakhnushev ! src/share/classes/javax/imageio/metadata/doc-files/gif_metadata.html Changeset: 934595726263 Author: bae Date: 2012-11-28 14:12 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/934595726263 7064516: ImageIO.read() fails to load an image Reviewed-by: jgodinez, prr ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/classes/java/awt/image/ColorConvertOp.java + test/sun/java2d/cmm/ColorConvertOp/InvalidRenderIntentTest.java Changeset: d54db1e16b97 Author: bae Date: 2012-11-30 11:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d54db1e16b97 7124223: [macosx] Regression test failure with new exception, when glyph is positioned explicitly Reviewed-by: jgodinez ! src/share/classes/sun/print/PathGraphics.java Changeset: bd3b3cda125d Author: lana Date: 2012-11-30 16:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd3b3cda125d Merge Changeset: 3c5bf5ed45a9 Author: bae Date: 2012-12-03 16:26 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c5bf5ed45a9 7124347: [macosx] java.lang.InternalError: not implemented yet on call Graphics2D.drawRenderedImage Reviewed-by: prr, flar ! src/share/classes/sun/java2d/opengl/OGLBlitLoops.java ! src/share/classes/sun/java2d/opengl/OGLSurfaceDataProxy.java + test/sun/java2d/OpenGL/CustomCompositeTest.java Changeset: 1175410d98ea Author: serb Date: 2012-11-21 15:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1175410d98ea 7124552: [macosx] NullPointerException in getBufferStrategy() 7124219: [macosx] Unable to draw images to fullscreen Reviewed-by: bae, anthony ! src/macosx/classes/sun/awt/CGraphicsConfig.java ! src/macosx/classes/sun/java2d/opengl/CGLGraphicsConfig.java ! src/macosx/classes/sun/lwawt/LWCanvasPeer.java ! src/macosx/classes/sun/lwawt/LWComponentPeer.java + src/macosx/classes/sun/lwawt/LWGraphicsConfig.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/PlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java - src/share/classes/sun/awt/TextureSizeConstraining.java Changeset: 5b2c31d20a64 Author: serb Date: 2012-11-21 15:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5b2c31d20a64 7193214: Consider simplifying CPlatformWindow.setResizable() Reviewed-by: anthony, denis ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTWindow.m Changeset: c9dead63607c Author: serb Date: 2012-11-21 15:58 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9dead63607c 7154516: [macosx] Popup menus have no visible borders Reviewed-by: anthony, denis ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java Changeset: 9cd48409539e Author: kizune Date: 2012-11-21 20:42 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9cd48409539e 8003273: Missing testcase for 7171812 Reviewed-by: art, serb + test/javax/swing/dnd/7171812/JListWithScroll.java + test/javax/swing/dnd/7171812/bug7171812.java Changeset: 5600005b87fb Author: serb Date: 2012-11-27 17:03 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5600005b87fb 8002308: [macosx] 7198229 should be applied to the user action only Reviewed-by: anthony, skovatch ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTWindow.m + test/java/awt/Frame/FrameSetSizeStressTest/FrameSetSizeStressTest.java Changeset: 0e91d6f3019c Author: alexsch Date: 2012-11-29 07:42 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e91d6f3019c 8000423: Diacritic is not applyed to a base letter on Linux Reviewed-by: anthony, serb ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: abee1d528df1 Author: kshefov Date: 2012-11-30 12:39 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abee1d528df1 7124242: [macosx] Test doesn't work because of the frame round corners in the LaF Reviewed-by: anthony, yan, alexsch ! test/javax/swing/text/CSSBorder/6796710/bug6796710.java Changeset: 35d8085aa14a Author: lana Date: 2012-11-30 17:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/35d8085aa14a Merge Changeset: da55ef766e48 Author: alexsch Date: 2012-12-04 15:26 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da55ef766e48 6671481: NPE at javax.swing.plaf.basic.BasicTreeUI$Handler.handleSelection Reviewed-by: serb ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java Changeset: bd175c70684c Author: alexsch Date: 2012-12-04 15:56 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd175c70684c 8003830: NPE at BasicTreeUI$Actions.page:4470 Reviewed-by: serb, alexsch Contributed-by: Jaroslav Tulach ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java + test/javax/swing/JTree/8003830/bug8003830.java Changeset: 009fd6e1d9f5 Author: alexsch Date: 2012-12-04 16:42 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/009fd6e1d9f5 8002077: Possible mnemonic issue on JFileChooser Save button on nimbus L&F Reviewed-by: serb ! src/share/classes/sun/swing/plaf/synth/SynthFileChooserUI.java Changeset: 4aad3e6f68d2 Author: jviswana Date: 2012-12-04 17:17 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4aad3e6f68d2 4631925: JColor Chooser is not fully accessible Reviewed-by: alexsch ! src/share/classes/javax/swing/JColorChooser.java ! src/share/classes/javax/swing/colorchooser/ColorChooserPanel.java ! src/share/classes/javax/swing/colorchooser/ColorPanel.java ! src/share/classes/javax/swing/plaf/basic/BasicColorChooserUI.java Changeset: ea20c9388d90 Author: aph Date: 2012-12-04 14:02 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ea20c9388d90 8004344: Fix a crash in ToolkitErrorHandler() in XlibWrapper.c Summary: Code does not check for JNU_GetEnv returning NULL. Reviewed-by: anthony ! src/solaris/native/sun/xawt/XlibWrapper.c Changeset: bbbb5c70aa59 Author: lana Date: 2012-12-04 11:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bbbb5c70aa59 Merge - src/share/classes/sun/awt/TextureSizeConstraining.java Changeset: 87028eb3f020 Author: lana Date: 2012-12-04 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/87028eb3f020 Merge Changeset: b68a5404de60 Author: lana Date: 2012-12-10 20:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b68a5404de60 Merge ! makefiles/CompileJavaClasses.gmk - src/share/classes/sun/awt/TextureSizeConstraining.java Changeset: 379e3dfa521d Author: erikj Date: 2012-12-06 12:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/379e3dfa521d 8004104: build-infra: Minor cleanup Reviewed-by: ohrstrom, tbell ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileNativeLibraries.gmk Changeset: 2689f6cfe835 Author: erikj Date: 2012-12-11 12:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2689f6cfe835 8001753: build-infra: mismatch with full debug symbol control for hotspot Summary: Changing boolean values of ENABLE_DEBUG_SYMBOLS. Reviewed-by: dholmes, ohair ! makefiles/CompileNativeLibraries.gmk Changeset: 53fb43e4d614 Author: katleman Date: 2012-12-12 13:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/53fb43e4d614 Merge ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileNativeLibraries.gmk Changeset: 7fd56a5abd94 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7fd56a5abd94 Added tag jdk8-b68 for changeset 53fb43e4d614 ! .hgtags Changeset: f959e0cc8766 Author: lana Date: 2012-12-16 22:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f959e0cc8766 Merge ! makefiles/CompileNativeLibraries.gmk - src/share/classes/sun/awt/TextureSizeConstraining.java From sean.mullan at oracle.com Mon Dec 17 05:41:22 2012 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Mon, 17 Dec 2012 13:41:22 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20121217134217.4D9A9471D0@hg.openjdk.java.net> Changeset: e4d88a7352c6 Author: mullan Date: 2012-12-17 08:28 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e4d88a7352c6 8004234: Downgrade normative references to ${java.home}/lib/security/krb5.conf Reviewed-by: alanb, weijun ! src/share/classes/javax/security/auth/kerberos/package.html Changeset: 4a21f818ebb1 Author: mullan Date: 2012-12-17 08:30 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4a21f818ebb1 Merge - src/share/classes/sun/awt/TextureSizeConstraining.java - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java From vicente.romero at oracle.com Mon Dec 17 07:00:36 2012 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Mon, 17 Dec 2012 15:00:36 +0000 Subject: hg: jdk8/tl/langtools: 8004814: javadoc should be able to detect default methods Message-ID: <20121217150042.25926471D1@hg.openjdk.java.net> Changeset: 02a18f209ab3 Author: vromero Date: 2012-12-17 14:54 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/02a18f209ab3 8004814: javadoc should be able to detect default methods Reviewed-by: jjg Contributed-by: maurizio.cimadamore at oracle.com ! src/share/classes/com/sun/javadoc/ClassDoc.java ! src/share/classes/com/sun/javadoc/MethodDoc.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java From jonathan.gibbons at oracle.com Mon Dec 17 07:47:49 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 17 Dec 2012 15:47:49 +0000 Subject: hg: jdk8/tl/langtools: 8004832: Add new doclint package Message-ID: <20121217154752.7E17B471D3@hg.openjdk.java.net> Changeset: 75ab654b5cd5 Author: jjg Date: 2012-12-17 07:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/75ab654b5cd5 8004832: Add new doclint package Reviewed-by: mcimadamore ! make/build.properties ! src/share/classes/com/sun/source/util/DocTrees.java ! src/share/classes/com/sun/source/util/JavacTask.java ! src/share/classes/com/sun/source/util/TreePath.java + src/share/classes/com/sun/tools/doclint/Checker.java + src/share/classes/com/sun/tools/doclint/DocLint.java + src/share/classes/com/sun/tools/doclint/Entity.java + src/share/classes/com/sun/tools/doclint/Env.java + src/share/classes/com/sun/tools/doclint/HtmlTag.java + src/share/classes/com/sun/tools/doclint/Messages.java + src/share/classes/com/sun/tools/doclint/resources/doclint.properties ! src/share/classes/com/sun/tools/javac/api/BasicJavacTask.java ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javac/parser/DocCommentParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/DCTree.java ! src/share/classes/com/sun/tools/javac/tree/DocPretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java + test/tools/doclint/AccessTest.java + test/tools/doclint/AccessTest.package.out + test/tools/doclint/AccessTest.private.out + test/tools/doclint/AccessTest.protected.out + test/tools/doclint/AccessTest.public.out + test/tools/doclint/AccessibilityTest.java + test/tools/doclint/AccessibilityTest.out + test/tools/doclint/DocLintTester.java + test/tools/doclint/EmptyAuthorTest.java + test/tools/doclint/EmptyAuthorTest.out + test/tools/doclint/EmptyExceptionTest.java + test/tools/doclint/EmptyExceptionTest.out + test/tools/doclint/EmptyParamTest.java + test/tools/doclint/EmptyParamTest.out + test/tools/doclint/EmptyReturnTest.java + test/tools/doclint/EmptyReturnTest.out + test/tools/doclint/EmptySerialDataTest.java + test/tools/doclint/EmptySerialDataTest.out + test/tools/doclint/EmptySerialFieldTest.java + test/tools/doclint/EmptySerialFieldTest.out + test/tools/doclint/EmptySinceTest.java + test/tools/doclint/EmptySinceTest.out + test/tools/doclint/EmptyVersionTest.java + test/tools/doclint/EmptyVersionTest.out + test/tools/doclint/HtmlAttrsTest.java + test/tools/doclint/HtmlAttrsTest.out + test/tools/doclint/HtmlTagsTest.java + test/tools/doclint/HtmlTagsTest.out + test/tools/doclint/MissingCommentTest.java + test/tools/doclint/MissingCommentTest.out + test/tools/doclint/MissingParamsTest.java + test/tools/doclint/MissingParamsTest.out + test/tools/doclint/MissingReturnTest.java + test/tools/doclint/MissingReturnTest.out + test/tools/doclint/MissingThrowsTest.java + test/tools/doclint/MissingThrowsTest.out + test/tools/doclint/OptionTest.java + test/tools/doclint/OverridesTest.java + test/tools/doclint/ReferenceTest.java + test/tools/doclint/ReferenceTest.out + test/tools/doclint/RunTest.java + test/tools/doclint/SyntaxTest.java + test/tools/doclint/SyntaxTest.out + test/tools/doclint/SyntheticTest.java + test/tools/doclint/ValidTest.java + test/tools/doclint/tidy/AnchorAlreadyDefined.java + test/tools/doclint/tidy/AnchorAlreadyDefined.out + test/tools/doclint/tidy/BadEnd.java + test/tools/doclint/tidy/BadEnd.out + test/tools/doclint/tidy/InsertImplicit.java + test/tools/doclint/tidy/InsertImplicit.out + test/tools/doclint/tidy/InvalidEntity.java + test/tools/doclint/tidy/InvalidEntity.out + test/tools/doclint/tidy/InvalidName.java + test/tools/doclint/tidy/InvalidName.out + test/tools/doclint/tidy/InvalidTag.java + test/tools/doclint/tidy/InvalidTag.out + test/tools/doclint/tidy/InvalidURI.java + test/tools/doclint/tidy/InvalidURI.out + test/tools/doclint/tidy/MissingGT.java + test/tools/doclint/tidy/MissingGT.out + test/tools/doclint/tidy/MissingTag.java + test/tools/doclint/tidy/MissingTag.out + test/tools/doclint/tidy/NestedTag.java + test/tools/doclint/tidy/NestedTag.out + test/tools/doclint/tidy/ParaInPre.java + test/tools/doclint/tidy/ParaInPre.out + test/tools/doclint/tidy/README.txt + test/tools/doclint/tidy/RepeatedAttr.java + test/tools/doclint/tidy/RepeatedAttr.out + test/tools/doclint/tidy/TextNotAllowed.java + test/tools/doclint/tidy/TextNotAllowed.out + test/tools/doclint/tidy/TrimmingEmptyTag.java + test/tools/doclint/tidy/TrimmingEmptyTag.out + test/tools/doclint/tidy/UnescapedOrUnknownEntity.java + test/tools/doclint/tidy/UnescapedOrUnknownEntity.out + test/tools/doclint/tidy/util/Main.java + test/tools/doclint/tidy/util/tidy.sh + test/tools/javac/diags/examples/NoContent.java From maurizio.cimadamore at oracle.com Mon Dec 17 08:27:55 2012 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Mon, 17 Dec 2012 16:27:55 +0000 Subject: hg: jdk8/tl/langtools: 8004099: Bad compiler diagnostic generated when poly expression is passed to non-existent method Message-ID: <20121217162759.0D394471D5@hg.openjdk.java.net> Changeset: f20568328a57 Author: mcimadamore Date: 2012-12-17 16:13 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f20568328a57 8004099: Bad compiler diagnostic generated when poly expression is passed to non-existent method Summary: Some code paths in resolve do not use methodArguments to correctly format actuals Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/lambda/BadMethodCall2.java + test/tools/javac/lambda/BadMethodCall2.out From chris.hegarty at oracle.com Mon Dec 17 08:28:02 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 17 Dec 2012 16:28:02 +0000 Subject: hg: jdk8/tl/jdk: 8005081: java/util/prefs/PrefsSpi.sh fails on macos-x Message-ID: <20121217162814.AD0D8471D6@hg.openjdk.java.net> Changeset: bcf79e6f52a0 Author: chegar Date: 2012-12-17 16:27 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bcf79e6f52a0 8005081: java/util/prefs/PrefsSpi.sh fails on macos-x Reviewed-by: alanb ! test/java/util/prefs/PrefsSpi.sh From jonathan.gibbons at oracle.com Mon Dec 17 08:34:25 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 17 Dec 2012 16:34:25 +0000 Subject: hg: jdk8/tl: 8005090: Include com.sun.source.doctree in Tree API docs Message-ID: <20121217163426.233EF471D8@hg.openjdk.java.net> Changeset: a0779b1e9a4d Author: jjg Date: 2012-12-17 08:34 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/a0779b1e9a4d 8005090: Include com.sun.source.doctree in Tree API docs Reviewed-by: erikj ! common/makefiles/javadoc/NON_CORE_PKGS.gmk From jonathan.gibbons at oracle.com Mon Dec 17 08:34:56 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 17 Dec 2012 16:34:56 +0000 Subject: hg: jdk8/tl/jdk: 8005090: Include com.sun.source.doctree in Tree API docs Message-ID: <20121217163508.2BB34471D9@hg.openjdk.java.net> Changeset: 9f1b516cd9cb Author: jjg Date: 2012-12-17 08:34 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f1b516cd9cb 8005090: Include com.sun.source.doctree in Tree API docs Reviewed-by: erikj ! make/docs/NON_CORE_PKGS.gmk From jonathan.gibbons at oracle.com Mon Dec 17 10:32:04 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 17 Dec 2012 18:32:04 +0000 Subject: hg: jdk8/tl/jdk: 8004832: Add new doclint package Message-ID: <20121217183215.6557E471E6@hg.openjdk.java.net> Changeset: bac477d67867 Author: jjg Date: 2012-12-17 10:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bac477d67867 8004832: Add new doclint package Reviewed-by: erikj, ohair ! make/common/Release.gmk ! make/common/internal/Defs-langtools.gmk ! makefiles/CreateJars.gmk From mstjohns at comcast.net Mon Dec 17 10:54:23 2012 From: mstjohns at comcast.net (Michael StJohns) Date: Mon, 17 Dec 2012 13:54:23 -0500 Subject: Code Review Request for 6996769: support AEAD ciphers In-Reply-To: <50CBD33D.9050902@oracle.com> References: <50945D35.8010201@oracle.com> <5098CECB.3020409@oracle.com> <509AE548.4020804@oracle.com> <509B481A.6010307@oracle.com> <50C29674.6000800@oracle.com> <201212140407.qBE47J5R021114@aserp1020.oracle.com> <50CBD33D.9050902@oracle.com> Message-ID: <20121217185409.581E36B84@mail.openjdk.java.net> Hi Valerie - Comments in line. At 08:32 PM 12/14/2012, Valerie (Yu-Ching) Peng wrote: >Mike, > >Thanks for the comments... >With the current API, it is still possible to have the IV generated at the provider level by calling Cipher.init(...) without GCM parameters. >This means that provider will generate IVs using provider-default iv length as well as provider-default value for tag length. >Of course, things may be a little awkward if you need to use custom tag length and a different iv length from what the provider uses as default. Right. And that may be required by specific protocols. Not saying it is now, but there needs to be support for this in the API. >SunJCE provider uses 128-bit tag length as well as 96-bit IVs as default. If there are demands to use other non-default values, then we should see if something can be done to facilitate these scenarios. It's perfectly acceptable for any given implementation to only permit 96 bit IVs, But the AEAD algorithms have the possibility of some really unique initialization variables. Going back to just the 96 bit IV you've got two ways of constructing the IV - a deterministic and a random (8.2.1 and 8.2.2). For the both of these you have a "fixed field" (aka the "free field" which may be empty in 8.2.2) which is specified by the user. For 8.2.1 you also have an invocation field which is either a linear counter or an LFSR based value. For 8.2.2 you have a random field. You really need an API for the GCMParameterSpec which allows you to specify either the IV value or the generation parameters. >As for preventing the same IV from being re-used, I think it takes more than just adding a new constructor for GCMParameterSpec. Right - but the enforcement has to be in the cipher engine, and only for the ENCRYPT operation. >Generally, AlgorithmParameterSpec objects can be converted to AlgorithmParameters objects and vice versa. If the GCMParameterSpec only specifies iv length, would you expect the provider to automatically generate a new IV w/o explicit re-init? If yes, then what should the Cipher.getParameters() return, the new one or the old one? Depends on whether there is a contract of immutability for AlgorithmParameterSpec's - if no, then you update the state in the existing object and return that object. If yes, you create a new object from the existing object with the generated IV. >Regardless which way we choose, it introduces a window on when Cipher.getParameters() should be called. If you pass in the GCMParameterSpec with just the IV format info, then when you call init, you cause that object to do a generate of the IV. The GCMParameterSpec object should indicate whether the IV was passed or generated. Thinking this through, the GCMParameterSpec needs "generateNextIV()" method. If the GCMParameterSpec is an IV generator rather than an IV container, then generateNextIV() updates the internal state of the parameter spec and IV. Every time you pass this is as an init() argument, you call generateNextIV() - the spec will either ignore the call (IV container) or update the IV (IV generator). (Hmm... possibly a common interface method for AEAD and CTR mode parameter spec object). For the pass back and forth between the GCMAlgorithmParameter object and this, just reflect the state at the time called. I think this works for the ordering specified in the GCM spec. This isn't perfect - what you really want is some state to continue from Cipher.init to Cipher.init call without reference to an externally twiddleable object. Cipher.updateIV which would do an internal reset and then update the parameter counter appropriately to get a new IV for the next message? Something similar will probably be needed for CCM as well. >Valerie > >On 12/13/12 20:07, Michael StJohns wrote: >>Sorry for the late comment - >> >>You might want to consider section 9.1, first paragraph of SP800-38D which defines the GCM mode. Basically, for FIPS validated implementations, to prevent accidental reuse, the IV needs to be generated inside the cryptographic boundary using one of the defined mechanism. Obviously, that's on the ENCRYPT side since you need to match the IV on the DECRYPT side. >> >>I think you may need to add a GCMParameterSpec that allows you to specify either the IV or the IV length as a subclass of IvParameterSpec. >> >>Mike >> >> >> >> >>At 08:23 PM 12/7/2012, Valerie (Yu-Ching) Peng wrote: >>>Max, >>> >>>The webrev has been updated so that different key + iv values have to be used for AES/GCM encryption. >>>Latest version at: http://cr.openjdk.java.net/~valeriep/6996769/webrev.03/ >>> >>>Please review and send me comments. >>>Thanks! >>>Valerie >>> >>>On 11/07/12 21:50, Valerie (Yu-Ching) Peng wrote: >>>>Max, >>>> >>>>Update: I removed the block (starting line 580 in CipherCore.java) for handling RC2 since it's never used. >>>> >>>>It turns out that the current impl in RC2Cipher always convert the AlgorithmParameters object to RC2ParameterSpec and only uses CipherCore.init(..., AlgorithmParameterSpec,...) method. Thus, I won't be adding a regression test, but rather simply document the current RC2Cipher behavior in CipherCore.java to clarify things up. >>>> >>>>The updated webrev is at: >>>>http://cr.openjdk.java.net/~valeriep/6996769/webrev.01/ >>>> >>>>Xuelei brought up the issue of enforcing (Key+IV) uniqueness for GCM mode during this afternoon's meeting. >>>>I think more changes may be made after we decide what to do. >>>>So, there may be a webrev.02 coming... Just a heads up. >>>> >>>>Thanks! >>>>Valerie >>>> >>>>On 11/07/12 14:48, Valerie (Yu-Ching) Peng wrote: >>>>>>580 } else if (key.getAlgorithm().equals("RC2")) { >>>>>> >>>>>>This seems a bug fix. Is there a regression test for it? >>>>>I just noticed this problem when make the enhancement for GCM mode. >>>>>I will add a regression test for this. From jonathan.gibbons at oracle.com Mon Dec 17 10:56:12 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 17 Dec 2012 18:56:12 +0000 Subject: hg: jdk8/tl/langtools: 8004961: rename Plugin.call to Plugin.init Message-ID: <20121217185615.4331E471ED@hg.openjdk.java.net> Changeset: 064e372f273d Author: jjg Date: 2012-12-17 10:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/064e372f273d 8004961: rename Plugin.call to Plugin.init Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/util/Plugin.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! test/tools/javac/plugin/showtype/ShowTypePlugin.java ! test/tools/javac/plugin/showtype/Test.java From vicente.romero at oracle.com Sat Dec 15 05:43:42 2012 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Sat, 15 Dec 2012 13:43:42 +0000 Subject: hg: jdk8/tl/langtools: 8004976: test/tools/javac/7153958/CPoolRefClassContainingInlinedCts.java can fail Message-ID: <20121215134348.1B0384719A@hg.openjdk.java.net> Changeset: 37a5d7eccb87 Author: vromero Date: 2012-12-14 11:16 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/37a5d7eccb87 8004976: test/tools/javac/7153958/CPoolRefClassContainingInlinedCts.java can fail Reviewed-by: jjg, mcimadamore ! test/tools/javac/7153958/CPoolRefClassContainingInlinedCts.java From vicente.romero at oracle.com Sat Dec 15 06:02:59 2012 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Sat, 15 Dec 2012 14:02:59 +0000 Subject: hg: jdk8/tl/langtools: 8000518: Javac generates duplicate name_and_type constant pool entry for class BinaryOpValueExp.java Message-ID: <20121215140302.1CD004719B@hg.openjdk.java.net> Changeset: de1ec6fc93fe Author: vromero Date: 2012-12-15 13:54 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/de1ec6fc93fe 8000518: Javac generates duplicate name_and_type constant pool entry for class BinaryOpValueExp.java Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/sym/CreateSymbols.java + test/tools/javac/8000518/DuplicateConstantPoolEntry.java ! test/tools/javac/lambda/TestInvokeDynamic.java From alexey.utkin at oracle.com Mon Dec 17 02:37:35 2012 From: alexey.utkin at oracle.com (alexey.utkin at oracle.com) Date: Mon, 17 Dec 2012 10:37:35 +0000 Subject: hg: jdk8/tl/jdk: 8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem Message-ID: <20121217103804.29186471CB@hg.openjdk.java.net> Changeset: a02212de8db6 Author: uta Date: 2012-12-17 14:34 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a02212de8db6 8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem Summary: the tests were refactored to drop AWT dependence where it was possible. Reviewed-by: alanb, mchung ! test/java/io/Serializable/resolveProxyClass/NonPublicInterface.java ! test/java/lang/Throwable/LegacyChainedExceptionSerialization.java ! test/java/lang/management/CompilationMXBean/Basic.java ! test/java/lang/reflect/Generics/Probe.java ! test/java/lang/reflect/Proxy/ClassRestrictions.java ! test/java/util/Collections/EmptyIterator.java ! test/java/util/logging/LoggingDeadlock4.java ! test/sun/tools/jrunscript/common.sh From mandy.chung at oracle.com Mon Dec 17 15:21:32 2012 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Mon, 17 Dec 2012 23:21:32 +0000 Subject: hg: jdk8/tl/langtools: 8005137: Rename DocLint.call to DocLint.init which overrides Plugin.init Message-ID: <20121217232134.BBA01471FA@hg.openjdk.java.net> Changeset: ef537bcc825a Author: mchung Date: 2012-12-17 15:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ef537bcc825a 8005137: Rename DocLint.call to DocLint.init which overrides Plugin.init Reviewed-by: darcy, jjh ! src/share/classes/com/sun/tools/doclint/DocLint.java From joe.darcy at oracle.com Tue Dec 18 00:25:42 2012 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 18 Dec 2012 08:25:42 +0000 Subject: hg: jdk8/tl/langtools: 8005046: Provide checking for a default method in javax.lang.model Message-ID: <20121218082544.95F7B47209@hg.openjdk.java.net> Changeset: bc74006c2d8d Author: darcy Date: 2012-12-18 00:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bc74006c2d8d 8005046: Provide checking for a default method in javax.lang.model Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/javax/lang/model/element/ExecutableElement.java + test/tools/javac/processing/model/element/TestExecutableElement.java From martinrb at google.com Tue Dec 18 10:04:25 2012 From: martinrb at google.com (martinrb at google.com) Date: Tue, 18 Dec 2012 18:04:25 +0000 Subject: hg: jdk8/tl/jdk: 8004863: Infinite Loop in KeepAliveStream Message-ID: <20121218180436.864A647228@hg.openjdk.java.net> Changeset: 0fabdf676395 Author: martin Date: 2012-12-17 18:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0fabdf676395 8004863: Infinite Loop in KeepAliveStream Reviewed-by: chegar ! src/share/classes/sun/net/www/http/KeepAliveStream.java + test/sun/net/www/http/KeepAliveStream/InfiniteLoop.java From maurizio.cimadamore at oracle.com Tue Dec 18 14:17:22 2012 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Tue, 18 Dec 2012 22:17:22 +0000 Subject: hg: jdk8/tl/langtools: 8005193: New regression test test/tools/javac/lambda/BadMethodCall2.java fails Message-ID: <20121218221725.5F42E47235@hg.openjdk.java.net> Changeset: 250f0acf880c Author: mcimadamore Date: 2012-12-18 22:16 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/250f0acf880c 8005193: New regression test test/tools/javac/lambda/BadMethodCall2.java fails Summary: Bad golden file in negative test Reviewed-by: jjh ! test/tools/javac/lambda/BadMethodCall2.out From joe.darcy at oracle.com Tue Dec 18 14:44:43 2012 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 18 Dec 2012 22:44:43 +0000 Subject: hg: jdk8/tl/jdk: 8005042: Add Method.isDefault to core reflection Message-ID: <20121218224503.D996C47238@hg.openjdk.java.net> Changeset: 0a1398021c7c Author: darcy Date: 2012-12-18 14:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a1398021c7c 8005042: Add Method.isDefault to core reflection Reviewed-by: alanb, forax, mduigou, jgish, mchung ! src/share/classes/java/lang/reflect/Method.java + test/java/lang/reflect/Method/IsDefaultTest.java From joe.darcy at oracle.com Tue Dec 18 14:50:26 2012 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 18 Dec 2012 22:50:26 +0000 Subject: hg: jdk8/tl/jdk: 8004699: Add type annotation storage to Constructor, Field and Method Message-ID: <20121218225038.108464723B@hg.openjdk.java.net> Changeset: 6d977f61af5e Author: darcy Date: 2012-12-18 14:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6d977f61af5e 8004699: Add type annotation storage to Constructor, Field and Method Reviewed-by: darcy, dholmes Contributed-by: joel.franck at oracle.com ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Method.java From fredrik.ohrstrom at oracle.com Tue Dec 18 01:29:51 2012 From: fredrik.ohrstrom at oracle.com (fredrik.ohrstrom at oracle.com) Date: Tue, 18 Dec 2012 09:29:51 +0000 Subject: hg: jdk8/tl/langtools: 8004657: Add hooks to javac to enable reporting dependency information. Message-ID: <20121218092954.2CEDB47212@hg.openjdk.java.net> Changeset: 92fcf299cd09 Author: ohrstrom Date: 2012-12-18 10:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/92fcf299cd09 8004657: Add hooks to javac to enable reporting dependency information. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java From lana.steuck at oracle.com Tue Dec 18 19:17:21 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 19 Dec 2012 03:17:21 +0000 Subject: hg: jdk8/tl: 2 new changesets Message-ID: <20121219031722.0C8BC47258@hg.openjdk.java.net> Changeset: e08b0096058f Author: lana Date: 2012-12-14 11:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e08b0096058f Merge Changeset: 68a81db3ceb1 Author: lana Date: 2012-12-18 17:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/68a81db3ceb1 Merge From lana.steuck at oracle.com Tue Dec 18 19:17:31 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 19 Dec 2012 03:17:31 +0000 Subject: hg: jdk8/tl/langtools: 2 new changesets Message-ID: <20121219031740.E4E3547259@hg.openjdk.java.net> Changeset: d7360bf35ee1 Author: lana Date: 2012-12-14 13:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d7360bf35ee1 Merge Changeset: 573b38691a74 Author: lana Date: 2012-12-18 18:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/573b38691a74 Merge From lana.steuck at oracle.com Tue Dec 18 19:17:59 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 19 Dec 2012 03:17:59 +0000 Subject: hg: jdk8/tl/jdk: 8 new changesets Message-ID: <20121219032112.8E53F4725C@hg.openjdk.java.net> Changeset: e8b54ae97344 Author: jviswana Date: 2012-12-12 13:28 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8b54ae97344 8004316: Printer - tempfile having incorrect extension Reviewed-by: bae, jgodinez ! src/solaris/classes/sun/print/UnixPrintJob.java Changeset: fd9e6b4c8488 Author: lana Date: 2012-12-14 11:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fd9e6b4c8488 Merge Changeset: c69424f78060 Author: serb Date: 2012-12-11 19:45 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c69424f78060 7154778: [macosx] NSView-based implementation of sun.awt.EmbeddedFrame Summary: The new implementation of EmbeddedFrame to support SWT_AWT Bridge Reviewed-by: anthony, serb, leonidr Contributed-by: Petr Pchelko ! src/macosx/classes/sun/lwawt/LWToolkit.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/PlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CMouseInfoPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CPrinterDialogPeer.java + src/macosx/classes/sun/lwawt/macosx/CViewEmbeddedFrame.java + src/macosx/classes/sun/lwawt/macosx/CViewPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CWrapper.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/AWTSurfaceLayers.m ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.m ! src/macosx/native/sun/awt/CCursorManager.m ! src/macosx/native/sun/awt/CWrapper.m ! src/macosx/native/sun/awt/awt.m ! src/macosx/native/sun/java2d/opengl/CGLLayer.m ! src/macosx/native/sun/osxapp/ThreadUtilities.h ! src/macosx/native/sun/osxapp/ThreadUtilities.m Changeset: e016ad35a764 Author: kshefov Date: 2012-12-13 15:14 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e016ad35a764 7132385: [macosx] IconifyTest of RepaintManager could use some delay Reviewed-by: serb, alexsch + test/javax/swing/RepaintManager/IconifyTest/IconifyTest.java Changeset: 71e03e17c183 Author: kshefov Date: 2012-12-14 13:32 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71e03e17c183 6757986: javax/swing/JInternalFrame/5066752/bug5066752.java needs correction Reviewed-by: serb, alexsch + test/javax/swing/JInternalFrame/5066752/bug5066752.java Changeset: 9fc7460ca3ac Author: lana Date: 2012-12-14 11:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9fc7460ca3ac Merge Changeset: de6b54a60d60 Author: lana Date: 2012-12-14 13:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/de6b54a60d60 Merge ! makefiles/CompileNativeLibraries.gmk - src/share/lib/security/java.security - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java Changeset: e515956879cd Author: lana Date: 2012-12-18 18:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e515956879cd Merge From huizhe.wang at oracle.com Tue Dec 18 21:08:38 2012 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Wed, 19 Dec 2012 05:08:38 +0000 Subject: hg: jdk8/tl/jaxp: 8003261: static field is public but not final Message-ID: <20121219050843.538F84726A@hg.openjdk.java.net> Changeset: 15b32367b23c Author: joehw Date: 2012-12-18 21:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/15b32367b23c 8003261: static field is public but not final Summary: add final to fVersion field, and make it a non-compile time constant. Reviewed-by: hawtin, lancea, dholmes, chegar ! src/com/sun/org/apache/xerces/internal/impl/Version.java From jonathan.gibbons at oracle.com Wed Dec 19 03:35:36 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 19 Dec 2012 11:35:36 +0000 Subject: hg: jdk8/tl/langtools: 8004833: Integrate doclint support into javac Message-ID: <20121219113546.777424727F@hg.openjdk.java.net> Changeset: 67b01d295cd2 Author: jjg Date: 2012-12-19 11:29 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/67b01d295cd2 8004833: Integrate doclint support into javac Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties + test/tools/javac/doclint/DocLintTest.java From alan.bateman at oracle.com Wed Dec 19 07:02:49 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 19 Dec 2012 15:02:49 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20121219150313.2B43C47287@hg.openjdk.java.net> Changeset: 3fd3bcc8bd42 Author: joehw Date: 2012-12-19 12:09 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3fd3bcc8bd42 8004371: (props) Properties.loadFromXML needs small footprint XML parser as fallback when JAXP is not present Reviewed-by: alanb, mchung, psandoz + src/share/classes/jdk/internal/org/xml/sax/Attributes.java + src/share/classes/jdk/internal/org/xml/sax/ContentHandler.java + src/share/classes/jdk/internal/org/xml/sax/DTDHandler.java + src/share/classes/jdk/internal/org/xml/sax/EntityResolver.java + src/share/classes/jdk/internal/org/xml/sax/ErrorHandler.java + src/share/classes/jdk/internal/org/xml/sax/InputSource.java + src/share/classes/jdk/internal/org/xml/sax/Locator.java + src/share/classes/jdk/internal/org/xml/sax/SAXException.java + src/share/classes/jdk/internal/org/xml/sax/SAXNotRecognizedException.java + src/share/classes/jdk/internal/org/xml/sax/SAXNotSupportedException.java + src/share/classes/jdk/internal/org/xml/sax/SAXParseException.java + src/share/classes/jdk/internal/org/xml/sax/XMLReader.java + src/share/classes/jdk/internal/org/xml/sax/helpers/DefaultHandler.java + src/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java + src/share/classes/jdk/internal/util/xml/SAXParser.java + src/share/classes/jdk/internal/util/xml/XMLStreamException.java + src/share/classes/jdk/internal/util/xml/XMLStreamWriter.java + src/share/classes/jdk/internal/util/xml/impl/Attrs.java + src/share/classes/jdk/internal/util/xml/impl/Input.java + src/share/classes/jdk/internal/util/xml/impl/Pair.java + src/share/classes/jdk/internal/util/xml/impl/Parser.java + src/share/classes/jdk/internal/util/xml/impl/ParserSAX.java + src/share/classes/jdk/internal/util/xml/impl/ReaderUTF16.java + src/share/classes/jdk/internal/util/xml/impl/ReaderUTF8.java + src/share/classes/jdk/internal/util/xml/impl/SAXParserImpl.java + src/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java + src/share/classes/jdk/internal/util/xml/impl/XMLWriter.java Changeset: cf15abdcdf88 Author: alanb Date: 2012-12-19 14:53 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf15abdcdf88 8005248: (props) Integrate small footprint parser into Properties Reviewed-by: joehw, mchung, psandoz, erikj ! make/jdk/Makefile - make/jdk/asm/Makefile ! src/share/classes/java/util/Properties.java + src/share/classes/jdk/internal/util/xml/BasicXmlPropertiesProvider.java ! test/java/util/Properties/LoadAndStoreXML.java + test/java/util/Properties/invalidxml/BadCase.xml + test/java/util/Properties/invalidxml/BadDocType.xml.excluded + test/java/util/Properties/invalidxml/NoClosingTag.xml + test/java/util/Properties/invalidxml/NoDocType.xml.excluded + test/java/util/Properties/invalidxml/NoRoot.xml + test/java/util/Properties/invalidxml/NotQuoted.xml + test/java/util/Properties/invalidxml/README.txt From jonathan.gibbons at oracle.com Wed Dec 19 09:09:26 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 19 Dec 2012 17:09:26 +0000 Subject: hg: jdk8/tl/langtools: 8005098: Provide isSynthesized() information on Attribute.Compound Message-ID: <20121219170928.A9A404728F@hg.openjdk.java.net> Changeset: f72c9c5aeaef Author: jfranck Date: 2012-12-16 11:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f72c9c5aeaef 8005098: Provide isSynthesized() information on Attribute.Compound Reviewed-by: jjg ! make/build.properties ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ParameterImpl.java ! src/share/classes/com/sun/tools/javadoc/ProgramElementDocImpl.java From joe.darcy at oracle.com Wed Dec 19 11:54:06 2012 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 19 Dec 2012 19:54:06 +0000 Subject: hg: jdk8/tl/jdk: 8005097: Tie isSynthetic javadoc to the JLS Message-ID: <20121219195417.F0A1D47295@hg.openjdk.java.net> Changeset: 1f9c19741285 Author: darcy Date: 2012-12-19 11:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f9c19741285 8005097: Tie isSynthetic javadoc to the JLS Reviewed-by: mduigou ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Member.java ! src/share/classes/java/lang/reflect/Method.java From shanliang.jiang at oracle.com Wed Dec 19 02:31:51 2012 From: shanliang.jiang at oracle.com (shanliang.jiang at oracle.com) Date: Wed, 19 Dec 2012 10:31:51 +0000 Subject: hg: jdk8/tl/jdk: 7158614: JMXStartStopTest.sh failing intermittently Message-ID: <20121219103239.3EE244727D@hg.openjdk.java.net> Changeset: c79b26b8efe0 Author: sjiang Date: 2012-12-19 11:06 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c79b26b8efe0 7158614: JMXStartStopTest.sh failing intermittently Summary: fixed 3 problems here: 1) checked the lock file too eary 2) never got the process id of a java test 3) some shell commands were not supported in some Solaris machines. Reviewed-by: dsamersoff, alanb ! test/ProblemList.txt ! test/sun/management/jmxremote/startstop/JMXStartStopDoSomething.java ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh From sean.mullan at oracle.com Wed Dec 19 13:35:33 2012 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 19 Dec 2012 16:35:33 -0500 Subject: [8] Code Review Request for 8005117: Eliminate dependency from ConfigSpiFile to com.sun.security.auth.login.ConfigFile Message-ID: <50D23325.1090909@oracle.com> For JEPs 161 and 162, we need to remove or deprecate undesirable dependencies from the compact1 profile. One of these is the dependency on com.sun.security.auth.login.ConfigFile from sun.security.provider.ConfigSpiFile. The proposed fix moves the guts of the ConfigFile implementation to sun.security.provider.ConfigSpiFile, and changes ConfigFile such that it is simply a wrapper around ConfigSpiFile. webrev: http://cr.openjdk.java.net/~mullan/webrevs/8005117/webrev.00/ bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005117 I've added the noreg-cleanup label to the bug since no new functionality is being added. Thanks, Sean From stephen.flores at oracle.com Wed Dec 19 16:23:28 2012 From: stephen.flores at oracle.com (Stephen Flores) Date: Wed, 19 Dec 2012 19:23:28 -0500 Subject: 7194075: Various classes of sunec.jar are duplicated in rt.jar In-Reply-To: <50B7A020.1050609@oracle.com> References: <50B431A3.3080808@oracle.com> <50B7A020.1050609@oracle.com> Message-ID: <50D25A80.3010009@oracle.com> Sorry, for the delayed response, I have been working in another area. Comments below: On 11/29/2012 12:49 PM, Sean Mullan wrote: > Hi Steve, > > Most of this looks good. Here are my comments: > > * General > > You haven't added any new regression tests for this. Since this is > essentially a lot of code refactoring and covered by existing tests, can > you add the noreg-cleanup keyword to the bug? > When I figure out the new bug system, will do this. > * src/share/classes/java/security/AlgorithmParameters.java > > [394] You can't make this change, since it would violate the spec which > says it returns null. You will need to workaround this some other way. > I will revert the change. > * src/share/classes/sun/security/ec/ECDSASignature.java > > [278, 305] The comment should be aligned to the left. > OK > * src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java > > [121-2] The exception message here seems misleading, since it doesn't > have to be an instance of ECPublicKey, it could just be a PublicKey as > long as the encoding is correct. Why not just set the cause to the > InvalidKeySpecException, ex: > OK, I will change the code to use the InvalidKeySpecException from the key factory to create a InvalidKeyException. Sorry, I keep forgetting about the cause constructor on exceptions, because for 8 years while working on J2ME MIDP I did not have cause constructor on exceptions or the getCause method. > What exception message did the old code throw? It might be best to > preserve that behavior. > > [151-2] same comment as above > OK > * src/share/classes/sun/security/util/ECUtil.java > > [230-60] Can you add a comment as to why this is commented out? > This commented out code was in ECParameters that was not need to implement the public contract, but to be utility code like encodePoint and decodePoint, so I moved it *as is* to ECUtil. I would like to remove it, as it the policy of other groups, but I don't know your groups policy. Which would you like: remove the code or add the comment "Code that will have a possible use in the future"? Steve. > --Sean > > On 11/26/2012 10:21 PM, Stephen Flores wrote: >> Vincent, Sean, >> >> Please review the fix for: >> >> CR 7194075: Various classes of sunec.jar are duplicated in rt.jar >> >> http://cr.openjdk.java.net/~sflores/7194075/webrev-1/ >> >> Changes: >> >> *Changed/renamed any of methods that did not support the public API to >> package private. >> >> *Moved the decode and encode point methods out of ECParameters to a new >> class sun.security.util.ECUtil. >> >> *Changed any "new byte[], System.arraycopy" blocks in ECUtil point >> methods to Arrays.copyOfRange. >> >> *Added a new AlgorithmParameterSpec in sun.security.util to get curves >> by key size, for PKCS11 to use. >> >> *Moved all of static lookup methods in ECParameters, NamedCurve and the >> curve repository to separate class (CurveDB). This made ECParameters and >> NamedCurve cleaner and easier work on (there was some ECParameters >> cleanup. >> >> *In JSSE and PKCS11 and changed the references to ECParmeters and >> NamedCurve to the ECUtil which has utility methods that use the public >> APIs. >> >> *Changed to the EC unit test to use the list of supported curves in the >> property that the SunEC provider has already. >> >> *Changed SunECEntries to build the list of supported curves property >> from the collection in CurveDB. >> >> *Changed the JDK makefiles to not duplicate EC classes in rt.jar. >> >> Thanks, >> >> Steve. > From stephen.flores at oracle.com Wed Dec 19 16:51:43 2012 From: stephen.flores at oracle.com (Stephen Flores) Date: Wed, 19 Dec 2012 19:51:43 -0500 Subject: 7194075: Various classes of sunec.jar are duplicated in rt.jar In-Reply-To: <50C551DB.9060404@oracle.com> References: <50B431A3.3080808@oracle.com> <50C551DB.9060404@oracle.com> Message-ID: <50D2611F.5060401@oracle.com> Xuelei, Sorry, for the delayed response, I have been working in another area. Comments below: On 12/09/2012 10:07 PM, Xuelei Fan wrote: > Hi Stephen, > > The update in JsseJce.java update the behaviors of SunJSSE provider. > Need more time to evaluate the impact. > > For a particular standard named curve of EC, I think the ECParameterSpec > does not change in different providers. I was wondering, is it > necessary to bind the ECParameterSpec with a particular provider? in > ECUtil, you have methods like this one: > > ECParameterSpec getECParameterSpec(Provider p, ECParameterSpec spec) > > I think it converts from one ECParameterSpec object to another > ECParameterSpec object. What's the usage of this method? > From what I can see of the code, the caller is checking to see the curve is supported. I did not change what was being done, but changed code path from a direct call into the sun.security.ec package to call into java.security packages. The provider parameter is there because to be provider independent, since the calling JSSE had already obtained the EC provider it intends to use, so I did not want to use the default provider. > And this one: > ECParameterSpec getECParameterSpec(Provider p, String name) > > For named curves, is it possible to make methods like this one to be > provider independent? > Again, a calling class will have already obtained the EC provider they intend to use. Steve. > Regards, > Xuelei > > > On 11/27/2012 11:21 AM, Stephen Flores wrote: >> Vincent, Sean, >> >> Please review the fix for: >> >> CR 7194075: Various classes of sunec.jar are duplicated in rt.jar >> >> http://cr.openjdk.java.net/~sflores/7194075/webrev-1/ >> >> Changes: >> >> *Changed/renamed any of methods that did not support the public API to >> package private. >> >> *Moved the decode and encode point methods out of ECParameters to a new >> class sun.security.util.ECUtil. >> >> *Changed any "new byte[], System.arraycopy" blocks in ECUtil point >> methods to Arrays.copyOfRange. >> >> *Added a new AlgorithmParameterSpec in sun.security.util to get curves >> by key size, for PKCS11 to use. >> >> *Moved all of static lookup methods in ECParameters, NamedCurve and the >> curve repository to separate class (CurveDB). This made ECParameters and >> NamedCurve cleaner and easier work on (there was some ECParameters cleanup. >> >> *In JSSE and PKCS11 and changed the references to ECParmeters and >> NamedCurve to the ECUtil which has utility methods that use the public >> APIs. >> >> *Changed to the EC unit test to use the list of supported curves in the >> property that the SunEC provider has already. >> >> *Changed SunECEntries to build the list of supported curves property >> from the collection in CurveDB. >> >> *Changed the JDK makefiles to not duplicate EC classes in rt.jar. >> >> Thanks, >> >> Steve. > From dmitry.samersoff at oracle.com Thu Dec 20 04:03:29 2012 From: dmitry.samersoff at oracle.com (dmitry.samersoff at oracle.com) Date: Thu, 20 Dec 2012 12:03:29 +0000 Subject: hg: jdk8/tl/jdk: 6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject Message-ID: <20121220120403.14270472CB@hg.openjdk.java.net> Changeset: b600d490dc57 Author: dsamersoff Date: 2012-12-20 16:02 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b600d490dc57 6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject Summary: call readObject in all cases Reviewed-by: emcmanus Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/javax/management/MBeanFeatureInfo.java ! src/share/classes/javax/management/MBeanInfo.java From dmitry.samersoff at oracle.com Thu Dec 20 05:06:16 2012 From: dmitry.samersoff at oracle.com (dmitry.samersoff at oracle.com) Date: Thu, 20 Dec 2012 13:06:16 +0000 Subject: hg: jdk8/tl/jdk: 6937053: RMI unmarshalling errors in ClientNotifForwarder cause silent failure Message-ID: <20121220130642.D07B0472CD@hg.openjdk.java.net> Changeset: e43f90d5af11 Author: dsamersoff Date: 2012-12-20 16:56 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e43f90d5af11 6937053: RMI unmarshalling errors in ClientNotifForwarder cause silent failure Summary: the catch block in the fetchNotifs() method is extended to expect UnmarshalException Reviewed-by: emcmanus Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/com/sun/jmx/remote/internal/ClientNotifForwarder.java From dmitry.samersoff at oracle.com Thu Dec 20 05:26:33 2012 From: dmitry.samersoff at oracle.com (dmitry.samersoff at oracle.com) Date: Thu, 20 Dec 2012 13:26:33 +0000 Subject: hg: jdk8/tl/jdk: 7009998: JMX synchronization during connection restart is faulty Message-ID: <20121220132645.201C0472CE@hg.openjdk.java.net> Changeset: 3f014bc09297 Author: dsamersoff Date: 2012-12-20 17:24 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f014bc09297 7009998: JMX synchronization during connection restart is faulty Summary: add a return statement after the re-connecting has finished and the state is CONNECTED Reviewed-by: sjiang Contributed-by: jaroslav.bachorik at oracle.com ! make/netbeans/jmx/build.properties ! src/share/classes/com/sun/jmx/remote/internal/ClientCommunicatorAdmin.java From chris.hegarty at oracle.com Thu Dec 20 05:46:19 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 20 Dec 2012 13:46:19 +0000 Subject: hg: jdk8/tl/jdk: 8002356: Add ForkJoin common pool and CountedCompleter Message-ID: <20121220134631.0AC22472CF@hg.openjdk.java.net> Changeset: d01a810798e0 Author: dl Date: 2012-12-20 13:44 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d01a810798e0 8002356: Add ForkJoin common pool and CountedCompleter Reviewed-by: chegar, mduigou ! make/java/java/FILES_java.gmk + src/share/classes/java/util/concurrent/CountedCompleter.java ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ForkJoinTask.java ! src/share/classes/java/util/concurrent/ForkJoinWorkerThread.java From chris.hegarty at oracle.com Thu Dec 20 07:05:28 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 20 Dec 2012 15:05:28 +0000 Subject: hg: jdk8/tl/jdk: 8005306: Redundant cast warning in KeepAliveStream.java Message-ID: <20121220150550.BC332472D3@hg.openjdk.java.net> Changeset: 31d2f9995d6c Author: chegar Date: 2012-12-20 15:04 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31d2f9995d6c 8005306: Redundant cast warning in KeepAliveStream.java Reviewed-by: alanb ! src/share/classes/sun/net/www/http/KeepAliveStream.java From dmitry.samersoff at oracle.com Thu Dec 20 08:16:46 2012 From: dmitry.samersoff at oracle.com (dmitry.samersoff at oracle.com) Date: Thu, 20 Dec 2012 16:16:46 +0000 Subject: hg: jdk8/tl/jdk: 8005309: Missed tests for 6783290,6937053,7009998 Message-ID: <20121220161707.A434F472DC@hg.openjdk.java.net> Changeset: c1a55ee9618e Author: dsamersoff Date: 2012-12-20 20:12 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1a55ee9618e 8005309: Missed tests for 6783290,6937053,7009998 Summary: Missed tests for 6783290,6937053,7009998 Reviewed-by: sjiang, emcmanus Contributed-by: jaroslav.bachorik at oracle.com + test/com/sun/jmx/remote/CCAdminReconnectTest.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Client/Client.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Client/ConfigKey.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Client/TestNotification.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/ConfigKey.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Server.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Ste.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/SteMBean.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/TestNotification.java + test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh + test/javax/management/MBeanInfo/SerializationTest1.java From jonathan.gibbons at oracle.com Thu Dec 20 10:09:39 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 20 Dec 2012 18:09:39 +0000 Subject: hg: jdk8/tl/langtools: 8005307: fix missing @bug tags Message-ID: <20121220180944.2AD75472ED@hg.openjdk.java.net> Changeset: a22f23fb7abf Author: jjg Date: 2012-12-20 17:59 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a22f23fb7abf 8005307: fix missing @bug tags Reviewed-by: jjh ! test/tools/doclint/AccessTest.java ! test/tools/doclint/AccessTest.package.out ! test/tools/doclint/AccessTest.private.out ! test/tools/doclint/AccessTest.protected.out ! test/tools/doclint/AccessTest.public.out ! test/tools/doclint/AccessibilityTest.java ! test/tools/doclint/AccessibilityTest.out ! test/tools/doclint/EmptyAuthorTest.java ! test/tools/doclint/EmptyAuthorTest.out ! test/tools/doclint/EmptyExceptionTest.java ! test/tools/doclint/EmptyExceptionTest.out ! test/tools/doclint/EmptyParamTest.java ! test/tools/doclint/EmptyParamTest.out ! test/tools/doclint/EmptyReturnTest.java ! test/tools/doclint/EmptyReturnTest.out ! test/tools/doclint/EmptySerialDataTest.java ! test/tools/doclint/EmptySerialDataTest.out ! test/tools/doclint/EmptySerialFieldTest.java ! test/tools/doclint/EmptySerialFieldTest.out ! test/tools/doclint/EmptySinceTest.java ! test/tools/doclint/EmptySinceTest.out ! test/tools/doclint/EmptyVersionTest.java ! test/tools/doclint/EmptyVersionTest.out ! test/tools/doclint/HtmlAttrsTest.java ! test/tools/doclint/HtmlAttrsTest.out ! test/tools/doclint/HtmlTagsTest.java ! test/tools/doclint/HtmlTagsTest.out ! test/tools/doclint/MissingParamsTest.java ! test/tools/doclint/MissingParamsTest.out ! test/tools/doclint/MissingReturnTest.java ! test/tools/doclint/MissingReturnTest.out ! test/tools/doclint/MissingThrowsTest.java ! test/tools/doclint/MissingThrowsTest.out ! test/tools/doclint/OptionTest.java ! test/tools/doclint/OverridesTest.java ! test/tools/doclint/ReferenceTest.java ! test/tools/doclint/ReferenceTest.out ! test/tools/doclint/RunTest.java ! test/tools/doclint/SyntaxTest.java ! test/tools/doclint/SyntaxTest.out ! test/tools/doclint/SyntheticTest.java ! test/tools/doclint/ValidTest.java ! test/tools/doclint/tidy/AnchorAlreadyDefined.java ! test/tools/doclint/tidy/AnchorAlreadyDefined.out ! test/tools/doclint/tidy/BadEnd.java ! test/tools/doclint/tidy/BadEnd.out ! test/tools/doclint/tidy/InsertImplicit.java ! test/tools/doclint/tidy/InsertImplicit.out ! test/tools/doclint/tidy/InvalidEntity.java ! test/tools/doclint/tidy/InvalidEntity.out ! test/tools/doclint/tidy/InvalidName.java ! test/tools/doclint/tidy/InvalidName.out ! test/tools/doclint/tidy/InvalidTag.java ! test/tools/doclint/tidy/InvalidTag.out ! test/tools/doclint/tidy/InvalidURI.java ! test/tools/doclint/tidy/InvalidURI.out ! test/tools/doclint/tidy/MissingGT.java ! test/tools/doclint/tidy/MissingGT.out ! test/tools/doclint/tidy/MissingTag.java ! test/tools/doclint/tidy/MissingTag.out ! test/tools/doclint/tidy/NestedTag.java ! test/tools/doclint/tidy/NestedTag.out ! test/tools/doclint/tidy/ParaInPre.java ! test/tools/doclint/tidy/ParaInPre.out ! test/tools/doclint/tidy/RepeatedAttr.java ! test/tools/doclint/tidy/RepeatedAttr.out ! test/tools/doclint/tidy/TextNotAllowed.java ! test/tools/doclint/tidy/TextNotAllowed.out ! test/tools/doclint/tidy/TrimmingEmptyTag.java ! test/tools/doclint/tidy/TrimmingEmptyTag.out ! test/tools/doclint/tidy/UnescapedOrUnknownEntity.java ! test/tools/doclint/tidy/UnescapedOrUnknownEntity.out From alan.bateman at oracle.com Thu Dec 20 12:32:45 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 20 Dec 2012 20:32:45 +0000 Subject: hg: jdk8/tl/jdk: 8001048: JSR-160: Allow IIOP transport to be optional Message-ID: <20121220203306.F0171472FD@hg.openjdk.java.net> Changeset: edb71a37fcb7 Author: alanb Date: 2012-12-20 20:29 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/edb71a37fcb7 8001048: JSR-160: Allow IIOP transport to be optional Reviewed-by: dsamersoff, dfuchs, mchung ! src/share/classes/com/sun/jmx/remote/internal/IIOPHelper.java ! src/share/classes/javax/management/remote/JMXConnectorFactory.java ! src/share/classes/javax/management/remote/JMXConnectorServerFactory.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/share/classes/javax/management/remote/rmi/RMIConnectorServer.java ! src/share/classes/javax/management/remote/rmi/package.html ! test/javax/management/remote/mandatory/connection/AddressableTest.java ! test/javax/management/remote/mandatory/connection/CloseableTest.java ! test/javax/management/remote/mandatory/connection/ConnectionListenerNullTest.java ! test/javax/management/remote/mandatory/connection/IIOPURLTest.java ! test/javax/management/remote/mandatory/connection/IdleTimeoutTest.java ! test/javax/management/remote/mandatory/connection/MultiThreadDeadLockTest.java ! test/javax/management/remote/mandatory/connectorServer/SetMBeanServerForwarder.java ! test/javax/management/remote/mandatory/loading/MissingClassTest.java ! test/javax/management/remote/mandatory/provider/ProviderTest.java ! test/javax/management/remote/mandatory/serverError/JMXServerErrorTest.java From alan.bateman at oracle.com Thu Dec 20 12:46:20 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 20 Dec 2012 20:46:20 +0000 Subject: hg: jdk8/tl/jdk: 8005281: (props) loadFromXML/storeToXML with small parser is not thread safe Message-ID: <20121220204631.7E4FF472FE@hg.openjdk.java.net> Changeset: eeda18683ddc Author: alanb Date: 2012-12-20 20:40 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eeda18683ddc 8005281: (props) loadFromXML/storeToXML with small parser is not thread safe Reviewed-by: mchung ! src/share/classes/jdk/internal/util/xml/BasicXmlPropertiesProvider.java + test/java/util/Properties/ConcurrentLoadAndStoreXML.java From valerie.peng at oracle.com Thu Dec 20 15:46:25 2012 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Thu, 20 Dec 2012 15:46:25 -0800 Subject: Code Review Request for 8004873: Arrayindexoutofboundsexception for jce decrypting Message-ID: <50D3A351.2050009@oracle.com> Vinnie, 8004873 is a bug inside OracleUcrypto provider whose sources are managed separately from OpenJDK. To address comments that the corresponding regression tests should also be managed separately, I removed them from the OpenJDK workspace. Here is the webrevs for OpenJDK8 as well as 7u12: http://cr.openjdk.java.net/~valeriep/8004873/webrev.00/ http://cr.openjdk.java.net/~valeriep/8004873_7u/webrev.00/ Thanks, Valerie From stuart.marks at oracle.com Thu Dec 20 21:41:54 2012 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Fri, 21 Dec 2012 05:41:54 +0000 Subject: hg: jdk8/tl/jdk: 8005290: remove -showversion from RMI test library subprocess mechanism Message-ID: <20121221054214.825BB47326@hg.openjdk.java.net> Changeset: 60adb69bf043 Author: smarks Date: 2012-12-20 20:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60adb69bf043 8005290: remove -showversion from RMI test library subprocess mechanism Reviewed-by: jgish, chegar, dmocek ! test/java/rmi/testlibrary/JavaVM.java ! test/java/rmi/testlibrary/StreamPipe.java ! test/sun/rmi/runtime/Log/6409194/NoConsoleOutput.java From Alan.Bateman at oracle.com Fri Dec 21 07:11:28 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 21 Dec 2012 15:11:28 +0000 Subject: [8] Code Review Request for 8005117: Eliminate dependency from ConfigSpiFile to com.sun.security.auth.login.ConfigFile In-Reply-To: <50D23325.1090909@oracle.com> References: <50D23325.1090909@oracle.com> Message-ID: <50D47C20.3060209@oracle.com> On 19/12/2012 21:35, Sean Mullan wrote: > For JEPs 161 and 162, we need to remove or deprecate undesirable > dependencies from the compact1 profile. > > One of these is the dependency on > com.sun.security.auth.login.ConfigFile from > sun.security.provider.ConfigSpiFile. > > The proposed fix moves the guts of the ConfigFile implementation to > sun.security.provider.ConfigSpiFile, and changes ConfigFile such that > it is simply a wrapper around ConfigSpiFile. > > webrev: http://cr.openjdk.java.net/~mullan/webrevs/8005117/webrev.00/ Thanks for doing this, it's good to get this dependency fixed. I've looked at the webrev and I can't see anything obviously wrong (meaning it looks like you've transposed the code correctly). I think once the tests pass then you are good to go. Once thing in passing is that I see this code uses legacy StreamTokenizer, might be good to get it moved to java.util.regex some day. -Alan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20121221/a4de84fc/attachment.html From joe.darcy at oracle.com Fri Dec 21 08:46:00 2012 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 21 Dec 2012 16:46:00 +0000 Subject: hg: jdk8/tl/langtools: 8005282: Use @library tag with non-relative path for javac tests Message-ID: <20121221164605.393E347337@hg.openjdk.java.net> Changeset: b52a38d4536c Author: darcy Date: 2012-12-21 08:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b52a38d4536c 8005282: Use @library tag with non-relative path for javac tests Reviewed-by: jjg ! test/tools/javac/7129225/TestImportStar.java ! test/tools/javac/cast/intersection/model/Model01.java ! test/tools/javac/classreader/T7031108.java ! test/tools/javac/enum/6350057/T6350057.java ! test/tools/javac/enum/6424358/T6424358.java ! test/tools/javac/file/T7018098.java ! test/tools/javac/multicatch/model/ModelChecker.java ! test/tools/javac/options/T7022337.java ! test/tools/javac/processing/6348499/T6348499.java ! test/tools/javac/processing/6359313/T6359313.java ! test/tools/javac/processing/6365040/T6365040.java ! test/tools/javac/processing/6413690/T6413690.java ! test/tools/javac/processing/6414633/T6414633.java ! test/tools/javac/processing/6430209/T6430209.java ! test/tools/javac/processing/6499119/ClassProcessor.java ! test/tools/javac/processing/6511613/clss41701.java ! test/tools/javac/processing/6512707/T6512707.java ! test/tools/javac/processing/6634138/T6634138.java ! test/tools/javac/processing/6994946/SemanticErrorTest.java ! test/tools/javac/processing/6994946/SyntaxErrorTest.java ! test/tools/javac/processing/T6920317.java ! test/tools/javac/processing/T7196462.java ! test/tools/javac/processing/TestWarnErrorCount.java ! test/tools/javac/processing/environment/TestSourceVersion.java ! test/tools/javac/processing/environment/round/TestContext.java ! test/tools/javac/processing/environment/round/TestElementsAnnotatedWith.java ! test/tools/javac/processing/errors/TestErrorCount.java ! test/tools/javac/processing/errors/TestFatalityOfParseErrors.java ! test/tools/javac/processing/errors/TestOptionSyntaxErrors.java ! test/tools/javac/processing/errors/TestParseErrors/TestParseErrors.java ! test/tools/javac/processing/errors/TestReturnCode.java ! test/tools/javac/processing/filer/TestFilerConstraints.java ! test/tools/javac/processing/filer/TestGetResource.java ! test/tools/javac/processing/filer/TestGetResource2.java ! test/tools/javac/processing/filer/TestInvalidRelativeNames.java ! test/tools/javac/processing/filer/TestLastRound.java ! test/tools/javac/processing/filer/TestPackageInfo.java ! test/tools/javac/processing/filer/TestValidRelativeNames.java ! test/tools/javac/processing/messager/6362067/T6362067.java ! test/tools/javac/processing/messager/MessagerBasics.java ! test/tools/javac/processing/model/6194785/T6194785.java ! test/tools/javac/processing/model/6341534/T6341534.java ! test/tools/javac/processing/model/element/TestAnonClassNames.java ! test/tools/javac/processing/model/element/TestElement.java ! test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingClass.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericClass1.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericClass2.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface1.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface2.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingInterface.java ! test/tools/javac/processing/model/element/TestNames.java ! test/tools/javac/processing/model/element/TestPackageElement.java ! test/tools/javac/processing/model/element/TestResourceElement.java ! test/tools/javac/processing/model/element/TestResourceVariable.java ! test/tools/javac/processing/model/element/TestTypeParameter.java ! test/tools/javac/processing/model/element/TypeParamBounds.java ! test/tools/javac/processing/model/type/MirroredTypeEx/OverEager.java ! test/tools/javac/processing/model/type/MirroredTypeEx/Plurality.java ! test/tools/javac/processing/model/type/NoTypes.java ! test/tools/javac/processing/model/type/TestUnionType.java ! test/tools/javac/processing/model/util/BinaryName.java ! test/tools/javac/processing/model/util/GetTypeElemBadArg.java ! test/tools/javac/processing/model/util/NoSupers.java ! test/tools/javac/processing/model/util/OverridesSpecEx.java ! test/tools/javac/processing/model/util/TypesBadArg.java ! test/tools/javac/processing/model/util/deprecation/TestDeprecation.java ! test/tools/javac/processing/model/util/directSupersOfErr/DirectSupersOfErr.java ! test/tools/javac/processing/model/util/elements/TestGetConstantExpression.java ! test/tools/javac/processing/model/util/elements/TestGetPackageOf.java ! test/tools/javac/processing/model/util/filter/TestIterables.java ! test/tools/javac/processing/options/testCommandLineClasses/Test.java ! test/tools/javac/processing/options/testPrintProcessorInfo/Test.java ! test/tools/javac/processing/options/testPrintProcessorInfo/TestWithXstdout.java ! test/tools/javac/processing/warnings/UseImplicit/TestProcUseImplicitWarning.java ! test/tools/javac/processing/werror/WError1.java ! test/tools/javac/processing/werror/WErrorGen.java ! test/tools/javac/processing/werror/WErrorLast.java ! test/tools/javac/resolve/ResolveHarness.java ! test/tools/javac/util/T6597678.java ! test/tools/javac/util/context/T7021650.java From vicente.romero at oracle.com Fri Dec 21 09:40:10 2012 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Fri, 21 Dec 2012 17:40:10 +0000 Subject: hg: jdk8/tl/langtools: 8003512: javac doesn't work with jar files with >64k entries Message-ID: <20121221174012.A48EA47340@hg.openjdk.java.net> Changeset: 189b26e3818f Author: vromero Date: 2012-12-21 15:27 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/189b26e3818f 8003512: javac doesn't work with jar files with >64k entries Reviewed-by: jjg, ksrini Contributed-by: martinrb at google.com ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java + test/tools/javac/file/zip/8003512/LoadClassFromJava6CreatedJarTest.java ! test/tools/javac/file/zip/Utils.java From shanliang.jiang at oracle.com Fri Dec 21 00:28:00 2012 From: shanliang.jiang at oracle.com (shanliang.jiang at oracle.com) Date: Fri, 21 Dec 2012 08:28:00 +0000 Subject: hg: jdk8/tl/jdk: 7146162: javax/management/remote/mandatory/connection/BrokenConnectionTest.java failing intermittently Message-ID: <20121221082824.8FF3047329@hg.openjdk.java.net> Changeset: 42ee6b6ad373 Author: jbachorik Date: 2012-12-21 09:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/42ee6b6ad373 7146162: javax/management/remote/mandatory/connection/BrokenConnectionTest.java failing intermittently Summary: ClientCommunicatorAdmin should call gotIOException((IOException)e) instead of restart((IOException)e) when detecting a communication error, because the method gotIOException will send a failure notification if necessary. Reviewed-by: emcmanus, sjiang Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/com/sun/jmx/remote/internal/ClientCommunicatorAdmin.java From shanliang.jiang at oracle.com Fri Dec 21 02:04:35 2012 From: shanliang.jiang at oracle.com (shanliang.jiang at oracle.com) Date: Fri, 21 Dec 2012 10:04:35 +0000 Subject: hg: jdk8/tl/jdk: 8005325: The script should use TESTVMOPTS Message-ID: <20121221100457.399BB4732D@hg.openjdk.java.net> Changeset: 86c10d1484e9 Author: sjiang Date: 2012-12-21 10:58 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/86c10d1484e9 8005325: The script should use TESTVMOPTS Summary: Put back TESTVMOPTS which was removed by mistake. Reviewed-by: smarks ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh From mandy.chung at oracle.com Fri Dec 21 14:02:24 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 21 Dec 2012 14:02:24 -0800 Subject: [8] Code Review Request for 8005117: Eliminate dependency from ConfigSpiFile to com.sun.security.auth.login.ConfigFile In-Reply-To: <50D23325.1090909@oracle.com> References: <50D23325.1090909@oracle.com> Message-ID: <50D4DC70.1080901@oracle.com> On 12/19/2012 1:35 PM, Sean Mullan wrote: > For JEPs 161 and 162, we need to remove or deprecate undesirable > dependencies from the compact1 profile. > > One of these is the dependency on > com.sun.security.auth.login.ConfigFile from > sun.security.provider.ConfigSpiFile. > > The proposed fix moves the guts of the ConfigFile implementation to > sun.security.provider.ConfigSpiFile, and changes ConfigFile such that > it is simply a wrapper around ConfigSpiFile. > > webrev: http://cr.openjdk.java.net/~mullan/webrevs/8005117/webrev.00/ This looks good to me from what I can tell and it's good to see the code be modernized to use some new language features. Thanks for removing this dependency. Mandy From huizhe.wang at oracle.com Fri Dec 21 17:30:21 2012 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Sat, 22 Dec 2012 01:30:21 +0000 Subject: hg: jdk8/tl/jdk: 8005280: (props) Improve test coverage for small XML parser Message-ID: <20121222013044.87D3D47361@hg.openjdk.java.net> Changeset: c1227b872a12 Author: joehw Date: 2012-12-21 17:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1227b872a12 8005280: (props) Improve test coverage for small XML parser Summary: added a few more invalid XML files, international characters to LoadAndStore test, and a behavior compatibility test. Reviewed-by: alanb, lancea + test/java/util/Properties/Compatibility.xml + test/java/util/Properties/CompatibilityTest.java ! test/java/util/Properties/LoadAndStoreXML.java + test/java/util/Properties/invalidxml/BadDocType.xml - test/java/util/Properties/invalidxml/BadDocType.xml.excluded + test/java/util/Properties/invalidxml/DTDRootNotMatch.xml + test/java/util/Properties/invalidxml/IllegalComment.xml + test/java/util/Properties/invalidxml/IllegalEntry.xml + test/java/util/Properties/invalidxml/IllegalEntry1.xml + test/java/util/Properties/invalidxml/IllegalKeyAttribute.xml + test/java/util/Properties/invalidxml/NoDocType.xml - test/java/util/Properties/invalidxml/NoDocType.xml.excluded + test/java/util/Properties/invalidxml/NoNamespaceSupport.xml From xuelei.fan at oracle.com Fri Dec 21 17:35:01 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Sat, 22 Dec 2012 09:35:01 +0800 Subject: Code review request, [JNDI], 8003265, Need to clone array of input/output parameters Message-ID: <50D50E45.5050805@oracle.com> Hi, Please review the fix for JDK-8003265, Need to clone array of input/output parameters. webrev: http://cr.openjdk.java.net./~xuelei/8003265/webrev.00/ The bug may be not yet available in Oracle bugs system. Just as the subject implies, the fix is to create safe copies of mutable input values. Thanks, Xuelei From sean.mullan at oracle.com Wed Dec 26 07:44:59 2012 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Wed, 26 Dec 2012 15:44:59 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20121226154556.058FC473A9@hg.openjdk.java.net> Changeset: 4d28776d7007 Author: mullan Date: 2012-12-26 10:07 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4d28776d7007 8005117: Eliminate dependency from ConfigSpiFile to com.sun.security.auth.login.ConfigFile Reviewed-by: alanb, mchung, weijun ! src/share/classes/com/sun/security/auth/login/ConfigFile.java ! src/share/classes/sun/security/provider/ConfigSpiFile.java Changeset: d9cab18f326a Author: mullan Date: 2012-12-26 10:08 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d9cab18f326a Merge - make/jdk/asm/Makefile From bhavesh.x.patel at oracle.com Tue Dec 25 17:27:38 2012 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Wed, 26 Dec 2012 01:27:38 +0000 Subject: hg: jdk8/tl/langtools: 8004893: the javadoc/doclet needs to be updated to accommodate lambda changes Message-ID: <20121226012742.E24CF4739F@hg.openjdk.java.net> Changeset: 690c41cdab55 Author: bpatel Date: 2012-12-25 17:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/690c41cdab55 8004893: the javadoc/doclet needs to be updated to accommodate lambda changes Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ClassWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclet.xml ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MethodTypes.java ! test/com/sun/javadoc/testHtmlTableTags/TestHtmlTableTags.java + test/com/sun/javadoc/testLambdaFeature/TestLambdaFeature.java + test/com/sun/javadoc/testLambdaFeature/pkg/A.java + test/com/sun/javadoc/testLambdaFeature/pkg/B.java ! test/com/sun/javadoc/testMethodTypes/TestMethodTypes.java From chris.hegarty at oracle.com Thu Dec 27 13:59:01 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 27 Dec 2012 21:59:01 +0000 Subject: hg: jdk8/tl/jdk: 8003981: Support Parallel Array Sorting - JEP 103 Message-ID: <20121227215929.084D9473DE@hg.openjdk.java.net> Changeset: 9d984ccd17fc Author: chegar Date: 2012-12-27 21:55 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9d984ccd17fc 8003981: Support Parallel Array Sorting - JEP 103 Reviewed-by: chegar, forax, dholmes, dl Contributed-by: david.holmes at oracle.com, dl at cs.oswego.edu, chris.hegarty at oracle.com ! make/java/java/FILES_java.gmk ! src/share/classes/java/util/Arrays.java + src/share/classes/java/util/ArraysParallelSortHelpers.java + test/java/util/Arrays/ParallelSorting.java From huizhe.wang at oracle.com Thu Dec 27 18:21:11 2012 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Fri, 28 Dec 2012 02:21:11 +0000 Subject: hg: jdk8/tl/jaxp: 8005473: Warnings compiling jaxp Message-ID: <20121228022116.28F0A473F1@hg.openjdk.java.net> Changeset: d4aea0225e80 Author: joehw Date: 2012-12-27 18:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/d4aea0225e80 8005473: Warnings compiling jaxp Summary: clean up compiling warnings. Reviewed-by: weijun, chegar, forax ! src/com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java ! src/javax/xml/transform/FactoryFinder.java ! src/javax/xml/validation/SchemaFactoryFinder.java ! src/javax/xml/xpath/XPathFactoryFinder.java From masayoshi.okutsu at oracle.com Thu Dec 27 21:35:06 2012 From: masayoshi.okutsu at oracle.com (masayoshi.okutsu at oracle.com) Date: Fri, 28 Dec 2012 05:35:06 +0000 Subject: hg: jdk8/tl/jdk: 8005471: DateFormat: Time zone info is not localized when adapter is CLDR Message-ID: <20121228053527.266194740C@hg.openjdk.java.net> Changeset: 4ad38db38fff Author: okutsu Date: 2012-12-28 14:13 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4ad38db38fff 8005471: DateFormat: Time zone info is not localized when adapter is CLDR Reviewed-by: peytoia ! src/share/classes/sun/util/resources/TimeZoneNamesBundle.java + test/java/util/TimeZone/CLDRDisplayNamesTest.java From yuka.kamiya at oracle.com Thu Dec 27 22:17:06 2012 From: yuka.kamiya at oracle.com (yuka.kamiya at oracle.com) Date: Fri, 28 Dec 2012 06:17:06 +0000 Subject: hg: jdk8/tl/jdk: 8005277: Regression in JDK 7 in Bidi implementation Message-ID: <20121228061726.7F8D347415@hg.openjdk.java.net> Changeset: 1da019e7999a Author: peytoia Date: 2012-12-28 15:07 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1da019e7999a 8005277: Regression in JDK 7 in Bidi implementation Reviewed-by: okutsu ! src/share/classes/sun/text/bidi/BidiBase.java ! test/java/text/Bidi/BidiConformance.java + test/java/text/Bidi/Bug8005277.java From masayoshi.okutsu at oracle.com Thu Dec 27 23:46:32 2012 From: masayoshi.okutsu at oracle.com (masayoshi.okutsu at oracle.com) Date: Fri, 28 Dec 2012 07:46:32 +0000 Subject: hg: jdk8/tl/jdk: 8005561: typo in Calendar Message-ID: <20121228074652.4D09447416@hg.openjdk.java.net> Changeset: f3ac419e2bf0 Author: okutsu Date: 2012-12-28 16:39 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f3ac419e2bf0 8005561: typo in Calendar Reviewed-by: peytoia ! src/share/classes/java/util/Calendar.java From xuelei.fan at oracle.com Fri Dec 28 00:55:23 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Fri, 28 Dec 2012 08:55:23 +0000 Subject: hg: jdk8/tl/jdk: 7109274: Restrict the use of certificates with RSA keys less than 1024 bits Message-ID: <20121228085543.B65E547419@hg.openjdk.java.net> Changeset: 645d774b683a Author: xuelei Date: 2012-12-28 00:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/645d774b683a 7109274: Restrict the use of certificates with RSA keys less than 1024 bits Summary: This restriction is applied via the Java Security property, "jdk.certpath.disabledAlgorithms". This will impact providers that adhere to this security property. Reviewed-by: mullan ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/java/security/cert/CertPathBuilder/targetConstraints/BuildEEBasicConstraints.java ! test/java/security/cert/pkix/policyChanges/TestPolicy.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPBuilder.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorEndEntity.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorIntermediate.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorTrustAnchor.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ClientHandshaker/RSAExport.java + test/sun/security/ssl/javax/net/ssl/TLSv12/DisabledShortRSAKeys.java ! test/sun/security/ssl/javax/net/ssl/TLSv12/ShortRSAKey512.java ! test/sun/security/tools/jarsigner/concise_jarsigner.sh From xuelei.fan at oracle.com Fri Dec 28 03:53:16 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Fri, 28 Dec 2012 11:53:16 +0000 Subject: hg: jdk8/tl/jdk: 8003265: Need to clone array of input/output parameters Message-ID: <20121228115351.CAE4B4741D@hg.openjdk.java.net> Changeset: 4472a641b4dc Author: xuelei Date: 2012-12-28 03:50 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4472a641b4dc 8003265: Need to clone array of input/output parameters Reviewed-by: mullan ! src/share/classes/com/sun/jndi/dns/DnsContext.java ! src/share/classes/com/sun/jndi/ldap/BasicControl.java From sean.mullan at oracle.com Fri Dec 28 09:39:57 2012 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 28 Dec 2012 12:39:57 -0500 Subject: [8] Code Review Request for 7019834: Eliminate dependency from PolicyFile to com.sun.security.auth.PrincipalComparator Message-ID: <50DDD96D.9090400@oracle.com> As part of the effort to prepare the platform for modules (see http://openjdk.java.net/jeps/162) we need to remove or deprecate undesirable dependencies. One of these is the dependency: sun.security.provider.PolicyFile -> com.sun.security.auth.PrincipalComparator which is problematic since the com.sun.security.auth package is not intended to be part of the base module. The solution is to add an implies method to the java.security.Principal interface. Existing PrincipalComparator implementations must also implement Principal if they are to be used by the default "JavaPolicy" Policy implementation. This change will allow us to remove the dependency on the PrincipalComparator class and preserve compatibility. Since java.security.Principal is an interface, this change requires the new default method feature of lambda. webrev: http://cr.openjdk.java.net/~mullan/webrevs/7019834/webrev.00/ Thanks, Sean From stuart.marks at oracle.com Fri Dec 28 17:35:45 2012 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Sat, 29 Dec 2012 01:35:45 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20121229013626.4A8414743B@hg.openjdk.java.net> Changeset: 0cfcba56cfa7 Author: jgish Date: 2012-12-28 18:32 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0cfcba56cfa7 8005594: Fix to 8003265 breaks build Summary: backout changeset 4472a641b4dc Reviewed-by: smarks, wetmore ! src/share/classes/com/sun/jndi/dns/DnsContext.java ! src/share/classes/com/sun/jndi/ldap/BasicControl.java Changeset: ac5e29b62288 Author: smarks Date: 2012-12-28 17:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac5e29b62288 Merge From xuelei.fan at oracle.com Fri Dec 28 19:34:05 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Sat, 29 Dec 2012 11:34:05 +0800 Subject: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115) In-Reply-To: <50CE8875.3060104@oracle.com> References: <50AE3DF0.1020400@oracle.com> <50BE11A6.2070205@oracle.com> <50CE8875.3060104@oracle.com> Message-ID: <50DE64AD.6010504@oracle.com> webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.01/ The main update in this webrev is to correct the MAC checking in (Engine)InputRecord to handle null cipher (as TLS_RSA_WITH_NULL_MD5). Thanks, Xuelei On 12/17/2012 10:50 AM, Xuelei Fan wrote: > Ping again ... ;-) > > On 12/4/2012 11:07 PM, Xuelei Fan wrote: >> Ping ... >> >> On 11/22/2012 11:00 PM, Xuelei Fan wrote: >>> Hi Valerie, Max or Brad, >>> >>> Can you review the update for JDK-7030966? It is the JSSE part of JEP 115. >>> >>> webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.00/ >>> JEP 115: http://openjdk.java.net/jeps/115 >>> >>> In the update, I have not remove the debug synchronization. I will >>> remove them before pushing the changeset. >>> >>> Thanks, >>> Xuelei >>> >> > From mandy.chung at oracle.com Fri Dec 28 22:25:45 2012 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Sat, 29 Dec 2012 06:25:45 +0000 Subject: hg: jdk8/tl: 8003562: Provide a CLI tool to analyze class dependencies Message-ID: <20121229062545.A48AB47443@hg.openjdk.java.net> Changeset: c37401e77c80 Author: mchung Date: 2012-12-28 22:20 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/c37401e77c80 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! common/bin/compare_exceptions.sh.incl From mandy.chung at oracle.com Fri Dec 28 22:27:27 2012 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Sat, 29 Dec 2012 06:27:27 +0000 Subject: hg: jdk8/tl/jdk: 8003562: Provide a CLI tool to analyze class dependencies Message-ID: <20121229062815.2274F47444@hg.openjdk.java.net> Changeset: 28b47ed08c63 Author: mchung Date: 2012-12-28 22:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/28b47ed08c63 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! make/common/Release.gmk ! make/docs/NON_CORE_PKGS.gmk ! make/launchers/Makefile ! make/launchers/Makefile.launcher ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk ! makefiles/Images.gmk From mandy.chung at oracle.com Fri Dec 28 22:31:06 2012 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Sat, 29 Dec 2012 06:31:06 +0000 Subject: hg: jdk8/tl/langtools: 8003562: Provide a CLI tool to analyze class dependencies Message-ID: <20121229063119.DD3B047445@hg.openjdk.java.net> Changeset: 0c244701188e Author: mchung Date: 2012-12-28 22:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0c244701188e 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! make/build.properties ! makefiles/BuildLangtools.gmk ! src/share/classes/com/sun/tools/classfile/Dependencies.java ! src/share/classes/com/sun/tools/classfile/Dependency.java + src/share/classes/com/sun/tools/jdeps/Archive.java + src/share/classes/com/sun/tools/jdeps/ClassFileReader.java + src/share/classes/com/sun/tools/jdeps/JdepsTask.java + src/share/classes/com/sun/tools/jdeps/Main.java + src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java + src/share/classes/com/sun/tools/jdeps/resources/jdeps.properties + src/share/classes/com/sun/tools/jdeps/resources/jdk.properties + src/share/classes/com/sun/tools/jdeps/resources/version.properties-template ! test/Makefile + test/tools/jdeps/Basic.java + test/tools/jdeps/Test.java + test/tools/jdeps/p/Foo.java From chris.hegarty at oracle.com Sat Dec 29 03:01:17 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Sat, 29 Dec 2012 11:01:17 +0000 Subject: hg: jdk8/tl/jdk: 8005556: java/net/Socks/SocksV4Test.java is missing @run tag Message-ID: <20121229110200.0BEA247449@hg.openjdk.java.net> Changeset: 3cc25d0e3bb0 Author: chegar Date: 2012-12-29 11:00 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3cc25d0e3bb0 8005556: java/net/Socks/SocksV4Test.java is missing @run tag Reviewed-by: alanb ! test/java/net/Socks/SocksV4Test.java From shanliang.jiang at oracle.com Fri Dec 28 07:45:06 2012 From: shanliang.jiang at oracle.com (shanliang.jiang at oracle.com) Date: Fri, 28 Dec 2012 15:45:06 +0000 Subject: hg: jdk8/tl/jdk: 7120365: DiffHBTest.java fails due to ConcurrentModificationException Message-ID: <20121228154606.B349E4741F@hg.openjdk.java.net> Changeset: 46675076f753 Author: sjiang Date: 2012-12-28 16:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46675076f753 7120365: DiffHBTest.java fails due to ConcurrentModificationException Summary: The problem is from the server notification forwarder, it should use a copy of listener set to do iterate. Reviewed-by: alanb ! src/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java ! test/ProblemList.txt + test/javax/management/remote/mandatory/notif/ConcurrentModificationTest.java From jonathan.gibbons at oracle.com Sat Dec 29 17:33:30 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Sun, 30 Dec 2012 01:33:30 +0000 Subject: hg: jdk8/tl/langtools: 8004727: Add compiler support for parameter reflection Message-ID: <20121230013335.3541C47452@hg.openjdk.java.net> Changeset: 31780dd06ec7 Author: jjg Date: 2012-12-29 17:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/31780dd06ec7 8004727: Add compiler support for parameter reflection Reviewed-by: jjg Contributed-by: eric.mccorkle at oracle.com ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java + src/share/classes/com/sun/tools/classfile/MethodParameters_attribute.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! src/share/classes/com/sun/tools/javac/util/Names.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java + test/tools/javac/MethodParameters.java + test/tools/javap/MethodParameters.java From jonathan.gibbons at oracle.com Sun Dec 30 06:20:43 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Sun, 30 Dec 2012 14:20:43 +0000 Subject: hg: jdk8/tl/langtools: 8005195: Doclint regression tests fail on windows Message-ID: <20121230142048.B011E4745A@hg.openjdk.java.net> Changeset: 383bc0fbd759 Author: jjg Date: 2012-12-30 06:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/383bc0fbd759 8005195: Doclint regression tests fail on windows Reviewed-by: mcimadamore ! test/tools/doclint/DocLintTester.java