Code review: 8004904: Makefile for ntlm (was Re: com/sun/security/ntlm)

[Chris Hegarty]

Thank you Max, looks fine to me.

-Chris.

On 12/12/2012 03:32, Weijun Wang wrote:
> Hi Chris/Mark
>
> I've added a makefile, please take a look
>
> http://cr.openjdk.java.net/~weijun/8004904/webrev.00/
>
> *build-dev* guys, I guess this won't affect the new build style.
>
> Thanks
> Max
>
>
> On 12/12/2012 09:28 AM, Weijun Wang wrote:
>>
>>
>> On 12/12/2012 01:50 AM, Chris Hegarty wrote:
>>> Max,
>>>
>>> Mark is looking to recompile com/sun/security/ntlm/Client.java during an
>>> incremental build. I cannot find explicit targets for the
>>> com/sun/security/ntlm files, are these compiled implicitly by reference
>>> from other source? Is there a way of forcing these to be recompiled?
>>>
>>> I admit, it is strange to me to find a complete package without some
>>> kind of explicit reference in the makefiles, but maybe I just cannot
>>> find it!
>>
>> No, you cannot find it. There was no Makefile when those files were
>> added:
>>
>> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9be643e70f42
>>
>> Thanks
>> Max
>>
>>
>>>
>>> -Chris.
>>>
>>> On 12/11/2012 05:36 PM, Mark Sheppard wrote:
>>>>
>>>> Client.java
>>>>
>>>> I modified files in other parts of jdk under sun.net
>>>> and these were rebuilt
>>>>
>>>>
>>>> regards
>>>> Mark
>>>> ----- Original Message -----
>>>> From: chris.hegarty at oracle.com
>>>> To: mark.sheppard at oracle.com
>>>> Sent: Tuesday, December 11, 2012 5:32:32 PM GMT +00:00 GMT Britain,
>>>> Ireland, Portugal
>>>> Subject: Re: com/sun/security/ntlm
>>>>
>>>> What's the actual filename?
>>>>
>>>> -Chris.
>>>>
>>>> On 12/11/2012 05:15 PM, Mark Sheppard wrote:
>>>>>
>>>>> Hi Chris,
>>>>> I need some extra debug and modified a few files e.g.
>>>>> com.sun.security.ntlm.Client.java. But the modified files
>>>>> do not seem to have been rebuilt.
>>>>>
>>>>> Can you think of anything obvious that I may have overlooked.
>>>>>
>>>>> How can I force a rebuild of this component - partial build
>>>>>
>>>>> regards
>>>>> Mark
>>>>>