From vincent.x.ryan at oracle.com Fri Jun 1 11:18:56 2012 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Fri, 01 Jun 2012 19:18:56 +0100 Subject: Code review request for JEP-121 Message-ID: <4FC90790.5070109@oracle.com> Hello Valerie, Could you please review these changes for JEP-121: http://cr.openjdk.java.net/~vinnie/6383200/webrev.00/ Thanks. From mike.duigou at oracle.com Fri Jun 1 00:15:57 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Fri, 01 Jun 2012 07:15:57 +0000 Subject: hg: jdk8/tl/jdk: 7173432: Handle null key at HashMap resize Message-ID: <20120601071616.B7FEA4767A@hg.openjdk.java.net> Changeset: 7baa22e6a6b3 Author: mduigou Date: 2012-06-01 00:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7baa22e6a6b3 7173432: Handle null key at HashMap resize Summary: If the key to be inserted into a HashMap is null and the table needs to be resized as part of the insertion then addEntry will try to recalculate the hash of a null key. This will fail with an NPE. Reviewed-by: darcy ! src/share/classes/java/util/HashMap.java + test/java/util/HashMap/NullKeyAtResize.java From littlee at linux.vnet.ibm.com Mon Jun 4 01:34:58 2012 From: littlee at linux.vnet.ibm.com (littlee at linux.vnet.ibm.com) Date: Mon, 04 Jun 2012 08:34:58 +0000 Subject: hg: jdk8/tl/jdk: 7166055: Javadoc for WeakHashMap contains misleading advice Message-ID: <20120604083518.2D7BD476CA@hg.openjdk.java.net> Changeset: 237e27c7ddc3 Author: littlee Date: 2012-06-04 16:30 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/237e27c7ddc3 7166055: Javadoc for WeakHashMap contains misleading advice Reviewed-by: dholmes, mduigou ! src/share/classes/java/util/WeakHashMap.java From weijun.wang at oracle.com Mon Jun 4 03:07:15 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 04 Jun 2012 10:07:15 +0000 Subject: hg: jdk8/tl/jdk: 7173036: test/com/sun/jdi/ConnectedVMs.java does not run as expected Message-ID: <20120604100738.40B6E476D1@hg.openjdk.java.net> Changeset: a5bb0343f135 Author: weijun Date: 2012-06-04 18:06 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a5bb0343f135 7173036: test/com/sun/jdi/ConnectedVMs.java does not run as expected Reviewed-by: alanb ! test/com/sun/jdi/ConnectedVMs.java From peter.levart at gmail.com Sun Jun 3 13:44:38 2012 From: peter.levart at gmail.com (Peter Levart) Date: Sun, 03 Jun 2012 22:44:38 +0200 Subject: hg: jdk8/tl/jdk: 6924259: Remove offset and count fields from java.lang.String In-Reply-To: <20120531032252.A69774763C@hg.openjdk.java.net> References: <20120531032252.A69774763C@hg.openjdk.java.net> Message-ID: <1359801.KFxJhQHyve@cube> On Thursday, May 31, 2012 03:22:35 AM mike.duigou at oracle.com wrote: > Changeset: 2c773daa825d > Author: mduigou > Date: 2012-05-17 10:06 -0700 > URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c773daa825d > > 6924259: Remove offset and count fields from java.lang.String > Summary: Removes the use of shared character array buffers by String along > with the two fields needed to support the use of shared buffers. Wow, that's quite a change. So .substring() is not O(1) any more? Doesn't this have impact on the performance of parsers and such that rely on the performance caracteristics of the .substring() ? Have you considered then implementing .subSequence() not in terms of just delegating to .substring() but returning a special CharSequence view over the chars of the sub-sequence? Regards, Peter > Reviewed-by: alanb, mduigou, forax, briangoetz > Contributed-by: brian.doherty at oracle.com > > ! src/share/classes/java/lang/Integer.java > ! src/share/classes/java/lang/Long.java > ! src/share/classes/java/lang/String.java > ! src/share/classes/java/lang/StringCoding.java From valerie.peng at oracle.com Mon Jun 4 13:17:46 2012 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Mon, 04 Jun 2012 13:17:46 -0700 Subject: Code review request for JEP-121 In-Reply-To: <4FC90790.5070109@oracle.com> References: <4FC90790.5070109@oracle.com> Message-ID: <4FCD17EA.4020708@oracle.com> Vinnie, I am still reviewing the changes. Just some quick comments and questions: Your current changes have both PBES1 and PBES2 impl inside the PBECipherCore.java but yet there is another new classPBES2Core.java which seems to just delegate the calls to the internal PBECipherCore object. Have you considered splitting out the PBES2 impl from PBECipherCore into PBES2Core.java? Maybe renaming PBECipherCore to PBES1Core.java so it's clear that it's PBES1 impl only. Also, instead of encapsulating the PBEXXCore object and yet duplicating all the engineXXX methods which simply delegate to the implXXX calls, why not just extending from a common parent which extends the CipherSpi class and no need for the engineXXX methods for all children classes. Thanks, Valerie On 06/01/12 11:18, Vincent Ryan wrote: > Hello Valerie, > > Could you please review these changes for JEP-121: > http://cr.openjdk.java.net/~vinnie/6383200/webrev.00/ > > Thanks. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20120604/c3e8c952/attachment.html From bradford.wetmore at oracle.com Mon Jun 4 17:52:16 2012 From: bradford.wetmore at oracle.com (Brad Wetmore) Date: Mon, 04 Jun 2012 17:52:16 -0700 Subject: Code review request for 7172149 ArrayIndexOutOfBoundsException from Signature.verify In-Reply-To: <4FC86062.2050804@linux.vnet.ibm.com> References: <4FC46447.5080802@linux.vnet.ibm.com> <4FC47083.40004@oracle.com> <4FC47699.8090302@linux.vnet.ibm.com> <4FC55B3F.2010306@oracle.com> <4FC86062.2050804@linux.vnet.ibm.com> Message-ID: <4FCD5840.4050400@oracle.com> Looks good to me, however, we are still checking on the copyright notice in the test. I think what you have is ok, but want to run it by one other person. Hope to hear back soon. The bug presents an interesting and obvious problem when you think of it. Wonder how many things we have like that elsewhere. Another thing to keep in the back on my mind for future codereviews. Thanks, Brad On 5/31/2012 11:25 PM, Jonathan Lu wrote: > Hello Xuelei, > > What do you think of the updated patch? any comments? > http://cr.openjdk.java.net/~luchsh/7172149_2/ > > Thanks > - Jonathan > > On 05/30/2012 07:26 AM, Xuelei Fan wrote: >> On 5/29/2012 3:11 PM, Jonathan Lu wrote: >>> Hi Xuelei, >>> >>> Thanks for review! >>> >>> On 05/29/2012 02:45 PM, Xuelei Fan wrote: >>>> That's an interesting topic. From my understand, the length of an array >>>> is of type "int". So normally, the (offset + length) should not be >>>> great than integer.max_value. Of course, Hostile or improper code are >>>> not of the case. >>>> >>>> What's interesting to me is that may be when we do additive operation >>>> for two "int" values, we may have to convert it to "long" in case of >>>> any >>>> overflow strictly. We are luck here because we have "long" type. But >>>> what about the additive operation for two "long" values >>> I think this issue is special, since it is about index value of Java >>> arrays, which is limited to smaller than Integer.MAX_VALUE according to >>> Java language specification, not other general conditions of comparing >>> integer or long values. >>> >>>> Jonathan, do you run into the problem in real world? >>> For now I am not quiet sure of whether it is from a real world problem, >>> but this problem does exhibit some weakness or behavior differences, >>> right? >>> >> Yes, it is an improvement. Would you please add a comment about why >> convert it to "long", and update the copyright year to 2012? Otherwise, >> looks fine to me for JDK 8. >> >> Thanks& Regards, >> Xuelei >> >>> Thanks& regards >>> -Jonathan >>> >>>> Thanks& Regards, >>>> Xuelei >>>> >>>> On 5/29/2012 1:53 PM, Jonathan Lu wrote: >>>>> Hi Security-dev, >>>>> >>>>> Here's a patch for bug7172149, could anybody please help to take a >>>>> look? >>>>> http://cr.openjdk.java.net/~luchsh/7172149/ >>>>> >>>>> The problem is that the range check in Signature.verify(byte[], int, >>>>> int) uses integer value to check whether (offset + length) is greater >>>>> than signature.length, but if (offset + length) overflows the check >>>>> will >>>>> fail and ArrayIndexOutOfBoundsException will be thrown instead of >>>>> IllegalArgumentException.My proposed solution is to make a conversion >>>>> to long in the if block. >>>>> >>>>> Thanks! >>>>> - Jonathan >>>>> > From littlee at linux.vnet.ibm.com Mon Jun 4 19:17:19 2012 From: littlee at linux.vnet.ibm.com (littlee at linux.vnet.ibm.com) Date: Tue, 05 Jun 2012 02:17:19 +0000 Subject: hg: jdk8/tl/jdk: 7173044: MemoryMonitor hangs if getMax method in MemoryUsage object returns -1 Message-ID: <20120605021729.8B384476EF@hg.openjdk.java.net> Changeset: 4573662cb28c Author: zhouyx Date: 2012-06-05 10:16 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4573662cb28c 7173044: MemoryMonitor hangs if getMax method in MemoryUsage object returns -1 Reviewed-by: dholmes, sspitsyn ! src/share/demo/management/MemoryMonitor/MemoryMonitor.java From xuelei.fan at oracle.com Mon Jun 4 21:17:59 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Tue, 05 Jun 2012 12:17:59 +0800 Subject: Code review request for 7172149 ArrayIndexOutOfBoundsException from Signature.verify In-Reply-To: <4FCD5840.4050400@oracle.com> References: <4FC46447.5080802@linux.vnet.ibm.com> <4FC47083.40004@oracle.com> <4FC47699.8090302@linux.vnet.ibm.com> <4FC55B3F.2010306@oracle.com> <4FC86062.2050804@linux.vnet.ibm.com> <4FCD5840.4050400@oracle.com> Message-ID: <4FCD8877.6060901@oracle.com> Hi Jonathan, The fix, including the copyright notice, looks good to us. Are you a committer of OpenJDK? Otherwise, I would like to help to integrate the fix into OpenJDK. Thanks, Xuelei On 6/5/2012 8:52 AM, Brad Wetmore wrote: > Looks good to me, however, we are still checking on the copyright notice > in the test. I think what you have is ok, but want to run it by one > other person. Hope to hear back soon. > > The bug presents an interesting and obvious problem when you think of > it. Wonder how many things we have like that elsewhere. Another thing > to keep in the back on my mind for future codereviews. > > Thanks, > > Brad > > > > On 5/31/2012 11:25 PM, Jonathan Lu wrote: >> Hello Xuelei, >> >> What do you think of the updated patch? any comments? >> http://cr.openjdk.java.net/~luchsh/7172149_2/ >> >> Thanks >> - Jonathan >> >> On 05/30/2012 07:26 AM, Xuelei Fan wrote: >>> On 5/29/2012 3:11 PM, Jonathan Lu wrote: >>>> Hi Xuelei, >>>> >>>> Thanks for review! >>>> >>>> On 05/29/2012 02:45 PM, Xuelei Fan wrote: >>>>> That's an interesting topic. From my understand, the length of an >>>>> array >>>>> is of type "int". So normally, the (offset + length) should not be >>>>> great than integer.max_value. Of course, Hostile or improper code are >>>>> not of the case. >>>>> >>>>> What's interesting to me is that may be when we do additive operation >>>>> for two "int" values, we may have to convert it to "long" in case of >>>>> any >>>>> overflow strictly. We are luck here because we have "long" type. But >>>>> what about the additive operation for two "long" values >>>> I think this issue is special, since it is about index value of Java >>>> arrays, which is limited to smaller than Integer.MAX_VALUE according to >>>> Java language specification, not other general conditions of comparing >>>> integer or long values. >>>> >>>>> Jonathan, do you run into the problem in real world? >>>> For now I am not quiet sure of whether it is from a real world problem, >>>> but this problem does exhibit some weakness or behavior differences, >>>> right? >>>> >>> Yes, it is an improvement. Would you please add a comment about why >>> convert it to "long", and update the copyright year to 2012? Otherwise, >>> looks fine to me for JDK 8. >>> >>> Thanks& Regards, >>> Xuelei >>> >>>> Thanks& regards >>>> -Jonathan >>>> >>>>> Thanks& Regards, >>>>> Xuelei >>>>> >>>>> On 5/29/2012 1:53 PM, Jonathan Lu wrote: >>>>>> Hi Security-dev, >>>>>> >>>>>> Here's a patch for bug7172149, could anybody please help to take a >>>>>> look? >>>>>> http://cr.openjdk.java.net/~luchsh/7172149/ >>>>>> >>>>>> The problem is that the range check in Signature.verify(byte[], int, >>>>>> int) uses integer value to check whether (offset + length) is greater >>>>>> than signature.length, but if (offset + length) overflows the check >>>>>> will >>>>>> fail and ArrayIndexOutOfBoundsException will be thrown instead of >>>>>> IllegalArgumentException.My proposed solution is to make a conversion >>>>>> to long in the if block. >>>>>> >>>>>> Thanks! >>>>>> - Jonathan >>>>>> >> From weijun.wang at oracle.com Tue Jun 5 00:56:40 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 05 Jun 2012 15:56:40 +0800 Subject: Code review request: 7172701: KDC tests cleanup In-Reply-To: <3888519.1338369662678.JavaMail.sbladm@swsblss4-new.central.sun.com> References: <3888519.1338369662678.JavaMail.sbladm@swsblss4-new.central.sun.com> Message-ID: <4FCDBBB8.8050009@oracle.com> Xuelei or Valerie, Anyone can take a review on this cleanup? http://cr.openjdk.java.net/~weijun/7172701/webrev.00/ There are two parts in the webrev: 1. policy and option combined as option in KDC.java. Policy was designed (in the configMatch method) to match a rule to client and server names but currently there is only one policy and it only support server names. Just hard code it. 2. Remove the two shell tests and add commands back into java tests as multiple @run lines. Please note that jtreg currently does not support comments between @run lines, so I rewrite the comments as @run arguments. At least these two tests only recognize fixed-length argument lists so it's OK. I will change to real @comments once it's supported. Thanks, Max -------- Original Message -------- 7172701: cleanup options and policies in KDC tests === *Description* ============================================================ The behaviors of the simple KDC in test/sun/security/krb5/auto can be configured with either options or policies, and in fact there is no real difference between these two concepts. It's better to use only one set of configurations. Also, remove two shell tests and use multiple @run inside java tests. From xuelei.fan at oracle.com Tue Jun 5 01:35:47 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Tue, 05 Jun 2012 16:35:47 +0800 Subject: Code review request: 7172701: KDC tests cleanup In-Reply-To: <4FCDBBB8.8050009@oracle.com> References: <3888519.1338369662678.JavaMail.sbladm@swsblss4-new.central.sun.com> <4FCDBBB8.8050009@oracle.com> Message-ID: <4FCDC4E3.7000804@oracle.com> Looks fine to me. The copyright date is not changed. It is OK, but I will always suggest to change the date so that there is not need of an additional change log for the date in the future. Xuelei On 6/5/2012 3:56 PM, Weijun Wang wrote: > Xuelei or Valerie, > > Anyone can take a review on this cleanup? > > http://cr.openjdk.java.net/~weijun/7172701/webrev.00/ > > There are two parts in the webrev: > > 1. policy and option combined as option in KDC.java. Policy was designed > (in the configMatch method) to match a rule to client and server names > but currently there is only one policy and it only support server names. > Just hard code it. > > 2. Remove the two shell tests and add commands back into java tests as > multiple @run lines. Please note that jtreg currently does not support > comments between @run lines, so I rewrite the comments as @run > arguments. At least these two tests only recognize fixed-length argument > lists so it's OK. I will change to real @comments once it's supported. > > Thanks, > Max > > -------- Original Message -------- > 7172701: cleanup options and policies in KDC tests > > === *Description* > ============================================================ > The behaviors of the simple KDC in test/sun/security/krb5/auto can be > configured with either options or policies, and in fact there is no real > difference between these two concepts. It's better to use only one set > of configurations. > > Also, remove two shell tests and use multiple @run inside java tests. From weijun.wang at oracle.com Tue Jun 5 02:12:20 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Tue, 05 Jun 2012 09:12:20 +0000 Subject: hg: jdk8/tl/jdk: 7172701: KDC tests cleanup Message-ID: <20120605091426.A138A476F5@hg.openjdk.java.net> Changeset: 0678af55d3db Author: weijun Date: 2012-06-05 17:11 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0678af55d3db 7172701: KDC tests cleanup Reviewed-by: xuelei ! test/sun/security/krb5/auto/KDC.java ! test/sun/security/krb5/auto/OkAsDelegate.java ! test/sun/security/krb5/auto/OkAsDelegateXRealm.java - test/sun/security/krb5/auto/ok-as-delegate-xrealm.sh - test/sun/security/krb5/auto/ok-as-delegate.sh From alan.bateman at oracle.com Tue Jun 5 05:56:05 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 05 Jun 2012 12:56:05 +0000 Subject: hg: jdk8/tl/jdk: 7173515: (se) Selector.open fails with OOME on Solaris when unlimited file descriptors Message-ID: <20120605125622.6EC16476FF@hg.openjdk.java.net> Changeset: 5ea56641276c Author: alanb Date: 2012-06-05 12:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ea56641276c 7173515: (se) Selector.open fails with OOME on Solaris when unlimited file descriptors Reviewed-by: coffeys, chegar - src/share/classes/sun/nio/ch/DevPollSelectorProvider.java ! src/solaris/classes/sun/nio/ch/DevPollArrayWrapper.java + src/solaris/classes/sun/nio/ch/DevPollSelectorProvider.java From weijun.wang at oracle.com Tue Jun 5 07:52:30 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 05 Jun 2012 22:52:30 +0800 Subject: code review request: 7174351: test/sun/security/tools/keytool/standard.sh failed after new Hashtable In-Reply-To: <18859698.1338902692091.JavaMail.sbladm@swsblss4-new.central.sun.com> References: <18859698.1338902692091.JavaMail.sbladm@swsblss4-new.central.sun.com> Message-ID: <4FCE1D2E.4030707@oracle.com> Hi Xuelei Can you take a look at this? http://cr.openjdk.java.net/~weijun/7174351/webrev.00 In the test, I try to import a JCEKS keystore into a JKS one. The JCEKS one includes 4 entries: s1, Jun 5, 2012, SecretKeyEntry, s2, Jun 5, 2012, SecretKeyEntry, c1, Jun 5, 2012, trustedCertEntry, p1, Jun 5, 2012, PrivateKeyEntry, Since you cannot store a SecretKeyEntry inside a JKS, there will be a warning like Entry for alias s1 not imported. Do you want to quit the import process? [no]: If you enter "no" (or simply press ENTER) the import will go on with the next entry, with "yes", it terminates immediately. So in the webrev you can see me calling the exact same commands twice. First give it "\n\n" to ignore warnings for both s1 and s2. Second give it a "yes\n" to terminate the import. Both should be consumed by the command correctly, and no keystroke is left in buffer. However, the test has a bug that before the 2nd importstore, the x.jks file already exists. Before Mike introduced the new hash feature, it still works because s1 is always the first to import, so a single "yes" terminates the command nicely. Now, the order is random, and if you happen to see c1 comes first, another kind of prompt would show: Existing entry alias c1 exists, overwrite? [no]: Here a single "yes" won't complete the command and the test fails. Now I remove the x.jks before the 2nd call. Thanks Max -------- Original Message -------- 7174351: test/sun/security/tools/keytool/standard.sh failed after new Hashtable === *Description* ============================================================ sun/security/tools/keytool/standard.sh test/sun/security/tools/keytool/standard.sh failed since 7118743 : Alternative Hashing for String with Hash-based Maps. The test mistakenly assumes a certain order of aliases in a keystore, stored in a Hashtable. From vincent.x.ryan at oracle.com Tue Jun 5 09:01:02 2012 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Tue, 05 Jun 2012 17:01:02 +0100 Subject: Code review request for JEP-121 In-Reply-To: <4FCD17EA.4020708@oracle.com> References: <4FC90790.5070109@oracle.com> <4FCD17EA.4020708@oracle.com> Message-ID: <4FCE2D3E.5010007@oracle.com> Thanks for those comments. I've refactored the classes as suggested and generated a new webrev: http://cr.openjdk.java.net/~vinnie/6383200/webrev.01/ On 06/ 4/12 09:17 PM, Valerie (Yu-Ching) Peng wrote: > Vinnie, > > I am still reviewing the changes. > Just some quick comments and questions: > Your current changes have both PBES1 and PBES2 impl inside the PBECipherCore.java but yet there is > another new classPBES2Core.java which seems to just delegate the calls to the internal PBECipherCore > object. > > Have you considered splitting out the PBES2 impl from PBECipherCore into PBES2Core.java? > Maybe renaming PBECipherCore to PBES1Core.java so it's clear that it's PBES1 impl only. > > Also, instead of encapsulating the PBEXXCore object and yet duplicating all the engineXXX methods > which simply delegate to the implXXX calls, why not just extending from a common parent which extends > the CipherSpi class and no need for the engineXXX methods for all children classes. > > Thanks, > Valerie > > > On 06/01/12 11:18, Vincent Ryan wrote: >> Hello Valerie, >> >> Could you please review these changes for JEP-121: >> http://cr.openjdk.java.net/~vinnie/6383200/webrev.00/ >> >> Thanks. > From xueming.shen at oracle.com Tue Jun 5 12:01:43 2012 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 05 Jun 2012 19:01:43 +0000 Subject: hg: jdk8/tl/jdk: 6183404: Many eudc characters are incorrectly mapped in MS936 and GBK converter Message-ID: <20120605190152.B7FAC47707@hg.openjdk.java.net> Changeset: d1f52390275b Author: sherman Date: 2012-06-05 12:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1f52390275b 6183404: Many eudc characters are incorrectly mapped in MS936 and GBK converter Summary: updated MS936 and GBK mappings Reviewed-by: alanb ! make/tools/CharsetMapping/GBK.map ! make/tools/CharsetMapping/MS936.map From xuelei.fan at oracle.com Tue Jun 5 16:45:17 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 06 Jun 2012 07:45:17 +0800 Subject: code review request: 7174351: test/sun/security/tools/keytool/standard.sh failed after new Hashtable In-Reply-To: <4FCE1D2E.4030707@oracle.com> References: <18859698.1338902692091.JavaMail.sbladm@swsblss4-new.central.sun.com> <4FCE1D2E.4030707@oracle.com> Message-ID: <4FCE9A0D.7020605@oracle.com> Looks fine! Xuelei On 6/5/2012 10:52 PM, Weijun Wang wrote: > Hi Xuelei > > Can you take a look at this? > > http://cr.openjdk.java.net/~weijun/7174351/webrev.00 > > In the test, I try to import a JCEKS keystore into a JKS one. The JCEKS > one includes 4 entries: > > s1, Jun 5, 2012, SecretKeyEntry, > s2, Jun 5, 2012, SecretKeyEntry, > c1, Jun 5, 2012, trustedCertEntry, > p1, Jun 5, 2012, PrivateKeyEntry, > > Since you cannot store a SecretKeyEntry inside a JKS, there will be a > warning like > > Entry for alias s1 not imported. > Do you want to quit the import process? [no]: > > If you enter "no" (or simply press ENTER) the import will go on with the > next entry, with "yes", it terminates immediately. > > So in the webrev you can see me calling the exact same commands twice. > First give it "\n\n" to ignore warnings for both s1 and s2. Second give > it a "yes\n" to terminate the import. Both should be consumed by the > command correctly, and no keystroke is left in buffer. > > However, the test has a bug that before the 2nd importstore, the x.jks > file already exists. Before Mike introduced the new hash feature, it > still works because s1 is always the first to import, so a single "yes" > terminates the command nicely. Now, the order is random, and if you > happen to see c1 comes first, another kind of prompt would show: > > Existing entry alias c1 exists, overwrite? [no]: > > Here a single "yes" won't complete the command and the test fails. > > Now I remove the x.jks before the 2nd call. > > Thanks > Max > > > -------- Original Message -------- > 7174351: test/sun/security/tools/keytool/standard.sh failed after new > Hashtable > > === *Description* > ============================================================ > sun/security/tools/keytool/standard.sh > > test/sun/security/tools/keytool/standard.sh failed since 7118743 : > Alternative Hashing for String with Hash-based Maps. The test mistakenly > assumes a certain order of aliases in a keystore, stored in a Hashtable. > > From lana.steuck at oracle.com Tue Jun 5 17:47:35 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 06 Jun 2012 00:47:35 +0000 Subject: hg: jdk8/tl: Added tag jdk8-b41 for changeset 1a8c7c530f8a Message-ID: <20120606004735.E728B47717@hg.openjdk.java.net> Changeset: 1ce5dc164166 Author: cl Date: 2012-06-01 14:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/1ce5dc164166 Added tag jdk8-b41 for changeset 1a8c7c530f8a ! .hgtags From lana.steuck at oracle.com Tue Jun 5 17:47:37 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 06 Jun 2012 00:47:37 +0000 Subject: hg: jdk8/tl/corba: Added tag jdk8-b41 for changeset 113f0d5f0a08 Message-ID: <20120606004739.23F6047718@hg.openjdk.java.net> Changeset: 79cc42c9c71b Author: cl Date: 2012-06-01 14:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/79cc42c9c71b Added tag jdk8-b41 for changeset 113f0d5f0a08 ! .hgtags From lana.steuck at oracle.com Tue Jun 5 17:47:38 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 06 Jun 2012 00:47:38 +0000 Subject: hg: jdk8/tl/jaxp: Added tag jdk8-b41 for changeset 6f5c0e17415d Message-ID: <20120606004747.285DD47719@hg.openjdk.java.net> Changeset: 39ee03c16021 Author: cl Date: 2012-06-01 14:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/39ee03c16021 Added tag jdk8-b41 for changeset 6f5c0e17415d ! .hgtags From lana.steuck at oracle.com Tue Jun 5 17:47:45 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 06 Jun 2012 00:47:45 +0000 Subject: hg: jdk8/tl/jaxws: Added tag jdk8-b41 for changeset f2072b164b05 Message-ID: <20120606004748.9DC154771A@hg.openjdk.java.net> Changeset: 1f20f37818a9 Author: cl Date: 2012-06-01 14:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/1f20f37818a9 Added tag jdk8-b41 for changeset f2072b164b05 ! .hgtags From lana.steuck at oracle.com Tue Jun 5 17:47:39 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 06 Jun 2012 00:47:39 +0000 Subject: hg: jdk8/tl/langtools: 2 new changesets Message-ID: <20120606004750.11AA04771B@hg.openjdk.java.net> Changeset: 02c5a3575539 Author: cl Date: 2012-06-01 14:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/02c5a3575539 Added tag jdk8-b41 for changeset 179fa85aeefa ! .hgtags Changeset: 252f8b7473e1 Author: lana Date: 2012-06-05 17:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/252f8b7473e1 Merge From lana.steuck at oracle.com Tue Jun 5 17:47:52 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 06 Jun 2012 00:47:52 +0000 Subject: hg: jdk8/tl/hotspot: 23 new changesets Message-ID: <20120606004840.C4D914771C@hg.openjdk.java.net> Changeset: 03d61caacd1e Author: amurillo Date: 2012-05-18 14:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/03d61caacd1e 7170006: new hotspot build - hs24-b12 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 0251d217257f Author: sla Date: 2012-05-08 20:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0251d217257f 7162726: Wrong filter predicate of visible locals in SA JSJavaFrame Reviewed-by: sla, dcubed Contributed-by: Krystal Mok ! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaFrame.java Changeset: 7f410b6ea66c Author: dholmes Date: 2012-05-09 00:28 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7f410b6ea66c 7167406: (Zero) Fix for InvokeDynamic needed Reviewed-by: chrisphi, dholmes Contributed-by: Andrew Dinn ! src/cpu/zero/vm/cppInterpreter_zero.cpp Changeset: d506b2cf2ad0 Author: dholmes Date: 2012-05-09 04:32 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d506b2cf2ad0 Merge Changeset: 78d2ae5ab35b Author: nloodin Date: 2012-05-09 16:24 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/78d2ae5ab35b 7163117: Agent can't connect to process on Mac OSX Reviewed-by: dholmes, coleenp, sla, minqi, kvn ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdCDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThreadContextFactory.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerClient.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java Changeset: 037973617842 Author: kevinw Date: 2012-05-11 17:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/037973617842 7157734: hotspot test scripts not testing 64-bit JVM under JPRT/JTREG. Reviewed-by: kvn ! test/compiler/6894807/Test6894807.sh ! test/gc/6941923/test6941923.sh ! test/runtime/6626217/Test6626217.sh ! test/runtime/6878713/Test6878713.sh ! test/runtime/6929067/Test6929067.sh ! test/runtime/7020373/Test7020373.sh ! test/runtime/7051189/Xchecksig.sh ! test/runtime/7158988/TestFieldMonitor.sh Changeset: 2f4819f92dc7 Author: zgu Date: 2012-05-10 18:19 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2f4819f92dc7 Merge - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.hpp Changeset: b4f7c4315c36 Author: zgu Date: 2012-05-12 06:50 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b4f7c4315c36 Merge Changeset: 7d4e6dabc6bf Author: dcubed Date: 2012-05-15 10:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7d4e6dabc6bf 7165060: dtrace tests fail with FDS debug info files Summary: Work around 'gobjcopy --add-gnu-debuglink' failure by adding a temporary tool that adds the '.gnu_debuglink' section and nothing more. Reviewed-by: sspitsyn, acorn + make/solaris/makefiles/add_gnu_debuglink.make ! make/solaris/makefiles/vm.make + src/os/solaris/add_gnu_debuglink/add_gnu_debuglink.c Changeset: 80b9cc90b643 Author: dcubed Date: 2012-05-15 11:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/80b9cc90b643 Merge ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/vm.make Changeset: 9793f47cdebc Author: dcubed Date: 2012-05-15 15:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9793f47cdebc 7169102: 7165060 merge lost changes to make/windows/makefiles/defs.make Reviewed-by: sspitsyn, acorn ! make/windows/makefiles/defs.make Changeset: 7432b9db36ff Author: nloodin Date: 2012-05-10 15:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7432b9db36ff 7165755: OS Information much longer on linux than other platforms Reviewed-by: sla, dholmes ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp ! src/os/posix/vm/os_posix.cpp + src/os/posix/vm/os_posix.hpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.hpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.hpp ! src/share/vm/runtime/os.hpp Changeset: 198dcc84088c Author: dcubed Date: 2012-05-16 12:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/198dcc84088c 7169409: enabling ZIP_DEBUGINFO_FILES causes unexpected test failures on Windows X86 Summary: Disable ZIP_DEBUGINFO_FILES by default on Windows. Reviewed-by: acorn ! make/windows/makefiles/defs.make Changeset: 4b37c0dafe3a Author: dcubed Date: 2012-05-18 09:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4b37c0dafe3a 7170010: conditional "ZIP_DEBUGINFO_FILES ?= 0" setting is not reliable on Windows Summary: Always disable ZIP_DEBUGINFO_FILES on Windows. Reviewed-by: acorn ! make/windows/makefiles/defs.make Changeset: cee14a6fc5ac Author: zgu Date: 2012-05-22 20:29 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cee14a6fc5ac Merge Changeset: 6759698e3140 Author: roland Date: 2012-05-15 10:10 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6759698e3140 7133857: exp() and pow() should use the x87 ISA on x86 Summary: use x87 instructions to implement exp() and pow() in interpreter/c1/c2. Reviewed-by: kvn, never, twisti ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/sparc/vm/interpreter_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/c1_LinearScan_x86.cpp ! src/cpu/x86/vm/interpreter_x86_32.cpp ! src/cpu/x86/vm/interpreter_x86_64.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/c1/c1_LIRAssembler.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LinearScan.cpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/interpreter/templateInterpreter.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/subnode.cpp Changeset: 4073d9478a90 Author: roland Date: 2012-05-18 15:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4073d9478a90 7167254: Crash on OSX in Enumerator.nextElement() with compressed oops Summary: null checks in "compressed oops with base" mode may trigger a SIGBUS rather than a SIGSEGV. Reviewed-by: dsamersoff, dcubed, rbackman, kvn ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp Changeset: cdd249497b34 Author: twisti Date: 2012-05-18 12:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cdd249497b34 7170053: crash in C2 when using -XX:+CountCompiledCalls Reviewed-by: kvn, twisti Contributed-by: Krystal Mok ! src/share/vm/opto/doCall.cpp Changeset: e2961d14584b Author: roland Date: 2012-05-21 09:46 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e2961d14584b 7169934: pow(x,y) or x64 computes incorrect result when x<0 and y is an odd integer Summary: bad test for parity of y in pow(x,y) (c1, interpreter) Reviewed-by: kvn, twisti ! src/cpu/x86/vm/assembler_x86.cpp Changeset: 7089278210e2 Author: kvn Date: 2012-05-24 18:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7089278210e2 Merge Changeset: 785573170238 Author: amurillo Date: 2012-05-25 14:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/785573170238 Merge Changeset: 37add4fa0296 Author: amurillo Date: 2012-05-25 14:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/37add4fa0296 Added tag hs24-b12 for changeset 785573170238 ! .hgtags Changeset: 2040997cba56 Author: cl Date: 2012-06-01 14:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2040997cba56 Added tag jdk8-b41 for changeset 37add4fa0296 ! .hgtags From lana.steuck at oracle.com Tue Jun 5 17:47:50 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 06 Jun 2012 00:47:50 +0000 Subject: hg: jdk8/tl/jdk: 5 new changesets Message-ID: <20120606004848.2D3E44771D@hg.openjdk.java.net> Changeset: edb02bee325e Author: ihse Date: 2012-05-25 18:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/edb02bee325e 7172014: Remove empty and unused javah include files Reviewed-by: ohair, erikj ! src/share/native/sun/awt/image/cvutils/img_dcm.h ! src/share/native/sun/awt/image/cvutils/img_dcm8.h ! src/share/native/sun/java2d/pipe/SpanClipRenderer.c ! src/solaris/native/sun/awt/initIDs.c Changeset: 8b4dd321b8a2 Author: dholmes Date: 2012-05-30 00:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8b4dd321b8a2 7171653: 32-bit cross-compile on 64-bit build host generates 64-bit data for awt/X11 leading to crash Reviewed-by: ohair, anthony ! make/sun/xawt/Makefile ! makefiles/sun/xawt/Makefile Changeset: 4eac56f073ea Author: katleman Date: 2012-05-30 15:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4eac56f073ea Merge Changeset: cf5c1f6fbc5b Author: cl Date: 2012-06-01 14:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf5c1f6fbc5b Added tag jdk8-b41 for changeset 4eac56f073ea ! .hgtags Changeset: 91d05db156d3 Author: lana Date: 2012-06-05 17:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/91d05db156d3 Merge From luchsh at linux.vnet.ibm.com Tue Jun 5 19:03:07 2012 From: luchsh at linux.vnet.ibm.com (Jonathan Lu) Date: Wed, 06 Jun 2012 10:03:07 +0800 Subject: Code review request for 7172149 ArrayIndexOutOfBoundsException from Signature.verify In-Reply-To: <4FCD8877.6060901@oracle.com> References: <4FC46447.5080802@linux.vnet.ibm.com> <4FC47083.40004@oracle.com> <4FC47699.8090302@linux.vnet.ibm.com> <4FC55B3F.2010306@oracle.com> <4FC86062.2050804@linux.vnet.ibm.com> <4FCD5840.4050400@oracle.com> <4FCD8877.6060901@oracle.com> Message-ID: <4FCEBA5B.3040405@linux.vnet.ibm.com> Hi Xuelei, On 06/05/2012 12:17 PM, Xuelei Fan wrote: > Hi Jonathan, > > The fix, including the copyright notice, looks good to us. Are you a > committer of OpenJDK? Otherwise, I would like to help to integrate the I'm not. > fix into OpenJDK. Please help me to integrate the fix into OpenJDK. Thanks! - Jonathan > > Thanks, > Xuelei > > On 6/5/2012 8:52 AM, Brad Wetmore wrote: >> Looks good to me, however, we are still checking on the copyright notice >> in the test. I think what you have is ok, but want to run it by one >> other person. Hope to hear back soon. >> >> The bug presents an interesting and obvious problem when you think of >> it. Wonder how many things we have like that elsewhere. Another thing >> to keep in the back on my mind for future codereviews. >> >> Thanks, >> >> Brad >> >> >> >> On 5/31/2012 11:25 PM, Jonathan Lu wrote: >>> Hello Xuelei, >>> >>> What do you think of the updated patch? any comments? >>> http://cr.openjdk.java.net/~luchsh/7172149_2/ >>> >>> Thanks >>> - Jonathan >>> >>> On 05/30/2012 07:26 AM, Xuelei Fan wrote: >>>> On 5/29/2012 3:11 PM, Jonathan Lu wrote: >>>>> Hi Xuelei, >>>>> >>>>> Thanks for review! >>>>> >>>>> On 05/29/2012 02:45 PM, Xuelei Fan wrote: >>>>>> That's an interesting topic. From my understand, the length of an >>>>>> array >>>>>> is of type "int". So normally, the (offset + length) should not be >>>>>> great than integer.max_value. Of course, Hostile or improper code are >>>>>> not of the case. >>>>>> >>>>>> What's interesting to me is that may be when we do additive operation >>>>>> for two "int" values, we may have to convert it to "long" in case of >>>>>> any >>>>>> overflow strictly. We are luck here because we have "long" type. But >>>>>> what about the additive operation for two "long" values >>>>> I think this issue is special, since it is about index value of Java >>>>> arrays, which is limited to smaller than Integer.MAX_VALUE according to >>>>> Java language specification, not other general conditions of comparing >>>>> integer or long values. >>>>> >>>>>> Jonathan, do you run into the problem in real world? >>>>> For now I am not quiet sure of whether it is from a real world problem, >>>>> but this problem does exhibit some weakness or behavior differences, >>>>> right? >>>>> >>>> Yes, it is an improvement. Would you please add a comment about why >>>> convert it to "long", and update the copyright year to 2012? Otherwise, >>>> looks fine to me for JDK 8. >>>> >>>> Thanks& Regards, >>>> Xuelei >>>> >>>>> Thanks& regards >>>>> -Jonathan >>>>> >>>>>> Thanks& Regards, >>>>>> Xuelei >>>>>> >>>>>> On 5/29/2012 1:53 PM, Jonathan Lu wrote: >>>>>>> Hi Security-dev, >>>>>>> >>>>>>> Here's a patch for bug7172149, could anybody please help to take a >>>>>>> look? >>>>>>> http://cr.openjdk.java.net/~luchsh/7172149/ >>>>>>> >>>>>>> The problem is that the range check in Signature.verify(byte[], int, >>>>>>> int) uses integer value to check whether (offset + length) is greater >>>>>>> than signature.length, but if (offset + length) overflows the check >>>>>>> will >>>>>>> fail and ArrayIndexOutOfBoundsException will be thrown instead of >>>>>>> IllegalArgumentException.My proposed solution is to make a conversion >>>>>>> to long in the if block. >>>>>>> >>>>>>> Thanks! >>>>>>> - Jonathan >>>>>>> From weijun.wang at oracle.com Tue Jun 5 19:06:24 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 06 Jun 2012 02:06:24 +0000 Subject: hg: jdk8/tl/jdk: 7174351: test/sun/security/tools/keytool/standard.sh failed after new Hashtable Message-ID: <20120606020635.35E2A4772F@hg.openjdk.java.net> Changeset: b6eb10d6932f Author: weijun Date: 2012-06-06 10:05 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b6eb10d6932f 7174351: test/sun/security/tools/keytool/standard.sh failed after new Hashtable Reviewed-by: xuelei ! test/sun/security/tools/keytool/KeyToolTest.java From xuelei.fan at oracle.com Wed Jun 6 05:27:10 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 06 Jun 2012 20:27:10 +0800 Subject: Code review request, CR 7174244, NPE in Krb5ProxyImpl.getServerKeys() Message-ID: <4FCF4C9E.8080401@oracle.com> Hi Weijun, Would you please review the fix for CR 7174244. http://cr.openjdk.java.net./~xuelei/7174244/webrev.00/ There are mainly two updates in the fix. One is to have Krb5ProxyImpl.getServerKeys() to check null return value of Krb5Util.getServiceCreds(). The other one is to have cipher suite order to be independent from HashMap implementation. TreeSet is used to replace ArrayList so that the cipher suites order are sorted automatically. Thanks, Xuelei From weijun.wang at oracle.com Wed Jun 6 06:11:49 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 06 Jun 2012 21:11:49 +0800 Subject: Code review request, CR 7174244, NPE in Krb5ProxyImpl.getServerKeys() In-Reply-To: <4FCF4C9E.8080401@oracle.com> References: <4FCF4C9E.8080401@oracle.com> Message-ID: <4FCF5715.2010206@oracle.com> Hi Xuelei I don't quite understand the bug report. Certainly it's good to prevent that NPE, but why must the cipher suites be ordered? It seems it's not ordered before the new HashMap. Is this a regression or an RFE? You'd better add some explanation in the bug report. Thanks Max On 06/06/2012 08:27 PM, Xuelei Fan wrote: > Hi Weijun, > > Would you please review the fix for CR 7174244. > http://cr.openjdk.java.net./~xuelei/7174244/webrev.00/ > > There are mainly two updates in the fix. One is to have > Krb5ProxyImpl.getServerKeys() to check null return value of > Krb5Util.getServiceCreds(). The other one is to have cipher suite order > to be independent from HashMap implementation. TreeSet is used to > replace ArrayList so that the cipher suites order are sorted automatically. > > Thanks, > Xuelei From xuelei.fan at oracle.com Wed Jun 6 06:22:07 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 06 Jun 2012 21:22:07 +0800 Subject: Code review request, CR 7174244, NPE in Krb5ProxyImpl.getServerKeys() In-Reply-To: <4FCF5715.2010206@oracle.com> References: <4FCF4C9E.8080401@oracle.com> <4FCF5715.2010206@oracle.com> Message-ID: <4FCF597F.8050307@oracle.com> On 6/6/2012 9:11 PM, Weijun Wang wrote: > Hi Xuelei > > I don't quite understand the bug report. Certainly it's good to prevent > that NPE, but why must the cipher suites be ordered? It seems it's not > ordered before the new HashMap. No, it was not ordered because of a regression. > Is this a regression or an RFE? It's a regression. We used to use TreeSet to sort the cipher suites. But later it is miss-updated to use ArrayList rather then TreeSet in a bug fix. Then the order was lost. We need to sort the cipher suites because the order is the preference when TLS handshaking selects a proper cipher suite. Please refer to TLS specification about the order, page 41, RFC5246: cipher_suites This is a list of the cryptographic options supported by the client, with the client's first preference first. > You'd > better add some explanation in the bug report. > I will. Thanks, Xuelei > Thanks > Max > > On 06/06/2012 08:27 PM, Xuelei Fan wrote: >> Hi Weijun, >> >> Would you please review the fix for CR 7174244. >> http://cr.openjdk.java.net./~xuelei/7174244/webrev.00/ >> >> There are mainly two updates in the fix. One is to have >> Krb5ProxyImpl.getServerKeys() to check null return value of >> Krb5Util.getServiceCreds(). The other one is to have cipher suite order >> to be independent from HashMap implementation. TreeSet is used to >> replace ArrayList so that the cipher suites order are sorted >> automatically. >> >> Thanks, >> Xuelei From weijun.wang at oracle.com Wed Jun 6 06:34:55 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 06 Jun 2012 21:34:55 +0800 Subject: Code review request, CR 7174244, NPE in Krb5ProxyImpl.getServerKeys() In-Reply-To: <4FCF597F.8050307@oracle.com> References: <4FCF4C9E.8080401@oracle.com> <4FCF5715.2010206@oracle.com> <4FCF597F.8050307@oracle.com> Message-ID: <4FCF5C7F.5070607@oracle.com> Then the fix is fine. Please add the CR that causes this regression to the see also field. -Max On 06/06/2012 09:22 PM, Xuelei Fan wrote: > On 6/6/2012 9:11 PM, Weijun Wang wrote: >> Hi Xuelei >> >> I don't quite understand the bug report. Certainly it's good to prevent >> that NPE, but why must the cipher suites be ordered? It seems it's not >> ordered before the new HashMap. > No, it was not ordered because of a regression. > >> Is this a regression or an RFE? > It's a regression. We used to use TreeSet to sort the cipher suites. But > later it is miss-updated to use ArrayList rather then TreeSet in a bug > fix. Then the order was lost. > > We need to sort the cipher suites because the order is the preference > when TLS handshaking selects a proper cipher suite. Please refer to TLS > specification about the order, page 41, RFC5246: > > cipher_suites > This is a list of the cryptographic options supported by the > client, with the client's first preference first. > >> You'd >> better add some explanation in the bug report. >> > I will. > > Thanks, > Xuelei > >> Thanks >> Max >> >> On 06/06/2012 08:27 PM, Xuelei Fan wrote: >>> Hi Weijun, >>> >>> Would you please review the fix for CR 7174244. >>> http://cr.openjdk.java.net./~xuelei/7174244/webrev.00/ >>> >>> There are mainly two updates in the fix. One is to have >>> Krb5ProxyImpl.getServerKeys() to check null return value of >>> Krb5Util.getServiceCreds(). The other one is to have cipher suite order >>> to be independent from HashMap implementation. TreeSet is used to >>> replace ArrayList so that the cipher suites order are sorted >>> automatically. >>> >>> Thanks, >>> Xuelei > From alan.bateman at oracle.com Wed Jun 6 10:02:14 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 06 Jun 2012 17:02:14 +0000 Subject: hg: jdk8/tl/jdk: 7172826: (se) Selector based on the Solaris event port mechanism Message-ID: <20120606170234.9E65A4774E@hg.openjdk.java.net> Changeset: 119c9a306a3d Author: alanb Date: 2012-06-06 17:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/119c9a306a3d 7172826: (se) Selector based on the Solaris event port mechanism Reviewed-by: coffeys, chegar ! make/java/nio/Makefile ! make/java/nio/mapfile-linux ! make/java/nio/mapfile-solaris ! src/share/classes/sun/nio/ch/IOUtil.java ! src/solaris/classes/sun/nio/ch/DevPollArrayWrapper.java ! src/solaris/classes/sun/nio/ch/EPollArrayWrapper.java + src/solaris/classes/sun/nio/ch/EventPortSelectorImpl.java + src/solaris/classes/sun/nio/ch/EventPortSelectorProvider.java + src/solaris/classes/sun/nio/ch/EventPortWrapper.java ! src/solaris/classes/sun/nio/ch/SolarisEventPort.java ! src/solaris/native/sun/nio/ch/DevPollArrayWrapper.c ! src/solaris/native/sun/nio/ch/EPollArrayWrapper.c ! src/solaris/native/sun/nio/ch/IOUtil.c ! src/solaris/native/sun/nio/ch/SolarisEventPort.c ! test/java/nio/channels/Selector/lots_of_updates.sh ! test/java/nio/channels/SocketChannel/Open.sh ! test/sun/nio/ch/SelProvider.java From kurchi.subhra.hazra at oracle.com Wed Jun 6 11:37:53 2012 From: kurchi.subhra.hazra at oracle.com (kurchi.subhra.hazra at oracle.com) Date: Wed, 06 Jun 2012 18:37:53 +0000 Subject: hg: jdk8/tl/jdk: 7173645: (props) System.getProperty("os.name") should return "Windows Server 2012" for Windows Server 2012 Message-ID: <20120606183809.8E28647757@hg.openjdk.java.net> Changeset: af313ded4ffb Author: khazra Date: 2012-06-06 11:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af313ded4ffb 7173645: (props) System.getProperty("os.name") should return "Windows Server 2012" for Windows Server 2012 Summary: Enable Windows Server 2012 to be recognized as "os.name" Reviewed-by: alanb, dholmes, chegar ! src/windows/native/java/lang/java_props_md.c From rich.midwinter at gmail.com Wed Jun 6 12:42:30 2012 From: rich.midwinter at gmail.com (Rich Midwinter) Date: Wed, 6 Jun 2012 20:42:30 +0100 Subject: Adding an adaptive hashing algorithm to the JDK Message-ID: Hi I'd like to see a bcrypt implementation added to the JDK and would like to write the code required too. Does this sound like a feasible task, are there any reasons it would be dead in the water before I've even opened an editor? Thanks Rich -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20120606/85af3d6a/attachment.html From weijun.wang at oracle.com Wed Jun 6 17:55:35 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 07 Jun 2012 08:55:35 +0800 Subject: Avoid PrincipalName with realm == null Message-ID: <4FCFFC07.2090605@oracle.com> Hi Valerie The krb5 PrincipalName class has a realm field and the class says If null, means the default realm Ideally this means if the realm of a name is null then this field can be null. Otherwise, it must be filled when created. In fact, inside our codes, the field is often filled (using setRealm()) after it's created. This leads to several strange coding styles that make the codes confusing and error-prone. 1. a lot of setRealm() calls that's far from the creation of the principal name only when the field needs to be used 2. a lot of if (realm == null) checks 3. a lot of "unresolved" names that never has a realm but is definitely not in the default realm (just because the realm field is not used inside JDK) I am planning to fix this to make the PrincipalName immutable and always with a non-null non-empty realm. I also plan to make Realm immutable and remove the ServiceName class (it's quite useless). A brief look into the code and protocol suggests this is quite feasible. In every krb5 message and serialized data (I mean ccache and keytab) defined, there is always a realm beside name. This is also true for most Java methods. And I don't think a name with an "unresolved" realm should exists at all. If we have to deal with something like this, I'd rather invent a new class for it. The code change will be mostly refactoring, removing a lot of realm arguments/fields and merging it into name. One behavior change is that there will be no name with "unresolved" realm anymore, but I think this should never be true in a real production environment. In fact, the public API KerberosPrincipal has * @throws IllegalArgumentException if name is improperly * formatted, if name is null, or if name does not contain * the realm to use and the default realm is not specified * in either a Kerberos configuration file or via the * java.security.krb5.realm system property. What's your suggestion? I've been haunted by this several times, mostly because a setRealm() is not called. Thanks Max From weijun.wang at oracle.com Wed Jun 6 17:56:33 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 07 Jun 2012 08:56:33 +0800 Subject: Avoid PrincipalName with realm == null In-Reply-To: <4FCFFC07.2090605@oracle.com> References: <4FCFFC07.2090605@oracle.com> Message-ID: <4FCFFC41.4060609@oracle.com> > > Ideally this means if the realm of a name is null then this field can be > null. Otherwise, it must be filled when created. > Should be "if the realm of a name is the default realm". From xuelei.fan at oracle.com Wed Jun 6 18:19:55 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Thu, 07 Jun 2012 01:19:55 +0000 Subject: hg: jdk8/tl/jdk: 7174244: NPE in Krb5ProxyImpl.getServerKeys() Message-ID: <20120607012013.E527D47769@hg.openjdk.java.net> Changeset: f8e72d7ff37d Author: xuelei Date: 2012-06-06 18:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8e72d7ff37d 7174244: NPE in Krb5ProxyImpl.getServerKeys() Reviewed-by: weijun ! src/share/classes/sun/security/ssl/SSLContextImpl.java ! src/share/classes/sun/security/ssl/ServerHandshaker.java ! src/share/classes/sun/security/ssl/krb5/Krb5ProxyImpl.java + test/sun/security/ssl/sanity/ciphersuites/CipherSuitesInOrder.java From xuelei.fan at oracle.com Wed Jun 6 18:39:58 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Thu, 07 Jun 2012 01:39:58 +0000 Subject: hg: jdk8/tl/jdk: 7172149: ArrayIndexOutOfBoundsException from Signature.verify Message-ID: <20120607014008.2343D4776D@hg.openjdk.java.net> Changeset: 713b10821c3d Author: xuelei Date: 2012-06-06 18:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/713b10821c3d 7172149: ArrayIndexOutOfBoundsException from Signature.verify Summary: take care of integer addition overflow Reviewed-by: xuelei, wetmore Contributed-by: Jonathan Lu ! src/share/classes/java/security/Signature.java + test/java/security/Signature/VerifyRangeCheckOverflow.java From daniel.daugherty at oracle.com Wed Jun 6 19:12:29 2012 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Thu, 07 Jun 2012 02:12:29 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20120607021250.60BF84776F@hg.openjdk.java.net> Changeset: 181175887d24 Author: jonas Date: 2012-06-06 13:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/181175887d24 7174861: all/OPT jdk build on Solaris with FDS enabled sets wrong options Summary: Use CFLAGS_COMMON instead of CC_OPT and CXXFLAGS_COMMON instead of CXX_OPT for setting FDS options. FDS should also set OPTIMIZATION_LEVEL. Reviewed-by: ihse, dholmes, ohair, dcubed ! make/common/Defs-solaris.gmk Changeset: 7543b6db3026 Author: dcubed Date: 2012-06-06 19:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7543b6db3026 Merge From alan.bateman at oracle.com Thu Jun 7 02:33:50 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 07 Jun 2012 09:33:50 +0000 Subject: hg: jdk8/tl/jdk: 7175011: ProblemList.txt updates (6/2012) Message-ID: <20120607093429.CEFF847779@hg.openjdk.java.net> Changeset: 636f9486fde7 Author: alanb Date: 2012-06-07 10:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/636f9486fde7 7175011: ProblemList.txt updates (6/2012) Reviewed-by: mduigou, chegar ! test/ProblemList.txt From alan.bateman at oracle.com Thu Jun 7 04:32:45 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 07 Jun 2012 11:32:45 +0000 Subject: hg: jdk8/tl/jdk: 7164256: EnumMap clone doesn't clear the entrySet keeping a reference to the original Map Message-ID: <20120607113304.B3A8347781@hg.openjdk.java.net> Changeset: 757a5129fad7 Author: alanb Date: 2012-06-07 12:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/757a5129fad7 7164256: EnumMap clone doesn't clear the entrySet keeping a reference to the original Map Reviewed-by: alanb, chegar, forax, mduigou Contributed-by: dbelfer at gmail.com ! src/share/classes/java/util/EnumMap.java + test/java/util/EnumMap/ProperEntrySetOnClone.java From weijun.wang at oracle.com Thu Jun 7 04:37:25 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 07 Jun 2012 19:37:25 +0800 Subject: Code review request: 7175041: HttpTimestamper should accept https URI In-Reply-To: <31383767.1339066871550.JavaMail.sbladm@swsblss4-new.central.sun.com> References: <31383767.1339066871550.JavaMail.sbladm@swsblss4-new.central.sun.com> Message-ID: <4FD09275.4050006@oracle.com> Hi All Please take a review at this http://cr.openjdk.java.net/~weijun/7175041/webrev.00/ The original check is added [1] in JDK 8 so there is no need for a backport. I also do not intend to introduce the updated check to JDK 7 or earlier. Noreg-trivial. Thanks Max [1] http://hg.openjdk.java.net/jdk8/tl/jdk/diff/57eb9136b73b/src/share/classes/sun/security/timestamp/HttpTimestamper.java -------- Original Message -------- 7175041: HttpTimestamper should accept https URI Product: java Category: java Subcategory: classes_security Type: Defect === *Description* ============================================================ sun.security.timestamp.HttpTimestamper has: public HttpTimestamper(URI tsaURI) { if (!tsaURI.getScheme().equalsIgnoreCase("http")) throw new IllegalArgumentException("TSA must be an HTTP URI"); this.tsaURI = tsaURI; } It should also support TSA with a https URI. From nils.loodin at oracle.com Thu Jun 7 06:42:41 2012 From: nils.loodin at oracle.com (nils.loodin at oracle.com) Date: Thu, 07 Jun 2012 13:42:41 +0000 Subject: hg: jdk8/tl/jdk: 7163471: Licensee source bundle failed around 7u4 Message-ID: <20120607134251.711684778D@hg.openjdk.java.net> Changeset: c89018e3f3b6 Author: nloodin Date: 2012-06-05 13:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c89018e3f3b6 7163471: Licensee source bundle failed around 7u4 Reviewed-by: dholmes, sla, brutisso, erikj ! make/com/oracle/Makefile From sean.mullan at oracle.com Thu Jun 7 07:14:47 2012 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 07 Jun 2012 10:14:47 -0400 Subject: Code review request: 7175041: HttpTimestamper should accept https URI In-Reply-To: <4FD09275.4050006@oracle.com> References: <31383767.1339066871550.JavaMail.sbladm@swsblss4-new.central.sun.com> <4FD09275.4050006@oracle.com> Message-ID: <4FD0B757.8010007@oracle.com> Looks good to me. --Sean On 06/07/2012 07:37 AM, Weijun Wang wrote: > Hi All > > Please take a review at this > > http://cr.openjdk.java.net/~weijun/7175041/webrev.00/ > > The original check is added [1] in JDK 8 so there is no need for a > backport. I also do not intend to introduce the updated check to JDK 7 > or earlier. > > Noreg-trivial. > > Thanks > Max > > [1] > http://hg.openjdk.java.net/jdk8/tl/jdk/diff/57eb9136b73b/src/share/classes/sun/security/timestamp/HttpTimestamper.java > > > -------- Original Message -------- > 7175041: HttpTimestamper should accept https URI > > Product: java > Category: java > Subcategory: classes_security > Type: Defect > > > === *Description* > ============================================================ > sun.security.timestamp.HttpTimestamper has: > > public HttpTimestamper(URI tsaURI) { > if (!tsaURI.getScheme().equalsIgnoreCase("http")) > throw new IllegalArgumentException("TSA must be an HTTP URI"); > this.tsaURI = tsaURI; > } > > It should also support TSA with a https URI. > From weijun.wang at oracle.com Thu Jun 7 07:34:17 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Thu, 07 Jun 2012 14:34:17 +0000 Subject: hg: jdk8/tl/jdk: 7175041: HttpTimestamper should accept https URI Message-ID: <20120607143428.E6F0947794@hg.openjdk.java.net> Changeset: 9b814b887240 Author: weijun Date: 2012-06-07 22:33 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9b814b887240 7175041: HttpTimestamper should accept https URI Reviewed-by: mullan ! src/share/classes/sun/security/timestamp/HttpTimestamper.java From alan.bateman at oracle.com Thu Jun 7 10:43:04 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 07 Jun 2012 17:43:04 +0000 Subject: hg: jdk8/tl/jdk: 7174723: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing [win] Message-ID: <20120607174323.6635E477A2@hg.openjdk.java.net> Changeset: 23f8be788c77 Author: alanb Date: 2012-06-07 18:42 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23f8be788c77 7174723: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing [win] Reviewed-by: mduigou ! test/java/lang/ProcessBuilder/Basic.java From hbhotz at oxy.edu Thu Jun 7 11:39:28 2012 From: hbhotz at oxy.edu (Henry B. Hotz) Date: Thu, 7 Jun 2012 11:39:28 -0700 Subject: Avoid PrincipalName with realm == null In-Reply-To: <4FCFFC07.2090605@oracle.com> References: <4FCFFC07.2090605@oracle.com> Message-ID: Doesn't this interact with the new anonymity standards? On Jun 6, 2012, at 5:55 PM, Weijun Wang wrote: > Hi Valerie > > The krb5 PrincipalName class has a realm field and the class says > > If null, means the default realm > > Ideally this means if the realm of a name is null then this field can be null. Otherwise, it must be filled when created. > > In fact, inside our codes, the field is often filled (using setRealm()) after it's created. This leads to several strange coding styles that make the codes confusing and error-prone. > > 1. a lot of setRealm() calls that's far from the creation of the principal name only when the field needs to be used > 2. a lot of if (realm == null) checks > 3. a lot of "unresolved" names that never has a realm but is definitely not in the default realm (just because the realm field is not used inside JDK) > > I am planning to fix this to make the PrincipalName immutable and always with a non-null non-empty realm. I also plan to make Realm immutable and remove the ServiceName class (it's quite useless). > > A brief look into the code and protocol suggests this is quite feasible. In every krb5 message and serialized data (I mean ccache and keytab) defined, there is always a realm beside name. This is also true for most Java methods. And I don't think a name with an "unresolved" realm should exists at all. If we have to deal with something like this, I'd rather invent a new class for it. > > The code change will be mostly refactoring, removing a lot of realm arguments/fields and merging it into name. One behavior change is that there will be no name with "unresolved" realm anymore, but I think this should never be true in a real production environment. In fact, the public API KerberosPrincipal has > > * @throws IllegalArgumentException if name is improperly > * formatted, if name is null, or if name does not contain > * the realm to use and the default realm is not specified > * in either a Kerberos configuration file or via the > * java.security.krb5.realm system property. > > What's your suggestion? I've been haunted by this several times, mostly because a setRealm() is not called. > > Thanks > Max From mike.duigou at oracle.com Thu Jun 7 11:40:15 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 07 Jun 2012 18:40:15 +0000 Subject: hg: jdk8/tl/jdk: 7174736: JCK test api/java_util/HashMap/index_EntrySet failing Message-ID: <20120607184025.AF352477AD@hg.openjdk.java.net> Changeset: fc0e508b713f Author: mduigou Date: 2012-06-07 01:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc0e508b713f 7174736: JCK test api/java_util/HashMap/index_EntrySet failing Summary: Corrects a problem with HashMap.removeEntry() that caused a JCK test to fail Reviewed-by: mduigou Contributed-by: alan.bateman at oracle.com ! src/share/classes/java/util/HashMap.java From huizhe.wang at oracle.com Thu Jun 7 14:10:03 2012 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Thu, 07 Jun 2012 21:10:03 +0000 Subject: hg: jdk8/tl/jaxp: 7151118: Regressions on 7u4 b11 comp. 7u4 b06 on specjvm2008.xml.transform subbenchmark Message-ID: <20120607211007.E1A99477BA@hg.openjdk.java.net> Changeset: 633700642caf Author: joehw Date: 2012-06-07 13:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/633700642caf 7151118: Regressions on 7u4 b11 comp. 7u4 b06 on specjvm2008.xml.transform subbenchmark Summary: roll back XalanJ-2271 that caused the regression Reviewed-by: lancea ! src/com/sun/org/apache/xml/internal/serializer/CharInfo.java ! src/com/sun/org/apache/xml/internal/serializer/ToHTMLStream.java ! src/com/sun/org/apache/xml/internal/serializer/ToStream.java ! src/com/sun/org/apache/xml/internal/serializer/ToXMLStream.java From weijun.wang at oracle.com Thu Jun 7 19:53:14 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 08 Jun 2012 10:53:14 +0800 Subject: Avoid PrincipalName with realm == null In-Reply-To: References: <4FCFFC07.2090605@oracle.com> Message-ID: <4FD1691A.8030305@oracle.com> Hi Henry We haven't supported the anonymous feature in Java yet. Anyway, if I read RFC6111/6112 correctly, an anonymous principal name uses well-known values in its nameStrings and nameRealm fields, so they are still neither null nor empty. This does not conflict with my proposal. Also, it seems the KDC (or a service) recognizes the client being anonymous mainly by looking at the KDCOptions or TicketFlags, not the name itself. If we want to support anonymous in Java's kerberos, we can make use of the current requestAnonymity/getAnonymityState methods. The getSrcName method will also return a GSSName whose isAnonymous() might return true. The PrincipalName here is a sun.security.* internal class. Thanks Max On 06/08/2012 02:39 AM, Henry B. Hotz wrote: > Doesn't this interact with the new anonymity standards? > > On Jun 6, 2012, at 5:55 PM, Weijun Wang wrote: > >> Hi Valerie >> >> The krb5 PrincipalName class has a realm field and the class says >> >> If null, means the default realm >> >> Ideally this means if the realm of a name is null then this field can be null. Otherwise, it must be filled when created. >> >> In fact, inside our codes, the field is often filled (using setRealm()) after it's created. This leads to several strange coding styles that make the codes confusing and error-prone. >> >> 1. a lot of setRealm() calls that's far from the creation of the principal name only when the field needs to be used >> 2. a lot of if (realm == null) checks >> 3. a lot of "unresolved" names that never has a realm but is definitely not in the default realm (just because the realm field is not used inside JDK) >> >> I am planning to fix this to make the PrincipalName immutable and always with a non-null non-empty realm. I also plan to make Realm immutable and remove the ServiceName class (it's quite useless). >> >> A brief look into the code and protocol suggests this is quite feasible. In every krb5 message and serialized data (I mean ccache and keytab) defined, there is always a realm beside name. This is also true for most Java methods. And I don't think a name with an "unresolved" realm should exists at all. If we have to deal with something like this, I'd rather invent a new class for it. >> >> The code change will be mostly refactoring, removing a lot of realm arguments/fields and merging it into name. One behavior change is that there will be no name with "unresolved" realm anymore, but I think this should never be true in a real production environment. In fact, the public API KerberosPrincipal has >> >> * @throws IllegalArgumentException if name is improperly >> * formatted, if name is null, or if name does not contain >> * the realm to use and the default realm is not specified >> * in either a Kerberos configuration file or via the >> * java.security.krb5.realm system property. >> >> What's your suggestion? I've been haunted by this several times, mostly because a setRealm() is not called. >> >> Thanks >> Max > From hbhotz at oxy.edu Thu Jun 7 23:09:20 2012 From: hbhotz at oxy.edu (Henry B. Hotz) Date: Thu, 7 Jun 2012 23:09:20 -0700 Subject: Avoid PrincipalName with realm == null In-Reply-To: <4FD1691A.8030305@oracle.com> References: <4FCFFC07.2090605@oracle.com> <4FD1691A.8030305@oracle.com> Message-ID: <9B778713-E821-414D-A38F-BEF32598B5D9@oxy.edu> Thanks for checking. I was remembering some early discussion of possibilities that obviously didn't make it to the final version. I'm also wrestling with an oddball application that stores some data in the ccache with a principal name without a realm. The data isn't a ticket though, so that's really completely off the reservation. ;-) On Jun 7, 2012, at 7:53 PM, Weijun Wang wrote: > Hi Henry > > We haven't supported the anonymous feature in Java yet. > > Anyway, if I read RFC6111/6112 correctly, an anonymous principal name uses well-known values in its nameStrings and nameRealm fields, so they are still neither null nor empty. This does not conflict with my proposal. Also, it seems the KDC (or a service) recognizes the client being anonymous mainly by looking at the KDCOptions or TicketFlags, not the name itself. > > If we want to support anonymous in Java's kerberos, we can make use of the current requestAnonymity/getAnonymityState methods. The getSrcName method will also return a GSSName whose isAnonymous() might return true. The PrincipalName here is a sun.security.* internal class. > > Thanks > Max > > > On 06/08/2012 02:39 AM, Henry B. Hotz wrote: >> Doesn't this interact with the new anonymity standards? >> >> On Jun 6, 2012, at 5:55 PM, Weijun Wang wrote: >> >>> Hi Valerie >>> >>> The krb5 PrincipalName class has a realm field and the class says >>> >>> If null, means the default realm >>> >>> Ideally this means if the realm of a name is null then this field can be null. Otherwise, it must be filled when created. >>> >>> In fact, inside our codes, the field is often filled (using setRealm()) after it's created. This leads to several strange coding styles that make the codes confusing and error-prone. >>> >>> 1. a lot of setRealm() calls that's far from the creation of the principal name only when the field needs to be used >>> 2. a lot of if (realm == null) checks >>> 3. a lot of "unresolved" names that never has a realm but is definitely not in the default realm (just because the realm field is not used inside JDK) >>> >>> I am planning to fix this to make the PrincipalName immutable and always with a non-null non-empty realm. I also plan to make Realm immutable and remove the ServiceName class (it's quite useless). >>> >>> A brief look into the code and protocol suggests this is quite feasible. In every krb5 message and serialized data (I mean ccache and keytab) defined, there is always a realm beside name. This is also true for most Java methods. And I don't think a name with an "unresolved" realm should exists at all. If we have to deal with something like this, I'd rather invent a new class for it. >>> >>> The code change will be mostly refactoring, removing a lot of realm arguments/fields and merging it into name. One behavior change is that there will be no name with "unresolved" realm anymore, but I think this should never be true in a real production environment. In fact, the public API KerberosPrincipal has >>> >>> * @throws IllegalArgumentException if name is improperly >>> * formatted, if name is null, or if name does not contain >>> * the realm to use and the default realm is not specified >>> * in either a Kerberos configuration file or via the >>> * java.security.krb5.realm system property. >>> >>> What's your suggestion? I've been haunted by this several times, mostly because a setRealm() is not called. >>> >>> Thanks >>> Max >> From weijun.wang at oracle.com Thu Jun 7 23:37:44 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 08 Jun 2012 14:37:44 +0800 Subject: Avoid PrincipalName with realm == null In-Reply-To: <9B778713-E821-414D-A38F-BEF32598B5D9@oxy.edu> References: <4FCFFC07.2090605@oracle.com> <4FD1691A.8030305@oracle.com> <9B778713-E821-414D-A38F-BEF32598B5D9@oxy.edu> Message-ID: <4FD19DB8.90608@oracle.com> On 06/08/2012 02:09 PM, Henry B. Hotz wrote: > Thanks for checking. I was remembering some early discussion of possibilities that obviously didn't make it to the final version. > > I'm also wrestling with an oddball application that stores some data in the ccache with a principal name without a realm. The data isn't a ticket though, so that's really completely off the reservation. ;-) I've met something similar, at the realm field is a string "X-CACHECONF:". We have to skip that entry. In fact, how can one tell if a principal inside a ccache has or hasn't a realm? It's just an array of strings there. Who knows if the first one is for realm or the first component? -Max > > On Jun 7, 2012, at 7:53 PM, Weijun Wang wrote: > >> Hi Henry >> >> We haven't supported the anonymous feature in Java yet. >> >> Anyway, if I read RFC6111/6112 correctly, an anonymous principal name uses well-known values in its nameStrings and nameRealm fields, so they are still neither null nor empty. This does not conflict with my proposal. Also, it seems the KDC (or a service) recognizes the client being anonymous mainly by looking at the KDCOptions or TicketFlags, not the name itself. >> >> If we want to support anonymous in Java's kerberos, we can make use of the current requestAnonymity/getAnonymityState methods. The getSrcName method will also return a GSSName whose isAnonymous() might return true. The PrincipalName here is a sun.security.* internal class. >> >> Thanks >> Max >> >> >> On 06/08/2012 02:39 AM, Henry B. Hotz wrote: >>> Doesn't this interact with the new anonymity standards? >>> >>> On Jun 6, 2012, at 5:55 PM, Weijun Wang wrote: >>> >>>> Hi Valerie >>>> >>>> The krb5 PrincipalName class has a realm field and the class says >>>> >>>> If null, means the default realm >>>> >>>> Ideally this means if the realm of a name is null then this field can be null. Otherwise, it must be filled when created. >>>> >>>> In fact, inside our codes, the field is often filled (using setRealm()) after it's created. This leads to several strange coding styles that make the codes confusing and error-prone. >>>> >>>> 1. a lot of setRealm() calls that's far from the creation of the principal name only when the field needs to be used >>>> 2. a lot of if (realm == null) checks >>>> 3. a lot of "unresolved" names that never has a realm but is definitely not in the default realm (just because the realm field is not used inside JDK) >>>> >>>> I am planning to fix this to make the PrincipalName immutable and always with a non-null non-empty realm. I also plan to make Realm immutable and remove the ServiceName class (it's quite useless). >>>> >>>> A brief look into the code and protocol suggests this is quite feasible. In every krb5 message and serialized data (I mean ccache and keytab) defined, there is always a realm beside name. This is also true for most Java methods. And I don't think a name with an "unresolved" realm should exists at all. If we have to deal with something like this, I'd rather invent a new class for it. >>>> >>>> The code change will be mostly refactoring, removing a lot of realm arguments/fields and merging it into name. One behavior change is that there will be no name with "unresolved" realm anymore, but I think this should never be true in a real production environment. In fact, the public API KerberosPrincipal has >>>> >>>> * @throws IllegalArgumentException if name is improperly >>>> * formatted, if name is null, or if name does not contain >>>> * the realm to use and the default realm is not specified >>>> * in either a Kerberos configuration file or via the >>>> * java.security.krb5.realm system property. >>>> >>>> What's your suggestion? I've been haunted by this several times, mostly because a setRealm() is not called. >>>> >>>> Thanks >>>> Max >>> > From chris.hegarty at oracle.com Fri Jun 8 01:56:19 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 08 Jun 2012 08:56:19 +0000 Subject: hg: jdk8/tl/jdk: 7175413: Typo in comments of JVM_SupportsCX8 in jvm.h Message-ID: <20120608085645.75039477EB@hg.openjdk.java.net> Changeset: abe465d6a9b8 Author: chegar Date: 2012-06-08 09:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abe465d6a9b8 7175413: Typo in comments of JVM_SupportsCX8 in jvm.h Reviewed-by: chegar Contributed-by: Krystal Mok ! src/share/javavm/export/jvm.h From lance.andersen at oracle.com Fri Jun 8 04:58:08 2012 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Fri, 08 Jun 2012 11:58:08 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20120608115837.99AC5477F2@hg.openjdk.java.net> Changeset: 8305ddc88a5a Author: lancea Date: 2012-06-07 20:11 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8305ddc88a5a 7172551: Remove Native calls from DriverManager for jigsaw Reviewed-by: alanb, chegar, darcy, mchung ! make/java/java/FILES_c.gmk ! make/java/java/mapfile-vers ! makefiles/java/java/FILES_c.gmk ! makefiles/java/java/mapfile-vers ! src/share/classes/java/sql/DriverManager.java - src/share/native/java/sql/DriverManager.c Changeset: 7cb7bfae9d3a Author: lancea Date: 2012-06-08 09:22 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7cb7bfae9d3a Merge From steve.read at microfocus.com Fri Jun 8 05:31:20 2012 From: steve.read at microfocus.com (Steven Read) Date: Fri, 8 Jun 2012 12:31:20 +0000 (UTC) Subject: Code review request, CR =?utf-8?b?NzE3NDI0NCwJTlBF?= in Krb5ProxyImpl.getServerKeys() References: <4FCF4C9E.8080401@oracle.com> <4FCF5715.2010206@oracle.com> <4FCF597F.8050307@oracle.com> Message-ID: Xuelei Fan writes: > > On 6/6/2012 9:11 PM, Weijun Wang wrote: > > Hi Xuelei > > > > I don't quite understand the bug report. Certainly it's good to prevent > > that NPE, but why must the cipher suites be ordered? It seems it's not > > ordered before the new HashMap. > No, it was not ordered because of a regression. > > > Is this a regression or an RFE? > It's a regression. We used to use TreeSet to sort the cipher suites. But > later it is miss-updated to use ArrayList rather then TreeSet in a bug > fix. Then the order was lost. > > We need to sort the cipher suites because the order is the preference > when TLS handshaking selects a proper cipher suite. Please refer to TLS > specification about the order, page 41, RFC5246: > > cipher_suites > This is a list of the cryptographic options supported by the > client, with the client's first preference first. > > > You'd > > better add some explanation in the bug report. > > > I will. > > Thanks, > Xuelei > > > Thanks > > Max > > > > On 06/06/2012 08:27 PM, Xuelei Fan wrote: > >> Hi Weijun, > >> > >> Would you please review the fix for CR 7174244. > >> http://cr.openjdk.java.net./~xuelei/7174244/webrev.00/ > >> > >> There are mainly two updates in the fix. One is to have > >> Krb5ProxyImpl.getServerKeys() to check null return value of > >> Krb5Util.getServiceCreds(). The other one is to have cipher suite order > >> to be independent from HashMap implementation. TreeSet is used to > >> replace ArrayList so that the cipher suites order are sorted > >> automatically. > >> > >> Thanks, > >> Xuelei > > Hi Xuelei, My only comment is that providing the ciphers in preference order goes beyond what the API call specifies. I would agree it makes a lot of sense to have them returned in order, but other implementations of JSSE do not necessarily provide them in preference order as they are not required to - certainly looking at JDK1.6.0 on IBM earlier today it was not. Therefore, anyone wishing to write cross-JDK compatible code would be wrong to assume that they don't need to order the ciphers by preference themselves as well. Perhaps it is possible to do a docs change on the abstract classes to indicate that the order is not guaranteed across JSSE implementations. Best regards Steve From xuelei.fan at oracle.com Fri Jun 8 07:06:40 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Fri, 08 Jun 2012 22:06:40 +0800 Subject: Code review request, CR 7174244, NPE in Krb5ProxyImpl.getServerKeys() In-Reply-To: References: <4FCF4C9E.8080401@oracle.com> <4FCF5715.2010206@oracle.com> <4FCF597F.8050307@oracle.com> Message-ID: <4FD206F0.8000407@oracle.com> On 6/8/2012 8:31 PM, Steven Read wrote: > Xuelei Fan writes: > >> >> On 6/6/2012 9:11 PM, Weijun Wang wrote: >>> Hi Xuelei >>> >>> I don't quite understand the bug report. Certainly it's good to prevent >>> that NPE, but why must the cipher suites be ordered? It seems it's not >>> ordered before the new HashMap. >> No, it was not ordered because of a regression. >> >>> Is this a regression or an RFE? >> It's a regression. We used to use TreeSet to sort the cipher suites. But >> later it is miss-updated to use ArrayList rather then TreeSet in a bug >> fix. Then the order was lost. >> >> We need to sort the cipher suites because the order is the preference >> when TLS handshaking selects a proper cipher suite. Please refer to TLS >> specification about the order, page 41, RFC5246: >> >> cipher_suites >> This is a list of the cryptographic options supported by the >> client, with the client's first preference first. >> >>> You'd >>> better add some explanation in the bug report. >>> >> I will. >> >> Thanks, >> Xuelei >> >>> Thanks >>> Max >>> >>> On 06/06/2012 08:27 PM, Xuelei Fan wrote: >>>> Hi Weijun, >>>> >>>> Would you please review the fix for CR 7174244. >>>> http://cr.openjdk.java.net./~xuelei/7174244/webrev.00/ >>>> >>>> There are mainly two updates in the fix. One is to have >>>> Krb5ProxyImpl.getServerKeys() to check null return value of >>>> Krb5Util.getServiceCreds(). The other one is to have cipher suite order >>>> to be independent from HashMap implementation. TreeSet is used to >>>> replace ArrayList so that the cipher suites order are sorted >>>> automatically. >>>> >>>> Thanks, >>>> Xuelei >> >> > > Hi Xuelei, > > My only comment is that providing the ciphers in preference order goes beyond > what the API call specifies. I would agree it makes a lot of sense to have them > returned in order, but other implementations of JSSE do not necessarily provide > them in preference order as they are not required to - certainly looking at > JDK1.6.0 on IBM earlier today it was not. > Before the reply, I want to explain that the fix only impact the default cipher suites preference of Oracle provider. It does not impact the user customized cipher suites via SSLXxxxx.setEnabledCipherSuites(). Hope we are on the same page on this point. Right. It's not a part of java specification. It's a behavior of Oracle provider. It may not apply third parties' providers. Different provider may define different preferences, it is hard to define what's the preference exactly. And it is hard to tell which provider provides a better preference for a certain circumstance. Cross-provider applications which care about the exactly order should not reply on providers preference. > Therefore, anyone wishing to write cross-JDK compatible code would be wrong to > assume that they don't need to order the ciphers by preference themselves as > well. If the application uses the default cipher suites, every provider has its own default preference. If the application uses the customized cipher suites, the preference is defined by the application, providers should not (should not, is it really true for every provider? I'm not sure) adjust the users preference. So I'm not sure I understand in which case the user will run into the confusion you mentioned above. > Perhaps it is possible to do a docs change on the abstract classes to > indicate that the order is not guaranteed across JSSE implementations. > I think maybe no words to guarantee the order is to say that it may be ordered, may be not. IMHO, I did not see a very strong reason to declare a maybe-or-maybe-not spec. Thank you very much for looking into the issue and the feedback. Thanks & Regards, Xuelei > Best regards > Steve > > > From rob.mckenna at oracle.com Fri Jun 8 10:22:23 2012 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Fri, 08 Jun 2012 17:22:23 +0000 Subject: hg: jdk8/tl/jdk: 7161881: (dc) DatagramChannel.bind(null) fails if IPv4 socket and running with preferIPv6Addresses=true Message-ID: <20120608172242.708E247807@hg.openjdk.java.net> Changeset: a7895dc61088 Author: robm Date: 2012-06-08 18:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a7895dc61088 7161881: (dc) DatagramChannel.bind(null) fails if IPv4 socket and running with preferIPv6Addresses=true Reviewed-by: alanb, chegar ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java + test/java/nio/channels/DatagramChannel/BindNull.java From hbhotz at oxy.edu Fri Jun 8 12:55:22 2012 From: hbhotz at oxy.edu (Henry B. Hotz) Date: Fri, 8 Jun 2012 12:55:22 -0700 Subject: Avoid PrincipalName with realm == null In-Reply-To: <4FD19DB8.90608@oracle.com> References: <4FCFFC07.2090605@oracle.com> <4FD1691A.8030305@oracle.com> <9B778713-E821-414D-A38F-BEF32598B5D9@oxy.edu> <4FD19DB8.90608@oracle.com> Message-ID: Always just used the API, which takes care of it. Anyway, this looks like as authoritative a description as any. In particular, it says the first string is the realm, which matches my intuition of what should be there, since it's the same ordering as in the DER representation. http://www.gnu.org/software/shishi/manual/html_node/The-Credential-Cache-Binary-File-Format.html On Jun 7, 2012, at 11:37 PM, Weijun Wang wrote: > On 06/08/2012 02:09 PM, Henry B. Hotz wrote: >> Thanks for checking. I was remembering some early discussion of possibilities that obviously didn't make it to the final version. >> >> I'm also wrestling with an oddball application that stores some data in the ccache with a principal name without a realm. The data isn't a ticket though, so that's really completely off the reservation. ;-) > > I've met something similar, at the realm field is a string "X-CACHECONF:". We have to skip that entry. > > In fact, how can one tell if a principal inside a ccache has or hasn't a realm? It's just an array of strings there. Who knows if the first one is for realm or the first component? > > -Max > > >> >> On Jun 7, 2012, at 7:53 PM, Weijun Wang wrote: >> >>> Hi Henry >>> >>> We haven't supported the anonymous feature in Java yet. >>> >>> Anyway, if I read RFC6111/6112 correctly, an anonymous principal name uses well-known values in its nameStrings and nameRealm fields, so they are still neither null nor empty. This does not conflict with my proposal. Also, it seems the KDC (or a service) recognizes the client being anonymous mainly by looking at the KDCOptions or TicketFlags, not the name itself. >>> >>> If we want to support anonymous in Java's kerberos, we can make use of the current requestAnonymity/getAnonymityState methods. The getSrcName method will also return a GSSName whose isAnonymous() might return true. The PrincipalName here is a sun.security.* internal class. >>> >>> Thanks >>> Max >>> >>> >>> On 06/08/2012 02:39 AM, Henry B. Hotz wrote: >>>> Doesn't this interact with the new anonymity standards? >>>> >>>> On Jun 6, 2012, at 5:55 PM, Weijun Wang wrote: >>>> >>>>> Hi Valerie >>>>> >>>>> The krb5 PrincipalName class has a realm field and the class says >>>>> >>>>> If null, means the default realm >>>>> >>>>> Ideally this means if the realm of a name is null then this field can be null. Otherwise, it must be filled when created. >>>>> >>>>> In fact, inside our codes, the field is often filled (using setRealm()) after it's created. This leads to several strange coding styles that make the codes confusing and error-prone. >>>>> >>>>> 1. a lot of setRealm() calls that's far from the creation of the principal name only when the field needs to be used >>>>> 2. a lot of if (realm == null) checks >>>>> 3. a lot of "unresolved" names that never has a realm but is definitely not in the default realm (just because the realm field is not used inside JDK) >>>>> >>>>> I am planning to fix this to make the PrincipalName immutable and always with a non-null non-empty realm. I also plan to make Realm immutable and remove the ServiceName class (it's quite useless). >>>>> >>>>> A brief look into the code and protocol suggests this is quite feasible. In every krb5 message and serialized data (I mean ccache and keytab) defined, there is always a realm beside name. This is also true for most Java methods. And I don't think a name with an "unresolved" realm should exists at all. If we have to deal with something like this, I'd rather invent a new class for it. >>>>> >>>>> The code change will be mostly refactoring, removing a lot of realm arguments/fields and merging it into name. One behavior change is that there will be no name with "unresolved" realm anymore, but I think this should never be true in a real production environment. In fact, the public API KerberosPrincipal has >>>>> >>>>> * @throws IllegalArgumentException if name is improperly >>>>> * formatted, if name is null, or if name does not contain >>>>> * the realm to use and the default realm is not specified >>>>> * in either a Kerberos configuration file or via the >>>>> * java.security.krb5.realm system property. >>>>> >>>>> What's your suggestion? I've been haunted by this several times, mostly because a setRealm() is not called. >>>>> >>>>> Thanks >>>>> Max >>>> >> From valerie.peng at oracle.com Fri Jun 8 17:08:00 2012 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Fri, 08 Jun 2012 17:08:00 -0700 Subject: Code Review Request for 7044060 "Need to support NSA Suite B Cryptography algorithms" Message-ID: <4FD293E0.9020304@oracle.com> Vinnie, Could you please review the changes for 7044060 "Need to support NSA Suite B Cryptography algorithms"? The webrev is at: http://cr.openjdk.java.net/~valeriep/7044060/webrev.00/ The changes are as follows: 1) add support for larger DSA key sizes (up to 2048-bit): this also means adding built-in parameter, and SHA224withDSA and SHA256withDSA signatures. 2) add AES OID support and other misc ones. Thanks, Valerie From valerie.peng at oracle.com Fri Jun 8 17:23:20 2012 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Fri, 08 Jun 2012 17:23:20 -0700 Subject: Avoid PrincipalName with realm == null In-Reply-To: <4FCFFC07.2090605@oracle.com> References: <4FCFFC07.2090605@oracle.com> Message-ID: <4FD29778.9060907@oracle.com> Max, Yes, I think the current model that you described sounds error prone. I don't know the history of the current design. But I do also prefer the described changes that you have. I'd expect the refactoring would make the code clearer and more robust. Valerie On 06/06/12 17:55, Weijun Wang wrote: > Hi Valerie > > The krb5 PrincipalName class has a realm field and the class says > > If null, means the default realm > > Ideally this means if the realm of a name is null then this field can > be null. Otherwise, it must be filled when created. > > In fact, inside our codes, the field is often filled (using > setRealm()) after it's created. This leads to several strange coding > styles that make the codes confusing and error-prone. > > 1. a lot of setRealm() calls that's far from the creation of the > principal name only when the field needs to be used > 2. a lot of if (realm == null) checks > 3. a lot of "unresolved" names that never has a realm but is > definitely not in the default realm (just because the realm field is > not used inside JDK) > > I am planning to fix this to make the PrincipalName immutable and > always with a non-null non-empty realm. I also plan to make Realm > immutable and remove the ServiceName class (it's quite useless). > > A brief look into the code and protocol suggests this is quite > feasible. In every krb5 message and serialized data (I mean ccache and > keytab) defined, there is always a realm beside name. This is also > true for most Java methods. And I don't think a name with an > "unresolved" realm should exists at all. If we have to deal with > something like this, I'd rather invent a new class for it. > > The code change will be mostly refactoring, removing a lot of realm > arguments/fields and merging it into name. One behavior change is that > there will be no name with "unresolved" realm anymore, but I think > this should never be true in a real production environment. In fact, > the public API KerberosPrincipal has > > * @throws IllegalArgumentException if name is improperly > * formatted, if name is null, or if name does not contain > * the realm to use and the default realm is not specified > * in either a Kerberos configuration file or via the > * java.security.krb5.realm system property. > > What's your suggestion? I've been haunted by this several times, > mostly because a setRealm() is not called. > > Thanks > Max From alan.bateman at oracle.com Sun Jun 10 02:33:58 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sun, 10 Jun 2012 09:33:58 +0000 Subject: hg: jdk8/tl/jdk: 7175775: Disable SA options in jinfo/Basic.java test until SA updated for new hash and String count/offset Message-ID: <20120610093426.2D63847829@hg.openjdk.java.net> Changeset: fc575c78f5d3 Author: alanb Date: 2012-06-10 10:29 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc575c78f5d3 7175775: Disable SA options in jinfo/Basic.java test until SA updated for new hash and String count/offset Reviewed-by: minqi ! test/sun/tools/jinfo/Basic.sh From weijun.wang at oracle.com Sun Jun 10 22:29:11 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 11 Jun 2012 13:29:11 +0800 Subject: Code revire request: 6966259 (was Re: Avoid PrincipalName with realm == null) In-Reply-To: <4FD29778.9060907@oracle.com> References: <4FCFFC07.2090605@oracle.com> <4FD29778.9060907@oracle.com> Message-ID: <4FD58227.4070709@oracle.com> Hi Valerie Here is the webrev: http://cr.openjdk.java.net/~weijun/6966259/webrev.00/ The patch is quite long, but most of the real changes are in a few classes: PrincipalName.java: . All fields are final and non-null non-empty now . All constructors have a realm argument, including those from DER . Add a new static method tgsService(r1, r2) to get AS/TGS name . Remove ServiceName class . New reg test: Constructors.java Realm.java: . Field is now final . New getDefault() method KDCReqBody.java: . cname and sname share the same realm field. This is also the only message format that realm comes after name. KrbKdcRep.java: . Related to the class above. The check() method now has a new argument isAsReq to deal with AS-REQ and TGS-REQ differently. The old code does not check crealm equality, now both name and realm are checked, but only for AS-REQ. For TGS-REQ, no more check for cname equality, this will be useful for S4U2proxy where the cname of KDCRep comes from the additional ticket in request. The old code checks if req.crealm is rep.srealm, since KDCReqBody has only one realm field, this is the same as checking req.srealm and rep.srealm. CCacheInputStream.java: . readPrincipal returns null when there is no realm field. This has the benefit that a ccache is readable even if there is no valid krb5 setting. A normal ccache entry's principal should have its own realm field. but when an entry is used to store non-ticket, returning null won't trigger an exception. (See readCred about "X-CACHECONF:" style entries) Other trivial code changes: . Methods with the realm/name argument pair now has only name . In parsing DER, read realm and then merge the info into name . In encoding DER, encode the realm from name.getRealm() . No need to check realm == null for name . No need to print realm in debug output . No need to call setRealm() Thanks Max On 06/09/2012 08:23 AM, Valerie (Yu-Ching) Peng wrote: > Max, > > Yes, I think the current model that you described sounds error prone. I > don't know the history of the current design. > But I do also prefer the described changes that you have. > I'd expect the refactoring would make the code clearer and more robust. > > Valerie > > On 06/06/12 17:55, Weijun Wang wrote: >> Hi Valerie >> >> The krb5 PrincipalName class has a realm field and the class says >> >> If null, means the default realm >> >> Ideally this means if the realm of a name is null then this field can >> be null. Otherwise, it must be filled when created. >> >> In fact, inside our codes, the field is often filled (using >> setRealm()) after it's created. This leads to several strange coding >> styles that make the codes confusing and error-prone. >> >> 1. a lot of setRealm() calls that's far from the creation of the >> principal name only when the field needs to be used >> 2. a lot of if (realm == null) checks >> 3. a lot of "unresolved" names that never has a realm but is >> definitely not in the default realm (just because the realm field is >> not used inside JDK) >> >> I am planning to fix this to make the PrincipalName immutable and >> always with a non-null non-empty realm. I also plan to make Realm >> immutable and remove the ServiceName class (it's quite useless). >> >> A brief look into the code and protocol suggests this is quite >> feasible. In every krb5 message and serialized data (I mean ccache and >> keytab) defined, there is always a realm beside name. This is also >> true for most Java methods. And I don't think a name with an >> "unresolved" realm should exists at all. If we have to deal with >> something like this, I'd rather invent a new class for it. >> >> The code change will be mostly refactoring, removing a lot of realm >> arguments/fields and merging it into name. One behavior change is that >> there will be no name with "unresolved" realm anymore, but I think >> this should never be true in a real production environment. In fact, >> the public API KerberosPrincipal has >> >> * @throws IllegalArgumentException if name is improperly >> * formatted, if name is null, or if name does not contain >> * the realm to use and the default realm is not specified >> * in either a Kerberos configuration file or via the >> * java.security.krb5.realm system property. >> >> What's your suggestion? I've been haunted by this several times, >> mostly because a setRealm() is not called. >> >> Thanks >> Max > From steve.read at microfocus.com Mon Jun 11 03:18:11 2012 From: steve.read at microfocus.com (Steven Read) Date: Mon, 11 Jun 2012 10:18:11 +0000 (UTC) Subject: Code review request, CR =?utf-8?b?NzE3NDI0NCwJTlBF?= in Krb5ProxyImpl.getServerKeys() References: <4FCF4C9E.8080401@oracle.com> <4FCF5715.2010206@oracle.com> <4FCF597F.8050307@oracle.com> <4FD206F0.8000407@oracle.com> Message-ID: Xuelei Fan writes: > > On 6/8/2012 8:31 PM, Steven Read wrote: > > Xuelei Fan writes: > > > >> > >> On 6/6/2012 9:11 PM, Weijun Wang wrote: > >>> Hi Xuelei > >>> > >>> I don't quite understand the bug report. Certainly it's good to prevent > >>> that NPE, but why must the cipher suites be ordered? It seems it's not > >>> ordered before the new HashMap. > >> No, it was not ordered because of a regression. > >> > >>> Is this a regression or an RFE? > >> It's a regression. We used to use TreeSet to sort the cipher suites. But > >> later it is miss-updated to use ArrayList rather then TreeSet in a bug > >> fix. Then the order was lost. > >> > >> We need to sort the cipher suites because the order is the preference > >> when TLS handshaking selects a proper cipher suite. Please refer to TLS > >> specification about the order, page 41, RFC5246: > >> > >> cipher_suites > >> This is a list of the cryptographic options supported by the > >> client, with the client's first preference first. > >> > >>> You'd > >>> better add some explanation in the bug report. > >>> > >> I will. > >> > >> Thanks, > >> Xuelei > >> > >>> Thanks > >>> Max > >>> > >>> On 06/06/2012 08:27 PM, Xuelei Fan wrote: > >>>> Hi Weijun, > >>>> > >>>> Would you please review the fix for CR 7174244. > >>>> http://cr.openjdk.java.net./~xuelei/7174244/webrev.00/ > >>>> > >>>> There are mainly two updates in the fix. One is to have > >>>> Krb5ProxyImpl.getServerKeys() to check null return value of > >>>> Krb5Util.getServiceCreds(). The other one is to have cipher suite order > >>>> to be independent from HashMap implementation. TreeSet is used to > >>>> replace ArrayList so that the cipher suites order are sorted > >>>> automatically. > >>>> > >>>> Thanks, > >>>> Xuelei > >> > >> > > > > Hi Xuelei, > > > > My only comment is that providing the ciphers in preference order goes beyond > > what the API call specifies. I would agree it makes a lot of sense to have them > > returned in order, but other implementations of JSSE do not necessarily provide > > them in preference order as they are not required to - certainly looking at > > JDK1.6.0 on IBM earlier today it was not. > > > Before the reply, I want to explain that the fix only impact the default > cipher suites preference of Oracle provider. It does not impact the user > customized cipher suites via SSLXxxxx.setEnabledCipherSuites(). Hope we > are on the same page on this point. > > Right. It's not a part of java specification. It's a behavior of Oracle > provider. It may not apply third parties' providers. > > Different provider may define different preferences, it is hard to > define what's the preference exactly. And it is hard to tell which > provider provides a better preference for a certain circumstance. > Cross-provider applications which care about the exactly order should > not reply on providers preference. > > > Therefore, anyone wishing to write cross-JDK compatible code would be wrong to > > assume that they don't need to order the ciphers by preference themselves as > > well. > If the application uses the default cipher suites, every provider has > its own default preference. If the application uses the customized > cipher suites, the preference is defined by the application, providers > should not (should not, is it really true for every provider? I'm not > sure) adjust the users preference. So I'm not sure I understand in > which case the user will run into the confusion you mentioned above. > > > Perhaps it is possible to do a docs change on the abstract classes to > > indicate that the order is not guaranteed across JSSE implementations. > > > I think maybe no words to guarantee the order is to say that it may be > ordered, may be not. IMHO, I did not see a very strong reason to declare > a maybe-or-maybe-not spec. > > Thank you very much for looking into the issue and the feedback. > > Thanks & Regards, > Xuelei > > > Best regards > > Steve > > > > > > > > Hi Xuelei, yes I agree that the reordering doesn't affect those ciphers set using SetEnabledCipherSuites, and that yes other providers can have different preference orders returned by getSupportedCipherSuites. It is also true that they won't necessarily sort by an order at all. In the Sun/Oracle JDK 5 and 6, was the order by preference? As far as I can see from the commit log this is new functionality introduced in change 6976117. My concern is for anyone trying to dynamically use the order of getSupportedCipherSuites to enable a subset of ciphers. Order is not guaranteed, so I cannot see where order would be used besides in printing it or similar. For consistent behaviour regarding cipher preference a developer must reference a list of their own ciphers instead, even if it is based on a JSSE provider's list. If getSupportedCipherSuites returns an unsorted list in JDK5 and JDK6, then there should in my opinion be measures to stop compilation of code written against the sorted list functionality with a JDK5/6 compiler. I therefore feel that a new method call would be better in that it cannot be mis-used in older JDK versions and JDKs by other vendors. That way, the documentation for the new method can then say that the order of the ciphers is sorted - and people can trust it. >From my investigations it appears to me the ciphers from getSupportedCipherSuites have never been sorted in released code, even if the TreeSet was originally intended in place of the ArrayList. Your original response to Max gave me the impression this feature existed already, but on closer inspecition it looks like the initial commit was an ArrayList and my experiences on JDK6 (Sun and IBM) have suggested that the order is unsorted. I have only skimmed over code so please tell me if the original code was ordered as well as filtered. I hope I have managed to explain my concerns clearly. I think that an ordered list of ciphers is great, but am concerned it is done in a way that is not dangerous to those running old/different JDKs. Best regards Steve From lance.andersen at oracle.com Mon Jun 11 04:11:34 2012 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Mon, 11 Jun 2012 11:11:34 +0000 Subject: hg: jdk8/tl/jdk: 7171917: CachedRowSetImpl.populate does not handle map properly Message-ID: <20120611111155.62A8E47850@hg.openjdk.java.net> Changeset: 46ff1b63b0c3 Author: lancea Date: 2012-06-11 07:10 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46ff1b63b0c3 7171917: CachedRowSetImpl.populate does not handle map properly Reviewed-by: joehw ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java From kumar.x.srinivasan at oracle.com Mon Jun 11 15:58:30 2012 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Mon, 11 Jun 2012 22:58:30 +0000 Subject: hg: jdk8/tl/langtools: 7160072: (javac) JavacParserTests needs cleanup Message-ID: <20120611225835.28BF247883@hg.openjdk.java.net> Changeset: 9cafabb5e576 Author: ksrini Date: 2012-06-11 15:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9cafabb5e576 7160072: (javac) JavacParserTests needs cleanup Reviewed-by: jjg ! test/tools/javac/parser/JavacParserTest.java From staffan.larsen at oracle.com Fri Jun 8 05:40:28 2012 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Fri, 08 Jun 2012 12:40:28 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20120608124049.2B5F6477F3@hg.openjdk.java.net> Changeset: 82c41d3065e2 Author: sla Date: 2012-06-07 15:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82c41d3065e2 7165257: Add JFR tests to the JDK code base Reviewed-by: ohair, dholmes, nloodin, mgronlun ! make/jprt.properties ! test/Makefile Changeset: 961807959c5f Author: sla Date: 2012-06-08 05:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/961807959c5f Merge From staffan.larsen at oracle.com Fri Jun 8 05:50:46 2012 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Fri, 08 Jun 2012 12:50:46 +0000 Subject: hg: jdk8/tl: 7165257: Add JFR tests to the JDK code base Message-ID: <20120608125046.9BA42477F4@hg.openjdk.java.net> Changeset: df998cd4d51d Author: sla Date: 2012-06-07 15:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/df998cd4d51d 7165257: Add JFR tests to the JDK code base Reviewed-by: ohair, dholmes, nloodin, mgronlun ! make/jprt.properties From huizhe.wang at oracle.com Fri Jun 8 11:26:29 2012 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Fri, 08 Jun 2012 18:26:29 +0000 Subject: hg: jdk8/tl/jaxp: 7157608: One feature is not recognized. Message-ID: <20120608182633.AD38747809@hg.openjdk.java.net> Changeset: 238d2d0249af Author: joehw Date: 2012-06-08 11:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/238d2d0249af 7157608: One feature is not recognized. Summary: adding feature standard-uri-conformant into the recognized list Reviewed-by: psandoz ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java From staffan.larsen at oracle.com Mon Jun 11 11:52:21 2012 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Mon, 11 Jun 2012 18:52:21 +0000 Subject: hg: jdk8/tl: 7175802: Missing jdk_jfr in top-level make file Message-ID: <20120611185221.CD62F4786A@hg.openjdk.java.net> Changeset: 1af3996aa431 Author: sla Date: 2012-06-11 20:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/1af3996aa431 7175802: Missing jdk_jfr in top-level make file Reviewed-by: alanb ! test/Makefile From huizhe.wang at oracle.com Mon Jun 11 15:45:07 2012 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Mon, 11 Jun 2012 22:45:07 +0000 Subject: hg: jdk8/tl/jaxp: 7157610: NullPointerException occurs when parsing XML doc Message-ID: <20120611224512.56C1547882@hg.openjdk.java.net> Changeset: f328914a04ea Author: joehw Date: 2012-06-11 15:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f328914a04ea 7157610: NullPointerException occurs when parsing XML doc Summary: recovers what was the original disallow-doctype-decl, reporting error when disallow-doctype-decl is true, and change everything else that was added for SupportDTD to be governed by a new flag 'fSupportDTD'. Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentScannerImpl.java From xuelei.fan at oracle.com Mon Jun 11 17:24:02 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Tue, 12 Jun 2012 08:24:02 +0800 Subject: Code review request, CR 7174244, NPE in Krb5ProxyImpl.getServerKeys() In-Reply-To: References: <4FCF4C9E.8080401@oracle.com> <4FCF5715.2010206@oracle.com> <4FCF597F.8050307@oracle.com> <4FD206F0.8000407@oracle.com> Message-ID: <4FD68C22.7070307@oracle.com> Hi Steven, JSSE is a provider based framework. And compatibility is one of the most important facts users concerns. That's to say, a provider developed for JDK 6 is expected to work with JDK 7. As implies that sometimes, we cannot changes the specification for some certain cases. Otherwise, we would run into compatibility issues. For this case, we did not require supported cipher suites are ordered. Providers may not implemented to support sorted supported cipher suites. If we update the spec to require to sort supported cipher suites in preference, we would face the compatibility issue, and the old providers would not be able to be used any more. So IMHO, unless there is very very strong concerns, we are just not able to update the specification. The preference order is an option of JSSE providers. Although it is not specified in API specification, SunJSSE providers would like to keep the behaviors consistent between different releases. SunJSSE provider defined the preference since 1.4.2 or earlier. But the preference may be changed in different builds or releases. You may find that "SSL_RSA_WITH_RC4_128_MD5" is the most preferable cipher suite in JDK 1.4.2, but in JDK 7, "TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA384" becomes the most preferable one. So unless you use the default cipher suites, it is not good to trust the order of supported cipher suites. Hope it answers your questions. Regards, Xuelei On 6/11/2012 6:18 PM, Steven Read wrote: > Xuelei Fan writes: > >> >> On 6/8/2012 8:31 PM, Steven Read wrote: >>> Xuelei Fan writes: >>> >>>> >>>> On 6/6/2012 9:11 PM, Weijun Wang wrote: >>>>> Hi Xuelei >>>>> >>>>> I don't quite understand the bug report. Certainly it's good to prevent >>>>> that NPE, but why must the cipher suites be ordered? It seems it's not >>>>> ordered before the new HashMap. >>>> No, it was not ordered because of a regression. >>>> >>>>> Is this a regression or an RFE? >>>> It's a regression. We used to use TreeSet to sort the cipher suites. But >>>> later it is miss-updated to use ArrayList rather then TreeSet in a bug >>>> fix. Then the order was lost. >>>> >>>> We need to sort the cipher suites because the order is the preference >>>> when TLS handshaking selects a proper cipher suite. Please refer to TLS >>>> specification about the order, page 41, RFC5246: >>>> >>>> cipher_suites >>>> This is a list of the cryptographic options supported by the >>>> client, with the client's first preference first. >>>> >>>>> You'd >>>>> better add some explanation in the bug report. >>>>> >>>> I will. >>>> >>>> Thanks, >>>> Xuelei >>>> >>>>> Thanks >>>>> Max >>>>> >>>>> On 06/06/2012 08:27 PM, Xuelei Fan wrote: >>>>>> Hi Weijun, >>>>>> >>>>>> Would you please review the fix for CR 7174244. >>>>>> http://cr.openjdk.java.net./~xuelei/7174244/webrev.00/ >>>>>> >>>>>> There are mainly two updates in the fix. One is to have >>>>>> Krb5ProxyImpl.getServerKeys() to check null return value of >>>>>> Krb5Util.getServiceCreds(). The other one is to have cipher suite order >>>>>> to be independent from HashMap implementation. TreeSet is used to >>>>>> replace ArrayList so that the cipher suites order are sorted >>>>>> automatically. >>>>>> >>>>>> Thanks, >>>>>> Xuelei >>>> >>>> >>> >>> Hi Xuelei, >>> >>> My only comment is that providing the ciphers in preference order goes > beyond >>> what the API call specifies. I would agree it makes a lot of sense to have > them >>> returned in order, but other implementations of JSSE do not necessarily > provide >>> them in preference order as they are not required to - certainly looking at >>> JDK1.6.0 on IBM earlier today it was not. >>> >> Before the reply, I want to explain that the fix only impact the default >> cipher suites preference of Oracle provider. It does not impact the user >> customized cipher suites via SSLXxxxx.setEnabledCipherSuites(). Hope we >> are on the same page on this point. >> >> Right. It's not a part of java specification. It's a behavior of Oracle >> provider. It may not apply third parties' providers. >> >> Different provider may define different preferences, it is hard to >> define what's the preference exactly. And it is hard to tell which >> provider provides a better preference for a certain circumstance. >> Cross-provider applications which care about the exactly order should >> not reply on providers preference. >> >>> Therefore, anyone wishing to write cross-JDK compatible code would be > wrong to >>> assume that they don't need to order the ciphers by preference themselves > as >>> well. >> If the application uses the default cipher suites, every provider has >> its own default preference. If the application uses the customized >> cipher suites, the preference is defined by the application, providers >> should not (should not, is it really true for every provider? I'm not >> sure) adjust the users preference. So I'm not sure I understand in >> which case the user will run into the confusion you mentioned above. >> >>> Perhaps it is possible to do a docs change on the abstract classes to >>> indicate that the order is not guaranteed across JSSE implementations. >>> >> I think maybe no words to guarantee the order is to say that it may be >> ordered, may be not. IMHO, I did not see a very strong reason to declare >> a maybe-or-maybe-not spec. >> >> Thank you very much for looking into the issue and the feedback. >> >> Thanks & Regards, >> Xuelei >> >>> Best regards >>> Steve >>> >>> >>> >> >> > > Hi Xuelei, yes I agree that the reordering doesn't affect those ciphers set > using SetEnabledCipherSuites, and that yes other providers can have different > preference orders returned by getSupportedCipherSuites. It is also true that > they won't necessarily sort by an order at all. > > In the Sun/Oracle JDK 5 and 6, was the order by preference? As far as I can > see from the commit log this is new functionality introduced in change 6976117. > > My concern is for anyone trying to dynamically use the order of > getSupportedCipherSuites to enable a subset of ciphers. Order is not > guaranteed, so I cannot see where order would be used besides in printing it > or similar. For consistent behaviour regarding cipher preference a developer > must reference a list of their own ciphers instead, even if it is based on a > JSSE provider's list. > > If getSupportedCipherSuites returns an unsorted list in JDK5 and JDK6, then > there should in my opinion be measures to stop compilation of code written > against the sorted list functionality with a JDK5/6 compiler. I therefore feel > that a new method call would be better in that it cannot be mis-used in older > JDK versions and JDKs by other vendors. That way, the documentation for the > new method can then say that the order of the ciphers is sorted - and people > can trust it. > >>From my investigations it appears to me the ciphers from > getSupportedCipherSuites have never been sorted in released code, even if the > TreeSet was originally intended in place of the ArrayList. Your original > response to Max gave me the impression this feature existed already, but on > closer inspecition it looks like the initial commit was an ArrayList and my > experiences on JDK6 (Sun and IBM) have suggested that the order is unsorted. I > have only skimmed over code so please tell me if the original code was ordered > as well as filtered. > > I hope I have managed to explain my concerns clearly. I think that an ordered > list of ciphers is great, but am concerned it is done in a way that is not > dangerous to those running old/different JDKs. > > Best regards > Steve > From xuelei.fan at oracle.com Tue Jun 12 07:23:38 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Tue, 12 Jun 2012 22:23:38 +0800 Subject: Code revire request: 6966259 (was Re: Avoid PrincipalName with realm == null) In-Reply-To: <4FD58227.4070709@oracle.com> References: <4FCFFC07.2090605@oracle.com> <4FD29778.9060907@oracle.com> <4FD58227.4070709@oracle.com> Message-ID: <4FD750EA.60201@oracle.com> I have not reviewed too much about the fix. But before looking more updates, I was wondering whether it is good to have PrincipalName to be paired with Realm in the PrincipalName class. In RFC4120, realm names and principal names are two different name constraints for different purpose. The PrincipalName is defined as: PrincipalName ::= SEQUENCE { name-type [0] Int32, name-string [1] SEQUENCE OF KerberosString } There is no realm field in the structure. When I read Java code, I think the PrincipalName class is a one-to-one map to above PrincipalName specification. Otherwise, the class name may be confusing to me. I was wondering, can we just make the PrincipalName independent from Realm, and create a new class, such as XXXPrincipal to pair the PrincipalName and Realm? XXXPrincipal ::= SEQUENCE { principal PrincipalName, realm Realm } Xuelei On 6/11/2012 1:29 PM, Weijun Wang wrote: > Hi Valerie > > Here is the webrev: > > http://cr.openjdk.java.net/~weijun/6966259/webrev.00/ > > The patch is quite long, but most of the real changes are in a few classes: > > PrincipalName.java: > . All fields are final and non-null non-empty now > . All constructors have a realm argument, including those from DER > . Add a new static method tgsService(r1, r2) to get AS/TGS name > . Remove ServiceName class > . New reg test: Constructors.java > > Realm.java: > . Field is now final > . New getDefault() method > > KDCReqBody.java: > . cname and sname share the same realm field. This is also the only > message format that realm comes after name. > > KrbKdcRep.java: > . Related to the class above. The check() method now has a new argument > isAsReq to deal with AS-REQ and TGS-REQ differently. The old code does > not check crealm equality, now both name and realm are checked, but only > for AS-REQ. For TGS-REQ, no more check for cname equality, this will be > useful for S4U2proxy where the cname of KDCRep comes from the additional > ticket in request. The old code checks if req.crealm is rep.srealm, > since KDCReqBody has only one realm field, this is the same as checking > req.srealm and rep.srealm. > > CCacheInputStream.java: > . readPrincipal returns null when there is no realm field. This has the > benefit that a ccache is readable even if there is no valid krb5 > setting. A normal ccache entry's principal should have its own realm > field. but when an entry is used to store non-ticket, returning null > won't trigger an exception. (See readCred about "X-CACHECONF:" style > entries) > > Other trivial code changes: > . Methods with the realm/name argument pair now has only name > . In parsing DER, read realm and then merge the info into name > . In encoding DER, encode the realm from name.getRealm() > . No need to check realm == null for name > . No need to print realm in debug output > . No need to call setRealm() > > Thanks > Max > > > On 06/09/2012 08:23 AM, Valerie (Yu-Ching) Peng wrote: >> Max, >> >> Yes, I think the current model that you described sounds error prone. I >> don't know the history of the current design. >> But I do also prefer the described changes that you have. >> I'd expect the refactoring would make the code clearer and more robust. >> >> Valerie >> >> On 06/06/12 17:55, Weijun Wang wrote: >>> Hi Valerie >>> >>> The krb5 PrincipalName class has a realm field and the class says >>> >>> If null, means the default realm >>> >>> Ideally this means if the realm of a name is null then this field can >>> be null. Otherwise, it must be filled when created. >>> >>> In fact, inside our codes, the field is often filled (using >>> setRealm()) after it's created. This leads to several strange coding >>> styles that make the codes confusing and error-prone. >>> >>> 1. a lot of setRealm() calls that's far from the creation of the >>> principal name only when the field needs to be used >>> 2. a lot of if (realm == null) checks >>> 3. a lot of "unresolved" names that never has a realm but is >>> definitely not in the default realm (just because the realm field is >>> not used inside JDK) >>> >>> I am planning to fix this to make the PrincipalName immutable and >>> always with a non-null non-empty realm. I also plan to make Realm >>> immutable and remove the ServiceName class (it's quite useless). >>> >>> A brief look into the code and protocol suggests this is quite >>> feasible. In every krb5 message and serialized data (I mean ccache and >>> keytab) defined, there is always a realm beside name. This is also >>> true for most Java methods. And I don't think a name with an >>> "unresolved" realm should exists at all. If we have to deal with >>> something like this, I'd rather invent a new class for it. >>> >>> The code change will be mostly refactoring, removing a lot of realm >>> arguments/fields and merging it into name. One behavior change is that >>> there will be no name with "unresolved" realm anymore, but I think >>> this should never be true in a real production environment. In fact, >>> the public API KerberosPrincipal has >>> >>> * @throws IllegalArgumentException if name is improperly >>> * formatted, if name is null, or if name does not contain >>> * the realm to use and the default realm is not specified >>> * in either a Kerberos configuration file or via the >>> * java.security.krb5.realm system property. >>> >>> What's your suggestion? I've been haunted by this several times, >>> mostly because a setRealm() is not called. >>> >>> Thanks >>> Max >> From huizhe.wang at oracle.com Tue Jun 12 10:22:25 2012 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Tue, 12 Jun 2012 17:22:25 +0000 Subject: hg: jdk8/tl/jaxp: 7144423: StAX EventReader swallows the cause of error Message-ID: <20120612172232.1AE994789F@hg.openjdk.java.net> Changeset: 0c7f86d9ff8b Author: joehw Date: 2012-06-12 10:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/0c7f86d9ff8b 7144423: StAX EventReader swallows the cause of error Summary: make sure the cause of the error is properly reported Reviewed-by: lancea, psandoz ! src/com/sun/xml/internal/stream/XMLEventReaderImpl.java From lance.andersen at oracle.com Tue Jun 12 14:32:31 2012 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Tue, 12 Jun 2012 21:32:31 +0000 Subject: hg: jdk8/tl/jdk: 7171918: XmlReaderContentHandler.endElement does not handle a Delete Tag properly Message-ID: <20120612213302.411C3478AA@hg.openjdk.java.net> Changeset: 6b6a73e8c036 Author: lancea Date: 2012-06-12 17:32 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6b6a73e8c036 7171918: XmlReaderContentHandler.endElement does not handle a Delete Tag properly Reviewed-by: joehw ! src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java From weijun.wang at oracle.com Tue Jun 12 18:12:00 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 13 Jun 2012 09:12:00 +0800 Subject: Code revire request: 6966259 (was Re: Avoid PrincipalName with realm == null) In-Reply-To: <4FD750EA.60201@oracle.com> References: <4FCFFC07.2090605@oracle.com> <4FD29778.9060907@oracle.com> <4FD58227.4070709@oracle.com> <4FD750EA.60201@oracle.com> Message-ID: <4FD7E8E0.1000807@oracle.com> On 06/12/2012 10:23 PM, Xuelei Fan wrote: > I have not reviewed too much about the fix. But before looking more > updates, I was wondering whether it is good to have PrincipalName to be > paired with Realm in the PrincipalName class. > > In RFC4120, realm names and principal names are two different name > constraints for different purpose. The PrincipalName is defined as: > > PrincipalName ::= SEQUENCE { > name-type [0] Int32, > name-string [1] SEQUENCE OF KerberosString > } > > There is no realm field in the structure. When I read Java code, I think > the PrincipalName class is a one-to-one map to above PrincipalName > specification. Otherwise, the class name may be confusing to me. Yes, it's true that the PrincipalName defined in RFC has no realm, and therefore not equivalent to the PrincipalName class in Java, but I think there are several reasons we keep the current design: 1. In Kerberos, PrincipalName and Realm always appear together. In this sense, they should be modeled as a single data entity. 2. In Java, we had this model from the very beginning, i.e. PrincipalName includes the realm info inside. (We should document this). The current problem is that whether/when the realm field is filled is not consistent. > > I was wondering, can we just make the PrincipalName independent from > Realm, and create a new class, such as XXXPrincipal to pair the > PrincipalName and Realm? > > XXXPrincipal ::= SEQUENCE { > principal PrincipalName, > realm Realm > } Suppose you agree with me on the model design, this is just a name change, and after this name change, the plain PrincipalName class will be useless. I doubt this makes any real enhancement, but it really touches all the source files. Thanks Max > > > Xuelei > > On 6/11/2012 1:29 PM, Weijun Wang wrote: >> Hi Valerie >> >> Here is the webrev: >> >> http://cr.openjdk.java.net/~weijun/6966259/webrev.00/ >> >> The patch is quite long, but most of the real changes are in a few classes: >> >> PrincipalName.java: >> . All fields are final and non-null non-empty now >> . All constructors have a realm argument, including those from DER >> . Add a new static method tgsService(r1, r2) to get AS/TGS name >> . Remove ServiceName class >> . New reg test: Constructors.java >> >> Realm.java: >> . Field is now final >> . New getDefault() method >> >> KDCReqBody.java: >> . cname and sname share the same realm field. This is also the only >> message format that realm comes after name. >> >> KrbKdcRep.java: >> . Related to the class above. The check() method now has a new argument >> isAsReq to deal with AS-REQ and TGS-REQ differently. The old code does >> not check crealm equality, now both name and realm are checked, but only >> for AS-REQ. For TGS-REQ, no more check for cname equality, this will be >> useful for S4U2proxy where the cname of KDCRep comes from the additional >> ticket in request. The old code checks if req.crealm is rep.srealm, >> since KDCReqBody has only one realm field, this is the same as checking >> req.srealm and rep.srealm. >> >> CCacheInputStream.java: >> . readPrincipal returns null when there is no realm field. This has the >> benefit that a ccache is readable even if there is no valid krb5 >> setting. A normal ccache entry's principal should have its own realm >> field. but when an entry is used to store non-ticket, returning null >> won't trigger an exception. (See readCred about "X-CACHECONF:" style >> entries) >> >> Other trivial code changes: >> . Methods with the realm/name argument pair now has only name >> . In parsing DER, read realm and then merge the info into name >> . In encoding DER, encode the realm from name.getRealm() >> . No need to check realm == null for name >> . No need to print realm in debug output >> . No need to call setRealm() >> >> Thanks >> Max >> >> >> On 06/09/2012 08:23 AM, Valerie (Yu-Ching) Peng wrote: >>> Max, >>> >>> Yes, I think the current model that you described sounds error prone. I >>> don't know the history of the current design. >>> But I do also prefer the described changes that you have. >>> I'd expect the refactoring would make the code clearer and more robust. >>> >>> Valerie >>> >>> On 06/06/12 17:55, Weijun Wang wrote: >>>> Hi Valerie >>>> >>>> The krb5 PrincipalName class has a realm field and the class says >>>> >>>> If null, means the default realm >>>> >>>> Ideally this means if the realm of a name is null then this field can >>>> be null. Otherwise, it must be filled when created. >>>> >>>> In fact, inside our codes, the field is often filled (using >>>> setRealm()) after it's created. This leads to several strange coding >>>> styles that make the codes confusing and error-prone. >>>> >>>> 1. a lot of setRealm() calls that's far from the creation of the >>>> principal name only when the field needs to be used >>>> 2. a lot of if (realm == null) checks >>>> 3. a lot of "unresolved" names that never has a realm but is >>>> definitely not in the default realm (just because the realm field is >>>> not used inside JDK) >>>> >>>> I am planning to fix this to make the PrincipalName immutable and >>>> always with a non-null non-empty realm. I also plan to make Realm >>>> immutable and remove the ServiceName class (it's quite useless). >>>> >>>> A brief look into the code and protocol suggests this is quite >>>> feasible. In every krb5 message and serialized data (I mean ccache and >>>> keytab) defined, there is always a realm beside name. This is also >>>> true for most Java methods. And I don't think a name with an >>>> "unresolved" realm should exists at all. If we have to deal with >>>> something like this, I'd rather invent a new class for it. >>>> >>>> The code change will be mostly refactoring, removing a lot of realm >>>> arguments/fields and merging it into name. One behavior change is that >>>> there will be no name with "unresolved" realm anymore, but I think >>>> this should never be true in a real production environment. In fact, >>>> the public API KerberosPrincipal has >>>> >>>> * @throws IllegalArgumentException if name is improperly >>>> * formatted, if name is null, or if name does not contain >>>> * the realm to use and the default realm is not specified >>>> * in either a Kerberos configuration file or via the >>>> * java.security.krb5.realm system property. >>>> >>>> What's your suggestion? I've been haunted by this several times, >>>> mostly because a setRealm() is not called. >>>> >>>> Thanks >>>> Max >>> > From kelly.ohair at oracle.com Wed Jun 13 03:50:43 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Wed, 13 Jun 2012 10:50:43 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20120613105123.957E3478CF@hg.openjdk.java.net> Changeset: 9fd127ff51d5 Author: ohair Date: 2012-06-12 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9fd127ff51d5 7176138: Fixes for missing close() calls and possible null pointer reference instead of fatal error Reviewed-by: dcubed ! src/share/demo/jvmti/hprof/hprof_table.c ! src/solaris/demo/jvmti/hprof/hprof_md.c Changeset: 7b93a2a9cd15 Author: ohair Date: 2012-06-12 15:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b93a2a9cd15 Merge From weijun.wang at oracle.com Wed Jun 13 04:23:58 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 13 Jun 2012 11:23:58 +0000 Subject: hg: jdk8/tl/jdk: 7176574: sun/security/krb5/auto/TcpTimeout.java failed with solaris-i586 Message-ID: <20120613112408.CE616478D0@hg.openjdk.java.net> Changeset: 4435f8b20d08 Author: weijun Date: 2012-06-13 19:23 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4435f8b20d08 7176574: sun/security/krb5/auto/TcpTimeout.java failed with solaris-i586 Reviewed-by: chegar ! test/sun/security/krb5/auto/TcpTimeout.java From xuelei.fan at oracle.com Thu Jun 14 02:26:28 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Thu, 14 Jun 2012 17:26:28 +0800 Subject: Code revire request: 6966259 (was Re: Avoid PrincipalName with realm == null) In-Reply-To: <4FD7E8E0.1000807@oracle.com> References: <4FCFFC07.2090605@oracle.com> <4FD29778.9060907@oracle.com> <4FD58227.4070709@oracle.com> <4FD750EA.60201@oracle.com> <4FD7E8E0.1000807@oracle.com> Message-ID: <4FD9AE44.1050805@oracle.com> It's really confusing to mix the name of a principal and realm of a principal in the same PrincipalName class. For example, when printing a debug log for "sname", from the name of "sname", I think it a name of the principal, but the output also include the realm of the principal. When I read the spec, I think a message should contains both Realm and PrincipalName. But when read the code, only PrincipalName class appears in a call of a method. Feels very strange. I have to read the implementation carefully in order to understand the debug log and logic of the code. Can we make PrincipalName a pure name of a principal, without the realm field in it? How hard to make the changes? I noticed most of the code have the name and realm parameters at the same time, just as the krb5 v5 specification. I can accept your current design if you won't like to make more changes. I may be able to complete the review tomorrow. Thanks, Xuelei On 6/13/2012 9:12 AM, Weijun Wang wrote: > On 06/12/2012 10:23 PM, Xuelei Fan wrote: >> I have not reviewed too much about the fix. But before looking more >> updates, I was wondering whether it is good to have PrincipalName to be >> paired with Realm in the PrincipalName class. >> >> In RFC4120, realm names and principal names are two different name >> constraints for different purpose. The PrincipalName is defined as: >> >> PrincipalName ::= SEQUENCE { >> name-type [0] Int32, >> name-string [1] SEQUENCE OF KerberosString >> } >> >> There is no realm field in the structure. When I read Java code, I think >> the PrincipalName class is a one-to-one map to above PrincipalName >> specification. Otherwise, the class name may be confusing to me. > > Yes, it's true that the PrincipalName defined in RFC has no realm, and > therefore not equivalent to the PrincipalName class in Java, but I think > there are several reasons we keep the current design: > > 1. In Kerberos, PrincipalName and Realm always appear together. In this > sense, they should be modeled as a single data entity. > > 2. In Java, we had this model from the very beginning, i.e. > PrincipalName includes the realm info inside. (We should document this). > The current problem is that whether/when the realm field is filled is > not consistent. > >> >> I was wondering, can we just make the PrincipalName independent from >> Realm, and create a new class, such as XXXPrincipal to pair the >> PrincipalName and Realm? >> >> XXXPrincipal ::= SEQUENCE { >> principal PrincipalName, >> realm Realm >> } > > Suppose you agree with me on the model design, this is just a name > change, and after this name change, the plain PrincipalName class will > be useless. I doubt this makes any real enhancement, but it really > touches all the source files. > > Thanks > Max > >> >> >> Xuelei >> >> On 6/11/2012 1:29 PM, Weijun Wang wrote: >>> Hi Valerie >>> >>> Here is the webrev: >>> >>> http://cr.openjdk.java.net/~weijun/6966259/webrev.00/ >>> >>> The patch is quite long, but most of the real changes are in a few >>> classes: >>> >>> PrincipalName.java: >>> . All fields are final and non-null non-empty now >>> . All constructors have a realm argument, including those from DER >>> . Add a new static method tgsService(r1, r2) to get AS/TGS name >>> . Remove ServiceName class >>> . New reg test: Constructors.java >>> >>> Realm.java: >>> . Field is now final >>> . New getDefault() method >>> >>> KDCReqBody.java: >>> . cname and sname share the same realm field. This is also the only >>> message format that realm comes after name. >>> >>> KrbKdcRep.java: >>> . Related to the class above. The check() method now has a new argument >>> isAsReq to deal with AS-REQ and TGS-REQ differently. The old code does >>> not check crealm equality, now both name and realm are checked, but only >>> for AS-REQ. For TGS-REQ, no more check for cname equality, this will be >>> useful for S4U2proxy where the cname of KDCRep comes from the additional >>> ticket in request. The old code checks if req.crealm is rep.srealm, >>> since KDCReqBody has only one realm field, this is the same as checking >>> req.srealm and rep.srealm. >>> >>> CCacheInputStream.java: >>> . readPrincipal returns null when there is no realm field. This has the >>> benefit that a ccache is readable even if there is no valid krb5 >>> setting. A normal ccache entry's principal should have its own realm >>> field. but when an entry is used to store non-ticket, returning null >>> won't trigger an exception. (See readCred about "X-CACHECONF:" style >>> entries) >>> >>> Other trivial code changes: >>> . Methods with the realm/name argument pair now has only name >>> . In parsing DER, read realm and then merge the info into name >>> . In encoding DER, encode the realm from name.getRealm() >>> . No need to check realm == null for name >>> . No need to print realm in debug output >>> . No need to call setRealm() >>> >>> Thanks >>> Max >>> >>> >>> On 06/09/2012 08:23 AM, Valerie (Yu-Ching) Peng wrote: >>>> Max, >>>> >>>> Yes, I think the current model that you described sounds error prone. I >>>> don't know the history of the current design. >>>> But I do also prefer the described changes that you have. >>>> I'd expect the refactoring would make the code clearer and more robust. >>>> >>>> Valerie >>>> >>>> On 06/06/12 17:55, Weijun Wang wrote: >>>>> Hi Valerie >>>>> >>>>> The krb5 PrincipalName class has a realm field and the class says >>>>> >>>>> If null, means the default realm >>>>> >>>>> Ideally this means if the realm of a name is null then this field can >>>>> be null. Otherwise, it must be filled when created. >>>>> >>>>> In fact, inside our codes, the field is often filled (using >>>>> setRealm()) after it's created. This leads to several strange coding >>>>> styles that make the codes confusing and error-prone. >>>>> >>>>> 1. a lot of setRealm() calls that's far from the creation of the >>>>> principal name only when the field needs to be used >>>>> 2. a lot of if (realm == null) checks >>>>> 3. a lot of "unresolved" names that never has a realm but is >>>>> definitely not in the default realm (just because the realm field is >>>>> not used inside JDK) >>>>> >>>>> I am planning to fix this to make the PrincipalName immutable and >>>>> always with a non-null non-empty realm. I also plan to make Realm >>>>> immutable and remove the ServiceName class (it's quite useless). >>>>> >>>>> A brief look into the code and protocol suggests this is quite >>>>> feasible. In every krb5 message and serialized data (I mean ccache and >>>>> keytab) defined, there is always a realm beside name. This is also >>>>> true for most Java methods. And I don't think a name with an >>>>> "unresolved" realm should exists at all. If we have to deal with >>>>> something like this, I'd rather invent a new class for it. >>>>> >>>>> The code change will be mostly refactoring, removing a lot of realm >>>>> arguments/fields and merging it into name. One behavior change is that >>>>> there will be no name with "unresolved" realm anymore, but I think >>>>> this should never be true in a real production environment. In fact, >>>>> the public API KerberosPrincipal has >>>>> >>>>> * @throws IllegalArgumentException if name is improperly >>>>> * formatted, if name is null, or if name does not contain >>>>> * the realm to use and the default realm is not specified >>>>> * in either a Kerberos configuration file or via the >>>>> * java.security.krb5.realm system property. >>>>> >>>>> What's your suggestion? I've been haunted by this several times, >>>>> mostly because a setRealm() is not called. >>>>> >>>>> Thanks >>>>> Max >>>> >> From weijun.wang at oracle.com Thu Jun 14 02:55:50 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 14 Jun 2012 17:55:50 +0800 Subject: Code revire request: 6966259 (was Re: Avoid PrincipalName with realm == null) In-Reply-To: <4FD9AE44.1050805@oracle.com> References: <4FCFFC07.2090605@oracle.com> <4FD29778.9060907@oracle.com> <4FD58227.4070709@oracle.com> <4FD750EA.60201@oracle.com> <4FD7E8E0.1000807@oracle.com> <4FD9AE44.1050805@oracle.com> Message-ID: <4FD9B526.8060105@oracle.com> On 06/14/2012 05:26 PM, Xuelei Fan wrote: > It's really confusing to mix the name of a principal and realm of a > principal in the same PrincipalName class. > > For example, when printing a debug log for "sname", from the name of > "sname", I think it a name of the principal, but the output also include > the realm of the principal. > > When I read the spec, I think a message should contains both Realm and > PrincipalName. But when read the code, only PrincipalName class appears > in a call of a method. Feels very strange. I have to read the > implementation carefully in order to understand the debug log and logic > of the code. I understand your feelings. But in JDK, PrincipalName contains the realm info from the very beginning. Removing it from PrincipalName makes me confusing. Yes, maybe it's a bad name. Shall we wait for Valerie's opinion? > > Can we make PrincipalName a pure name of a principal, without the realm > field in it? We can, but for what? Anyway, I don't think we need to maintain both PrincipalNameWithoutRealm and PrincipalNameWithRealm. The 1st one is completely useless. The 2nd one is the existing PrincipalName. If you don't like it, how about simply call it Principal? > How hard to make the changes? Not hard at all. If you agree with me on my last paragraph, it's just a simple "s/PrincipalName/Principal/g" on all src/test codes. > I noticed most of the code > have the name and realm parameters at the same time, just as the krb5 v5 > specification. Yes, that's why I say PrincipalNameWithoutRealm is useless. > > I can accept your current design if you won't like to make more changes. > I may be able to complete the review tomorrow. Please go on. I think we agree on the basic idea that name and realm should be bound in a single class. The only disagreement is on the name of the class. Am I right? Thanks Max > > Thanks, > Xuelei > > On 6/13/2012 9:12 AM, Weijun Wang wrote: >> On 06/12/2012 10:23 PM, Xuelei Fan wrote: >>> I have not reviewed too much about the fix. But before looking more >>> updates, I was wondering whether it is good to have PrincipalName to be >>> paired with Realm in the PrincipalName class. >>> >>> In RFC4120, realm names and principal names are two different name >>> constraints for different purpose. The PrincipalName is defined as: >>> >>> PrincipalName ::= SEQUENCE { >>> name-type [0] Int32, >>> name-string [1] SEQUENCE OF KerberosString >>> } >>> >>> There is no realm field in the structure. When I read Java code, I think >>> the PrincipalName class is a one-to-one map to above PrincipalName >>> specification. Otherwise, the class name may be confusing to me. >> >> Yes, it's true that the PrincipalName defined in RFC has no realm, and >> therefore not equivalent to the PrincipalName class in Java, but I think >> there are several reasons we keep the current design: >> >> 1. In Kerberos, PrincipalName and Realm always appear together. In this >> sense, they should be modeled as a single data entity. >> >> 2. In Java, we had this model from the very beginning, i.e. >> PrincipalName includes the realm info inside. (We should document this). >> The current problem is that whether/when the realm field is filled is >> not consistent. >> >>> >>> I was wondering, can we just make the PrincipalName independent from >>> Realm, and create a new class, such as XXXPrincipal to pair the >>> PrincipalName and Realm? >>> >>> XXXPrincipal ::= SEQUENCE { >>> principal PrincipalName, >>> realm Realm >>> } >> >> Suppose you agree with me on the model design, this is just a name >> change, and after this name change, the plain PrincipalName class will >> be useless. I doubt this makes any real enhancement, but it really >> touches all the source files. >> >> Thanks >> Max >> >>> >>> >>> Xuelei >>> >>> On 6/11/2012 1:29 PM, Weijun Wang wrote: >>>> Hi Valerie >>>> >>>> Here is the webrev: >>>> >>>> http://cr.openjdk.java.net/~weijun/6966259/webrev.00/ >>>> >>>> The patch is quite long, but most of the real changes are in a few >>>> classes: >>>> >>>> PrincipalName.java: >>>> . All fields are final and non-null non-empty now >>>> . All constructors have a realm argument, including those from DER >>>> . Add a new static method tgsService(r1, r2) to get AS/TGS name >>>> . Remove ServiceName class >>>> . New reg test: Constructors.java >>>> >>>> Realm.java: >>>> . Field is now final >>>> . New getDefault() method >>>> >>>> KDCReqBody.java: >>>> . cname and sname share the same realm field. This is also the only >>>> message format that realm comes after name. >>>> >>>> KrbKdcRep.java: >>>> . Related to the class above. The check() method now has a new argument >>>> isAsReq to deal with AS-REQ and TGS-REQ differently. The old code does >>>> not check crealm equality, now both name and realm are checked, but only >>>> for AS-REQ. For TGS-REQ, no more check for cname equality, this will be >>>> useful for S4U2proxy where the cname of KDCRep comes from the additional >>>> ticket in request. The old code checks if req.crealm is rep.srealm, >>>> since KDCReqBody has only one realm field, this is the same as checking >>>> req.srealm and rep.srealm. >>>> >>>> CCacheInputStream.java: >>>> . readPrincipal returns null when there is no realm field. This has the >>>> benefit that a ccache is readable even if there is no valid krb5 >>>> setting. A normal ccache entry's principal should have its own realm >>>> field. but when an entry is used to store non-ticket, returning null >>>> won't trigger an exception. (See readCred about "X-CACHECONF:" style >>>> entries) >>>> >>>> Other trivial code changes: >>>> . Methods with the realm/name argument pair now has only name >>>> . In parsing DER, read realm and then merge the info into name >>>> . In encoding DER, encode the realm from name.getRealm() >>>> . No need to check realm == null for name >>>> . No need to print realm in debug output >>>> . No need to call setRealm() >>>> >>>> Thanks >>>> Max >>>> >>>> >>>> On 06/09/2012 08:23 AM, Valerie (Yu-Ching) Peng wrote: >>>>> Max, >>>>> >>>>> Yes, I think the current model that you described sounds error prone. I >>>>> don't know the history of the current design. >>>>> But I do also prefer the described changes that you have. >>>>> I'd expect the refactoring would make the code clearer and more robust. >>>>> >>>>> Valerie >>>>> >>>>> On 06/06/12 17:55, Weijun Wang wrote: >>>>>> Hi Valerie >>>>>> >>>>>> The krb5 PrincipalName class has a realm field and the class says >>>>>> >>>>>> If null, means the default realm >>>>>> >>>>>> Ideally this means if the realm of a name is null then this field can >>>>>> be null. Otherwise, it must be filled when created. >>>>>> >>>>>> In fact, inside our codes, the field is often filled (using >>>>>> setRealm()) after it's created. This leads to several strange coding >>>>>> styles that make the codes confusing and error-prone. >>>>>> >>>>>> 1. a lot of setRealm() calls that's far from the creation of the >>>>>> principal name only when the field needs to be used >>>>>> 2. a lot of if (realm == null) checks >>>>>> 3. a lot of "unresolved" names that never has a realm but is >>>>>> definitely not in the default realm (just because the realm field is >>>>>> not used inside JDK) >>>>>> >>>>>> I am planning to fix this to make the PrincipalName immutable and >>>>>> always with a non-null non-empty realm. I also plan to make Realm >>>>>> immutable and remove the ServiceName class (it's quite useless). >>>>>> >>>>>> A brief look into the code and protocol suggests this is quite >>>>>> feasible. In every krb5 message and serialized data (I mean ccache and >>>>>> keytab) defined, there is always a realm beside name. This is also >>>>>> true for most Java methods. And I don't think a name with an >>>>>> "unresolved" realm should exists at all. If we have to deal with >>>>>> something like this, I'd rather invent a new class for it. >>>>>> >>>>>> The code change will be mostly refactoring, removing a lot of realm >>>>>> arguments/fields and merging it into name. One behavior change is that >>>>>> there will be no name with "unresolved" realm anymore, but I think >>>>>> this should never be true in a real production environment. In fact, >>>>>> the public API KerberosPrincipal has >>>>>> >>>>>> * @throws IllegalArgumentException if name is improperly >>>>>> * formatted, if name is null, or if name does not contain >>>>>> * the realm to use and the default realm is not specified >>>>>> * in either a Kerberos configuration file or via the >>>>>> * java.security.krb5.realm system property. >>>>>> >>>>>> What's your suggestion? I've been haunted by this several times, >>>>>> mostly because a setRealm() is not called. >>>>>> >>>>>> Thanks >>>>>> Max >>>>> >>> > From xuelei.fan at oracle.com Thu Jun 14 02:57:56 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Thu, 14 Jun 2012 17:57:56 +0800 Subject: Code revire request: 6966259 (was Re: Avoid PrincipalName with realm == null) In-Reply-To: <4FD9B526.8060105@oracle.com> References: <4FCFFC07.2090605@oracle.com> <4FD29778.9060907@oracle.com> <4FD58227.4070709@oracle.com> <4FD750EA.60201@oracle.com> <4FD7E8E0.1000807@oracle.com> <4FD9AE44.1050805@oracle.com> <4FD9B526.8060105@oracle.com> Message-ID: <4FD9B5A4.2050308@oracle.com> On 6/14/2012 5:55 PM, Weijun Wang wrote: >> I can accept your current design if you won't like to make more changes. >> I may be able to complete the review tomorrow. > > Please go on. I think we agree on the basic idea that name and realm > should be bound in a single class. The only disagreement is on the name > of the class. Am I right? Yes. I will go on. Xuelei From alan.bateman at oracle.com Thu Jun 14 04:14:40 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 14 Jun 2012 11:14:40 +0000 Subject: hg: jdk8/tl/jdk: 7176630: (sc) SocketChannel.write does not write more than 128k when channel configured blocking [win] Message-ID: <20120614111520.036B247908@hg.openjdk.java.net> Changeset: 4f99d146fce0 Author: alanb Date: 2012-06-14 12:13 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4f99d146fce0 7176630: (sc) SocketChannel.write does not write more than 128k when channel configured blocking [win] Reviewed-by: khazra, chegar ! src/windows/native/sun/nio/ch/SocketDispatcher.c + test/java/nio/channels/SocketChannel/ShortWrite.java From sean.mullan at oracle.com Thu Jun 14 09:10:29 2012 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 14 Jun 2012 12:10:29 -0400 Subject: JDK 8 Code Review Request for 7176326: CertPath/CertPathBuilderTest failures after webrev 6854712_6637288_7126011 Message-ID: <4FDA0CF5.5010107@oracle.com> Xuelei or Vinnie could you please review the following fix: http://cr.openjdk.java.net/~mullan/webrevs/7176326/ The bug has not been posted yet, so I've included the relevant details below. It is a small regression introduced by my changes for JEP 124 (6854712). Also, I have moved the existing zeroLengthPath test from the closed repo (after removing a dependency on a proprietary cert), and enhanced it to also test 7176326. Thanks, Sean ------------ The following SQE tets are failing after the changes in webrev cr.openjdk.java.net/~mullan/webrevs/6854712_6637288_7126011/webrev.00 have been merged CertPath/CertPathBuilderTest/KeyUsagePolicy/test11 CertPath/CertPathBuilderTest/Misc/test101 CertPathBuilderTest/Misc/test15 CertPath/CertPathBuilderTest/Misc/test25 CertPath/CertPathBuilderTest/Misc/test35 CertPath/CertPathBuilderTest/Misc/test44 CertPath/CertPathBuilderTest/Misc/test59 CertPath/CertPathBuilderTest/Misc/test67 CertPath/CertPathBuilderTest/Misc/test78 CertPath/CertPathBuilderTest/Misc/test88 Stacktrace ----------- java.lang.NullPointerException: subjectPublicKey must be non-null at java.security.cert.PKIXCertPathValidatorResult.(PKIXCertPathValidatorResult.java:80) at sun.security.provider.certpath.PKIXCertPathValidator.validate(PKIXCertPathValidator.java:215) at sun.security.provider.certpath.PKIXCertPathValidator.validate(PKIXCertPathValidator.java:143) at sun.security.provider.certpath.PKIXCertPathValidator.engineValidate(PKIXCertPathValidator.java:79) at java.security.cert.CertPathValidator.validate(CertPathValidator.java:292) at BuildCertPath.doBuild(BuildCertPath.java:414) at BuildCertPath.main(BuildCertPath.java:139) java.lang.NullPointerException: subjectPublicKey must be non-null at java.security.cert.PKIXCertPathValidatorResult.(PKIXCertPathValidatorResult.java:80) at sun.security.provider.certpath.PKIXCertPathValidator.validate(PKIXCertPathValidator.java:215) at sun.security.provider.certpath.PKIXCertPathValidator.validate(PKIXCertPathValidator.java:143) at sun.security.provider.certpath.PKIXCertPathValidator.engineValidate(PKIXCertPathValidator.java:79) at java.security.cert.CertPathValidator.validate(CertPathValidator.java:292) at BuildCertPath.doBuild(BuildCertPath.java:414) at BuildCertPath.main(BuildCertPath.java:139) Entry 1 nithya.srinivasan [2012-06-12 16:46] Evaluation A regression was introduced as part of the JEP 124 changes (6854712). It only causes an exception if you are validating a zero-length CertPath. From lance.andersen at oracle.com Thu Jun 14 12:05:53 2012 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Thu, 14 Jun 2012 19:05:53 +0000 Subject: hg: jdk8/tl/jdk: 7145913: CachedRowSetSwriter.insertNewRow() throws SQLException Message-ID: <20120614190618.B196347917@hg.openjdk.java.net> Changeset: 28588ace1fb9 Author: lancea Date: 2012-06-14 15:05 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/28588ace1fb9 7145913: CachedRowSetSwriter.insertNewRow() throws SQLException Reviewed-by: joehw, naoto, psandoz, forax ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java From mike.duigou at oracle.com Thu Jun 14 08:27:16 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 14 Jun 2012 15:27:16 +0000 Subject: hg: jdk8/tl/jdk: 7173919: Minor optimization of hashing methods Message-ID: <20120614152728.0BDA84790C@hg.openjdk.java.net> Changeset: 505455116320 Author: mduigou Date: 2012-06-13 16:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/505455116320 7173919: Minor optimization of hashing methods Summary: several minor optimizations to hashing methods used by hash map classes Reviewed-by: dholmes ! src/share/classes/java/util/HashMap.java ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/WeakHashMap.java ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java From xuelei.fan at oracle.com Thu Jun 14 17:21:20 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Fri, 15 Jun 2012 08:21:20 +0800 Subject: JDK 8 Code Review Request for 7176326: CertPath/CertPathBuilderTest failures after webrev 6854712_6637288_7126011 In-Reply-To: <4FDA0CF5.5010107@oracle.com> References: <4FDA0CF5.5010107@oracle.com> Message-ID: <4FDA8000.7010309@oracle.com> Looks fine to me. Xuelei On 6/15/2012 12:10 AM, Sean Mullan wrote: > Xuelei or Vinnie could you please review the following fix: > > http://cr.openjdk.java.net/~mullan/webrevs/7176326/ > > The bug has not been posted yet, so I've included the relevant details > below. It is a small regression introduced by my changes for JEP 124 > (6854712). > > Also, I have moved the existing zeroLengthPath test from the closed repo > (after removing a dependency on a proprietary cert), and enhanced it to > also test 7176326. > > Thanks, > Sean > ------------ > > The following SQE tets are failing after the changes in webrev > cr.openjdk.java.net/~mullan/webrevs/6854712_6637288_7126011/webrev.00 > have been merged > > CertPath/CertPathBuilderTest/KeyUsagePolicy/test11 > CertPath/CertPathBuilderTest/Misc/test101 > CertPathBuilderTest/Misc/test15 > CertPath/CertPathBuilderTest/Misc/test25 > CertPath/CertPathBuilderTest/Misc/test35 > CertPath/CertPathBuilderTest/Misc/test44 > CertPath/CertPathBuilderTest/Misc/test59 > CertPath/CertPathBuilderTest/Misc/test67 > CertPath/CertPathBuilderTest/Misc/test78 > CertPath/CertPathBuilderTest/Misc/test88 > > > Stacktrace > ----------- > java.lang.NullPointerException: subjectPublicKey must be non-null > at > java.security.cert.PKIXCertPathValidatorResult.(PKIXCertPathValidatorResult.java:80) > > at > sun.security.provider.certpath.PKIXCertPathValidator.validate(PKIXCertPathValidator.java:215) > > at > sun.security.provider.certpath.PKIXCertPathValidator.validate(PKIXCertPathValidator.java:143) > > at > sun.security.provider.certpath.PKIXCertPathValidator.engineValidate(PKIXCertPathValidator.java:79) > > at > java.security.cert.CertPathValidator.validate(CertPathValidator.java:292) > at BuildCertPath.doBuild(BuildCertPath.java:414) > at BuildCertPath.main(BuildCertPath.java:139) > java.lang.NullPointerException: subjectPublicKey must be non-null > at > java.security.cert.PKIXCertPathValidatorResult.(PKIXCertPathValidatorResult.java:80) > > at > sun.security.provider.certpath.PKIXCertPathValidator.validate(PKIXCertPathValidator.java:215) > > at > sun.security.provider.certpath.PKIXCertPathValidator.validate(PKIXCertPathValidator.java:143) > > at > sun.security.provider.certpath.PKIXCertPathValidator.engineValidate(PKIXCertPathValidator.java:79) > > at > java.security.cert.CertPathValidator.validate(CertPathValidator.java:292) > at BuildCertPath.doBuild(BuildCertPath.java:414) > at BuildCertPath.main(BuildCertPath.java:139) > > Entry 1 nithya.srinivasan [2012-06-12 16:46] > > Evaluation > > A regression was introduced as part of the JEP 124 changes (6854712). It > only causes an exception if you are validating a zero-length CertPath. From xuelei.fan at oracle.com Thu Jun 14 19:28:50 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Fri, 15 Jun 2012 10:28:50 +0800 Subject: Code revire request: 6966259 (was Re: Avoid PrincipalName with realm == null) In-Reply-To: <4FD58227.4070709@oracle.com> References: <4FCFFC07.2090605@oracle.com> <4FD29778.9060907@oracle.com> <4FD58227.4070709@oracle.com> Message-ID: <4FDA9DE2.7080004@oracle.com> Looks fine to me. Just some minor comments. 1. PrincipalName.java need to make it more clear that PrincipalName is not only for the name of a principal, but also include the realm. - 48 * This class encapsulates a Kerberos principal. + 48 * This class encapsulates a Kerberos principal, + * including both of the realm and name of a principal. Or some other words like that. 2. KrbAppMessage.java No copyright date in the header. Other files have the header like "Copyright (c) 2000, 2011, Oracle and/or its affiliates. All rights reserved." 3. Realm.java 63 } catch (KrbException ke) { 64 RealmException re = new RealmException(ke.getMessage()); 65 re.initCause(ke); 66 throw re; 67 } I think you make a lot cleanup to exception thrown with just one call, like the one in KerberosPrincipal.java: - IOException ioe = new IOException(e.getMessage()); - ioe.initCause(e); - throw ioe; + throw new IOException(e); Would you like to use the same style for the update in Realm.java? Otherwise, looks fine to me. As there are too many changes, I would suggest you run a thoroughly testing before integration in case of any missing. Regards, Xuelei On 6/11/2012 1:29 PM, Weijun Wang wrote: > Hi Valerie > > Here is the webrev: > > http://cr.openjdk.java.net/~weijun/6966259/webrev.00/ > > The patch is quite long, but most of the real changes are in a few classes: > > PrincipalName.java: > . All fields are final and non-null non-empty now > . All constructors have a realm argument, including those from DER > . Add a new static method tgsService(r1, r2) to get AS/TGS name > . Remove ServiceName class > . New reg test: Constructors.java > > Realm.java: > . Field is now final > . New getDefault() method > > KDCReqBody.java: > . cname and sname share the same realm field. This is also the only > message format that realm comes after name. > > KrbKdcRep.java: > . Related to the class above. The check() method now has a new argument > isAsReq to deal with AS-REQ and TGS-REQ differently. The old code does > not check crealm equality, now both name and realm are checked, but only > for AS-REQ. For TGS-REQ, no more check for cname equality, this will be > useful for S4U2proxy where the cname of KDCRep comes from the additional > ticket in request. The old code checks if req.crealm is rep.srealm, > since KDCReqBody has only one realm field, this is the same as checking > req.srealm and rep.srealm. > > CCacheInputStream.java: > . readPrincipal returns null when there is no realm field. This has the > benefit that a ccache is readable even if there is no valid krb5 > setting. A normal ccache entry's principal should have its own realm > field. but when an entry is used to store non-ticket, returning null > won't trigger an exception. (See readCred about "X-CACHECONF:" style > entries) > > Other trivial code changes: > . Methods with the realm/name argument pair now has only name > . In parsing DER, read realm and then merge the info into name > . In encoding DER, encode the realm from name.getRealm() > . No need to check realm == null for name > . No need to print realm in debug output > . No need to call setRealm() > > Thanks > Max > > > On 06/09/2012 08:23 AM, Valerie (Yu-Ching) Peng wrote: >> Max, >> >> Yes, I think the current model that you described sounds error prone. I >> don't know the history of the current design. >> But I do also prefer the described changes that you have. >> I'd expect the refactoring would make the code clearer and more robust. >> >> Valerie >> >> On 06/06/12 17:55, Weijun Wang wrote: >>> Hi Valerie >>> >>> The krb5 PrincipalName class has a realm field and the class says >>> >>> If null, means the default realm >>> >>> Ideally this means if the realm of a name is null then this field can >>> be null. Otherwise, it must be filled when created. >>> >>> In fact, inside our codes, the field is often filled (using >>> setRealm()) after it's created. This leads to several strange coding >>> styles that make the codes confusing and error-prone. >>> >>> 1. a lot of setRealm() calls that's far from the creation of the >>> principal name only when the field needs to be used >>> 2. a lot of if (realm == null) checks >>> 3. a lot of "unresolved" names that never has a realm but is >>> definitely not in the default realm (just because the realm field is >>> not used inside JDK) >>> >>> I am planning to fix this to make the PrincipalName immutable and >>> always with a non-null non-empty realm. I also plan to make Realm >>> immutable and remove the ServiceName class (it's quite useless). >>> >>> A brief look into the code and protocol suggests this is quite >>> feasible. In every krb5 message and serialized data (I mean ccache and >>> keytab) defined, there is always a realm beside name. This is also >>> true for most Java methods. And I don't think a name with an >>> "unresolved" realm should exists at all. If we have to deal with >>> something like this, I'd rather invent a new class for it. >>> >>> The code change will be mostly refactoring, removing a lot of realm >>> arguments/fields and merging it into name. One behavior change is that >>> there will be no name with "unresolved" realm anymore, but I think >>> this should never be true in a real production environment. In fact, >>> the public API KerberosPrincipal has >>> >>> * @throws IllegalArgumentException if name is improperly >>> * formatted, if name is null, or if name does not contain >>> * the realm to use and the default realm is not specified >>> * in either a Kerberos configuration file or via the >>> * java.security.krb5.realm system property. >>> >>> What's your suggestion? I've been haunted by this several times, >>> mostly because a setRealm() is not called. >>> >>> Thanks >>> Max >> From weijun.wang at oracle.com Thu Jun 14 21:19:53 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 15 Jun 2012 12:19:53 +0800 Subject: Code revire request: 6966259 (was Re: Avoid PrincipalName with realm == null) In-Reply-To: <4FDA9DE2.7080004@oracle.com> References: <4FCFFC07.2090605@oracle.com> <4FD29778.9060907@oracle.com> <4FD58227.4070709@oracle.com> <4FDA9DE2.7080004@oracle.com> Message-ID: <4FDAB7E9.1060002@oracle.com> On 06/15/2012 10:28 AM, Xuelei Fan wrote: > Looks fine to me. Just some minor comments. > > 1. PrincipalName.java > need to make it more clear that PrincipalName is not only for the name > of a principal, but also include the realm. > > - 48 * This class encapsulates a Kerberos principal. > + 48 * This class encapsulates a Kerberos principal, > + * including both of the realm and name of a principal. > > Or some other words like that. Sure. > > 2. KrbAppMessage.java > No copyright date in the header. Other files have the header like > "Copyright (c) 2000, 2011, Oracle and/or its affiliates. All rights > reserved." Quite some other files (see krb5/internal) look the same. I remember I was told not to touch them. > > 3. Realm.java > 63 } catch (KrbException ke) { > 64 RealmException re = new RealmException(ke.getMessage()); > 65 re.initCause(ke); > 66 throw re; > 67 } > > I think you make a lot cleanup to exception thrown with just one call, > like the one in KerberosPrincipal.java: > - IOException ioe = new IOException(e.getMessage()); > - ioe.initCause(e); > - throw ioe; > + throw new IOException(e); > > Would you like to use the same style for the update in Realm.java? Unfortunately RealmException does not provide such a constructor. Are you suggesting me to create one? > > Otherwise, looks fine to me. > > As there are too many changes, I would suggest you run a thoroughly > testing before integration in case of any missing. Sure. Thanks Max > > Regards, > Xuelei > > > On 6/11/2012 1:29 PM, Weijun Wang wrote: >> Hi Valerie >> >> Here is the webrev: >> >> http://cr.openjdk.java.net/~weijun/6966259/webrev.00/ >> >> The patch is quite long, but most of the real changes are in a few classes: >> >> PrincipalName.java: >> . All fields are final and non-null non-empty now >> . All constructors have a realm argument, including those from DER >> . Add a new static method tgsService(r1, r2) to get AS/TGS name >> . Remove ServiceName class >> . New reg test: Constructors.java >> >> Realm.java: >> . Field is now final >> . New getDefault() method >> >> KDCReqBody.java: >> . cname and sname share the same realm field. This is also the only >> message format that realm comes after name. >> >> KrbKdcRep.java: >> . Related to the class above. The check() method now has a new argument >> isAsReq to deal with AS-REQ and TGS-REQ differently. The old code does >> not check crealm equality, now both name and realm are checked, but only >> for AS-REQ. For TGS-REQ, no more check for cname equality, this will be >> useful for S4U2proxy where the cname of KDCRep comes from the additional >> ticket in request. The old code checks if req.crealm is rep.srealm, >> since KDCReqBody has only one realm field, this is the same as checking >> req.srealm and rep.srealm. >> >> CCacheInputStream.java: >> . readPrincipal returns null when there is no realm field. This has the >> benefit that a ccache is readable even if there is no valid krb5 >> setting. A normal ccache entry's principal should have its own realm >> field. but when an entry is used to store non-ticket, returning null >> won't trigger an exception. (See readCred about "X-CACHECONF:" style >> entries) >> >> Other trivial code changes: >> . Methods with the realm/name argument pair now has only name >> . In parsing DER, read realm and then merge the info into name >> . In encoding DER, encode the realm from name.getRealm() >> . No need to check realm == null for name >> . No need to print realm in debug output >> . No need to call setRealm() >> >> Thanks >> Max >> >> >> On 06/09/2012 08:23 AM, Valerie (Yu-Ching) Peng wrote: >>> Max, >>> >>> Yes, I think the current model that you described sounds error prone. I >>> don't know the history of the current design. >>> But I do also prefer the described changes that you have. >>> I'd expect the refactoring would make the code clearer and more robust. >>> >>> Valerie >>> >>> On 06/06/12 17:55, Weijun Wang wrote: >>>> Hi Valerie >>>> >>>> The krb5 PrincipalName class has a realm field and the class says >>>> >>>> If null, means the default realm >>>> >>>> Ideally this means if the realm of a name is null then this field can >>>> be null. Otherwise, it must be filled when created. >>>> >>>> In fact, inside our codes, the field is often filled (using >>>> setRealm()) after it's created. This leads to several strange coding >>>> styles that make the codes confusing and error-prone. >>>> >>>> 1. a lot of setRealm() calls that's far from the creation of the >>>> principal name only when the field needs to be used >>>> 2. a lot of if (realm == null) checks >>>> 3. a lot of "unresolved" names that never has a realm but is >>>> definitely not in the default realm (just because the realm field is >>>> not used inside JDK) >>>> >>>> I am planning to fix this to make the PrincipalName immutable and >>>> always with a non-null non-empty realm. I also plan to make Realm >>>> immutable and remove the ServiceName class (it's quite useless). >>>> >>>> A brief look into the code and protocol suggests this is quite >>>> feasible. In every krb5 message and serialized data (I mean ccache and >>>> keytab) defined, there is always a realm beside name. This is also >>>> true for most Java methods. And I don't think a name with an >>>> "unresolved" realm should exists at all. If we have to deal with >>>> something like this, I'd rather invent a new class for it. >>>> >>>> The code change will be mostly refactoring, removing a lot of realm >>>> arguments/fields and merging it into name. One behavior change is that >>>> there will be no name with "unresolved" realm anymore, but I think >>>> this should never be true in a real production environment. In fact, >>>> the public API KerberosPrincipal has >>>> >>>> * @throws IllegalArgumentException if name is improperly >>>> * formatted, if name is null, or if name does not contain >>>> * the realm to use and the default realm is not specified >>>> * in either a Kerberos configuration file or via the >>>> * java.security.krb5.realm system property. >>>> >>>> What's your suggestion? I've been haunted by this several times, >>>> mostly because a setRealm() is not called. >>>> >>>> Thanks >>>> Max >>> > From xuelei.fan at oracle.com Thu Jun 14 22:01:09 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Fri, 15 Jun 2012 13:01:09 +0800 Subject: Code revire request: 6966259 (was Re: Avoid PrincipalName with realm == null) In-Reply-To: <4FDAB7E9.1060002@oracle.com> References: <4FCFFC07.2090605@oracle.com> <4FD29778.9060907@oracle.com> <4FD58227.4070709@oracle.com> <4FDA9DE2.7080004@oracle.com> <4FDAB7E9.1060002@oracle.com> Message-ID: <4FDAC195.9010701@oracle.com> On 6/15/2012 12:19 PM, Weijun Wang wrote: > > > On 06/15/2012 10:28 AM, Xuelei Fan wrote: >> Looks fine to me. Just some minor comments. >> >> 1. PrincipalName.java >> need to make it more clear that PrincipalName is not only for the name >> of a principal, but also include the realm. >> >> - 48 * This class encapsulates a Kerberos principal. >> + 48 * This class encapsulates a Kerberos principal, >> + * including both of the realm and name of a principal. >> >> Or some other words like that. > > Sure. > >> >> 2. KrbAppMessage.java >> No copyright date in the header. Other files have the header like >> "Copyright (c) 2000, 2011, Oracle and/or its affiliates. All rights >> reserved." > > Quite some other files (see krb5/internal) look the same. I remember I > was told not to touch them. > OK. >> >> 3. Realm.java >> 63 } catch (KrbException ke) { >> 64 RealmException re = new RealmException(ke.getMessage()); >> 65 re.initCause(ke); >> 66 throw re; >> 67 } >> >> I think you make a lot cleanup to exception thrown with just one call, >> like the one in KerberosPrincipal.java: >> - IOException ioe = new IOException(e.getMessage()); >> - ioe.initCause(e); >> - throw ioe; >> + throw new IOException(e); >> >> Would you like to use the same style for the update in Realm.java? > > Unfortunately RealmException does not provide such a constructor. Are > you suggesting me to create one? > Why not? I think a Exception class should always have such constructor. Xuelei >> >> Otherwise, looks fine to me. >> >> As there are too many changes, I would suggest you run a thoroughly >> testing before integration in case of any missing. > > Sure. > > Thanks > Max > >> >> Regards, >> Xuelei >> >> >> On 6/11/2012 1:29 PM, Weijun Wang wrote: >>> Hi Valerie >>> >>> Here is the webrev: >>> >>> http://cr.openjdk.java.net/~weijun/6966259/webrev.00/ >>> >>> The patch is quite long, but most of the real changes are in a few >>> classes: >>> >>> PrincipalName.java: >>> . All fields are final and non-null non-empty now >>> . All constructors have a realm argument, including those from DER >>> . Add a new static method tgsService(r1, r2) to get AS/TGS name >>> . Remove ServiceName class >>> . New reg test: Constructors.java >>> >>> Realm.java: >>> . Field is now final >>> . New getDefault() method >>> >>> KDCReqBody.java: >>> . cname and sname share the same realm field. This is also the only >>> message format that realm comes after name. >>> >>> KrbKdcRep.java: >>> . Related to the class above. The check() method now has a new argument >>> isAsReq to deal with AS-REQ and TGS-REQ differently. The old code does >>> not check crealm equality, now both name and realm are checked, but only >>> for AS-REQ. For TGS-REQ, no more check for cname equality, this will be >>> useful for S4U2proxy where the cname of KDCRep comes from the additional >>> ticket in request. The old code checks if req.crealm is rep.srealm, >>> since KDCReqBody has only one realm field, this is the same as checking >>> req.srealm and rep.srealm. >>> >>> CCacheInputStream.java: >>> . readPrincipal returns null when there is no realm field. This has the >>> benefit that a ccache is readable even if there is no valid krb5 >>> setting. A normal ccache entry's principal should have its own realm >>> field. but when an entry is used to store non-ticket, returning null >>> won't trigger an exception. (See readCred about "X-CACHECONF:" style >>> entries) >>> >>> Other trivial code changes: >>> . Methods with the realm/name argument pair now has only name >>> . In parsing DER, read realm and then merge the info into name >>> . In encoding DER, encode the realm from name.getRealm() >>> . No need to check realm == null for name >>> . No need to print realm in debug output >>> . No need to call setRealm() >>> >>> Thanks >>> Max >>> >>> >>> On 06/09/2012 08:23 AM, Valerie (Yu-Ching) Peng wrote: >>>> Max, >>>> >>>> Yes, I think the current model that you described sounds error prone. I >>>> don't know the history of the current design. >>>> But I do also prefer the described changes that you have. >>>> I'd expect the refactoring would make the code clearer and more robust. >>>> >>>> Valerie >>>> >>>> On 06/06/12 17:55, Weijun Wang wrote: >>>>> Hi Valerie >>>>> >>>>> The krb5 PrincipalName class has a realm field and the class says >>>>> >>>>> If null, means the default realm >>>>> >>>>> Ideally this means if the realm of a name is null then this field can >>>>> be null. Otherwise, it must be filled when created. >>>>> >>>>> In fact, inside our codes, the field is often filled (using >>>>> setRealm()) after it's created. This leads to several strange coding >>>>> styles that make the codes confusing and error-prone. >>>>> >>>>> 1. a lot of setRealm() calls that's far from the creation of the >>>>> principal name only when the field needs to be used >>>>> 2. a lot of if (realm == null) checks >>>>> 3. a lot of "unresolved" names that never has a realm but is >>>>> definitely not in the default realm (just because the realm field is >>>>> not used inside JDK) >>>>> >>>>> I am planning to fix this to make the PrincipalName immutable and >>>>> always with a non-null non-empty realm. I also plan to make Realm >>>>> immutable and remove the ServiceName class (it's quite useless). >>>>> >>>>> A brief look into the code and protocol suggests this is quite >>>>> feasible. In every krb5 message and serialized data (I mean ccache and >>>>> keytab) defined, there is always a realm beside name. This is also >>>>> true for most Java methods. And I don't think a name with an >>>>> "unresolved" realm should exists at all. If we have to deal with >>>>> something like this, I'd rather invent a new class for it. >>>>> >>>>> The code change will be mostly refactoring, removing a lot of realm >>>>> arguments/fields and merging it into name. One behavior change is that >>>>> there will be no name with "unresolved" realm anymore, but I think >>>>> this should never be true in a real production environment. In fact, >>>>> the public API KerberosPrincipal has >>>>> >>>>> * @throws IllegalArgumentException if name is improperly >>>>> * formatted, if name is null, or if name does not contain >>>>> * the realm to use and the default realm is not specified >>>>> * in either a Kerberos configuration file or via the >>>>> * java.security.krb5.realm system property. >>>>> >>>>> What's your suggestion? I've been haunted by this several times, >>>>> mostly because a setRealm() is not called. >>>>> >>>>> Thanks >>>>> Max >>>> >> From weijun.wang at oracle.com Thu Jun 14 23:13:16 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 15 Jun 2012 14:13:16 +0800 Subject: Code revire request: 6966259 (was Re: Avoid PrincipalName with realm == null) In-Reply-To: <4FDAC195.9010701@oracle.com> References: <4FCFFC07.2090605@oracle.com> <4FD29778.9060907@oracle.com> <4FD58227.4070709@oracle.com> <4FDA9DE2.7080004@oracle.com> <4FDAB7E9.1060002@oracle.com> <4FDAC195.9010701@oracle.com> Message-ID: <4FDAD27C.3060401@oracle.com> >>> 3. Realm.java >>> 63 } catch (KrbException ke) { >>> 64 RealmException re = new RealmException(ke.getMessage()); >>> 65 re.initCause(ke); >>> 66 throw re; >>> 67 } >>> >>> I think you make a lot cleanup to exception thrown with just one call, >>> like the one in KerberosPrincipal.java: >>> - IOException ioe = new IOException(e.getMessage()); >>> - ioe.initCause(e); >>> - throw ioe; >>> + throw new IOException(e); >>> >>> Would you like to use the same style for the update in Realm.java? >> >> Unfortunately RealmException does not provide such a constructor. Are >> you suggesting me to create one? >> > Why not? I think a Exception class should always have such constructor. Good. -Max > > Xuelei From weijun.wang at oracle.com Fri Jun 15 00:59:20 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 15 Jun 2012 15:59:20 +0800 Subject: Code revire request: 6966259 (was Re: Avoid PrincipalName with realm == null) In-Reply-To: <4FDAC195.9010701@oracle.com> References: <4FCFFC07.2090605@oracle.com> <4FD29778.9060907@oracle.com> <4FD58227.4070709@oracle.com> <4FDA9DE2.7080004@oracle.com> <4FDAB7E9.1060002@oracle.com> <4FDAC195.9010701@oracle.com> Message-ID: <4FDAEB58.7060204@oracle.com> Webrev updated: http://cr.openjdk.java.net/~weijun/6966259/webrev.01/ Changes made: test/sun/security/krb5/name/Constructors.java src/share/classes/sun/security/krb5/RealmException.java src/share/classes/sun/security/krb5/Realm.java src/share/classes/sun/security/krb5/PrincipalName.java src/share/classes/sun/security/krb5/KrbException.java 1. New constructors for KrbException and RealmException that takes Throwable as an argument. 2. In PrincipalName.java: More comments in PrincipalName, and 3. Consolidate all nameStrings check into a separate method static void validateNameStrings(String[] ns) and make sure it's called by all basic constructors. Also, remove all other duplicate checks. 4. Small changes in parseName(String), say - if (componentStart < i) { + if (componentStart <= i) { and - if (componentStart < i) { to make sure that names like "a//b" and "a/" are rejected. 5. Remove "equals(PrincipalName other)". I guess it was only used to compare a PrincipalName and a ServiceName. Also, parseName() is now private. 6. In Realm.java: parseRealmAtSeparator(String). A small change to make sure a name like "a@" is treated as illegal but not silently bypassed. 7. Updating the Constructors regression test to check for illegal names. Thanks Max On 06/15/2012 01:01 PM, Xuelei Fan wrote: > On 6/15/2012 12:19 PM, Weijun Wang wrote: >> >> >> On 06/15/2012 10:28 AM, Xuelei Fan wrote: >>> Looks fine to me. Just some minor comments. >>> >>> 1. PrincipalName.java >>> need to make it more clear that PrincipalName is not only for the name >>> of a principal, but also include the realm. >>> >>> - 48 * This class encapsulates a Kerberos principal. >>> + 48 * This class encapsulates a Kerberos principal, >>> + * including both of the realm and name of a principal. >>> >>> Or some other words like that. >> >> Sure. >> >>> >>> 2. KrbAppMessage.java >>> No copyright date in the header. Other files have the header like >>> "Copyright (c) 2000, 2011, Oracle and/or its affiliates. All rights >>> reserved." >> >> Quite some other files (see krb5/internal) look the same. I remember I >> was told not to touch them. >> > OK. > >>> >>> 3. Realm.java >>> 63 } catch (KrbException ke) { >>> 64 RealmException re = new RealmException(ke.getMessage()); >>> 65 re.initCause(ke); >>> 66 throw re; >>> 67 } >>> >>> I think you make a lot cleanup to exception thrown with just one call, >>> like the one in KerberosPrincipal.java: >>> - IOException ioe = new IOException(e.getMessage()); >>> - ioe.initCause(e); >>> - throw ioe; >>> + throw new IOException(e); >>> >>> Would you like to use the same style for the update in Realm.java? >> >> Unfortunately RealmException does not provide such a constructor. Are >> you suggesting me to create one? >> > Why not? I think a Exception class should always have such constructor. > > Xuelei > >>> >>> Otherwise, looks fine to me. >>> >>> As there are too many changes, I would suggest you run a thoroughly >>> testing before integration in case of any missing. >> >> Sure. >> >> Thanks >> Max >> >>> >>> Regards, >>> Xuelei >>> >>> >>> On 6/11/2012 1:29 PM, Weijun Wang wrote: >>>> Hi Valerie >>>> >>>> Here is the webrev: >>>> >>>> http://cr.openjdk.java.net/~weijun/6966259/webrev.00/ >>>> >>>> The patch is quite long, but most of the real changes are in a few >>>> classes: >>>> >>>> PrincipalName.java: >>>> . All fields are final and non-null non-empty now >>>> . All constructors have a realm argument, including those from DER >>>> . Add a new static method tgsService(r1, r2) to get AS/TGS name >>>> . Remove ServiceName class >>>> . New reg test: Constructors.java >>>> >>>> Realm.java: >>>> . Field is now final >>>> . New getDefault() method >>>> >>>> KDCReqBody.java: >>>> . cname and sname share the same realm field. This is also the only >>>> message format that realm comes after name. >>>> >>>> KrbKdcRep.java: >>>> . Related to the class above. The check() method now has a new argument >>>> isAsReq to deal with AS-REQ and TGS-REQ differently. The old code does >>>> not check crealm equality, now both name and realm are checked, but only >>>> for AS-REQ. For TGS-REQ, no more check for cname equality, this will be >>>> useful for S4U2proxy where the cname of KDCRep comes from the additional >>>> ticket in request. The old code checks if req.crealm is rep.srealm, >>>> since KDCReqBody has only one realm field, this is the same as checking >>>> req.srealm and rep.srealm. >>>> >>>> CCacheInputStream.java: >>>> . readPrincipal returns null when there is no realm field. This has the >>>> benefit that a ccache is readable even if there is no valid krb5 >>>> setting. A normal ccache entry's principal should have its own realm >>>> field. but when an entry is used to store non-ticket, returning null >>>> won't trigger an exception. (See readCred about "X-CACHECONF:" style >>>> entries) >>>> >>>> Other trivial code changes: >>>> . Methods with the realm/name argument pair now has only name >>>> . In parsing DER, read realm and then merge the info into name >>>> . In encoding DER, encode the realm from name.getRealm() >>>> . No need to check realm == null for name >>>> . No need to print realm in debug output >>>> . No need to call setRealm() >>>> >>>> Thanks >>>> Max >>>> >>>> >>>> On 06/09/2012 08:23 AM, Valerie (Yu-Ching) Peng wrote: >>>>> Max, >>>>> >>>>> Yes, I think the current model that you described sounds error prone. I >>>>> don't know the history of the current design. >>>>> But I do also prefer the described changes that you have. >>>>> I'd expect the refactoring would make the code clearer and more robust. >>>>> >>>>> Valerie >>>>> >>>>> On 06/06/12 17:55, Weijun Wang wrote: >>>>>> Hi Valerie >>>>>> >>>>>> The krb5 PrincipalName class has a realm field and the class says >>>>>> >>>>>> If null, means the default realm >>>>>> >>>>>> Ideally this means if the realm of a name is null then this field can >>>>>> be null. Otherwise, it must be filled when created. >>>>>> >>>>>> In fact, inside our codes, the field is often filled (using >>>>>> setRealm()) after it's created. This leads to several strange coding >>>>>> styles that make the codes confusing and error-prone. >>>>>> >>>>>> 1. a lot of setRealm() calls that's far from the creation of the >>>>>> principal name only when the field needs to be used >>>>>> 2. a lot of if (realm == null) checks >>>>>> 3. a lot of "unresolved" names that never has a realm but is >>>>>> definitely not in the default realm (just because the realm field is >>>>>> not used inside JDK) >>>>>> >>>>>> I am planning to fix this to make the PrincipalName immutable and >>>>>> always with a non-null non-empty realm. I also plan to make Realm >>>>>> immutable and remove the ServiceName class (it's quite useless). >>>>>> >>>>>> A brief look into the code and protocol suggests this is quite >>>>>> feasible. In every krb5 message and serialized data (I mean ccache and >>>>>> keytab) defined, there is always a realm beside name. This is also >>>>>> true for most Java methods. And I don't think a name with an >>>>>> "unresolved" realm should exists at all. If we have to deal with >>>>>> something like this, I'd rather invent a new class for it. >>>>>> >>>>>> The code change will be mostly refactoring, removing a lot of realm >>>>>> arguments/fields and merging it into name. One behavior change is that >>>>>> there will be no name with "unresolved" realm anymore, but I think >>>>>> this should never be true in a real production environment. In fact, >>>>>> the public API KerberosPrincipal has >>>>>> >>>>>> * @throws IllegalArgumentException if name is improperly >>>>>> * formatted, if name is null, or if name does not contain >>>>>> * the realm to use and the default realm is not specified >>>>>> * in either a Kerberos configuration file or via the >>>>>> * java.security.krb5.realm system property. >>>>>> >>>>>> What's your suggestion? I've been haunted by this several times, >>>>>> mostly because a setRealm() is not called. >>>>>> >>>>>> Thanks >>>>>> Max >>>>> >>> > From kdriver at us.ibm.com Fri Jun 15 01:05:55 2012 From: kdriver at us.ibm.com (Kevin T Driver) Date: Fri, 15 Jun 2012 04:05:55 -0400 Subject: AUTO: Kevin T Driver is out of the office. (returning 06/25/2012) Message-ID: I am out of the office until 06/25/2012. I will respond to your message when I return. Please contact Lisbeth Arriaza for L2 support requests. Please contact Audrey Timkovich for urgent support requests of the Java Security team or JCE specific issues. Please contact Ralph Snow for ITSAS concerns. Note: This is an automated response to your message "security-dev Digest, Vol 60, Issue 18" sent on 06/15/2012 1:01:19. This is the only notification you will receive while this person is away. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20120615/60e970c6/attachment.html From xuelei.fan at oracle.com Fri Jun 15 02:06:24 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Fri, 15 Jun 2012 17:06:24 +0800 Subject: Code revire request: 6966259 (was Re: Avoid PrincipalName with realm == null) In-Reply-To: <4FDAEB58.7060204@oracle.com> References: <4FCFFC07.2090605@oracle.com> <4FD29778.9060907@oracle.com> <4FD58227.4070709@oracle.com> <4FDA9DE2.7080004@oracle.com> <4FDAB7E9.1060002@oracle.com> <4FDAC195.9010701@oracle.com> <4FDAEB58.7060204@oracle.com> Message-ID: <4FDAFB10.1040006@oracle.com> Looks fine to me. Thanks, Xuelei On 6/15/2012 3:59 PM, Weijun Wang wrote: > Webrev updated: > > http://cr.openjdk.java.net/~weijun/6966259/webrev.01/ > > Changes made: > > test/sun/security/krb5/name/Constructors.java > src/share/classes/sun/security/krb5/RealmException.java > src/share/classes/sun/security/krb5/Realm.java > src/share/classes/sun/security/krb5/PrincipalName.java > src/share/classes/sun/security/krb5/KrbException.java > > 1. New constructors for KrbException and RealmException that takes > Throwable as an argument. > > 2. In PrincipalName.java: More comments in PrincipalName, and > > 3. Consolidate all nameStrings check into a separate method > > static void validateNameStrings(String[] ns) > > and make sure it's called by all basic constructors. Also, remove all > other duplicate checks. > > 4. Small changes in parseName(String), say > > - if (componentStart < i) { > + if (componentStart <= i) { > > and > > - if (componentStart < i) { > > to make sure that names like "a//b" and "a/" are rejected. > > 5. Remove "equals(PrincipalName other)". I guess it was only used to > compare a PrincipalName and a ServiceName. Also, parseName() is now > private. > > 6. In Realm.java: parseRealmAtSeparator(String). A small change to make > sure a name like "a@" is treated as illegal but not silently bypassed. > > 7. Updating the Constructors regression test to check for illegal names. > > Thanks > Max > > > On 06/15/2012 01:01 PM, Xuelei Fan wrote: >> On 6/15/2012 12:19 PM, Weijun Wang wrote: >>> >>> >>> On 06/15/2012 10:28 AM, Xuelei Fan wrote: >>>> Looks fine to me. Just some minor comments. >>>> >>>> 1. PrincipalName.java >>>> need to make it more clear that PrincipalName is not only for the name >>>> of a principal, but also include the realm. >>>> >>>> - 48 * This class encapsulates a Kerberos principal. >>>> + 48 * This class encapsulates a Kerberos principal, >>>> + * including both of the realm and name of a principal. >>>> >>>> Or some other words like that. >>> >>> Sure. >>> >>>> >>>> 2. KrbAppMessage.java >>>> No copyright date in the header. Other files have the header like >>>> "Copyright (c) 2000, 2011, Oracle and/or its affiliates. All rights >>>> reserved." >>> >>> Quite some other files (see krb5/internal) look the same. I remember I >>> was told not to touch them. >>> >> OK. >> >>>> >>>> 3. Realm.java >>>> 63 } catch (KrbException ke) { >>>> 64 RealmException re = new RealmException(ke.getMessage()); >>>> 65 re.initCause(ke); >>>> 66 throw re; >>>> 67 } >>>> >>>> I think you make a lot cleanup to exception thrown with just one call, >>>> like the one in KerberosPrincipal.java: >>>> - IOException ioe = new IOException(e.getMessage()); >>>> - ioe.initCause(e); >>>> - throw ioe; >>>> + throw new IOException(e); >>>> >>>> Would you like to use the same style for the update in Realm.java? >>> >>> Unfortunately RealmException does not provide such a constructor. Are >>> you suggesting me to create one? >>> >> Why not? I think a Exception class should always have such constructor. >> >> Xuelei >> >>>> >>>> Otherwise, looks fine to me. >>>> >>>> As there are too many changes, I would suggest you run a thoroughly >>>> testing before integration in case of any missing. >>> >>> Sure. >>> >>> Thanks >>> Max >>> >>>> >>>> Regards, >>>> Xuelei >>>> >>>> >>>> On 6/11/2012 1:29 PM, Weijun Wang wrote: >>>>> Hi Valerie >>>>> >>>>> Here is the webrev: >>>>> >>>>> http://cr.openjdk.java.net/~weijun/6966259/webrev.00/ >>>>> >>>>> The patch is quite long, but most of the real changes are in a few >>>>> classes: >>>>> >>>>> PrincipalName.java: >>>>> . All fields are final and non-null non-empty now >>>>> . All constructors have a realm argument, including those from DER >>>>> . Add a new static method tgsService(r1, r2) to get AS/TGS name >>>>> . Remove ServiceName class >>>>> . New reg test: Constructors.java >>>>> >>>>> Realm.java: >>>>> . Field is now final >>>>> . New getDefault() method >>>>> >>>>> KDCReqBody.java: >>>>> . cname and sname share the same realm field. This is also the only >>>>> message format that realm comes after name. >>>>> >>>>> KrbKdcRep.java: >>>>> . Related to the class above. The check() method now has a new >>>>> argument >>>>> isAsReq to deal with AS-REQ and TGS-REQ differently. The old code does >>>>> not check crealm equality, now both name and realm are checked, but >>>>> only >>>>> for AS-REQ. For TGS-REQ, no more check for cname equality, this >>>>> will be >>>>> useful for S4U2proxy where the cname of KDCRep comes from the >>>>> additional >>>>> ticket in request. The old code checks if req.crealm is rep.srealm, >>>>> since KDCReqBody has only one realm field, this is the same as >>>>> checking >>>>> req.srealm and rep.srealm. >>>>> >>>>> CCacheInputStream.java: >>>>> . readPrincipal returns null when there is no realm field. This has >>>>> the >>>>> benefit that a ccache is readable even if there is no valid krb5 >>>>> setting. A normal ccache entry's principal should have its own realm >>>>> field. but when an entry is used to store non-ticket, returning null >>>>> won't trigger an exception. (See readCred about "X-CACHECONF:" style >>>>> entries) >>>>> >>>>> Other trivial code changes: >>>>> . Methods with the realm/name argument pair now has only name >>>>> . In parsing DER, read realm and then merge the info into name >>>>> . In encoding DER, encode the realm from name.getRealm() >>>>> . No need to check realm == null for name >>>>> . No need to print realm in debug output >>>>> . No need to call setRealm() >>>>> >>>>> Thanks >>>>> Max >>>>> >>>>> >>>>> On 06/09/2012 08:23 AM, Valerie (Yu-Ching) Peng wrote: >>>>>> Max, >>>>>> >>>>>> Yes, I think the current model that you described sounds error >>>>>> prone. I >>>>>> don't know the history of the current design. >>>>>> But I do also prefer the described changes that you have. >>>>>> I'd expect the refactoring would make the code clearer and more >>>>>> robust. >>>>>> >>>>>> Valerie >>>>>> >>>>>> On 06/06/12 17:55, Weijun Wang wrote: >>>>>>> Hi Valerie >>>>>>> >>>>>>> The krb5 PrincipalName class has a realm field and the class says >>>>>>> >>>>>>> If null, means the default realm >>>>>>> >>>>>>> Ideally this means if the realm of a name is null then this field >>>>>>> can >>>>>>> be null. Otherwise, it must be filled when created. >>>>>>> >>>>>>> In fact, inside our codes, the field is often filled (using >>>>>>> setRealm()) after it's created. This leads to several strange coding >>>>>>> styles that make the codes confusing and error-prone. >>>>>>> >>>>>>> 1. a lot of setRealm() calls that's far from the creation of the >>>>>>> principal name only when the field needs to be used >>>>>>> 2. a lot of if (realm == null) checks >>>>>>> 3. a lot of "unresolved" names that never has a realm but is >>>>>>> definitely not in the default realm (just because the realm field is >>>>>>> not used inside JDK) >>>>>>> >>>>>>> I am planning to fix this to make the PrincipalName immutable and >>>>>>> always with a non-null non-empty realm. I also plan to make Realm >>>>>>> immutable and remove the ServiceName class (it's quite useless). >>>>>>> >>>>>>> A brief look into the code and protocol suggests this is quite >>>>>>> feasible. In every krb5 message and serialized data (I mean >>>>>>> ccache and >>>>>>> keytab) defined, there is always a realm beside name. This is also >>>>>>> true for most Java methods. And I don't think a name with an >>>>>>> "unresolved" realm should exists at all. If we have to deal with >>>>>>> something like this, I'd rather invent a new class for it. >>>>>>> >>>>>>> The code change will be mostly refactoring, removing a lot of realm >>>>>>> arguments/fields and merging it into name. One behavior change is >>>>>>> that >>>>>>> there will be no name with "unresolved" realm anymore, but I think >>>>>>> this should never be true in a real production environment. In fact, >>>>>>> the public API KerberosPrincipal has >>>>>>> >>>>>>> * @throws IllegalArgumentException if name is improperly >>>>>>> * formatted, if name is null, or if name does not contain >>>>>>> * the realm to use and the default realm is not specified >>>>>>> * in either a Kerberos configuration file or via the >>>>>>> * java.security.krb5.realm system property. >>>>>>> >>>>>>> What's your suggestion? I've been haunted by this several times, >>>>>>> mostly because a setRealm() is not called. >>>>>>> >>>>>>> Thanks >>>>>>> Max >>>>>> >>>> >> From sean.coffey at oracle.com Fri Jun 15 06:14:24 2012 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Fri, 15 Jun 2012 13:14:24 +0000 Subject: hg: jdk8/tl/jdk: 7156963: Incorrect copyright header in java/io/SerialCallbackContext Message-ID: <20120615131455.5BFD04795D@hg.openjdk.java.net> Changeset: 00c9d6cce3ec Author: coffeys Date: 2012-06-15 14:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/00c9d6cce3ec 7156963: Incorrect copyright header in java/io/SerialCallbackContext Reviewed-by: weijun, coffeys Contributed-by: edvard.wendelin at oracle.com ! src/share/classes/java/io/SerialCallbackContext.java From sean.mullan at oracle.com Fri Jun 15 06:16:33 2012 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Fri, 15 Jun 2012 13:16:33 +0000 Subject: hg: jdk8/tl/jdk: 3 new changesets Message-ID: <20120615131706.2B31E4795E@hg.openjdk.java.net> Changeset: 8deec0d1fc6f Author: mullan Date: 2012-06-15 08:43 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8deec0d1fc6f 7176326: CertPath/CertPathBuilderTest failures after webrev 6854712_6637288_7126011 Reviewed-by: xuelei ! src/share/classes/sun/security/provider/certpath/BasicChecker.java + test/java/security/cert/CertPathBuilder/zeroLengthPath/ZeroLengthPath.java Changeset: 0e382512610f Author: mullan Date: 2012-06-15 08:47 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e382512610f Merge Changeset: e01b47409e37 Author: mullan Date: 2012-06-15 09:16 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e01b47409e37 Merge From alan.bateman at oracle.com Fri Jun 15 09:20:55 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 15 Jun 2012 16:20:55 +0000 Subject: hg: jdk8/tl/jdk: 7176485: (bf) Allow temporary buffer cache to grow to IOV_MAX Message-ID: <20120615162128.55ECF47962@hg.openjdk.java.net> Changeset: 23394d686f74 Author: alanb Date: 2012-06-15 17:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23394d686f74 7176485: (bf) Allow temporary buffer cache to grow to IOV_MAX Reviewed-by: chegar, coffeys ! make/java/nio/mapfile-linux ! make/java/nio/mapfile-solaris ! src/share/classes/sun/nio/ch/IOUtil.java ! src/share/classes/sun/nio/ch/Util.java ! src/solaris/native/sun/nio/ch/FileDispatcherImpl.c ! src/solaris/native/sun/nio/ch/IOUtil.c ! src/windows/native/sun/nio/ch/IOUtil.c ! src/windows/native/sun/nio/ch/SocketDispatcher.c ! src/windows/native/sun/nio/ch/nio_util.h From a.atapin at gmail.com Fri Jun 15 04:49:16 2012 From: a.atapin at gmail.com (Andrey Atapin) Date: Fri, 15 Jun 2012 17:49:16 +0600 Subject: How to detect if a PKCS11 token presents in a system? Message-ID: Hello, Right now I'm solving this problem by calling 'getMechanismsList' on the PKCS11 wrapper object. Considering that Windows x86-64 doesn't have PKCS11 support in Java, code becomes more tricky, because I have to instantiate all objects via reflection. Is it possible to avoid using such tricks and detect a token presence/removal in a more straightforward way? Sincerely, Andrey Atapin. From mike.duigou at oracle.com Fri Jun 15 14:32:53 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Fri, 15 Jun 2012 21:32:53 +0000 Subject: hg: jdk8/tl/jdk: 7175758: Improve unit test of Map iterators and Iterator.remove() Message-ID: <20120615213315.042A24796C@hg.openjdk.java.net> Changeset: e60cedd3a4aa Author: mduigou Date: 2012-06-15 13:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e60cedd3a4aa 7175758: Improve unit test of Map iterators and Iterator.remove() Summary: Adds additional tests of Map iterators and Iterator.remove() Reviewed-by: lancea ! test/java/util/Map/Collisions.java From bradford.wetmore at oracle.com Fri Jun 15 17:25:18 2012 From: bradford.wetmore at oracle.com (Brad Wetmore) Date: Fri, 15 Jun 2012 17:25:18 -0700 Subject: Codereview for 7177556 Message-ID: <4FDBD26E.8010604@oracle.com> This test has started failing in JDK nightly. We were working on it this week, but test approach may need alteration. Putting this test on ProblemList.txt for the time being to quiet the test noise. 7177556: Put TestProviderLeak.java on the ProblemList until test can be reworked http://cr.openjdk.java.net/~wetmore/7177556/ Brad From kurchi.subhra.hazra at oracle.com Fri Jun 15 17:35:30 2012 From: kurchi.subhra.hazra at oracle.com (Kurchi Hazra) Date: Fri, 15 Jun 2012 17:35:30 -0700 Subject: Codereview for 7177556 In-Reply-To: <4FDBD26E.8010604@oracle.com> References: <4FDBD26E.8010604@oracle.com> Message-ID: <4FDBD4D2.6040001@oracle.com> Hi Brad, This looks fine to me. Thanks, Kurchi On 6/15/2012 5:25 PM, Brad Wetmore wrote: > This test has started failing in JDK nightly. We were working on it > this week, but test approach may need alteration. Putting this test > on ProblemList.txt for the time being to quiet the test noise. > > 7177556: Put TestProviderLeak.java on the ProblemList until test can > be reworked > > http://cr.openjdk.java.net/~wetmore/7177556/ > > Brad -- -Kurchi From bradford.wetmore at oracle.com Fri Jun 15 17:43:02 2012 From: bradford.wetmore at oracle.com (bradford.wetmore at oracle.com) Date: Sat, 16 Jun 2012 00:43:02 +0000 Subject: hg: jdk8/tl/jdk: 7177556: Put TestProviderLeak.java on the ProblemList until test can be reworked Message-ID: <20120616004321.8A7C447972@hg.openjdk.java.net> Changeset: 8e5635ded425 Author: wetmore Date: 2012-06-15 17:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8e5635ded425 7177556: Put TestProviderLeak.java on the ProblemList until test can be reworked Reviewed-by: khazra ! test/ProblemList.txt From mstjohns at comcast.net Sat Jun 16 21:18:20 2012 From: mstjohns at comcast.net (Michael StJohns) Date: Sun, 17 Jun 2012 00:18:20 -0400 Subject: How to detect if a PKCS11 token presents in a system? In-Reply-To: References: Message-ID: <8A6474DE-D1FB-4EF7-96A2-7864C2AAA59D@comcast.net> C_GetSlotInfo will tell you whether or not there is a token in the slot. Sent from my iPad On Jun 15, 2012, at 7:49, Andrey Atapin wrote: > Hello, > Right now I'm solving this problem by calling 'getMechanismsList' on > the PKCS11 wrapper object. Considering that Windows x86-64 doesn't > have PKCS11 support in Java, code becomes more tricky, because I have > to instantiate all objects via reflection. Is it possible to avoid > using such tricks and detect a token presence/removal in a more > straightforward way? > > Sincerely, > Andrey Atapin. From lana.steuck at oracle.com Sun Jun 17 23:38:48 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 18 Jun 2012 06:38:48 +0000 Subject: hg: jdk8/tl: 8 new changesets Message-ID: <20120618063849.546B147997@hg.openjdk.java.net> Changeset: dac58047c19f Author: cl Date: 2012-06-07 12:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/dac58047c19f Added tag jdk8-b42 for changeset 1ce5dc164166 ! .hgtags Changeset: 6aea9b1a3840 Author: lana Date: 2012-06-08 12:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/6aea9b1a3840 Merge Changeset: efd26e051e50 Author: erikj Date: 2012-06-07 20:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/efd26e051e50 7170079: Adjustments to build-infra makefiles Reviewed-by: ohair, ohrstrom, ihse, jonas Contributed-by: jonas , erikj , ihse , tgranat , ykantser ! README-builds.html ! common/autoconf/autogen.sh ! common/autoconf/builddeps.m4 ! common/autoconf/configure ! common/autoconf/configure.ac ! common/autoconf/help.m4 ! common/autoconf/platform.m4 ! common/autoconf/spec.gmk.in ! common/bin/compareimage.sh ! common/bin/diffexec.sh ! common/bin/diffjarzip.sh ! common/bin/difflib.sh ! common/bin/logger.sh ! common/makefiles/JavaCompilation.gmk ! common/makefiles/MakeBase.gmk ! common/makefiles/Makefile ! common/makefiles/NativeCompilation.gmk Changeset: dd596160b323 Author: ohair Date: 2012-06-08 17:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/dd596160b323 7170091: Fix missing wait between repo cloning in hgforest.sh Reviewed-by: strarup ! make/scripts/hgforest.sh Changeset: c61921f9b965 Author: ohair Date: 2012-06-08 17:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/c61921f9b965 Merge Changeset: 661c9aae602b Author: katleman Date: 2012-06-13 16:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/661c9aae602b Merge Changeset: 02c6c67c1bb7 Author: katleman Date: 2012-06-14 13:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/02c6c67c1bb7 Added tag jdk8-b43 for changeset 661c9aae602b ! .hgtags Changeset: 67e1fb3b2b33 Author: lana Date: 2012-06-17 21:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/67e1fb3b2b33 Merge From lana.steuck at oracle.com Sun Jun 17 23:38:48 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 18 Jun 2012 06:38:48 +0000 Subject: hg: jdk8/tl/corba: 5 new changesets Message-ID: <20120618063856.1480747998@hg.openjdk.java.net> Changeset: 4def0723b0b0 Author: cl Date: 2012-06-07 12:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/4def0723b0b0 Added tag jdk8-b42 for changeset 79cc42c9c71b ! .hgtags Changeset: 0c0b50c7b76a Author: erikj Date: 2012-06-07 20:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/0c0b50c7b76a 7170079: Adjustments to build-infra makefiles Reviewed-by: ohair, ohrstrom, ihse, jonas Contributed-by: jonas , erikj , ihse , tgranat , ykantser ! makefiles/Makefile Changeset: a1f721fbe5d0 Author: ohair Date: 2012-06-13 09:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/a1f721fbe5d0 7176691: prtconf: devinfo facility not available in corba building Reviewed-by: tbell ! make/common/shared/Platform.gmk Changeset: cd879aff5d3c Author: katleman Date: 2012-06-13 16:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/cd879aff5d3c Merge Changeset: 439d9bf8e4ff Author: katleman Date: 2012-06-14 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/439d9bf8e4ff Added tag jdk8-b43 for changeset cd879aff5d3c ! .hgtags From lana.steuck at oracle.com Sun Jun 17 23:38:48 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 18 Jun 2012 06:38:48 +0000 Subject: hg: jdk8/tl/jaxws: 4 new changesets Message-ID: <20120618063904.F1B6547999@hg.openjdk.java.net> Changeset: 35e0f6001816 Author: cl Date: 2012-06-07 12:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/35e0f6001816 Added tag jdk8-b42 for changeset 1f20f37818a9 ! .hgtags Changeset: 001351a98bd5 Author: erikj Date: 2012-06-07 20:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/001351a98bd5 7170079: Adjustments to build-infra makefiles Reviewed-by: ohair, ohrstrom, ihse, jonas Contributed-by: jonas , erikj , ihse , tgranat , ykantser ! makefiles/Makefile Changeset: f00c12994562 Author: katleman Date: 2012-06-13 16:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/f00c12994562 Merge Changeset: f6a417540ef1 Author: katleman Date: 2012-06-14 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/f6a417540ef1 Added tag jdk8-b43 for changeset f00c12994562 ! .hgtags From lana.steuck at oracle.com Sun Jun 17 23:38:48 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 18 Jun 2012 06:38:48 +0000 Subject: hg: jdk8/tl/langtools: 6 new changesets Message-ID: <20120618063911.B47954799A@hg.openjdk.java.net> Changeset: 8280c4f9f619 Author: cl Date: 2012-06-07 12:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8280c4f9f619 Added tag jdk8-b42 for changeset 02c5a3575539 ! .hgtags Changeset: e3d0a8fe4318 Author: lana Date: 2012-06-08 12:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e3d0a8fe4318 Merge - test/tools/javac/diags/examples/FullInstSig.java - test/tools/javac/diags/examples/InvalidInferredTypes.java - test/tools/javac/diags/examples/UndeterminedType1.java Changeset: ac29cc95b5c5 Author: erikj Date: 2012-06-07 20:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ac29cc95b5c5 7170079: Adjustments to build-infra makefiles Reviewed-by: ohair, ohrstrom, ihse, jonas Contributed-by: jonas , erikj , ihse , tgranat , ykantser ! makefiles/Makefile Changeset: f8c64d835b28 Author: katleman Date: 2012-06-13 16:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f8c64d835b28 Merge Changeset: 59cbead12ff4 Author: katleman Date: 2012-06-14 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/59cbead12ff4 Added tag jdk8-b43 for changeset f8c64d835b28 ! .hgtags Changeset: e534aa747b22 Author: lana Date: 2012-06-17 21:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e534aa747b22 Merge From lana.steuck at oracle.com Sun Jun 17 23:38:48 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 18 Jun 2012 06:38:48 +0000 Subject: hg: jdk8/tl/jaxp: 6 new changesets Message-ID: <20120618063913.A63274799B@hg.openjdk.java.net> Changeset: c73aaf2b0d14 Author: cl Date: 2012-06-07 12:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/c73aaf2b0d14 Added tag jdk8-b42 for changeset 39ee03c16021 ! .hgtags Changeset: b94fad1cb830 Author: lana Date: 2012-06-08 12:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/b94fad1cb830 Merge Changeset: 83a38059327b Author: erikj Date: 2012-06-07 20:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/83a38059327b 7170079: Adjustments to build-infra makefiles Reviewed-by: ohair, ohrstrom, ihse, jonas Contributed-by: jonas , erikj , ihse , tgranat , ykantser ! makefiles/Makefile Changeset: eff4ece9c8bc Author: katleman Date: 2012-06-13 16:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/eff4ece9c8bc Merge Changeset: 0b3f3a4ce139 Author: katleman Date: 2012-06-14 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/0b3f3a4ce139 Added tag jdk8-b43 for changeset eff4ece9c8bc ! .hgtags Changeset: a079926a6d81 Author: lana Date: 2012-06-17 21:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a079926a6d81 Merge From lana.steuck at oracle.com Sun Jun 17 23:38:49 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 18 Jun 2012 06:38:49 +0000 Subject: hg: jdk8/tl/hotspot: 23 new changesets Message-ID: <20120618063946.92FD44799C@hg.openjdk.java.net> Changeset: c80d42d78a01 Author: amurillo Date: 2012-05-25 14:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c80d42d78a01 7171853: new hotspot build - hs24-b13 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 960a442eae91 Author: rbackman Date: 2012-05-22 10:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/960a442eae91 7161732: Improve handling of thread_id in OSThread Reviewed-by: dholmes, kamg ! src/os/bsd/vm/osThread_bsd.hpp ! src/os/linux/vm/osThread_linux.hpp ! src/os/solaris/vm/osThread_solaris.hpp ! src/os/windows/vm/osThread_windows.hpp ! src/os_cpu/bsd_x86/vm/vmStructs_bsd_x86.hpp ! src/os_cpu/linux_sparc/vm/vmStructs_linux_sparc.hpp ! src/os_cpu/linux_x86/vm/vmStructs_linux_x86.hpp ! src/os_cpu/solaris_sparc/vm/vmStructs_solaris_sparc.hpp ! src/os_cpu/solaris_x86/vm/vmStructs_solaris_x86.hpp ! src/os_cpu/windows_x86/vm/vmStructs_windows_x86.hpp ! src/share/vm/runtime/osThread.hpp Changeset: df84b4a3ebcb Author: rbackman Date: 2012-05-24 13:37 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/df84b4a3ebcb 7171422: Change 7161732 breaks SA on Windows Reviewed-by: dholmes, sla ! src/os_cpu/windows_x86/vm/vmStructs_windows_x86.hpp Changeset: 9c1709c4c80c Author: dcubed Date: 2012-05-24 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9c1709c4c80c 7165598: enable FDS on Solaris X64 when 7165593 is fixed Summary: Work around 'gobjcopy' failure on Solaris X64 by adding a temporary tool that removes the SHF_ALLOC flag from "empty" section headers. Reviewed-by: sspitsyn, acorn ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/dtrace.make + make/solaris/makefiles/fix_empty_sec_hdr_flags.make ! make/solaris/makefiles/jsig.make ! make/solaris/makefiles/saproc.make ! make/solaris/makefiles/vm.make + src/os/solaris/fix_empty_sec_hdr_flags/fix_empty_sec_hdr_flags.c Changeset: fb8f9ab27c14 Author: dcubed Date: 2012-05-24 12:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fb8f9ab27c14 Merge ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/vm.make ! make/windows/makefiles/defs.make Changeset: cd3a8ab0352b Author: zgu Date: 2012-05-24 20:04 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cd3a8ab0352b Merge Changeset: 17be2328b50b Author: zgu Date: 2012-05-26 06:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/17be2328b50b Merge Changeset: 5be76dc5304d Author: zgu Date: 2012-05-29 20:06 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5be76dc5304d Merge Changeset: 71afdabfd05b Author: jiangli Date: 2012-05-21 14:10 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/71afdabfd05b 7168280: Eliminate the generic signature index slot from field array for field without generic signature. Summary: Only allocate the generic signature index slot in the field array for field with generic signature attribute. Reviewed-by: coleenp, dlong ! agent/src/share/classes/sun/jvm/hotspot/oops/AccessFlags.java ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/ClassConstants.java ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/oops/fieldInfo.hpp ! src/share/vm/oops/fieldStreams.hpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/runtime/fieldDescriptor.cpp ! src/share/vm/runtime/fieldDescriptor.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/accessFlags.hpp Changeset: 48df98e03639 Author: dholmes Date: 2012-05-23 20:09 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/48df98e03639 7170197: Update JPRT default build targets to support embedded builds Reviewed-by: jcoomes, kvn ! make/jprt.properties Changeset: 4e64a590066e Author: jprovino Date: 2012-05-26 08:49 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4e64a590066e Merge Changeset: dd45f26b4282 Author: dholmes Date: 2012-05-30 17:45 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dd45f26b4282 Merge Changeset: c92a79900986 Author: brutisso Date: 2012-05-17 21:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c92a79900986 7169062: CMS: Assertion failed with -XX:+ObjectAlignmentInBytes=64 Summary: Removed the assert in CompactibleFreeListSpace::check_free_list_consistency() since it was too strict. Simplified CompactibleFreeListSpace::set_cms_values() to reducde the need for asserts. Reviewed-by: jcoomes, stefank ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp Changeset: 9a344d88dc22 Author: mnunez Date: 2012-05-21 14:59 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9a344d88dc22 7168848: Add test to check that humongous object allocation path also checks the heap occupancy. Summary: Added test that checks humongous object allocation path also check the heap occupancy and initiate a marking cycle when / if needed. Reviewed-by: brutisso, jwilhelm + test/gc/7168848/HumongousAlloc.java Changeset: 1d478c993020 Author: johnc Date: 2012-05-29 10:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1d478c993020 7143858: G1: Back to back young GCs with the second GC having a minimally sized eden Summary: Before the last thread to leave a JNI critical region was able to schedule a GCLocker Initiated GC, another thread was attempting an allocation and saw that the GCLocker region was no longer active and successfully scheduled a GC. Stall allocating threads until the GCLocker Initiated GC is performed and then retry the allocation. Reviewed-by: brutisso, huntch ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: 5c8bd7c16119 Author: brutisso Date: 2012-05-25 22:35 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5c8bd7c16119 7171936: LOG_G incorrectly defined in globalDefinitions.hpp Summary: Removed LOG_G and LOG_K. Moved LOG_M to where it is being used. Reviewed-by: twisti, johnc ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: c52a6a39546c Author: johnc Date: 2012-05-30 10:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c52a6a39546c 7158682: G1: Handle leak when running nsk.sysdict tests Summary: Place HandleMarks in the code that allocates handles for the pending list lock so that the handles are freed and multiple, unsuccessful, attempts to schedule a GC do not cause an OOM. Reviewed-by: brutisso ! src/share/vm/oops/instanceRefKlass.cpp Changeset: bbc900c2482a Author: brutisso Date: 2012-05-31 21:10 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bbc900c2482a 7172279: G1: Clean up TraceGen0Time and TraceGen1Time data gathering Summary: Simplify code, remove unused code, remove ExitAfterGCNum Reviewed-by: huntch, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/utilities/numberSeq.cpp ! src/share/vm/utilities/numberSeq.hpp Changeset: 7121cd2c58b5 Author: jcoomes Date: 2012-06-01 10:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7121cd2c58b5 Merge Changeset: bd568544be7f Author: amurillo Date: 2012-06-01 15:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bd568544be7f Merge Changeset: 55954061c6e8 Author: amurillo Date: 2012-06-01 15:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/55954061c6e8 Added tag hs24-b13 for changeset bd568544be7f ! .hgtags Changeset: e77b8e0ed1f8 Author: cl Date: 2012-06-07 12:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e77b8e0ed1f8 Added tag jdk8-b42 for changeset 55954061c6e8 ! .hgtags Changeset: b38fb5f31e31 Author: katleman Date: 2012-06-14 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b38fb5f31e31 Added tag jdk8-b43 for changeset e77b8e0ed1f8 ! .hgtags From lana.steuck at oracle.com Sun Jun 17 23:40:45 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 18 Jun 2012 06:40:45 +0000 Subject: hg: jdk8/tl/jdk: 42 new changesets Message-ID: <20120618064815.9D8E2479A2@hg.openjdk.java.net> Changeset: 8e8fb6500a87 Author: cl Date: 2012-06-07 12:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8e8fb6500a87 Added tag jdk8-b42 for changeset cf5c1f6fbc5b ! .hgtags Changeset: a2d12ca36eb3 Author: bae Date: 2012-05-25 12:56 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a2d12ca36eb3 7146550: [macosx] DnD test failure in createCompatibleWritableRaster() Reviewed-by: kizune, serb ! src/macosx/classes/sun/lwawt/macosx/CDragSourceContextPeer.java ! src/macosx/classes/sun/lwawt/macosx/CImage.java ! src/macosx/native/sun/awt/CDragSource.h ! src/macosx/native/sun/awt/CDragSource.m ! src/macosx/native/sun/awt/CDragSourceContextPeer.m ! test/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.java Changeset: 23b82fb671d4 Author: lana Date: 2012-05-25 19:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23b82fb671d4 Merge Changeset: c892ca15ca52 Author: andrew Date: 2012-05-30 16:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c892ca15ca52 7171223: Building ExtensionSubtables.cpp should use -fno-strict-aliasing Summary: GCC 4.4+ have stricter aliasing requirements which produces a new warning from this code Reviewed-by: prr, ohair ! make/sun/font/Makefile Changeset: d988ed9d40bc Author: bae Date: 2012-05-31 12:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d988ed9d40bc 7120895: FontConfiguration should not use thread contextClassLoader Reviewed-by: igor, prr ! src/share/classes/sun/awt/FontConfiguration.java Changeset: baf734760bd6 Author: lana Date: 2012-06-05 17:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/baf734760bd6 Merge Changeset: c499fd3f1695 Author: erikj Date: 2012-06-07 18:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c499fd3f1695 7170969: Add @GenerateNativeHeader to classes whose fields need to be exported for JNI Reviewed-by: ohair, ohrstrom, ihse ! make/sun/awt/make.depend ! src/macosx/classes/apple/laf/JRSUIConstants.java ! src/macosx/classes/com/apple/eawt/FullScreenHandler.java ! src/macosx/classes/com/apple/eawt/event/GestureHandler.java ! src/macosx/classes/sun/java2d/OSXSurfaceData.java ! src/macosx/classes/sun/lwawt/LWLabelPeer.java ! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java ! src/macosx/classes/sun/lwawt/macosx/CocoaConstants.java ! src/share/classes/java/awt/Adjustable.java ! src/share/classes/java/awt/BasicStroke.java ! src/share/classes/java/awt/Choice.java ! src/share/classes/java/awt/DisplayMode.java ! src/share/classes/java/awt/Image.java ! src/share/classes/java/awt/List.java ! src/share/classes/java/awt/PopupMenu.java ! src/share/classes/java/awt/SystemColor.java ! src/share/classes/java/awt/TextComponent.java ! src/share/classes/java/awt/Transparency.java ! src/share/classes/java/awt/color/ColorSpace.java ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/classes/java/awt/datatransfer/Clipboard.java ! src/share/classes/java/awt/datatransfer/StringSelection.java ! src/share/classes/java/awt/dnd/DnDConstants.java ! src/share/classes/java/awt/event/ActionEvent.java ! src/share/classes/java/awt/event/AdjustmentEvent.java ! src/share/classes/java/awt/event/ComponentEvent.java ! src/share/classes/java/awt/event/InputMethodEvent.java ! src/share/classes/java/awt/event/MouseWheelEvent.java ! src/share/classes/java/awt/geom/PathIterator.java ! src/share/classes/java/awt/image/AffineTransformOp.java ! src/share/classes/java/awt/image/ConvolveOp.java ! src/share/classes/java/awt/image/DataBuffer.java ! src/share/classes/java/awt/image/DirectColorModel.java ! src/share/classes/java/awt/image/ImageConsumer.java ! src/share/classes/java/awt/image/ImageObserver.java ! src/share/classes/java/awt/peer/ComponentPeer.java ! src/share/classes/java/awt/print/PageFormat.java ! src/share/classes/java/awt/print/Pageable.java ! src/share/classes/java/awt/print/Printable.java ! src/share/classes/sun/awt/CharsetString.java ! src/share/classes/sun/awt/EmbeddedFrame.java ! src/share/classes/sun/awt/SunHints.java ! src/share/classes/sun/awt/dnd/SunDragSourceContextPeer.java ! src/share/classes/sun/awt/image/BufImgSurfaceData.java ! src/share/classes/sun/java2d/SunGraphics2D.java ! src/share/classes/sun/java2d/opengl/OGLBlitLoops.java ! src/share/classes/sun/java2d/opengl/OGLContext.java ! src/share/classes/sun/java2d/pipe/BufferedContext.java ! src/share/classes/sun/java2d/pipe/BufferedOpCodes.java ! src/share/classes/sun/java2d/pipe/BufferedPaints.java ! src/share/classes/sun/java2d/pipe/BufferedTextPipe.java ! src/share/classes/sun/java2d/pipe/RegionIterator.java ! src/share/classes/sun/java2d/pipe/RenderBuffer.java ! src/share/classes/sun/java2d/pipe/hw/AccelDeviceEventNotifier.java ! src/share/classes/sun/java2d/pipe/hw/AccelSurface.java ! src/share/classes/sun/java2d/pipe/hw/ContextCapabilities.java ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/share/classes/sun/nio/ch/IOStatus.java ! src/share/classes/sun/security/pkcs11/Secmod.java ! src/share/classes/sun/security/pkcs11/wrapper/PKCS11.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/windows/classes/sun/java2d/d3d/D3DBlitLoops.java ! src/windows/classes/sun/java2d/d3d/D3DContext.java ! src/windows/classes/sun/java2d/d3d/D3DPaints.java ! src/windows/native/java/net/TwoStacksPlainSocketImpl.c ! src/windows/native/sun/windows/awt_DataTransferer.cpp ! src/windows/native/sun/windows/awt_MenuItem.h Changeset: 563582096868 Author: ohair Date: 2012-06-07 18:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/563582096868 Merge - src/macosx/bin/amd64/jvm.cfg ! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java - src/share/classes/sun/security/action/LoadLibraryAction.java - test/tools/pack200/dyn.jar - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java Changeset: 992068b99493 Author: lana Date: 2012-06-08 11:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/992068b99493 Merge Changeset: 5ff4693406ad Author: dcherepanov Date: 2012-05-22 12:35 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ff4693406ad 7160293: [macosx] FileDialog appears on secondary display Reviewed-by: art, bae ! src/macosx/classes/sun/awt/CGraphicsEnvironment.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/PlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTWindow.m Changeset: cac4daf60283 Author: zhouyx Date: 2012-05-23 12:37 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cac4daf60283 7170996: IME composition window does not disappear when file dialog is closed : Japanese WinXP Reviewed-by: art, bagiras ! src/windows/native/sun/windows/awt_Component.cpp Changeset: bb3ada9822e4 Author: kizune Date: 2012-05-24 15:11 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb3ada9822e4 7144064: [macosx] "Could not find class" error in JTree's ctor when called in headless mode Reviewed-by: art, leonidr ! src/solaris/native/java/lang/java_props_md.c Changeset: cd00d68e06ac Author: neugens Date: 2012-05-25 14:16 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd00d68e06ac 6800513: GTK-LaF renders menus incompletely Reviewed-by: rupashka ! src/share/classes/javax/swing/JPopupMenu.java Changeset: 4b2b963f8774 Author: ant Date: 2012-05-25 20:57 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4b2b963f8774 7171776: one more setGlobalCurrentFocusCycleRoot call requires doPrivileged Reviewed-by: art ! src/share/classes/java/awt/KeyboardFocusManager.java Changeset: bcdb6e5f31cc Author: lana Date: 2012-05-25 13:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bcdb6e5f31cc Merge Changeset: 3c9adc88956d Author: luchsh Date: 2012-05-30 10:58 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c9adc88956d 7170655: Frame size does not follow font size change with XToolkit Reviewed-by: serb, art ! src/solaris/classes/sun/awt/X11/XLabelPeer.java + test/java/awt/Frame/ResizeAfterSetFont/ResizeAfterSetFont.java Changeset: 14f9e9060370 Author: alexsch Date: 2012-05-30 14:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/14f9e9060370 7146131: [macosx] When click the show optionpane button,it display partly of dialog and hung until timeout Reviewed-by: rupashka ! src/macosx/classes/com/apple/laf/AquaInternalFrameUI.java Changeset: e6de02da6870 Author: alexsch Date: 2012-05-30 14:58 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6de02da6870 7141296: [macosx] Mouse Wheel Turn closes combobox popup Reviewed-by: rupashka ! src/macosx/classes/com/apple/laf/AquaScrollPaneUI.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformResponder.java Changeset: 8800a98316b2 Author: neugens Date: 2012-05-30 18:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8800a98316b2 7171806: Missing test for bug ID 6800513 fix Reviewed-by: rupashka + test/javax/swing/JPopupMenu/6800513/bug6800513.java Changeset: 06a0302856eb Author: leonidr Date: 2012-05-31 20:18 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/06a0302856eb 7150089: [macosx] Default for a custom cursor created from non-existent image is not transparent Reviewed-by: anthony, kizune ! src/macosx/classes/sun/lwawt/macosx/CCustomCursor.java Changeset: fd27852f3ea5 Author: denis Date: 2012-06-01 17:08 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fd27852f3ea5 7112115: Component.getLocationOnScreen() work incorrectly if create window in point (0, 0) on oel Reviewed-by: serb, art + test/javax/swing/JSpinner/5012888/bug5012888.java Changeset: 0526ba7f723b Author: alexsch Date: 2012-06-04 14:11 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0526ba7f723b 7161766: [macosx] javax/swing/JPopupMenu/6694823/bug6694823.java failed on Mac OS X Reviewed-by: rupashka ! test/javax/swing/JPopupMenu/6694823/bug6694823.java Changeset: 79df0a4a6573 Author: omajid Date: 2012-06-04 16:39 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/79df0a4a6573 7043963: AWT workaround missing for Mutter. Reviewed-by: art, anthony Contributed-by: Denis Lila ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java ! src/solaris/classes/sun/awt/X11/XWM.java + test/java/awt/WMSpecificTests/Mutter/MutterMaximizeTest.java ! test/java/awt/regtesthelpers/Util.java Changeset: fc64530a1571 Author: anthony Date: 2012-06-05 15:20 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc64530a1571 7172722: Latest jdk7u from OSX broke universal build Summary: Add a data memeber for a new property Reviewed-by: serb, swingler ! src/macosx/native/sun/awt/AWTWindow.h Changeset: 5880da7a3628 Author: dcherepanov Date: 2012-06-05 19:48 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5880da7a3628 7123957: Switch of Gnome theme ends up deadlocked in GTKEngine.native_switch_theme Reviewed-by: art, anthony ! src/solaris/native/sun/awt/swing_GTKEngine.c Changeset: 8c6fef8404ea Author: lana Date: 2012-06-05 18:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c6fef8404ea Merge Changeset: c6075e29ce94 Author: alexsch Date: 2012-06-06 11:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6075e29ce94 7169285: [macosx] Test api/javax_swing/JPopupMenu/descriptions.html#setgetXXX doesn't take Mac main menu Reviewed-by: rupashka ! src/share/classes/javax/swing/JPopupMenu.java Changeset: 6694d9e99716 Author: littlee Date: 2012-06-07 10:22 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6694d9e99716 7174233: Openjdk is missing some key maps on the Japanese keyboards Reviewed-by: anthony, naoto ! src/solaris/classes/sun/awt/X11/XKeysym.java ! src/solaris/native/sun/xawt/XWindow.c Changeset: 77c92e809c25 Author: alexsch Date: 2012-06-07 18:24 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77c92e809c25 7152952: [macosx] List rows overlap with enlarged font Reviewed-by: art, rupashka ! src/macosx/classes/sun/lwawt/LWListPeer.java Changeset: f1063002c843 Author: kizune Date: 2012-06-07 20:04 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f1063002c843 7124247: [macosx] Implement GraphicsDevice.setDisplayMode() Reviewed-by: anthony, swingler ! src/macosx/classes/sun/awt/CGraphicsDevice.java ! src/macosx/native/sun/awt/CGraphicsDevice.m Changeset: 05ac5622a2ec Author: kizune Date: 2012-06-07 20:06 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/05ac5622a2ec Merge Changeset: 4acd0211f48b Author: rupashka Date: 2012-06-07 21:49 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4acd0211f48b 7156657: Version 7 doesn't support translucent popup menus against a translucent window Reviewed-by: art, alexsch ! src/share/classes/javax/swing/PopupFactory.java ! src/share/demo/jfc/TransparentRuler/transparentruler/Ruler.java + test/javax/swing/JPopupMenu/7156657/bug7156657.java Changeset: a1d825c477bc Author: alexsch Date: 2012-06-08 14:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a1d825c477bc 7092551: Double-click in TextField sets caret to the beginning Reviewed-by: bagiras, serb ! src/windows/native/sun/windows/awt_TextArea.cpp ! src/windows/native/sun/windows/awt_TextArea.h ! src/windows/native/sun/windows/awt_TextComponent.cpp ! src/windows/native/sun/windows/awt_TextComponent.h ! src/windows/native/sun/windows/awt_TextField.cpp ! src/windows/native/sun/windows/awt_TextField.h Changeset: 34ac493d6bea Author: kizune Date: 2012-06-08 22:21 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/34ac493d6bea 7175566: [macosx] Glich in fix for CR7124247 caused MacOS crash during PIT testing Reviewed-by: anthony, dcherepanov ! src/macosx/native/sun/awt/CGraphicsDevice.m Changeset: 3d7be3ac3a99 Author: lana Date: 2012-06-08 12:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3d7be3ac3a99 Merge Changeset: cd195e5d2c07 Author: lana Date: 2012-06-08 12:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd195e5d2c07 Merge ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java - src/share/classes/sun/nio/ch/DevPollSelectorProvider.java - src/share/classes/sun/security/provider/certpath/CrlRevocationChecker.java - src/share/classes/sun/security/provider/certpath/OCSPChecker.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources_ja.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources_zh_CN.java - src/share/native/java/sql/DriverManager.c - test/sun/security/krb5/auto/ok-as-delegate-xrealm.sh - test/sun/security/krb5/auto/ok-as-delegate.sh Changeset: 898ce0cf7476 Author: ohair Date: 2012-06-07 20:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/898ce0cf7476 Merge ! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java Changeset: 1953cf522107 Author: erikj Date: 2012-06-07 20:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1953cf522107 7170079: Adjustments to build-infra makefiles Reviewed-by: ohair, ohrstrom, ihse, jonas Contributed-by: jonas , erikj , ihse , tgranat , ykantser ! makefiles/CompileDemos.gmk ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CopyFiles.gmk ! makefiles/CopyIntoClasses.gmk ! makefiles/CopySamples.gmk + makefiles/CreateJars.gmk ! makefiles/GendataBreakIterator.gmk + makefiles/GendataFontConfig.gmk + makefiles/GendataHtml32dtd.gmk + makefiles/GendataTimeZone.gmk ! makefiles/GenerateClasses.gmk ! makefiles/GenerateData.gmk ! makefiles/GenerateJavaSources.gmk + makefiles/GensrcBuffer.gmk ! makefiles/GensrcCharacterData.gmk + makefiles/GensrcCharsetCoder.gmk + makefiles/GensrcCharsetMapping.gmk + makefiles/GensrcExceptions.gmk + makefiles/GensrcIcons.gmk ! makefiles/GensrcJDWP.gmk ! makefiles/GensrcLocaleDataMetaInfo.gmk ! makefiles/GensrcMisc.gmk ! makefiles/GensrcProperties.gmk + makefiles/GensrcSwing.gmk + makefiles/GensrcX11Wrappers.gmk ! makefiles/Images.gmk ! makefiles/LegacyMakefiles.gmk ! makefiles/Makefile + makefiles/OldImages.gmk ! makefiles/Setup.gmk ! makefiles/Tools.gmk - makefiles/altclasses/Makefile - makefiles/apple/Makefile - makefiles/apple/applescript/Makefile - makefiles/com/Makefile - makefiles/com/apple/Makefile - makefiles/com/apple/osx/Makefile - makefiles/com/apple/osxui/Makefile - makefiles/com/oracle/Makefile - makefiles/com/oracle/jfr/Makefile - makefiles/com/oracle/security/ucrypto/FILES_c.gmk - makefiles/com/oracle/security/ucrypto/Makefile - makefiles/com/oracle/security/ucrypto/mapfile-vers - makefiles/com/sun/Makefile ! makefiles/common/Defs-macosx.gmk ! makefiles/common/Release-macosx.gmk ! makefiles/common/Release.gmk - makefiles/common/shared/Defs-utils.gmk ! makefiles/common/shared/Defs.gmk ! makefiles/docs/CORE_PKGS.gmk ! makefiles/java/Makefile - makefiles/java/fdlibm/FILES_c.gmk - makefiles/java/fdlibm/Makefile - makefiles/java/instrument/Makefile - makefiles/java/instrument/mapfile-vers - makefiles/java/java/Exportedfiles.gmk - makefiles/java/java/FILES_c.gmk - makefiles/java/java/FILES_java.gmk - makefiles/java/java/Makefile - makefiles/java/java/localelist.sh - makefiles/java/java/mapfile-vers - makefiles/java/java/reflect/Makefile - makefiles/java/java/reorder-i586 - makefiles/java/java/reorder-sparc - makefiles/java/java/reorder-sparcv9 - makefiles/java/java_crw_demo/Makefile - makefiles/java/java_crw_demo/mapfile-vers - makefiles/java/java_hprof_demo/Makefile - makefiles/java/java_hprof_demo/mapfile-vers - makefiles/java/jexec/Makefile - makefiles/java/jli/Makefile - makefiles/java/jli/mapfile-vers - makefiles/java/jobjc/Makefile - makefiles/java/jvm/Makefile - makefiles/java/main/Makefile - makefiles/java/main/java/Makefile - makefiles/java/main/java/mapfile-amd64 - makefiles/java/main/java/mapfile-i586 - makefiles/java/main/java/mapfile-sparc - makefiles/java/main/java/mapfile-sparcv9 - makefiles/java/main/javaw/Makefile - makefiles/java/management/Exportedfiles.gmk - makefiles/java/management/FILES_c.gmk - makefiles/java/management/Makefile - makefiles/java/management/mapfile-vers - makefiles/java/net/FILES_c.gmk - makefiles/java/net/Makefile - makefiles/java/net/mapfile-vers - makefiles/java/nio/Exportedfiles.gmk - makefiles/java/nio/FILES_c.gmk - makefiles/java/nio/FILES_java.gmk - makefiles/java/nio/Makefile - makefiles/java/nio/addNotices.sh - makefiles/java/nio/genBuffer.sh - makefiles/java/nio/genCharsetProvider.sh - makefiles/java/nio/genCoder.sh - makefiles/java/nio/genExceptions.sh - makefiles/java/nio/mapfile-bsd - makefiles/java/nio/mapfile-linux - makefiles/java/nio/mapfile-solaris - makefiles/java/nio/reorder-i586 - makefiles/java/nio/reorder-sparc - makefiles/java/nio/reorder-sparcv9 - makefiles/java/npt/Makefile - makefiles/java/npt/mapfile-vers ! makefiles/java/redist/Makefile - makefiles/java/redist/fonts/Makefile - makefiles/java/security/Makefile - makefiles/java/sun_nio/FILES_java.gmk - makefiles/java/sun_nio/Makefile - makefiles/java/util/FILES_java.gmk - makefiles/java/util/FILES_properties.gmk - makefiles/java/util/Makefile - makefiles/java/verify/Makefile - makefiles/java/verify/mapfile-vers - makefiles/java/verify/reorder-i586 - makefiles/java/verify/reorder-sparc - makefiles/java/verify/reorder-sparcv9 - makefiles/javax/Makefile - makefiles/javax/imageio/Makefile - makefiles/javax/management/Makefile - makefiles/javax/sound/FILES_c.gmk - makefiles/javax/sound/Makefile - makefiles/javax/sound/SoundDefs.gmk - makefiles/javax/sound/jsoundalsa/Makefile - makefiles/javax/sound/jsoundalsa/mapfile-vers - makefiles/javax/sound/jsoundds/Makefile - makefiles/javax/sound/mapfile-vers - makefiles/javax/sql/Makefile - makefiles/javax/swing/FILES.gmk - makefiles/javax/swing/Makefile - makefiles/javax/swing/beaninfo/FILES.gmk - makefiles/javax/swing/beaninfo/Makefile - makefiles/javax/swing/beaninfo/SwingBeans.gmk - makefiles/javax/swing/beaninfo/manifest - makefiles/javax/swing/html32dtd/Makefile - makefiles/javax/swing/plaf/FILES.gmk - makefiles/javax/swing/plaf/Makefile + makefiles/mapfiles/libawt/mapfile-mawt-vers + makefiles/mapfiles/libawt/mapfile-vers + makefiles/mapfiles/libawt/mapfile-vers-linux + makefiles/mapfiles/libawt_headless/mapfile-vers + makefiles/mapfiles/libawt_headless/reorder-i586 + makefiles/mapfiles/libawt_headless/reorder-sparc + makefiles/mapfiles/libawt_headless/reorder-sparcv9 + makefiles/mapfiles/libawt_xawt/mapfile-vers + makefiles/mapfiles/libdcpr/mapfile-vers + makefiles/mapfiles/libhprof/mapfile-vers + makefiles/mapfiles/libinstrument/mapfile-vers + makefiles/mapfiles/libj2gss/mapfile-vers + makefiles/mapfiles/libj2pcsc/mapfile-vers + makefiles/mapfiles/libj2pkcs11/mapfile-vers + makefiles/mapfiles/libj2ucrypto/mapfile-vers + makefiles/mapfiles/libjava/mapfile-vers + makefiles/mapfiles/libjava/reorder-i586 + makefiles/mapfiles/libjava/reorder-sparc + makefiles/mapfiles/libjava/reorder-sparcv9 + makefiles/mapfiles/libjava_crw_demo/mapfile-vers + makefiles/mapfiles/libjdga/mapfile-vers + makefiles/mapfiles/libjfr/mapfile-vers + makefiles/mapfiles/libjli/mapfile-vers ! makefiles/mapfiles/libjpeg/reorder-i586 ! makefiles/mapfiles/libjpeg/reorder-sparc ! makefiles/mapfiles/libjpeg/reorder-sparcv9 + makefiles/mapfiles/libjsound/mapfile-vers + makefiles/mapfiles/libjsoundalsa/mapfile-vers + makefiles/mapfiles/libkcms/mapfile-vers + makefiles/mapfiles/libmanagement/mapfile-vers + makefiles/mapfiles/libmlib_image/mapfile-vers + makefiles/mapfiles/libnet/mapfile-vers + makefiles/mapfiles/libnio/mapfile-bsd + makefiles/mapfiles/libnio/mapfile-linux + makefiles/mapfiles/libnio/mapfile-solaris + makefiles/mapfiles/libnio/reorder-i586 + makefiles/mapfiles/libnio/reorder-sparc + makefiles/mapfiles/libnio/reorder-sparcv9 + makefiles/mapfiles/libnpt/mapfile-vers + makefiles/mapfiles/libsplashscreen/mapfile-vers + makefiles/mapfiles/libsunec/mapfile-vers ! makefiles/mapfiles/libverify/reorder-i586 ! makefiles/mapfiles/libverify/reorder-sparc ! makefiles/mapfiles/libverify/reorder-sparcv9 ! makefiles/mapfiles/libzip/reorder-i586 ! makefiles/mapfiles/libzip/reorder-sparc ! makefiles/mapfiles/libzip/reorder-sparcv9 + makefiles/scripts/addNotices.sh + makefiles/scripts/genCharsetProvider.sh + makefiles/scripts/genExceptions.sh + makefiles/scripts/localelist.sh - makefiles/sun/Makefile - makefiles/sun/awt/CondenseRules.awk - makefiles/sun/awt/Depend.mak - makefiles/sun/awt/Depend.sed - makefiles/sun/awt/FILES_c_macosx.gmk - makefiles/sun/awt/FILES_c_unix.gmk - makefiles/sun/awt/FILES_c_windows.gmk - makefiles/sun/awt/FILES_export_macosx.gmk - makefiles/sun/awt/FILES_export_unix.gmk - makefiles/sun/awt/FILES_export_windows.gmk - makefiles/sun/awt/Makefile - makefiles/sun/awt/README - makefiles/sun/awt/make.depend - makefiles/sun/awt/mapfile-mawt-vers - makefiles/sun/awt/mapfile-vers - makefiles/sun/awt/mapfile-vers-linux - makefiles/sun/awt/mawt.gmk - makefiles/sun/cmm/Makefile - makefiles/sun/cmm/kcms/FILES_c_unix.gmk - makefiles/sun/cmm/kcms/FILES_c_windows.gmk - makefiles/sun/cmm/kcms/Makefile - makefiles/sun/cmm/kcms/mapfile-vers - makefiles/sun/dcpr/FILES_c.gmk - makefiles/sun/dcpr/Makefile - makefiles/sun/dcpr/mapfile-vers - makefiles/sun/headless/Makefile - makefiles/sun/headless/mapfile-vers - makefiles/sun/headless/reorder-i586 - makefiles/sun/headless/reorder-sparc - makefiles/sun/headless/reorder-sparcv9 - makefiles/sun/image/Makefile - makefiles/sun/image/generic/FILES_c.gmk - makefiles/sun/image/generic/Makefile - makefiles/sun/image/generic/mapfile-vers - makefiles/sun/image/vis/FILES_c.gmk - makefiles/sun/image/vis/Makefile - makefiles/sun/javazic/Makefile - makefiles/sun/jdbc/Makefile - makefiles/sun/jdga/Makefile - makefiles/sun/jdga/mapfile-vers - makefiles/sun/lwawt/FILES_c_macosx.gmk - makefiles/sun/lwawt/FILES_export_macosx.gmk - makefiles/sun/lwawt/Makefile - makefiles/sun/nio/Makefile - makefiles/sun/nio/cs/FILES_java.gmk - makefiles/sun/nio/cs/Makefile - makefiles/sun/org/Makefile - makefiles/sun/org/mozilla/Makefile - makefiles/sun/org/mozilla/javascript/Makefile - makefiles/sun/osxapp/Makefile - makefiles/sun/security/Makefile - makefiles/sun/security/ec/FILES_c.gmk - makefiles/sun/security/ec/mapfile-vers - makefiles/sun/security/jgss/Makefile - makefiles/sun/security/jgss/wrapper/FILES_c.gmk - makefiles/sun/security/jgss/wrapper/Makefile - makefiles/sun/security/jgss/wrapper/mapfile-vers - makefiles/sun/security/krb5/FILES_c_windows.gmk - makefiles/sun/security/krb5/Makefile - makefiles/sun/security/mscapi/FILES_cpp.gmk - makefiles/sun/security/mscapi/Makefile - makefiles/sun/security/other/Makefile - makefiles/sun/security/smartcardio/FILES_c.gmk - makefiles/sun/security/smartcardio/Makefile - makefiles/sun/security/smartcardio/mapfile-vers - makefiles/sun/security/tools/Makefile - makefiles/sun/security/util/Makefile - makefiles/sun/splashscreen/FILES_c.gmk - makefiles/sun/splashscreen/Makefile - makefiles/sun/splashscreen/mapfile-vers - makefiles/sun/xawt/FILES_c_unix.gmk - makefiles/sun/xawt/FILES_export_unix.gmk - makefiles/sun/xawt/Makefile - makefiles/sun/xawt/mapfile-vers Changeset: e00f450a3c5f Author: erikj Date: 2012-06-11 09:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e00f450a3c5f 7175966: Fix windows build issues for build-infra project Reviewed-by: ohair ! makefiles/CompileJavaClasses.gmk ! makefiles/java/redist/sajdi/Makefile Changeset: b3246687c369 Author: katleman Date: 2012-06-13 16:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b3246687c369 Merge - makefiles/altclasses/Makefile - makefiles/apple/Makefile - makefiles/apple/applescript/Makefile - makefiles/com/Makefile - makefiles/com/apple/Makefile - makefiles/com/apple/osx/Makefile - makefiles/com/apple/osxui/Makefile - makefiles/com/oracle/Makefile - makefiles/com/oracle/jfr/Makefile - makefiles/com/oracle/security/ucrypto/FILES_c.gmk - makefiles/com/oracle/security/ucrypto/Makefile - makefiles/com/oracle/security/ucrypto/mapfile-vers - makefiles/com/sun/Makefile - makefiles/common/shared/Defs-utils.gmk - makefiles/java/fdlibm/FILES_c.gmk - makefiles/java/fdlibm/Makefile - makefiles/java/instrument/Makefile - makefiles/java/instrument/mapfile-vers - makefiles/java/java/Exportedfiles.gmk - makefiles/java/java/FILES_c.gmk - makefiles/java/java/FILES_java.gmk - makefiles/java/java/Makefile - makefiles/java/java/localelist.sh - makefiles/java/java/mapfile-vers - makefiles/java/java/reflect/Makefile - makefiles/java/java/reorder-i586 - makefiles/java/java/reorder-sparc - makefiles/java/java/reorder-sparcv9 - makefiles/java/java_crw_demo/Makefile - makefiles/java/java_crw_demo/mapfile-vers - makefiles/java/java_hprof_demo/Makefile - makefiles/java/java_hprof_demo/mapfile-vers - makefiles/java/jexec/Makefile - makefiles/java/jli/Makefile - makefiles/java/jli/mapfile-vers - makefiles/java/jobjc/Makefile - makefiles/java/jvm/Makefile - makefiles/java/main/Makefile - makefiles/java/main/java/Makefile - makefiles/java/main/java/mapfile-amd64 - makefiles/java/main/java/mapfile-i586 - makefiles/java/main/java/mapfile-sparc - makefiles/java/main/java/mapfile-sparcv9 - makefiles/java/main/javaw/Makefile - makefiles/java/management/Exportedfiles.gmk - makefiles/java/management/FILES_c.gmk - makefiles/java/management/Makefile - makefiles/java/management/mapfile-vers - makefiles/java/net/FILES_c.gmk - makefiles/java/net/Makefile - makefiles/java/net/mapfile-vers - makefiles/java/nio/Exportedfiles.gmk - makefiles/java/nio/FILES_c.gmk - makefiles/java/nio/FILES_java.gmk - makefiles/java/nio/Makefile - makefiles/java/nio/addNotices.sh - makefiles/java/nio/genBuffer.sh - makefiles/java/nio/genCharsetProvider.sh - makefiles/java/nio/genCoder.sh - makefiles/java/nio/genExceptions.sh - makefiles/java/nio/mapfile-bsd - makefiles/java/nio/mapfile-linux - makefiles/java/nio/mapfile-solaris - makefiles/java/nio/reorder-i586 - makefiles/java/nio/reorder-sparc - makefiles/java/nio/reorder-sparcv9 - makefiles/java/npt/Makefile - makefiles/java/npt/mapfile-vers - makefiles/java/redist/fonts/Makefile - makefiles/java/security/Makefile - makefiles/java/sun_nio/FILES_java.gmk - makefiles/java/sun_nio/Makefile - makefiles/java/util/FILES_java.gmk - makefiles/java/util/FILES_properties.gmk - makefiles/java/util/Makefile - makefiles/java/verify/Makefile - makefiles/java/verify/mapfile-vers - makefiles/java/verify/reorder-i586 - makefiles/java/verify/reorder-sparc - makefiles/java/verify/reorder-sparcv9 - makefiles/javax/Makefile - makefiles/javax/imageio/Makefile - makefiles/javax/management/Makefile - makefiles/javax/sound/FILES_c.gmk - makefiles/javax/sound/Makefile - makefiles/javax/sound/SoundDefs.gmk - makefiles/javax/sound/jsoundalsa/Makefile - makefiles/javax/sound/jsoundalsa/mapfile-vers - makefiles/javax/sound/jsoundds/Makefile - makefiles/javax/sound/mapfile-vers - makefiles/javax/sql/Makefile - makefiles/javax/swing/FILES.gmk - makefiles/javax/swing/Makefile - makefiles/javax/swing/beaninfo/FILES.gmk - makefiles/javax/swing/beaninfo/Makefile - makefiles/javax/swing/beaninfo/SwingBeans.gmk - makefiles/javax/swing/beaninfo/manifest - makefiles/javax/swing/html32dtd/Makefile - makefiles/javax/swing/plaf/FILES.gmk - makefiles/javax/swing/plaf/Makefile - makefiles/sun/Makefile - makefiles/sun/awt/CondenseRules.awk - makefiles/sun/awt/Depend.mak - makefiles/sun/awt/Depend.sed - makefiles/sun/awt/FILES_c_macosx.gmk - makefiles/sun/awt/FILES_c_unix.gmk - makefiles/sun/awt/FILES_c_windows.gmk - makefiles/sun/awt/FILES_export_macosx.gmk - makefiles/sun/awt/FILES_export_unix.gmk - makefiles/sun/awt/FILES_export_windows.gmk - makefiles/sun/awt/Makefile - makefiles/sun/awt/README - makefiles/sun/awt/make.depend - makefiles/sun/awt/mapfile-mawt-vers - makefiles/sun/awt/mapfile-vers - makefiles/sun/awt/mapfile-vers-linux - makefiles/sun/awt/mawt.gmk - makefiles/sun/cmm/Makefile - makefiles/sun/cmm/kcms/FILES_c_unix.gmk - makefiles/sun/cmm/kcms/FILES_c_windows.gmk - makefiles/sun/cmm/kcms/Makefile - makefiles/sun/cmm/kcms/mapfile-vers - makefiles/sun/dcpr/FILES_c.gmk - makefiles/sun/dcpr/Makefile - makefiles/sun/dcpr/mapfile-vers - makefiles/sun/headless/Makefile - makefiles/sun/headless/mapfile-vers - makefiles/sun/headless/reorder-i586 - makefiles/sun/headless/reorder-sparc - makefiles/sun/headless/reorder-sparcv9 - makefiles/sun/image/Makefile - makefiles/sun/image/generic/FILES_c.gmk - makefiles/sun/image/generic/Makefile - makefiles/sun/image/generic/mapfile-vers - makefiles/sun/image/vis/FILES_c.gmk - makefiles/sun/image/vis/Makefile - makefiles/sun/javazic/Makefile - makefiles/sun/jdbc/Makefile - makefiles/sun/jdga/Makefile - makefiles/sun/jdga/mapfile-vers - makefiles/sun/lwawt/FILES_c_macosx.gmk - makefiles/sun/lwawt/FILES_export_macosx.gmk - makefiles/sun/lwawt/Makefile - makefiles/sun/nio/Makefile - makefiles/sun/nio/cs/FILES_java.gmk - makefiles/sun/nio/cs/Makefile - makefiles/sun/org/Makefile - makefiles/sun/org/mozilla/Makefile - makefiles/sun/org/mozilla/javascript/Makefile - makefiles/sun/osxapp/Makefile - makefiles/sun/security/Makefile - makefiles/sun/security/ec/FILES_c.gmk - makefiles/sun/security/ec/mapfile-vers - makefiles/sun/security/jgss/Makefile - makefiles/sun/security/jgss/wrapper/FILES_c.gmk - makefiles/sun/security/jgss/wrapper/Makefile - makefiles/sun/security/jgss/wrapper/mapfile-vers - makefiles/sun/security/krb5/FILES_c_windows.gmk - makefiles/sun/security/krb5/Makefile - makefiles/sun/security/mscapi/FILES_cpp.gmk - makefiles/sun/security/mscapi/Makefile - makefiles/sun/security/other/Makefile - makefiles/sun/security/smartcardio/FILES_c.gmk - makefiles/sun/security/smartcardio/Makefile - makefiles/sun/security/smartcardio/mapfile-vers - makefiles/sun/security/tools/Makefile - makefiles/sun/security/util/Makefile - makefiles/sun/splashscreen/FILES_c.gmk - makefiles/sun/splashscreen/Makefile - makefiles/sun/splashscreen/mapfile-vers - makefiles/sun/xawt/FILES_c_unix.gmk - makefiles/sun/xawt/FILES_export_unix.gmk - makefiles/sun/xawt/Makefile - makefiles/sun/xawt/mapfile-vers Changeset: db471a7af031 Author: katleman Date: 2012-06-14 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/db471a7af031 Added tag jdk8-b43 for changeset b3246687c369 ! .hgtags Changeset: 6b40703aad55 Author: lana Date: 2012-06-17 21:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6b40703aad55 Merge - makefiles/altclasses/Makefile - makefiles/apple/Makefile - makefiles/apple/applescript/Makefile - makefiles/com/Makefile - makefiles/com/apple/Makefile - makefiles/com/apple/osx/Makefile - makefiles/com/apple/osxui/Makefile - makefiles/com/oracle/Makefile - makefiles/com/oracle/jfr/Makefile - makefiles/com/oracle/security/ucrypto/FILES_c.gmk - makefiles/com/oracle/security/ucrypto/Makefile - makefiles/com/oracle/security/ucrypto/mapfile-vers - makefiles/com/sun/Makefile - makefiles/common/shared/Defs-utils.gmk - makefiles/java/fdlibm/FILES_c.gmk - makefiles/java/fdlibm/Makefile - makefiles/java/instrument/Makefile - makefiles/java/instrument/mapfile-vers - makefiles/java/java/Exportedfiles.gmk - makefiles/java/java/FILES_c.gmk - makefiles/java/java/FILES_java.gmk - makefiles/java/java/Makefile - makefiles/java/java/localelist.sh - makefiles/java/java/mapfile-vers - makefiles/java/java/reflect/Makefile - makefiles/java/java/reorder-i586 - makefiles/java/java/reorder-sparc - makefiles/java/java/reorder-sparcv9 - makefiles/java/java_crw_demo/Makefile - makefiles/java/java_crw_demo/mapfile-vers - makefiles/java/java_hprof_demo/Makefile - makefiles/java/java_hprof_demo/mapfile-vers - makefiles/java/jexec/Makefile - makefiles/java/jli/Makefile - makefiles/java/jli/mapfile-vers - makefiles/java/jobjc/Makefile - makefiles/java/jvm/Makefile - makefiles/java/main/Makefile - makefiles/java/main/java/Makefile - makefiles/java/main/java/mapfile-amd64 - makefiles/java/main/java/mapfile-i586 - makefiles/java/main/java/mapfile-sparc - makefiles/java/main/java/mapfile-sparcv9 - makefiles/java/main/javaw/Makefile - makefiles/java/management/Exportedfiles.gmk - makefiles/java/management/FILES_c.gmk - makefiles/java/management/Makefile - makefiles/java/management/mapfile-vers - makefiles/java/net/FILES_c.gmk - makefiles/java/net/Makefile - makefiles/java/net/mapfile-vers - makefiles/java/nio/Exportedfiles.gmk - makefiles/java/nio/FILES_c.gmk - makefiles/java/nio/FILES_java.gmk - makefiles/java/nio/Makefile - makefiles/java/nio/addNotices.sh - makefiles/java/nio/genBuffer.sh - makefiles/java/nio/genCharsetProvider.sh - makefiles/java/nio/genCoder.sh - makefiles/java/nio/genExceptions.sh - makefiles/java/nio/mapfile-bsd - makefiles/java/nio/mapfile-linux - makefiles/java/nio/mapfile-solaris - makefiles/java/nio/reorder-i586 - makefiles/java/nio/reorder-sparc - makefiles/java/nio/reorder-sparcv9 - makefiles/java/npt/Makefile - makefiles/java/npt/mapfile-vers - makefiles/java/redist/fonts/Makefile - makefiles/java/security/Makefile - makefiles/java/sun_nio/FILES_java.gmk - makefiles/java/sun_nio/Makefile - makefiles/java/util/FILES_java.gmk - makefiles/java/util/FILES_properties.gmk - makefiles/java/util/Makefile - makefiles/java/verify/Makefile - makefiles/java/verify/mapfile-vers - makefiles/java/verify/reorder-i586 - makefiles/java/verify/reorder-sparc - makefiles/java/verify/reorder-sparcv9 - makefiles/javax/Makefile - makefiles/javax/imageio/Makefile - makefiles/javax/management/Makefile - makefiles/javax/sound/FILES_c.gmk - makefiles/javax/sound/Makefile - makefiles/javax/sound/SoundDefs.gmk - makefiles/javax/sound/jsoundalsa/Makefile - makefiles/javax/sound/jsoundalsa/mapfile-vers - makefiles/javax/sound/jsoundds/Makefile - makefiles/javax/sound/mapfile-vers - makefiles/javax/sql/Makefile - makefiles/javax/swing/FILES.gmk - makefiles/javax/swing/Makefile - makefiles/javax/swing/beaninfo/FILES.gmk - makefiles/javax/swing/beaninfo/Makefile - makefiles/javax/swing/beaninfo/SwingBeans.gmk - makefiles/javax/swing/beaninfo/manifest - makefiles/javax/swing/html32dtd/Makefile - makefiles/javax/swing/plaf/FILES.gmk - makefiles/javax/swing/plaf/Makefile - makefiles/sun/Makefile - makefiles/sun/awt/CondenseRules.awk - makefiles/sun/awt/Depend.mak - makefiles/sun/awt/Depend.sed - makefiles/sun/awt/FILES_c_macosx.gmk - makefiles/sun/awt/FILES_c_unix.gmk - makefiles/sun/awt/FILES_c_windows.gmk - makefiles/sun/awt/FILES_export_macosx.gmk - makefiles/sun/awt/FILES_export_unix.gmk - makefiles/sun/awt/FILES_export_windows.gmk - makefiles/sun/awt/Makefile - makefiles/sun/awt/README - makefiles/sun/awt/make.depend - makefiles/sun/awt/mapfile-mawt-vers - makefiles/sun/awt/mapfile-vers - makefiles/sun/awt/mapfile-vers-linux - makefiles/sun/awt/mawt.gmk - makefiles/sun/cmm/Makefile - makefiles/sun/cmm/kcms/FILES_c_unix.gmk - makefiles/sun/cmm/kcms/FILES_c_windows.gmk - makefiles/sun/cmm/kcms/Makefile - makefiles/sun/cmm/kcms/mapfile-vers - makefiles/sun/dcpr/FILES_c.gmk - makefiles/sun/dcpr/Makefile - makefiles/sun/dcpr/mapfile-vers - makefiles/sun/headless/Makefile - makefiles/sun/headless/mapfile-vers - makefiles/sun/headless/reorder-i586 - makefiles/sun/headless/reorder-sparc - makefiles/sun/headless/reorder-sparcv9 - makefiles/sun/image/Makefile - makefiles/sun/image/generic/FILES_c.gmk - makefiles/sun/image/generic/Makefile - makefiles/sun/image/generic/mapfile-vers - makefiles/sun/image/vis/FILES_c.gmk - makefiles/sun/image/vis/Makefile - makefiles/sun/javazic/Makefile - makefiles/sun/jdbc/Makefile - makefiles/sun/jdga/Makefile - makefiles/sun/jdga/mapfile-vers - makefiles/sun/lwawt/FILES_c_macosx.gmk - makefiles/sun/lwawt/FILES_export_macosx.gmk - makefiles/sun/lwawt/Makefile - makefiles/sun/nio/Makefile - makefiles/sun/nio/cs/FILES_java.gmk - makefiles/sun/nio/cs/Makefile - makefiles/sun/org/Makefile - makefiles/sun/org/mozilla/Makefile - makefiles/sun/org/mozilla/javascript/Makefile - makefiles/sun/osxapp/Makefile - makefiles/sun/security/Makefile - makefiles/sun/security/ec/FILES_c.gmk - makefiles/sun/security/ec/mapfile-vers - makefiles/sun/security/jgss/Makefile - makefiles/sun/security/jgss/wrapper/FILES_c.gmk - makefiles/sun/security/jgss/wrapper/Makefile - makefiles/sun/security/jgss/wrapper/mapfile-vers - makefiles/sun/security/krb5/FILES_c_windows.gmk - makefiles/sun/security/krb5/Makefile - makefiles/sun/security/mscapi/FILES_cpp.gmk - makefiles/sun/security/mscapi/Makefile - makefiles/sun/security/other/Makefile - makefiles/sun/security/smartcardio/FILES_c.gmk - makefiles/sun/security/smartcardio/Makefile - makefiles/sun/security/smartcardio/mapfile-vers - makefiles/sun/security/tools/Makefile - makefiles/sun/security/util/Makefile - makefiles/sun/splashscreen/FILES_c.gmk - makefiles/sun/splashscreen/Makefile - makefiles/sun/splashscreen/mapfile-vers - makefiles/sun/xawt/FILES_c_unix.gmk - makefiles/sun/xawt/FILES_export_unix.gmk - makefiles/sun/xawt/Makefile - makefiles/sun/xawt/mapfile-vers From alan.bateman at oracle.com Mon Jun 18 03:21:34 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 18 Jun 2012 10:21:34 +0000 Subject: hg: jdk8/tl/jdk: 7177617: TEST_BUG: java/nio/channels/AsyncCloseAndInterrupt.java failing (win) Message-ID: <20120618102158.DF6BC479B0@hg.openjdk.java.net> Changeset: 689129c71ccd Author: alanb Date: 2012-06-18 11:19 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/689129c71ccd 7177617: TEST_BUG: java/nio/channels/AsyncCloseAndInterrupt.java failing (win) Reviewed-by: chegar, coffeys ! test/java/nio/channels/AsyncCloseAndInterrupt.java ! test/java/nio/channels/SocketChannel/AdaptSocket.java + test/java/nio/channels/SocketChannel/CloseDuringWrite.java ! test/java/nio/channels/TestUtil.java From weijun.wang at oracle.com Mon Jun 18 19:07:54 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 19 Jun 2012 10:07:54 +0800 Subject: Request for refactoring: Config.getXXX() Message-ID: <4FDFDEFA.6000005@oracle.com> This is about the internal class sun.security.krb5.Config. If you want to get a value from inside krb5.conf, you can call getDefault(String). This might be good to get a value from the [libdefaults] section. However, the method was designed to be so smart that it can recursively search for key/value pairs no matter how deep it is. For example, given a krb5.conf [s1] a=b [s2] c=d [s3] e = { f = g } getDefault("a") = "b", getDefault("c") = "d", and astonishingly, getDefault("f") = "g". I don't think this is a good design, for several reasons: 1. It depends on the order of sections if there are key/value pairs with the same key. 2. It ignores wrong settings. For example, when doing a cross-realm auth, the Realm.getRealmsList(from,to) is used to get a path which should be defined in [capaths]. However, the method simply crawls recursively into any subsection it found and won't notice the [capaths] being mistakenly typed as [capath] 3. It lacks certain features. Because the function always return a String (same with the getDefault(String,String) method), getDefault("e") can only return a null. Therefore there is no way to find out the existence of the subsection e unless we also know it contains a key f. 4. The current Config class needs to know what subsections contains more subsections, and it hardcodes names like [capaths] and [realms]. In short, it's just too smart and becomes unsafe to use. I suggest removing all this smartness and a user must use the full paths to get a value, say, kdc = config.get("realms", "SUN.COM", "kdc") My full spec is: 1. The Config class should understand a krb5.conf without knowing any specific section names. All it maintains is a Value, which can be either of String List TreeMap Here I use TreeMap to preserve the order (might not be necessary). 2. The basic retrieval method will be Value get(String... key) 3. There are simply methods if you already know what the type in your case is String getAsString(String... key) List getAsStringList(String... key) The compatibility risk will be low, and if there really comes a compatibility issue, most likely it will be because the caller had written his krb5.conf wrong. One of the advantages of the original design is that when a key is provided in both [libdefaults] and a given realm, the method can find it anyway. This will be useful for keys like kdc_timeout, max_retries. However, I think this automatic retrieval is confusing and error-prone, I'd rather manually call the get() method twice. Thanks Max From masayoshi.okutsu at oracle.com Tue Jun 19 00:32:31 2012 From: masayoshi.okutsu at oracle.com (masayoshi.okutsu at oracle.com) Date: Tue, 19 Jun 2012 07:32:31 +0000 Subject: hg: jdk8/tl/jdk: 6380549: (rb) ResourceBundle.Control global binding support Message-ID: <20120619073244.61B58479E4@hg.openjdk.java.net> Changeset: 4419c8f0b2f2 Author: okutsu Date: 2012-06-19 16:21 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4419c8f0b2f2 6380549: (rb) ResourceBundle.Control global binding support Reviewed-by: naoto ! make/java/java/FILES_java.gmk ! src/share/classes/java/util/ResourceBundle.java + src/share/classes/java/util/spi/ResourceBundleControlProvider.java + test/java/util/spi/ResourceBundleControlProvider/UserDefaultControlTest.java + test/java/util/spi/ResourceBundleControlProvider/UserDefaultControlTest.sh + test/java/util/spi/ResourceBundleControlProvider/providersrc/Makefile + test/java/util/spi/ResourceBundleControlProvider/providersrc/UserControlProvider.java + test/java/util/spi/ResourceBundleControlProvider/providersrc/UserXMLControl.java + test/java/util/spi/ResourceBundleControlProvider/providersrc/XmlRB.xml + test/java/util/spi/ResourceBundleControlProvider/providersrc/XmlRB_ja.xml + test/java/util/spi/ResourceBundleControlProvider/providersrc/java.util.spi.ResourceBundleControlProvider + test/java/util/spi/ResourceBundleControlProvider/rbcontrolprovider.jar From chris.hegarty at oracle.com Tue Jun 19 02:21:47 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 19 Jun 2012 09:21:47 +0000 Subject: hg: jdk8/tl/jdk: 6901992: InvalidJarIndexException due to bug in sun.misc.JarIndex.merge() Message-ID: <20120619092249.4B557479EA@hg.openjdk.java.net> Changeset: efc2791d7c5d Author: chegar Date: 2012-06-19 10:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/efc2791d7c5d 6901992: InvalidJarIndexException due to bug in sun.misc.JarIndex.merge() Reviewed-by: chegar Contributed-by: dbelfer at gmail.com ! src/share/classes/sun/misc/JarIndex.java + test/sun/misc/JarIndex/JarIndexMergeForClassLoaderTest.java + test/sun/misc/JarIndex/JarIndexMergeTest.java From maurizio.cimadamore at oracle.com Tue Jun 19 05:27:14 2012 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Tue, 19 Jun 2012 12:27:14 +0000 Subject: hg: jdk8/tl/langtools: 7177701: error: Filling jar message during javax/imageio/metadata/IIOMetadataFormatImpl compilation Message-ID: <20120619122716.D48CE479ED@hg.openjdk.java.net> Changeset: 34e254ffd0e7 Author: mcimadamore Date: 2012-06-19 13:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/34e254ffd0e7 7177701: error: Filling jar message during javax/imageio/metadata/IIOMetadataFormatImpl compilation Summary: Recent JDK hash changes affected order in which files are returned from JavacFileManager.list() Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java From vincent.x.ryan at oracle.com Tue Jun 19 12:52:12 2012 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Tue, 19 Jun 2012 20:52:12 +0100 Subject: 7168191: Signature validation can fail under certain circumstances Message-ID: <4FE0D86C.6070308@oracle.com> Hello, Please review the following changeset for JDK 7u6: http://cr.openjdk.java.net/~vinnie/7168191/webrev.01 The bug report is at: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7168191 This fix addresses a bug in the OCSP client when processing key-rollover certs. Typically such certs have the same subject name but different keys. Now the OCSP code examines all the matching candidates (not just the first one) both when preparing the request and when validating the response. Thanks. From mstjohns at comcast.net Tue Jun 19 13:48:49 2012 From: mstjohns at comcast.net (Michael StJohns) Date: Tue, 19 Jun 2012 16:48:49 -0400 Subject: 7168191: Signature validation can fail under certain circumstances In-Reply-To: <4FE0D86C.6070308@oracle.com> References: <4FE0D86C.6070308@oracle.com> Message-ID: <781F0ED6-998C-459C-AC94-70EEB8BAE8DF@comcast.net> Hi - there's two different varieties of authorityKeyIdentifier - you only fixed one. If the child cert has an akid consisting of the value of the parent skid, then you're good to go. But there's also the akid variant which contains issuerName/serialNumber of its parent where the parent has no skid. Mike Sent from my iPad On Jun 19, 2012, at 15:52, Vincent Ryan wrote: > Hello, > > Please review the following changeset for JDK 7u6: > http://cr.openjdk.java.net/~vinnie/7168191/webrev.01 > > The bug report is at: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7168191 > > This fix addresses a bug in the OCSP client when processing key-rollover > certs. Typically such certs have the same subject name but different > keys. Now the OCSP code examines all the matching candidates (not just > the first one) both when preparing the request and when validating the > response. > > Thanks. From xuelei.fan at oracle.com Tue Jun 19 17:29:18 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Wed, 20 Jun 2012 00:29:18 +0000 Subject: hg: jdk8/tl/jdk: 7166487: checkSequenceNumber method never called within readRecord of SSLEngineImpl Message-ID: <20120620002935.1B2C147A0D@hg.openjdk.java.net> Changeset: cdcbd22cfb9d Author: xuelei Date: 2012-06-19 17:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cdcbd22cfb9d 7166487: checkSequenceNumber method never called within readRecord of SSLEngineImpl Reviewed-by: weijun ! src/share/classes/sun/security/ssl/SSLEngineImpl.java From vincent.x.ryan at oracle.com Wed Jun 20 06:49:50 2012 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Wed, 20 Jun 2012 14:49:50 +0100 Subject: 7168191: Signature validation can fail under certain circumstances In-Reply-To: <781F0ED6-998C-459C-AC94-70EEB8BAE8DF@comcast.net> References: <4FE0D86C.6070308@oracle.com> <781F0ED6-998C-459C-AC94-70EEB8BAE8DF@comcast.net> Message-ID: <4FE1D4FE.6030405@oracle.com> Hello Michael, Thanks for your review comments. The cert path implementation in JDK currently doesn't support that AKID variant. I don't think that it is commonly used. Especially since RFC 5280 requires the SKID extension to be present in all CA certs. Would you like me to file an RFE to add support for it? On 06/19/12 09:48 PM, Michael StJohns wrote: > Hi - there's two different varieties of authorityKeyIdentifier - you only fixed one. > > If the child cert has an akid consisting of the value of the parent skid, then you're good to go. But there's also the akid variant which contains issuerName/serialNumber of its parent where the parent has no skid. > > Mike > > Sent from my iPad > > On Jun 19, 2012, at 15:52, Vincent Ryan wrote: > >> Hello, >> >> Please review the following changeset for JDK 7u6: >> http://cr.openjdk.java.net/~vinnie/7168191/webrev.01 >> >> The bug report is at: >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7168191 >> >> This fix addresses a bug in the OCSP client when processing key-rollover >> certs. Typically such certs have the same subject name but different >> keys. Now the OCSP code examines all the matching candidates (not just >> the first one) both when preparing the request and when validating the >> response. >> >> Thanks. From mstjohns at comcast.net Wed Jun 20 07:40:10 2012 From: mstjohns at comcast.net (Michael StJohns) Date: Wed, 20 Jun 2012 10:40:10 -0400 Subject: 7168191: Signature validation can fail under certain circumstances In-Reply-To: <4FE1D4FE.6030405@oracle.com> References: <4FE0D86C.6070308@oracle.com> <781F0ED6-998C-459C-AC94-70EEB8BAE8DF@comcast.net> <4FE1D4FE.6030405@oracle.com> Message-ID: <20120620144027.E7D83635E@mail.openjdk.java.net> At 09:49 AM 6/20/2012, Vincent Ryan wrote: >Hello Michael, > >Thanks for your review comments. > >The cert path implementation in JDK currently doesn't support that AKID >variant. I don't think that it is commonly used. Especially since RFC 5280 requires the SKID extension to be present in all CA certs. > >Would you like me to file an RFE to add support for it? OK - that's a fair statement. Part of the issue is that not all CAs are 5280 compliant (see for example the recent discussion on setting the critical bit of the NameConstraints extension on the IETF PKIX mailing list). I'm wondering if perhaps your path code should throw an error if either the parent certificate does not have an SKID or if the child certificate does not have an AKID with a keyIdentifier? (Or at least an option to trigger that "strict" behavior to identify non-compliant certs). Upon reflection, I don't think an RFE is necessary. The only applicable case is where the CA cert was issued without an SKID and needed to create AKIDs in child certs which mostly shouldn't happen. And that leaves us with the problem where the root key may not be bound into a certificate at all. Thanks! Mike >On 06/19/12 09:48 PM, Michael StJohns wrote: >>Hi - there's two different varieties of authorityKeyIdentifier - you only fixed one. >> >>If the child cert has an akid consisting of the value of the parent skid, then you're good to go. But there's also the akid variant which contains issuerName/serialNumber of its parent where the parent has no skid. >> >>Mike >> >>Sent from my iPad >> >>On Jun 19, 2012, at 15:52, Vincent Ryan wrote: >> >>>Hello, >>> >>>Please review the following changeset for JDK 7u6: >>> http://cr.openjdk.java.net/~vinnie/7168191/webrev.01 >>> >>>The bug report is at: >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7168191 >>> >>>This fix addresses a bug in the OCSP client when processing key-rollover >>>certs. Typically such certs have the same subject name but different >>>keys. Now the OCSP code examines all the matching candidates (not just >>>the first one) both when preparing the request and when validating the >>>response. >>> >>>Thanks. From steve.read at microfocus.com Wed Jun 20 08:19:17 2012 From: steve.read at microfocus.com (Steven Read) Date: Wed, 20 Jun 2012 15:19:17 +0000 (UTC) Subject: Code review request, CR =?utf-8?b?NzE3NDI0NCwJTlBF?= in Krb5ProxyImpl.getServerKeys() References: <4FCF4C9E.8080401@oracle.com> <4FCF5715.2010206@oracle.com> <4FCF597F.8050307@oracle.com> <4FD206F0.8000407@oracle.com> <4FD68C22.7070307@oracle.com> Message-ID: Xuelei Fan writes: > > Hi Steven, > > JSSE is a provider based framework. And compatibility is one of the > most important facts users concerns. That's to say, a provider > developed for JDK 6 is expected to work with JDK 7. As implies that > sometimes, we cannot changes the specification for some certain cases. > Otherwise, we would run into compatibility issues. For this case, we did > not require supported cipher suites are ordered. Providers may not > implemented to support sorted supported cipher suites. If we update the > spec to require to sort supported cipher suites in preference, we would > face the compatibility issue, and the old providers would not be able to > be used any more. So IMHO, unless there is very very strong concerns, we > are just not able to update the specification. > > The preference order is an option of JSSE providers. Although it is not > specified in API specification, SunJSSE providers would like to keep the > behaviors consistent between different releases. SunJSSE provider > defined the preference since 1.4.2 or earlier. But the preference may be > changed in different builds or releases. You may find that > "SSL_RSA_WITH_RC4_128_MD5" is the most preferable cipher suite in JDK > 1.4.2, but in JDK 7, "TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA384" becomes > the most preferable one. > > So unless you use the default cipher suites, it is not good to trust the > order of supported cipher suites. > > Hope it answers your questions. > > Regards, > Xuelei > Thanks for addressing my questions Xuelei, it is a shame regarding the specification but yes I understand that it is best to stay with the status quo given it isn't new specification and backwards compatability is a concern. It is also better to follow previous behaviour, even when that behaviour hasn't been documented and cannot be relied upon. Best regards Steve From vincent.x.ryan at oracle.com Wed Jun 20 09:24:19 2012 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Wed, 20 Jun 2012 17:24:19 +0100 Subject: 7168191: Signature validation can fail under certain circumstances In-Reply-To: <201206201440.q5KEeR8v014171@acsinet13.oracle.com> References: <4FE0D86C.6070308@oracle.com> <781F0ED6-998C-459C-AC94-70EEB8BAE8DF@comcast.net> <4FE1D4FE.6030405@oracle.com> <201206201440.q5KEeR8v014171@acsinet13.oracle.com> Message-ID: <4FE1F933.3070908@oracle.com> On 06/20/12 03:40 PM, Michael StJohns wrote: > At 09:49 AM 6/20/2012, Vincent Ryan wrote: >> Hello Michael, >> >> Thanks for your review comments. >> >> The cert path implementation in JDK currently doesn't support that AKID >> variant. I don't think that it is commonly used. Especially since RFC 5280 requires the SKID extension to be present in all CA certs. >> >> Would you like me to file an RFE to add support for it? > > > OK - that's a fair statement. Part of the issue is that not all CAs are 5280 compliant (see for example the recent discussion on setting the critical bit of the NameConstraints extension on the IETF PKIX mailing list). > > I'm wondering if perhaps your path code should throw an error if either the parent certificate does not have an SKID or if the child certificate does not have an AKID with a keyIdentifier? (Or at least an option to trigger that "strict" behavior to identify non-compliant certs). > In OCSPChecker.check the AKID extension is examined only when the subject names already match. I'm reluctant to throw an exception in the case where an AKID is not present because that will terminate the loop that is seeking the matching issuer cert. I'd rather log the event and continue. > Upon reflection, I don't think an RFE is necessary. The only applicable case is where the CA cert was issued without an SKID and needed to create AKIDs in child certs which mostly shouldn't happen. And that leaves us with the problem where the root key may not be bound into a certificate at all. > OK. Thanks. > > Thanks! Mike > > > > >> On 06/19/12 09:48 PM, Michael StJohns wrote: >>> Hi - there's two different varieties of authorityKeyIdentifier - you only fixed one. >>> >>> If the child cert has an akid consisting of the value of the parent skid, then you're good to go. But there's also the akid variant which contains issuerName/serialNumber of its parent where the parent has no skid. >>> >>> Mike >>> >>> Sent from my iPad >>> >>> On Jun 19, 2012, at 15:52, Vincent Ryan wrote: >>> >>>> Hello, >>>> >>>> Please review the following changeset for JDK 7u6: >>>> http://cr.openjdk.java.net/~vinnie/7168191/webrev.01 >>>> >>>> The bug report is at: >>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7168191 >>>> >>>> This fix addresses a bug in the OCSP client when processing key-rollover >>>> certs. Typically such certs have the same subject name but different >>>> keys. Now the OCSP code examines all the matching candidates (not just >>>> the first one) both when preparing the request and when validating the >>>> response. >>>> >>>> Thanks. > > From jonathan.gibbons at oracle.com Wed Jun 20 13:37:07 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 20 Jun 2012 20:37:07 +0000 Subject: hg: jdk8/tl/langtools: 7174143: encapsulate doc comment table Message-ID: <20120620203711.34B2747A3E@hg.openjdk.java.net> Changeset: 5c0b3faeb0b0 Author: jjg Date: 2012-06-20 13:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5c0b3faeb0b0 7174143: encapsulate doc comment table Reviewed-by: ksrini, mcimadamore ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/jvm/CRTable.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java - src/share/classes/com/sun/tools/javac/parser/EndPosTable.java ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + src/share/classes/com/sun/tools/javac/parser/SimpleDocCommentTable.java ! src/share/classes/com/sun/tools/javac/parser/Tokens.java + src/share/classes/com/sun/tools/javac/tree/DocCommentTable.java + src/share/classes/com/sun/tools/javac/tree/EndPosTable.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/util/DiagnosticSource.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java ! test/tools/javac/6304921/TestLog.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/tree/DocCommentToplevelTest.java ! test/tools/javac/tree/TreePosTest.java From david.holmes at oracle.com Wed Jun 20 21:41:37 2012 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Thu, 21 Jun 2012 04:41:37 +0000 Subject: hg: jdk8/tl/jdk: 7178483: Change version string for Embedded releases Message-ID: <20120621044159.3FDE547A59@hg.openjdk.java.net> Changeset: dfe5617c18b4 Author: dholmes Date: 2012-06-20 22:40 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dfe5617c18b4 7178483: Change version string for Embedded releases Reviewed-by: dholmes, lancea Contributed-by: Gary Collins ! make/common/Defs-embedded.gmk From weijun.wang at oracle.com Wed Jun 20 21:50:08 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 21 Jun 2012 12:50:08 +0800 Subject: Request for enhancement: Support KRB5_CONFIG Message-ID: <4FE2A800.9030809@oracle.com> Hi All Oracle's Java currently looks for the krb5.conf file in this order: 1: If -Djava.security.krb5.conf defined, use it 2: If jre/lib/security/krb5.conf found, use it 3: Looking for the system default krb5.conf . /etc/krb5/krb5.conf on Solaris . /etc/krb5.conf on Linux . $WINDOWS/krb5.ini on Windows . edu.mit.Kerberos or krb5.conf on Mac We know native kerberos supports a KRB5_CONFIG env variable for the same purpose. Hereby I suggest adding a check 1.5: If KRB5_CONFIG defined, use it This will work with native Kerberos installation better. But there is one compatibility issue that if you already have this variable set: Current behavior: Java uses /etc/krb5.conf Future behavior: Java uses KRB5_CONFIG I wonder if that will be a problem in a real production environment. Suppose you really have a different krb5.conf, you might have already use -Djava.security.krb5.conf to override it. I have more questions: 1. Is the value of this variable always a file path (either absolute or relative)? Is it possible to be something like file:/etc/krb5.conf? 2. Should it always be honored? Is it possible that in a server environment it should be ignored for security reasons? (If so, I wonder how a server is defined). Any suggestion? Thanks Max From jonathan.gibbons at oracle.com Thu Jun 21 13:22:32 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 21 Jun 2012 20:22:32 +0000 Subject: hg: jdk8/tl/langtools: 7178297: provide mapping from doc comment position to source file position Message-ID: <20120621202236.BD8B347A72@hg.openjdk.java.net> Changeset: 067f51db3402 Author: jjg Date: 2012-06-21 13:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/067f51db3402 7178297: provide mapping from doc comment position to source file position Reviewed-by: mcimadamore, ksrini ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/JavadocTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/Tokens.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java From jonathan.gibbons at oracle.com Fri Jun 22 14:41:13 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 22 Jun 2012 21:41:13 +0000 Subject: hg: jdk8/tl/langtools: 7178763: javadoc OutOfMemory error results in several jdk8 tl nightly failures Message-ID: <20120622214117.3DF7E47ABC@hg.openjdk.java.net> Changeset: 3468519d9b45 Author: jjg Date: 2012-06-22 14:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3468519d9b45 7178763: javadoc OutOfMemory error results in several jdk8 tl nightly failures Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/parser/JavadocTokenizer.java From chris.hegarty at oracle.com Mon Jun 25 06:20:58 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 25 Jun 2012 13:20:58 +0000 Subject: hg: jdk8/tl/jdk: 7176784: Windows authentication not working on some computers Message-ID: <20120625132130.61A1D47AED@hg.openjdk.java.net> Changeset: 4a4a04bfeece Author: chegar Date: 2012-06-25 14:19 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4a4a04bfeece 7176784: Windows authentication not working on some computers Reviewed-by: michaelm ! src/windows/native/sun/net/www/protocol/http/ntlm/NTLMAuthSequence.c From rob.mckenna at oracle.com Tue Jun 26 05:26:20 2012 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Tue, 26 Jun 2012 12:26:20 +0000 Subject: hg: jdk8/tl/jdk: 4244896: (process) Provide System.getPid(), System.killProcess(String pid) Message-ID: <20120626122654.E62D947B19@hg.openjdk.java.net> Changeset: ff0da4ea08a2 Author: robm Date: 2012-06-26 13:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff0da4ea08a2 4244896: (process) Provide System.getPid(), System.killProcess(String pid) Reviewed-by: alanb ! src/share/classes/java/lang/Process.java ! src/solaris/classes/java/lang/UNIXProcess.java.bsd ! src/solaris/classes/java/lang/UNIXProcess.java.linux ! src/solaris/classes/java/lang/UNIXProcess.java.solaris ! src/solaris/native/java/lang/UNIXProcess_md.c ! src/windows/classes/java/lang/ProcessImpl.java ! src/windows/native/java/lang/ProcessImpl_md.c ! test/java/lang/ProcessBuilder/Basic.java + test/java/lang/ProcessBuilder/DestroyTest.java From huizhe.wang at oracle.com Tue Jun 26 15:26:33 2012 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Tue, 26 Jun 2012 22:26:33 +0000 Subject: hg: jdk8/tl/jaxp: 7166896: DocumentBuilder.parse(String uri) is not IPv6 enabled. It throws MalformedURLException Message-ID: <20120626222640.28A1747B2F@hg.openjdk.java.net> Changeset: 7920ead2cc75 Author: joehw Date: 2012-06-26 15:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/7920ead2cc75 7166896: DocumentBuilder.parse(String uri) is not IPv6 enabled. It throws MalformedURLException Summary: skip the added international character handling for general paths Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java From david.holmes at oracle.com Tue Jun 26 22:38:04 2012 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Wed, 27 Jun 2012 05:38:04 +0000 Subject: hg: jdk8/tl/jdk: 7161229: PriorityBlockingQueue keeps hard reference to last removed element Message-ID: <20120627053814.287DF47B46@hg.openjdk.java.net> Changeset: 94b525ce3653 Author: dholmes Date: 2012-06-27 01:36 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94b525ce3653 7161229: PriorityBlockingQueue keeps hard reference to last removed element Reviewed-by: dholmes, forax, alanb Contributed-by: Doug Lea
! src/share/classes/java/util/concurrent/PriorityBlockingQueue.java ! test/java/util/concurrent/BlockingQueue/LastElement.java From lana.steuck at oracle.com Wed Jun 27 00:10:48 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 27 Jun 2012 07:10:48 +0000 Subject: hg: jdk8/tl: 4 new changesets Message-ID: <20120627071049.3FA3047B47@hg.openjdk.java.net> Changeset: 8fb4cd2f05a1 Author: mbykov Date: 2012-06-19 14:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/8fb4cd2f05a1 7178241: Basic script for JDK source code legal headers conformance verification Summary: A new script lic_check.sh to check license headers in JDK source code Reviewed-by: ohair, darcy Contributed-by: misha.bykov at oracle.com + make/scripts/lic_check.sh Changeset: e4f81a817447 Author: katleman Date: 2012-06-20 15:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e4f81a817447 Merge Changeset: 1e989139ce0d Author: katleman Date: 2012-06-21 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/1e989139ce0d Added tag jdk8-b44 for changeset e4f81a817447 ! .hgtags Changeset: 633f2378c904 Author: lana Date: 2012-06-25 21:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/633f2378c904 Merge From lana.steuck at oracle.com Wed Jun 27 00:10:54 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 27 Jun 2012 07:10:54 +0000 Subject: hg: jdk8/tl/jaxws: Added tag jdk8-b44 for changeset f6a417540ef1 Message-ID: <20120627071102.30C6A47B48@hg.openjdk.java.net> Changeset: e80ac58b5ba9 Author: katleman Date: 2012-06-21 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/e80ac58b5ba9 Added tag jdk8-b44 for changeset f6a417540ef1 ! .hgtags From lana.steuck at oracle.com Wed Jun 27 00:10:52 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 27 Jun 2012 07:10:52 +0000 Subject: hg: jdk8/tl/corba: 9 new changesets Message-ID: <20120627071104.591DD47B49@hg.openjdk.java.net> Changeset: ad3ba4b392cc Author: katleman Date: 2012-06-21 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/ad3ba4b392cc Added tag jdk8-b44 for changeset 439d9bf8e4ff ! .hgtags Changeset: 5222b7d658d4 Author: coffeys Date: 2012-03-26 14:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/5222b7d658d4 7143851: Improve IIOP stub and tie generation in RMIC 7149048: Changes to corba rmic stubGenerator class are not used during jdk build process Reviewed-by: mschoene, robm ! src/share/classes/sun/rmi/rmic/iiop/StubGenerator.java Changeset: e324dfb90c9e Author: mbankal Date: 2012-03-28 02:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/e324dfb90c9e 7079902: Refine CORBA data models Reviewed-by: coffeys ! src/share/classes/com/sun/corba/se/impl/interceptors/ClientRequestInfoImpl.java ! src/share/classes/com/sun/corba/se/impl/interceptors/ServerRequestInfoImpl.java ! src/share/classes/com/sun/corba/se/impl/javax/rmi/CORBA/Util.java ! src/share/classes/com/sun/corba/se/impl/oa/poa/POAPolicyMediatorBase_R.java ! src/share/classes/com/sun/corba/se/impl/oa/toa/TOAFactory.java ! src/share/classes/com/sun/corba/se/impl/orb/ParserTable.java ! src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryId_1_3.java ! src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryId_1_3_1.java ! src/share/classes/com/sun/corba/se/impl/protocol/LocalClientRequestDispatcherBase.java ! src/share/classes/com/sun/corba/se/impl/util/RepositoryId.java ! src/share/classes/com/sun/corba/se/spi/logging/CORBALogDomains.java ! src/share/classes/sun/rmi/rmic/iiop/IDLNames.java Changeset: 2846cb957582 Author: mbankal Date: 2012-03-28 02:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/2846cb957582 Merge Changeset: a00c5c0b1f30 Author: asaha Date: 2012-04-10 10:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/a00c5c0b1f30 Merge - make/tools/src/build/tools/stripproperties/StripProperties.java Changeset: 3697feea6f54 Author: asaha Date: 2012-05-08 07:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/3697feea6f54 Merge Changeset: 787fb5a0602f Author: asaha Date: 2012-05-21 14:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/787fb5a0602f Merge Changeset: 25bb958d07de Author: asaha Date: 2012-06-07 12:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/25bb958d07de Merge Changeset: 747dad9e9d37 Author: lana Date: 2012-06-26 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/747dad9e9d37 Merge From lana.steuck at oracle.com Wed Jun 27 00:11:03 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 27 Jun 2012 07:11:03 +0000 Subject: hg: jdk8/tl/langtools: 2 new changesets Message-ID: <20120627071110.BBD3A47B4A@hg.openjdk.java.net> Changeset: a39c99192184 Author: katleman Date: 2012-06-21 17:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a39c99192184 Added tag jdk8-b44 for changeset 59cbead12ff4 ! .hgtags Changeset: e111e4587cca Author: lana Date: 2012-06-25 21:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e111e4587cca Merge - src/share/classes/com/sun/tools/javac/parser/EndPosTable.java From lana.steuck at oracle.com Wed Jun 27 00:11:25 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 27 Jun 2012 07:11:25 +0000 Subject: hg: jdk8/tl/jaxp: 8 new changesets Message-ID: <20120627071151.E60B247B4B@hg.openjdk.java.net> Changeset: a5c1047a05e9 Author: katleman Date: 2012-06-21 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a5c1047a05e9 Added tag jdk8-b44 for changeset 0b3f3a4ce139 ! .hgtags Changeset: 54a86b897fe8 Author: lana Date: 2012-06-25 21:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/54a86b897fe8 Merge Changeset: d117133a7283 Author: joehw Date: 2012-04-10 13:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/d117133a7283 7157609: Issues with loop Reviewed-by: hawtin, lancea, asaha ! src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLScanner.java Changeset: 0e635b48336a Author: asaha Date: 2012-05-08 07:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/0e635b48336a Merge = src/com/sun/org/apache/xerces/internal/impl/XMLScanner.java < src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLScanner.java - src/share/classes/com/sun/java_cup/internal/runtime/Scanner.java - src/share/classes/com/sun/java_cup/internal/runtime/Symbol.java - src/share/classes/com/sun/java_cup/internal/runtime/lr_parser.java - src/share/classes/com/sun/java_cup/internal/runtime/virtual_parse_stack.java - src/share/classes/com/sun/org/apache/bcel/internal/Constants.java - src/share/classes/com/sun/org/apache/bcel/internal/ExceptionConstants.java - src/share/classes/com/sun/org/apache/bcel/internal/Repository.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/AccessFlags.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Attribute.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/AttributeReader.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ClassFormatException.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ClassParser.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Code.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/CodeException.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Constant.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantCP.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantClass.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantDouble.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantFieldref.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantFloat.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantInteger.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantInterfaceMethodref.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantLong.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantMethodref.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantNameAndType.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantObject.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantPool.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantString.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantUtf8.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantValue.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Deprecated.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/DescendingVisitor.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/EmptyVisitor.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ExceptionTable.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Field.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/FieldOrMethod.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/InnerClass.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/InnerClasses.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/JavaClass.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/LineNumber.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/LineNumberTable.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/LocalVariable.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/LocalVariableTable.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Method.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Node.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/PMGClass.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Signature.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/SourceFile.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/StackMap.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/StackMapEntry.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/StackMapType.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Synthetic.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Unknown.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Utility.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Visitor.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/package.html - src/share/classes/com/sun/org/apache/bcel/internal/generic/AALOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/AASTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ACONST_NULL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ALOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ANEWARRAY.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ARETURN.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ARRAYLENGTH.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ASTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ATHROW.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/AllocationInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ArithmeticInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ArrayInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ArrayType.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/BALOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/BASTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/BIPUSH.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/BREAKPOINT.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/BasicType.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/BranchHandle.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/BranchInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/CALOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/CASTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/CHECKCAST.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/CPInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ClassGen.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ClassGenException.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ClassObserver.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/CodeExceptionGen.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/CompoundInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ConstantPoolGen.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ConstantPushInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ConversionInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/D2F.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/D2I.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/D2L.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DADD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DALOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DASTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DCMPG.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DCMPL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DCONST.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DDIV.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DLOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DMUL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DNEG.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DREM.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DRETURN.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DSTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DSUB.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DUP.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DUP2.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DUP2_X1.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DUP2_X2.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DUP_X1.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DUP_X2.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/EmptyVisitor.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ExceptionThrower.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/F2D.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/F2I.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/F2L.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FADD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FALOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FASTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FCMPG.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FCMPL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FCONST.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FDIV.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FLOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FMUL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FNEG.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FREM.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FRETURN.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FSTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FSUB.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FieldGen.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FieldGenOrMethodGen.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FieldInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FieldObserver.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FieldOrMethod.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/GETFIELD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/GETSTATIC.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/GOTO.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/GOTO_W.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/GotoInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/I2B.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/I2C.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/I2D.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/I2F.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/I2L.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/I2S.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IADD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IALOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IAND.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IASTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ICONST.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IDIV.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IFEQ.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IFGE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IFGT.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IFLE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IFLT.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IFNE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IFNONNULL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IFNULL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IF_ACMPEQ.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IF_ACMPNE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IF_ICMPEQ.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IF_ICMPGE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IF_ICMPGT.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IF_ICMPLE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IF_ICMPLT.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IF_ICMPNE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IINC.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ILOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IMPDEP1.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IMPDEP2.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IMUL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/INEG.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/INSTANCEOF.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/INVOKEINTERFACE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/INVOKESPECIAL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/INVOKESTATIC.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/INVOKEVIRTUAL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IOR.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IREM.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IRETURN.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ISHL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ISHR.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ISTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ISUB.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IUSHR.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IXOR.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IfInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IndexedInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/Instruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionComparator.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionConstants.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionFactory.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionHandle.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionList.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionListObserver.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionTargeter.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/InvokeInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/JSR.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/JSR_W.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/JsrInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/L2D.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/L2F.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/L2I.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LADD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LALOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LAND.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LASTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LCMP.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LCONST.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LDC.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LDC2_W.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LDC_W.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LDIV.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LLOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LMUL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LNEG.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LOOKUPSWITCH.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LOR.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LREM.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LRETURN.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LSHL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LSHR.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LSTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LSUB.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LUSHR.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LXOR.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LineNumberGen.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LoadClass.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LoadInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LocalVariableGen.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LocalVariableInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/MONITORENTER.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/MONITOREXIT.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/MULTIANEWARRAY.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/MethodGen.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/MethodObserver.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/NEW.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/NEWARRAY.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/NOP.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/NamedAndTyped.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ObjectType.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/POP.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/POP2.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/PUSH.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/PUTFIELD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/PUTSTATIC.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/PopInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/PushInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/RET.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/RETURN.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ReferenceType.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ReturnInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ReturnaddressType.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/SALOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/SASTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/SIPUSH.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/SWAP.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/SWITCH.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/Select.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/StackConsumer.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/StackInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/StackProducer.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/StoreInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/TABLESWITCH.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/TargetLostException.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/Type.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/TypedInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/UnconditionalBranch.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/VariableLengthInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/Visitor.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/package.html - src/share/classes/com/sun/org/apache/bcel/internal/package.html - src/share/classes/com/sun/org/apache/bcel/internal/util/AttributeHTML.java - src/share/classes/com/sun/org/apache/bcel/internal/util/BCELFactory.java - src/share/classes/com/sun/org/apache/bcel/internal/util/BCELifier.java - src/share/classes/com/sun/org/apache/bcel/internal/util/ByteSequence.java - src/share/classes/com/sun/org/apache/bcel/internal/util/Class2HTML.java - src/share/classes/com/sun/org/apache/bcel/internal/util/ClassLoader.java - src/share/classes/com/sun/org/apache/bcel/internal/util/ClassLoaderRepository.java - src/share/classes/com/sun/org/apache/bcel/internal/util/ClassPath.java - src/share/classes/com/sun/org/apache/bcel/internal/util/ClassQueue.java - src/share/classes/com/sun/org/apache/bcel/internal/util/ClassSet.java - src/share/classes/com/sun/org/apache/bcel/internal/util/ClassStack.java - src/share/classes/com/sun/org/apache/bcel/internal/util/ClassVector.java - src/share/classes/com/sun/org/apache/bcel/internal/util/CodeHTML.java - src/share/classes/com/sun/org/apache/bcel/internal/util/ConstantHTML.java - src/share/classes/com/sun/org/apache/bcel/internal/util/InstructionFinder.java - src/share/classes/com/sun/org/apache/bcel/internal/util/JavaWrapper.java - src/share/classes/com/sun/org/apache/bcel/internal/util/MethodHTML.java - src/share/classes/com/sun/org/apache/bcel/internal/util/Repository.java - src/share/classes/com/sun/org/apache/bcel/internal/util/SyntheticRepository.java - src/share/classes/com/sun/org/apache/bcel/internal/util/package.html - src/share/classes/com/sun/org/apache/regexp/internal/CharacterArrayCharacterIterator.java - src/share/classes/com/sun/org/apache/regexp/internal/CharacterIterator.java - src/share/classes/com/sun/org/apache/regexp/internal/RE.java - src/share/classes/com/sun/org/apache/regexp/internal/RECompiler.java - src/share/classes/com/sun/org/apache/regexp/internal/REDebugCompiler.java - src/share/classes/com/sun/org/apache/regexp/internal/REProgram.java - src/share/classes/com/sun/org/apache/regexp/internal/RESyntaxException.java - src/share/classes/com/sun/org/apache/regexp/internal/RETest.java - src/share/classes/com/sun/org/apache/regexp/internal/REUtil.java - src/share/classes/com/sun/org/apache/regexp/internal/ReaderCharacterIterator.java - src/share/classes/com/sun/org/apache/regexp/internal/StreamCharacterIterator.java - src/share/classes/com/sun/org/apache/regexp/internal/StringCharacterIterator.java - src/share/classes/com/sun/org/apache/regexp/internal/recompile.java - src/share/classes/com/sun/org/apache/xalan/META-INF/services/javax.xml.transform.TransformerFactory - src/share/classes/com/sun/org/apache/xalan/META-INF/services/javax.xml.xpath.XPathFactory - src/share/classes/com/sun/org/apache/xalan/META-INF/services/org.apache.xml.dtm.DTMManager - src/share/classes/com/sun/org/apache/xalan/internal/Version.java - src/share/classes/com/sun/org/apache/xalan/internal/extensions/ExpressionContext.java - src/share/classes/com/sun/org/apache/xalan/internal/extensions/package.html - src/share/classes/com/sun/org/apache/xalan/internal/lib/ExsltBase.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/ExsltCommon.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/ExsltDatetime.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/ExsltDynamic.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/ExsltMath.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/ExsltSets.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/ExsltStrings.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/Extensions.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/NodeInfo.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/ObjectFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/SecuritySupport.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/package.html - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLMessages.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_de.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_en.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_es.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_fr.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_it.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_ja.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_ko.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_pt_BR.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_sv.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_zh_CN.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_zh_TW.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTInfo.properties - src/share/classes/com/sun/org/apache/xalan/internal/res/package.html - src/share/classes/com/sun/org/apache/xalan/internal/templates/Constants.java - src/share/classes/com/sun/org/apache/xalan/internal/templates/package.html - src/share/classes/com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java - src/share/classes/com/sun/org/apache/xalan/internal/xslt/ObjectFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/xslt/Process.java - src/share/classes/com/sun/org/apache/xalan/internal/xslt/SecuritySupport.java - src/share/classes/com/sun/org/apache/xalan/internal/xslt/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xalan/internal/xslt/package.html - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/CollatorFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/DOM.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/DOMCache.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/DOMEnhancedForDTM.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/NodeIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/ProcessorVersion.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/StripFilter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/Translet.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/TransletException.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/cmdline/Compile.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/cmdline/ObjectFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/cmdline/SecuritySupport.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/cmdline/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/cmdline/Transform.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/cmdline/getopt/GetOpt.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/cmdline/getopt/GetOptsException.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/cmdline/getopt/IllegalArgumentException.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/cmdline/getopt/MissingOptArgException.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AbsoluteLocationPath.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AbsolutePathPattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AlternativePattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AncestorPattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ApplyImports.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ApplyTemplates.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ArgumentList.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Attribute.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AttributeSet.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AttributeValue.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AttributeValueTemplate.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/BinOpExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/BooleanCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/BooleanExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CallTemplate.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CastCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CastExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CeilingCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Choose.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Closure.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Comment.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CompilerException.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ConcatCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Constants.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ContainsCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Copy.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CopyOf.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CurrentCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/DecimalFormatting.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/DocumentCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ElementAvailableCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/EqualityExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Expression.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Fallback.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FilterExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FilterParentPath.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FilteredAbsoluteLocationPath.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FloorCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FlowList.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ForEach.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FormatNumberCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionAvailableCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/GenerateIdCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/IdKeyPattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/IdPattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/If.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/IllegalCharException.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Import.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Include.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Instruction.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/IntExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Key.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/KeyCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/KeyPattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LangCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LastCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LiteralAttribute.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LiteralElement.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LiteralExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LocalNameCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LocationPathPattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LogicalExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Makefile.inc - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Message.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Mode.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/NameBase.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/NameCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/NamespaceAlias.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/NamespaceUriCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/NodeTest.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/NotCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Number.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/NumberCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ObjectFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Otherwise.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Output.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Param.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ParameterRef.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ParentLocationPath.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ParentPattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Parser.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Pattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/PositionCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Predicate.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ProcessingInstruction.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ProcessingInstructionPattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/QName.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/RealExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/RelationalExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/RelativeLocationPath.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/RelativePathPattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/RoundCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/SecuritySupport.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/SimpleAttributeValue.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Sort.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/SourceLoader.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/StartsWithCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Step.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/StepPattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/StringCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/StringLengthCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Stylesheet.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/SymbolTable.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/SyntaxTreeNode.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Template.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/TestSeq.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Text.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/TopLevelElement.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/TransletOutput.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/UnaryOpExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/UnionPathExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/UnparsedEntityUriCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/UnresolvedRef.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/UnsupportedElement.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/UseAttributeSets.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ValueOf.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Variable.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/VariableBase.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/VariableRef.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/VariableRefBase.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/When.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Whitespace.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/WithParam.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/XPathLexer.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/XPathParser.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/XSLTC.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/XslAttribute.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/XslElement.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/sym.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/AttributeSetMethodGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/BooleanType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ClassGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/CompareGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ca.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_cs.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_de.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_es.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_fr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_it.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ja.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ko.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_pt_BR.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sk.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sv.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_CN.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_TW.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMsg.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/FilterGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/IntType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/MatchGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/MethodGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/MethodType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/MultiHashtable.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/NamedMethodGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/NodeCounterGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/NodeSetType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/NodeSortRecordFactGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/NodeSortRecordGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/NodeType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/NumberType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ObjectFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ObjectType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/RealType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ReferenceType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ResultTreeType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/RtMethodGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/SecuritySupport.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/SlotAllocator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/StringStack.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/StringType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/TestGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/Type.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/TypeCheckError.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/Util.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/VoidType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/xpath.cup - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/xpath.lex - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/AbsoluteIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/AdaptiveResultTreeImpl.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/AnyNodeCounter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/BitArray.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/CachedNodeListIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/ClonedNodeListIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/CollatorFactoryBase.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/CurrentNodeListFilter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/CurrentNodeListIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DOMAdapter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DOMBuilder.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DOMWSFilter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DocumentCache.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DupFilterIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/EmptyFilter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/ExtendedSAX.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/Filter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/FilterIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/FilteredStepIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/ForwardPositionIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/KeyIndex.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/LoadDocument.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/MatchingIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/MultiDOM.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/MultiValuedNodeHeapIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/MultipleNodeCounter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/NodeCounter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/NodeIteratorBase.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/NodeSortRecord.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/NodeSortRecordFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/NthIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/ObjectFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/SAXImpl.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/SecuritySupport.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/SimpleResultTreeImpl.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/SingleNodeCounter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/SingletonIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/SortSettings.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/SortingIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/StepIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/StripWhitespaceFilter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/UnionIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/XSLTCDTMManager.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/javax.xml.transform.TransformerFactory - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/AbstractTranslet.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/Attributes.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/BasisLibrary.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/Constants.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_ca.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_cs.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_de.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_es.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_fr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_it.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_ja.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_ko.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_pt_BR.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_sk.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_sv.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_zh_CN.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_zh_TW.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/Hashtable.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/MessageHandler.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/Node.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ObjectFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/Operators.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/Parameter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/SecuritySupport.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/StringValueHandler.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/output/OutputBuffer.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/output/StringOutputBuffer.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/output/TransletOutputHandlerFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/output/WriterOutputBuffer.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/DOM2SAX.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/DOM2TO.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/ObjectFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/OutputSettings.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/SAX2DOM.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/SAX2StAXBaseWriter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/SAX2StAXEventWriter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/SAX2StAXStreamWriter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/SecuritySupport.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/SmartTransformerFactoryImpl.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/StAXEvent2SAX.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/StAXStream2SAX.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesHandlerImpl.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesImpl.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TrAXFilter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerHandlerImpl.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/Util.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/XSLTCSource.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/util/IntegerArray.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/AttrImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/AttrNSImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/AttributeMap.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/CDATASectionImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/CharacterDataImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/ChildNode.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/CommentImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/CoreDOMImplementationImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/CoreDocumentImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMErrorImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMImplementationImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMImplementationListImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMImplementationSourceImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMInputImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMLocatorImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMMessageFormatter.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMNormalizer.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMOutputImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMStringListImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMXSImplementationSourceImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeepNodeListImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredAttrImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredAttrNSImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredCDATASectionImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredCommentImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredDOMImplementationImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredDocumentImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredDocumentTypeImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredElementDefinitionImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredElementImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredEntityImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredEntityReferenceImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredNode.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredNotationImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredProcessingInstructionImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredTextImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DocumentFragmentImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DocumentImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DocumentTypeImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/ElementDefinitionImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/ElementImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/ElementNSImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/EntityImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/EntityReferenceImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/LCount.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/NamedNodeMapImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/NodeImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/NodeIteratorImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/NodeListCache.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/NotationImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/ObjectFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/PSVIAttrNSImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/PSVIDOMImplementationImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/PSVIDocumentImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/PSVIElementNSImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/ParentNode.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/ProcessingInstructionImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/RangeExceptionImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/RangeImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/SecuritySupport.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/TextImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/TreeWalkerImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/events/EventImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/events/MutationEventImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/org.apache.xerces.dom.DOMImplementationSourceImpl - src/share/classes/com/sun/org/apache/xerces/internal/dom/org.w3c.dom.DOMImplementationSourceList - src/share/classes/com/sun/org/apache/xerces/internal/impl/Constants.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/ExternalSubsetResolver.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/PropertyManager.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/RevalidationHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/Version.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XML11DTDScannerImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XML11DocumentScannerImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XML11EntityScanner.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XML11NSDocumentScannerImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XML11NamespaceBinder.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDTDScannerImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentScannerImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityDescription.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityScanner.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLErrorReporter.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLNSDocumentScannerImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLNamespaceBinder.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLStreamFilterImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLStreamReaderImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLVersionDetector.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/BalancedDTDGrammar.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/DTDGrammar.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/DTDGrammarBucket.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XML11DTDProcessor.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XML11DTDValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XML11NSDTDValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLAttributeDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLContentSpec.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLDTDDescription.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLDTDLoader.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLDTDProcessor.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLDTDValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLDTDValidatorFilter.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLElementDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLEntityDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLNSDTDValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLNotationDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLSimpleType.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/CMAny.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/CMBinOp.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/CMLeaf.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/CMNode.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/CMStateSet.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/CMUniOp.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/ContentModelValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/DFAContentModel.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/MixedContentModel.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/SimpleContentModel.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/DTDDVFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/DVFactoryException.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/DatatypeException.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/DatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/InvalidDatatypeFacetException.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/InvalidDatatypeValueException.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/ObjectFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/SchemaDVFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/SecuritySupport.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/ValidatedInfo.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/ValidationContext.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/XSFacets.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/XSSimpleType.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/DTDDVFactoryImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/ENTITYDatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/IDDatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/IDREFDatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/ListDatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/NMTOKENDatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/NOTATIONDatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/StringDatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/XML11DTDDVFactoryImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/XML11IDDatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/XML11IDREFDatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/XML11NMTOKENDatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/util/Base64.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/util/ByteListImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/util/HexBin.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/AbstractDateTimeDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/AnyAtomicDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/AnySimpleDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/AnyURIDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/Base64BinaryDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/BaseDVFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/BaseSchemaDVFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/BooleanDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/DateDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/DateTimeDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/DayDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/DayTimeDurationDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/DecimalDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/DoubleDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/DurationDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/EntityDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/ExtendedSchemaDVFactoryImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/FloatDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/FullDVFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/HexBinaryDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/IDDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/IDREFDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/IntegerDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/ListDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/MonthDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/MonthDayDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/PrecisionDecimalDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/QNameDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/SchemaDVFactoryImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/SchemaDateTimeException.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/StringDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/TimeDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/TypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/UnionDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/XSSimpleTypeDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/XSSimpleTypeDelegate.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/YearDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/YearMonthDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/YearMonthDurationDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/io/ASCIIReader.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/io/MalformedByteSequenceException.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/io/UCSReader.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/io/UTF8Reader.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_de.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_es.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_fr.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_it.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_ja.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_ko.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_pt_BR.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_sv.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_zh_CN.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_zh_TW.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_de.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_es.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_fr.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_it.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_ja.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_ko.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_pt_BR.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_sv.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_zh_CN.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_zh_TW.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_de.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_es.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_fr.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_it.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_ja.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_ko.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_pt_BR.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_sv.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_zh_CN.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_zh_TW.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_de.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_es.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_fr.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_it.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_ja.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_ko.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_pt_BR.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_sv.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_zh_CN.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_zh_TW.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_de.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_es.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_fr.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_it.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_ja.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_ko.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_pt_BR.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_sv.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_zh_CN.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_zh_TW.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_de.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_es.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_fr.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_it.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_ja.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_ko.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_pt_BR.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_sv.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_zh_CN.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_zh_TW.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_es.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_fr.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_it.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ja.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ko.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_pt_BR.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_sv.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_CN.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_TW.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_de.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_es.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_fr.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_it.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ja.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ko.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_pt_BR.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_sv.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_CN.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_TW.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_de.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_es.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_fr.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_it.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_ja.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_ko.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_pt_BR.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_sv.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_zh_CN.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_zh_TW.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_de.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_es.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_fr.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_it.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_ja.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_ko.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_pt_BR.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_sv.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_zh_CN.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_zh_TW.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/validation/EntityState.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/validation/ValidationManager.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/validation/ValidationState.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/XPath.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/XPathException.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/BMPattern.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/CaseInsensitiveMap.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/Match.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/Op.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/ParseException.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/ParserForXMLSchema.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/REUtil.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/RangeToken.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/RegexParser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/RegularExpression.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/Token.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/message.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_fr.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_ja.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/AttributePSVImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/ElementPSVImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/SchemaGrammar.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/SchemaNamespaceSupport.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/SchemaSymbols.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/SubstitutionGroupHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaException.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaLoader.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSAnnotationImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSAttributeDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSAttributeGroupDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSAttributeUseImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSComplexTypeDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSConstraints.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSDDescription.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSDeclarationPool.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSElementDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSGrammarBucket.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSGroupDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSImplementationImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSLoaderImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSMessageFormatter.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSModelGroupImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSModelImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSNotationDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSParticleDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSWildcardDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/identity/Field.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/identity/FieldActivator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/identity/IdentityConstraint.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/identity/KeyRef.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/identity/Selector.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/identity/UniqueOrKey.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/identity/ValueStore.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/identity/XPathMatcher.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/CMBuilder.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/CMNodeFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/XSAllCM.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/XSCMBinOp.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/XSCMLeaf.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/XSCMRepeatingLeaf.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/XSCMUniOp.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/XSCMValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/XSDFACM.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/XSEmptyCM.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/AttrImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/DefaultDocument.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/DefaultElement.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/DefaultNode.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/DefaultText.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/DefaultXMLDocumentHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/ElementImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/NamedNodeMapImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/NodeImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/SchemaDOM.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/SchemaDOMImplementation.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/SchemaDOMParser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/SchemaParsingConfig.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/TextImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/SchemaContentHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/StAXSchemaParser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSAnnotationInfo.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSAttributeChecker.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDAbstractIDConstraintTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDAbstractParticleTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDAbstractTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDAttributeGroupTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDAttributeTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDComplexTypeTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDElementTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDGroupTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDKeyrefTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDNotationTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDSimpleTypeTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDUniqueOrKeyTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDWildcardTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDocumentInfo.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/LSInputListImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/ObjectListImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/ShortListImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/SimpleLocator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/StringListImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/XInt.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/XIntPool.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/XSGrammarPool.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/XSInputSource.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/XSNamedMap4Types.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/XSNamedMapImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/XSObjectListImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/DefaultValidationErrorHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderFactoryImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/JAXPConstants.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/JAXPValidatorComponent.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/SAXParserFactoryImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/SchemaValidatorConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/TeeXMLDocumentFilterImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/UnparsedEntityHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/DatatypeFactoryImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/DurationDayTimeImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/DurationImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/DurationYearMonthImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/XMLGregorianCalendarImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/javax.xml.datatype.DatatypeFactory - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/javax.xml.parsers.DocumentBuilderFactory - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/javax.xml.parsers.SAXParserFactory - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/AbstractXMLSchema.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/DOMDocumentHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/DOMResultAugmentor.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/DOMResultBuilder.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/DOMValidatorHelper.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/DraconianErrorHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/EmptyXMLSchema.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/ErrorHandlerAdaptor.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/JAXPValidationMessageFormatter.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/ReadOnlyGrammarPool.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/SimpleXMLSchema.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/SoftReferenceGrammarPool.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/StAXValidatorHelper.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/StreamValidatorHelper.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/Util.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHandlerImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHelper.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/WeakReferenceXMLSchema.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/WrappedSAXException.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchema.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaValidatorComponentManager.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/XSGrammarPoolContainer.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/javax.xml.validation.SchemaFactory - src/share/classes/com/sun/org/apache/xerces/internal/parsers/AbstractDOMParser.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/AbstractSAXParser.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/AbstractXMLDocumentParser.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/BasicParserConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/CachingParserPool.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/DOMParser.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/DOMParserImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/DTDConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/DTDParser.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/IntegratedParserConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/NonValidatingConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/ObjectFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/SAXParser.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/SecurityConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/SecuritySupport.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/StandardParserConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XIncludeAwareParserConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XIncludeParserConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11Configurable.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11DTDConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11NonValidatingConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XMLDocumentParser.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XMLGrammarCachingConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XMLGrammarParser.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XMLGrammarPreparser.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XMLParser.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XPointerParserConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/org.apache.xerces.xni.parser.DTDConfiguration - src/share/classes/com/sun/org/apache/xerces/internal/parsers/org.apache.xerces.xni.parser.XML11Configuration - src/share/classes/com/sun/org/apache/xerces/internal/parsers/org.apache.xerces.xni.parser.XMLParserConfiguration - src/share/classes/com/sun/org/apache/xerces/internal/parsers/org.xml.sax.driver - src/share/classes/com/sun/org/apache/xerces/internal/util/AttributesProxy.java - src/share/classes/com/sun/org/apache/xerces/internal/util/AugmentationsImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/util/DOMEntityResolverWrapper.java - src/share/classes/com/sun/org/apache/xerces/internal/util/DOMErrorHandlerWrapper.java - src/share/classes/com/sun/org/apache/xerces/internal/util/DOMInputSource.java - src/share/classes/com/sun/org/apache/xerces/internal/util/DOMUtil.java - src/share/classes/com/sun/org/apache/xerces/internal/util/DatatypeMessageFormatter.java - src/share/classes/com/sun/org/apache/xerces/internal/util/DefaultErrorHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/util/DraconianErrorHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/util/EncodingMap.java - src/share/classes/com/sun/org/apache/xerces/internal/util/EntityResolver2Wrapper.java - src/share/classes/com/sun/org/apache/xerces/internal/util/EntityResolverWrapper.java - src/share/classes/com/sun/org/apache/xerces/internal/util/ErrorHandlerProxy.java - src/share/classes/com/sun/org/apache/xerces/internal/util/ErrorHandlerWrapper.java - src/share/classes/com/sun/org/apache/xerces/internal/util/FeatureState.java - src/share/classes/com/sun/org/apache/xerces/internal/util/HTTPInputSource.java - src/share/classes/com/sun/org/apache/xerces/internal/util/IntStack.java - src/share/classes/com/sun/org/apache/xerces/internal/util/JAXPNamespaceContextWrapper.java - src/share/classes/com/sun/org/apache/xerces/internal/util/LocatorProxy.java - src/share/classes/com/sun/org/apache/xerces/internal/util/LocatorWrapper.java - src/share/classes/com/sun/org/apache/xerces/internal/util/MessageFormatter.java - src/share/classes/com/sun/org/apache/xerces/internal/util/NamespaceContextWrapper.java - src/share/classes/com/sun/org/apache/xerces/internal/util/NamespaceSupport.java - src/share/classes/com/sun/org/apache/xerces/internal/util/ParserConfigurationSettings.java - src/share/classes/com/sun/org/apache/xerces/internal/util/PropertyState.java - src/share/classes/com/sun/org/apache/xerces/internal/util/SAX2XNI.java - src/share/classes/com/sun/org/apache/xerces/internal/util/SAXInputSource.java - src/share/classes/com/sun/org/apache/xerces/internal/util/SAXLocatorWrapper.java - src/share/classes/com/sun/org/apache/xerces/internal/util/SAXMessageFormatter.java - src/share/classes/com/sun/org/apache/xerces/internal/util/SecurityManager.java - src/share/classes/com/sun/org/apache/xerces/internal/util/ShadowedSymbolTable.java - src/share/classes/com/sun/org/apache/xerces/internal/util/StAXInputSource.java - src/share/classes/com/sun/org/apache/xerces/internal/util/StAXLocationWrapper.java - src/share/classes/com/sun/org/apache/xerces/internal/util/Status.java - src/share/classes/com/sun/org/apache/xerces/internal/util/SymbolHash.java - src/share/classes/com/sun/org/apache/xerces/internal/util/SymbolTable.java - src/share/classes/com/sun/org/apache/xerces/internal/util/SynchronizedSymbolTable.java - src/share/classes/com/sun/org/apache/xerces/internal/util/TeeXMLDocumentFilterImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/util/TypeInfoImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/util/URI.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XML11Char.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLAttributesImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLAttributesIteratorImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLCatalogResolver.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLChar.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLDocumentFilterImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLEntityDescriptionImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLErrorCode.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLGrammarPoolImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLInputSourceAdaptor.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLResourceIdentifierImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLStringBuffer.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLSymbols.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/MultipleScopeNamespaceSupport.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/ObjectFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/SecuritySupport.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/XInclude11TextReader.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/XIncludeMessageFormatter.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/XIncludeNamespaceSupport.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/XIncludeTextReader.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/XPointerElementHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/XPointerFramework.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/XPointerSchema.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/Augmentations.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/NamespaceContext.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/QName.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/XMLAttributes.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/XMLDTDContentModelHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/XMLDTDHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/XMLDocumentFragmentHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/XMLDocumentHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/XMLLocator.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/XMLResourceIdentifier.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/XMLString.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/XNIException.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/grammars/Grammar.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/grammars/XMLDTDDescription.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/grammars/XMLGrammarDescription.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/grammars/XMLGrammarLoader.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/grammars/XMLGrammarPool.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/grammars/XMLSchemaDescription.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/grammars/XSGrammar.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLComponent.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLComponentManager.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLConfigurationException.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDTDContentModelFilter.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDTDContentModelSource.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDTDFilter.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDTDScanner.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDTDSource.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDocumentFilter.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDocumentScanner.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDocumentSource.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLEntityResolver.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLErrorHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLInputSource.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLParseException.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLParserConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLPullParserConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/xpointer/ElementSchemePointer.java - src/share/classes/com/sun/org/apache/xerces/internal/xpointer/ShortHandPointer.java - src/share/classes/com/sun/org/apache/xerces/internal/xpointer/XPointerErrorHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/xpointer/XPointerHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/xpointer/XPointerMessageFormatter.java - src/share/classes/com/sun/org/apache/xerces/internal/xpointer/XPointerPart.java - src/share/classes/com/sun/org/apache/xerces/internal/xpointer/XPointerProcessor.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/AttributePSVI.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/ElementPSVI.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/ItemPSVI.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/LSInputList.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/PSVIProvider.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/ShortList.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/StringList.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSAnnotation.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSAttributeDeclaration.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSAttributeGroupDefinition.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSAttributeUse.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSComplexTypeDefinition.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSConstants.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSElementDeclaration.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSException.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSFacet.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSIDCDefinition.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSImplementation.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSLoader.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSModel.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSModelGroup.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSModelGroupDefinition.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSMultiValueFacet.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSNamedMap.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSNamespaceItem.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSNamespaceItemList.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSNotationDeclaration.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSObject.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSObjectList.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSParticle.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSSimpleTypeDefinition.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSTerm.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSTypeDefinition.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSWildcard.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/datatypes/ByteList.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/datatypes/ObjectList.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/datatypes/XSDateTime.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/datatypes/XSDecimal.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/datatypes/XSDouble.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/datatypes/XSFloat.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/datatypes/XSQName.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/datatypes/package.html - src/share/classes/com/sun/org/apache/xml/internal/dtm/Axis.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/DTM.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/DTMAxisIterator.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/DTMAxisTraverser.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/DTMConfigurationException.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/DTMDOMException.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/DTMException.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/DTMFilter.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/DTMIterator.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/DTMManager.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/DTMWSFilter.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ObjectFactory.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/SecuritySupport.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/ChunkedIntArray.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/CoroutineManager.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/CoroutineParser.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/CustomStringPool.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMAxisIterNodeList.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMAxisIteratorBase.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMChildIterNodeList.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMDefaultBase.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMDefaultBaseIterators.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMDefaultBaseTraversers.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMDocumentImpl.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMManagerDefault.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMNamedNodeMap.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMNodeIterator.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMNodeList.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMNodeListBase.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMNodeProxy.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMSafeStringPool.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMStringPool.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMTreeWalker.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/EmptyIterator.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/ExpandedNameTable.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/ExtendedType.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/IncrementalSAXSource.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/IncrementalSAXSource_Filter.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/IncrementalSAXSource_Xerces.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/NodeLocator.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/ObjectFactory.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/SecuritySupport.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/dom2dtm/DOM2DTM.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/dom2dtm/DOM2DTMdefaultNamespaceDeclarationNode.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/sax2dtm/SAX2DTM.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/sax2dtm/SAX2DTM2.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/sax2dtm/SAX2RTFDTM.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_ca.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_cs.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_de.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_en.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_es.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_fr.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_it.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_ja.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_ko.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_pt_BR.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_sk.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_sv.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_tr.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_zh_CN.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_zh_HK.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_zh_TW.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLMessages.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/Catalog.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/CatalogEntry.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/CatalogException.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/CatalogManager.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/Resolver.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/helpers/BootstrapResolver.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/helpers/Debug.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/helpers/FileURL.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/helpers/Namespaces.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/helpers/PublicId.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/CatalogReader.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/DOMCatalogParser.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/DOMCatalogReader.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/ExtendedXMLCatalogReader.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/OASISXMLCatalogReader.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/SAXCatalogParser.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/SAXCatalogReader.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/SAXParserHandler.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/TR9401CatalogReader.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/TextCatalogReader.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/XCatalogReader.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/tools/CatalogResolver.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/tools/ResolvingParser.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/tools/ResolvingXMLFilter.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/tools/ResolvingXMLReader.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/BaseMarkupSerializer.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/DOMSerializer.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/DOMSerializerImpl.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/ElementState.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/EncodingInfo.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/Encodings.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/HTMLEntities.res - src/share/classes/com/sun/org/apache/xml/internal/serialize/HTMLSerializer.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/HTMLdtd.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/IndentPrinter.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/LineSeparator.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/Method.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/ObjectFactory.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/OutputFormat.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/Printer.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/SecuritySupport.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/Serializer.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/SerializerFactory.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/SerializerFactoryImpl.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/TextSerializer.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/XHTMLSerializer.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/XML11Serializer.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/XMLSerializer.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/AttributesImplSerializer.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/CharInfo.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/DOMSerializer.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ElemContext.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ElemDesc.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/EmptySerializer.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/EncodingInfo.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/Encodings.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/Encodings.properties - src/share/classes/com/sun/org/apache/xml/internal/serializer/ExtendedContentHandler.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ExtendedLexicalHandler.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/HTMLEntities.properties - src/share/classes/com/sun/org/apache/xml/internal/serializer/Method.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/NamespaceMappings.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ObjectFactory.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/OutputPropertiesFactory.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/OutputPropertyUtils.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/SecuritySupport.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/SerializationHandler.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/Serializer.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/SerializerBase.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/SerializerConstants.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/SerializerFactory.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/SerializerTrace.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/SerializerTraceWriter.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ToHTMLSAXHandler.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ToHTMLStream.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ToSAXHandler.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ToStream.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ToTextSAXHandler.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ToTextStream.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ToUnknownStream.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ToXMLSAXHandler.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ToXMLStream.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/TransformStateSetter.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/TreeWalker.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/Utils.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/Version.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/WriterChain.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/WriterToASCI.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/WriterToUTF8Buffered.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/XMLEntities.properties - src/share/classes/com/sun/org/apache/xml/internal/serializer/XSLOutputAttributes.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/output_html.properties - src/share/classes/com/sun/org/apache/xml/internal/serializer/output_text.properties - src/share/classes/com/sun/org/apache/xml/internal/serializer/output_unknown.properties - src/share/classes/com/sun/org/apache/xml/internal/serializer/output_xml.properties - src/share/classes/com/sun/org/apache/xml/internal/serializer/package.html - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/AttList.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/BoolStack.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/DOM2Helper.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/Messages.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/MsgKey.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_ca.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_cs.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_de.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_en.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_es.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_fr.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_it.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_ja.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_ko.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_sv.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_zh_CN.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_zh_TW.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/StringToIntTable.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SystemIDResolver.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/URI.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/Utils.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/WrappedRuntimeException.java - src/share/classes/com/sun/org/apache/xml/internal/utils/AttList.java - src/share/classes/com/sun/org/apache/xml/internal/utils/BoolStack.java - src/share/classes/com/sun/org/apache/xml/internal/utils/CharKey.java - src/share/classes/com/sun/org/apache/xml/internal/utils/Constants.java - src/share/classes/com/sun/org/apache/xml/internal/utils/DOM2Helper.java - src/share/classes/com/sun/org/apache/xml/internal/utils/DOMBuilder.java - src/share/classes/com/sun/org/apache/xml/internal/utils/DOMHelper.java - src/share/classes/com/sun/org/apache/xml/internal/utils/DOMOrder.java - src/share/classes/com/sun/org/apache/xml/internal/utils/DefaultErrorHandler.java - src/share/classes/com/sun/org/apache/xml/internal/utils/ElemDesc.java - src/share/classes/com/sun/org/apache/xml/internal/utils/FastStringBuffer.java - src/share/classes/com/sun/org/apache/xml/internal/utils/Hashtree2Node.java - src/share/classes/com/sun/org/apache/xml/internal/utils/IntStack.java - src/share/classes/com/sun/org/apache/xml/internal/utils/IntVector.java - src/share/classes/com/sun/org/apache/xml/internal/utils/ListingErrorHandler.java - src/share/classes/com/sun/org/apache/xml/internal/utils/LocaleUtility.java - src/share/classes/com/sun/org/apache/xml/internal/utils/MutableAttrListImpl.java - src/share/classes/com/sun/org/apache/xml/internal/utils/NSInfo.java - src/share/classes/com/sun/org/apache/xml/internal/utils/NameSpace.java - src/share/classes/com/sun/org/apache/xml/internal/utils/NamespaceSupport2.java - src/share/classes/com/sun/org/apache/xml/internal/utils/NodeConsumer.java - src/share/classes/com/sun/org/apache/xml/internal/utils/NodeVector.java - src/share/classes/com/sun/org/apache/xml/internal/utils/ObjectFactory.java - src/share/classes/com/sun/org/apache/xml/internal/utils/ObjectPool.java - src/share/classes/com/sun/org/apache/xml/internal/utils/ObjectStack.java - src/share/classes/com/sun/org/apache/xml/internal/utils/ObjectVector.java - src/share/classes/com/sun/org/apache/xml/internal/utils/PrefixResolver.java - src/share/classes/com/sun/org/apache/xml/internal/utils/PrefixResolverDefault.java - src/share/classes/com/sun/org/apache/xml/internal/utils/QName.java - src/share/classes/com/sun/org/apache/xml/internal/utils/RawCharacterHandler.java - src/share/classes/com/sun/org/apache/xml/internal/utils/SAXSourceLocator.java - src/share/classes/com/sun/org/apache/xml/internal/utils/SecuritySupport.java - src/share/classes/com/sun/org/apache/xml/internal/utils/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xml/internal/utils/SerializableLocatorImpl.java - src/share/classes/com/sun/org/apache/xml/internal/utils/StopParseException.java - src/share/classes/com/sun/org/apache/xml/internal/utils/StringBufferPool.java - src/share/classes/com/sun/org/apache/xml/internal/utils/StringComparable.java - src/share/classes/com/sun/org/apache/xml/internal/utils/StringToIntTable.java - src/share/classes/com/sun/org/apache/xml/internal/utils/StringToStringTable.java - src/share/classes/com/sun/org/apache/xml/internal/utils/StringToStringTableVector.java - src/share/classes/com/sun/org/apache/xml/internal/utils/StringVector.java - src/share/classes/com/sun/org/apache/xml/internal/utils/StylesheetPIHandler.java - src/share/classes/com/sun/org/apache/xml/internal/utils/SuballocatedByteVector.java - src/share/classes/com/sun/org/apache/xml/internal/utils/SuballocatedIntVector.java - src/share/classes/com/sun/org/apache/xml/internal/utils/SystemIDResolver.java - src/share/classes/com/sun/org/apache/xml/internal/utils/ThreadControllerWrapper.java - src/share/classes/com/sun/org/apache/xml/internal/utils/TreeWalker.java - src/share/classes/com/sun/org/apache/xml/internal/utils/Trie.java - src/share/classes/com/sun/org/apache/xml/internal/utils/URI.java - src/share/classes/com/sun/org/apache/xml/internal/utils/UnImplNode.java - src/share/classes/com/sun/org/apache/xml/internal/utils/WrappedRuntimeException.java - src/share/classes/com/sun/org/apache/xml/internal/utils/WrongParserException.java - src/share/classes/com/sun/org/apache/xml/internal/utils/XML11Char.java - src/share/classes/com/sun/org/apache/xml/internal/utils/XMLChar.java - src/share/classes/com/sun/org/apache/xml/internal/utils/XMLCharacterRecognizer.java - src/share/classes/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java - src/share/classes/com/sun/org/apache/xml/internal/utils/XMLString.java - src/share/classes/com/sun/org/apache/xml/internal/utils/XMLStringDefault.java - src/share/classes/com/sun/org/apache/xml/internal/utils/XMLStringFactory.java - src/share/classes/com/sun/org/apache/xml/internal/utils/XMLStringFactoryDefault.java - src/share/classes/com/sun/org/apache/xml/internal/utils/package.html - src/share/classes/com/sun/org/apache/xml/internal/utils/res/CharArrayWrapper.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/IntArrayWrapper.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/LongArrayWrapper.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/StringArrayWrapper.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResourceBundle.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResourceBundleBase.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_de.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_en.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_es.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_fr.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_it.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_ja_JP_A.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_ja_JP_HA.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_ja_JP_HI.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_ja_JP_I.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_ko.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_sv.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_zh_CN.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_zh_TW.java - src/share/classes/com/sun/org/apache/xpath/internal/Arg.java - src/share/classes/com/sun/org/apache/xpath/internal/CachedXPathAPI.java - src/share/classes/com/sun/org/apache/xpath/internal/Expression.java - src/share/classes/com/sun/org/apache/xpath/internal/ExpressionNode.java - src/share/classes/com/sun/org/apache/xpath/internal/ExpressionOwner.java - src/share/classes/com/sun/org/apache/xpath/internal/ExtensionsProvider.java - src/share/classes/com/sun/org/apache/xpath/internal/FoundIndex.java - src/share/classes/com/sun/org/apache/xpath/internal/NodeSet.java - src/share/classes/com/sun/org/apache/xpath/internal/NodeSetDTM.java - src/share/classes/com/sun/org/apache/xpath/internal/SourceTree.java - src/share/classes/com/sun/org/apache/xpath/internal/SourceTreeManager.java - src/share/classes/com/sun/org/apache/xpath/internal/VariableStack.java - src/share/classes/com/sun/org/apache/xpath/internal/WhitespaceStrippingElementMatcher.java - src/share/classes/com/sun/org/apache/xpath/internal/XPath.java - src/share/classes/com/sun/org/apache/xpath/internal/XPathAPI.java - src/share/classes/com/sun/org/apache/xpath/internal/XPathContext.java - src/share/classes/com/sun/org/apache/xpath/internal/XPathException.java - src/share/classes/com/sun/org/apache/xpath/internal/XPathFactory.java - src/share/classes/com/sun/org/apache/xpath/internal/XPathProcessorException.java - src/share/classes/com/sun/org/apache/xpath/internal/XPathVisitable.java - src/share/classes/com/sun/org/apache/xpath/internal/XPathVisitor.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/AttributeIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/AxesWalker.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/BasicTestIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/ChildIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/ChildTestIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/ContextNodeList.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/DescendantIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/FilterExprIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/FilterExprIteratorSimple.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/FilterExprWalker.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/HasPositionalPredChecker.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/IteratorPool.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/LocPathIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/MatchPatternIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/NodeSequence.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/OneStepIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/OneStepIteratorForward.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/PathComponent.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/PredicatedNodeTest.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/RTFIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/ReverseAxesWalker.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/SelfIteratorNoPredicate.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/SubContextList.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/UnionChildIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/UnionPathIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/WalkerFactory.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/WalkingIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/WalkingIteratorSorted.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/package.html - src/share/classes/com/sun/org/apache/xpath/internal/compiler/Compiler.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/FuncLoader.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/FunctionTable.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/Keywords.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/Lexer.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/ObjectFactory.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/OpCodes.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/OpMap.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/OpMapVector.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/PsuedoNames.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/SecuritySupport.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/XPathDumper.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/XPathParser.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/package.html - src/share/classes/com/sun/org/apache/xpath/internal/domapi/XPathEvaluatorImpl.java - src/share/classes/com/sun/org/apache/xpath/internal/domapi/XPathExpressionImpl.java - src/share/classes/com/sun/org/apache/xpath/internal/domapi/XPathNSResolverImpl.java - src/share/classes/com/sun/org/apache/xpath/internal/domapi/XPathNamespaceImpl.java - src/share/classes/com/sun/org/apache/xpath/internal/domapi/XPathResultImpl.java - src/share/classes/com/sun/org/apache/xpath/internal/domapi/XPathStylesheetDOM3Exception.java - src/share/classes/com/sun/org/apache/xpath/internal/domapi/package.html - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncBoolean.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncCeiling.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncConcat.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncContains.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncCount.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncCurrent.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncDoclocation.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncExtElementAvailable.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncExtFunction.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncExtFunctionAvailable.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncFalse.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncFloor.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncGenerateId.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncId.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncLang.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncLast.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncLocalPart.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncNamespace.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncNormalizeSpace.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncNot.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncNumber.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncPosition.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncQname.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncRound.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncStartsWith.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncString.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncStringLength.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncSubstring.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncSubstringAfter.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncSubstringBefore.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncSum.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncSystemProperty.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncTranslate.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncTrue.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncUnparsedEntityURI.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/Function.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/Function2Args.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/Function3Args.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FunctionDef1Arg.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FunctionMultiArgs.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FunctionOneArg.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/ObjectFactory.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/SecuritySupport.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/WrongNumberArgsException.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/package.html - src/share/classes/com/sun/org/apache/xpath/internal/jaxp/JAXPExtensionsProvider.java - src/share/classes/com/sun/org/apache/xpath/internal/jaxp/JAXPPrefixResolver.java - src/share/classes/com/sun/org/apache/xpath/internal/jaxp/JAXPVariableStack.java - src/share/classes/com/sun/org/apache/xpath/internal/jaxp/XPathExpressionImpl.java - src/share/classes/com/sun/org/apache/xpath/internal/jaxp/XPathFactoryImpl.java - src/share/classes/com/sun/org/apache/xpath/internal/jaxp/XPathImpl.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/DTMXRTreeFrag.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XBoolean.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XBooleanStatic.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XMLStringFactoryImpl.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XNodeSet.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XNodeSetForDOM.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XNull.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XNumber.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XObject.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XObjectFactory.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XRTreeFrag.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XRTreeFragSelectWrapper.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XString.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XStringForChars.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XStringForFSB.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/package.html - src/share/classes/com/sun/org/apache/xpath/internal/operations/And.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Bool.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Div.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Equals.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Gt.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Gte.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Lt.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Lte.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Minus.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Mod.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Mult.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Neg.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/NotEquals.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Number.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Operation.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Or.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Plus.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Quo.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/String.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/UnaryOperation.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Variable.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/VariableSafeAbsRef.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/package.html - src/share/classes/com/sun/org/apache/xpath/internal/package.html - src/share/classes/com/sun/org/apache/xpath/internal/patterns/ContextMatchStepPattern.java - src/share/classes/com/sun/org/apache/xpath/internal/patterns/FunctionPattern.java - src/share/classes/com/sun/org/apache/xpath/internal/patterns/NodeTest.java - src/share/classes/com/sun/org/apache/xpath/internal/patterns/NodeTestFilter.java - src/share/classes/com/sun/org/apache/xpath/internal/patterns/StepPattern.java - src/share/classes/com/sun/org/apache/xpath/internal/patterns/UnionPattern.java - src/share/classes/com/sun/org/apache/xpath/internal/patterns/package.html - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_de.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_en.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_es.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_fr.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_it.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_ja.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_ko.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_pt_BR.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_sv.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_zh_CN.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_zh_TW.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHMessages.java - src/share/classes/com/sun/org/apache/xpath/internal/res/package.html - src/share/classes/com/sun/xml/internal/stream/Entity.java - src/share/classes/com/sun/xml/internal/stream/EventFilterSupport.java - src/share/classes/com/sun/xml/internal/stream/StaxEntityResolverWrapper.java - src/share/classes/com/sun/xml/internal/stream/StaxErrorReporter.java - src/share/classes/com/sun/xml/internal/stream/StaxXMLInputSource.java - src/share/classes/com/sun/xml/internal/stream/XMLBufferListener.java - src/share/classes/com/sun/xml/internal/stream/XMLEntityReader.java - src/share/classes/com/sun/xml/internal/stream/XMLEntityStorage.java - src/share/classes/com/sun/xml/internal/stream/XMLEventReaderImpl.java - src/share/classes/com/sun/xml/internal/stream/XMLInputFactoryImpl.java - src/share/classes/com/sun/xml/internal/stream/XMLOutputFactoryImpl.java - src/share/classes/com/sun/xml/internal/stream/dtd/DTDGrammarUtil.java - src/share/classes/com/sun/xml/internal/stream/dtd/nonvalidating/DTDGrammar.java - src/share/classes/com/sun/xml/internal/stream/dtd/nonvalidating/XMLAttributeDecl.java - src/share/classes/com/sun/xml/internal/stream/dtd/nonvalidating/XMLElementDecl.java - src/share/classes/com/sun/xml/internal/stream/dtd/nonvalidating/XMLNotationDecl.java - src/share/classes/com/sun/xml/internal/stream/dtd/nonvalidating/XMLSimpleType.java - src/share/classes/com/sun/xml/internal/stream/events/AttributeImpl.java - src/share/classes/com/sun/xml/internal/stream/events/CharacterEvent.java - src/share/classes/com/sun/xml/internal/stream/events/CommentEvent.java - src/share/classes/com/sun/xml/internal/stream/events/DTDEvent.java - src/share/classes/com/sun/xml/internal/stream/events/DummyEvent.java - src/share/classes/com/sun/xml/internal/stream/events/EndDocumentEvent.java - src/share/classes/com/sun/xml/internal/stream/events/EndElementEvent.java - src/share/classes/com/sun/xml/internal/stream/events/EntityDeclarationImpl.java - src/share/classes/com/sun/xml/internal/stream/events/EntityReferenceEvent.java - src/share/classes/com/sun/xml/internal/stream/events/LocationImpl.java - src/share/classes/com/sun/xml/internal/stream/events/NamedEvent.java - src/share/classes/com/sun/xml/internal/stream/events/NamespaceImpl.java - src/share/classes/com/sun/xml/internal/stream/events/NotationDeclarationImpl.java - src/share/classes/com/sun/xml/internal/stream/events/ProcessingInstructionEvent.java - src/share/classes/com/sun/xml/internal/stream/events/StartDocumentEvent.java - src/share/classes/com/sun/xml/internal/stream/events/StartElementEvent.java - src/share/classes/com/sun/xml/internal/stream/events/XMLEventAllocatorImpl.java - src/share/classes/com/sun/xml/internal/stream/events/XMLEventFactoryImpl.java - src/share/classes/com/sun/xml/internal/stream/javax.xml.stream.XMLEventFactory - src/share/classes/com/sun/xml/internal/stream/javax.xml.stream.XMLInputFactory - src/share/classes/com/sun/xml/internal/stream/javax.xml.stream.XMLOutputFactory - src/share/classes/com/sun/xml/internal/stream/util/BufferAllocator.java - src/share/classes/com/sun/xml/internal/stream/util/ReadOnlyIterator.java - src/share/classes/com/sun/xml/internal/stream/util/ThreadLocalBufferAllocator.java - src/share/classes/com/sun/xml/internal/stream/writers/UTF8OutputStreamWriter.java - src/share/classes/com/sun/xml/internal/stream/writers/WriterUtility.java - src/share/classes/com/sun/xml/internal/stream/writers/XMLDOMWriterImpl.java - src/share/classes/com/sun/xml/internal/stream/writers/XMLEventWriterImpl.java - src/share/classes/com/sun/xml/internal/stream/writers/XMLOutputSource.java - src/share/classes/com/sun/xml/internal/stream/writers/XMLStreamWriterImpl.java - src/share/classes/com/sun/xml/internal/stream/writers/XMLWriter.java - src/share/classes/javax/xml/XMLConstants.java - src/share/classes/javax/xml/datatype/DatatypeConfigurationException.java - src/share/classes/javax/xml/datatype/DatatypeConstants.java - src/share/classes/javax/xml/datatype/DatatypeFactory.java - src/share/classes/javax/xml/datatype/Duration.java - src/share/classes/javax/xml/datatype/FactoryFinder.java - src/share/classes/javax/xml/datatype/SecuritySupport.java - src/share/classes/javax/xml/datatype/XMLGregorianCalendar.java - src/share/classes/javax/xml/datatype/package.html - src/share/classes/javax/xml/namespace/NamespaceContext.java - src/share/classes/javax/xml/namespace/QName.java - src/share/classes/javax/xml/namespace/package.html - src/share/classes/javax/xml/parsers/DocumentBuilder.java - src/share/classes/javax/xml/parsers/DocumentBuilderFactory.java - src/share/classes/javax/xml/parsers/FactoryConfigurationError.java - src/share/classes/javax/xml/parsers/FactoryFinder.java - src/share/classes/javax/xml/parsers/ParserConfigurationException.java - src/share/classes/javax/xml/parsers/SAXParser.java - src/share/classes/javax/xml/parsers/SAXParserFactory.java - src/share/classes/javax/xml/parsers/SecuritySupport.java - src/share/classes/javax/xml/parsers/package.html - src/share/classes/javax/xml/stream/EventFilter.java - src/share/classes/javax/xml/stream/FactoryConfigurationError.java - src/share/classes/javax/xml/stream/FactoryFinder.java - src/share/classes/javax/xml/stream/Location.java - src/share/classes/javax/xml/stream/SecuritySupport.java - src/share/classes/javax/xml/stream/StreamFilter.java - src/share/classes/javax/xml/stream/XMLEventFactory.java - src/share/classes/javax/xml/stream/XMLEventReader.java - src/share/classes/javax/xml/stream/XMLEventWriter.java - src/share/classes/javax/xml/stream/XMLInputFactory.java - src/share/classes/javax/xml/stream/XMLOutputFactory.java - src/share/classes/javax/xml/stream/XMLReporter.java - src/share/classes/javax/xml/stream/XMLResolver.java - src/share/classes/javax/xml/stream/XMLStreamConstants.java - src/share/classes/javax/xml/stream/XMLStreamException.java - src/share/classes/javax/xml/stream/XMLStreamReader.java - src/share/classes/javax/xml/stream/XMLStreamWriter.java - src/share/classes/javax/xml/stream/events/Attribute.java - src/share/classes/javax/xml/stream/events/Characters.java - src/share/classes/javax/xml/stream/events/Comment.java - src/share/classes/javax/xml/stream/events/DTD.java - src/share/classes/javax/xml/stream/events/EndDocument.java - src/share/classes/javax/xml/stream/events/EndElement.java - src/share/classes/javax/xml/stream/events/EntityDeclaration.java - src/share/classes/javax/xml/stream/events/EntityReference.java - src/share/classes/javax/xml/stream/events/Namespace.java - src/share/classes/javax/xml/stream/events/NotationDeclaration.java - src/share/classes/javax/xml/stream/events/ProcessingInstruction.java - src/share/classes/javax/xml/stream/events/StartDocument.java - src/share/classes/javax/xml/stream/events/StartElement.java - src/share/classes/javax/xml/stream/events/XMLEvent.java - src/share/classes/javax/xml/stream/util/EventReaderDelegate.java - src/share/classes/javax/xml/stream/util/StreamReaderDelegate.java - src/share/classes/javax/xml/stream/util/XMLEventAllocator.java - src/share/classes/javax/xml/stream/util/XMLEventConsumer.java - src/share/classes/javax/xml/transform/ErrorListener.java - src/share/classes/javax/xml/transform/FactoryFinder.java - src/share/classes/javax/xml/transform/OutputKeys.java - src/share/classes/javax/xml/transform/Result.java - src/share/classes/javax/xml/transform/SecuritySupport.java - src/share/classes/javax/xml/transform/Source.java - src/share/classes/javax/xml/transform/SourceLocator.java - src/share/classes/javax/xml/transform/Templates.java - src/share/classes/javax/xml/transform/Transformer.java - src/share/classes/javax/xml/transform/TransformerConfigurationException.java - src/share/classes/javax/xml/transform/TransformerException.java - src/share/classes/javax/xml/transform/TransformerFactory.java - src/share/classes/javax/xml/transform/TransformerFactoryConfigurationError.java - src/share/classes/javax/xml/transform/URIResolver.java - src/share/classes/javax/xml/transform/dom/DOMLocator.java - src/share/classes/javax/xml/transform/dom/DOMResult.java - src/share/classes/javax/xml/transform/dom/DOMSource.java - src/share/classes/javax/xml/transform/dom/package.html - src/share/classes/javax/xml/transform/overview.html - src/share/classes/javax/xml/transform/package.html - src/share/classes/javax/xml/transform/sax/SAXResult.java - src/share/classes/javax/xml/transform/sax/SAXSource.java - src/share/classes/javax/xml/transform/sax/SAXTransformerFactory.java - src/share/classes/javax/xml/transform/sax/TemplatesHandler.java - src/share/classes/javax/xml/transform/sax/TransformerHandler.java - src/share/classes/javax/xml/transform/sax/package.html - src/share/classes/javax/xml/transform/stax/StAXResult.java - src/share/classes/javax/xml/transform/stax/StAXSource.java - src/share/classes/javax/xml/transform/stax/package.html - src/share/classes/javax/xml/transform/stream/StreamResult.java - src/share/classes/javax/xml/transform/stream/StreamSource.java - src/share/classes/javax/xml/transform/stream/package.html - src/share/classes/javax/xml/validation/Schema.java - src/share/classes/javax/xml/validation/SchemaFactory.java - src/share/classes/javax/xml/validation/SchemaFactoryFinder.java - src/share/classes/javax/xml/validation/SchemaFactoryLoader.java - src/share/classes/javax/xml/validation/SecuritySupport.java - src/share/classes/javax/xml/validation/TypeInfoProvider.java - src/share/classes/javax/xml/validation/Validator.java - src/share/classes/javax/xml/validation/ValidatorHandler.java - src/share/classes/javax/xml/validation/package.html - src/share/classes/javax/xml/xpath/SecuritySupport.java - src/share/classes/javax/xml/xpath/XPath.java - src/share/classes/javax/xml/xpath/XPathConstants.java - src/share/classes/javax/xml/xpath/XPathException.java - src/share/classes/javax/xml/xpath/XPathExpression.java - src/share/classes/javax/xml/xpath/XPathExpressionException.java - src/share/classes/javax/xml/xpath/XPathFactory.java - src/share/classes/javax/xml/xpath/XPathFactoryConfigurationException.java - src/share/classes/javax/xml/xpath/XPathFactoryFinder.java - src/share/classes/javax/xml/xpath/XPathFunction.java - src/share/classes/javax/xml/xpath/XPathFunctionException.java - src/share/classes/javax/xml/xpath/XPathFunctionResolver.java - src/share/classes/javax/xml/xpath/XPathVariableResolver.java - src/share/classes/javax/xml/xpath/package.html - src/share/classes/org/w3c/dom/Attr.java - src/share/classes/org/w3c/dom/CDATASection.java - src/share/classes/org/w3c/dom/CharacterData.java - src/share/classes/org/w3c/dom/Comment.java - src/share/classes/org/w3c/dom/DOMConfiguration.java - src/share/classes/org/w3c/dom/DOMError.java - src/share/classes/org/w3c/dom/DOMErrorHandler.java - src/share/classes/org/w3c/dom/DOMException.java - src/share/classes/org/w3c/dom/DOMImplementation.java - src/share/classes/org/w3c/dom/DOMImplementationList.java - src/share/classes/org/w3c/dom/DOMImplementationSource.java - src/share/classes/org/w3c/dom/DOMLocator.java - src/share/classes/org/w3c/dom/DOMStringList.java - src/share/classes/org/w3c/dom/Document.java - src/share/classes/org/w3c/dom/DocumentFragment.java - src/share/classes/org/w3c/dom/DocumentType.java - src/share/classes/org/w3c/dom/Element.java - src/share/classes/org/w3c/dom/Entity.java - src/share/classes/org/w3c/dom/EntityReference.java - src/share/classes/org/w3c/dom/NameList.java - src/share/classes/org/w3c/dom/NamedNodeMap.java - src/share/classes/org/w3c/dom/Node.java - src/share/classes/org/w3c/dom/NodeList.java - src/share/classes/org/w3c/dom/Notation.java - src/share/classes/org/w3c/dom/ProcessingInstruction.java - src/share/classes/org/w3c/dom/Text.java - src/share/classes/org/w3c/dom/TypeInfo.java - src/share/classes/org/w3c/dom/UserDataHandler.java - src/share/classes/org/w3c/dom/bootstrap/DOMImplementationRegistry.java - src/share/classes/org/w3c/dom/css/CSS2Properties.java - src/share/classes/org/w3c/dom/css/CSSCharsetRule.java - src/share/classes/org/w3c/dom/css/CSSFontFaceRule.java - src/share/classes/org/w3c/dom/css/CSSImportRule.java - src/share/classes/org/w3c/dom/css/CSSMediaRule.java - src/share/classes/org/w3c/dom/css/CSSPageRule.java - src/share/classes/org/w3c/dom/css/CSSPrimitiveValue.java - src/share/classes/org/w3c/dom/css/CSSRule.java - src/share/classes/org/w3c/dom/css/CSSRuleList.java - src/share/classes/org/w3c/dom/css/CSSStyleDeclaration.java - src/share/classes/org/w3c/dom/css/CSSStyleRule.java - src/share/classes/org/w3c/dom/css/CSSStyleSheet.java - src/share/classes/org/w3c/dom/css/CSSUnknownRule.java - src/share/classes/org/w3c/dom/css/CSSValue.java - src/share/classes/org/w3c/dom/css/CSSValueList.java - src/share/classes/org/w3c/dom/css/Counter.java - src/share/classes/org/w3c/dom/css/DOMImplementationCSS.java - src/share/classes/org/w3c/dom/css/DocumentCSS.java - src/share/classes/org/w3c/dom/css/ElementCSSInlineStyle.java - src/share/classes/org/w3c/dom/css/RGBColor.java - src/share/classes/org/w3c/dom/css/Rect.java - src/share/classes/org/w3c/dom/css/ViewCSS.java - src/share/classes/org/w3c/dom/events/DocumentEvent.java - src/share/classes/org/w3c/dom/events/Event.java - src/share/classes/org/w3c/dom/events/EventException.java - src/share/classes/org/w3c/dom/events/EventListener.java - src/share/classes/org/w3c/dom/events/EventTarget.java - src/share/classes/org/w3c/dom/events/MouseEvent.java - src/share/classes/org/w3c/dom/events/MutationEvent.java - src/share/classes/org/w3c/dom/events/UIEvent.java - src/share/classes/org/w3c/dom/html/HTMLAnchorElement.java - src/share/classes/org/w3c/dom/html/HTMLAppletElement.java - src/share/classes/org/w3c/dom/html/HTMLAreaElement.java - src/share/classes/org/w3c/dom/html/HTMLBRElement.java - src/share/classes/org/w3c/dom/html/HTMLBaseElement.java - src/share/classes/org/w3c/dom/html/HTMLBaseFontElement.java - src/share/classes/org/w3c/dom/html/HTMLBodyElement.java - src/share/classes/org/w3c/dom/html/HTMLButtonElement.java - src/share/classes/org/w3c/dom/html/HTMLCollection.java - src/share/classes/org/w3c/dom/html/HTMLDListElement.java - src/share/classes/org/w3c/dom/html/HTMLDOMImplementation.java - src/share/classes/org/w3c/dom/html/HTMLDirectoryElement.java - src/share/classes/org/w3c/dom/html/HTMLDivElement.java - src/share/classes/org/w3c/dom/html/HTMLDocument.java - src/share/classes/org/w3c/dom/html/HTMLElement.java - src/share/classes/org/w3c/dom/html/HTMLFieldSetElement.java - src/share/classes/org/w3c/dom/html/HTMLFontElement.java - src/share/classes/org/w3c/dom/html/HTMLFormElement.java - src/share/classes/org/w3c/dom/html/HTMLFrameElement.java - src/share/classes/org/w3c/dom/html/HTMLFrameSetElement.java - src/share/classes/org/w3c/dom/html/HTMLHRElement.java - src/share/classes/org/w3c/dom/html/HTMLHeadElement.java - src/share/classes/org/w3c/dom/html/HTMLHeadingElement.java - src/share/classes/org/w3c/dom/html/HTMLHtmlElement.java - src/share/classes/org/w3c/dom/html/HTMLIFrameElement.java - src/share/classes/org/w3c/dom/html/HTMLImageElement.java - src/share/classes/org/w3c/dom/html/HTMLInputElement.java - src/share/classes/org/w3c/dom/html/HTMLIsIndexElement.java - src/share/classes/org/w3c/dom/html/HTMLLIElement.java - src/share/classes/org/w3c/dom/html/HTMLLabelElement.java - src/share/classes/org/w3c/dom/html/HTMLLegendElement.java - src/share/classes/org/w3c/dom/html/HTMLLinkElement.java - src/share/classes/org/w3c/dom/html/HTMLMapElement.java - src/share/classes/org/w3c/dom/html/HTMLMenuElement.java - src/share/classes/org/w3c/dom/html/HTMLMetaElement.java - src/share/classes/org/w3c/dom/html/HTMLModElement.java - src/share/classes/org/w3c/dom/html/HTMLOListElement.java - src/share/classes/org/w3c/dom/html/HTMLObjectElement.java - src/share/classes/org/w3c/dom/html/HTMLOptGroupElement.java - src/share/classes/org/w3c/dom/html/HTMLOptionElement.java - src/share/classes/org/w3c/dom/html/HTMLParagraphElement.java - src/share/classes/org/w3c/dom/html/HTMLParamElement.java - src/share/classes/org/w3c/dom/html/HTMLPreElement.java - src/share/classes/org/w3c/dom/html/HTMLQuoteElement.java - src/share/classes/org/w3c/dom/html/HTMLScriptElement.java - src/share/classes/org/w3c/dom/html/HTMLSelectElement.java - src/share/classes/org/w3c/dom/html/HTMLStyleElement.java - src/share/classes/org/w3c/dom/html/HTMLTableCaptionElement.java - src/share/classes/org/w3c/dom/html/HTMLTableCellElement.java - src/share/classes/org/w3c/dom/html/HTMLTableColElement.java - src/share/classes/org/w3c/dom/html/HTMLTableElement.java - src/share/classes/org/w3c/dom/html/HTMLTableRowElement.java - src/share/classes/org/w3c/dom/html/HTMLTableSectionElement.java - src/share/classes/org/w3c/dom/html/HTMLTextAreaElement.java - src/share/classes/org/w3c/dom/html/HTMLTitleElement.java - src/share/classes/org/w3c/dom/html/HTMLUListElement.java - src/share/classes/org/w3c/dom/ls/DOMImplementationLS.java - src/share/classes/org/w3c/dom/ls/LSException.java - src/share/classes/org/w3c/dom/ls/LSInput.java - src/share/classes/org/w3c/dom/ls/LSLoadEvent.java - src/share/classes/org/w3c/dom/ls/LSOutput.java - src/share/classes/org/w3c/dom/ls/LSParser.java - src/share/classes/org/w3c/dom/ls/LSParserFilter.java - src/share/classes/org/w3c/dom/ls/LSProgressEvent.java - src/share/classes/org/w3c/dom/ls/LSResourceResolver.java - src/share/classes/org/w3c/dom/ls/LSSerializer.java - src/share/classes/org/w3c/dom/ls/LSSerializerFilter.java - src/share/classes/org/w3c/dom/package.html - src/share/classes/org/w3c/dom/ranges/DocumentRange.java - src/share/classes/org/w3c/dom/ranges/Range.java - src/share/classes/org/w3c/dom/ranges/RangeException.java - src/share/classes/org/w3c/dom/ranges/package.html - src/share/classes/org/w3c/dom/stylesheets/DocumentStyle.java - src/share/classes/org/w3c/dom/stylesheets/LinkStyle.java - src/share/classes/org/w3c/dom/stylesheets/MediaList.java - src/share/classes/org/w3c/dom/stylesheets/StyleSheet.java - src/share/classes/org/w3c/dom/stylesheets/StyleSheetList.java - src/share/classes/org/w3c/dom/traversal/DocumentTraversal.java - src/share/classes/org/w3c/dom/traversal/NodeFilter.java - src/share/classes/org/w3c/dom/traversal/NodeIterator.java - src/share/classes/org/w3c/dom/traversal/TreeWalker.java - src/share/classes/org/w3c/dom/views/AbstractView.java - src/share/classes/org/w3c/dom/views/DocumentView.java - src/share/classes/org/w3c/dom/xpath/COPYRIGHT.html - src/share/classes/org/w3c/dom/xpath/XPathEvaluator.java - src/share/classes/org/w3c/dom/xpath/XPathException.java - src/share/classes/org/w3c/dom/xpath/XPathExpression.java - src/share/classes/org/w3c/dom/xpath/XPathNSResolver.java - src/share/classes/org/w3c/dom/xpath/XPathNamespace.java - src/share/classes/org/w3c/dom/xpath/XPathResult.java - src/share/classes/org/xml/sax/AttributeList.java - src/share/classes/org/xml/sax/Attributes.java - src/share/classes/org/xml/sax/COPYING - src/share/classes/org/xml/sax/COPYING.txt - src/share/classes/org/xml/sax/ContentHandler.java - src/share/classes/org/xml/sax/DTDHandler.java - src/share/classes/org/xml/sax/DocumentHandler.java - src/share/classes/org/xml/sax/EntityResolver.java - src/share/classes/org/xml/sax/ErrorHandler.java - src/share/classes/org/xml/sax/HandlerBase.java - src/share/classes/org/xml/sax/InputSource.java - src/share/classes/org/xml/sax/Locator.java - src/share/classes/org/xml/sax/Parser.java - src/share/classes/org/xml/sax/SAXException.java - src/share/classes/org/xml/sax/SAXNotRecognizedException.java - src/share/classes/org/xml/sax/SAXNotSupportedException.java - src/share/classes/org/xml/sax/SAXParseException.java - src/share/classes/org/xml/sax/XMLFilter.java - src/share/classes/org/xml/sax/XMLReader.java - src/share/classes/org/xml/sax/ext/Attributes2.java - src/share/classes/org/xml/sax/ext/Attributes2Impl.java - src/share/classes/org/xml/sax/ext/DeclHandler.java - src/share/classes/org/xml/sax/ext/DefaultHandler2.java - src/share/classes/org/xml/sax/ext/EntityResolver2.java - src/share/classes/org/xml/sax/ext/LexicalHandler.java - src/share/classes/org/xml/sax/ext/Locator2.java - src/share/classes/org/xml/sax/ext/Locator2Impl.java - src/share/classes/org/xml/sax/ext/package.html - src/share/classes/org/xml/sax/helpers/AttributeListImpl.java - src/share/classes/org/xml/sax/helpers/AttributesImpl.java - src/share/classes/org/xml/sax/helpers/DefaultHandler.java - src/share/classes/org/xml/sax/helpers/LocatorImpl.java - src/share/classes/org/xml/sax/helpers/NamespaceSupport.java - src/share/classes/org/xml/sax/helpers/NewInstance.java - src/share/classes/org/xml/sax/helpers/ParserAdapter.java - src/share/classes/org/xml/sax/helpers/ParserFactory.java - src/share/classes/org/xml/sax/helpers/XMLFilterImpl.java - src/share/classes/org/xml/sax/helpers/XMLReaderAdapter.java - src/share/classes/org/xml/sax/helpers/XMLReaderFactory.java - src/share/classes/org/xml/sax/helpers/package.html - src/share/classes/org/xml/sax/package.html Changeset: 6aadb7d98564 Author: asaha Date: 2012-05-21 14:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/6aadb7d98564 Merge Changeset: c865c6951fea Author: asaha Date: 2012-06-07 12:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/c865c6951fea Merge Changeset: 57476f66e13c Author: lana Date: 2012-06-26 10:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/57476f66e13c Merge Changeset: 219e720a1baa Author: lana Date: 2012-06-26 22:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/219e720a1baa Merge From lana.steuck at oracle.com Wed Jun 27 00:11:43 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 27 Jun 2012 07:11:43 +0000 Subject: hg: jdk8/tl/hotspot: 45 new changesets Message-ID: <20120627071320.E74D547B4C@hg.openjdk.java.net> Changeset: 6e2633440960 Author: amurillo Date: 2012-06-01 15:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6e2633440960 7173438: new hotspot build - hs24-b14 Reviewed-by: jcoomes ! make/hotspot_version Changeset: fab99b17c1de Author: mikael Date: 2012-06-01 20:17 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fab99b17c1de 7155453: [macosx] re-enable jbb tests in JPRT Summary: Run SPECjbb in headless mode and enable SPECjbb runs on OSX Reviewed-by: dcubed, dholmes ! make/jprt.properties Changeset: 4434fdad6b37 Author: dholmes Date: 2012-06-02 07:32 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4434fdad6b37 Merge ! make/jprt.properties Changeset: e17b61ba7bb3 Author: kamg Date: 2012-06-04 10:22 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e17b61ba7bb3 7166498: JVM crash in ClassVerifier Summary: Fixed raw pointer being used after potential safepoint/GC Reviewed-by: acorn, fparain, dholmes ! src/share/vm/classfile/verifier.cpp Changeset: a297b0e14605 Author: mgerdin Date: 2012-06-04 09:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a297b0e14605 7172226: HotSpot fails to build with GCC 4.7 because of stricter c++ argument dependent lookup Summary: Add "using" keyword to import base class functions from FreeList to fix template name lookup in gcc 4.7 Reviewed-by: brutisso, iveresov ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/memory/binaryTreeDictionary.hpp Changeset: 37552638d24a Author: brutisso Date: 2012-06-05 22:30 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/37552638d24a 7172388: G1: _total_full_collections should not be incremented for concurrent cycles Reviewed-by: azeemj, jmasa ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.hpp Changeset: b9442ac22f59 Author: brutisso Date: 2012-06-04 13:29 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b9442ac22f59 7173460: G1: java/lang/management/MemoryMXBean/CollectionUsageThreshold.java failes with G1 Summary: The scope of TraceMemoryManagerStats in G1CollectedHeap need to cover the call to G1MonitoringSupport::update_sizes() Reviewed-by: johnc, jmasa ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: 063451aefde8 Author: jcoomes Date: 2012-06-08 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/063451aefde8 Merge Changeset: 2fe087c3e814 Author: jiangli Date: 2012-06-06 14:33 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2fe087c3e814 7172967: Eliminate constMethod's _method backpointer to methodOop. Summary: Eliminate constMethod's _method backpointer to methodOop, and move the _constant field from methodOop to constMethod. Reviewed-by: roland, bdelsart, kamg ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstMethod.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.hpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/interp_masm_x86_32.hpp ! src/cpu/x86/vm/interp_masm_x86_64.hpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/os/solaris/dtrace/generateJvmOffsets.cpp ! src/os/solaris/dtrace/jhelper.d ! src/os/solaris/dtrace/libjvm_db.c ! src/share/vm/oops/constMethodKlass.cpp ! src/share/vm/oops/constMethodOop.cpp ! src/share/vm/oops/constMethodOop.hpp ! src/share/vm/oops/methodKlass.cpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: ab6ab9f84b2d Author: bdelsart Date: 2012-06-11 04:47 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ab6ab9f84b2d Merge Changeset: dcfcdd01af4b Author: fparain Date: 2012-06-05 06:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dcfcdd01af4b 7171703: JNI DefineClass crashes client VM when first parameter is NULL Reviewed-by: acorn, kamg, sspitsyn, dholmes ! src/share/vm/prims/jni.cpp Changeset: de909f001528 Author: mikael Date: 2012-06-06 05:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/de909f001528 7170275: os::print_os_info needs to know about Windows 8 Summary: Recognize Windows 8 and Windows Server 2012 Reviewed-by: sla, kvn, azeemj ! src/os/windows/vm/os_windows.cpp Changeset: 40b4aaf010e4 Author: dholmes Date: 2012-06-08 02:06 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/40b4aaf010e4 7172708: 32/64 bit type issues on Windows after Mac OS X port Reviewed-by: dholmes, coleenp Contributed-by: Chris Dennis ! src/share/vm/utilities/globalDefinitions_visCPP.hpp Changeset: 0a8b8cb8b22c Author: sla Date: 2012-06-11 10:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0a8b8cb8b22c Merge Changeset: 4d399f013e5a Author: kamg Date: 2012-06-11 13:10 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4d399f013e5a 7175914: Usage of gcc with precompiled headers produces wrong build dependencies Summary: Add -fpch-deps flag to gcc builds Reviewed-by: kamg, coleenp Contributed-by: volker.simonis at gmail.com ! make/bsd/makefiles/gcc.make ! make/linux/makefiles/gcc.make ! make/solaris/makefiles/gcc.make Changeset: 17b1b616daf7 Author: sla Date: 2012-06-14 12:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/17b1b616daf7 Merge Changeset: 8f6ce6f1049b Author: kvn Date: 2012-05-25 07:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8f6ce6f1049b 7170463: C2 should recognize "obj.getClass() == A.class" code pattern Summary: optimize this code pattern obj.getClass() == A.class. Reviewed-by: jrose, kvn Contributed-by: Krystal Mok ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/subnode.cpp Changeset: 4d8787136e08 Author: twisti Date: 2012-05-25 11:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4d8787136e08 7170145: C1 doesn't respect the JMM with volatile field loads Reviewed-by: kvn, roland ! src/share/vm/c1/c1_ValueMap.hpp Changeset: c8289830e172 Author: twisti Date: 2012-05-30 12:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c8289830e172 7172843: C1: fix "assert(has_printable_bci()) failed: _printable_bci should have been set" Reviewed-by: twisti Contributed-by: Krystal Mok ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_Instruction.hpp Changeset: 7bc2d5136f54 Author: amurillo Date: 2012-06-01 11:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7bc2d5136f54 7173635: jprt.properties should include release jdk7u6 Reviewed-by: jcoomes ! make/jprt.properties Changeset: 8f37087fc13f Author: roland Date: 2012-06-05 10:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8f37087fc13f 7171890: C1: add Class.isInstance intrinsic Summary: Class.cast which calls Class.isInstance is heavily used by the new JSR 292 implementation Reviewed-by: roland Contributed-by: Krystal Mok ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LIRGenerator.hpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/c1/c1_Runtime1.hpp Changeset: e1635876b206 Author: twisti Date: 2012-06-06 15:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e1635876b206 7174884: C1: failures after 7171890: assert(cur_state != NULL) failed: state_before must be set Reviewed-by: kvn ! src/share/vm/c1/c1_Canonicalizer.cpp Changeset: 829ee34e7cbd Author: kvn Date: 2012-06-11 08:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/829ee34e7cbd Merge ! make/jprt.properties Changeset: ccaa67adfe5b Author: twisti Date: 2012-06-11 16:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ccaa67adfe5b 7063674: Wrong results from basic comparisons after calls to Long.bitCount(long) Reviewed-by: kvn ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad Changeset: 0919b2e7895d Author: kvn Date: 2012-06-11 14:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0919b2e7895d 7174510: 19 JCK compiler tests fail with C2 error: memNode.cpp:812 - ShouldNotReachHere Summary: Add missing check for EncodeP node in MemNode::Ideal_common_DU_postCCP() method. Reviewed-by: twisti ! src/share/vm/opto/memnode.cpp Changeset: d5dded5d1e0d Author: kvn Date: 2012-06-11 22:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d5dded5d1e0d Merge Changeset: e7715c222897 Author: roland Date: 2012-06-12 10:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e7715c222897 7174532: jdk/test/java/lang/Math/WorstCaseTests.java failing on x86 Summary: increase precision on x86 for the steps of the computation of exp and pow. Reviewed-by: kvn ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp Changeset: 121e5708ae96 Author: kvn Date: 2012-06-12 09:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/121e5708ae96 7169782: C2: SIGSEGV in LShiftLNode::Ideal(PhaseGVN*, bool) Summary: keep intermediate node alive till the end of the graph construction using dummy hook node trick Reviewed-by: kvn, twisti Contributed-by: vladimir.x.ivanov at oracle.com ! src/share/vm/opto/divnode.cpp + test/compiler/6732154/Test6732154.java + test/compiler/7169782/Test7169782.java Changeset: 8b0a4867acf0 Author: twisti Date: 2012-06-12 14:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8b0a4867acf0 7174218: remove AtomicLongCSImpl intrinsics Reviewed-by: kvn, twisti Contributed-by: Krystal Mok ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/forms.cpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LIRGenerator.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/prims/jvm.h ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 5e990493719e Author: kvn Date: 2012-06-12 16:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5e990493719e 7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable Summary: replace frequent C2 optimizer code patterns with new methods calls Reviewed-by: kvn, twisti Contributed-by: vladimir.x.ivanov at oracle.com ! src/share/vm/opto/domgraph.cpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/loopPredicate.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopUnswitch.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/opto/split_if.cpp ! src/share/vm/opto/superword.cpp Changeset: e2fe93124108 Author: twisti Date: 2012-06-13 11:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e2fe93124108 7174928: JSR 292: unresolved invokedynamic call sites deopt and osr infinitely Reviewed-by: kvn ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp Changeset: eba1d5bce9e8 Author: kvn Date: 2012-06-14 14:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/eba1d5bce9e8 Merge ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 5ba29a1db46e Author: amurillo Date: 2012-06-15 14:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5ba29a1db46e Merge Changeset: 831e5c76a20a Author: amurillo Date: 2012-06-15 14:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/831e5c76a20a Added tag hs24-b14 for changeset 5ba29a1db46e ! .hgtags Changeset: 0976e71907b9 Author: katleman Date: 2012-06-21 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0976e71907b9 Added tag jdk8-b44 for changeset 831e5c76a20a ! .hgtags Changeset: 1e76463170b3 Author: kamg Date: 2012-03-29 18:55 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1e76463170b3 7110720: Issue with vm config file loadingIssue with vm config file loading Summary: disabling default config files if -XX:-ReadDefaultConfigFiles Reviewed-by: phh, jrose, dcubed, dholmes ! src/share/vm/compiler/compilerOracle.cpp ! src/share/vm/compiler/compilerOracle.hpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/runtime/arguments.cpp + test/runtime/7110720/Test7110720.sh Changeset: e778c29768e6 Author: never Date: 2012-04-04 20:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e778c29768e6 7152811: Issues in client compiler Reviewed-by: kvn, jrose ! src/share/vm/ci/ciField.cpp ! src/share/vm/ci/ciField.hpp Changeset: 958bb4b7be49 Author: asaha Date: 2012-04-10 10:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/958bb4b7be49 Merge ! src/share/vm/runtime/arguments.cpp Changeset: aa07e41a9f80 Author: never Date: 2012-04-12 12:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/aa07e41a9f80 7160677: missing else in fix for 7152811 Reviewed-by: kvn, kevinw ! src/share/vm/ci/ciField.cpp Changeset: 5142b5110214 Author: asaha Date: 2012-05-08 07:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5142b5110214 Merge ! src/share/vm/opto/runtime.cpp Changeset: d558e01a72c0 Author: kamg Date: 2012-05-03 15:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d558e01a72c0 7160757: Problem with hotspot/runtime_classfile Summary: Allow only current and super invokespecials of Reviewed-by: never, coleenp, dcubed ! src/share/vm/classfile/verifier.cpp + test/runtime/7160757/Test7160757.java Changeset: 6d2c830e025d Author: asaha Date: 2012-05-08 11:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6d2c830e025d Merge Changeset: 84e198dc2474 Author: asaha Date: 2012-05-21 14:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/84e198dc2474 Merge - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.hpp ! src/share/vm/runtime/arguments.cpp Changeset: f9d57285de70 Author: asaha Date: 2012-06-07 12:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f9d57285de70 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 9d5f20961bc5 Author: lana Date: 2012-06-26 10:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9d5f20961bc5 Merge ! src/share/vm/classfile/verifier.cpp From lana.steuck at oracle.com Wed Jun 27 00:16:52 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 27 Jun 2012 07:16:52 +0000 Subject: hg: jdk8/tl/jdk: 36 new changesets Message-ID: <20120627072323.5563547B4D@hg.openjdk.java.net> Changeset: 9d88f2ce6338 Author: katleman Date: 2012-06-21 17:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9d88f2ce6338 Added tag jdk8-b44 for changeset db471a7af031 ! .hgtags Changeset: eb50eeb2eb7d Author: prr Date: 2012-06-13 12:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eb50eeb2eb7d 7027300: Unsynchronized HashMap access causes endless loop Reviewed-by: bae, jgodinez ! src/share/classes/sun/font/SunLayoutEngine.java Changeset: 5959fec806d8 Author: bae Date: 2012-06-14 11:14 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5959fec806d8 7153693: Three 2D_ImageIO tests failed due ImageFormatException on OEL 6.* Unbreakable Kernel x64 Reviewed-by: jgodinez, prr ! src/share/native/sun/awt/image/jpeg/jpegdecoder.c Changeset: 2aa89f018a2f Author: prr Date: 2012-06-14 16:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2aa89f018a2f 7158366: [macosx] Print-to-file dialog doesn't have an entry field for a name Reviewed-by: bae, jgodinez ! src/share/classes/sun/print/ServiceDialog.java Changeset: e42563f8ec12 Author: lana Date: 2012-06-17 22:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e42563f8ec12 Merge - makefiles/altclasses/Makefile - makefiles/apple/Makefile - makefiles/apple/applescript/Makefile - makefiles/com/Makefile - makefiles/com/apple/Makefile - makefiles/com/apple/osx/Makefile - makefiles/com/apple/osxui/Makefile - makefiles/com/oracle/Makefile - makefiles/com/oracle/jfr/Makefile - makefiles/com/oracle/security/ucrypto/FILES_c.gmk - makefiles/com/oracle/security/ucrypto/Makefile - makefiles/com/oracle/security/ucrypto/mapfile-vers - makefiles/com/sun/Makefile - makefiles/common/shared/Defs-utils.gmk - makefiles/java/fdlibm/FILES_c.gmk - makefiles/java/fdlibm/Makefile - makefiles/java/instrument/Makefile - makefiles/java/instrument/mapfile-vers - makefiles/java/java/Exportedfiles.gmk - makefiles/java/java/FILES_c.gmk - makefiles/java/java/FILES_java.gmk - makefiles/java/java/Makefile - makefiles/java/java/localelist.sh - makefiles/java/java/mapfile-vers - makefiles/java/java/reflect/Makefile - makefiles/java/java/reorder-i586 - makefiles/java/java/reorder-sparc - makefiles/java/java/reorder-sparcv9 - makefiles/java/java_crw_demo/Makefile - makefiles/java/java_crw_demo/mapfile-vers - makefiles/java/java_hprof_demo/Makefile - makefiles/java/java_hprof_demo/mapfile-vers - makefiles/java/jexec/Makefile - makefiles/java/jli/Makefile - makefiles/java/jli/mapfile-vers - makefiles/java/jobjc/Makefile - makefiles/java/jvm/Makefile - makefiles/java/main/Makefile - makefiles/java/main/java/Makefile - makefiles/java/main/java/mapfile-amd64 - makefiles/java/main/java/mapfile-i586 - makefiles/java/main/java/mapfile-sparc - makefiles/java/main/java/mapfile-sparcv9 - makefiles/java/main/javaw/Makefile - makefiles/java/management/Exportedfiles.gmk - makefiles/java/management/FILES_c.gmk - makefiles/java/management/Makefile - makefiles/java/management/mapfile-vers - makefiles/java/net/FILES_c.gmk - makefiles/java/net/Makefile - makefiles/java/net/mapfile-vers - makefiles/java/nio/Exportedfiles.gmk - makefiles/java/nio/FILES_c.gmk - makefiles/java/nio/FILES_java.gmk - makefiles/java/nio/Makefile - makefiles/java/nio/addNotices.sh - makefiles/java/nio/genBuffer.sh - makefiles/java/nio/genCharsetProvider.sh - makefiles/java/nio/genCoder.sh - makefiles/java/nio/genExceptions.sh - makefiles/java/nio/mapfile-bsd - makefiles/java/nio/mapfile-linux - makefiles/java/nio/mapfile-solaris - makefiles/java/nio/reorder-i586 - makefiles/java/nio/reorder-sparc - makefiles/java/nio/reorder-sparcv9 - makefiles/java/npt/Makefile - makefiles/java/npt/mapfile-vers - makefiles/java/redist/fonts/Makefile - makefiles/java/security/Makefile - makefiles/java/sun_nio/FILES_java.gmk - makefiles/java/sun_nio/Makefile - makefiles/java/util/FILES_java.gmk - makefiles/java/util/FILES_properties.gmk - makefiles/java/util/Makefile - makefiles/java/verify/Makefile - makefiles/java/verify/mapfile-vers - makefiles/java/verify/reorder-i586 - makefiles/java/verify/reorder-sparc - makefiles/java/verify/reorder-sparcv9 - makefiles/javax/Makefile - makefiles/javax/imageio/Makefile - makefiles/javax/management/Makefile - makefiles/javax/sound/FILES_c.gmk - makefiles/javax/sound/Makefile - makefiles/javax/sound/SoundDefs.gmk - makefiles/javax/sound/jsoundalsa/Makefile - makefiles/javax/sound/jsoundalsa/mapfile-vers - makefiles/javax/sound/jsoundds/Makefile - makefiles/javax/sound/mapfile-vers - makefiles/javax/sql/Makefile - makefiles/javax/swing/FILES.gmk - makefiles/javax/swing/Makefile - makefiles/javax/swing/beaninfo/FILES.gmk - makefiles/javax/swing/beaninfo/Makefile - makefiles/javax/swing/beaninfo/SwingBeans.gmk - makefiles/javax/swing/beaninfo/manifest - makefiles/javax/swing/html32dtd/Makefile - makefiles/javax/swing/plaf/FILES.gmk - makefiles/javax/swing/plaf/Makefile - makefiles/sun/Makefile - makefiles/sun/awt/CondenseRules.awk - makefiles/sun/awt/Depend.mak - makefiles/sun/awt/Depend.sed - makefiles/sun/awt/FILES_c_macosx.gmk - makefiles/sun/awt/FILES_c_unix.gmk - makefiles/sun/awt/FILES_c_windows.gmk - makefiles/sun/awt/FILES_export_macosx.gmk - makefiles/sun/awt/FILES_export_unix.gmk - makefiles/sun/awt/FILES_export_windows.gmk - makefiles/sun/awt/Makefile - makefiles/sun/awt/README - makefiles/sun/awt/make.depend - makefiles/sun/awt/mapfile-mawt-vers - makefiles/sun/awt/mapfile-vers - makefiles/sun/awt/mapfile-vers-linux - makefiles/sun/awt/mawt.gmk - makefiles/sun/cmm/Makefile - makefiles/sun/cmm/kcms/FILES_c_unix.gmk - makefiles/sun/cmm/kcms/FILES_c_windows.gmk - makefiles/sun/cmm/kcms/Makefile - makefiles/sun/cmm/kcms/mapfile-vers - makefiles/sun/dcpr/FILES_c.gmk - makefiles/sun/dcpr/Makefile - makefiles/sun/dcpr/mapfile-vers - makefiles/sun/headless/Makefile - makefiles/sun/headless/mapfile-vers - makefiles/sun/headless/reorder-i586 - makefiles/sun/headless/reorder-sparc - makefiles/sun/headless/reorder-sparcv9 - makefiles/sun/image/Makefile - makefiles/sun/image/generic/FILES_c.gmk - makefiles/sun/image/generic/Makefile - makefiles/sun/image/generic/mapfile-vers - makefiles/sun/image/vis/FILES_c.gmk - makefiles/sun/image/vis/Makefile - makefiles/sun/javazic/Makefile - makefiles/sun/jdbc/Makefile - makefiles/sun/jdga/Makefile - makefiles/sun/jdga/mapfile-vers - makefiles/sun/lwawt/FILES_c_macosx.gmk - makefiles/sun/lwawt/FILES_export_macosx.gmk - makefiles/sun/lwawt/Makefile - makefiles/sun/nio/Makefile - makefiles/sun/nio/cs/FILES_java.gmk - makefiles/sun/nio/cs/Makefile - makefiles/sun/org/Makefile - makefiles/sun/org/mozilla/Makefile - makefiles/sun/org/mozilla/javascript/Makefile - makefiles/sun/osxapp/Makefile - makefiles/sun/security/Makefile - makefiles/sun/security/ec/FILES_c.gmk - makefiles/sun/security/ec/mapfile-vers - makefiles/sun/security/jgss/Makefile - makefiles/sun/security/jgss/wrapper/FILES_c.gmk - makefiles/sun/security/jgss/wrapper/Makefile - makefiles/sun/security/jgss/wrapper/mapfile-vers - makefiles/sun/security/krb5/FILES_c_windows.gmk - makefiles/sun/security/krb5/Makefile - makefiles/sun/security/mscapi/FILES_cpp.gmk - makefiles/sun/security/mscapi/Makefile - makefiles/sun/security/other/Makefile - makefiles/sun/security/smartcardio/FILES_c.gmk - makefiles/sun/security/smartcardio/Makefile - makefiles/sun/security/smartcardio/mapfile-vers - makefiles/sun/security/tools/Makefile - makefiles/sun/security/util/Makefile - makefiles/sun/splashscreen/FILES_c.gmk - makefiles/sun/splashscreen/Makefile - makefiles/sun/splashscreen/mapfile-vers - makefiles/sun/xawt/FILES_c_unix.gmk - makefiles/sun/xawt/FILES_export_unix.gmk - makefiles/sun/xawt/Makefile - makefiles/sun/xawt/mapfile-vers - src/share/classes/sun/nio/ch/DevPollSelectorProvider.java - src/share/classes/sun/security/provider/certpath/CrlRevocationChecker.java - src/share/classes/sun/security/provider/certpath/OCSPChecker.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources_ja.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources_zh_CN.java - src/share/native/java/sql/DriverManager.c - test/sun/security/krb5/auto/ok-as-delegate-xrealm.sh - test/sun/security/krb5/auto/ok-as-delegate.sh Changeset: b8ff85860648 Author: prr Date: 2012-06-19 09:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b8ff85860648 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null Reviewed-by: bae, igor ! src/solaris/classes/sun/print/CUPSPrinter.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java Changeset: c05893704c82 Author: lana Date: 2012-06-25 21:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c05893704c82 Merge Changeset: 45259658e158 Author: rupashka Date: 2012-06-09 17:42 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/45259658e158 7165725: JAVA6 HTML PARSER CANNOT PARSE MULTIPLE SCRIPT TAGS IN A LINE CORRECTLY Reviewed-by: alexsch ! src/share/classes/javax/swing/text/html/parser/Parser.java + test/javax/swing/text/html/parser/Parser/7165725/bug7165725.java + test/javax/swing/text/html/parser/Parser/7165725/false-text-after-script.html + test/javax/swing/text/html/parser/Parser/7165725/successive-script-tag.html Changeset: 0474e0ed2ef2 Author: kizune Date: 2012-06-09 19:18 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0474e0ed2ef2 7173487: closed/java/awt/Frame/RemoveNotifyTest/RemoveNotifyTest.html Reviewed-by: anthony, dcherepanov, serb ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java Changeset: b57167b71169 Author: luchsh Date: 2012-06-11 10:52 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b57167b71169 7155887: ComboBox does not display focus outline in GTK L&F Reviewed-by: rupashka ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKPainter.java Changeset: f05e517a74b3 Author: anthony Date: 2012-06-13 18:33 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f05e517a74b3 7176644: [macosx] Missing NSAutoreleasePool in CGLGraphicsConfig.m OGLGC_DestroyOGLGraphicsConfig Summary: Create and drain an autorelease pool Reviewed-by: anthony, dcherepanov Contributed-by: Tomas Hurka ! src/macosx/native/sun/java2d/opengl/CGLGraphicsConfig.m Changeset: f90369b3d61d Author: alexsch Date: 2012-06-13 18:43 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f90369b3d61d 7150049: [macosx] closed/javax/swing/JCheckBox/4449413/bug4449413.java check the checkbox again,it auto fail Reviewed-by: rupashka + test/javax/swing/JCheckBox/4449413/bug4449413.html + test/javax/swing/JCheckBox/4449413/bug4449413.java Changeset: 8326709c6315 Author: kizune Date: 2012-06-15 18:28 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8326709c6315 7171163: [macosx] Shortcomings in the design of the secondary native event loop made JavaFX DnD deadlock Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/macosx/CToolkitThreadBlockedHandler.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/LWCToolkit.m ! src/share/classes/sun/awt/dnd/SunDropTargetContextPeer.java Changeset: f709f8ebebd4 Author: lana Date: 2012-06-17 22:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f709f8ebebd4 Merge - makefiles/altclasses/Makefile - makefiles/apple/Makefile - makefiles/apple/applescript/Makefile - makefiles/com/Makefile - makefiles/com/apple/Makefile - makefiles/com/apple/osx/Makefile - makefiles/com/apple/osxui/Makefile - makefiles/com/oracle/Makefile - makefiles/com/oracle/jfr/Makefile - makefiles/com/oracle/security/ucrypto/FILES_c.gmk - makefiles/com/oracle/security/ucrypto/Makefile - makefiles/com/oracle/security/ucrypto/mapfile-vers - makefiles/com/sun/Makefile - makefiles/common/shared/Defs-utils.gmk - makefiles/java/fdlibm/FILES_c.gmk - makefiles/java/fdlibm/Makefile - makefiles/java/instrument/Makefile - makefiles/java/instrument/mapfile-vers - makefiles/java/java/Exportedfiles.gmk - makefiles/java/java/FILES_c.gmk - makefiles/java/java/FILES_java.gmk - makefiles/java/java/Makefile - makefiles/java/java/localelist.sh - makefiles/java/java/mapfile-vers - makefiles/java/java/reflect/Makefile - makefiles/java/java/reorder-i586 - makefiles/java/java/reorder-sparc - makefiles/java/java/reorder-sparcv9 - makefiles/java/java_crw_demo/Makefile - makefiles/java/java_crw_demo/mapfile-vers - makefiles/java/java_hprof_demo/Makefile - makefiles/java/java_hprof_demo/mapfile-vers - makefiles/java/jexec/Makefile - makefiles/java/jli/Makefile - makefiles/java/jli/mapfile-vers - makefiles/java/jobjc/Makefile - makefiles/java/jvm/Makefile - makefiles/java/main/Makefile - makefiles/java/main/java/Makefile - makefiles/java/main/java/mapfile-amd64 - makefiles/java/main/java/mapfile-i586 - makefiles/java/main/java/mapfile-sparc - makefiles/java/main/java/mapfile-sparcv9 - makefiles/java/main/javaw/Makefile - makefiles/java/management/Exportedfiles.gmk - makefiles/java/management/FILES_c.gmk - makefiles/java/management/Makefile - makefiles/java/management/mapfile-vers - makefiles/java/net/FILES_c.gmk - makefiles/java/net/Makefile - makefiles/java/net/mapfile-vers - makefiles/java/nio/Exportedfiles.gmk - makefiles/java/nio/FILES_c.gmk - makefiles/java/nio/FILES_java.gmk - makefiles/java/nio/Makefile - makefiles/java/nio/addNotices.sh - makefiles/java/nio/genBuffer.sh - makefiles/java/nio/genCharsetProvider.sh - makefiles/java/nio/genCoder.sh - makefiles/java/nio/genExceptions.sh - makefiles/java/nio/mapfile-bsd - makefiles/java/nio/mapfile-linux - makefiles/java/nio/mapfile-solaris - makefiles/java/nio/reorder-i586 - makefiles/java/nio/reorder-sparc - makefiles/java/nio/reorder-sparcv9 - makefiles/java/npt/Makefile - makefiles/java/npt/mapfile-vers - makefiles/java/redist/fonts/Makefile - makefiles/java/security/Makefile - makefiles/java/sun_nio/FILES_java.gmk - makefiles/java/sun_nio/Makefile - makefiles/java/util/FILES_java.gmk - makefiles/java/util/FILES_properties.gmk - makefiles/java/util/Makefile - makefiles/java/verify/Makefile - makefiles/java/verify/mapfile-vers - makefiles/java/verify/reorder-i586 - makefiles/java/verify/reorder-sparc - makefiles/java/verify/reorder-sparcv9 - makefiles/javax/Makefile - makefiles/javax/imageio/Makefile - makefiles/javax/management/Makefile - makefiles/javax/sound/FILES_c.gmk - makefiles/javax/sound/Makefile - makefiles/javax/sound/SoundDefs.gmk - makefiles/javax/sound/jsoundalsa/Makefile - makefiles/javax/sound/jsoundalsa/mapfile-vers - makefiles/javax/sound/jsoundds/Makefile - makefiles/javax/sound/mapfile-vers - makefiles/javax/sql/Makefile - makefiles/javax/swing/FILES.gmk - makefiles/javax/swing/Makefile - makefiles/javax/swing/beaninfo/FILES.gmk - makefiles/javax/swing/beaninfo/Makefile - makefiles/javax/swing/beaninfo/SwingBeans.gmk - makefiles/javax/swing/beaninfo/manifest - makefiles/javax/swing/html32dtd/Makefile - makefiles/javax/swing/plaf/FILES.gmk - makefiles/javax/swing/plaf/Makefile - makefiles/sun/Makefile - makefiles/sun/awt/CondenseRules.awk - makefiles/sun/awt/Depend.mak - makefiles/sun/awt/Depend.sed - makefiles/sun/awt/FILES_c_macosx.gmk - makefiles/sun/awt/FILES_c_unix.gmk - makefiles/sun/awt/FILES_c_windows.gmk - makefiles/sun/awt/FILES_export_macosx.gmk - makefiles/sun/awt/FILES_export_unix.gmk - makefiles/sun/awt/FILES_export_windows.gmk - makefiles/sun/awt/Makefile - makefiles/sun/awt/README - makefiles/sun/awt/make.depend - makefiles/sun/awt/mapfile-mawt-vers - makefiles/sun/awt/mapfile-vers - makefiles/sun/awt/mapfile-vers-linux - makefiles/sun/awt/mawt.gmk - makefiles/sun/cmm/Makefile - makefiles/sun/cmm/kcms/FILES_c_unix.gmk - makefiles/sun/cmm/kcms/FILES_c_windows.gmk - makefiles/sun/cmm/kcms/Makefile - makefiles/sun/cmm/kcms/mapfile-vers - makefiles/sun/dcpr/FILES_c.gmk - makefiles/sun/dcpr/Makefile - makefiles/sun/dcpr/mapfile-vers - makefiles/sun/headless/Makefile - makefiles/sun/headless/mapfile-vers - makefiles/sun/headless/reorder-i586 - makefiles/sun/headless/reorder-sparc - makefiles/sun/headless/reorder-sparcv9 - makefiles/sun/image/Makefile - makefiles/sun/image/generic/FILES_c.gmk - makefiles/sun/image/generic/Makefile - makefiles/sun/image/generic/mapfile-vers - makefiles/sun/image/vis/FILES_c.gmk - makefiles/sun/image/vis/Makefile - makefiles/sun/javazic/Makefile - makefiles/sun/jdbc/Makefile - makefiles/sun/jdga/Makefile - makefiles/sun/jdga/mapfile-vers - makefiles/sun/lwawt/FILES_c_macosx.gmk - makefiles/sun/lwawt/FILES_export_macosx.gmk - makefiles/sun/lwawt/Makefile - makefiles/sun/nio/Makefile - makefiles/sun/nio/cs/FILES_java.gmk - makefiles/sun/nio/cs/Makefile - makefiles/sun/org/Makefile - makefiles/sun/org/mozilla/Makefile - makefiles/sun/org/mozilla/javascript/Makefile - makefiles/sun/osxapp/Makefile - makefiles/sun/security/Makefile - makefiles/sun/security/ec/FILES_c.gmk - makefiles/sun/security/ec/mapfile-vers - makefiles/sun/security/jgss/Makefile - makefiles/sun/security/jgss/wrapper/FILES_c.gmk - makefiles/sun/security/jgss/wrapper/Makefile - makefiles/sun/security/jgss/wrapper/mapfile-vers - makefiles/sun/security/krb5/FILES_c_windows.gmk - makefiles/sun/security/krb5/Makefile - makefiles/sun/security/mscapi/FILES_cpp.gmk - makefiles/sun/security/mscapi/Makefile - makefiles/sun/security/other/Makefile - makefiles/sun/security/smartcardio/FILES_c.gmk - makefiles/sun/security/smartcardio/Makefile - makefiles/sun/security/smartcardio/mapfile-vers - makefiles/sun/security/tools/Makefile - makefiles/sun/security/util/Makefile - makefiles/sun/splashscreen/FILES_c.gmk - makefiles/sun/splashscreen/Makefile - makefiles/sun/splashscreen/mapfile-vers - makefiles/sun/xawt/FILES_c_unix.gmk - makefiles/sun/xawt/FILES_export_unix.gmk - makefiles/sun/xawt/Makefile - makefiles/sun/xawt/mapfile-vers - src/share/classes/sun/nio/ch/DevPollSelectorProvider.java - src/share/classes/sun/security/provider/certpath/CrlRevocationChecker.java - src/share/classes/sun/security/provider/certpath/OCSPChecker.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources_ja.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources_zh_CN.java - src/share/native/java/sql/DriverManager.c - test/sun/security/krb5/auto/ok-as-delegate-xrealm.sh - test/sun/security/krb5/auto/ok-as-delegate.sh Changeset: 4b470e9017da Author: alexsch Date: 2012-06-18 15:39 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4b470e9017da 7174970: NLS [ccjk] Extra mnemonic keys at standard filechooserdialog (open and save) in metal L&F Reviewed-by: rupashka ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_de.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_es.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_it.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_TW.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_de.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_es.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_it.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_zh_TW.properties Changeset: 3226f1968e77 Author: kizune Date: 2012-06-19 21:09 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3226f1968e77 7172430: [macosx] debug message in non debug jdk build Reviewed-by: anthony, serb ! src/macosx/native/sun/awt/AWTView.m Changeset: e7dc778d768e Author: anthony Date: 2012-06-22 16:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7dc778d768e 7170716: JVM crash when opening an AWT app from a registered file. Summary: Copy the queued blocks to prevent their deallocation Reviewed-by: anthony, swingler Contributed-by: Marco Dinacci ! src/macosx/native/sun/osxapp/QueuingApplicationDelegate.h ! src/macosx/native/sun/osxapp/QueuingApplicationDelegate.m Changeset: cafcc94a11a7 Author: anthony Date: 2012-06-25 17:27 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cafcc94a11a7 7174718: [macosx] Regression in 7u6 b12: PopupFactory leaks DefaultFrames. Summary: Fix memory management Reviewed-by: art, serb ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTWindow.m Changeset: 6dae09c6759e Author: lana Date: 2012-06-25 21:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6dae09c6759e Merge Changeset: b76779abcd7f Author: lana Date: 2012-06-25 21:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b76779abcd7f Merge Changeset: bff59bf994da Author: mullan Date: 2012-02-22 15:38 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bff59bf994da 7145239: Finetune package definition restriction Reviewed-by: hawtin ! src/share/lib/security/java.security ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows Changeset: 1d8a3ef381f7 Author: bae Date: 2012-02-28 10:44 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d8a3ef381f7 7143617: Improve fontmanager layout lookup operations Reviewed-by: igor, prr, mschoene ! src/share/native/sun/font/layout/LookupProcessor.cpp ! src/share/native/sun/font/layout/LookupProcessor.h Changeset: 9e6e535a6769 Author: rupashka Date: 2012-02-28 16:09 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9e6e535a6769 7143614: SynthLookAndFeel stability improvement Reviewed-by: malenkov ! src/share/classes/javax/swing/plaf/synth/SynthButtonUI.java ! src/share/classes/javax/swing/plaf/synth/SynthLabelUI.java ! src/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java + test/javax/swing/plaf/synth/7143614/bug7143614.java Changeset: 8516c5b4521b Author: weijun Date: 2012-02-29 14:06 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8516c5b4521b 7143872: Improve certificate extension processing Reviewed-by: mullan ! src/share/classes/sun/security/x509/CRLExtensions.java ! src/share/classes/sun/security/x509/CertificateExtensions.java ! src/share/classes/sun/security/x509/X509CRLEntryImpl.java ! src/share/classes/sun/security/x509/X509CRLImpl.java ! src/share/classes/sun/security/x509/X509CertImpl.java + test/sun/security/x509/X509CRLImpl/OrderAndDup.java Changeset: 3640f1a043f8 Author: coffeys Date: 2012-03-26 14:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3640f1a043f8 7143851: Improve IIOP stub and tie generation in RMIC 7149048: Changes to corba rmic stubGenerator class are not used during jdk build process Reviewed-by: mschoene, robm ! make/com/sun/jmx/Makefile Changeset: 9de49289df0f Author: asaha Date: 2012-04-10 10:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9de49289df0f Merge ! make/com/oracle/net/Makefile - make/sun/motif12/reorder-i586 - make/sun/motif12/reorder-sparc - make/sun/motif12/reorder-sparcv9 ! make/sun/rmi/rmi/mapfile-vers - src/linux/doc/man/apt.1 - src/linux/doc/man/ja/apt.1 - src/share/classes/com/sun/tools/jdi/LinkedHashMap.java - src/share/classes/java/lang/invoke/FilterGeneric.java - src/share/classes/java/lang/invoke/FilterOneArgument.java - src/share/classes/java/lang/invoke/FromGeneric.java - src/share/classes/java/lang/invoke/SpreadGeneric.java - src/share/classes/java/lang/invoke/ToGeneric.java - src/share/classes/java/util/XMLUtils.java - src/share/classes/sun/awt/FocusingTextField.java - src/share/classes/sun/awt/HorizBagLayout.java - src/share/classes/sun/awt/OrientableFlowLayout.java - src/share/classes/sun/awt/VariableGridLayout.java - src/share/classes/sun/awt/VerticalBagLayout.java - src/share/classes/sun/io/ByteToCharASCII.java - src/share/classes/sun/io/ByteToCharBig5.java - src/share/classes/sun/io/ByteToCharBig5_HKSCS.java - src/share/classes/sun/io/ByteToCharBig5_Solaris.java - src/share/classes/sun/io/ByteToCharConverter.java - src/share/classes/sun/io/ByteToCharCp037.java - src/share/classes/sun/io/ByteToCharCp1006.java - src/share/classes/sun/io/ByteToCharCp1025.java - src/share/classes/sun/io/ByteToCharCp1026.java - src/share/classes/sun/io/ByteToCharCp1046.java - src/share/classes/sun/io/ByteToCharCp1047.java - src/share/classes/sun/io/ByteToCharCp1097.java - src/share/classes/sun/io/ByteToCharCp1098.java - src/share/classes/sun/io/ByteToCharCp1112.java - src/share/classes/sun/io/ByteToCharCp1122.java - src/share/classes/sun/io/ByteToCharCp1123.java - src/share/classes/sun/io/ByteToCharCp1124.java - src/share/classes/sun/io/ByteToCharCp1140.java - src/share/classes/sun/io/ByteToCharCp1141.java - src/share/classes/sun/io/ByteToCharCp1142.java - src/share/classes/sun/io/ByteToCharCp1143.java - src/share/classes/sun/io/ByteToCharCp1144.java - src/share/classes/sun/io/ByteToCharCp1145.java - src/share/classes/sun/io/ByteToCharCp1146.java - src/share/classes/sun/io/ByteToCharCp1147.java - src/share/classes/sun/io/ByteToCharCp1148.java - src/share/classes/sun/io/ByteToCharCp1149.java - src/share/classes/sun/io/ByteToCharCp1250.java - src/share/classes/sun/io/ByteToCharCp1251.java - src/share/classes/sun/io/ByteToCharCp1252.java - src/share/classes/sun/io/ByteToCharCp1253.java - src/share/classes/sun/io/ByteToCharCp1254.java - src/share/classes/sun/io/ByteToCharCp1255.java - src/share/classes/sun/io/ByteToCharCp1256.java - src/share/classes/sun/io/ByteToCharCp1257.java - src/share/classes/sun/io/ByteToCharCp1258.java - src/share/classes/sun/io/ByteToCharCp1381.java - src/share/classes/sun/io/ByteToCharCp1383.java - src/share/classes/sun/io/ByteToCharCp273.java - src/share/classes/sun/io/ByteToCharCp277.java - src/share/classes/sun/io/ByteToCharCp278.java - src/share/classes/sun/io/ByteToCharCp280.java - src/share/classes/sun/io/ByteToCharCp284.java - src/share/classes/sun/io/ByteToCharCp285.java - src/share/classes/sun/io/ByteToCharCp297.java - src/share/classes/sun/io/ByteToCharCp33722.java - src/share/classes/sun/io/ByteToCharCp420.java - src/share/classes/sun/io/ByteToCharCp424.java - src/share/classes/sun/io/ByteToCharCp437.java - src/share/classes/sun/io/ByteToCharCp500.java - src/share/classes/sun/io/ByteToCharCp737.java - src/share/classes/sun/io/ByteToCharCp775.java - src/share/classes/sun/io/ByteToCharCp833.java - src/share/classes/sun/io/ByteToCharCp834.java - src/share/classes/sun/io/ByteToCharCp838.java - src/share/classes/sun/io/ByteToCharCp850.java - src/share/classes/sun/io/ByteToCharCp852.java - src/share/classes/sun/io/ByteToCharCp855.java - src/share/classes/sun/io/ByteToCharCp856.java - src/share/classes/sun/io/ByteToCharCp857.java - src/share/classes/sun/io/ByteToCharCp858.java - src/share/classes/sun/io/ByteToCharCp860.java - src/share/classes/sun/io/ByteToCharCp861.java - src/share/classes/sun/io/ByteToCharCp862.java - src/share/classes/sun/io/ByteToCharCp863.java - src/share/classes/sun/io/ByteToCharCp864.java - src/share/classes/sun/io/ByteToCharCp865.java - src/share/classes/sun/io/ByteToCharCp866.java - src/share/classes/sun/io/ByteToCharCp868.java - src/share/classes/sun/io/ByteToCharCp869.java - src/share/classes/sun/io/ByteToCharCp870.java - src/share/classes/sun/io/ByteToCharCp871.java - src/share/classes/sun/io/ByteToCharCp874.java - src/share/classes/sun/io/ByteToCharCp875.java - src/share/classes/sun/io/ByteToCharCp918.java - src/share/classes/sun/io/ByteToCharCp921.java - src/share/classes/sun/io/ByteToCharCp922.java - src/share/classes/sun/io/ByteToCharCp930.java - src/share/classes/sun/io/ByteToCharCp933.java - src/share/classes/sun/io/ByteToCharCp935.java - src/share/classes/sun/io/ByteToCharCp937.java - src/share/classes/sun/io/ByteToCharCp939.java - src/share/classes/sun/io/ByteToCharCp942.java - src/share/classes/sun/io/ByteToCharCp942C.java - src/share/classes/sun/io/ByteToCharCp943.java - src/share/classes/sun/io/ByteToCharCp943C.java - src/share/classes/sun/io/ByteToCharCp948.java - src/share/classes/sun/io/ByteToCharCp949.java - src/share/classes/sun/io/ByteToCharCp949C.java - src/share/classes/sun/io/ByteToCharCp950.java - src/share/classes/sun/io/ByteToCharCp964.java - src/share/classes/sun/io/ByteToCharCp970.java - src/share/classes/sun/io/ByteToCharDBCS_ASCII.java - src/share/classes/sun/io/ByteToCharDBCS_EBCDIC.java - src/share/classes/sun/io/ByteToCharDoubleByte.java - src/share/classes/sun/io/ByteToCharEUC.java - src/share/classes/sun/io/ByteToCharEUC2.java - src/share/classes/sun/io/ByteToCharEUC_CN.java - src/share/classes/sun/io/ByteToCharEUC_JP.java - src/share/classes/sun/io/ByteToCharEUC_JP_LINUX.java - src/share/classes/sun/io/ByteToCharEUC_JP_Solaris.java - src/share/classes/sun/io/ByteToCharEUC_KR.java - src/share/classes/sun/io/ByteToCharEUC_TW.java - src/share/classes/sun/io/ByteToCharGB18030.java - src/share/classes/sun/io/ByteToCharGB18030DB.java - src/share/classes/sun/io/ByteToCharGBK.java - src/share/classes/sun/io/ByteToCharISCII91.java - src/share/classes/sun/io/ByteToCharISO2022.java - src/share/classes/sun/io/ByteToCharISO2022CN.java - src/share/classes/sun/io/ByteToCharISO2022JP.java - src/share/classes/sun/io/ByteToCharISO2022KR.java - src/share/classes/sun/io/ByteToCharISO8859_1.java - src/share/classes/sun/io/ByteToCharISO8859_13.java - src/share/classes/sun/io/ByteToCharISO8859_15.java - src/share/classes/sun/io/ByteToCharISO8859_2.java - src/share/classes/sun/io/ByteToCharISO8859_3.java - src/share/classes/sun/io/ByteToCharISO8859_4.java - src/share/classes/sun/io/ByteToCharISO8859_5.java - src/share/classes/sun/io/ByteToCharISO8859_6.java - src/share/classes/sun/io/ByteToCharISO8859_7.java - src/share/classes/sun/io/ByteToCharISO8859_8.java - src/share/classes/sun/io/ByteToCharISO8859_9.java - src/share/classes/sun/io/ByteToCharJIS0201.java - src/share/classes/sun/io/ByteToCharJIS0208.java - src/share/classes/sun/io/ByteToCharJIS0208_Solaris.java - src/share/classes/sun/io/ByteToCharJIS0212.java - src/share/classes/sun/io/ByteToCharJIS0212_Solaris.java - src/share/classes/sun/io/ByteToCharJISAutoDetect.java - src/share/classes/sun/io/ByteToCharJohab.java - src/share/classes/sun/io/ByteToCharKOI8_R.java - src/share/classes/sun/io/ByteToCharMS874.java - src/share/classes/sun/io/ByteToCharMS932.java - src/share/classes/sun/io/ByteToCharMS936.java - src/share/classes/sun/io/ByteToCharMS949.java - src/share/classes/sun/io/ByteToCharMS950.java - src/share/classes/sun/io/ByteToCharMS950_HKSCS.java - src/share/classes/sun/io/ByteToCharMacArabic.java - src/share/classes/sun/io/ByteToCharMacCentralEurope.java - src/share/classes/sun/io/ByteToCharMacCroatian.java - src/share/classes/sun/io/ByteToCharMacCyrillic.java - src/share/classes/sun/io/ByteToCharMacDingbat.java - src/share/classes/sun/io/ByteToCharMacGreek.java - src/share/classes/sun/io/ByteToCharMacHebrew.java - src/share/classes/sun/io/ByteToCharMacIceland.java - src/share/classes/sun/io/ByteToCharMacRoman.java - src/share/classes/sun/io/ByteToCharMacRomania.java - src/share/classes/sun/io/ByteToCharMacSymbol.java - src/share/classes/sun/io/ByteToCharMacThai.java - src/share/classes/sun/io/ByteToCharMacTurkish.java - src/share/classes/sun/io/ByteToCharMacUkraine.java - src/share/classes/sun/io/ByteToCharPCK.java - src/share/classes/sun/io/ByteToCharSJIS.java - src/share/classes/sun/io/ByteToCharSingleByte.java - src/share/classes/sun/io/ByteToCharTIS620.java - src/share/classes/sun/io/ByteToCharUTF16.java - src/share/classes/sun/io/ByteToCharUTF8.java - src/share/classes/sun/io/ByteToCharUnicode.java - src/share/classes/sun/io/ByteToCharUnicodeBig.java - src/share/classes/sun/io/ByteToCharUnicodeBigUnmarked.java - src/share/classes/sun/io/ByteToCharUnicodeLittle.java - src/share/classes/sun/io/ByteToCharUnicodeLittleUnmarked.java - src/share/classes/sun/io/CharToByteASCII.java - src/share/classes/sun/io/CharToByteBig5.java - src/share/classes/sun/io/CharToByteBig5_HKSCS.java - src/share/classes/sun/io/CharToByteBig5_Solaris.java - src/share/classes/sun/io/CharToByteConverter.java - src/share/classes/sun/io/CharToByteCp037.java - src/share/classes/sun/io/CharToByteCp1006.java - src/share/classes/sun/io/CharToByteCp1025.java - src/share/classes/sun/io/CharToByteCp1026.java - src/share/classes/sun/io/CharToByteCp1046.java - src/share/classes/sun/io/CharToByteCp1047.java - src/share/classes/sun/io/CharToByteCp1097.java - src/share/classes/sun/io/CharToByteCp1098.java - src/share/classes/sun/io/CharToByteCp1112.java - src/share/classes/sun/io/CharToByteCp1122.java - src/share/classes/sun/io/CharToByteCp1123.java - src/share/classes/sun/io/CharToByteCp1124.java - src/share/classes/sun/io/CharToByteCp1140.java - src/share/classes/sun/io/CharToByteCp1141.java - src/share/classes/sun/io/CharToByteCp1142.java - src/share/classes/sun/io/CharToByteCp1143.java - src/share/classes/sun/io/CharToByteCp1144.java - src/share/classes/sun/io/CharToByteCp1145.java - src/share/classes/sun/io/CharToByteCp1146.java - src/share/classes/sun/io/CharToByteCp1147.java - src/share/classes/sun/io/CharToByteCp1148.java - src/share/classes/sun/io/CharToByteCp1149.java - src/share/classes/sun/io/CharToByteCp1250.java - src/share/classes/sun/io/CharToByteCp1251.java - src/share/classes/sun/io/CharToByteCp1252.java - src/share/classes/sun/io/CharToByteCp1253.java - src/share/classes/sun/io/CharToByteCp1254.java - src/share/classes/sun/io/CharToByteCp1255.java - src/share/classes/sun/io/CharToByteCp1256.java - src/share/classes/sun/io/CharToByteCp1257.java - src/share/classes/sun/io/CharToByteCp1258.java - src/share/classes/sun/io/CharToByteCp1381.java - src/share/classes/sun/io/CharToByteCp1383.java - src/share/classes/sun/io/CharToByteCp273.java - src/share/classes/sun/io/CharToByteCp277.java - src/share/classes/sun/io/CharToByteCp278.java - src/share/classes/sun/io/CharToByteCp280.java - src/share/classes/sun/io/CharToByteCp284.java - src/share/classes/sun/io/CharToByteCp285.java - src/share/classes/sun/io/CharToByteCp297.java - src/share/classes/sun/io/CharToByteCp33722.java - src/share/classes/sun/io/CharToByteCp420.java - src/share/classes/sun/io/CharToByteCp424.java - src/share/classes/sun/io/CharToByteCp437.java - src/share/classes/sun/io/CharToByteCp500.java - src/share/classes/sun/io/CharToByteCp737.java - src/share/classes/sun/io/CharToByteCp775.java - src/share/classes/sun/io/CharToByteCp833.java - src/share/classes/sun/io/CharToByteCp834.java - src/share/classes/sun/io/CharToByteCp838.java - src/share/classes/sun/io/CharToByteCp850.java - src/share/classes/sun/io/CharToByteCp852.java - src/share/classes/sun/io/CharToByteCp855.java - src/share/classes/sun/io/CharToByteCp856.java - src/share/classes/sun/io/CharToByteCp857.java - src/share/classes/sun/io/CharToByteCp858.java - src/share/classes/sun/io/CharToByteCp860.java - src/share/classes/sun/io/CharToByteCp861.java - src/share/classes/sun/io/CharToByteCp862.java - src/share/classes/sun/io/CharToByteCp863.java - src/share/classes/sun/io/CharToByteCp864.java - src/share/classes/sun/io/CharToByteCp865.java - src/share/classes/sun/io/CharToByteCp866.java - src/share/classes/sun/io/CharToByteCp868.java - src/share/classes/sun/io/CharToByteCp869.java - src/share/classes/sun/io/CharToByteCp870.java - src/share/classes/sun/io/CharToByteCp871.java - src/share/classes/sun/io/CharToByteCp874.java - src/share/classes/sun/io/CharToByteCp875.java - src/share/classes/sun/io/CharToByteCp918.java - src/share/classes/sun/io/CharToByteCp921.java - src/share/classes/sun/io/CharToByteCp922.java - src/share/classes/sun/io/CharToByteCp930.java - src/share/classes/sun/io/CharToByteCp933.java - src/share/classes/sun/io/CharToByteCp935.java - src/share/classes/sun/io/CharToByteCp937.java - src/share/classes/sun/io/CharToByteCp939.java - src/share/classes/sun/io/CharToByteCp942.java - src/share/classes/sun/io/CharToByteCp942C.java - src/share/classes/sun/io/CharToByteCp943.java - src/share/classes/sun/io/CharToByteCp943C.java - src/share/classes/sun/io/CharToByteCp948.java - src/share/classes/sun/io/CharToByteCp949.java - src/share/classes/sun/io/CharToByteCp949C.java - src/share/classes/sun/io/CharToByteCp950.java - src/share/classes/sun/io/CharToByteCp964.java - src/share/classes/sun/io/CharToByteCp970.java - src/share/classes/sun/io/CharToByteDBCS_ASCII.java - src/share/classes/sun/io/CharToByteDBCS_EBCDIC.java - src/share/classes/sun/io/CharToByteDoubleByte.java - src/share/classes/sun/io/CharToByteEUC.java - src/share/classes/sun/io/CharToByteEUC_CN.java - src/share/classes/sun/io/CharToByteEUC_JP.java - src/share/classes/sun/io/CharToByteEUC_JP_LINUX.java - src/share/classes/sun/io/CharToByteEUC_JP_Solaris.java - src/share/classes/sun/io/CharToByteEUC_KR.java - src/share/classes/sun/io/CharToByteEUC_TW.java - src/share/classes/sun/io/CharToByteGB18030.java - src/share/classes/sun/io/CharToByteGBK.java - src/share/classes/sun/io/CharToByteISCII91.java - src/share/classes/sun/io/CharToByteISO2022.java - src/share/classes/sun/io/CharToByteISO2022CN_CNS.java - src/share/classes/sun/io/CharToByteISO2022CN_GB.java - src/share/classes/sun/io/CharToByteISO2022JP.java - src/share/classes/sun/io/CharToByteISO2022KR.java - src/share/classes/sun/io/CharToByteISO8859_1.java - src/share/classes/sun/io/CharToByteISO8859_13.java - src/share/classes/sun/io/CharToByteISO8859_15.java - src/share/classes/sun/io/CharToByteISO8859_2.java - src/share/classes/sun/io/CharToByteISO8859_3.java - src/share/classes/sun/io/CharToByteISO8859_4.java - src/share/classes/sun/io/CharToByteISO8859_5.java - src/share/classes/sun/io/CharToByteISO8859_6.java - src/share/classes/sun/io/CharToByteISO8859_7.java - src/share/classes/sun/io/CharToByteISO8859_8.java - src/share/classes/sun/io/CharToByteISO8859_9.java - src/share/classes/sun/io/CharToByteJIS0201.java - src/share/classes/sun/io/CharToByteJIS0208.java - src/share/classes/sun/io/CharToByteJIS0208_Solaris.java - src/share/classes/sun/io/CharToByteJIS0212.java - src/share/classes/sun/io/CharToByteJIS0212_Solaris.java - src/share/classes/sun/io/CharToByteJohab.java - src/share/classes/sun/io/CharToByteKOI8_R.java - src/share/classes/sun/io/CharToByteMS874.java - src/share/classes/sun/io/CharToByteMS932.java - src/share/classes/sun/io/CharToByteMS936.java - src/share/classes/sun/io/CharToByteMS949.java - src/share/classes/sun/io/CharToByteMS950.java - src/share/classes/sun/io/CharToByteMS950_HKSCS.java - src/share/classes/sun/io/CharToByteMacArabic.java - src/share/classes/sun/io/CharToByteMacCentralEurope.java - src/share/classes/sun/io/CharToByteMacCroatian.java - src/share/classes/sun/io/CharToByteMacCyrillic.java - src/share/classes/sun/io/CharToByteMacDingbat.java - src/share/classes/sun/io/CharToByteMacGreek.java - src/share/classes/sun/io/CharToByteMacHebrew.java - src/share/classes/sun/io/CharToByteMacIceland.java - src/share/classes/sun/io/CharToByteMacRoman.java - src/share/classes/sun/io/CharToByteMacRomania.java - src/share/classes/sun/io/CharToByteMacSymbol.java - src/share/classes/sun/io/CharToByteMacThai.java - src/share/classes/sun/io/CharToByteMacTurkish.java - src/share/classes/sun/io/CharToByteMacUkraine.java - src/share/classes/sun/io/CharToBytePCK.java - src/share/classes/sun/io/CharToByteSJIS.java - src/share/classes/sun/io/CharToByteSingleByte.java - src/share/classes/sun/io/CharToByteTIS620.java - src/share/classes/sun/io/CharToByteUTF16.java - src/share/classes/sun/io/CharToByteUTF8.java - src/share/classes/sun/io/CharToByteUnicode.java - src/share/classes/sun/io/CharToByteUnicodeBig.java - src/share/classes/sun/io/CharToByteUnicodeBigUnmarked.java - src/share/classes/sun/io/CharToByteUnicodeLittle.java - src/share/classes/sun/io/CharToByteUnicodeLittleUnmarked.java - src/share/classes/sun/io/CharacterEncoding.java - src/share/classes/sun/io/ConversionBufferFullException.java - src/share/classes/sun/io/Converters.java - src/share/classes/sun/io/MalformedInputException.java - src/share/classes/sun/io/UnknownCharacterException.java - src/share/classes/sun/nio/ch/SctpMessageInfoImpl.java - src/share/classes/sun/nio/ch/SctpStdSocketOption.java - src/share/classes/sun/security/pkcs/EncodingException.java - src/share/classes/sun/security/pkcs/PKCS10.java - src/share/classes/sun/security/pkcs/PKCS10Attribute.java - src/share/classes/sun/security/pkcs/PKCS10Attributes.java - src/share/classes/sun/security/util/BigInt.java - src/share/classes/sun/security/util/PathList.java ! src/share/classes/sun/security/x509/CRLExtensions.java - src/share/classes/sun/security/x509/CertAndKeyGen.java ! src/share/classes/sun/security/x509/CertificateExtensions.java ! src/share/classes/sun/security/x509/X509CRLEntryImpl.java ! src/share/classes/sun/security/x509/X509CRLImpl.java ! src/share/classes/sun/security/x509/X509CertImpl.java - src/share/classes/sun/tools/jar/JarImageSource.java ! src/share/lib/security/java.security-solaris - src/share/native/java/lang/fdlibm/src/e_acosh.c - src/share/native/java/lang/fdlibm/src/e_gamma.c - src/share/native/java/lang/fdlibm/src/e_gamma_r.c - src/share/native/java/lang/fdlibm/src/e_j0.c - src/share/native/java/lang/fdlibm/src/e_j1.c - src/share/native/java/lang/fdlibm/src/e_jn.c - src/share/native/java/lang/fdlibm/src/e_lgamma.c - src/share/native/java/lang/fdlibm/src/e_lgamma_r.c - src/share/native/java/lang/fdlibm/src/s_asinh.c - src/share/native/java/lang/fdlibm/src/s_erf.c - src/share/native/java/lang/fdlibm/src/w_acosh.c - src/share/native/java/lang/fdlibm/src/w_gamma.c - src/share/native/java/lang/fdlibm/src/w_gamma_r.c - src/share/native/java/lang/fdlibm/src/w_j0.c - src/share/native/java/lang/fdlibm/src/w_j1.c - src/share/native/java/lang/fdlibm/src/w_jn.c - src/share/native/java/lang/fdlibm/src/w_lgamma.c - src/share/native/java/lang/fdlibm/src/w_lgamma_r.c - src/share/native/java/util/zip/zlib-1.2.3/ChangeLog - src/share/native/java/util/zip/zlib-1.2.3/README - src/share/native/java/util/zip/zlib-1.2.3/compress.c - src/share/native/java/util/zip/zlib-1.2.3/crc32.h - src/share/native/java/util/zip/zlib-1.2.3/deflate.c - src/share/native/java/util/zip/zlib-1.2.3/deflate.h - src/share/native/java/util/zip/zlib-1.2.3/gzio.c - src/share/native/java/util/zip/zlib-1.2.3/infback.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.h - src/share/native/java/util/zip/zlib-1.2.3/inffixed.h - src/share/native/java/util/zip/zlib-1.2.3/inflate.c - src/share/native/java/util/zip/zlib-1.2.3/inflate.h - src/share/native/java/util/zip/zlib-1.2.3/inftrees.c - src/share/native/java/util/zip/zlib-1.2.3/inftrees.h - src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog_java - src/share/native/java/util/zip/zlib-1.2.3/patches/crc32.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/inflate.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zconf.h.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zlib.h.diff - src/share/native/java/util/zip/zlib-1.2.3/trees.c - src/share/native/java/util/zip/zlib-1.2.3/trees.h - src/share/native/java/util/zip/zlib-1.2.3/uncompr.c - src/share/native/java/util/zip/zlib-1.2.3/zadler32.c - src/share/native/java/util/zip/zlib-1.2.3/zconf.h - src/share/native/java/util/zip/zlib-1.2.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.2.3/zlib.h - src/share/native/java/util/zip/zlib-1.2.3/zutil.c - src/share/native/java/util/zip/zlib-1.2.3/zutil.h - src/share/native/sun/awt/libpng/pnggccrd.c - src/share/native/sun/awt/libpng/pngvcrd.c - src/share/native/sun/rmi/server/MarshalInputStream.c - src/solaris/classes/sun/awt/motif/AWTLockAccess.java - src/solaris/classes/sun/awt/motif/MFontPeer.java - src/solaris/classes/sun/awt/motif/MToolkit.java - src/solaris/classes/sun/awt/motif/MToolkitThreadBlockedHandler.java - src/solaris/classes/sun/awt/motif/MWindowAttributes.java - src/solaris/classes/sun/awt/motif/X11FontMetrics.java - src/solaris/classes/sun/nio/ch/SctpAssocChange.java - src/solaris/classes/sun/nio/ch/SctpAssociationImpl.java - src/solaris/classes/sun/nio/ch/SctpChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpNet.java - src/solaris/classes/sun/nio/ch/SctpNotification.java - src/solaris/classes/sun/nio/ch/SctpPeerAddrChange.java - src/solaris/classes/sun/nio/ch/SctpResultContainer.java - src/solaris/classes/sun/nio/ch/SctpSendFailed.java - src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpShutdown.java - src/solaris/doc/sun/man/man1/apt.1 - src/solaris/doc/sun/man/man1/ja/apt.1 - src/solaris/native/sun/awt/MouseInfo.c - src/solaris/native/sun/awt/XDrawingArea.c - src/solaris/native/sun/awt/XDrawingArea.h - src/solaris/native/sun/awt/XDrawingAreaP.h - src/solaris/native/sun/awt/awt_Cursor.h - src/solaris/native/sun/awt/awt_KeyboardFocusManager.h - src/solaris/native/sun/awt/awt_MToolkit.c - src/solaris/native/sun/awt/awt_MToolkit.h - src/solaris/native/sun/awt/awt_MenuItem.h - src/solaris/native/sun/awt/awt_PopupMenu.h - src/solaris/native/sun/awt/awt_TopLevel.h - src/solaris/native/sun/awt/awt_Window.h - src/solaris/native/sun/awt/awt_mgrsel.c - src/solaris/native/sun/awt/awt_mgrsel.h - src/solaris/native/sun/awt/awt_motif.h - src/solaris/native/sun/awt/awt_wm.c - src/solaris/native/sun/awt/awt_wm.h - src/solaris/native/sun/awt/awt_xembed.h - src/solaris/native/sun/awt/awt_xembed_server.c - src/solaris/native/sun/awt/awt_xembed_server.h - src/solaris/native/sun/nio/ch/Sctp.h - src/solaris/native/sun/nio/ch/SctpChannelImpl.c - src/solaris/native/sun/nio/ch/SctpNet.c - src/solaris/native/sun/nio/ch/SctpServerChannelImpl.c - src/windows/classes/sun/nio/ch/SctpChannelImpl.java - src/windows/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/windows/classes/sun/nio/ch/SctpServerChannelImpl.java - test/java/io/File/BlockIsDirectory.java - test/java/io/File/isDirectory/Applet.html - test/java/io/File/isDirectory/Applet.java - test/java/io/FileDescriptor/FileChannelFDTest.java - test/java/util/ResourceBundle/Control/ExpirationTest.java - test/java/util/ResourceBundle/Control/ExpirationTest.sh - test/sun/nio/cs/OLD/TestX11CS.java - test/sun/nio/cs/TestISCII91.java - test/sun/security/util/BigInt/BigIntEqualsHashCode.java - test/tools/launcher/ChangeDataModel.sh - test/tools/launcher/CreatePlatformFile.java - test/tools/launcher/DefaultLocaleTest.sh - test/tools/launcher/SomeException.java - test/tools/launcher/UnicodeCleanup.java - test/tools/launcher/UnicodeTest.sh - test/tools/launcher/deleteI18n.sh - test/tools/launcher/i18nTest.sh - test/tools/launcher/unresolvedExceptions.sh Changeset: 95998c60ab4b Author: robm Date: 2012-04-11 17:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/95998c60ab4b 7143606: File.createTempFile should be improved for temporary files created by the platform. Reviewed-by: sherman ! src/macosx/classes/apple/applescript/AppleScriptEngine.java ! src/share/classes/com/sun/java/util/jar/pack/Driver.java ! src/share/classes/java/awt/Font.java ! src/share/classes/javax/imageio/stream/FileCacheImageInputStream.java ! src/share/classes/javax/imageio/stream/FileCacheImageOutputStream.java ! src/share/classes/javax/management/loading/MLet.java ! src/share/classes/sun/print/PSPrinterJob.java ! src/share/classes/sun/rmi/server/Activation.java ! src/share/classes/sun/tools/jar/Main.java ! src/share/classes/sun/tools/native2ascii/Main.java ! src/solaris/classes/sun/font/FcFontConfiguration.java ! src/solaris/classes/sun/print/UnixPrintJob.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java Changeset: afe424ee3240 Author: asaha Date: 2012-05-08 07:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/afe424ee3240 Merge ! src/share/lib/security/java.security ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows - test/sun/security/pkcs11/nss/lib/linux-amd64/libfreebl3.chk - test/sun/security/pkcs11/nss/lib/linux-amd64/libfreebl3.so - test/sun/security/pkcs11/nss/lib/linux-amd64/libnspr4.so - test/sun/security/pkcs11/nss/lib/linux-amd64/libnss3.so - test/sun/security/pkcs11/nss/lib/linux-amd64/libnssckbi.so - test/sun/security/pkcs11/nss/lib/linux-amd64/libplc4.so - test/sun/security/pkcs11/nss/lib/linux-amd64/libplds4.so - test/sun/security/pkcs11/nss/lib/linux-amd64/libsoftokn3.chk - test/sun/security/pkcs11/nss/lib/linux-amd64/libsoftokn3.so - test/sun/security/pkcs11/nss/lib/linux-i586/libnspr4.so - test/sun/security/pkcs11/nss/lib/linux-i586/libnss3.so - test/sun/security/pkcs11/nss/lib/linux-i586/libnssckbi.so - test/sun/security/pkcs11/nss/lib/linux-i586/libplc4.so - test/sun/security/pkcs11/nss/lib/linux-i586/libplds4.so - test/sun/security/pkcs11/nss/lib/linux-i586/libsoftokn3.so - test/sun/security/pkcs11/nss/lib/solaris-amd64/libnspr4.so - test/sun/security/pkcs11/nss/lib/solaris-amd64/libnss3.so - test/sun/security/pkcs11/nss/lib/solaris-amd64/libnssckbi.so - test/sun/security/pkcs11/nss/lib/solaris-amd64/libplc4.so - test/sun/security/pkcs11/nss/lib/solaris-amd64/libplds4.so - test/sun/security/pkcs11/nss/lib/solaris-amd64/libsoftokn3.so - test/sun/security/pkcs11/nss/lib/solaris-i586/libfreebl3.so - test/sun/security/pkcs11/nss/lib/solaris-i586/libnspr4.so - test/sun/security/pkcs11/nss/lib/solaris-i586/libnss3.so - test/sun/security/pkcs11/nss/lib/solaris-i586/libnssckbi.so - test/sun/security/pkcs11/nss/lib/solaris-i586/libplc4.so - test/sun/security/pkcs11/nss/lib/solaris-i586/libplds4.so - test/sun/security/pkcs11/nss/lib/solaris-i586/libsoftokn3.so - test/sun/security/pkcs11/nss/lib/solaris-sparc/libfreebl_hybrid_3.chk - test/sun/security/pkcs11/nss/lib/solaris-sparc/libfreebl_hybrid_3.so - test/sun/security/pkcs11/nss/lib/solaris-sparc/libnspr4.so - test/sun/security/pkcs11/nss/lib/solaris-sparc/libnss3.so - test/sun/security/pkcs11/nss/lib/solaris-sparc/libnssckbi.so - test/sun/security/pkcs11/nss/lib/solaris-sparc/libplc4.so - test/sun/security/pkcs11/nss/lib/solaris-sparc/libplds4.so - test/sun/security/pkcs11/nss/lib/solaris-sparc/libsoftokn3.chk - test/sun/security/pkcs11/nss/lib/solaris-sparc/libsoftokn3.so - test/sun/security/pkcs11/nss/lib/solaris-sparcv9/libnspr4.so - test/sun/security/pkcs11/nss/lib/solaris-sparcv9/libnss3.so - test/sun/security/pkcs11/nss/lib/solaris-sparcv9/libnssckbi.so - test/sun/security/pkcs11/nss/lib/solaris-sparcv9/libplc4.so - test/sun/security/pkcs11/nss/lib/solaris-sparcv9/libplds4.so - test/sun/security/pkcs11/nss/lib/solaris-sparcv9/libsoftokn3.so - test/sun/security/pkcs11/nss/lib/windows-i586/libnspr4.dll - test/sun/security/pkcs11/nss/lib/windows-i586/libplc4.dll - test/sun/security/pkcs11/nss/lib/windows-i586/libplds4.dll - test/sun/security/pkcs11/nss/lib/windows-i586/nss3.dll - test/sun/security/pkcs11/nss/lib/windows-i586/nssckbi.dll - test/sun/security/pkcs11/nss/lib/windows-i586/softokn3.dll Changeset: 3a2cfce96908 Author: coffeys Date: 2012-05-17 12:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3a2cfce96908 7123896: Unexpected behavior due to Solaris using separate IPv4 and IPv6 port spaces Reviewed-by: alanb ! src/share/native/java/net/net_util.c ! src/share/native/java/net/net_util.h ! src/solaris/native/java/net/net_util_md.c ! src/windows/native/java/net/net_util_md.c ! test/java/net/Socket/setReuseAddress/Basic.java ! test/java/net/Socket/setReuseAddress/Restart.java Changeset: cf097cda2733 Author: jrose Date: 2012-05-18 20:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf097cda2733 7165628: Issues with java.lang.invoke.MethodHandles.Lookup Summary: Base SecurityManager checks on either of Lookup.lookupClass or caller class; also clarify Lookup access checks. Reviewed-by: twisti ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/sun/invoke/util/VerifyAccess.java + test/java/lang/invoke/AccessControlTest.java + test/java/lang/invoke/AccessControlTest_subpkg/Acquaintance_remote.java Changeset: 36d899822de7 Author: asaha Date: 2012-05-21 15:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/36d899822de7 Merge - src/macosx/bin/amd64/jvm.cfg ! src/share/classes/sun/print/PSPrinterJob.java - src/share/classes/sun/security/action/LoadLibraryAction.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java ! src/solaris/native/java/net/net_util_md.c - test/tools/pack200/dyn.jar - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java Changeset: 4c403c00fdf1 Author: asaha Date: 2012-05-24 10:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4c403c00fdf1 7171228: closed/java/lang/SecurityManager/CheckPackageDefinition.java failure Reviewed-by: mullan ! src/share/lib/security/java.security ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows Changeset: 2fbf98031e65 Author: asaha Date: 2012-06-07 12:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2fbf98031e65 Merge ! src/share/native/java/net/net_util.h ! src/solaris/native/java/net/net_util_md.c Changeset: b92353a01aa0 Author: lana Date: 2012-06-26 10:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b92353a01aa0 Merge ! src/share/classes/sun/security/x509/X509CRLEntryImpl.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java ! src/solaris/native/java/net/net_util_md.c Changeset: 7e9a7400329b Author: lana Date: 2012-06-26 22:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7e9a7400329b Merge Changeset: 2bba577b8ab8 Author: lana Date: 2012-06-27 00:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2bba577b8ab8 Merge From xuelei.fan at oracle.com Wed Jun 27 09:12:25 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Thu, 28 Jun 2012 00:12:25 +0800 Subject: Proposed API Changes for JEP 114: TLS Server Name Indication (SNI) Extension Message-ID: <4FEB30E9.9060903@oracle.com> Hi, As part of JEP 114[1], I have been working on a few API changes for JDK 8 to support TLS server name indication in server side. I have posted a README and the webrev for the specification for review: http://cr.openjdk.java.net./~xuelei/7068321/README http://cr.openjdk.java.net./~xuelei/7068321/webrev_spec.00/ The README gives some behavior changes of Oracle provider related to this JEP, and a couple of examples about how to use the new APIs to support virtual hosting mechanisms. Please review the API changes and send any comments to the list. I would prefer to get any comments by the end of next Monday (July 2th), if possible. Thanks, Xuelei [1]: http://openjdk.java.net/jeps/114 From sean.coffey at oracle.com Wed Jun 27 13:08:15 2012 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Wed, 27 Jun 2012 20:08:15 +0000 Subject: hg: jdk8/tl/corba: 7162902: Umbrella port of a number of corba bug fixes from JDK 6 to jdk7u/8 Message-ID: <20120627200816.B4E2147B5C@hg.openjdk.java.net> Changeset: 47adb42076f1 Author: coffeys Date: 2012-06-27 21:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/47adb42076f1 7162902: Umbrella port of a number of corba bug fixes from JDK 6 to jdk7u/8 Reviewed-by: lancea ! src/share/classes/com/sun/corba/se/impl/encoding/CachedCodeBase.java ! src/share/classes/com/sun/corba/se/impl/interceptors/PIHandlerImpl.java ! src/share/classes/com/sun/corba/se/impl/interceptors/PINoOpHandlerImpl.java ! src/share/classes/com/sun/corba/se/impl/monitoring/MonitoringManagerFactoryImpl.java ! src/share/classes/com/sun/corba/se/impl/monitoring/MonitoringManagerImpl.java ! src/share/classes/com/sun/corba/se/impl/orb/ORBImpl.java ! src/share/classes/com/sun/corba/se/impl/orbutil/threadpool/ThreadPoolImpl.java ! src/share/classes/com/sun/corba/se/impl/orbutil/threadpool/ThreadPoolManagerImpl.java ! src/share/classes/com/sun/corba/se/impl/orbutil/threadpool/WorkQueueImpl.java ! src/share/classes/com/sun/corba/se/impl/protocol/CorbaMessageMediatorImpl.java ! src/share/classes/com/sun/corba/se/impl/transport/SelectorImpl.java ! src/share/classes/com/sun/corba/se/spi/logging/data/ORBUtil.mc ! src/share/classes/com/sun/corba/se/spi/monitoring/MonitoringManager.java ! src/share/classes/com/sun/corba/se/spi/monitoring/MonitoringManagerFactory.java ! src/share/classes/com/sun/corba/se/spi/orb/ORB.java ! src/share/classes/com/sun/corba/se/spi/orbutil/threadpool/ThreadPool.java ! src/share/classes/com/sun/corba/se/spi/orbutil/threadpool/ThreadPoolManager.java ! src/share/classes/com/sun/corba/se/spi/protocol/PIHandler.java ! src/share/classes/com/sun/corba/se/spi/protocol/RequestDispatcherRegistry.java From sean.coffey at oracle.com Wed Jun 27 13:08:10 2012 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Wed, 27 Jun 2012 20:08:10 +0000 Subject: hg: jdk8/tl/jdk: 6893617: JDK 6 CNCtx always uses the default ORB Message-ID: <20120627200849.9396647B5D@hg.openjdk.java.net> Changeset: 612e56cf284c Author: coffeys Date: 2012-06-27 21:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/612e56cf284c 6893617: JDK 6 CNCtx always uses the default ORB Reviewed-by: lancea ! src/share/classes/com/sun/jndi/cosnaming/CNCtx.java From dan.xu at oracle.com Thu Jun 28 13:49:32 2012 From: dan.xu at oracle.com (Dan Xu) Date: Thu, 28 Jun 2012 13:49:32 -0700 Subject: Please Review Test Fix of Bug 7177045 Message-ID: <4FECC35C.10105@oracle.com> Security code reviewers, I have fixed a security test failure and posted my changes at http://cr.openjdk.java.net/~dxu/7177045/. Please help review it. Thanks! -Dan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20120628/2ad80114/attachment.html From bradford.wetmore at oracle.com Thu Jun 28 17:30:34 2012 From: bradford.wetmore at oracle.com (Brad Wetmore) Date: Thu, 28 Jun 2012 17:30:34 -0700 Subject: Please Review Test Fix of Bug 7177045 In-Reply-To: <4FECC35C.10105@oracle.com> References: <4FECC35C.10105@oracle.com> Message-ID: <4FECF72A.6090102@oracle.com> Dan, congrats on assembling and posting your first webrev. Besides the big picture things, since you are new, I'll also be looking for minor things that you may or may not know yet. On 6/28/2012 1:49 PM, Dan Xu wrote: > Security code reviewers, > > I have fixed a security test failure and posted my changes at > http://cr.openjdk.java.net/~dxu/7177045/. Please help review it. Thanks! Minor nit: line 38 has a space at the end of the line. Current jstyle guidelines state no indention with tabs and no whitespace at the end of the lines. Lines 61/89: memroy->memory Just wondering why you chose a Deque instead of a simpler LinkedList? Suggest more liberal use of comments, either in the method's comments or inline. Good to explain your assumptions/approach in case things aren't obvious. For example, why do you backoff 3MB after allocating available memory? And at line 134: the operation could either time out or threw an exception. Nice to make that clear. dummyData could be a local variable. Line 64/113: consider using the JDK 7 diamond <> operator on your generics. Line 114: consider adding a @overrides annotation on the call() method. Line 139: I'm being paranoid here, but shutdownNow doesn't guarantee threads will be stopped. If we actually got into a situation where there was a timeout, executor.shutdownNow() *may* never return. One reason is it might be hanging somewhere waiting for memory. I would suggest as part of your finally block, you dequeue all the memory in dummyData, call System.gc(), then run executor.shutdownNow(). JTREG will timeout after two minutes, but if we can proactively help the situation, we might as well. Otherwise, looks good. We'll wait to see if anyone has other thoughts, and if not, we'll push when you're back from vacation. Brad From xueming.shen at oracle.com Thu Jun 28 22:50:06 2012 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Fri, 29 Jun 2012 05:50:06 +0000 Subject: hg: jdk8/tl/jdk: 7175845: jar uf changes file permissions unexpectedly; ... Message-ID: <20120629055025.E625C47BBE@hg.openjdk.java.net> Changeset: 819258b5002e Author: sherman Date: 2012-06-28 22:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/819258b5002e 7175845: jar uf changes file permissions unexpectedly 7177216: native2ascii changes file permissions of input file Summary: undo the File.createTempFile change in jar and native2ascii Reviewed-by: asaha ! src/share/classes/sun/tools/jar/Main.java ! src/share/classes/sun/tools/native2ascii/Main.java + test/sun/tools/native2ascii/Permission.java + test/tools/jar/UpdateJar.java From mike.duigou at oracle.com Fri Jun 29 15:45:25 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Fri, 29 Jun 2012 22:45:25 +0000 Subject: hg: jdk8/tl/jdk: 7100996: (spec str) IndexOutOfBoundsException when using a StringBuffer from multiple threads Message-ID: <20120629224601.4E0A947C00@hg.openjdk.java.net> Changeset: 9e15068b6946 Author: jgish Date: 2012-06-29 15:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9e15068b6946 7100996: (spec str) IndexOutOfBoundsException when using a StringBuffer from multiple threads Summary: add usage note to clarify thread safety Reviewed-by: briangoetz, mduigou Contributed-by: jim.gish at oracle.com ! src/share/classes/java/lang/StringBuffer.java From stuart.marks at oracle.com Fri Jun 29 16:28:15 2012 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Fri, 29 Jun 2012 23:28:15 +0000 Subject: hg: jdk8/tl/jdk: 7170938: (str) incorrect wording in doc for String.subSequence Message-ID: <20120629232837.1AE5247C03@hg.openjdk.java.net> Changeset: 9df29b658145 Author: smarks Date: 2012-06-29 16:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9df29b658145 7170938: (str) incorrect wording in doc for String.subSequence Reviewed-by: forax, mduigou Contributed-by: Joe Bowbeer ! src/share/classes/java/lang/String.java