simple code review request: 8001596

Brad Wetmore bradford.wetmore at oracle.com
Thu Mar 28 14:40:51 PDT 2013


Just realized, there are no regression tests here.

Simplest is to probably do as much setup as you can, then 
java.security.Security.removeProvider("SunJCE"), then issue the calls 
that call into these changes.  They should all pass in the new version, 
and fail in the old.

Brad



On 3/28/2013 2:29 PM, Anthony Scarpino wrote:
> Hi all,
>
> I have a very simple code review request.  It's a typo bug.
>
> 8001596 Incorrect condition check in PBKDF2KeyImpl.JAVA
> https://jbs.oracle.com/bugs/browse/JDK-8001596
>
> http://cr.openjdk.java.net/~mullan/webrevs/ascarpin/8001596/webrev.01/
>
> thanks
>
> Tony


More information about the security-dev mailing list