RFR 8061253: CCC 8043071 doesn't fully approve the change in JDK9b25

[Wang Weijun]

> On Nov 19, 2014, at 22:10, Sean Mullan <sean.mullan at oracle.com> wrote:
> 
> On 11/18/2014 02:47 AM, Wang Weijun wrote:
>> Re-request for code review at
>> 
>> http://cr.openjdk.java.net/~weijun/8061253/webrev.01/
> 
> * Principal:
> 
> This should also be included in the @implSpec, is it? You might need another implSpec tag before this, or remove the <p> as it isn't really necessary.
> 
> <p>Subclasses may override this with a different implementation, if
> necessary.

Looks like one is enough.


> 
> * General
> 
> Sometimes you say "the Foo" and other times you say "this Foo". I think you should try to be consistent. I prefer "this Foo".

OK, I'll go through it.

Thanks
Max

> 
> --Sean
> 
>> 
>> Most are still spec changes, with only one code change in
>> KerberosTicket.java where KerberosPrincipal.toString() is changed to
>> KerberosPrincipal.getName(). This is also because the spec for
>> getName() is more suitable in this call.
>> 
>> *Jamil*: I usually don't touch copyright years and let RE handle it.
>> You might say this is not a good habit.
>> 
>> Thanks Max
>> 
>>> On Nov 15, 2014, at 08:05, Wang Weijun <weijun.wang at oracle.com>
>>> wrote:
>>> 
>>> Webrev withdrawn. I'd like to make more changes.
>>> 
>>> Thanks Max
>>> 
>>>> On Nov 14, 2014, at 10:38, Wang Weijun <weijun.wang at oracle.com>
>>>> wrote:
>>>> 
>>>> Hi All
>>>> 
>>>> This is a doc change only bug. Fix at
>>>> 
>>>> http://cr.openjdk.java.net/~weijun/8061253/webrev.00/
>>>> 
>>>> Please take a review.
>>>> 
>>>> Thanks Max
>>>> 
>>> 
>> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/security-dev/attachments/20141119/8196dfaa/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screen Shot 2014-11-19 at 22.25.34.png
Type: image/png
Size: 64840 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/security-dev/attachments/20141119/8196dfaa/ScreenShot2014-11-19at22.25.34-0001.png>