Code Review Request 8143298 Test ReadTimeout.java fails intermittently

Wang Weijun weijun.wang at oracle.com
Wed Dec 2 03:04:40 UTC 2015


Everything looks fine now.

Thanks
Max

> On Dec 2, 2015, at 10:48 AM, Xuelei Fan <xuelei.fan at oracle.com> wrote:
> 
> On 12/2/2015 10:20 AM, Wang Weijun wrote:
>> 
>>> On Dec 2, 2015, at 9:12 AM, Xuelei Fan <xuelei.fan at oracle.com> wrote:
>>> 
>>> On 12/2/2015 9:05 AM, Wang Weijun wrote:
>>>> Socket is a Closeable, so you can 
>>>> 
>>>> try (Socket sock = ....) { ... }
>>>> 
>>> Yes.  Better coding.  Updated in the same webrev.
>> 
>> Same sslSocket declared twice. Have you compiled the test?
>> 
> Updated.
> 
>> You can also do the same with sslServerSocket if you like.
>> 
> I'll leave it as it is.
> 
> Thanks,
> Xuelei



More information about the security-dev mailing list