Code Review Request 8149017 Delayed provider selection broken inRSA client key exchange

[Seán Coffey]

Looks ok to me Xuelei - tricky one to test, we should ensure some 3rd 
party interoperability testing is run.
Would it make sense to append to the exception message to the debug 
message on line 135 ? i.e.
> 132 if (debug != null && Debug.isOn("handshake")) {
> 133 System.out.println("The Cipher provider " +
> 134 cipher.getProvider().getName() +
> 135 " caused exception : " + iue.getMessage());
> 136 }

Regards,
Sean.

On 15/03/2016 10:34, Xuelei Fan wrote:
> On 3/15/2016 6:29 PM, Bernd Eckenfels wrote:
>>   
>>
>> BTW, the System.out is already in the existing code, but I wonder if
>> this should use Debug.println instead?
>>
> Better to use Debug.println().  I will make the update in an separate
> debug log improvement enhancement.
>
> Thanks,
> Xuelei
>
>>   
>>
>> Gruss
>>
>> Bernd
>> -- 
>> http://bernd.eckenfels.net
>>
>>   
>>
>> *Von: *Xuelei Fan <mailto:xuelei.fan at oracle.com>
>> *Gesendet: *Dienstag, 15. März 2016 11:02
>> *An: *OpenJDK <mailto:security-dev at openjdk.java.net>
>> *Betreff: *Re: Code Review Request 8149017 Delayed provider selection
>> broken inRSA client key exchange
>>
>>   
>>
>> Ping ...
>>
>>   
>>
>> On 3/10/2016 11:50 PM, Xuelei Fan wrote:
>>
>>> Hi,
>>> Please review this update:
>>>     http://cr.openjdk.java.net/~xuelei/8149017/webrev.00/
>>> The problem is that calling Cipher.getProvider, or any method on Cipher,
>>> forces the Cipher instance to skip the delayed provider selection which
>>> is built into Cipher.
>>> In this update, Cipher.init() was changed to be the first call to an
>>> instance of Cipher.
>>> Thanks,
>>> Xuelei
>>   
>>
>>   
>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/security-dev/attachments/20160323/e3414e5f/attachment.html>