RFR: [XS] 8215411: some GetByteArrayElements calls miss corresponding Release

Baesken, Matthias matthias.baesken at sap.com
Mon Dec 17 08:59:18 UTC 2018


Hello, please review the following change.
I noticed that we miss at some places (for example in case of early returns)
where GetByteArrayElements is used,  the corresponding ReleaseByteArrayElements  call.

In VirtualMachineImpl.c  I also removed a check for isCopy (is the returned byte array a copy ?)
because from what I read at

https://docs.oracle.com/javase/8/docs/technotes/guides/jni/spec/functions.html

the ReleaseByteArrayElements  routine should always be called.


bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8215411

http://cr.openjdk.java.net/~mbaesken/webrevs/8215411.0/


Thanks, Matthias
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/security-dev/attachments/20181217/3a8f6c88/attachment-0001.html>


More information about the security-dev mailing list