RFR: 8262438: sun/security/ssl/SSLLogger/LoggingFormatConsistency.java failed with "SocketException: Socket is closed" [v3]

[Daniel Fuchs]

On Thu, 4 Mar 2021 09:47:03 GMT, Evan Whelan <ewhelan at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review my test fix relating to JDK-8262438
>> 
>> This patch introduces as Thread.sleep at the start of each iteration which creates a new test jvm. 
>> This allows the server socket sufficient time to release the previous connection and allows the port to be used again.
>> 
>> I also refactored the behaviour for when the exitCode is not 0, allowing for an easier to read output.
>> An incorrect HttpsUrlConnection.disconnect() was also removed.
>> 
>> The test was ran 100 times on all platforms and no failures were seen. 
>> 
>> Thanks,
>> Evan
>
> Evan Whelan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8262438: Removed custom socket handling logic

I don't see any specific issue with what you are proposing from a networking perspective, but you will need someone from security-libs to review the proposed changes and acknowledge that the test is still testing what it intends to test.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2749