RFR: 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec
Ziyi Luo
luoziyi at openjdk.java.net
Thu Mar 11 20:00:23 UTC 2021
This is a P2 regression introduced by JDK-8254717.
In `RSAKeyFactory.engineGetKeySpec`, when the key is a RSA key and the KeySpec is RSAPrivateKeySpec or RSAPrivateCrtKeySpec. The method behavior is described as follow:
X-axis: type of `keySpec`
Y-axis: type of `key`
Before JDK-8254717:
| | RSAPrivateKeySpec.class | RSAPrivateCrtKeySpec.class |
|--|--|--|
| RSAPrivateKey | Return RSAPrivateKeySpec | Throw `InvalidKeySpecException` |
| RSAPrivateCrtKey | Return RSAPrivateKeySpec | Return RSAPrivateKeyCrtSpec |
After JDK-8254717 (Green check is what we want to fix, red cross is the regression):
| | RSAPrivateKeySpec.class | RSAPrivateCrtKeySpec.class |
|--|--|--|
| RSAPrivateKey | Throw `InvalidKeySpecException` ❌ | Throw `InvalidKeySpecException` |
| RSAPrivateCrtKey | Return RSAPrivateKeyCrtSpec ✅ | Return RSAPrivateKeyCrtSpec |
This commit fixes the regression.
### Tests
* Jtreg: All tests under `java/security`, `sun/security`, `javax/crypto` passed
* JCK: All JCK-16 (I do not have jCK-17)tests under `api/java_security` passed
-------------
Commit messages:
- Fix jcheck whitespace error
- 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec
Changes: https://git.openjdk.java.net/jdk/pull/2949/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2949&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8263404
Stats: 21 lines in 1 file changed: 3 ins; 5 del; 13 mod
Patch: https://git.openjdk.java.net/jdk/pull/2949.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/2949/head:pull/2949
PR: https://git.openjdk.java.net/jdk/pull/2949
More information about the security-dev
mailing list