RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v21]

Andrew Haley aph at openjdk.java.net
Fri Mar 12 16:35:24 UTC 2021


On Tue, 9 Mar 2021 18:01:11 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/globalDefinitions_aarch64.hpp line 62:
>> 
>>> 60: 
>>> 61: #if defined(__APPLE__) || defined(_WIN64)
>>> 62: #define R18_RESERVED
>> 
>> #define R18_RESERVED true```
>
> We always check for `R18_RESERVED` with `#if(n)def`, is there any reason to define the value for the macro?

Robustness, clarity, maintainability, convention. Why not?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2200


More information about the security-dev mailing list