RFR: 8263549: 8263412 can cause jtreg testlibrary split [v3]

Igor Ignatyev iignatyev at openjdk.java.net
Sat Mar 13 14:56:06 UTC 2021


On Sat, 13 Mar 2021 14:20:20 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Igor Ignatyev has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.
>
> I downloaded the patch and used Ioi's cmd pattern to scroll through
> the changes. I can't honestly say that I looked at every line since 867
> changed files would overwhelm anyone's brain...
> 
> I did notice a couple of `@run main` instead of `@run driver` calls
> to the ClassFileInstaller, but those are pre-existing.
> 
> Thumbs up.

Hi Dan,

Thanks for your review!

> I did notice a couple of @run main instead of @run driver calls to the ClassFileInstaller, but those are pre-existing.

I noticed this too, planning to fix that with a separate RFE.

-- Igor

-------------

PR: https://git.openjdk.java.net/jdk/pull/2985


More information about the security-dev mailing list