RFR: 8260274: Cipher.init(int, key) does not use highest priority provider for random bytes [v3]

SalusaSecondus github.com+829871+salusasecondus at openjdk.java.net
Wed Mar 17 20:16:49 UTC 2021


On Wed, 17 Mar 2021 20:09:04 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Can someone help review this somewhat trivial change?
>> 
>> Updated JCAUtil class to return the cached SecureRandom object only when the provider configuration has not changed. 
>> Added a regression test to check the affected classes, i.e. AlgorithmParameterGenerator, KeyPairGenerator, Cipher, KeyAgreement, KeyGenerator. 
>> 
>> Thanks,
>> Valerie
>
> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed a null race condition

Not that my review counts towards approval, but this looks good to me (and fixes some issues I've been wrestling with on and off for several years now, so I'm really happy to see this change).

-------------

Marked as reviewed by SalusaSecondus at github.com (no known OpenJDK username).

PR: https://git.openjdk.java.net/jdk/pull/3018


More information about the security-dev mailing list