RFR: 8263855: Use the blessed modifier order in java.management/naming

Claes Redestad redestad at openjdk.java.net
Fri Mar 19 13:30:39 UTC 2021


On Fri, 19 Mar 2021 13:08:24 GMT, Alex Blewitt <github.com+76791+alblue at openjdk.org> wrote:

>> Created the subtask https://bugs.openjdk.java.net/browse/JDK-8263855 for this along with an umbrella RFE.
>
> Thanks @cl4es -- do I need to update the git commit message as well, or is updating the title of the PR sufficient? I recall you suggesting not to do amend/rebases previously.

No, the git commit messages here doesn't matter, the bots will use the PR name when merging into master. It's good form to use reasonably consistent commit messages as you add commits to a PR, but altering commit history is not necessary and might even be disruptive once a PR has been opened.

There's the /summary command you could use to add additional comments to the final commit, see https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/summary

-------------

PR: https://git.openjdk.java.net/jdk/pull/3078


More information about the security-dev mailing list