RFR: 8248268: Support KWP in addition to KW [v3]
Valerie Peng
valeriep at openjdk.java.net
Thu Mar 25 02:20:41 UTC 2021
On Tue, 23 Mar 2021 19:18:14 GMT, Greg Rubin <github.com+829871+SalusaSecondus at openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Changed AlgorithmParameters impls to register under AES/KW/NoPadding and
>> AES/KWP/NoPadding
>
> test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestGeneral.java line 179:
>
>> 177: System.out.println("Testing " + ALGO);
>> 178: c = Cipher.getInstance(ALGO, "SunJCE");
>> 179: for (int i = 0; i < MAX_KWP_PAD_LEN; i++) {
>
> I see that here (and earlier) we do test all padding lengths. I'd still like some KATs generated by a known good implementation to ensure that we are not just compatible with ourselves.
Sure, I can add some from the NIST zip which Michael StJohns mentioned to the NISTWrapKAT.java.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2404
More information about the security-dev
mailing list