RFR: 8264190: Harden TLS interop tests [v3]

Rajan Halade rhalade at openjdk.java.net
Mon Mar 29 18:52:38 UTC 2021


On Mon, 29 Mar 2021 17:31:59 GMT, Fernando Guallini <fguallini at openjdk.org> wrote:

>> Occasional interop tests failures may occur when making use of the test/jdk/javax/net/ssl/TLSCommon/interop framework since there is no assurance the selected available port it is still free at the time a server using the framework starts up, for instance, by command line. To mitigate intermittent failures, this patch updates interop/BaseInteropTest.java in order to validate the server is alive and if not, retry to create a valid server.
>> 
>> In addition, Utilities::isSessionResumed implementation is now comparing equality of first and second session creation time to validate session resumption
>
> Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Improve JdkServer::close and Utilities::waitFor methods

test/jdk/javax/net/ssl/TLSCommon/interop/BaseInteropTest.java line 236:

> 234:             // Retry operation, server might have failed to bind a port
> 235:             server.signalStop();
> 236:             server = createServer(useCase, executor);

Can you please define MAX_RETRIES and use loop to retry? This will make it flexible for us to update retries if needed and avoid duplicate code.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3218


More information about the security-dev mailing list