RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v14]

Volodymyr Paprotski duke at openjdk.org
Fri Nov 11 18:12:20 UTC 2022


On Fri, 11 Nov 2022 01:26:40 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Volodymyr Paprotski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   live review with Sandhya
>
> src/hotspot/cpu/x86/macroAssembler_x86.hpp line 733:
> 
>> 731:   void andptr(Register src1, Register src2) { LP64_ONLY(andq(src1, src2)) NOT_LP64(andl(src1, src2)) ; }
>> 732: 
>> 733: #ifdef _LP64
> 
> Why is it x64-specific?

I believe its needed.

TLDR.. Couple of check ins ago, I broke the 32-bit build, and that was the 'easy' fix..

> src/hotspot/cpu/x86/stubGenerator_x86_64_poly.cpp line 161:
> 
>> 159:   const XMMRegister P2_H = xmm5;
>> 160:   const XMMRegister TMP1 = xmm6;
>> 161:   const Register polyCP = r13;
> 
> Could be renamed to `rscratch` (or `tmp`) since it doesn't hold constant base address anymore.

done

-------------

PR: https://git.openjdk.org/jdk/pull/10582


More information about the security-dev mailing list