RFR: 8296734: JarVerifier:: mapSignersToCodeSource should cache in map

Sean Mullan mullan at openjdk.org
Mon Nov 14 18:45:29 UTC 2022


On Fri, 11 Nov 2022 13:57:39 GMT, pandaapo <duke at openjdk.org> wrote:

> > If you want to instead do some general cleanup in this class for JDK 20, you could instead remove this method and several other unused methods from `JarVerifier`.
> 
> Before I began to make general cleanup, I looked up from this unused method `JarVerifier#mapSignersToCodeSource()`and found all related call stacks: ![未命名文件](https://user-images.githubusercontent.com/35672972/201353836-9151ddfa-10c5-4ecc-96f8-f8aa0c7e2798.png) Can I also remove these methods from `JarFile`, `JavaUtilJarAccess` and its only implementation `JavaUtilJarAccessImpl`?

Yes. I believe the `setEagerValidation` method can also be removed and all code that calls it.

-------------

PR: https://git.openjdk.org/jdk/pull/11072


More information about the security-dev mailing list