RFR: 8296442: EncryptedPrivateKeyInfo can be created with an uninitialized AlgorithmParameters [v3]

Weijun Wang weijun at openjdk.org
Tue Nov 15 21:42:37 UTC 2022


On Tue, 15 Nov 2022 21:13:59 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   expected
>
> src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java line 62:
> 
>> 60:     // The "encryptionAlgorithm" field. If this object is created by
>> 61:     // {@link #EncryptedPrivateKeyInfo(AlgorithmParameters, byte[])}
>> 62:     // with an uninitialized params, it's stored here and algid is null.
> 
> A bit confused by the words "it's stored here" if it is always null for the case where the params are uninitialized. How about: "... with an uninitialized params, algid is null."

How about "...with an uninitialized AlgorithmParameters, the AlgorithmParameters object is store in the params field and algid is null". This should be clear.

-------------

PR: https://git.openjdk.org/jdk/pull/11067


More information about the security-dev mailing list