RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v17]

Volodymyr Paprotski duke at openjdk.org
Wed Nov 16 00:08:07 UTC 2022


On Tue, 15 Nov 2022 19:41:25 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Volodymyr Paprotski has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits:
>> 
>>  - Vladimir's review comments
>>  - Merge remote-tracking branch 'origin/master' into avx512-poly
>>  - Merge remote-tracking branch 'origin/master' into avx512-poly
>>  - Vladimir's review
>>  - live review with Sandhya
>>  - jcheck
>>  - Sandhya's review
>>  - fix windows and 32b linux builds
>>  - add getLimbs to interface and reviews
>>  - fix 32-bit build
>>  - ... and 15 more: https://git.openjdk.org/jdk/compare/7357a1a3...8f5942d9
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_poly.cpp line 896:
> 
>> 894: 
>> 895:   // Cleanup
>> 896:   __ vpxorq(xmm0, xmm0, xmm0, Assembler::AVX_512bit);
> 
> What's the purpose of the cleanup?

The internal security review asked me to blank out all the key material after I am done. i.e. R (and its powers on the stack)

-------------

PR: https://git.openjdk.org/jdk/pull/10582


More information about the security-dev mailing list