RFR: 8296910: Add EdDSA/XDH/RSASSA-PSS to KeyPairGeneratorBench.java

Xue-Lei Andrew Fan xuelei at openjdk.org
Fri Nov 18 17:46:04 UTC 2022


On Fri, 18 Nov 2022 16:02:31 GMT, Weijun Wang <weijun at openjdk.org> wrote:

> Sure, you can choose your style. It's just that the original test was able to use multiple algorithm names in a single class but your enhancement abandoned this feature.

Did you refer to other bench case, like Signatures.java where  I used a single class?  For this one, the original test used sub-classes and I just add more sub-classes for new cases.

Thank you for the review.  I'm going to integrate it.

-------------

PR: https://git.openjdk.org/jdk/pull/11124


More information about the security-dev mailing list