RFR: 8281236: (D)TLS key exchange named groups [v3]

Sean Mullan mullan at openjdk.org
Mon Nov 21 16:36:28 UTC 2022


On Tue, 8 Nov 2022 22:07:35 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>>> Unfortunately, I only have author status and can only comment.
>> 
>> I think OpenJDK Author can approve as well.  I just need to get another Reviewer approval before integration.
>
>> > Unfortunately, I only have author status and can only comment.
>> 
>> I think OpenJDK Author can approve as well. I just need to get another Reviewer approval before integration.
> 
> For a CSR, I believe that is true. But you will need a Reviewer for the PR, and they may have comments on parts that are covered by the CSR.
> 
> I would suggest moving the CSR to Proposed (which doesn't require a Reviewer AFAIK). That will move it forward a bit.

> @seanjmullan Did you have cycle to review this PR and CSR? This CSR is similar to the one we did for signature algorithms. I was wondering if it is possible to have it in JDK 20 so that more specific TLS benchmarks could be introduced sooner. Thanks!

I added my name as Reviewer to the CSR, so you can finalize that, as that will give you a better chance of it being approved and getting this into JDK 20. It will take me a little while longer to review the code changes, though I don't expect it will impact the API.

-------------

PR: https://git.openjdk.org/jdk/pull/9776


More information about the security-dev mailing list