RFR: 8296742: Illegal X509 Extension should not be created [v8]

Weijun Wang weijun at openjdk.org
Tue Nov 22 20:45:37 UTC 2022


On Tue, 22 Nov 2022 19:56:42 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   IssuerAlternativeNameExtension names
>
> src/java.base/share/classes/sun/security/x509/SubjectKeyIdentifierExtension.java line 76:
> 
>> 74:      */
>> 75:     public SubjectKeyIdentifierExtension(byte[] octetString)
>> 76:             throws IOException {
> 
> Do you want to change the `KeyIdentifer` ctor to check for null instead of letting it throw NPE?

I'll let it throw NPE. As long as there's no way to create a `KeyIdentifer` with a null array inside, I'm not eager to change the exception type.

-------------

PR: https://git.openjdk.org/jdk/pull/11137


More information about the security-dev mailing list