RFR: 8247645: ChaCha20 intrinsics [v5]

[Jamil Nimeh]

On Mon, 28 Nov 2022 22:58:26 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> Jamil Nimeh has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 50 commits:
>> 
>>  - Merge with main
>>  - Add AVX assertion guard
>>  - Pull out common macro code into function parameter pack
>>  - replace hi/lo word shuffles and left-right shift/or operations for vpshufd on byte-aligned rotations
>>  - Change intrinsic helper method name conform to convention
>>  - consolidate chacha macroAssembler routines into chacha stubGenerator file
>>  - More indentation fixes on aarch64
>>  - rename chapoly->chacha for macro file
>>  - rename chacha macro file to be consistent with x86_64 naming
>>  - Fix indentation issues
>>  - ... and 40 more: https://git.openjdk.org/jdk/compare/392ac705...bb3f4264
>
> src/java.base/share/classes/com/sun/crypto/provider/ChaCha20Cipher.java line 92:
> 
>> 90:     private long counter;
>> 91: 
>> 92:     // The 16-int state array and output keystream array:
> 
> I think it would help readability if these comments were separated for each declaration

Agreed.  I've split those up for each declaration as suggested.

-------------

PR: https://git.openjdk.org/jdk/pull/7702