RFR: 8297778: Modernize and improve module jdk.sctp

Per Minborg pminborg at openjdk.org
Wed Nov 30 09:03:26 UTC 2022


On Tue, 29 Nov 2022 20:25:19 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> src/jdk.sctp/macosx/classes/sun/nio/ch/sctp/SctpChannelImpl.java line 44:
>> 
>>> 42:  * Unimplemented.
>>> 43:  */
>>> 44: public class SctpChannelImpl extends SctpChannel {
>> 
>> Going a bit beyond just updating syntax; but that's a different PR...
>> There could be more sharing of the unsupported implementation if SctpChannel was not abstract and its method bodies threw the exception.  There would less duplication for unsupported platforms.
>
>> There could be more sharing of the unsupported implementation if SctpChannel was not abstract and its method bodies threw the exception. There would less duplication for unsupported platforms.
> 
> I think this is accident of history. As I recall, the "unsupported implementation" was Windows only in JDK 6 but it has since been copied. It could be cleaned up.

Created https://bugs.openjdk.org/browse/JDK-8297822?filter=-2 and will move changes for this to a separate PR.

-------------

PR: https://git.openjdk.org/jdk/pull/11418


More information about the security-dev mailing list