From alan.bateman at oracle.com Thu Jul 1 08:36:53 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 01 Jul 2010 15:36:53 +0000 Subject: hg: jdk7/tl/jdk: 6947216: Even more Dual-pivot quicksort improvements Message-ID: <20100701153723.EEB57476AD@hg.openjdk.java.net> Changeset: a5a34c696d62 Author: alanb Date: 2010-07-01 16:28 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a5a34c696d62 6947216: Even more Dual-pivot quicksort improvements Reviewed-by: jjb Contributed-by: vladimir.yaroslavskiy at sun.com ! src/share/classes/java/util/DualPivotQuicksort.java ! test/java/util/Arrays/Sorting.java From sean.mullan at oracle.com Thu Jul 1 13:16:01 2010 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Thu, 01 Jul 2010 20:16:01 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20100701201636.0BA42476B9@hg.openjdk.java.net> Changeset: 9bffc32b645d Author: mullan Date: 2010-07-01 15:20 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9bffc32b645d 6782979: Add JNLPAppletLauncher (6618105) to blacklist Reviewed-by: ohair ! make/java/security/Makefile Changeset: c0d2a097eb99 Author: mullan Date: 2010-07-01 15:30 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c0d2a097eb99 Merge From john.coomes at oracle.com Fri Jul 2 07:14:37 2010 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 02 Jul 2010 14:14:37 +0000 Subject: hg: jdk7/hotspot-rt: 4 new changesets Message-ID: <20100702141437.87A7A476F8@hg.openjdk.java.net> Changeset: dc900d5a8e2f Author: mikejwre Date: 2010-06-24 20:02 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/rev/dc900d5a8e2f Added tag jdk7-b99 for changeset e7f18db469a3 ! .hgtags Changeset: 47f6b7db1882 Author: ohair Date: 2010-06-21 11:00 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/rev/47f6b7db1882 6960853: Cleanup makefiles, remove unused vars etc. 6959596: Windows fastdebug build broken 6960335: Add top level 'make test' rule that uses test/Makefile, runs all test batches Reviewed-by: alanb ! Makefile ! make/Defs-internal.gmk ! make/jprt.gmk ! make/sanity-rules.gmk ! test/Makefile Changeset: 3b147bf5a0e9 Author: lana Date: 2010-06-21 22:06 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/rev/3b147bf5a0e9 Merge Changeset: b218a53ec7d3 Author: lana Date: 2010-06-29 22:31 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/rev/b218a53ec7d3 Merge From john.coomes at oracle.com Fri Jul 2 07:14:42 2010 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 02 Jul 2010 14:14:42 +0000 Subject: hg: jdk7/hotspot-rt/corba: 5 new changesets Message-ID: <20100702141447.E02B7476F9@hg.openjdk.java.net> Changeset: ad2aa1f66abf Author: mikejwre Date: 2010-06-24 20:02 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/corba/rev/ad2aa1f66abf Added tag jdk7-b99 for changeset 95db968660e7 ! .hgtags Changeset: 032585ad970d Author: jjg Date: 2010-06-14 11:28 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/corba/rev/032585ad970d 6960831: fix CORBA build warnings Reviewed-by: darcy ! src/share/classes/com/sun/corba/se/impl/orbutil/CorbaResourceUtil.java ! src/share/classes/com/sun/corba/se/impl/orbutil/ObjectUtility.java ! src/share/classes/com/sun/corba/se/impl/presentation/rmi/ExceptionHandlerImpl.java ! src/share/classes/org/omg/CORBA/ORB.java ! src/share/classes/sun/corba/Bridge.java Changeset: 8f0a1a30461d Author: lana Date: 2010-06-16 13:41 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/corba/rev/8f0a1a30461d Merge Changeset: 8eeca6e452de Author: lana Date: 2010-06-21 22:06 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/corba/rev/8eeca6e452de Merge Changeset: a56d734a1e97 Author: lana Date: 2010-06-29 22:31 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/corba/rev/a56d734a1e97 Merge From john.coomes at oracle.com Fri Jul 2 07:24:06 2010 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 02 Jul 2010 14:24:06 +0000 Subject: hg: jdk7/hotspot-rt/jaxp: 5 new changesets Message-ID: <20100702142406.99F9A476FA@hg.openjdk.java.net> Changeset: 69a11eec2789 Author: mikejwre Date: 2010-06-24 20:03 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxp/rev/69a11eec2789 Added tag jdk7-b99 for changeset 7ef8469021fb ! .hgtags Changeset: 214f47923c24 Author: ohair Date: 2010-06-17 10:43 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxp/rev/214f47923c24 6955301: Update names and references to rebranded drop bundles (jaxp, jaxws, jaf) Reviewed-by: darcy ! jaxp.properties Changeset: 961ad5ff3b19 Author: ohair Date: 2010-06-17 10:50 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxp/rev/961ad5ff3b19 6955292: Workaround ant 1.7.1 package-info.java issue in ant scripts 6960333: Add make level ALLOW_DOWNLOADS=true option 6940241: Change jaxp/jaxws so that the http downloads are not done by default Reviewed-by: darcy ! build-defs.xml ! build-drop-template.xml ! build.properties ! build.xml ! make/Makefile Changeset: 478835e100cd Author: lana Date: 2010-06-21 22:07 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxp/rev/478835e100cd Merge Changeset: d524be5ef62e Author: lana Date: 2010-06-29 22:31 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxp/rev/d524be5ef62e Merge From john.coomes at oracle.com Fri Jul 2 07:24:10 2010 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 02 Jul 2010 14:24:10 +0000 Subject: hg: jdk7/hotspot-rt/jaxws: 5 new changesets Message-ID: <20100702142410.8814B476FB@hg.openjdk.java.net> Changeset: 5bca7bc114a0 Author: mikejwre Date: 2010-06-24 20:03 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxws/rev/5bca7bc114a0 Added tag jdk7-b99 for changeset 818366ce23d8 ! .hgtags Changeset: 38fd32b8e990 Author: ohair Date: 2010-06-17 17:18 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxws/rev/38fd32b8e990 6869741: Integrate JAX-WS 2.2 and JAXB 2.2 in JDK 7 Reviewed-by: darcy, ramap ! jaxws.properties Changeset: 48872561d4b1 Author: ohair Date: 2010-06-17 17:19 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxws/rev/48872561d4b1 6955292: Workaround ant 1.7.1 package-info.java issue in ant scripts 6940241: Change jaxp/jaxws so that the http downloads are not done by default 6960333: Add make level ALLOW_DOWNLOADS=true option Reviewed-by: darcy, ramap ! build-defs.xml ! build-drop-template.xml ! build.properties ! build.xml ! make/Makefile Changeset: db63f482182d Author: lana Date: 2010-06-21 22:07 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxws/rev/db63f482182d Merge Changeset: bd26d0ce0c3c Author: lana Date: 2010-06-29 22:31 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxws/rev/bd26d0ce0c3c Merge From john.coomes at oracle.com Fri Jul 2 07:26:08 2010 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 02 Jul 2010 14:26:08 +0000 Subject: hg: jdk7/hotspot-rt/jdk: 76 new changesets Message-ID: <20100702143903.55B1B476FC@hg.openjdk.java.net> Changeset: 0cd764a1c809 Author: jrose Date: 2010-04-30 23:48 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/0cd764a1c809 6939134: JSR 292 adjustments to method handle invocation Summary: split MethodHandle.invoke into invokeExact and invokeGeneric; also clean up JVM-to-Java interfaces Reviewed-by: twisti ! src/share/classes/java/dyn/CallSite.java ! src/share/classes/java/dyn/InvokeDynamic.java ! src/share/classes/java/dyn/InvokeDynamicBootstrapError.java ! src/share/classes/java/dyn/JavaMethodHandle.java ! src/share/classes/java/dyn/Linkage.java ! src/share/classes/java/dyn/LinkagePermission.java ! src/share/classes/java/dyn/MethodHandle.java ! src/share/classes/java/dyn/MethodHandles.java ! src/share/classes/java/dyn/MethodType.java ! src/share/classes/java/dyn/NoAccessException.java ! src/share/classes/java/dyn/package-info.java ! src/share/classes/sun/dyn/AdapterMethodHandle.java ! src/share/classes/sun/dyn/BoundMethodHandle.java ! src/share/classes/sun/dyn/CallSiteImpl.java ! src/share/classes/sun/dyn/FilterGeneric.java ! src/share/classes/sun/dyn/FilterOneArgument.java ! src/share/classes/sun/dyn/FromGeneric.java ! src/share/classes/sun/dyn/MemberName.java ! src/share/classes/sun/dyn/MethodHandleImpl.java ! src/share/classes/sun/dyn/MethodHandleNatives.java ! src/share/classes/sun/dyn/MethodTypeImpl.java ! src/share/classes/sun/dyn/SpreadGeneric.java ! src/share/classes/sun/dyn/ToGeneric.java ! src/share/classes/sun/dyn/package-info.java ! src/share/classes/sun/dyn/util/ValueConversions.java ! src/share/classes/sun/dyn/util/VerifyAccess.java ! test/java/dyn/MethodHandlesTest.java Changeset: 4a28a204b726 Author: jrose Date: 2010-05-03 23:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/4a28a204b726 6939196: method handle signatures off the boot class path get linkage errors Summary: Remove workaround from MethodHandleImpl lookup code; add JUnit regression test to MethodHandlesTest. Reviewed-by: twisti ! src/share/classes/sun/dyn/MethodHandleImpl.java ! test/java/dyn/MethodHandlesTest.java Changeset: 3cf85945abef Author: jrose Date: 2010-05-13 20:01 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/3cf85945abef Merge Changeset: d742045bd30b Author: jrose Date: 2010-06-18 15:23 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/d742045bd30b Merge ! src/share/classes/java/dyn/CallSite.java ! src/share/classes/java/dyn/InvokeDynamic.java ! src/share/classes/java/dyn/InvokeDynamicBootstrapError.java ! src/share/classes/java/dyn/JavaMethodHandle.java ! src/share/classes/java/dyn/Linkage.java ! src/share/classes/java/dyn/LinkagePermission.java ! src/share/classes/java/dyn/MethodHandle.java ! src/share/classes/java/dyn/MethodHandles.java ! src/share/classes/java/dyn/MethodType.java ! src/share/classes/java/dyn/NoAccessException.java ! src/share/classes/java/dyn/package-info.java ! src/share/classes/sun/dyn/AdapterMethodHandle.java ! src/share/classes/sun/dyn/BoundMethodHandle.java ! src/share/classes/sun/dyn/CallSiteImpl.java ! src/share/classes/sun/dyn/FilterGeneric.java ! src/share/classes/sun/dyn/FilterOneArgument.java ! src/share/classes/sun/dyn/FromGeneric.java ! src/share/classes/sun/dyn/MemberName.java ! src/share/classes/sun/dyn/MethodHandleImpl.java ! src/share/classes/sun/dyn/MethodHandleNatives.java ! src/share/classes/sun/dyn/MethodTypeImpl.java ! src/share/classes/sun/dyn/SpreadGeneric.java ! src/share/classes/sun/dyn/ToGeneric.java ! src/share/classes/sun/dyn/package-info.java ! src/share/classes/sun/dyn/util/ValueConversions.java ! src/share/classes/sun/dyn/util/VerifyAccess.java ! test/java/dyn/MethodHandlesTest.java Changeset: 3d944ecfa470 Author: jrose Date: 2010-06-08 23:08 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/3d944ecfa470 6939203: JSR 292 needs method handle constants Summary: Add new CP types CONSTANT_MethodHandle, CONSTANT_MethodType to verifier; put in runtime support upcall. Reviewed-by: twisti ! src/share/classes/java/dyn/MethodHandles.java ! src/share/classes/sun/dyn/MethodHandleNatives.java ! src/share/javavm/export/classfile_constants.h ! src/share/native/common/check_code.c ! test/java/dyn/MethodHandlesTest.java Changeset: 2587c9f0b60d Author: jrose Date: 2010-06-19 01:14 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/2587c9f0b60d Merge ! src/share/classes/java/dyn/MethodHandles.java ! src/share/classes/sun/dyn/MethodHandleNatives.java ! src/share/javavm/export/classfile_constants.h ! src/share/native/common/check_code.c ! test/java/dyn/MethodHandlesTest.java Changeset: 3956cdee6712 Author: mikejwre Date: 2010-06-24 20:03 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/3956cdee6712 Added tag jdk7-b99 for changeset 2587c9f0b60d ! .hgtags Changeset: 4d55419ce99e Author: andrew Date: 2010-06-08 17:52 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/4d55419ce99e 6959123: Remove use of obsolete png_check_sig function in splashscreen_png.c Summary: Avoid use of deprecated libpng macro (removed in some 1.4.x releases) Reviewed-by: prr ! src/share/native/sun/awt/splashscreen/splashscreen_png.c Changeset: 2574d999704a Author: igor Date: 2010-06-10 15:00 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/2574d999704a 6952043: Incorrect JNI calls in fontpath.c Reviewed-by: jgodinez, prr ! src/windows/native/sun/font/fontpath.c Changeset: ae887ea4c772 Author: lana Date: 2010-06-10 18:58 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/ae887ea4c772 Merge - make/com/sun/inputmethods/Makefile - make/com/sun/inputmethods/indicim/Makefile - make/com/sun/inputmethods/thaiim/Makefile - src/share/classes/com/sun/inputmethods/internal/indicim/DevanagariInputMethodDescriptor.java - src/share/classes/com/sun/inputmethods/internal/indicim/DevanagariTables.java - src/share/classes/com/sun/inputmethods/internal/indicim/IndicInputMethod.java - src/share/classes/com/sun/inputmethods/internal/indicim/IndicInputMethodImpl.java - src/share/classes/com/sun/inputmethods/internal/indicim/java.awt.im.spi.InputMethodDescriptor - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_de.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_es.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_fr.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_it.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_ja.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_ko.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_sv.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_zh_CN.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_zh_TW.properties - src/share/classes/com/sun/inputmethods/internal/thaiim/ThaiInputMethod.java - src/share/classes/com/sun/inputmethods/internal/thaiim/ThaiInputMethodDescriptor.java - src/share/classes/com/sun/inputmethods/internal/thaiim/ThaiInputMethodImpl.java - src/share/classes/com/sun/inputmethods/internal/thaiim/ThaiRules.java - src/share/classes/com/sun/inputmethods/internal/thaiim/java.awt.im.spi.InputMethodDescriptor - src/share/classes/com/sun/inputmethods/internal/thaiim/resources/DisplayNames.properties - src/share/classes/javax/swing/text/html/parser/html32.bdtd - src/share/classes/sun/security/tools/PolicyTool.java Changeset: 8b55669c7b7a Author: neugens Date: 2010-06-16 20:46 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/8b55669c7b7a 6961732: FontMetrics.getLeading() may be negative in freetype-based OpenJDK builds. Summary: Fix premature integer roundings to preserve correct height, width and descent values for fonts Reviewed-by: prr ! src/share/native/sun/font/freetypeScaler.c Changeset: 83c7768292d7 Author: prr Date: 2010-06-18 11:00 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/83c7768292d7 6961633: gui applications cause a jvm crash on windows Reviewed-by: ceisserer, bae ! make/sun/pisces/Makefile ! src/share/classes/sun/java2d/pisces/META-INF/services/sun.java2d.pipe.RenderingEngine + src/solaris/classes/sun/java2d/pisces/META-INF/services/sun.java2d.pipe.RenderingEngine Changeset: 31d25fccdf1c Author: lana Date: 2010-06-21 22:04 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/31d25fccdf1c Merge Changeset: c02096d7b70e Author: anthony Date: 2010-06-16 11:26 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/c02096d7b70e 6959787: java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html failed on 7b94 Summary: Add a delay to the test to make sure the filename filters are called. Reviewed-by: dcherepanov, art ! test/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java Changeset: fa06ad055c43 Author: coffeys Date: 2010-06-16 16:15 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/fa06ad055c43 6860491: WRAP_TIME_MILLIS incorrectly set Summary: Alter WRAP_TIME_MILLIS to be unsigned Reviewed-by: yan ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: 8722b75c9ccd Author: anthony Date: 2010-06-18 17:09 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/8722b75c9ccd 6959165: JVM crash during execution FileDialogBufferOverflowTest.html Summary: Add proper synchronization Reviewed-by: art, dcherepanov ! src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.c Changeset: 05eb107d6891 Author: anthony Date: 2010-06-18 17:13 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/05eb107d6891 6961754: JCK tests CvsEventTest0001 and CvsEventTest0002 fail under FF 3.5 on OEL 5 Summary: Check the return value of XlibUtil.translateCoordinates() for null Reviewed-by: art, dcherepanov ! src/solaris/classes/sun/awt/X11/XEmbeddedFramePeer.java ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: ae16c200341a Author: lana Date: 2010-06-21 22:05 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/ae16c200341a Merge Changeset: ad5f65797249 Author: rupashka Date: 2010-06-02 11:59 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/ad5f65797249 6857057: api/javax_swing/text/GlyphView/index.html#Methods test fails Reviewed-by: peterz ! src/share/classes/javax/swing/text/Utilities.java ! src/share/classes/javax/swing/text/WrappedPlainView.java + test/javax/swing/text/WrappedPlainView/6857057/StubBranchElement.java + test/javax/swing/text/WrappedPlainView/6857057/StubLeafElement.java + test/javax/swing/text/WrappedPlainView/6857057/bug6857057.java Changeset: dc14ee238fe3 Author: rupashka Date: 2010-06-02 12:53 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/dc14ee238fe3 6636983: Japanese text does not display correctly in a JEditorPane Reviewed-by: peterz ! src/share/classes/javax/swing/text/DefaultStyledDocument.java ! src/share/classes/javax/swing/text/GlyphView.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/sun/swing/SwingUtilities2.java + test/javax/swing/text/DefaultStyledDocument/6636983/bug6636983.java Changeset: d1c875d94263 Author: lana Date: 2010-06-10 14:18 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/d1c875d94263 Merge - src/share/classes/sun/security/tools/PolicyTool.java Changeset: 7a3d8fc0d2cd Author: malenkov Date: 2010-06-15 17:39 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/7a3d8fc0d2cd 5066685: BorderFactory lacks SoftBevelBorder support Reviewed-by: alexp ! src/share/classes/javax/swing/BorderFactory.java Changeset: cf13f6389bdd Author: alexp Date: 2010-06-15 19:05 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/cf13f6389bdd 6788484: NPE in DefaultTableCellHeaderRenderer.getColumnSortOrder() with null table Reviewed-by: rupashka ! src/share/classes/sun/swing/table/DefaultTableCellHeaderRenderer.java + test/javax/swing/JTable/6788484/bug6788484.java Changeset: 5e4969391538 Author: alexp Date: 2010-06-15 19:10 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/5e4969391538 6735259: NPE at WindowsComboBoxUI$XPComboBoxButton.getState(WindowsComboBoxUI.java:408) Reviewed-by: rupashka ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsComboBoxUI.java Changeset: cd565c554dc6 Author: alexp Date: 2010-06-15 21:28 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/cd565c554dc6 6771547: SynthParser throws StringIndexOutOfBoundsException parsing custom ColorTypes Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/synth/SynthParser.java + test/javax/swing/plaf/synth/6771547/SynthTest.java + test/javax/swing/plaf/synth/6771547/synthconfig.xml Changeset: 4d93c409ce87 Author: alexp Date: 2010-06-15 21:32 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/4d93c409ce87 6739756: JToolBar leaves space for non-visible items under Nimbus L&F Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/synth/SynthToolBarUI.java + test/javax/swing/plaf/synth/SynthToolBarUI/6739756/bug6739756.java Changeset: aaa62c1f221e Author: lana Date: 2010-06-21 22:06 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/aaa62c1f221e Merge Changeset: 17870c6c1d4e Author: alanb Date: 2010-06-02 09:29 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/17870c6c1d4e 6950927: Testcase failure sun/management/jmxremote/bootstrap/JvmstatCountersTest.java Reviewed-by: dholmes, dcubed ! src/solaris/classes/sun/tools/attach/LinuxVirtualMachine.java ! src/solaris/classes/sun/tools/attach/SolarisVirtualMachine.java Changeset: 6e57723b3519 Author: alanb Date: 2010-06-02 09:35 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/6e57723b3519 Merge Changeset: 1db252f307b6 Author: martin Date: 2010-06-02 17:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/1db252f307b6 6955840: ThreadLocalRandom bug - overriden setSeed(long) method is not invoked for java.util.Random(long) Summary: Allow setSeed only during construction Reviewed-by: dl, dholmes ! src/share/classes/java/util/concurrent/ThreadLocalRandom.java Changeset: ea8c57ec8409 Author: weijun Date: 2010-06-04 19:28 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/ea8c57ec8409 6951366: kerberos login failure on win2008 with AD set to win2000 compat mode Reviewed-by: valeriep, xuelei ! src/share/classes/sun/security/krb5/Credentials.java ! src/share/classes/sun/security/krb5/EncryptionKey.java ! src/share/classes/sun/security/krb5/KrbAsReq.java ! src/windows/classes/sun/security/krb5/internal/tools/Kinit.java ! test/sun/security/krb5/auto/Context.java ! test/sun/security/krb5/auto/KDC.java + test/sun/security/krb5/auto/W83.java Changeset: 489c1720757b Author: chegar Date: 2010-06-08 10:46 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/489c1720757b 6957375: java/net/ResponseCache getResponseCode and ResponseCacheTest fail after rebranding Reviewed-by: ohair, wetmore, alanb ! test/java/net/ResponseCache/file1.cache Changeset: a21e3a29ca9d Author: darcy Date: 2010-06-08 18:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/a21e3a29ca9d 6935997: Please add a nested throwable constructor to AssertionError Reviewed-by: martin, forax, wetmore ! src/share/classes/java/lang/AssertionError.java ! src/share/classes/java/security/Security.java Changeset: af68ad345389 Author: alanb Date: 2010-06-09 18:51 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/af68ad345389 6935563: (dc) Improve connection reset/port unreachable handling [win] Reviewed-by: chegar ! src/windows/native/sun/nio/ch/DatagramChannelImpl.c ! src/windows/native/sun/nio/ch/Net.c + test/java/nio/channels/DatagramChannel/SelectWhenRefused.java Changeset: 1474dfa499e3 Author: mchung Date: 2010-06-10 14:14 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/1474dfa499e3 6959965: jstat: Add new -classload option to print class loading statistics Summary: Add a new jstat -classload option Reviewed-by: alanb ! make/sun/tools/Makefile ! src/share/classes/sun/tools/jstat/Arguments.java ! src/share/classes/sun/tools/jstat/OptionFinder.java ! src/share/classes/sun/tools/jstat/OptionLister.java ! src/share/classes/sun/tools/jstat/resources/jstat_options + src/share/classes/sun/tools/jstat/resources/jstat_unsupported_options + test/sun/tools/jstat/classloadOutput1.awk + test/sun/tools/jstat/jstatClassloadOutput1.sh ! test/sun/tools/jstat/jstatOptions1.sh + test/sun/tools/jstat/options2.out Changeset: af827b7eb81d Author: mchung Date: 2010-06-10 14:21 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/af827b7eb81d Merge Changeset: f7a69b261b1d Author: martin Date: 2010-06-10 15:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/f7a69b261b1d 6960394: Stop linking with -lnsl on Linux Summary: Define LIBNSL (like LIBSOCKET), non-empty only on Solaris Reviewed-by: ohair ! make/common/Defs-linux.gmk ! make/common/Defs-solaris.gmk ! make/java/hpi/hpi_common.gmk ! make/java/java/Makefile ! make/java/java_hprof_demo/Makefile ! make/java/net/Makefile ! make/jpda/transport/socket/Makefile ! make/mkdemo/jvmti/hprof/Makefile ! src/share/demo/jvmti/hprof/sample.makefile.txt Changeset: aa8effe6bb54 Author: martin Date: 2010-06-10 15:55 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/aa8effe6bb54 6959259: Minor improvements to static Random field caching Summary: Cache fields in locals; small javadoc clarifications Reviewed-by: emcmanus, dholmes, forax, dl ! src/share/classes/java/lang/Math.java ! src/share/classes/java/lang/StrictMath.java ! src/share/classes/java/util/Collections.java Changeset: b1ec20722051 Author: weijun Date: 2010-06-11 11:38 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/b1ec20722051 6958869: regression: PKIXValidator fails when multiple trust anchors have same dn Reviewed-by: xuelei, wetmore, mullan ! src/share/classes/sun/security/validator/PKIXValidator.java ! test/sun/security/validator/CertReplace.java ! test/sun/security/validator/certreplace.sh + test/sun/security/validator/samedn.sh Changeset: 06699a990ac7 Author: alanb Date: 2010-06-11 14:31 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/06699a990ac7 6934585: TEST_BUG: java/nio/channels/AsynchronousSocketChannel/Basic.java Reviewed-by: chegar ! test/ProblemList.txt ! test/java/nio/channels/AsynchronousSocketChannel/Basic.java Changeset: 7079585d6e0e Author: alanb Date: 2010-06-11 14:47 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/7079585d6e0e 6938230: (so) SocketAdaptor.close() does not translate IOException resulting in Error Reviewed-by: chegar ! src/share/classes/sun/nio/ch/ServerSocketAdaptor.java ! src/share/classes/sun/nio/ch/SocketAdaptor.java Changeset: c849dc20dc85 Author: andrew Date: 2010-06-12 01:32 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/c849dc20dc85 6959197: When building with JAVAC_MAX_WARNINGS=true, the build fails in sun/nio/cs due to the use of -Werror Summary: Remove unneeded casts, add generic types and make better use of static data Reviewed-by: sherman ! make/sun/nio/cs/Makefile ! src/share/classes/sun/io/ByteToCharISO2022.java ! src/share/classes/sun/io/ByteToCharISO2022JP.java ! src/share/classes/sun/io/ByteToCharJISAutoDetect.java ! src/share/classes/sun/io/CharToBytePCK.java ! src/share/classes/sun/nio/cs/ext/DoubleByte.java ! src/share/classes/sun/nio/cs/ext/EUC_JP.java ! src/share/classes/sun/nio/cs/ext/EUC_JP_LINUX.java ! src/share/classes/sun/nio/cs/ext/EUC_JP_Open.java ! src/share/classes/sun/nio/cs/ext/EUC_TW.java ! src/share/classes/sun/nio/cs/ext/GB18030.java ! src/share/classes/sun/nio/cs/ext/HKSCS.java ! src/share/classes/sun/nio/cs/ext/ISO2022.java ! src/share/classes/sun/nio/cs/ext/JISAutoDetect.java ! src/share/classes/sun/nio/cs/ext/PCK.java ! src/share/classes/sun/nio/cs/ext/SJIS.java ! src/solaris/classes/sun/nio/cs/ext/COMPOUND_TEXT_Encoder.java ! src/solaris/classes/sun/nio/cs/ext/CompoundTextSupport.java Changeset: 422531c98ba5 Author: martin Date: 2010-06-11 18:55 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/422531c98ba5 6944584: Improvements to subprocess handling on Unix Summary: use thread pool for reaper thread; move most I/O operations out of reaper thread Reviewed-by: michaelm, hiroshi ! src/share/classes/java/lang/ProcessBuilder.java ! src/solaris/classes/java/lang/UNIXProcess.java.linux ! test/java/lang/ProcessBuilder/Basic.java Changeset: 5a61a4f65c9c Author: martin Date: 2010-06-13 17:19 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/5a61a4f65c9c 6960898: Regression due to src/share/classes/java/lang/ProcessBuilder.java changes Summary: Use Null{In,Out}putStream.INSTANCE as with Linux code Reviewed-by: ohair ! src/solaris/classes/java/lang/UNIXProcess.java.solaris ! src/windows/classes/java/lang/ProcessImpl.java Changeset: 76a9c90e9019 Author: alanb Date: 2010-06-15 10:03 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/76a9c90e9019 6961062: (dc) Several DatagramChannel tests timeout or fail with "address already in use" Reviewed-by: chegar ! test/ProblemList.txt ! test/java/nio/channels/DatagramChannel/Connect.java ! test/java/nio/channels/DatagramChannel/EmptyBuffer.java ! test/java/nio/channels/DatagramChannel/NoSender.java ! test/java/nio/channels/DatagramChannel/SRTest.java ! test/java/nio/channels/DatagramChannel/Sender.java Changeset: fb2d88134382 Author: mchung Date: 2010-06-14 14:44 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/fb2d88134382 6960789: com.sun.servicetag API needs to be added in ct.sym Summary: Include com.sun.servicetag classes when generating ct.sym Reviewed-by: alanb, jjg ! make/common/Release.gmk ! test/ProblemList.txt Changeset: c1f7ff3447ba Author: mchung Date: 2010-06-15 09:49 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/c1f7ff3447ba 6952161: Rebranding: Registration html for servicetag Summary: Rebrand register.html and jdk_header.png Reviewed-by: ohair, asaha, ogino, mfang ! src/share/classes/com/sun/servicetag/resources/jdk_header.png ! src/share/classes/com/sun/servicetag/resources/register.html ! src/share/classes/com/sun/servicetag/resources/register_ja.html ! src/share/classes/com/sun/servicetag/resources/register_zh_CN.html Changeset: 915ca65d1db7 Author: mchung Date: 2010-06-15 09:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/915ca65d1db7 Merge ! test/ProblemList.txt Changeset: 8d7438dede10 Author: mchung Date: 2010-06-15 09:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/8d7438dede10 6959641: testcase failing java/util/Locale/Bug4184873Test.java Summary: Revert the Bug4184873_{he,id,yi} files to revision 0 (before rebranding) Reviewed-by: naoto ! test/ProblemList.txt ! test/java/util/Locale/Bug4184873_he ! test/java/util/Locale/Bug4184873_id ! test/java/util/Locale/Bug4184873_yi Changeset: 72022d7d4578 Author: alanb Date: 2010-06-15 16:36 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/72022d7d4578 6932744: TEST_BUG: java/nio/channels/Selector/OpRead.java failing Reviewed-by: chegar ! test/ProblemList.txt ! test/java/nio/channels/Selector/OpRead.java Changeset: 91124d60b2ed Author: alanb Date: 2010-06-15 16:42 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/91124d60b2ed 6961358: TEST_BUG: java/nio/channels/SocketChannel/OpenLeak.java can't run in samevm mode Reviewed-by: chegar ! test/ProblemList.txt ! test/java/nio/channels/SocketChannel/OpenLeak.java Changeset: 125ec775c9d1 Author: alanb Date: 2010-06-15 21:43 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/125ec775c9d1 Merge ! test/ProblemList.txt Changeset: 1b7879ca3e74 Author: mchung Date: 2010-06-15 20:29 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/1b7879ca3e74 6961518: TEST_BUG: add @run main/othervm in tests that call setSecurityManager Summary: Mark tests to run in othervm Reviewed-by: ohair ! test/ProblemList.txt ! test/java/beans/Beans/Test4080522.java ! test/java/beans/EventHandler/Test6277246.java ! test/java/beans/EventHandler/Test6277266.java ! test/java/beans/Introspector/Test6277246.java ! test/java/lang/ClassLoader/UninitializedParent.java ! test/java/lang/ClassLoader/findSystemClass/Loader.java ! test/java/lang/System/IgnoreNullSecurityManager.java ! test/java/lang/annotation/ParameterAnnotations.java ! test/java/util/ResourceBundle/Bug6359330.java ! test/java/util/ResourceBundle/Test4300693.java Changeset: 55e512967525 Author: mchung Date: 2010-06-15 20:34 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/55e512967525 6961506: TEST_BUG: ResourceBundle/Bug4168625Test.java and TestBug4179766.java fails in samevm mode Summary: Set the proper parent class loader of Loader and SimpleLoader Reviewed-by: naoto ! test/ProblemList.txt ! test/java/util/ResourceBundle/Bug4168625Test.java ! test/java/util/ResourceBundle/TestBug4179766.java Changeset: 8a4557c5dfa1 Author: alanb Date: 2010-06-16 14:24 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/8a4557c5dfa1 6961630: TEST_BUG: Several SocketChannel and Selector tests can fail with "address already in use" Reviewed-by: chegar ! test/ProblemList.txt ! test/java/nio/channels/Selector/ByteServer.java ! test/java/nio/channels/Selector/CloseThenRegister.java ! test/java/nio/channels/Selector/ReadAfterConnect.java ! test/java/nio/channels/Selector/SelectAfterRead.java ! test/java/nio/channels/Selector/SelectWrite.java ! test/java/nio/channels/SocketChannel/BigReadWrite.java ! test/java/nio/channels/SocketChannel/VectorIO.java ! test/java/nio/channels/SocketChannel/Write.java ! test/java/nio/channels/spi/SelectorProvider/inheritedChannel/EchoTest.java Changeset: 8a286789de96 Author: ksrini Date: 2010-06-16 12:36 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/8a286789de96 6575373: Error verifying signatures of pack200 files in some cases Reviewed-by: jrose, forax ! src/share/classes/com/sun/java/util/jar/pack/PropMap.java ! src/share/classes/java/util/jar/Pack200.java ! test/tools/pack200/Pack200Test.java + test/tools/pack200/SegmentLimit.java Changeset: 705777f990cf Author: mchung Date: 2010-06-16 12:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/705777f990cf 6961502: TEST_BUG: test/java/lang/ClassLoader/defineClass/DefineClassByteBuffer.java fails Summary: Fix the test to define TestClass by DummyClassLoader as it intends to do Reviewed-by: alanb ! test/ProblemList.txt ! test/java/lang/ClassLoader/defineClass/DefineClassByteBuffer.java Changeset: 94404fea2067 Author: lana Date: 2010-06-16 14:07 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/94404fea2067 Merge - make/com/sun/inputmethods/Makefile - make/com/sun/inputmethods/indicim/Makefile - make/com/sun/inputmethods/thaiim/Makefile ! make/common/Defs-linux.gmk ! make/common/Defs-solaris.gmk ! make/common/Release.gmk - src/share/classes/com/sun/inputmethods/internal/indicim/DevanagariInputMethodDescriptor.java - src/share/classes/com/sun/inputmethods/internal/indicim/DevanagariTables.java - src/share/classes/com/sun/inputmethods/internal/indicim/IndicInputMethod.java - src/share/classes/com/sun/inputmethods/internal/indicim/IndicInputMethodImpl.java - src/share/classes/com/sun/inputmethods/internal/indicim/java.awt.im.spi.InputMethodDescriptor - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_de.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_es.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_fr.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_it.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_ja.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_ko.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_sv.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_zh_CN.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_zh_TW.properties - src/share/classes/com/sun/inputmethods/internal/thaiim/ThaiInputMethod.java - src/share/classes/com/sun/inputmethods/internal/thaiim/ThaiInputMethodDescriptor.java - src/share/classes/com/sun/inputmethods/internal/thaiim/ThaiInputMethodImpl.java - src/share/classes/com/sun/inputmethods/internal/thaiim/ThaiRules.java - src/share/classes/com/sun/inputmethods/internal/thaiim/java.awt.im.spi.InputMethodDescriptor - src/share/classes/com/sun/inputmethods/internal/thaiim/resources/DisplayNames.properties ! src/share/classes/com/sun/servicetag/resources/register.html ! src/share/classes/com/sun/servicetag/resources/register_ja.html ! src/share/classes/com/sun/servicetag/resources/register_zh_CN.html - src/share/classes/javax/swing/text/html/parser/html32.bdtd ! test/java/util/ResourceBundle/Bug4168625Test.java Changeset: 3df25d0680f3 Author: weijun Date: 2010-06-17 13:46 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/3df25d0680f3 6959292: regression: cannot login if session key and preauth does not use the same etype Reviewed-by: xuelei, valeriep ! src/share/classes/sun/security/krb5/Credentials.java ! src/share/classes/sun/security/krb5/EncryptionKey.java ! src/share/classes/sun/security/krb5/KrbAsReq.java ! src/share/classes/sun/security/krb5/internal/KRBError.java ! src/windows/classes/sun/security/krb5/internal/tools/Kinit.java ! test/sun/security/krb5/auto/KDC.java ! test/sun/security/krb5/auto/W83.java Changeset: c995607e7719 Author: mchung Date: 2010-06-16 23:27 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/c995607e7719 6961408: test/java/util/logging/ParentLoggersTest.java fails in samevm mode Summary: Check against the list of loggers added since the test begins to run Reviewed-by: dcubed ! test/ProblemList.txt ! test/java/util/logging/ParentLoggersTest.java Changeset: 1281181df71b Author: alanb Date: 2010-06-17 17:49 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/1281181df71b 6395224: (so) SocketChannel writer blocked on large buffer is not preempted by close method (vista) Reviewed-by: chegar ! src/windows/native/sun/nio/ch/SocketDispatcher.c ! src/windows/native/sun/nio/ch/nio_util.h ! test/ProblemList.txt ! test/java/nio/channels/AsyncCloseAndInterrupt.java Changeset: 5e4547833379 Author: sherman Date: 2010-06-17 13:21 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/5e4547833379 6962067: TEST_BUG: Tests in java/util/zip/ZipFile leave file open Summary: Close zipfile and io stream when done Reviewed-by: alanb ! test/ProblemList.txt ! test/java/util/zip/InfoZip.java ! test/java/util/zip/ZipFile/Comment.java ! test/java/util/zip/ZipFile/CorruptedZipFiles.java ! test/java/util/zip/ZipFile/ManyEntries.java Changeset: 006e852b692e Author: ohair Date: 2010-06-17 14:42 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/006e852b692e 6869741: Integrate JAX-WS 2.2 and JAXB 2.2 in JDK 7 Reviewed-by: ramap ! make/docs/CORE_PKGS.gmk Changeset: 6c188df7bfef Author: alanb Date: 2010-06-18 16:16 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/6c188df7bfef 4981129: (dc) DatagramSocket created by DatagramChannel does not provide sender info Reviewed-by: chegar ! src/share/classes/sun/nio/ch/DatagramSocketAdaptor.java ! test/java/nio/channels/DatagramChannel/AdaptDatagramSocket.java Changeset: 7526d0b9aab0 Author: mchung Date: 2010-06-18 09:35 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/7526d0b9aab0 6961894: TEST_BUG: jdk_lang tests fail in samevm mode Summary: Fixed jdk_lang tests to run in samevm mode or mark to run in othervm Reviewed-by: alanb ! test/ProblemList.txt ! test/java/lang/System/ExitFinalizersAndJIT.java ! test/java/lang/Thread/GenerifyStackTraces.java ! test/java/lang/Thread/StackTraces.java ! test/java/lang/management/ClassLoadingMXBean/LoadCounts.java ! test/java/lang/management/ManagementFactory/MXBeanProxyTest.java ! test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java ! test/java/lang/management/MemoryMXBean/LowMemoryTest.java ! test/java/lang/management/MemoryMXBean/MemoryManagement.java ! test/java/lang/management/MemoryMXBean/Pending.java ! test/java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java ! test/java/lang/management/MemoryPoolMXBean/ThresholdTest.java ! test/java/lang/management/RuntimeMXBean/UpTime.java ! test/java/lang/management/ThreadMXBean/AllThreadIds.java ! test/java/lang/management/ThreadMXBean/DisableTest.java ! test/java/lang/management/ThreadMXBean/EnableTest.java ! test/java/lang/management/ThreadMXBean/FindDeadlocks.java ! test/java/lang/management/ThreadMXBean/FindMonitorDeadlock.java ! test/java/lang/management/ThreadMXBean/Locks.java ! test/java/lang/reflect/Proxy/Boxing.java ! test/java/lang/reflect/Proxy/ClassRestrictions.java ! test/java/lang/reflect/Proxy/returnTypes/Test.java Changeset: ac93014a4d78 Author: alanb Date: 2010-06-18 20:59 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/ac93014a4d78 6962045: TEST_BUG: Tests in test/java/io/Serializable leave files open Reviewed-by: mchung ! test/ProblemList.txt ! test/java/io/Serializable/ClassCastExceptionDetail/Read.java ! test/java/io/Serializable/auditStreamSubclass/AuditStreamSubclass.java ! test/java/io/Serializable/backRefCNFException/Read.java ! test/java/io/Serializable/checkModifiers/CheckModifiers.java ! test/java/io/Serializable/classDescFlagConflict/Read.java ! test/java/io/Serializable/classDescHooks/ClassDescHooks.java ! test/java/io/Serializable/duplicateSerialFields/Test.java ! test/java/io/Serializable/enum/badResolve/Read.java ! test/java/io/Serializable/enum/constantSubclasses/Read.java ! test/java/io/Serializable/enum/missingConstant/Read.java ! test/java/io/Serializable/fieldTypeString/Read.java ! test/java/io/Serializable/illegalHandle/Test.java ! test/java/io/Serializable/longString/LongString.java ! test/java/io/Serializable/oldTests/AnnotateClass.java ! test/java/io/Serializable/oldTests/ArrayFields.java ! test/java/io/Serializable/oldTests/ArraysOfArrays.java ! test/java/io/Serializable/oldTests/BinaryTree.java ! test/java/io/Serializable/oldTests/CircularList.java ! test/java/io/Serializable/oldTests/SimpleArrays.java ! test/java/io/Serializable/oldTests/WritePrimitive.java ! test/java/io/Serializable/packageAccess/Test.java ! test/java/io/Serializable/parents/EvolvedClass.java ! test/java/io/Serializable/parents/OriginalClass.java ! test/java/io/Serializable/proxy/Basic.java ! test/java/io/Serializable/proxy/skipMissing/Read.java ! test/java/io/Serializable/proxy/skipMissing/Write.java ! test/java/io/Serializable/readObjectNoData/Read.java ! test/java/io/Serializable/skipWriteObject/Read.java ! test/java/io/Serializable/skippedObjCNFException/Read.java ! test/java/io/Serializable/stopCustomDeserialization/Read.java ! test/java/io/Serializable/unresolvedClassDesc/Read.java ! test/java/io/Serializable/unshared/Read.java ! test/java/io/Serializable/wrongReturnTypes/Read.java Changeset: 5919f0c72c0b Author: alanb Date: 2010-06-19 15:17 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/5919f0c72c0b 6962419: TEST_BUG: java_io tests fails in samevm mode Reviewed-by: ohair, sherman ! test/ProblemList.txt ! test/java/io/BufferedReader/BigMark.java ! test/java/io/BufferedReader/ReadLineSync.java ! test/java/io/DataInputStream/OpsAfterClose.java ! test/java/io/DataInputStream/ReadFully.java ! test/java/io/File/DeleteOnExit.java ! test/java/io/File/DeleteOnExitNPE.java ! test/java/io/File/IsHidden.java ! test/java/io/FileInputStream/LeadingSlash.java ! test/java/io/InputStream/OpsAfterClose.java ! test/java/io/InputStream/ReadParams.java ! test/java/io/InputStreamReader/GrowAfterEOF.java ! test/java/io/ObjectInputStream/ResolveProxyClass.java ! test/java/io/RandomAccessFile/EOF.java ! test/java/io/RandomAccessFile/ParameterCheck.java ! test/java/io/RandomAccessFile/ReadLine.java ! test/java/io/RandomAccessFile/Seek.java ! test/java/io/RandomAccessFile/WriteBytesChars.java ! test/java/io/RandomAccessFile/WriteUTF.java ! test/java/io/RandomAccessFile/skipBytes/SkipBytes.java ! test/java/io/Reader/Skip.java ! test/java/io/Reader/SkipNegative.java ! test/java/io/StreamTokenizer/Comment.java ! test/java/io/readBytes/ReadBytesBounds.java Changeset: 43dfa39686a1 Author: ksrini Date: 2010-06-19 17:42 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/43dfa39686a1 6712743: pack200: should default to 150.7 pack format for classfiles without any classes. Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/Constants.java ! src/share/classes/com/sun/java/util/jar/pack/Package.java ! src/share/classes/java/util/jar/Pack200.java + test/tools/pack200/PackageVersionTest.java Changeset: a086a3d98711 Author: ohair Date: 2010-06-20 14:51 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/a086a3d98711 6960853: Cleanup makefiles, remove unused vars etc. Reviewed-by: alanb ! make/common/shared/Defs-control.gmk ! make/netbeans/README ! make/netbeans/world/README ! make/netbeans/world/build.xml Changeset: 840265545bc3 Author: ohair Date: 2010-06-20 14:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/840265545bc3 6962617: Testcase changes, cleanup of problem list for jdk_tools targets Reviewed-by: alanb ! test/Makefile ! test/ProblemList.txt ! test/com/sun/jdi/PopAndInvokeTest.java ! test/com/sun/servicetag/JavaServiceTagTest1.java ! test/com/sun/servicetag/SystemRegistryTest.java ! test/com/sun/tools/attach/BasicTests.sh ! test/com/sun/tracing/BasicFunctionality.java ! test/sun/jvmstat/testlibrary/utils.sh ! test/sun/tools/jps/jps-Vvml_2.sh ! test/sun/tools/jps/jps-m_2.sh ! test/sun/tools/jstatd/jstatdDefaults.sh ! test/sun/tools/jstatd/jstatdExternalRegistry.sh ! test/sun/tools/jstatd/jstatdPort.sh ! test/sun/tools/jstatd/jstatdServerName.sh ! test/tools/jar/UpdateManifest.java ! test/tools/jar/index/MetaInf.java Changeset: 2366c2a5624c Author: mchung Date: 2010-06-20 19:56 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/2366c2a5624c 6962478: Privacy page referenced in register_ja.html is incorrect Summary: Fix the URL for the privacy page Reviewed-by: ogino ! src/share/classes/com/sun/servicetag/resources/register_ja.html Changeset: fe7271b4aeea Author: mchung Date: 2010-06-21 15:02 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/fe7271b4aeea 6962815: support enable and disable of the servicetag's system registry for testing purpose Summary: Allow the system registry to be disabled/enabled at runtime Reviewed-by: ksrini ! src/share/classes/com/sun/servicetag/Registry.java ! test/com/sun/servicetag/FindServiceTags.java ! test/com/sun/servicetag/JavaServiceTagTest1.java ! test/com/sun/servicetag/SystemRegistryTest.java ! test/com/sun/servicetag/Util.java Changeset: 5438223734aa Author: lana Date: 2010-06-21 22:08 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/5438223734aa Merge Changeset: 10a6319c9c15 Author: lana Date: 2010-06-29 22:34 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/10a6319c9c15 Merge Changeset: 861213cb02c3 Author: prr Date: 2010-06-29 16:34 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/861213cb02c3 6964882: 32 bit JDK does not build on 64 bit Windows platforms Reviewed-by: ohair, valeriep ! make/sun/security/mscapi/Makefile ! make/sun/security/pkcs11/Makefile Changeset: 511ddf6938ea Author: mikejwre Date: 2010-06-30 18:57 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/511ddf6938ea Merge From john.coomes at oracle.com Fri Jul 2 07:49:33 2010 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 02 Jul 2010 14:49:33 +0000 Subject: hg: jdk7/hotspot-rt/langtools: 21 new changesets Message-ID: <20100702145010.9F2A8476FE@hg.openjdk.java.net> Changeset: f0e3ec1f9d9f Author: jrose Date: 2010-05-01 15:05 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/f0e3ec1f9d9f 6939134: JSR 292 adjustments to method handle invocation Summary: split MethodHandle.invoke into invokeExact and invokeGeneric Reviewed-by: twisti ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/util/Names.java ! test/tools/javac/meth/InvokeDyn.java ! test/tools/javac/meth/InvokeMH.java Changeset: 2a28dcbef3a7 Author: jrose Date: 2010-05-13 20:01 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/2a28dcbef3a7 Merge Changeset: 005bec70ca27 Author: jrose Date: 2010-06-18 15:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/005bec70ca27 Merge ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/util/Names.java ! test/tools/javac/meth/InvokeDyn.java ! test/tools/javac/meth/InvokeMH.java Changeset: 9d02c4ce4275 Author: mikejwre Date: 2010-06-24 20:03 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/9d02c4ce4275 Added tag jdk7-b99 for changeset 005bec70ca27 ! .hgtags Changeset: 9a7c998bf2fc Author: darcy Date: 2010-06-02 19:08 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/9a7c998bf2fc 6933147: Provided new utility visitors supporting SourceVersion.RELEASE_7 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java ! src/share/classes/com/sun/tools/javah/JavahTask.java ! src/share/classes/com/sun/tools/javah/LLNI.java ! src/share/classes/com/sun/tools/javah/TypeSignature.java ! src/share/classes/javax/lang/model/element/ElementVisitor.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor6.java + src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor6.java + src/share/classes/javax/lang/model/util/AbstractElementVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java + src/share/classes/javax/lang/model/util/AbstractTypeVisitor7.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor6.java + src/share/classes/javax/lang/model/util/ElementKindVisitor7.java ! src/share/classes/javax/lang/model/util/ElementScanner6.java + src/share/classes/javax/lang/model/util/ElementScanner7.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor6.java + src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor7.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor6.java + src/share/classes/javax/lang/model/util/SimpleElementVisitor7.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor6.java + src/share/classes/javax/lang/model/util/SimpleTypeVisitor7.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor6.java + src/share/classes/javax/lang/model/util/TypeKindVisitor7.java ! src/share/sample/javac/processing/src/CheckNamesProcessor.java ! test/tools/javac/6402516/CheckLocalElements.java ! test/tools/javac/api/TestOperators.java ! test/tools/javac/enum/6424358/T6424358.java ! test/tools/javac/processing/model/6194785/T6194785.java ! test/tools/javac/processing/model/type/NoTypes.java ! test/tools/javac/processing/model/util/deprecation/TestDeprecation.java Changeset: 559c9a37d9f6 Author: jjg Date: 2010-06-03 17:14 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/559c9a37d9f6 6955264: add option to suppress Abort in Check.completionError Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Check.java Changeset: 852d8bb356bc Author: darcy Date: 2010-06-03 19:56 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/852d8bb356bc 6519115: MirroredTypeException thrown but should be MirroredTypesException Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/model/AnnotationProxyMaker.java ! src/share/classes/javax/lang/model/type/MirroredTypeException.java ! src/share/classes/javax/lang/model/type/MirroredTypesException.java + test/tools/javac/processing/model/type/MirroredTypeEx/Plurality.java Changeset: b7fc560217d3 Author: jjg Date: 2010-06-04 14:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/b7fc560217d3 6958391: add vizant support to langtools build Reviewed-by: mcimadamore ! make/build.properties ! make/build.xml Changeset: d33b91f360fc Author: jjg Date: 2010-06-04 17:33 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/d33b91f360fc 6958802: cleanup and doc langtools build.xml file Reviewed-by: ohair ! make/build.properties ! make/build.xml Changeset: 46cf751559ae Author: mcimadamore Date: 2010-06-10 09:29 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/46cf751559ae 6945418: Project Coin: Simplified Varargs Method Invocation Summary: Add new mandatory warning for unsafe vararg method declaration. Warning can be suppressed as usual (@SuppressWarnings("varargs")/-Xlint:-varargs) Reviewed-by: jjg, darcy ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/List.java ! test/tools/javac/varargs/6730476/T6730476a.java ! test/tools/javac/varargs/6806876/T6806876.out + test/tools/javac/varargs/warning/Warn4.java Changeset: f2fdd52e4e87 Author: jjg Date: 2010-06-10 16:08 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/f2fdd52e4e87 6944312: Potential rebranding issues in openjdk/langtools repository sources Reviewed-by: darcy ! src/share/classes/com/sun/javadoc/package.html ! src/share/classes/com/sun/mirror/overview.html ! src/share/classes/com/sun/source/tree/DisjointTypeTree.java ! src/share/classes/com/sun/tools/apt/comp/Apt.java ! src/share/classes/com/sun/tools/apt/main/CommandLine.java ! src/share/classes/com/sun/tools/apt/main/JavaCompiler.java ! src/share/classes/com/sun/tools/apt/main/Main.java ! src/share/classes/com/sun/tools/apt/util/Bark.java ! src/share/classes/com/sun/tools/classfile/AccessFlags.java ! src/share/classes/com/sun/tools/classfile/Annotation.java ! src/share/classes/com/sun/tools/classfile/AnnotationDefault_attribute.java ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/classfile/AttributeException.java ! src/share/classes/com/sun/tools/classfile/Attributes.java ! src/share/classes/com/sun/tools/classfile/CharacterRangeTable_attribute.java ! src/share/classes/com/sun/tools/classfile/ClassFile.java ! src/share/classes/com/sun/tools/classfile/ClassReader.java ! src/share/classes/com/sun/tools/classfile/ClassTranslator.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/share/classes/com/sun/tools/classfile/Code_attribute.java ! src/share/classes/com/sun/tools/classfile/CompilationID_attribute.java ! src/share/classes/com/sun/tools/classfile/ConstantPool.java ! src/share/classes/com/sun/tools/classfile/ConstantPoolException.java ! src/share/classes/com/sun/tools/classfile/ConstantValue_attribute.java ! src/share/classes/com/sun/tools/classfile/DefaultAttribute.java ! src/share/classes/com/sun/tools/classfile/Deprecated_attribute.java ! src/share/classes/com/sun/tools/classfile/Descriptor.java ! src/share/classes/com/sun/tools/classfile/DescriptorException.java ! src/share/classes/com/sun/tools/classfile/EnclosingMethod_attribute.java ! src/share/classes/com/sun/tools/classfile/Exceptions_attribute.java ! src/share/classes/com/sun/tools/classfile/ExtendedAnnotation.java ! src/share/classes/com/sun/tools/classfile/Field.java ! src/share/classes/com/sun/tools/classfile/InnerClasses_attribute.java ! src/share/classes/com/sun/tools/classfile/Instruction.java ! src/share/classes/com/sun/tools/classfile/LineNumberTable_attribute.java ! src/share/classes/com/sun/tools/classfile/LocalVariableTable_attribute.java ! src/share/classes/com/sun/tools/classfile/LocalVariableTypeTable_attribute.java ! src/share/classes/com/sun/tools/classfile/Method.java ! src/share/classes/com/sun/tools/classfile/Opcode.java ! src/share/classes/com/sun/tools/classfile/RuntimeAnnotations_attribute.java ! src/share/classes/com/sun/tools/classfile/RuntimeInvisibleAnnotations_attribute.java ! src/share/classes/com/sun/tools/classfile/RuntimeInvisibleParameterAnnotations_attribute.java ! src/share/classes/com/sun/tools/classfile/RuntimeInvisibleTypeAnnotations_attribute.java ! src/share/classes/com/sun/tools/classfile/RuntimeParameterAnnotations_attribute.java ! src/share/classes/com/sun/tools/classfile/RuntimeTypeAnnotations_attribute.java ! src/share/classes/com/sun/tools/classfile/RuntimeVisibleAnnotations_attribute.java ! src/share/classes/com/sun/tools/classfile/RuntimeVisibleParameterAnnotations_attribute.java ! src/share/classes/com/sun/tools/classfile/RuntimeVisibleTypeAnnotations_attribute.java ! src/share/classes/com/sun/tools/classfile/Signature.java ! src/share/classes/com/sun/tools/classfile/Signature_attribute.java ! src/share/classes/com/sun/tools/classfile/SourceDebugExtension_attribute.java ! src/share/classes/com/sun/tools/classfile/SourceFile_attribute.java ! src/share/classes/com/sun/tools/classfile/SourceID_attribute.java ! src/share/classes/com/sun/tools/classfile/StackMapTable_attribute.java ! src/share/classes/com/sun/tools/classfile/StackMap_attribute.java ! src/share/classes/com/sun/tools/classfile/Synthetic_attribute.java ! src/share/classes/com/sun/tools/classfile/Type.java ! src/share/classes/com/sun/tools/javac/Launcher.java ! src/share/classes/com/sun/tools/javac/Server.java ! src/share/classes/com/sun/tools/javac/api/DiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/api/Formattable.java ! src/share/classes/com/sun/tools/javac/api/JavacScope.java ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/api/Messages.java ! src/share/classes/com/sun/tools/javac/api/WrappingJavaFileManager.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/BoundKind.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Scope.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/TargetType.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java ! src/share/classes/com/sun/tools/javac/code/TypeTags.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/AttrContext.java ! src/share/classes/com/sun/tools/javac/comp/AttrContextEnv.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/ConstFold.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Env.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/Todo.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/file/BaseFileObject.java ! src/share/classes/com/sun/tools/javac/file/CacheFSInfo.java ! src/share/classes/com/sun/tools/javac/file/FSInfo.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/Paths.java ! src/share/classes/com/sun/tools/javac/file/RegularFileObject.java ! src/share/classes/com/sun/tools/javac/file/RelativePath.java ! src/share/classes/com/sun/tools/javac/file/SymbolArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndexArchive.java ! src/share/classes/com/sun/tools/javac/jvm/ByteCodes.java ! src/share/classes/com/sun/tools/javac/jvm/CRTFlags.java ! src/share/classes/com/sun/tools/javac/jvm/CRTable.java ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Items.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java ! src/share/classes/com/sun/tools/javac/jvm/UninitializedType.java ! src/share/classes/com/sun/tools/javac/main/CommandLine.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/JavacOption.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/main/OptionName.java ! src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java ! src/share/classes/com/sun/tools/javac/model/AnnotationProxyMaker.java ! src/share/classes/com/sun/tools/javac/model/FilteredMemberList.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/com/sun/tools/javac/model/JavacSourcePosition.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java ! src/share/classes/com/sun/tools/javac/nio/PathFileManager.java ! src/share/classes/com/sun/tools/javac/nio/PathFileObject.java ! src/share/classes/com/sun/tools/javac/parser/DocCommentScanner.java ! src/share/classes/com/sun/tools/javac/parser/EndPosParser.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Keywords.java ! src/share/classes/com/sun/tools/javac/parser/Lexer.java ! src/share/classes/com/sun/tools/javac/parser/Parser.java ! src/share/classes/com/sun/tools/javac/parser/ParserFactory.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/parser/Token.java ! src/share/classes/com/sun/tools/javac/processing/AnnotationProcessingError.java ! src/share/classes/com/sun/tools/javac/processing/JavacFiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacMessager.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java ! src/share/classes/com/sun/tools/javac/processing/ServiceProxy.java ! src/share/classes/com/sun/tools/javac/sym/CreateSymbols.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! src/share/classes/com/sun/tools/javac/util/Abort.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/AbstractLog.java ! src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/Bits.java ! src/share/classes/com/sun/tools/javac/util/ByteBuffer.java ! src/share/classes/com/sun/tools/javac/util/ClientCodeException.java ! src/share/classes/com/sun/tools/javac/util/CloseableURLClassLoader.java ! src/share/classes/com/sun/tools/javac/util/Constants.java ! src/share/classes/com/sun/tools/javac/util/Context.java ! src/share/classes/com/sun/tools/javac/util/Convert.java ! src/share/classes/com/sun/tools/javac/util/DiagnosticSource.java ! src/share/classes/com/sun/tools/javac/util/FatalError.java ! src/share/classes/com/sun/tools/javac/util/ForwardingDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/JavacMessages.java ! src/share/classes/com/sun/tools/javac/util/LayoutCharacters.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/ListBuffer.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/MandatoryWarningHandler.java ! src/share/classes/com/sun/tools/javac/util/Name.java ! src/share/classes/com/sun/tools/javac/util/Names.java ! src/share/classes/com/sun/tools/javac/util/Options.java ! src/share/classes/com/sun/tools/javac/util/Pair.java ! src/share/classes/com/sun/tools/javac/util/Position.java ! src/share/classes/com/sun/tools/javac/util/PropagatedException.java ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/SharedNameTable.java ! src/share/classes/com/sun/tools/javac/util/UnsharedNameTable.java ! src/share/classes/com/sun/tools/javac/util/Warner.java ! src/share/classes/com/sun/tools/javah/Gen.java ! src/share/classes/com/sun/tools/javah/InternalError.java ! src/share/classes/com/sun/tools/javah/JNI.java ! src/share/classes/com/sun/tools/javah/JavahFileManager.java ! src/share/classes/com/sun/tools/javah/JavahTask.java ! src/share/classes/com/sun/tools/javah/JavahTool.java ! src/share/classes/com/sun/tools/javah/LLNI.java ! src/share/classes/com/sun/tools/javah/Main.java ! src/share/classes/com/sun/tools/javah/Mangle.java ! src/share/classes/com/sun/tools/javah/NativeHeaderTool.java ! src/share/classes/com/sun/tools/javah/TypeSignature.java ! src/share/classes/com/sun/tools/javah/Util.java ! src/share/classes/com/sun/tools/javap/AnnotationWriter.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! src/share/classes/com/sun/tools/javap/BasicWriter.java ! src/share/classes/com/sun/tools/javap/ClassWriter.java ! src/share/classes/com/sun/tools/javap/CodeWriter.java ! src/share/classes/com/sun/tools/javap/ConstantWriter.java ! src/share/classes/com/sun/tools/javap/Context.java ! src/share/classes/com/sun/tools/javap/DisassemblerTool.java ! src/share/classes/com/sun/tools/javap/InstructionDetailWriter.java ! src/share/classes/com/sun/tools/javap/InternalError.java ! src/share/classes/com/sun/tools/javap/JavapFileManager.java ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/share/classes/com/sun/tools/javap/LocalVariableTableWriter.java ! src/share/classes/com/sun/tools/javap/LocalVariableTypeTableWriter.java ! src/share/classes/com/sun/tools/javap/Main.java ! src/share/classes/com/sun/tools/javap/Messages.java ! src/share/classes/com/sun/tools/javap/Options.java ! src/share/classes/com/sun/tools/javap/SourceWriter.java ! src/share/classes/com/sun/tools/javap/StackMapWriter.java ! src/share/classes/com/sun/tools/javap/TryBlockWriter.java ! src/share/classes/com/sun/tools/javap/TypeAnnotationWriter.java ! src/share/classes/javax/lang/model/overview.html ! test/tools/apt/mirror/declaration/pkg1/pkg2/package.html ! test/tools/javac/6948381/T6948381.java ! test/tools/javac/6948381/npe/A.java ! test/tools/javac/6948381/npe/B.java ! test/tools/javac/api/evalexpr/ByteArrayClassLoader.java ! test/tools/javac/api/evalexpr/CompileFromString.java ! test/tools/javac/api/evalexpr/MemoryFileManager.java ! test/tools/javac/generics/diamond/T6951833.java ! test/tools/javac/generics/typevars/T6880344.java ! test/tools/javac/varargs/warning/Warn4.java Changeset: 366a7b9b5627 Author: jjg Date: 2010-06-10 17:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/366a7b9b5627 6960407: Potential rebranding issues in openjdk/langtools repository sources Reviewed-by: darcy ! make/Makefile ! make/Makefile-classic ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/util/JavacTask.java ! src/share/classes/com/sun/source/util/TaskEvent.java ! src/share/classes/com/sun/source/util/TaskListener.java ! src/share/classes/com/sun/tools/doclets/formats/html/package.html ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javadoc/resources/javadoc.properties ! src/share/classes/com/sun/tools/javadoc/resources/javadoc_zh_CN.properties ! src/share/classes/javax/tools/JavaFileManager.java Changeset: 224533455888 Author: jjg Date: 2010-06-11 07:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/224533455888 6877961: langtools build should allow more options when running jtreg Reviewed-by: mcimadamore ! make/build.xml Changeset: d1ea43cb71c1 Author: jjg Date: 2010-06-11 17:24 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/d1ea43cb71c1 6958836: javadoc should support -Xmaxerrs and -Xmaxwarns Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! src/share/classes/com/sun/tools/javadoc/Start.java ! src/share/classes/com/sun/tools/javadoc/resources/javadoc.properties + test/tools/javadoc/6958836/Test.java + test/tools/javadoc/6958836/errs/Errors.java + test/tools/javadoc/6958836/warns/Warnings.java Changeset: 0840dd65b9e2 Author: jjg Date: 2010-06-16 16:23 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/0840dd65b9e2 6956638: JavacTask.generate does not generate all required files Reviewed-by: darcy Contributed-by: joshuamaurice at gmail.com + test/tools/javac/T6956638.java Changeset: 93e1975eea7a Author: lana Date: 2010-06-16 14:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/93e1975eea7a Merge ! test/tools/apt/mirror/declaration/pkg1/pkg2/package.html Changeset: e2b845fdc437 Author: lana Date: 2010-06-16 17:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/e2b845fdc437 Merge Changeset: 0ba1f80b73a5 Author: jjg Date: 2010-06-18 16:45 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/0ba1f80b73a5 6962540: langtools Makefile sets DEV_NULL incorrectly Reviewed-by: ohair ! make/Makefile Changeset: 4177f5bdd189 Author: jjg Date: 2010-06-18 21:13 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/4177f5bdd189 6961178: Allow doclet.xml to contain XML attributes Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeOptionalMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstantsSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstructorBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/EnumConstantBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/FieldBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/LayoutParser.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MethodBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/XMLNode.java Changeset: 4cca8d7ce6c1 Author: lana Date: 2010-06-21 22:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/4cca8d7ce6c1 Merge Changeset: d1d7595fa824 Author: lana Date: 2010-06-29 22:43 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/d1d7595fa824 Merge ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/util/Names.java From jeremymanson at google.com Fri Jul 2 10:56:44 2010 From: jeremymanson at google.com (Jeremy Manson) Date: Fri, 2 Jul 2010 10:56:44 -0700 Subject: Second Code Review for WeakReference leak in the Logging API (6942989) In-Reply-To: <4C2A1B0A.8020605@oracle.com> References: <4C1BC843.60403@oracle.com> <4C22A8FC.7070008@oracle.com> <4C2A1B0A.8020605@oracle.com> Message-ID: Hi Dan, I don't know what AnonLoggerWeakRefTest looks like, but I am fairly confident that if you create a few million loggers and then drop down to one or two, the backing array of the Hashtable will still be bigger than it should be. Still, no real harm done - that's a fairly unusual situation. Jeremy On Tue, Jun 29, 2010 at 9:10 AM, Daniel D. Daugherty wrote: > Jeremy, > > Closing the loop on this part of the thread. I don't think there are > any more leaks left after the fix is applied. Here are the entries > I added the "public comments" section of the bug. For some reason > that bug is _still_ not showing up on the OpenJDK site. > >> === *Public Comments* >> ======================================================== >> I ran the AnonLoggerWeakRefLeak test with the following env variables: >> >> >> TESTJAVA=c:/work/shared/mirrors/jdks-win32/jdk/1.7.0/latest/binaries/windows-i586 >> TESTCLASSES=C:/cygwin/home/dcubed/Projects/6942989/XXX >> TESTVMOPTS=-showversion -client -Xmx32m >> TESTSRC=C:/cygwin/home/dcubed/Projects/6942989/XXX >> >> along with a 30 minute duration (1800 seconds) using JDK7-B99 bits >> (which does NOT have the fix). >> >> Here's the last 15 lines of the log files: >> >> $ tail -15 AnonLogger.jdk7-B99_30min.log >> INFO: instance_cnt = 1032505 >> INFO: instance_cnt = 1038305 >> INFO: instance_cnt = 1044005 >> INFO: instance_cnt = 1049705 >> INFO: jmap exited with exit code = 1 >> INFO: The likely reason is that AnonLoggerWeakRefLeak has finished >> running. >> INFO: increasing_cnt = 181 >> INFO: decreasing_cnt = 0 >> INFO: The instance count of java.lang.ref.WeakReference objects >> INFO: is always increasing. >> FAIL: This indicates that there is a memory leak. >> >> real ? ?18m10.296s >> user ? ?0m41.570s >> sys ? ? 0m46.442s >> >> $ tail -15 AnonLoggerWeakRefLeak.jdk7-B99_30min.log >> INFO: call count = 1044000 >> INFO: call count = 1045000 >> INFO: call count = 1046000 >> INFO: call count = 1047000 >> INFO: call count = 1048000 >> INFO: call count = 1049000 >> Exception in thread "main" java.lang.OutOfMemoryError: Java heap space >> ? ? ? ?at java.util.Arrays.copyOf(Arrays.java:2239) >> ? ? ? ?at java.util.Arrays.copyOf(Arrays.java:2213) >> ? ? ? ?at java.util.ArrayList.grow(ArrayList.java:208) >> ? ? ? ?at java.util.ArrayList.ensureCapacity(ArrayList.java:182) >> ? ? ? ?at java.util.ArrayList.add(ArrayList.java:406) >> ? ? ? ?at java.util.logging.Logger.doSetParent(Logger.java:1401) >> ? ? ? ?at java.util.logging.Logger.getAnonymousLogger(Logger.java:374) >> ? ? ? ?at AnonLoggerWeakRefLeak.main(AnonLoggerWeakRefLeak.java:60) >> >> >> So it took a little over 18 minutes for a Client VM with a 32MB >> max heap size to throw an OOME with AnonLoggerWeakRefLeak. >> >> >> I ran the LoggerWeakRefLeak test with the same environment variables >> along with a 30 minute duration (1800 seconds) using JDK7-B99 bits >> (which does NOT have the fix). >> >> Here's the last 15 lines of the log files: >> >> $ tail -15 Logger.jdk7-B99_30min.log >> INFO: instance_cnt = 935705 >> INFO: instance_cnt = 938605 >> INFO: instance_cnt = 941205 >> INFO: instance_cnt = 943205 >> INFO: jmap exited with exit code = 1 >> INFO: The likely reason is that LoggerWeakRefLeak has finished running. >> INFO: increasing_cnt = 160 >> INFO: decreasing_cnt = 0 >> INFO: The instance count of java.lang.ref.WeakReference objects >> INFO: is always increasing. >> FAIL: This indicates that there is a memory leak. >> >> real ? ?16m47.690s >> user ? ?0m37.910s >> sys ? ? 0m40.002s >> >> $ tail -15 LoggerWeakRefLeak.jdk7-B99_30min.log >> INFO: call count = 881000 >> INFO: call count = 882000 >> INFO: call count = 883000 >> INFO: call count = 884000 >> INFO: call count = 885000 >> INFO: call count = 886000 >> INFO: call count = 887000 >> INFO: call count = 888000 >> INFO: call count = 889000 >> INFO: call count = 890000 >> INFO: call count = 891000 >> INFO: call count = 892000 >> INFO: call count = 893000 >> INFO: call count = 894000 >> Exception in thread "main" java.lang.OutOfMemoryError: Java heap space >> >> >> So it took a little less than 17 minutes for a Client VM with a 32MB >> max heap size to throw an OOME with LoggerWeakRefLeak. >> >> *** (#1 of 3): 2010-06-28 22:45:03 GMT+00:00 daniel.daugherty at oracle.com >> *** Last Edit: 2010-06-28 22:57:39 GMT+00:00 daniel.daugherty at oracle.com >> >> I ran the AnonLoggerWeakRefLeak test with the same environment >> variables for a 60 minute duration using the fixed bits from >> JPRT. Here are the last 15 lines of each log (much less >> interesting info): >> >> $ tail -15 AnonLogger.jdk7-B100+_60min.log >> INFO: instance_cnt = 5801 >> INFO: instance_cnt = 5901 >> INFO: instance_cnt = 5701 >> INFO: instance_cnt = 5601 >> INFO: jmap exited with exit code = 1 >> INFO: The likely reason is that AnonLoggerWeakRefLeak has finished >> running. >> INFO: increasing_cnt = 227 >> INFO: decreasing_cnt = 383 >> INFO: The instance count of java.lang.ref.WeakReference objects >> INFO: is both increasing and decreasing. >> PASS: This indicates that there is not a memory leak. >> >> real ? ?60m5.099s >> user ? ?2m18.882s >> sys ? ? 2m31.127s >> >> $ tail -15 AnonLoggerWeakRefLeak.jdk7-B100+_60min.log >> INFO: call count = 3484000 >> INFO: call count = 3485000 >> INFO: call count = 3486000 >> INFO: call count = 3487000 >> INFO: call count = 3488000 >> INFO: call count = 3489000 >> INFO: call count = 3490000 >> INFO: call count = 3491000 >> INFO: call count = 3492000 >> INFO: call count = 3493000 >> INFO: call count = 3494000 >> INFO: call count = 3495000 >> INFO: call count = 3496000 >> INFO: call count = 3497000 >> INFO: final loop count = 3497200 >> >> >> I ran the LoggerWeakRefLeak test with the same environment >> variables for a 60 minute duration using the fixed bits from >> JPRT. Here are the last 15 lines of each log (much less >> interesting info): >> >> $ tail -15 Logger.jdk7-B100+_60min.log >> INFO: instance_cnt = 1813 >> INFO: instance_cnt = 1638 >> INFO: instance_cnt = 1514 >> INFO: instance_cnt = 1511 >> INFO: jmap exited with exit code = 1 >> INFO: The likely reason is that LoggerWeakRefLeak has finished running. >> INFO: increasing_cnt = 293 >> INFO: decreasing_cnt = 318 >> INFO: The instance count of java.lang.ref.WeakReference objects >> INFO: is both increasing and decreasing. >> PASS: This indicates that there is not a memory leak. >> >> real ? ?60m6.783s >> user ? ?2m20.592s >> sys ? ? 2m31.997s >> >> $ tail -15 LoggerWeakRefLeak.jdk7-B100+_60min.log >> INFO: call count = 3502000 >> INFO: call count = 3503000 >> INFO: call count = 3504000 >> INFO: call count = 3505000 >> INFO: call count = 3506000 >> INFO: call count = 3507000 >> INFO: call count = 3508000 >> INFO: call count = 3509000 >> INFO: call count = 3510000 >> INFO: call count = 3511000 >> INFO: call count = 3512000 >> INFO: call count = 3513000 >> INFO: call count = 3514000 >> INFO: call count = 3515000 >> INFO: final loop count = 3515800 >> >> *** (#2 of 3): 2010-06-29 01:46:49 GMT+00:00 daniel.daugherty at oracle.com >> >> I ran the AnonLoggerWeakRefLeak test with the same environment >> variables for a 12 hour duration using the fixed bits from JPRT. >> For this run I saved the "Total" line from the jmap output from >> every 10th sample: >> >> $ diff ../AnonLoggerWeakRefLeak.sh AnonLoggerWeakRefLeak.sh >> 161a162 >> >>>> >>>> > > "$TEST_NAME.totals" >>>> >> >> 225a227,233 >> >>> >>> > > set +e >>> > mod=`expr "$loop_cnt" % 10` >>> > set -e >>> > if [ "$mod" = 0 ]; then >>> > tail -1 "$TEST_NAME.jmap" >> "$TEST_NAME.totals" >>> > fi >>> >> >> Here is an analysis of the .totals data: >> >> $ sh analyze_totals < AnonLoggerWeakRefLeak.totals >> ? ? ? ? ?#objs ? ? ?#bytes >> first: ? ?30537 ? ? 2243648 >> lo: ? ? ? 30537 ? ? 2243648 >> hi: ? ? ? 57072 ? ? 3197904 >> last: ? ? 35676 ? ? 2882488 >> avg: ? ? ?36853 ? ? 2929982 >> # samples: 647 >> >> The first sample is also the lowest set of values which isn't >> a surprise given that the first sample is taken shortly after >> the target program has started running. The hi value occurred >> in sample #269 of 647 and the last sample was below the average. >> This data indicates that the values are both rising and falling >> over time which does not indicate any more memory leaks. >> >> >> >> I also ran the LoggerWeakRefLeak test with the same environment >> variables for a 12 hour duration using the fixed bits from JPRT. >> For this run I saved the "Total" line from the jmap output from >> every 10th sample: >> >> $ diff ../LoggerWeakRefLeak.sh LoggerWeakRefLeak.sh >> 161a162 >> >>>> >>>> > > "$TEST_NAME.totals" >>>> >> >> 225a227,233 >> >>> >>> > > set +e >>> > mod=`expr "$loop_cnt" % 10` >>> > set -e >>> > if [ "$mod" = 0 ]; then >>> > tail -1 "$TEST_NAME.jmap" >> "$TEST_NAME.totals" >>> > fi >>> >> >> Here is an analysis of the .totals data: >> >> $ sh analyze_totals < LoggerWeakRefLeak.totals >> ? ? ? ? ?#objs ? ? ?#bytes >> first: ? ?48957 ? ? 2832648 >> lo: ? ? ? 48957 ? ? 2832648 >> hi: ? ? ?148299 ? ? 6299016 >> last: ? ?133173 ? ? 5451032 >> avg: ? ? 137578 ? ? 5608654 >> # samples: 647 >> >> The first sample is also the lowest set of values which isn't >> a surprise given that the first sample is taken shortly after >> the target program has started running. The hi value occurred >> in sample #76 of 647 and the last sample was below the average. >> This data indicates that the values are both rising and falling >> over time which does not indicate any more memory leaks. >> >> *** (#3 of 3): 2010-06-29 15:59:39 GMT+00:00 daniel.daugherty at oracle.com > > > Please let me know if the fix is not working for you in your > environment at Google. > > Dan > > > On 6/23/2010 6:38 PM, Daniel D. Daugherty wrote: >> >> On 6/23/2010 12:38 PM, Jeremy Manson wrote: >>> >>> Hi Daniel, >>> >>> I'm sorry I missed this (I heavily filter these lists, and check rarely). >>> >> >> This time I specifically left you on the "To" list rather than >> editing down to just the list aliases. >> >> >>> My main feeling is that you are missing a good bet by not >>> reconstructing the Hashtable in LogManager and the ArrayList in Logger >>> every so often when you remove the loggers. ?In a test case where >>> there are a LOT of short-lived loggers, the backing array for the >>> Hashtable can get very big. ?It is permanent, and doesn't go anywhere. >>> ?You can end up with a lot of extra memory lying around that way. >>> >> >> It's possible that is a good bet. However, that wasn't mentioned >> as one of the issues in either bug report (I think) so I didn't >> write a test for that. >> >> >>> Specifically, when I didn't reconstruct those data structures, the >>> test case listed in the bug (where it just creates lots and lots of >>> anonymous loggers) killed the Java instance with an OOM, even if I >>> *did* clean up the weakreferences to the loggers. >>> >> >> I'll create a variant of the anon logger test that I put in the >> changeset and checkout if I can kill the Java instance with an OOM. >> I'll keep you posted. >> >> >>> I'm assuming you have a customer waiting for this - if that is similar >>> to their usage pattern, this fix may not fix their problem. >>> >> >> Thanks for the heads up. The JDK6 version of the fix hasn't been tested >> by the customer yet so you might be right. >> >> >>> You obviously don't want to rebuild those structures every time, >>> though. ?What I did in my change was to reconstruct the backing data >>> structures every time ~as many loggers were collected as were present >>> in the data structure. >>> >> >> Yup. I caught that part of the rebuild algorithm. It's just that the >> reason for doing the rebuild didn't jump out at me. >> >> Dan >> >> >>> Jeremy >>> >>> On Fri, Jun 18, 2010 at 12:25 PM, Daniel D. Daugherty >>> wrote: >>> >>>> >>>> Greetings, >>>> >>>> I have a new version of my fix for the WeakReference leak in the >>>> Logging API done. This version uses ReferenceQueues; thanks to Eamonn >>>> McManus, Jeremy Manson and Tony Printezis for their insights on using >>>> ReferenceQueues. Here's a pointer to Tony's paper for background info: >>>> >>>> ? http://java.sun.com/developer/technicalArticles/javase/finalization/ >>>> >>>> This version also has limits on the number of dead Loggers that are >>>> cleaned up per call; thanks to Alan Bateman for politely pushing me in >>>> that direction. >>>> >>>> The webrev is again relative to OpenJDK7, but the bug is escalated so >>>> the fix will be backported to the JDK6-Update train. So again, I'll >>>> need a minimum of two code reviewers. >>>> >>>> Here is the URL for the webrev: >>>> >>>> ? http://cr.openjdk.java.net/~dcubed/6942989-webrev/1/ >>>> >>>> Thanks, in advance, for any reviews. >>>> >>>> Dan >>>> >>>> >>>> >> > From daniel.daugherty at oracle.com Fri Jul 2 12:55:25 2010 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Fri, 02 Jul 2010 13:55:25 -0600 Subject: Second Code Review for WeakReference leak in the Logging API (6942989) In-Reply-To: References: <4C1BC843.60403@oracle.com> <4C22A8FC.7070008@oracle.com> <4C2A1B0A.8020605@oracle.com> Message-ID: <4C2E442D.2040509@oracle.com> On 7/2/2010 11:56 AM, Jeremy Manson wrote: > Hi Dan, > > I don't know what AnonLoggerWeakRefTest looks like, Check out the webrevs in the review requests. I included the tests in the those reviews. > but I am fairly > confident that if you create a few million loggers and then drop down > to one or two, the backing array of the Hashtable will still be bigger > than it should be. > Possibly. I just wanted to confirm that we weren't leaking and I think I've confirmed that. > Still, no real harm done - that's a fairly unusual situation. > Agreed. Dan > Jeremy > > On Tue, Jun 29, 2010 at 9:10 AM, Daniel D. Daugherty > wrote: > >> Jeremy, >> >> Closing the loop on this part of the thread. I don't think there are >> any more leaks left after the fix is applied. Here are the entries >> I added the "public comments" section of the bug. For some reason >> that bug is _still_ not showing up on the OpenJDK site. >> >> >>> === *Public Comments* >>> ======================================================== >>> I ran the AnonLoggerWeakRefLeak test with the following env variables: >>> >>> >>> TESTJAVA=c:/work/shared/mirrors/jdks-win32/jdk/1.7.0/latest/binaries/windows-i586 >>> TESTCLASSES=C:/cygwin/home/dcubed/Projects/6942989/XXX >>> TESTVMOPTS=-showversion -client -Xmx32m >>> TESTSRC=C:/cygwin/home/dcubed/Projects/6942989/XXX >>> >>> along with a 30 minute duration (1800 seconds) using JDK7-B99 bits >>> (which does NOT have the fix). >>> >>> Here's the last 15 lines of the log files: >>> >>> $ tail -15 AnonLogger.jdk7-B99_30min.log >>> INFO: instance_cnt = 1032505 >>> INFO: instance_cnt = 1038305 >>> INFO: instance_cnt = 1044005 >>> INFO: instance_cnt = 1049705 >>> INFO: jmap exited with exit code = 1 >>> INFO: The likely reason is that AnonLoggerWeakRefLeak has finished >>> running. >>> INFO: increasing_cnt = 181 >>> INFO: decreasing_cnt = 0 >>> INFO: The instance count of java.lang.ref.WeakReference objects >>> INFO: is always increasing. >>> FAIL: This indicates that there is a memory leak. >>> >>> real 18m10.296s >>> user 0m41.570s >>> sys 0m46.442s >>> >>> $ tail -15 AnonLoggerWeakRefLeak.jdk7-B99_30min.log >>> INFO: call count = 1044000 >>> INFO: call count = 1045000 >>> INFO: call count = 1046000 >>> INFO: call count = 1047000 >>> INFO: call count = 1048000 >>> INFO: call count = 1049000 >>> Exception in thread "main" java.lang.OutOfMemoryError: Java heap space >>> at java.util.Arrays.copyOf(Arrays.java:2239) >>> at java.util.Arrays.copyOf(Arrays.java:2213) >>> at java.util.ArrayList.grow(ArrayList.java:208) >>> at java.util.ArrayList.ensureCapacity(ArrayList.java:182) >>> at java.util.ArrayList.add(ArrayList.java:406) >>> at java.util.logging.Logger.doSetParent(Logger.java:1401) >>> at java.util.logging.Logger.getAnonymousLogger(Logger.java:374) >>> at AnonLoggerWeakRefLeak.main(AnonLoggerWeakRefLeak.java:60) >>> >>> >>> So it took a little over 18 minutes for a Client VM with a 32MB >>> max heap size to throw an OOME with AnonLoggerWeakRefLeak. >>> >>> >>> I ran the LoggerWeakRefLeak test with the same environment variables >>> along with a 30 minute duration (1800 seconds) using JDK7-B99 bits >>> (which does NOT have the fix). >>> >>> Here's the last 15 lines of the log files: >>> >>> $ tail -15 Logger.jdk7-B99_30min.log >>> INFO: instance_cnt = 935705 >>> INFO: instance_cnt = 938605 >>> INFO: instance_cnt = 941205 >>> INFO: instance_cnt = 943205 >>> INFO: jmap exited with exit code = 1 >>> INFO: The likely reason is that LoggerWeakRefLeak has finished running. >>> INFO: increasing_cnt = 160 >>> INFO: decreasing_cnt = 0 >>> INFO: The instance count of java.lang.ref.WeakReference objects >>> INFO: is always increasing. >>> FAIL: This indicates that there is a memory leak. >>> >>> real 16m47.690s >>> user 0m37.910s >>> sys 0m40.002s >>> >>> $ tail -15 LoggerWeakRefLeak.jdk7-B99_30min.log >>> INFO: call count = 881000 >>> INFO: call count = 882000 >>> INFO: call count = 883000 >>> INFO: call count = 884000 >>> INFO: call count = 885000 >>> INFO: call count = 886000 >>> INFO: call count = 887000 >>> INFO: call count = 888000 >>> INFO: call count = 889000 >>> INFO: call count = 890000 >>> INFO: call count = 891000 >>> INFO: call count = 892000 >>> INFO: call count = 893000 >>> INFO: call count = 894000 >>> Exception in thread "main" java.lang.OutOfMemoryError: Java heap space >>> >>> >>> So it took a little less than 17 minutes for a Client VM with a 32MB >>> max heap size to throw an OOME with LoggerWeakRefLeak. >>> >>> *** (#1 of 3): 2010-06-28 22:45:03 GMT+00:00 daniel.daugherty at oracle.com >>> *** Last Edit: 2010-06-28 22:57:39 GMT+00:00 daniel.daugherty at oracle.com >>> >>> I ran the AnonLoggerWeakRefLeak test with the same environment >>> variables for a 60 minute duration using the fixed bits from >>> JPRT. Here are the last 15 lines of each log (much less >>> interesting info): >>> >>> $ tail -15 AnonLogger.jdk7-B100+_60min.log >>> INFO: instance_cnt = 5801 >>> INFO: instance_cnt = 5901 >>> INFO: instance_cnt = 5701 >>> INFO: instance_cnt = 5601 >>> INFO: jmap exited with exit code = 1 >>> INFO: The likely reason is that AnonLoggerWeakRefLeak has finished >>> running. >>> INFO: increasing_cnt = 227 >>> INFO: decreasing_cnt = 383 >>> INFO: The instance count of java.lang.ref.WeakReference objects >>> INFO: is both increasing and decreasing. >>> PASS: This indicates that there is not a memory leak. >>> >>> real 60m5.099s >>> user 2m18.882s >>> sys 2m31.127s >>> >>> $ tail -15 AnonLoggerWeakRefLeak.jdk7-B100+_60min.log >>> INFO: call count = 3484000 >>> INFO: call count = 3485000 >>> INFO: call count = 3486000 >>> INFO: call count = 3487000 >>> INFO: call count = 3488000 >>> INFO: call count = 3489000 >>> INFO: call count = 3490000 >>> INFO: call count = 3491000 >>> INFO: call count = 3492000 >>> INFO: call count = 3493000 >>> INFO: call count = 3494000 >>> INFO: call count = 3495000 >>> INFO: call count = 3496000 >>> INFO: call count = 3497000 >>> INFO: final loop count = 3497200 >>> >>> >>> I ran the LoggerWeakRefLeak test with the same environment >>> variables for a 60 minute duration using the fixed bits from >>> JPRT. Here are the last 15 lines of each log (much less >>> interesting info): >>> >>> $ tail -15 Logger.jdk7-B100+_60min.log >>> INFO: instance_cnt = 1813 >>> INFO: instance_cnt = 1638 >>> INFO: instance_cnt = 1514 >>> INFO: instance_cnt = 1511 >>> INFO: jmap exited with exit code = 1 >>> INFO: The likely reason is that LoggerWeakRefLeak has finished running. >>> INFO: increasing_cnt = 293 >>> INFO: decreasing_cnt = 318 >>> INFO: The instance count of java.lang.ref.WeakReference objects >>> INFO: is both increasing and decreasing. >>> PASS: This indicates that there is not a memory leak. >>> >>> real 60m6.783s >>> user 2m20.592s >>> sys 2m31.997s >>> >>> $ tail -15 LoggerWeakRefLeak.jdk7-B100+_60min.log >>> INFO: call count = 3502000 >>> INFO: call count = 3503000 >>> INFO: call count = 3504000 >>> INFO: call count = 3505000 >>> INFO: call count = 3506000 >>> INFO: call count = 3507000 >>> INFO: call count = 3508000 >>> INFO: call count = 3509000 >>> INFO: call count = 3510000 >>> INFO: call count = 3511000 >>> INFO: call count = 3512000 >>> INFO: call count = 3513000 >>> INFO: call count = 3514000 >>> INFO: call count = 3515000 >>> INFO: final loop count = 3515800 >>> >>> *** (#2 of 3): 2010-06-29 01:46:49 GMT+00:00 daniel.daugherty at oracle.com >>> >>> I ran the AnonLoggerWeakRefLeak test with the same environment >>> variables for a 12 hour duration using the fixed bits from JPRT. >>> For this run I saved the "Total" line from the jmap output from >>> every 10th sample: >>> >>> $ diff ../AnonLoggerWeakRefLeak.sh AnonLoggerWeakRefLeak.sh >>> 161a162 >>> >>> >>>>>>> "$TEST_NAME.totals" >>>>>>> >>> 225a227,233 >>> >>> >>>>>> set +e >>>>>> >>>>> mod=`expr "$loop_cnt" % 10` >>>>> set -e >>>>> if [ "$mod" = 0 ]; then >>>>> tail -1 "$TEST_NAME.jmap" >> "$TEST_NAME.totals" >>>>> fi >>>>> >>> Here is an analysis of the .totals data: >>> >>> $ sh analyze_totals < AnonLoggerWeakRefLeak.totals >>> #objs #bytes >>> first: 30537 2243648 >>> lo: 30537 2243648 >>> hi: 57072 3197904 >>> last: 35676 2882488 >>> avg: 36853 2929982 >>> # samples: 647 >>> >>> The first sample is also the lowest set of values which isn't >>> a surprise given that the first sample is taken shortly after >>> the target program has started running. The hi value occurred >>> in sample #269 of 647 and the last sample was below the average. >>> This data indicates that the values are both rising and falling >>> over time which does not indicate any more memory leaks. >>> >>> >>> >>> I also ran the LoggerWeakRefLeak test with the same environment >>> variables for a 12 hour duration using the fixed bits from JPRT. >>> For this run I saved the "Total" line from the jmap output from >>> every 10th sample: >>> >>> $ diff ../LoggerWeakRefLeak.sh LoggerWeakRefLeak.sh >>> 161a162 >>> >>> >>>>>>> "$TEST_NAME.totals" >>>>>>> >>> 225a227,233 >>> >>> >>>>>> set +e >>>>>> >>>>> mod=`expr "$loop_cnt" % 10` >>>>> set -e >>>>> if [ "$mod" = 0 ]; then >>>>> tail -1 "$TEST_NAME.jmap" >> "$TEST_NAME.totals" >>>>> fi >>>>> >>> Here is an analysis of the .totals data: >>> >>> $ sh analyze_totals < LoggerWeakRefLeak.totals >>> #objs #bytes >>> first: 48957 2832648 >>> lo: 48957 2832648 >>> hi: 148299 6299016 >>> last: 133173 5451032 >>> avg: 137578 5608654 >>> # samples: 647 >>> >>> The first sample is also the lowest set of values which isn't >>> a surprise given that the first sample is taken shortly after >>> the target program has started running. The hi value occurred >>> in sample #76 of 647 and the last sample was below the average. >>> This data indicates that the values are both rising and falling >>> over time which does not indicate any more memory leaks. >>> >>> *** (#3 of 3): 2010-06-29 15:59:39 GMT+00:00 daniel.daugherty at oracle.com >>> >> Please let me know if the fix is not working for you in your >> environment at Google. >> >> Dan >> >> >> On 6/23/2010 6:38 PM, Daniel D. Daugherty wrote: >> >>> On 6/23/2010 12:38 PM, Jeremy Manson wrote: >>> >>>> Hi Daniel, >>>> >>>> I'm sorry I missed this (I heavily filter these lists, and check rarely). >>>> >>>> >>> This time I specifically left you on the "To" list rather than >>> editing down to just the list aliases. >>> >>> >>> >>>> My main feeling is that you are missing a good bet by not >>>> reconstructing the Hashtable in LogManager and the ArrayList in Logger >>>> every so often when you remove the loggers. In a test case where >>>> there are a LOT of short-lived loggers, the backing array for the >>>> Hashtable can get very big. It is permanent, and doesn't go anywhere. >>>> You can end up with a lot of extra memory lying around that way. >>>> >>>> >>> It's possible that is a good bet. However, that wasn't mentioned >>> as one of the issues in either bug report (I think) so I didn't >>> write a test for that. >>> >>> >>> >>>> Specifically, when I didn't reconstruct those data structures, the >>>> test case listed in the bug (where it just creates lots and lots of >>>> anonymous loggers) killed the Java instance with an OOM, even if I >>>> *did* clean up the weakreferences to the loggers. >>>> >>>> >>> I'll create a variant of the anon logger test that I put in the >>> changeset and checkout if I can kill the Java instance with an OOM. >>> I'll keep you posted. >>> >>> >>> >>>> I'm assuming you have a customer waiting for this - if that is similar >>>> to their usage pattern, this fix may not fix their problem. >>>> >>>> >>> Thanks for the heads up. The JDK6 version of the fix hasn't been tested >>> by the customer yet so you might be right. >>> >>> >>> >>>> You obviously don't want to rebuild those structures every time, >>>> though. What I did in my change was to reconstruct the backing data >>>> structures every time ~as many loggers were collected as were present >>>> in the data structure. >>>> >>>> >>> Yup. I caught that part of the rebuild algorithm. It's just that the >>> reason for doing the rebuild didn't jump out at me. >>> >>> Dan >>> >>> >>> >>>> Jeremy >>>> >>>> On Fri, Jun 18, 2010 at 12:25 PM, Daniel D. Daugherty >>>> wrote: >>>> >>>> >>>>> Greetings, >>>>> >>>>> I have a new version of my fix for the WeakReference leak in the >>>>> Logging API done. This version uses ReferenceQueues; thanks to Eamonn >>>>> McManus, Jeremy Manson and Tony Printezis for their insights on using >>>>> ReferenceQueues. Here's a pointer to Tony's paper for background info: >>>>> >>>>> http://java.sun.com/developer/technicalArticles/javase/finalization/ >>>>> >>>>> This version also has limits on the number of dead Loggers that are >>>>> cleaned up per call; thanks to Alan Bateman for politely pushing me in >>>>> that direction. >>>>> >>>>> The webrev is again relative to OpenJDK7, but the bug is escalated so >>>>> the fix will be backported to the JDK6-Update train. So again, I'll >>>>> need a minimum of two code reviewers. >>>>> >>>>> Here is the URL for the webrev: >>>>> >>>>> http://cr.openjdk.java.net/~dcubed/6942989-webrev/1/ >>>>> >>>>> Thanks, in advance, for any reviews. >>>>> >>>>> Dan >>>>> >>>>> >>>>> >>>>> From andrei.pangin at sun.com Sat Jul 3 08:58:47 2010 From: andrei.pangin at sun.com (andrei.pangin at sun.com) Date: Sat, 03 Jul 2010 15:58:47 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 5 new changesets Message-ID: <20100703155903.A81F147733@hg.openjdk.java.net> Changeset: d678e3277048 Author: kvn Date: 2010-06-28 10:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/d678e3277048 6964479: widen normalization of small int and long values should be symmetric Summary: normalize widen value in xmeet() and xdual() methods for types Int and Long so the type meet will be symmetric. Reviewed-by: jrose ! src/share/vm/opto/type.cpp Changeset: 6027dddc26c6 Author: kvn Date: 2010-06-28 14:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/6027dddc26c6 6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist() Summary: Use replace_node() method instead of subsume_node(). Reviewed-by: jrose, never ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/opto/split_if.cpp ! src/share/vm/opto/superword.cpp Changeset: 76efbe666d6c Author: kvn Date: 2010-06-29 10:34 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/76efbe666d6c 6964774: Adjust optimization flags setting Summary: Adjust performance flags settings. Reviewed-by: never, phh ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/share/vm/runtime/arguments.cpp Changeset: fcbb92a1ab3b Author: jrose Date: 2010-06-29 16:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/fcbb92a1ab3b Merge ! src/share/vm/runtime/arguments.cpp Changeset: a00567c82f02 Author: coleenp Date: 2010-06-30 11:52 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/a00567c82f02 Merge ! src/share/vm/runtime/arguments.cpp From joe.darcy at oracle.com Tue Jul 6 18:57:58 2010 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 07 Jul 2010 01:57:58 +0000 Subject: hg: jdk7/tl/jdk: 6963723: Project Coin: Retrofit more JDK classes for ARM Message-ID: <20100707015825.8F78E477E4@hg.openjdk.java.net> Changeset: 425960cef714 Author: darcy Date: 2010-07-06 18:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/425960cef714 6963723: Project Coin: Retrofit more JDK classes for ARM Reviewed-by: alanb, malenkov, prr, amenkov ! src/share/classes/java/beans/XMLDecoder.java ! src/share/classes/java/beans/XMLEncoder.java ! src/share/classes/java/io/ObjectInput.java ! src/share/classes/java/io/ObjectOutput.java ! src/share/classes/java/util/Scanner.java ! src/share/classes/javax/sound/midi/MidiDevice.java ! src/share/classes/javax/sound/midi/Receiver.java ! src/share/classes/javax/sound/midi/Transmitter.java ! src/share/classes/javax/sound/sampled/Line.java From kelly.ohair at oracle.com Wed Jul 7 10:18:44 2010 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Wed, 07 Jul 2010 17:18:44 +0000 Subject: hg: jdk7/tl/jdk: 6954517: Testcase failure tools/launcher/UnicodeTest.sh Message-ID: <20100707171905.4289B47805@hg.openjdk.java.net> Changeset: d6f8ffc3c54a Author: ohair Date: 2010-07-07 10:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d6f8ffc3c54a 6954517: Testcase failure tools/launcher/UnicodeTest.sh Reviewed-by: ksrini ! test/tools/launcher/UnicodeTest.sh From karen.kinnear at sun.com Wed Jul 7 13:39:25 2010 From: karen.kinnear at sun.com (karen.kinnear at sun.com) Date: Wed, 07 Jul 2010 20:39:25 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 2 new changesets Message-ID: <20100707203930.8D56A4780D@hg.openjdk.java.net> Changeset: bfc89697cccb Author: acorn Date: 2010-07-02 17:23 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/bfc89697cccb 6964164: MonitorInUseLists leak of contended objects Summary: fix MonitorInUseLists memory leak and MonitorBound now works Reviewed-by: chrisphi, dice ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/synchronizer.hpp ! src/share/vm/runtime/thread.hpp Changeset: 5087ecc10458 Author: acorn Date: 2010-07-07 14:12 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/5087ecc10458 Merge From mandy.chung at oracle.com Fri Jul 9 02:31:09 2010 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Fri, 09 Jul 2010 09:31:09 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 6967423: Hotspot support for modules image Message-ID: <20100709093118.E98A747868@hg.openjdk.java.net> Changeset: 0e7d2a08b605 Author: mchung Date: 2010-07-07 15:35 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/0e7d2a08b605 6967423: Hotspot support for modules image Summary: Add hotspot support for modules image Reviewed-by: acorn ! make/linux/makefiles/sa.make ! make/solaris/makefiles/sa.make ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/runtime/os.cpp From kumar.x.srinivasan at oracle.com Fri Jul 9 09:54:24 2010 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Fri, 09 Jul 2010 16:54:24 +0000 Subject: hg: jdk7/tl/jdk: 6930056: (launcher) Need to remove or build as part of test these liblibrary.so files Message-ID: <20100709165439.08BD547879@hg.openjdk.java.net> Changeset: f13e94562d84 Author: ksrini Date: 2010-07-09 09:54 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f13e94562d84 6930056: (launcher) Need to remove or build as part of test these liblibrary.so files Reviewed-by: ohair, darcy - test/tools/launcher/Makefile.SolarisRunpath - test/tools/launcher/lib/i386/lib32/lib32/liblibrary.so - test/tools/launcher/lib/i386/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib64/lib64/liblibrary.so - test/tools/launcher/lib/sparc/lib64/liblibrary.so From martinrb at google.com Fri Jul 9 19:25:36 2010 From: martinrb at google.com (martinrb at google.com) Date: Sat, 10 Jul 2010 02:25:36 +0000 Subject: hg: jdk7/tl/jdk: 6967533: Epoch bug: ExceptionInInitializerError on systems with uninitialized clock Message-ID: <20100710022555.0036F47894@hg.openjdk.java.net> Changeset: da8526047e5f Author: martin Date: 2010-07-09 18:55 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/da8526047e5f 6967533: Epoch bug: ExceptionInInitializerError on systems with uninitialized clock Summary: Remove (hopefully!) unnecessary check of currentTimeMillis Reviewed-by: dholmes Contributed-by: Jon VanAlten ! src/share/classes/java/lang/System.java From chris.hegarty at oracle.com Mon Jul 12 10:19:31 2010 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 12 Jul 2010 17:19:31 +0000 Subject: hg: jdk7/tl/jdk: 3 new changesets Message-ID: <20100712172028.D9D334792A@hg.openjdk.java.net> Changeset: a7f8f269f741 Author: chegar Date: 2010-07-12 18:13 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a7f8f269f741 6967937: Scope id no longer being set after 6931566 Reviewed-by: alanb, dsamersoff ! src/solaris/native/java/net/NetworkInterface.c ! test/java/net/Inet6Address/B6214234.java Changeset: 1371a2d5f3a8 Author: chegar Date: 2010-07-12 18:16 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1371a2d5f3a8 6967684: httpserver using a non thread-safe SimpleDateFormat Reviewed-by: michaelm ! src/share/classes/sun/net/httpserver/ExchangeImpl.java Changeset: bb0b32ffefe9 Author: chegar Date: 2010-07-12 18:18 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bb0b32ffefe9 6966846: Incorrect assertion in java.net.Inet6Address.readObject Reviewed-by: michaelm ! src/share/classes/java/net/Inet6Address.java From daniel.daugherty at oracle.com Mon Jul 12 10:21:06 2010 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Mon, 12 Jul 2010 11:21:06 -0600 Subject: [JVMTI]Run error with SetFieldModificationWatch on every field in SPECJBB2005 In-Reply-To: References: Message-ID: <4C3B4F02.6020008@oracle.com> Li jian, I'm redirecting this e-mail thread to serviceability-dev at ... as this is a JVM/TI question. hotspot-dev at ... is named by Bcc and will drop off after this e-mail... This crash appears to be using a very old version of OpenJDK6. The OpenJDK6 project is currently at B21 and this crash is from B12 (Mon Oct 27 16:16:00 EDT 2008). Can you please retry your experiment with something more recent? Dan On 7/10/2010 7:48 PM, ?? wrote: > Hi all, > I've run OpenJDK1.6 on Fedora10 with a JVMTI which watch every > field access. The field modification callback method simply return and > do nothing. But OpenJDK randomly throw a bug like this: > > /Start User Threads > started user thread for Warehouse 1 > started user thread for Warehouse 2 > started user thread for Warehouse 3 > Timing Measurement began Sun Jul 11 09:10:48 CST 2010 for 4 minutes > # > # An unexpected error has been detected by Java Runtime Environment: > # > # SIGSEGV (0xb) at pc=0x00f0ec91, pid=10295, tid=5340048 > # > # Java VM: OpenJDK Server VM (1.6.0_0-b12 mixed mode linux-x86) > # Distribution: Custom build (Mon Oct 27 16:16:00 EDT 2008) > # Problematic frame: > # V [libjvm.so+0x471c91] > # > # An error report file with more information is saved as: > # /media/_home/lijian/specjbb2005/dist/hs_err_pid10295.log > # > # If you would like to submit a bug report, please include > # instructions how to reproduce the bug and visit: > # //http://java.sun.com/webapps/bugreport/crash.jsp/ > /# > Aborted > / > Any one can help me with this internal bug? I'll be very appreciate! > / / > > Here's my JVMTI source code: > > /static void JNICALL > FieldModifyCallBack(jvmtiEnv *jvmti_env, > JNIEnv* jni_env, > jthread thread, > jmethodID method, > jlocation location, > jclass field_klass, > jobject object, > jfieldID field, > char signature_type, > jvalue new_value)/ > /{/ > / //do nothing/ > /}/ > > /static void JNICALL > ClassPrepareCallback(jvmtiEnv *jvmti_env, > JNIEnv* jni_env, > jthread thread, > jclass klass) > { > jint field_num; > jfieldID * fieldIDs; > jvmtiError error = jvmti_env->GetClassFields(klass, > &field_num, &fieldIDs);/ > / if(error != JVMTI_ERROR_NONE) > fprintf(stderr, "!!!%d\n", error); > for(int i=0; i< field_num;i++) > {/ > / error = > jvmti_env->SetFieldModificationWatch(klass,fieldIDs[i]); > if(error != JVMTI_ERROR_NONE) > fprintf(stderr, "!!!\n"); > } > error = jvmti_env->Deallocate((unsigned char*)fieldIDs); > if(error != JVMTI_ERROR_NONE) > fprintf(stderr, "!!!\n");/ > /}/ > > /JNIEXPORT jint JNICALL Agent_OnLoad(JavaVM *jvm, char *options, void > *reserved) > { > static jvmtiEnv *jvmti = NULL; > static jvmtiCapabilities capa; > jvmtiError error; > > jint ret = (jvm)->GetEnv((void **)(&jvmti), JVMTI_VERSION_1_0); > (void)memset(&capa, 0, sizeof(jvmtiCapabilities)); > capa.can_generate_field_modification_events = 1; > error = jvmti->AddCapabilities(&capa); > if(error != JVMTI_ERROR_NONE) > fprintf(stderr, "!!!\n");/ > / error = jvmti->SetEventNotificationMode(JVMTI_ENABLE, > JVMTI_EVENT_CLASS_PREPARE, (jthread)NULL); > if(error != JVMTI_ERROR_NONE) > fprintf(stderr, "!!!\n"); > error = jvmti->SetEventNotificationMode(JVMTI_ENABLE, > JVMTI_EVENT_FIELD_MODIFICATION, NULL); > if(error != JVMTI_ERROR_NONE) > fprintf(stderr, "!!!\n"); > > jvmtiEventCallbacks callbacks; > (void)memset(&callbacks, 0, sizeof(callbacks));/ > / callbacks.ClassPrepare= &ClassPrepareCallback; > callbacks.FieldModification = &FieldModifyCallBack; > error = > jvmti->SetEventCallbacks(&callbacks,(jint)sizeof(callbacks)); > if(error != JVMTI_ERROR_NONE) > fprintf(stderr, "!!!\n"); > > return JNI_OK; > } > / > /JNIEXPORT void JNICALL Agent_OnUnload(JavaVM *jvm) > {/ > / return; > }/ > > Here's my openJDK version: > > /[root at localhost dist]# java -versionjava version "1.6.0_0" > IcedTea6 1.3.1 (6b12-Fedora-10) Runtime Environment (build 1.6.0_0-b12) > OpenJDK Server VM (build 1.6.0_0-b12, mixed mode)/ > // > The attachment is /hs_err_pid10295.log/ > > > Thanks a lot! > -- > Li jian > China From kumar.x.srinivasan at oracle.com Mon Jul 12 15:37:45 2010 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Mon, 12 Jul 2010 22:37:45 +0000 Subject: hg: jdk7/tl/jdk: 6921472: RFE: java launcher code needs clean up Message-ID: <20100712223755.DE00747937@hg.openjdk.java.net> Changeset: d3fa95d0710c Author: ksrini Date: 2010-07-09 11:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d3fa95d0710c 6921472: RFE: java launcher code needs clean up Summary: This changeset also contains fixes for 6405284, 6753938 and 6922500 Reviewed-by: darcy ! src/share/bin/emessages.h ! src/share/bin/java.c ! src/share/bin/java.h ! src/share/bin/jli_util.c ! src/share/bin/jli_util.h ! src/solaris/bin/java_md.c ! src/windows/bin/java_md.c ! test/tools/launcher/Arrrghs.java From daniel.daugherty at oracle.com Mon Jul 12 15:52:42 2010 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Mon, 12 Jul 2010 22:52:42 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20100712225301.AA47C47939@hg.openjdk.java.net> Changeset: ddf825161d2d Author: dcubed Date: 2010-07-12 14:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ddf825161d2d 6968401: 3/3 disable tests added by 6942989 until 6964018 is fixed Summary: Disable AnonLoggerWeakRefLeak.sh and LoggerWeakRefLeak.sh Reviewed-by: ohair ! test/java/util/logging/AnonLoggerWeakRefLeak.sh ! test/java/util/logging/LoggerWeakRefLeak.sh Changeset: 4e365ef6576d Author: dcubed Date: 2010-07-12 15:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4e365ef6576d Merge From jonathan.gibbons at oracle.com Mon Jul 12 16:38:23 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 12 Jul 2010 23:38:23 +0000 Subject: hg: jdk7/tl/langtools: 6968497: localized text appears in raw diagnostic Message-ID: <20100712233826.BAF114793B@hg.openjdk.java.net> Changeset: 064468702a8d Author: jjg Date: 2010-07-12 16:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/064468702a8d 6968497: localized text appears in raw diagnostic Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/comp/Check.java ! test/tools/javac/generics/6946618/T6946618c.java ! test/tools/javac/generics/6946618/T6946618c.out From dmitry.samersoff at sun.com Tue Jul 13 04:36:55 2010 From: dmitry.samersoff at sun.com (dmitry.samersoff at sun.com) Date: Tue, 13 Jul 2010 11:36:55 +0000 Subject: hg: jdk7/tl/jdk: 6964714: NetworkInterface getInetAddresses enumerates IPv6 addresses if java.net.preferIPvStack property set Message-ID: <20100713113711.343AB47956@hg.openjdk.java.net> Changeset: 25050030a320 Author: dsamersoff Date: 2010-07-13 15:32 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/25050030a320 6964714: NetworkInterface getInetAddresses enumerates IPv6 addresses if java.net.preferIPvStack property set Summary: User can disable ipv6 explicitly, have to check it Reviewed-by: chegar, alanb ! src/solaris/native/java/net/NetworkInterface.c + test/java/net/NetworkInterface/IPv4Only.java From weijun.wang at sun.com Tue Jul 13 05:27:38 2010 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Tue, 13 Jul 2010 12:27:38 +0000 Subject: hg: jdk7/tl/jdk: 6670889: Keystore created under Hindi Locale causing ArrayIndexOutOfBoundsException Message-ID: <20100713122748.2DCF547958@hg.openjdk.java.net> Changeset: f3a4c1947fd1 Author: weijun Date: 2010-07-13 20:27 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f3a4c1947fd1 6670889: Keystore created under Hindi Locale causing ArrayIndexOutOfBoundsException Reviewed-by: chegar ! src/share/classes/sun/security/util/DerOutputStream.java + test/sun/security/util/DerOutputStream/LocaleInTime.java From jonathan.gibbons at oracle.com Tue Jul 13 19:14:41 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 14 Jul 2010 02:14:41 +0000 Subject: hg: jdk7/tl/langtools: 6966732: replace use of static Log.getLocalizedString with non-static alternative where possible Message-ID: <20100714021442.CA9D247978@hg.openjdk.java.net> Changeset: a5454419dd46 Author: jjg Date: 2010-07-13 19:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a5454419dd46 6966732: replace use of static Log.getLocalizedString with non-static alternative where possible Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/Log.java From jonathan.gibbons at oracle.com Tue Jul 13 19:18:15 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 14 Jul 2010 02:18:15 +0000 Subject: hg: jdk7/tl/langtools: 6968434: test CheckResourceKeys fails on control builds Message-ID: <20100714021816.EDD5B47979@hg.openjdk.java.net> Changeset: 0e1fab5cffc8 Author: jjg Date: 2010-07-13 19:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/0e1fab5cffc8 6968434: test CheckResourceKeys fails on control builds Reviewed-by: darcy ! test/tools/javac/diags/CheckResourceKeys.java From jonathan.gibbons at oracle.com Tue Jul 13 19:21:30 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 14 Jul 2010 02:21:30 +0000 Subject: hg: jdk7/tl/langtools: 6968789: incorrect text in "diamond not supported" message Message-ID: <20100714022131.C8DAA4797A@hg.openjdk.java.net> Changeset: e57b27703e8b Author: jjg Date: 2010-07-13 19:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e57b27703e8b 6968789: incorrect text in "diamond not supported" message Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/resources/compiler.properties From Alan.Bateman at oracle.com Wed Jul 14 07:38:26 2010 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 14 Jul 2010 15:38:26 +0100 Subject: 6649594: Intermittent IOExceptions during dynamic attach on linux and solaris Message-ID: <4C3DCBE2.4050801@oracle.com> This is a long standing bug in the attach mechanism on Solaris and Linux that causes intermittent failures for some tests. The bug is that, on first attempt to attach, the client can observe the file to which the door descriptor is attached or the socket file before initialization is complete. The proposed fix removes the timing issue by renaming the file into place after initialization. Some minor clean-up while I was in the area. The webrev is here: http://cr.openjdk.java.net/~alanb/6649594/webrev/ Dan or Karen - one thing I wasn't sure about is whether to emit a warning when the attach listener can't start or should warnings be debug_only? -Alan. From daniel.daugherty at oracle.com Wed Jul 14 17:29:41 2010 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Wed, 14 Jul 2010 18:29:41 -0600 Subject: 6649594: Intermittent IOExceptions during dynamic attach on linux and solaris In-Reply-To: <4C3DCBE2.4050801@oracle.com> References: <4C3DCBE2.4050801@oracle.com> Message-ID: <4C3E5675.3090909@oracle.com> On 7/14/2010 8:38 AM, Alan Bateman wrote: > > This is a long standing bug in the attach mechanism on Solaris and > Linux that causes intermittent failures for some tests. The bug is > that, on first attempt to attach, the client can observe the file to > which the door descriptor is attached or the socket file before > initialization is complete. The proposed fix removes the timing issue > by renaming the file into place after initialization. Some minor > clean-up while I was in the area. The webrev is here: > http://cr.openjdk.java.net/~alanb/6649594/webrev/ > > Dan or Karen - one thing I wasn't sure about is whether to emit a > warning when the attach listener can't start or should warnings be > debug_only? > > -Alan. src/os/linux/vm/attachListener_linux.cpp The addition of UNIX_PATH_MAX means that the size of the buffer on line 61: static char _path[PATH_MAX+1] is now or can be potentially out of sync with the size of the buffer on line 170 char path[UNIX_PATH_MAX] If UNIX_PATH_MAX happens to be greater than PATH_MAX, and the path to the socket is actually longer than PATH_MAX, then we'll store a short path in the buffer on line 61. Is there some reason not to use the new UNIX_PATH_MAX in both locations? src/os/solaris/vm/attachListener_solaris.cpp The return values from snprintf() aren't checked here for potential overflow conditions. It seems to me that the Solaris logic could benefit from the same sanity checks that you make in the Linux version. I would keep the warnings debug only. I see you have a debug only warning in the Solaris code, but no warning in the Linux code. Or were you talking about a different warning? Dan From Alan.Bateman at oracle.com Thu Jul 15 03:03:27 2010 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 15 Jul 2010 11:03:27 +0100 Subject: 6649594: Intermittent IOExceptions during dynamic attach on linux and solaris In-Reply-To: <4C3E5675.3090909@oracle.com> References: <4C3DCBE2.4050801@oracle.com> <4C3E5675.3090909@oracle.com> Message-ID: <4C3EDCEF.6080601@oracle.com> Daniel D. Daugherty wrote: > : > src/os/linux/vm/attachListener_linux.cpp > The addition of UNIX_PATH_MAX means that the size of the buffer > on line 61: static char _path[PATH_MAX+1] > is now or can be potentially out of sync with the size of the > buffer on line 170 char path[UNIX_PATH_MAX] > > If UNIX_PATH_MAX happens to be greater than PATH_MAX, and the > path to the socket is actually longer than PATH_MAX, then we'll > store a short path in the buffer on line 61. > > Is there some reason not to use the new UNIX_PATH_MAX in both > locations? Thanks Dan, I missed that one although it shouldn't cause a problem (as UNIX_PATH_MAX (108) will be less than PATH_MAX (usually 4096)). > > src/os/solaris/vm/attachListener_solaris.cpp > The return values from snprintf() aren't checked here for potential > overflow conditions. It seems to me that the Solaris logic could > benefit from the same sanity checks that you make in the Linux > version. I didn't change or add this as it didn't seem likely that we would be started with java.io.tmpdir property set to a location that is close to the maximum path length. I suspect other things (like File.createTempFile) would also have problems if java.io.tmpdir were set this way. It is easily fixed to check for truncation, if you think it is important. The reason I added the check for truncation in the Linux implementation is because it's a path to a socket file. > > I would keep the warnings debug only. I see you have a debug only > warning in the Solaris code, but no warning in the Linux code. Or > were you talking about a different warning? I was wondering if I should additional warnings into this code, and if so, if they should be in the product build. I know warning messages can cause products when intermingled with application output. -Alan. From maurizio.cimadamore at oracle.com Thu Jul 15 08:46:07 2010 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 15 Jul 2010 15:46:07 +0000 Subject: hg: jdk7/tl/langtools: 2 new changesets Message-ID: <20100715154610.E9BD7479E1@hg.openjdk.java.net> Changeset: b49b0d72c071 Author: mcimadamore Date: 2010-07-15 16:31 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b49b0d72c071 6967002: JDK7 b99 javac compilation error (java.lang.AssertionError) Summary: bug in JavacParser related to parsing of type annotations in varargs position Reviewed-by: jjg Contributed-by: mahmood at notnoop.com ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/typeAnnotations/6967002/T6967002.java + test/tools/javac/typeAnnotations/6967002/T6967002.out Changeset: 472e74211e11 Author: mcimadamore Date: 2010-07-15 16:31 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/472e74211e11 6964669: javac reports error on miranda methods Summary: synthetic name clash check should not apply to miranda methods Reviewed-by: jjg Contributed-by: tomas.zezula at sun.com ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/miranda/6964669/T6964669.java + test/tools/javac/miranda/6964669/pkg/A.java + test/tools/javac/miranda/6964669/pkg/B.java + test/tools/javac/miranda/6964669/pkg/C.java From daniel.daugherty at oracle.com Thu Jul 15 13:41:01 2010 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 15 Jul 2010 14:41:01 -0600 Subject: 6649594: Intermittent IOExceptions during dynamic attach on linux and solaris In-Reply-To: <4C3EDCEF.6080601@oracle.com> References: <4C3DCBE2.4050801@oracle.com> <4C3E5675.3090909@oracle.com> <4C3EDCEF.6080601@oracle.com> Message-ID: <4C3F725D.1050608@oracle.com> On 7/15/2010 4:03 AM, Alan Bateman wrote: > Daniel D. Daugherty wrote: >> : >> src/os/linux/vm/attachListener_linux.cpp >> The addition of UNIX_PATH_MAX means that the size of the buffer >> on line 61: static char _path[PATH_MAX+1] >> is now or can be potentially out of sync with the size of the >> buffer on line 170 char path[UNIX_PATH_MAX] >> >> If UNIX_PATH_MAX happens to be greater than PATH_MAX, and the >> path to the socket is actually longer than PATH_MAX, then we'll >> store a short path in the buffer on line 61. >> >> Is there some reason not to use the new UNIX_PATH_MAX in both >> locations? > Thanks Dan, I missed that one although it shouldn't cause a problem > (as UNIX_PATH_MAX (108) will be less than PATH_MAX (usually 4096)). Your choice on how to resolve this one. > >> >> src/os/solaris/vm/attachListener_solaris.cpp >> The return values from snprintf() aren't checked here for potential >> overflow conditions. It seems to me that the Solaris logic could >> benefit from the same sanity checks that you make in the Linux >> version. > I didn't change or add this as it didn't seem likely that we would be > started with java.io.tmpdir property set to a location that is close > to the maximum path length. I suspect other things (like > File.createTempFile) would also have problems if java.io.tmpdir were > set this way. It is easily fixed to check for truncation, if you think > it is important. The reason I added the check for truncation in the > Linux implementation is because it's a path to a socket file. And it's a much shorter path. I would be happier if we had a truncation check, but I'm okay if we don't. > >> >> I would keep the warnings debug only. I see you have a debug only >> warning in the Solaris code, but no warning in the Linux code. Or >> were you talking about a different warning? > I was wondering if I should additional warnings into this code, and if > so, if they should be in the product build. I know warning messages > can cause products when intermingled with application output. Is there a TraceAttachOnDemand flag? If there is, then I would be okay if the product bits output a message when that option is enabled. Otherwise, I would just make it debug only. Dan From joe.darcy at oracle.com Thu Jul 15 18:03:16 2010 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 16 Jul 2010 01:03:16 +0000 Subject: hg: jdk7/tl/jdk: 6963622: Project Coin: Refinements to suppressed exceptions Message-ID: <20100716010326.819AA479F8@hg.openjdk.java.net> Changeset: ab65f46ae092 Author: darcy Date: 2010-07-15 18:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ab65f46ae092 6963622: Project Coin: Refinements to suppressed exceptions Reviewed-by: alanb, forax, jjb ! src/share/classes/java/lang/AutoCloseable.java ! src/share/classes/java/lang/Throwable.java ! test/java/lang/Throwable/SuppressedExceptions.java From Alan.Bateman at oracle.com Thu Jul 15 23:50:13 2010 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 16 Jul 2010 07:50:13 +0100 Subject: 6649594: Intermittent IOExceptions during dynamic attach on linux and solaris In-Reply-To: <4C3F725D.1050608@oracle.com> References: <4C3DCBE2.4050801@oracle.com> <4C3E5675.3090909@oracle.com> <4C3EDCEF.6080601@oracle.com> <4C3F725D.1050608@oracle.com> Message-ID: <4C400125.3020709@oracle.com> Daniel D. Daugherty wrote: > : > Your choice on how to resolve this one. Here's the updated webrev with the changes that I proposed to push for this one: http://cr.openjdk.java.net/~alanb/6649594/webrev.01/ Your suggestion to add a trace flag to help diagnose startup issues is good. I'll create a bug to track that rather than squeezing it into this change. -Alan. From daniel.daugherty at oracle.com Thu Jul 15 23:52:57 2010 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Fri, 16 Jul 2010 00:52:57 -0600 Subject: 6649594: Intermittent IOExceptions during dynamic attach on linux and solaris In-Reply-To: <4C400125.3020709@oracle.com> References: <4C3DCBE2.4050801@oracle.com> <4C3E5675.3090909@oracle.com> <4C3EDCEF.6080601@oracle.com> <4C3F725D.1050608@oracle.com> <4C400125.3020709@oracle.com> Message-ID: <4C4001C9.5020202@oracle.com> On 7/16/2010 12:50 AM, Alan Bateman wrote: > Daniel D. Daugherty wrote: >> : >> Your choice on how to resolve this one. > Here's the updated webrev with the changes that I proposed to push for > this one: > http://cr.openjdk.java.net/~alanb/6649594/webrev.01/ Thumbs up on the revised fix. > Your suggestion to add a trace flag to help diagnose startup issues is > good. I'll create a bug to track that rather than squeezing it into > this change. Sounds good to me. Dan From David.Holmes at oracle.com Fri Jul 16 00:08:35 2010 From: David.Holmes at oracle.com (David Holmes) Date: Fri, 16 Jul 2010 17:08:35 +1000 Subject: 6649594: Intermittent IOExceptions during dynamic attach on linux and solaris In-Reply-To: <4C400125.3020709@oracle.com> References: <4C3DCBE2.4050801@oracle.com> <4C3E5675.3090909@oracle.com> <4C3EDCEF.6080601@oracle.com> <4C3F725D.1050608@oracle.com> <4C400125.3020709@oracle.com> Message-ID: <4C400573.8020705@oracle.com> Alan Bateman said the following on 07/16/10 16:50: > Daniel D. Daugherty wrote: >> : >> Your choice on how to resolve this one. > Here's the updated webrev with the changes that I proposed to push for > this one: > http://cr.openjdk.java.net/~alanb/6649594/webrev.01/ > > Your suggestion to add a trace flag to help diagnose startup issues is > good. I'll create a bug to track that rather than squeezing it into this > change. Not to delay this but ... why replace the always safe strncpy with an unsafe strcpy protected by an assert ??? I though we were moving to always safe code to get past code-checkers etc. And out of curiousity where does this new UNIX_MAX_PATH come from (and if it is UNIX then why isn't used on Solaris rather than Linux ;-) ) David From Alan.Bateman at oracle.com Fri Jul 16 00:28:59 2010 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 16 Jul 2010 08:28:59 +0100 Subject: 6649594: Intermittent IOExceptions during dynamic attach on linux and solaris In-Reply-To: <4C400573.8020705@oracle.com> References: <4C3DCBE2.4050801@oracle.com> <4C3E5675.3090909@oracle.com> <4C3EDCEF.6080601@oracle.com> <4C3F725D.1050608@oracle.com> <4C400125.3020709@oracle.com> <4C400573.8020705@oracle.com> Message-ID: <4C400A3B.1010101@oracle.com> David Holmes wrote: > : > Not to delay this but ... why replace the always safe strncpy with an > unsafe strcpy protected by an assert ??? I though we were moving to > always safe code to get past code-checkers etc. > > And out of curiousity where does this new UNIX_MAX_PATH come from (and > if it is UNIX then why isn't used on Solaris rather than Linux ;-) ) When you bind a Unix domain socket then you (usually) specify a path so that clients can locate it via the file system. This path is specified in the sun_path field and is limited to UNIX_PATH_MAX (including nul terminator). The original code PATH_MAX, which didn't really matter until it was changed recently to use the temporary directory specified by the java.io.tmpdir property. The reason that it's not in the Solaris implementation is because it's not using Unix domain sockets. As regards the strcpy, the length has already been checked but you are probably right and I should leave that as a strncpy. -Alan. From alan.bateman at oracle.com Fri Jul 16 08:34:33 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 16 Jul 2010 15:34:33 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 6649594: Intermittent IOExceptions during dynamic attach on linux and solaris Message-ID: <20100716153442.3994947A2C@hg.openjdk.java.net> Changeset: a81afd9c293c Author: alanb Date: 2010-07-16 13:14 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/a81afd9c293c 6649594: Intermittent IOExceptions during dynamic attach on linux and solaris Reviewed-by: dcubed, dholmes ! src/os/linux/vm/attachListener_linux.cpp ! src/os/solaris/vm/attachListener_solaris.cpp From john.coomes at oracle.com Fri Jul 16 11:35:26 2010 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 16 Jul 2010 18:35:26 +0000 Subject: hg: jdk7/hotspot-rt: Added tag jdk7-b100 for changeset b218a53ec7d3 Message-ID: <20100716183526.6E0E247A35@hg.openjdk.java.net> Changeset: 4193eaf5f1b8 Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/rev/4193eaf5f1b8 Added tag jdk7-b100 for changeset b218a53ec7d3 ! .hgtags From john.coomes at oracle.com Fri Jul 16 11:35:30 2010 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 16 Jul 2010 18:35:30 +0000 Subject: hg: jdk7/hotspot-rt/corba: Added tag jdk7-b100 for changeset a56d734a1e97 Message-ID: <20100716183533.A955B47A36@hg.openjdk.java.net> Changeset: 86a239832646 Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/corba/rev/86a239832646 Added tag jdk7-b100 for changeset a56d734a1e97 ! .hgtags From john.coomes at oracle.com Fri Jul 16 11:54:52 2010 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 16 Jul 2010 18:54:52 +0000 Subject: hg: jdk7/hotspot-rt/jaxp: Added tag jdk7-b100 for changeset d524be5ef62e Message-ID: <20100716185452.5546B47A37@hg.openjdk.java.net> Changeset: 17f62a566a20 Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxp/rev/17f62a566a20 Added tag jdk7-b100 for changeset d524be5ef62e ! .hgtags From john.coomes at oracle.com Fri Jul 16 11:54:56 2010 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 16 Jul 2010 18:54:56 +0000 Subject: hg: jdk7/hotspot-rt/jaxws: Added tag jdk7-b100 for changeset bd26d0ce0c3c Message-ID: <20100716185456.B5F2247A38@hg.openjdk.java.net> Changeset: b55ce2744900 Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxws/rev/b55ce2744900 Added tag jdk7-b100 for changeset bd26d0ce0c3c ! .hgtags From john.coomes at oracle.com Fri Jul 16 11:55:07 2010 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 16 Jul 2010 18:55:07 +0000 Subject: hg: jdk7/hotspot-rt/jdk: 3 new changesets Message-ID: <20100716185644.2FEDD47A39@hg.openjdk.java.net> Changeset: 820b4e843d51 Author: ohair Date: 2010-07-07 10:21 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/820b4e843d51 6967036: Need to fix links with // in Javadoc comments Reviewed-by: mchung ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/Base64.java ! src/share/classes/com/sun/security/auth/LdapPrincipal.java ! src/share/classes/com/sun/security/sasl/CramMD5Client.java ! src/share/classes/com/sun/security/sasl/CramMD5Server.java ! src/share/classes/com/sun/security/sasl/ExternalClient.java ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Client.java ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Server.java ! src/share/classes/java/net/URI.java ! src/share/classes/java/nio/charset/package.html ! src/share/classes/javax/management/remote/JMXServiceURL.java ! src/share/classes/javax/naming/ldap/LdapName.java ! src/share/classes/javax/naming/ldap/Rdn.java ! src/share/classes/javax/net/ssl/SSLContext.java ! src/share/classes/javax/print/DocFlavor.java ! src/share/classes/sun/awt/image/PNGImageDecoder.java Changeset: 93c4e6d14010 Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/93c4e6d14010 Added tag jdk7-b100 for changeset 820b4e843d51 ! .hgtags Changeset: d58354a69011 Author: bpatel Date: 2010-07-14 15:42 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/d58354a69011 6955341: Oracle rebranding changes for man pages Reviewed-by: darcy ! src/linux/doc/man/appletviewer.1 ! src/linux/doc/man/apt.1 ! src/linux/doc/man/extcheck.1 ! src/linux/doc/man/idlj.1 ! src/linux/doc/man/ja/appletviewer.1 ! src/linux/doc/man/ja/apt.1 ! src/linux/doc/man/ja/extcheck.1 ! src/linux/doc/man/ja/idlj.1 ! src/linux/doc/man/ja/jar.1 ! src/linux/doc/man/ja/jarsigner.1 ! src/linux/doc/man/ja/java.1 ! src/linux/doc/man/ja/javac.1 ! src/linux/doc/man/ja/javadoc.1 ! src/linux/doc/man/ja/javah.1 ! src/linux/doc/man/ja/javap.1 ! src/linux/doc/man/ja/javaws.1 ! src/linux/doc/man/ja/jconsole.1 ! src/linux/doc/man/ja/jdb.1 ! src/linux/doc/man/ja/jhat.1 ! src/linux/doc/man/ja/jinfo.1 ! src/linux/doc/man/ja/jmap.1 ! src/linux/doc/man/ja/jps.1 ! src/linux/doc/man/ja/jrunscript.1 ! src/linux/doc/man/ja/jsadebugd.1 ! src/linux/doc/man/ja/jstack.1 ! src/linux/doc/man/ja/jstat.1 ! src/linux/doc/man/ja/jstatd.1 ! src/linux/doc/man/ja/keytool.1 - src/linux/doc/man/ja/kinit.1 - src/linux/doc/man/ja/klist.1 - src/linux/doc/man/ja/ktab.1 ! src/linux/doc/man/ja/native2ascii.1 ! src/linux/doc/man/ja/orbd.1 ! src/linux/doc/man/ja/pack200.1 ! src/linux/doc/man/ja/policytool.1 ! src/linux/doc/man/ja/rmic.1 ! src/linux/doc/man/ja/rmid.1 ! src/linux/doc/man/ja/rmiregistry.1 ! src/linux/doc/man/ja/schemagen.1 ! src/linux/doc/man/ja/serialver.1 ! src/linux/doc/man/ja/servertool.1 ! src/linux/doc/man/ja/tnameserv.1 ! src/linux/doc/man/ja/unpack200.1 ! src/linux/doc/man/ja/wsgen.1 ! src/linux/doc/man/ja/wsimport.1 ! src/linux/doc/man/ja/xjc.1 ! src/linux/doc/man/jar.1 ! src/linux/doc/man/jarsigner.1 ! src/linux/doc/man/java.1 ! src/linux/doc/man/javac.1 ! src/linux/doc/man/javadoc.1 ! src/linux/doc/man/javah.1 ! src/linux/doc/man/javap.1 ! src/linux/doc/man/javaws.1 ! src/linux/doc/man/jconsole.1 ! src/linux/doc/man/jdb.1 ! src/linux/doc/man/jhat.1 ! src/linux/doc/man/jinfo.1 ! src/linux/doc/man/jmap.1 ! src/linux/doc/man/jps.1 ! src/linux/doc/man/jrunscript.1 ! src/linux/doc/man/jsadebugd.1 ! src/linux/doc/man/jstack.1 ! src/linux/doc/man/jstat.1 ! src/linux/doc/man/jstatd.1 ! src/linux/doc/man/keytool.1 ! src/linux/doc/man/native2ascii.1 ! src/linux/doc/man/orbd.1 ! src/linux/doc/man/pack200.1 ! src/linux/doc/man/policytool.1 ! src/linux/doc/man/rmic.1 ! src/linux/doc/man/rmid.1 ! src/linux/doc/man/rmiregistry.1 ! src/linux/doc/man/schemagen.1 ! src/linux/doc/man/serialver.1 ! src/linux/doc/man/servertool.1 ! src/linux/doc/man/tnameserv.1 ! src/linux/doc/man/unpack200.1 ! src/linux/doc/man/wsgen.1 ! src/linux/doc/man/wsimport.1 ! src/linux/doc/man/xjc.1 ! src/solaris/doc/sun/man/man1/appletviewer.1 ! src/solaris/doc/sun/man/man1/apt.1 ! src/solaris/doc/sun/man/man1/extcheck.1 ! src/solaris/doc/sun/man/man1/idlj.1 ! src/solaris/doc/sun/man/man1/ja/appletviewer.1 ! src/solaris/doc/sun/man/man1/ja/apt.1 ! src/solaris/doc/sun/man/man1/ja/extcheck.1 ! src/solaris/doc/sun/man/man1/ja/idlj.1 ! src/solaris/doc/sun/man/man1/ja/jar.1 ! src/solaris/doc/sun/man/man1/ja/jarsigner.1 ! src/solaris/doc/sun/man/man1/ja/java.1 ! src/solaris/doc/sun/man/man1/ja/javac.1 ! src/solaris/doc/sun/man/man1/ja/javadoc.1 ! src/solaris/doc/sun/man/man1/ja/javah.1 ! src/solaris/doc/sun/man/man1/ja/javap.1 ! src/solaris/doc/sun/man/man1/ja/javaws.1 ! src/solaris/doc/sun/man/man1/ja/jconsole.1 ! src/solaris/doc/sun/man/man1/ja/jdb.1 ! src/solaris/doc/sun/man/man1/ja/jhat.1 ! src/solaris/doc/sun/man/man1/ja/jinfo.1 ! src/solaris/doc/sun/man/man1/ja/jmap.1 ! src/solaris/doc/sun/man/man1/ja/jps.1 ! src/solaris/doc/sun/man/man1/ja/jrunscript.1 ! src/solaris/doc/sun/man/man1/ja/jsadebugd.1 ! src/solaris/doc/sun/man/man1/ja/jstack.1 ! src/solaris/doc/sun/man/man1/ja/jstat.1 ! src/solaris/doc/sun/man/man1/ja/jstatd.1 ! src/solaris/doc/sun/man/man1/ja/keytool.1 ! src/solaris/doc/sun/man/man1/ja/native2ascii.1 ! src/solaris/doc/sun/man/man1/ja/orbd.1 ! src/solaris/doc/sun/man/man1/ja/pack200.1 ! src/solaris/doc/sun/man/man1/ja/policytool.1 ! src/solaris/doc/sun/man/man1/ja/rmic.1 ! src/solaris/doc/sun/man/man1/ja/rmid.1 ! src/solaris/doc/sun/man/man1/ja/rmiregistry.1 ! src/solaris/doc/sun/man/man1/ja/schemagen.1 ! src/solaris/doc/sun/man/man1/ja/serialver.1 ! src/solaris/doc/sun/man/man1/ja/servertool.1 ! src/solaris/doc/sun/man/man1/ja/tnameserv.1 ! src/solaris/doc/sun/man/man1/ja/unpack200.1 ! src/solaris/doc/sun/man/man1/ja/wsgen.1 ! src/solaris/doc/sun/man/man1/ja/wsimport.1 ! src/solaris/doc/sun/man/man1/ja/xjc.1 ! src/solaris/doc/sun/man/man1/jar.1 ! src/solaris/doc/sun/man/man1/jarsigner.1 ! src/solaris/doc/sun/man/man1/java.1 ! src/solaris/doc/sun/man/man1/javac.1 ! src/solaris/doc/sun/man/man1/javadoc.1 ! src/solaris/doc/sun/man/man1/javah.1 ! src/solaris/doc/sun/man/man1/javap.1 ! src/solaris/doc/sun/man/man1/javaws.1 ! src/solaris/doc/sun/man/man1/jconsole.1 ! src/solaris/doc/sun/man/man1/jdb.1 ! src/solaris/doc/sun/man/man1/jhat.1 ! src/solaris/doc/sun/man/man1/jinfo.1 ! src/solaris/doc/sun/man/man1/jmap.1 ! src/solaris/doc/sun/man/man1/jps.1 ! src/solaris/doc/sun/man/man1/jrunscript.1 ! src/solaris/doc/sun/man/man1/jsadebugd.1 ! src/solaris/doc/sun/man/man1/jstack.1 ! src/solaris/doc/sun/man/man1/jstat.1 ! src/solaris/doc/sun/man/man1/jstatd.1 ! src/solaris/doc/sun/man/man1/keytool.1 ! src/solaris/doc/sun/man/man1/native2ascii.1 ! src/solaris/doc/sun/man/man1/orbd.1 ! src/solaris/doc/sun/man/man1/pack200.1 ! src/solaris/doc/sun/man/man1/policytool.1 ! src/solaris/doc/sun/man/man1/rmic.1 ! src/solaris/doc/sun/man/man1/rmid.1 ! src/solaris/doc/sun/man/man1/rmiregistry.1 ! src/solaris/doc/sun/man/man1/schemagen.1 ! src/solaris/doc/sun/man/man1/serialver.1 ! src/solaris/doc/sun/man/man1/servertool.1 ! src/solaris/doc/sun/man/man1/tnameserv.1 ! src/solaris/doc/sun/man/man1/unpack200.1 ! src/solaris/doc/sun/man/man1/wsgen.1 ! src/solaris/doc/sun/man/man1/wsimport.1 ! src/solaris/doc/sun/man/man1/xjc.1 From john.coomes at oracle.com Fri Jul 16 12:08:38 2010 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 16 Jul 2010 19:08:38 +0000 Subject: hg: jdk7/hotspot-rt/langtools: Added tag jdk7-b100 for changeset d1d7595fa824 Message-ID: <20100716190845.9AF5047A3B@hg.openjdk.java.net> Changeset: 20a8fe72ee7b Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/20a8fe72ee7b Added tag jdk7-b100 for changeset d1d7595fa824 ! .hgtags From xueming.shen at oracle.com Fri Jul 16 13:49:30 2010 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Fri, 16 Jul 2010 20:49:30 +0000 Subject: hg: jdk7/tl/jdk: 6964313: Find sun/nio/cs/ext issue with CreateSymbols, then move sun/nio/cs/ext to charset.jar Message-ID: <20100716204952.8A78847A40@hg.openjdk.java.net> Changeset: a3747592bdf7 Author: sherman Date: 2010-07-16 16:45 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a3747592bdf7 6964313: Find sun/nio/cs/ext issue with CreateSymbols, then move sun/nio/cs/ext to charset.jar Summary: Removed the duplicate sun.nio.cs.ext entries from rt.jar and moved X11 charsets into charsets.jar Reviewed-by: ohair ! make/common/Release.gmk ! make/sun/nio/cs/Makefile From joe.darcy at oracle.com Fri Jul 16 19:34:40 2010 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Sat, 17 Jul 2010 02:34:40 +0000 Subject: hg: jdk7/tl/langtools: 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler; ... Message-ID: <20100717023447.0088E47A51@hg.openjdk.java.net> Changeset: 13354e1abba7 Author: darcy Date: 2010-07-16 19:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/13354e1abba7 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler 6964740: Project Coin: More tests for ARM compiler changes 6965277: Project Coin: Correctness issues in ARM implementation 6967065: add -Xlint warning category for Automatic Resource Management (ARM) Reviewed-by: jjb, darcy, mcimadamore, jjg, briangoetz Contributed-by: tball at google.com ! make/build.properties ! src/share/classes/com/sun/source/tree/TryTree.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/CRTable.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! src/share/classes/com/sun/tools/javac/util/Names.java + test/tools/javac/TryWithResources/ArmLint.java + test/tools/javac/TryWithResources/ArmLint.out + test/tools/javac/TryWithResources/BadTwr.java + test/tools/javac/TryWithResources/BadTwr.out + test/tools/javac/TryWithResources/BadTwrSyntax.java + test/tools/javac/TryWithResources/BadTwrSyntax.out + test/tools/javac/TryWithResources/DuplicateResource.java + test/tools/javac/TryWithResources/DuplicateResourceDecl.java + test/tools/javac/TryWithResources/DuplicateResourceDecl.out + test/tools/javac/TryWithResources/ImplicitFinal.java + test/tools/javac/TryWithResources/ImplicitFinal.out + test/tools/javac/TryWithResources/PlainTry.java + test/tools/javac/TryWithResources/PlainTry.out + test/tools/javac/TryWithResources/PlainTry6.out + test/tools/javac/TryWithResources/ResourceOutsideTry.java + test/tools/javac/TryWithResources/ResourceOutsideTry.out + test/tools/javac/TryWithResources/ResourceTypeVar.java + test/tools/javac/TryWithResources/TwrFlow.java + test/tools/javac/TryWithResources/TwrFlow.out + test/tools/javac/TryWithResources/TwrInference.java + test/tools/javac/TryWithResources/TwrIntersection.java + test/tools/javac/TryWithResources/TwrIntersection02.java + test/tools/javac/TryWithResources/TwrIntersection02.out + test/tools/javac/TryWithResources/TwrMultiCatch.java + test/tools/javac/TryWithResources/TwrOnNonResource.java + test/tools/javac/TryWithResources/TwrOnNonResource.out + test/tools/javac/TryWithResources/TwrTests.java + test/tools/javac/TryWithResources/WeirdTwr.java + test/tools/javac/processing/model/element/TestResourceVariable.java From andrei.pangin at sun.com Sun Jul 18 01:38:15 2010 From: andrei.pangin at sun.com (andrei.pangin at sun.com) Date: Sun, 18 Jul 2010 08:38:15 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 14 new changesets Message-ID: <20100718083840.B228247AA7@hg.openjdk.java.net> Changeset: 65b0c03b165d Author: never Date: 2010-07-02 15:01 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/65b0c03b165d 6965671: fatal error: acquiring lock JNIGlobalHandle_lock/16 out of order with lock CodeCache_lock/1 Reviewed-by: kvn, dcubed ! src/share/vm/prims/jvmtiCodeBlobEvents.cpp Changeset: 60a14ad85270 Author: kvn Date: 2010-07-02 17:30 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/60a14ad85270 6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP Summary: Execute IGVN optimization before and after Escape Analysis Reviewed-by: never ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp Changeset: a693e51ac197 Author: never Date: 2010-07-07 12:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/a693e51ac197 Merge Changeset: b2a00dd3117c Author: jcoomes Date: 2010-07-01 21:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/b2a00dd3117c 6957084: simplify TaskQueue overflow handling Reviewed-by: ysr, jmasa ! src/share/vm/gc_implementation/includeDB_gc_parallelScavenge ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/utilities/taskqueue.cpp ! src/share/vm/utilities/taskqueue.hpp Changeset: 9ee05c8ab82f Author: ysr Date: 2010-07-12 12:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/9ee05c8ab82f Merge Changeset: 1e7ec26380bd Author: apangin Date: 2010-07-14 17:52 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/1e7ec26380bd Merge Changeset: 2a47bd84841f Author: never Date: 2010-07-08 14:29 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/2a47bd84841f 6965184: possible races in make_not_entrant_or_zombie Reviewed-by: kvn ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java - src/os/linux/vm/vtune_linux.cpp - src/os/solaris/vm/vtune_solaris.cpp - src/os/windows/vm/vtune_windows.cpp ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/code/codeBlob.cpp ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/code/vtableStubs.cpp ! src/share/vm/includeDB_core ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/init.cpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/stubCodeGenerator.cpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp ! src/share/vm/runtime/vmStructs.cpp - src/share/vm/runtime/vtune.hpp Changeset: 3941674cc7fa Author: never Date: 2010-07-12 10:58 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/3941674cc7fa 6958668: repeated uncommon trapping for new of klass which is being initialized Reviewed-by: kvn, jrose ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciInstanceKlass.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parseHelper.cpp Changeset: 8d5934a77f10 Author: never Date: 2010-07-12 22:27 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/8d5934a77f10 6968385: malformed xml in sweeper logging Reviewed-by: kvn ! src/share/vm/runtime/sweeper.cpp Changeset: 079980c86f33 Author: kvn Date: 2010-07-14 14:29 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/079980c86f33 6968646: JVM crashes with SIGFPE during startup Summary: Check that cpuid returns valid values for processor topology (not zeros). Reviewed-by: never, twisti ! src/cpu/x86/vm/vm_version_x86.hpp Changeset: 8099e71601df Author: kvn Date: 2010-07-14 14:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/8099e71601df 6968368: SIGSEGV in the BCEscapeAnalyzer::copy_dependencies Summary: Use GrowableArray and VectorSet allocated in ciEnv arena. Reviewed-by: never, twisti ! src/share/vm/ci/bcEscapeAnalyzer.cpp ! src/share/vm/ci/bcEscapeAnalyzer.hpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/includeDB_compiler2 ! src/share/vm/includeDB_core Changeset: a528509c992b Author: never Date: 2010-07-15 08:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/a528509c992b 6968336: VM crash guarantee(!nm->is_zombie()) failed: cannot lock a zombie method Reviewed-by: twisti ! src/share/vm/prims/jvmtiCodeBlobEvents.cpp Changeset: 61fdaf88f57f Author: never Date: 2010-07-15 13:48 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/61fdaf88f57f Merge - src/os/linux/vm/vtune_linux.cpp - src/os/solaris/vm/vtune_solaris.cpp - src/os/windows/vm/vtune_windows.cpp - src/share/vm/runtime/vtune.hpp Changeset: 920aa833fd16 Author: apangin Date: 2010-07-17 21:49 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/920aa833fd16 Merge From weijun.wang at sun.com Sun Jul 18 19:04:09 2010 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Mon, 19 Jul 2010 02:04:09 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20100719020430.2242C47ACA@hg.openjdk.java.net> Changeset: 9a1bd20fc71c Author: weijun Date: 2010-07-19 10:02 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9a1bd20fc71c 6969683: Generify ResolverConfiguration codes Reviewed-by: alanb, chegar ! src/share/classes/com/sun/jndi/dns/DnsContextFactory.java ! src/share/classes/sun/net/dns/ResolverConfiguration.java ! src/share/classes/sun/net/spi/nameservice/dns/DNSNameService.java ! src/solaris/classes/sun/net/dns/ResolverConfigurationImpl.java ! src/windows/classes/sun/net/dns/ResolverConfigurationImpl.java Changeset: 4022e0c84507 Author: weijun Date: 2010-07-19 10:02 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4022e0c84507 6969292: make DNS lookup for realm/kdc really work Reviewed-by: alanb, valeriep ! src/share/classes/sun/security/krb5/Config.java From sean.mullan at oracle.com Tue Jul 20 09:22:30 2010 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Tue, 20 Jul 2010 16:22:30 +0000 Subject: hg: jdk7/tl/jdk: 6870553: X509Certificate.getSigAlgName method description uses non-standard algorithm name as example Message-ID: <20100720162240.9AED947B1F@hg.openjdk.java.net> Changeset: 9d1994d53a67 Author: mullan Date: 2010-07-20 10:41 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9d1994d53a67 6870553: X509Certificate.getSigAlgName method description uses non-standard algorithm name as example Reviewed-by: xuelei ! src/share/classes/java/security/cert/X509CRL.java ! src/share/classes/java/security/cert/X509Certificate.java From daniel.daugherty at oracle.com Tue Jul 20 11:35:17 2010 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 20 Jul 2010 12:35:17 -0600 Subject: SDK Test Fixes Batch for 2010.07 (6941287, 6962804, 6964018) Message-ID: <4C45EC65.7020707@oracle.com> Greetings, I have fixes for three different test bugs ready to go for OpenJDK7. I've run these tests manually on Linux, Solaris SPARC, Solaris X86 and WinXP/Cygwin. I've run these tests through JPRT several times to make sure they are stable (which also covers WinXP/MKS). I've been running select tests from this set in loops for 12-24 hours on Linux, Solaris X86 and WinXP/Cygwin to make sure they don't hiccup. This first fix I've had for a while and it has been used in my personal baseline testing for the last several JDK7 promotions: http://cr.openjdk.java.net/~dcubed/6941287-webrev/0/ Yes, it could be refactored to use some of the newer logic that I added in the fix for 6964018, but that's a task that should be applied to all the test/sun/tools/* tests. This second fix was intended to add diagnostic information for tracking down some of the strange intermittent failures on Windows: http://cr.openjdk.java.net/~dcubed/6962804-webrev/0/ However, the fix seems to have solved the intermittent failures on Windows problem. I haven't seen these failures reproduce in my personal baseline testing on the last several JDK7 promotions and a stress loop using JDK7-B98 bits hasn't reproduced the failures either. I suspect that my refactoring of the logic that handles a missing NL at the end of a file has fixed this problem. The scaffold no longer creates a temporary file every time a test runs; it is only created when needed to solve the missing NL problem. The third fix gets my recent Logger WeakReference leak tests back into the available test mix: http://cr.openjdk.java.net/~dcubed/6964018-webrev/0/ This fix refactors and enhances some of the test infrastructure in test/sun/tools/common/* and changes the new Logger WeakReference leak tests to use that infrastructure. Other tests in test/sun/tools/* also need minor tweaks to fit into the new infrastructure. Thanks, in advance, for any reviews. Dan From daniel.daugherty at oracle.com Tue Jul 20 11:52:57 2010 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 20 Jul 2010 12:52:57 -0600 Subject: SDK Test Fixes Batch for 2010.07 (6941287, 6962804, 6964018) In-Reply-To: <4C45EC65.7020707@oracle.com> References: <4C45EC65.7020707@oracle.com> Message-ID: <4C45F089.3000101@oracle.com> One thing I forgot to make clear about this fix. For the folks that were worried about the test execution time for the two new tests, I was able to add an early bailout if the test detected that the instance count was the same or decreasing for the target leak(s). This means that test now only runs until it determines that the bits being tested have the fix in place. Only bits without the fix will execute for the full time. Dan On 7/20/2010 12:35 PM, Daniel D. Daugherty wrote: > The third fix gets my recent Logger WeakReference leak tests back into > the available test mix: > > http://cr.openjdk.java.net/~dcubed/6964018-webrev/0/ > > This fix refactors and enhances some of the test infrastructure in > test/sun/tools/common/* and changes the new Logger WeakReference leak > tests to use that infrastructure. Other tests in test/sun/tools/* > also need minor tweaks to fit into the new infrastructure. From kelly.ohair at oracle.com Tue Jul 20 13:22:22 2010 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 20 Jul 2010 13:22:22 -0700 Subject: SDK Test Fixes Batch for 2010.07 (6941287, 6962804, 6964018) In-Reply-To: <4C45EC65.7020707@oracle.com> References: <4C45EC65.7020707@oracle.com> Message-ID: The first two batches look fine to me. The last one was pretty big, and I poked around a little, looks fine to me, but I am not sure I gave it a very good review. I think getting these tests right may be more difficult than getting the API to work. :^{ So for risking your sanity and working on these tests, you get 3 gold stars. ;^) -kto On Jul 20, 2010, at 11:35 AM, Daniel D. Daugherty wrote: > Greetings, > > I have fixes for three different test bugs ready to go for OpenJDK7. > I've run these tests manually on Linux, Solaris SPARC, Solaris X86 > and WinXP/Cygwin. I've run these tests through JPRT several times to > make sure they are stable (which also covers WinXP/MKS). I've been > running select tests from this set in loops for 12-24 hours on Linux, > Solaris X86 and WinXP/Cygwin to make sure they don't hiccup. > > This first fix I've had for a while and it has been used in my > personal > baseline testing for the last several JDK7 promotions: > > http://cr.openjdk.java.net/~dcubed/6941287-webrev/0/ > > Yes, it could be refactored to use some of the newer logic that I > added > in the fix for 6964018, but that's a task that should be applied to > all > the test/sun/tools/* tests. > > This second fix was intended to add diagnostic information for > tracking > down some of the strange intermittent failures on Windows: > > http://cr.openjdk.java.net/~dcubed/6962804-webrev/0/ > > However, the fix seems to have solved the intermittent failures on > Windows problem. I haven't seen these failures reproduce in my > personal > baseline testing on the last several JDK7 promotions and a stress loop > using JDK7-B98 bits hasn't reproduced the failures either. I suspect > that my refactoring of the logic that handles a missing NL at the end > of a file has fixed this problem. The scaffold no longer creates a > temporary file every time a test runs; it is only created when needed > to solve the missing NL problem. > > The third fix gets my recent Logger WeakReference leak tests back into > the available test mix: > > http://cr.openjdk.java.net/~dcubed/6964018-webrev/0/ > > This fix refactors and enhances some of the test infrastructure in > test/sun/tools/common/* and changes the new Logger WeakReference leak > tests to use that infrastructure. Other tests in test/sun/tools/* > also need minor tweaks to fit into the new infrastructure. > > Thanks, in advance, for any reviews. > > Dan > > From daniel.daugherty at oracle.com Tue Jul 20 13:58:12 2010 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 20 Jul 2010 14:58:12 -0600 Subject: SDK Test Fixes Batch for 2010.07 (6941287, 6962804, 6964018) In-Reply-To: References: <4C45EC65.7020707@oracle.com> Message-ID: <4C460DE4.7020802@oracle.com> On 7/20/2010 2:22 PM, Kelly O'Hair wrote: > The first two batches look fine to me. Thanks! > The last one was pretty big, and I poked around a little, looks fine > to me, > but I am not sure I gave it a very good review. I'll wait to see if one of the original Logger WeakRef leak reviewers chimes in here (Alan, David or Eamonn...) I'm very confident of the tests at this point; you've probably seen all the test JPRT jobs that I've been sending through... :-) > I think getting these tests right may be more difficult than getting > the API to work. :^{ Hence the refactoring of the infrastructure stuff into common files. I'm getting tired of fixing this infrastructure stuff in more than one place... > So for risking your sanity and working on these tests, you get 3 gold > stars. ;^) Thanks! There will be more fixes coming in the test arena... Dan > > > > -kto > > On Jul 20, 2010, at 11:35 AM, Daniel D. Daugherty wrote: > >> Greetings, >> >> I have fixes for three different test bugs ready to go for OpenJDK7. >> I've run these tests manually on Linux, Solaris SPARC, Solaris X86 >> and WinXP/Cygwin. I've run these tests through JPRT several times to >> make sure they are stable (which also covers WinXP/MKS). I've been >> running select tests from this set in loops for 12-24 hours on Linux, >> Solaris X86 and WinXP/Cygwin to make sure they don't hiccup. >> >> This first fix I've had for a while and it has been used in my personal >> baseline testing for the last several JDK7 promotions: >> >> http://cr.openjdk.java.net/~dcubed/6941287-webrev/0/ >> >> Yes, it could be refactored to use some of the newer logic that I added >> in the fix for 6964018, but that's a task that should be applied to all >> the test/sun/tools/* tests. >> >> This second fix was intended to add diagnostic information for tracking >> down some of the strange intermittent failures on Windows: >> >> http://cr.openjdk.java.net/~dcubed/6962804-webrev/0/ >> >> However, the fix seems to have solved the intermittent failures on >> Windows problem. I haven't seen these failures reproduce in my personal >> baseline testing on the last several JDK7 promotions and a stress loop >> using JDK7-B98 bits hasn't reproduced the failures either. I suspect >> that my refactoring of the logic that handles a missing NL at the end >> of a file has fixed this problem. The scaffold no longer creates a >> temporary file every time a test runs; it is only created when needed >> to solve the missing NL problem. >> >> The third fix gets my recent Logger WeakReference leak tests back into >> the available test mix: >> >> http://cr.openjdk.java.net/~dcubed/6964018-webrev/0/ >> >> This fix refactors and enhances some of the test infrastructure in >> test/sun/tools/common/* and changes the new Logger WeakReference leak >> tests to use that infrastructure. Other tests in test/sun/tools/* >> also need minor tweaks to fit into the new infrastructure. >> >> Thanks, in advance, for any reviews. >> >> Dan >> >> > From andrei.pangin at sun.com Tue Jul 20 15:42:59 2010 From: andrei.pangin at sun.com (andrei.pangin at sun.com) Date: Tue, 20 Jul 2010 22:42:59 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 6964170: Verifier crashes Message-ID: <20100720224302.7838347B2C@hg.openjdk.java.net> Changeset: a5c9d63a187d Author: apangin Date: 2010-07-20 08:41 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/a5c9d63a187d 6964170: Verifier crashes Summary: Check if klassOop != NULL rather than klass_part != NULL Reviewed-by: kamg, never ! src/share/vm/classfile/verificationType.cpp ! src/share/vm/classfile/verifier.cpp From chris.hegarty at oracle.com Wed Jul 21 05:32:42 2010 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 21 Jul 2010 12:32:42 +0000 Subject: hg: jdk7/tl/jdk: 6969395: TEST_BUG: Tests in java/net sun/net problems Message-ID: <20100721123252.3BEE547B4C@hg.openjdk.java.net> Changeset: 58f325ba3e27 Author: chegar Date: 2010-07-21 13:29 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/58f325ba3e27 6969395: TEST_BUG: Tests in java/net sun/net problems Reviewed-by: alanb ! test/ProblemList.txt ! test/com/sun/net/httpserver/Test1.java ! test/com/sun/net/httpserver/Test11.java ! test/com/sun/net/httpserver/Test12.java ! test/com/sun/net/httpserver/Test13.java ! test/com/sun/net/httpserver/Test6a.java ! test/com/sun/net/httpserver/Test7a.java ! test/com/sun/net/httpserver/Test8a.java ! test/com/sun/net/httpserver/Test9.java ! test/com/sun/net/httpserver/Test9a.java ! test/com/sun/net/httpserver/bugs/B6361557.java ! test/com/sun/net/httpserver/bugs/B6373555.java ! test/java/net/DatagramSocket/DatagramTimeout.java ! test/java/net/DatagramSocket/SendSize.java ! test/java/net/Inet6Address/B6558853.java ! test/java/net/Inet6Address/serialize/Serialize.java ! test/java/net/InetAddress/CheckJNI.java ! test/java/net/MulticastSocket/SetOutgoingIf.java ! test/java/net/ResponseCache/B6181108.java ! test/java/net/ResponseCache/ResponseCacheTest.java ! test/java/net/ResponseCache/getResponseCode.java - test/java/net/Socket/AccurateTimeout.java ! test/java/net/Socket/CloseAvailable.java ! test/java/net/Socket/DeadlockTest.java ! test/java/net/Socket/LingerTest.java ! test/java/net/Socket/LinkLocal.java ! test/java/net/Socket/ProxyCons.java ! test/java/net/Socket/ReadTimeout.java ! test/java/net/Socket/SetReceiveBufferSize.java ! test/java/net/Socket/SetSoLinger.java ! test/java/net/Socket/ShutdownBoth.java ! test/java/net/Socket/SoTimeout.java ! test/java/net/Socket/Timeout.java ! test/java/net/Socket/UrgentDataTest.java ! test/java/net/Socket/asyncClose/BrokenPipe.java ! test/java/net/Socket/setReuseAddress/Restart.java ! test/java/net/SocketInputStream/SocketClosedException.java ! test/java/net/SocketInputStream/SocketTimeout.java ! test/java/net/URL/GetContent.java ! test/java/net/URLClassLoader/ClassLoad.java ! test/java/net/URLConnection/DisconnectAfterEOF.java ! test/java/net/URLConnection/HandleContentTypeWithAttrs.java ! test/java/net/URLConnection/HttpContinueStackOverflow.java ! test/java/net/URLConnection/Redirect307Test.java ! test/java/net/URLConnection/RedirectLimit.java ! test/java/net/URLConnection/ResendPostBody.java ! test/java/net/URLConnection/SetIfModifiedSince.java ! test/java/net/URLConnection/TimeoutTest.java ! test/java/net/URLConnection/URLConnectionHeaders.java ! test/java/net/URLConnection/ZeroContentLength.java ! test/java/net/ipv6tests/B6521014.java ! test/java/net/ipv6tests/TcpTest.java ! test/java/net/ipv6tests/Tests.java ! test/sun/net/ftp/FtpGetContent.java ! test/sun/net/ftp/FtpURL.java ! test/sun/net/www/http/ChunkedInputStream/ChunkedEncodingWithProgressMonitorTest.java ! test/sun/net/www/http/ChunkedOutputStream/Test.java ! test/sun/net/www/http/HttpClient/B6726695.java ! test/sun/net/www/http/HttpClient/MultiThreadTest.java ! test/sun/net/www/http/HttpClient/ProxyTest.java ! test/sun/net/www/http/KeepAliveCache/KeepAliveTimerThread.java ! test/sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java ! test/sun/net/www/httptest/HttpServer.java ! test/sun/net/www/protocol/http/DigestTest.java From chris.hegarty at oracle.com Wed Jul 21 05:53:06 2010 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 21 Jul 2010 12:53:06 +0000 Subject: hg: jdk7/tl/jdk: 6970262: TEST_BUG: test/java/net/NetworkInterface/IPv4Only.java has wrong test name in @run tag Message-ID: <20100721125315.3AAA847B4D@hg.openjdk.java.net> Changeset: f90999d7c404 Author: chegar Date: 2010-07-21 13:52 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f90999d7c404 6970262: TEST_BUG: test/java/net/NetworkInterface/IPv4Only.java has wrong test name in @run tag Reviewed-by: alanb, dsamersoff ! test/java/net/NetworkInterface/IPv4Only.java From alan.bateman at oracle.com Wed Jul 21 11:31:50 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 21 Jul 2010 18:31:50 +0000 Subject: hg: jdk7/tl/jdk: 6963907: (so) Socket adapter need to implement sendUrgentData Message-ID: <20100721183206.E5DFF47B65@hg.openjdk.java.net> Changeset: 3902c742b5b1 Author: alanb Date: 2010-07-21 18:08 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3902c742b5b1 6963907: (so) Socket adapter need to implement sendUrgentData Reviewed-by: chegar ! make/java/nio/mapfile-linux ! make/java/nio/mapfile-solaris ! src/share/classes/sun/nio/ch/SocketAdaptor.java ! src/share/classes/sun/nio/ch/SocketChannelImpl.java ! src/solaris/native/sun/nio/ch/SocketChannelImpl.c ! src/windows/native/sun/nio/ch/SocketChannelImpl.c + test/java/nio/channels/SocketChannel/OutOfBand.java From daniel.daugherty at oracle.com Wed Jul 21 13:12:19 2010 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Wed, 21 Jul 2010 14:12:19 -0600 Subject: [Fwd: Re: SDK Test Fixes Batch for 2010.07 (6941287, 6962804, 6964018)] Message-ID: <4C4754A3.3060808@oracle.com> Here is relevant e-mail about the third fix (6964018) that I sent to Alan Bateman off list. It's probably interesting to anyone else that plans to review 6964018... Dan -------- Original Message -------- Subject: Re: SDK Test Fixes Batch for 2010.07 (6941287, 6962804, 6964018) Date: Wed, 21 Jul 2010 09:16:29 -0600 From: Daniel D. Daugherty Reply-To: daniel.daugherty at oracle.com To: Alan Bateman References: <4C45EC65.7020707 at oracle.com> On 7/20/2010 12:35 PM, Daniel D. Daugherty wrote: > The third fix gets my recent Logger WeakReference leak tests back into > the available test mix: > > http://cr.openjdk.java.net/~dcubed/6964018-webrev/0/ > > This fix refactors and enhances some of the test infrastructure in > test/sun/tools/common/* and changes the new Logger WeakReference leak > tests to use that infrastructure. Other tests in test/sun/tools/* > also need minor tweaks to fit into the new infrastructure. Here is what changed in the webrev. Now that I've written it out I can see why it looks like a lot. I'm hoping that you think I've made some good and useful improvements to both the infrastructure and tests that you created... Dan test/java/util/logging/AnonLoggerWeakRefLeak.java - refactored to be a subclass of SimpleApplication - changed duration from 60 -> 120 seconds because 60 seconds wasn't reliably reproducing the leak on an overloaded test machine test/java/util/logging/AnonLoggerWeakRefLeak.sh - refactored to use sun/tools/common/* infrastructure - drop incoming env check; now in CommonSetup.sh - drop command paths; now in CommonSetup.sh - drop grep_cmd function and rework both grep calls and sed calls to use PATTERN_EOL and PATTERN_WS constants - drop flag setting code; now in CommonSetup.sh - drop app launch and pid finding stuff in favor of startApplication, stopApplication, waitApplication and killApplication - changed timeout from 3 minutes to 4 minutes since test can now run for 2 minutes instead of 1 minute - rework jmap version check to not crash process group on Linux - rework jmap retry stuff to work around intermittent jmap bugs - allow for early termination if instance count is the same or decreasing which indicates that the bits being tested have the fix. - clarify messages when the test fails and when the test pass test/java/util/logging/LoggerWeakRefLeak.java - refactored to be a subclass of SimpleApplication test/java/util/logging/LoggerWeakRefLeak.sh - same fixes as for AnonLoggerWeakRefLeak.sh except the timeout was already 4 minutes for this test test/sun/tools/common/ApplicationSetup.sh - startApplication changes: - rename exported "pid" variable to appJavaPid; add appOtherPid, appPidList and appOutput exported variables - refactor "-classpath $TESTCLASSES" into function - switch to "$@" to preserve arg spacing - redirect stderr to output file in addition to stdout - refactor Cygwin pid logic to use "ps" and "sed" instead of "ps", "tail" and "awk" (fewer pipes and processes) - refactor MKS pid logic use "ps" and "sed" instead of "ps", "grep", "grep", "cut" (fewer pipes and processes) - stopApplication changes - refactor ShutdownSimpleApplication classname into function - add waitForApplication() and killApplication functions test/sun/tools/common/CommonSetup.sh - add JPS program path constant; also sorted the constants - add PATTERN_EOL and PATTERN_WS constants - cleanup incoming env vars check a bit - add 'set -eu' for paranoia - add isFoo flags (Cygwin, MKS, Linux,Solaris, Unknown and Windows) - change Cygwin PS value from ";" to (default) ":" test/sun/tools/common/CommonTests.sh - new tests for the infrastructure in ApplicationSetup.sh and CommonSetup.sh; allows for easier porting test/sun/tools/common/ShutdownSimpleApplication.java - Fix comment about the class argument being a file that contains the port number instead of being the port number - added a usage check for wrong number of parameters - added a "done connecting" message - added System.exit(0) (set -e now in use) test/sun/tools/common/SimpleApplication.java - clarify that the class argument is a file that contains the port number. - refactor main() into doMyAppStart(), doMyAppWork() and doMyAppFinish() pieces to permit easy subclassing - add getMyApp() and setMyApp() - refactor main() to permit subclassing test/sun/tools/common/SleeperApplication.java - add SleeperApplication to illustrate subclassing of SimpleApplication test/sun/tools/jhat/ParseTest.sh - add missing failed variable initialization - add 'set +e' since this test already checks return statuses test/sun/tools/jinfo/Basic.sh - refactor startApplication and stopApplication calls - add waitForApplication call - use "appJavaPid" variable instead of "pid" variable - use new flags as appropriate - add 'set +e' since this test already checks return statuses test/sun/tools/jmap/Basic.sh - refactor startApplication and stopApplication calls - add waitForApplication call - use "appJavaPid" variable instead of "pid" variable - add 'set +e' since this test already checks return statuses - delete unnecessary "p" variable setting and usage test/sun/tools/jstack/Basic.sh - refactor startApplication and stopApplication calls - add waitForApplication call - use "appJavaPid" variable instead of "pid" variable - add 'set +e' since this test already checks return statuses From daniel.daugherty at oracle.com Wed Jul 21 13:12:25 2010 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Wed, 21 Jul 2010 14:12:25 -0600 Subject: [Fwd: SDK Test Fixes Batch for 2010.07 (6941287, 6962804, 6964018)] In-Reply-To: <4C474DE9.2070109@oracle.com> References: <4C467204.6000100@oracle.com> <4C46CF24.6020909@oracle.com> <4C46E765.1040205@oracle.com> <4C474DE9.2070109@oracle.com> Message-ID: <4C4754A9.4070006@oracle.com> Alan, I'm adding the OpenJDK aliases back into this e-mail thread for this reply. Just trying to keep folks in the loop... Thanks for squeezing in time for a review of 6964018. On 7/21/2010 1:43 PM, Alan Bateman wrote: > Daniel D. Daugherty wrote: >> On 7/21/2010 4:42 AM, Alan Bateman wrote: >>> Daniel D. Daugherty wrote: >>>> Alan, >>>> >>>> A quick look from you at the third webrev would be much appreciated... >>>> >>>> Dan >>> Sorry Dan, I just don't have the cycles today due to a couple of >>> high priority issues. I might get cycles on Friday if we really >>> want me to review. >> >> I may just go with only Kelly's review. :-| > I just spent 15-20m going through > http://cr.openjdk.java.net/~dcubed/6964018-webrev/0/ in more detail > and it looks fine to me. Thanks for explaining about the refactoring > as it looks more than it really is on first glance. I'm happy with > the updates to the existing tests and happy to see the new > test/java/util/logging tests are more reliable. Given that this is > tests only change then one reviewer should be fine. I'll put both you and Kelly down for 6964018. I'll put just Kelly down for the first two. Of course, that could change if I get more reviewer comments. > Minor nits in ShutdownSimpleApplication.java is that System.exit is > probably not needed. Because I added the 'set -e' option, I think it is needed. Otherwise I get a random process exit status. > Also the pre-existing empty comment lines L25-26 can probably be removed. I wondered why those were there so I left them in. I had meant to ping you about them, but I forgot... I'll remove them. > Same comments for SimpleApplication. Hopefully, the same resolutions will be OK with you. > BTW: In test/java/util/logging/LoggerWeakRefLeak.sh you can listed > issues with jmap - are they still valid with the updated test and the > recent fix to the attach API? I suspect that your recent attach API fix will resolve those issues, but I plan to specifically test for that after your fix gets promoted. > The only outstanding issue that I can think of is where you try to > attach just as the process is about to exit (but with the updated test > this doesn't happen due to the "handshake"/socket connection). Agreed and thank you for pointing me in that direction. Dan From David.Holmes at oracle.com Wed Jul 21 16:41:38 2010 From: David.Holmes at oracle.com (David Holmes) Date: Thu, 22 Jul 2010 09:41:38 +1000 Subject: [Fwd: SDK Test Fixes Batch for 2010.07 (6941287, 6962804, 6964018)] In-Reply-To: <4C4754A9.4070006@oracle.com> References: <4C467204.6000100@oracle.com> <4C46CF24.6020909@oracle.com> <4C46E765.1040205@oracle.com> <4C474DE9.2070109@oracle.com> <4C4754A9.4070006@oracle.com> Message-ID: <4C4785B2.1080809@oracle.com> Dan, You can add me to the first two if you like. The third was over my head :) As Alan said these are test changes so not so critical ... and if there's a problem with them you get to fix it again :) Cheers, David Daniel D. Daugherty said the following on 07/22/10 06:12: > Alan, > > I'm adding the OpenJDK aliases back into this e-mail thread for > this reply. Just trying to keep folks in the loop... > > Thanks for squeezing in time for a review of 6964018. > > > On 7/21/2010 1:43 PM, Alan Bateman wrote: >> Daniel D. Daugherty wrote: >>> On 7/21/2010 4:42 AM, Alan Bateman wrote: >>>> Daniel D. Daugherty wrote: >>>>> Alan, >>>>> >>>>> A quick look from you at the third webrev would be much appreciated... >>>>> >>>>> Dan >>>> Sorry Dan, I just don't have the cycles today due to a couple of >>>> high priority issues. I might get cycles on Friday if we really >>>> want me to review. >>> >>> I may just go with only Kelly's review. :-| >> I just spent 15-20m going through >> http://cr.openjdk.java.net/~dcubed/6964018-webrev/0/ in more detail >> and it looks fine to me. Thanks for explaining about the refactoring >> as it looks more than it really is on first glance. I'm happy with >> the updates to the existing tests and happy to see the new >> test/java/util/logging tests are more reliable. Given that this is >> tests only change then one reviewer should be fine. > > I'll put both you and Kelly down for 6964018. I'll put just Kelly > down for the first two. Of course, that could change if I get more > reviewer comments. > > >> Minor nits in ShutdownSimpleApplication.java is that System.exit is >> probably not needed. > > Because I added the 'set -e' option, I think it is needed. Otherwise > I get a random process exit status. > > >> Also the pre-existing empty comment lines L25-26 can probably be removed. > > I wondered why those were there so I left them in. I had meant to > ping you about them, but I forgot... I'll remove them. > > >> Same comments for SimpleApplication. > > Hopefully, the same resolutions will be OK with you. > > >> BTW: In test/java/util/logging/LoggerWeakRefLeak.sh you can listed >> issues with jmap - are they still valid with the updated test and the >> recent fix to the attach API? > > I suspect that your recent attach API fix will resolve those > issues, but I plan to specifically test for that after your > fix gets promoted. > > >> The only outstanding issue that I can think of is where you try to >> attach just as the process is about to exit (but with the updated test >> this doesn't happen due to the "handshake"/socket connection). > > Agreed and thank you for pointing me in that direction. > > Dan > From daniel.daugherty at oracle.com Wed Jul 21 16:43:59 2010 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Wed, 21 Jul 2010 17:43:59 -0600 Subject: [Fwd: SDK Test Fixes Batch for 2010.07 (6941287, 6962804, 6964018)] In-Reply-To: <4C4785B2.1080809@oracle.com> References: <4C467204.6000100@oracle.com> <4C46CF24.6020909@oracle.com> <4C46E765.1040205@oracle.com> <4C474DE9.2070109@oracle.com> <4C4754A9.4070006@oracle.com> <4C4785B2.1080809@oracle.com> Message-ID: <4C47863F.90304@oracle.com> On 7/21/2010 5:41 PM, David Holmes wrote: > Dan, > > You can add me to the first two if you like. Thanks! > The third was over my head :) I doubt that, but I have two for that one :-) > As Alan said these are test changes so not so critical ... Unless you're trying to get an SDK/JDK job through the JPRT queue :-) > and if there's a problem with them you get to fix it again :) Yup. And now I have a template/shared code to use to fix other annoyingly intermittent tests... Dan > > Cheers, > David > > Daniel D. Daugherty said the following on 07/22/10 06:12: >> Alan, >> >> I'm adding the OpenJDK aliases back into this e-mail thread for >> this reply. Just trying to keep folks in the loop... >> >> Thanks for squeezing in time for a review of 6964018. >> >> >> On 7/21/2010 1:43 PM, Alan Bateman wrote: >>> Daniel D. Daugherty wrote: >>>> On 7/21/2010 4:42 AM, Alan Bateman wrote: >>>>> Daniel D. Daugherty wrote: >>>>>> Alan, >>>>>> >>>>>> A quick look from you at the third webrev would be much >>>>>> appreciated... >>>>>> >>>>>> Dan >>>>> Sorry Dan, I just don't have the cycles today due to a couple of >>>>> high priority issues. I might get cycles on Friday if we really >>>>> want me to review. >>>> >>>> I may just go with only Kelly's review. :-| >>> I just spent 15-20m going through >>> http://cr.openjdk.java.net/~dcubed/6964018-webrev/0/ in more detail >>> and it looks fine to me. Thanks for explaining about the refactoring >>> as it looks more than it really is on first glance. I'm happy with >>> the updates to the existing tests and happy to see the new >>> test/java/util/logging tests are more reliable. Given that this is >>> tests only change then one reviewer should be fine. >> >> I'll put both you and Kelly down for 6964018. I'll put just Kelly >> down for the first two. Of course, that could change if I get more >> reviewer comments. >> >> >>> Minor nits in ShutdownSimpleApplication.java is that System.exit is >>> probably not needed. >> >> Because I added the 'set -e' option, I think it is needed. Otherwise >> I get a random process exit status. >> >> >>> Also the pre-existing empty comment lines L25-26 can probably be >>> removed. >> >> I wondered why those were there so I left them in. I had meant to >> ping you about them, but I forgot... I'll remove them. >> >> >>> Same comments for SimpleApplication. >> >> Hopefully, the same resolutions will be OK with you. >> >> >>> BTW: In test/java/util/logging/LoggerWeakRefLeak.sh you can listed >>> issues with jmap - are they still valid with the updated test and >>> the recent fix to the attach API? >> >> I suspect that your recent attach API fix will resolve those >> issues, but I plan to specifically test for that after your >> fix gets promoted. >> >> >>> The only outstanding issue that I can think of is where you try to >>> attach just as the process is about to exit (but with the updated >>> test this doesn't happen due to the "handshake"/socket connection). >> >> Agreed and thank you for pointing me in that direction. >> >> Dan >> From daniel.daugherty at oracle.com Wed Jul 21 19:26:46 2010 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Thu, 22 Jul 2010 02:26:46 +0000 Subject: hg: jdk7/tl/jdk: 3 new changesets Message-ID: <20100722022714.A10C847B78@hg.openjdk.java.net> Changeset: d899526a187a Author: dcubed Date: 2010-07-21 16:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d899526a187a 6941287: 4/4 jrunscriptTest.sh test does not work right under Cygwin Summary: Add golden_diff variable for doing proper golden file diffs on Cygwin. Reviewed-by: ohair, dholmes ! test/sun/tools/jrunscript/common.sh ! test/sun/tools/jrunscript/jrunscript-eTest.sh ! test/sun/tools/jrunscript/jrunscript-fTest.sh ! test/sun/tools/jrunscript/jrunscriptTest.sh Changeset: 946236dc5c96 Author: dcubed Date: 2010-07-21 16:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/946236dc5c96 6962804: 4/4 ShellScaffold tests can fail without a specific reason Summary: Add more diagnostics for failures. Only copy target file in grepForString when NL is missing. Reviewed-by: ohair, dholmes ! test/com/sun/jdi/ShellScaffold.sh Changeset: 9cb77130999f Author: dcubed Date: 2010-07-21 17:01 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9cb77130999f 6964018: 3/4 AnonLoggerWeakRefLeak and LoggerWeakRefLeak can fail in JPRT Summary: Refactor test/sun/tools/common/* code and refactor AnonLoggerWeakRefLeak and LoggerWeakRefLeak to use it. Reviewed-by: ohair, alanb ! test/java/util/logging/AnonLoggerWeakRefLeak.java ! test/java/util/logging/AnonLoggerWeakRefLeak.sh ! test/java/util/logging/LoggerWeakRefLeak.java ! test/java/util/logging/LoggerWeakRefLeak.sh ! test/sun/tools/common/ApplicationSetup.sh ! test/sun/tools/common/CommonSetup.sh + test/sun/tools/common/CommonTests.sh ! test/sun/tools/common/ShutdownSimpleApplication.java ! test/sun/tools/common/SimpleApplication.java + test/sun/tools/common/SleeperApplication.java ! test/sun/tools/jhat/ParseTest.sh ! test/sun/tools/jinfo/Basic.sh ! test/sun/tools/jmap/Basic.sh ! test/sun/tools/jstack/Basic.sh From jonathan.gibbons at oracle.com Thu Jul 22 11:03:33 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 22 Jul 2010 18:03:33 +0000 Subject: hg: jdk7/tl/langtools: 6968063: provide examples of code that generate diagnostics Message-ID: <20100722180335.8045E47BA3@hg.openjdk.java.net> Changeset: 3640b60bd0f6 Author: jjg Date: 2010-07-22 11:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3640b60bd0f6 6968063: provide examples of code that generate diagnostics Reviewed-by: mcimadamore ! make/build.xml + test/tools/javac/diags/CheckExamples.java + test/tools/javac/diags/Example.java + test/tools/javac/diags/FileManager.java + test/tools/javac/diags/HTMLWriter.java + test/tools/javac/diags/README.examples.txt + test/tools/javac/diags/RunExamples.java + test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/AbstractCantBeAccessed.java + test/tools/javac/diags/examples/AbstractCantBeInstantiated.java + test/tools/javac/diags/examples/AbstractMethodCantHaveBody.java + test/tools/javac/diags/examples/AlreadyDefined.java + test/tools/javac/diags/examples/AlreadyDefinedImport.java + test/tools/javac/diags/examples/AlreadyDefinedStaticImport/AlreadDefinedStaticImport.java + test/tools/javac/diags/examples/AlreadyDefinedStaticImport/p/E1.java + test/tools/javac/diags/examples/AlreadyDefinedStaticImport/p/E2.java + test/tools/javac/diags/examples/AnnoNotApplicable.java + test/tools/javac/diags/examples/AnnoNotValidForType.java + test/tools/javac/diags/examples/AnnoValueMustBeAnnotation.java + test/tools/javac/diags/examples/AnnoValueMustBeClassLiteral.java + test/tools/javac/diags/examples/AnnosWithoutProcessors/AnnosWithoutProcessors.java + test/tools/javac/diags/examples/AnnosWithoutProcessors/processors/AnnoProc.java + test/tools/javac/diags/examples/AnnotationMissingValue.java + test/tools/javac/diags/examples/AnnotationMustBeNameValue.java + test/tools/javac/diags/examples/AnnotationsNotSupported.java + test/tools/javac/diags/examples/AnonClassImplInterfaceNoArgs.java + test/tools/javac/diags/examples/AnonClassImplInterfaceNoQualForNew.java + test/tools/javac/diags/examples/AnonClassImplInterfaceNoTypeArgs.java + test/tools/javac/diags/examples/AnonymousClass.java + test/tools/javac/diags/examples/ArrayAndVarargs.java + test/tools/javac/diags/examples/ArrayDimMissing.java + test/tools/javac/diags/examples/ArrayRequired.java + test/tools/javac/diags/examples/AssertAsIdentifier.java + test/tools/javac/diags/examples/AssertAsIdentifier2.java + test/tools/javac/diags/examples/AttrMustBeConstant.java + test/tools/javac/diags/examples/BadSourceFileHeader/BadSourceFileHeader.java + test/tools/javac/diags/examples/BadSourceFileHeader/sourcepath/p/A.java + test/tools/javac/diags/examples/BreakOutsideSwitchLoop.java + test/tools/javac/diags/examples/CallMustBeFirst.java + test/tools/javac/diags/examples/CannotCreateArrayWithTypeArgs.java + test/tools/javac/diags/examples/CantApplyDiamond.java + test/tools/javac/diags/examples/CantAssignToFinal.java + test/tools/javac/diags/examples/CantDeref.java + test/tools/javac/diags/examples/CantExtendIntfAnno.java + test/tools/javac/diags/examples/CantImplement.java + test/tools/javac/diags/examples/CantInheritDiffArg.java + test/tools/javac/diags/examples/CantRefBeforeConstr.java + test/tools/javac/diags/examples/CantResolve.java + test/tools/javac/diags/examples/CantResolveArgs.java + test/tools/javac/diags/examples/CantResolveArgsParams.java + test/tools/javac/diags/examples/CantResolveLocation.java + test/tools/javac/diags/examples/CantResolveLocationArgs.java + test/tools/javac/diags/examples/CantResolveLocationArgsParams.java + test/tools/javac/diags/examples/CantReturnValueForVoid.java + test/tools/javac/diags/examples/CatchWithoutTry.java + test/tools/javac/diags/examples/ClashesWith.java + test/tools/javac/diags/examples/ClassCantWrite.java + test/tools/javac/diags/examples/ClassPublicInFile.java + test/tools/javac/diags/examples/ConcreteInheritanceConflict.java + test/tools/javac/diags/examples/ConstExprRequired.java + test/tools/javac/diags/examples/ConstantSVUID.java + test/tools/javac/diags/examples/ContinueOutsideLoop.java + test/tools/javac/diags/examples/CountError.java + test/tools/javac/diags/examples/CountErrorPlural.java + test/tools/javac/diags/examples/CountWarn.java + test/tools/javac/diags/examples/CountWarnPlural.java + test/tools/javac/diags/examples/CyclicAnnoElement.java + test/tools/javac/diags/examples/CyclicInheritance.java + test/tools/javac/diags/examples/DefaultAllowedInIntfAnnotationMember.java + test/tools/javac/diags/examples/DeprecatedFilename.java + test/tools/javac/diags/examples/DeprecatedFilenameAdditional.java + test/tools/javac/diags/examples/DeprecatedPlural/DeprecatedClass.java + test/tools/javac/diags/examples/DeprecatedPlural/DeprecatedFilename.java + test/tools/javac/diags/examples/DeprecatedPlural/DeprecatedPlural.java + test/tools/javac/diags/examples/DeprecatedPluralAdditional/DeprecatedClass.java + test/tools/javac/diags/examples/DeprecatedPluralAdditional/DeprecatedFilename.java + test/tools/javac/diags/examples/DeprecatedPluralAdditional/DeprecatedPlural.java + test/tools/javac/diags/examples/DeprecatedPluralAdditional/DeprecatedPluralAdditional.java + test/tools/javac/diags/examples/DiamondInvalidArg.java + test/tools/javac/diags/examples/DiamondInvalidArgs.java + test/tools/javac/diags/examples/DiamondNotSupported.java + test/tools/javac/diags/examples/DirPathElementNotFound.java + test/tools/javac/diags/examples/DivZero.java + test/tools/javac/diags/examples/DoesNotOverride.java + test/tools/javac/diags/examples/DoesntExist.java + test/tools/javac/diags/examples/DotClassExpected.java + test/tools/javac/diags/examples/DuplicateAnnotation.java + test/tools/javac/diags/examples/DuplicateAnnotationMemberValue.java + test/tools/javac/diags/examples/DuplicateCaseLabel.java + test/tools/javac/diags/examples/DuplicateClass.java + test/tools/javac/diags/examples/DuplicateDefaultLabel.java + test/tools/javac/diags/examples/ElseWithoutIf.java + test/tools/javac/diags/examples/EmptyBytecodeIdent.java + test/tools/javac/diags/examples/EmptyCharLiteral.java + test/tools/javac/diags/examples/EmptyIf.java + test/tools/javac/diags/examples/EnclClassRequired.java + test/tools/javac/diags/examples/EnumAnnoValueMustBeEnumConst.java + test/tools/javac/diags/examples/EnumAsIdentifier.java + test/tools/javac/diags/examples/EnumAsIdentifier2.java + test/tools/javac/diags/examples/EnumCantBeInstantiated.java + test/tools/javac/diags/examples/EnumConstRequired.java + test/tools/javac/diags/examples/EnumLabelUnqualified.java + test/tools/javac/diags/examples/EnumNoFinalize.java + test/tools/javac/diags/examples/EnumNoSubclassing.java + test/tools/javac/diags/examples/EnumTypesNotExtensible.java + test/tools/javac/diags/examples/EnumsMustBeStatic.java + test/tools/javac/diags/examples/EnumsNotSupported.java + test/tools/javac/diags/examples/ErrProcMessager/ErrProcMessager.java + test/tools/javac/diags/examples/ErrProcMessager/processors/AnnoProc.java + test/tools/javac/diags/examples/ErrSyntheticNameConflict.java + test/tools/javac/diags/examples/Error.java + test/tools/javac/diags/examples/ErrorReadingFile.java + test/tools/javac/diags/examples/ExceptAlreadyCaught.java + test/tools/javac/diags/examples/ExceptNeverThrown.java + test/tools/javac/diags/examples/Expected2.java + test/tools/javac/diags/examples/Expected3.java + test/tools/javac/diags/examples/FinalParamCantBeAssigned.java + test/tools/javac/diags/examples/FinallyCannotComplete.java + test/tools/javac/diags/examples/FinallyWithoutTry.java + test/tools/javac/diags/examples/FloatNumberTooLarge.java + test/tools/javac/diags/examples/FloatNumberTooSmall.java + test/tools/javac/diags/examples/ForeachNotApplicable.java + test/tools/javac/diags/examples/ForeachNotSupported.java + test/tools/javac/diags/examples/GenericArrayCreation.java + test/tools/javac/diags/examples/GenericThrowable.java + test/tools/javac/diags/examples/GenericsNotSupported.java + test/tools/javac/diags/examples/HasBeenDeprecated.java + test/tools/javac/diags/examples/IdentifierExpected.java + test/tools/javac/diags/examples/IllegalBytecodeIdentChar.java + test/tools/javac/diags/examples/IllegalChar.java + test/tools/javac/diags/examples/IllegalComboModifiers.java + test/tools/javac/diags/examples/IllegalEnumStaticRef.java + test/tools/javac/diags/examples/IllegalEscapeChar.java + test/tools/javac/diags/examples/IllegalForwardRef.java + test/tools/javac/diags/examples/IllegalInitializer.java + test/tools/javac/diags/examples/IllegalLineEndInCharLit.java + test/tools/javac/diags/examples/IllegalNonAsciiDigit.java + test/tools/javac/diags/examples/IllegalQualNotIcls.java + test/tools/javac/diags/examples/IllegalSelfRef.java + test/tools/javac/diags/examples/IllegalStartOfExpr.java + test/tools/javac/diags/examples/IllegalUnderscore.java + test/tools/javac/diags/examples/IllegalUnicodeEscape.java + test/tools/javac/diags/examples/ImportRequiresCanonical/ImportRequiresCanonical.java + test/tools/javac/diags/examples/ImportRequiresCanonical/p/Base.java + test/tools/javac/diags/examples/ImportRequiresCanonical/p/ExtendsBase.java + test/tools/javac/diags/examples/ImproperSVUID.java + test/tools/javac/diags/examples/ImproperTypeInnerRawParam.java + test/tools/javac/diags/examples/ImproperTypeParamMissing.java + test/tools/javac/diags/examples/IncomparableTypes.java + test/tools/javac/diags/examples/IncompatibleTypes1.java + test/tools/javac/diags/examples/InconvertibleTypes.java + test/tools/javac/diags/examples/InexactVarargsCall.java + test/tools/javac/diags/examples/InferredDoNotConformToBounds.java + test/tools/javac/diags/examples/InheritFromFinal.java + test/tools/javac/diags/examples/InitializerMustComplete.java + test/tools/javac/diags/examples/InnerClassCantHaveStatic.java + test/tools/javac/diags/examples/IntNumberTooLarge.java + test/tools/javac/diags/examples/InterfaceExpected.java + test/tools/javac/diags/examples/InterfaceNotAllowed.java + test/tools/javac/diags/examples/IntfAnnotationCantHaveTypeParams.java + test/tools/javac/diags/examples/IntfAnnotationMemberClash.java + test/tools/javac/diags/examples/IntfAnnotationsCantHaveParams.java + test/tools/javac/diags/examples/IntfAnnotationsCantHaveTypeParams.java + test/tools/javac/diags/examples/IntfMethodCantHaveBody.java + test/tools/javac/diags/examples/InvalidAnnoMemberType.java + test/tools/javac/diags/examples/InvalidBinaryNumber.java + test/tools/javac/diags/examples/InvalidHexNumber.java + test/tools/javac/diags/examples/InvalidInferredTypes.java + test/tools/javac/diags/examples/InvalidInstanceof.java + test/tools/javac/diags/examples/InvalidMethodDecl.java + test/tools/javac/diags/examples/KindnameClass.java + test/tools/javac/diags/examples/KindnameConstructor.java + test/tools/javac/diags/examples/KindnameMethod.java + test/tools/javac/diags/examples/KindnameVariable.java + test/tools/javac/diags/examples/LabelInUse.java + test/tools/javac/diags/examples/LocalEnum.java + test/tools/javac/diags/examples/LocalVarNeedsFinal.java + test/tools/javac/diags/examples/LongSVUID.java + test/tools/javac/diags/examples/MalformedFpLit.java + test/tools/javac/diags/examples/MalformedSupported/MalformedSupported.java + test/tools/javac/diags/examples/MalformedSupported/processors/AnnoProc.java + test/tools/javac/diags/examples/MethodDoesNotOverride.java + test/tools/javac/diags/examples/MightBeAssignedInLoop.java + test/tools/javac/diags/examples/MissingDeprecatedAnnotation.java + test/tools/javac/diags/examples/MissingMethodBody.java + test/tools/javac/diags/examples/MissingReturnStatement.java + test/tools/javac/diags/examples/MissingReturnValue.java + test/tools/javac/diags/examples/MissingSVUID.java + test/tools/javac/diags/examples/ModifierNotAllowed.java + test/tools/javac/diags/examples/MulticatchCantBeAssigned.java + test/tools/javac/diags/examples/MulticatchMustBeFinal.java + test/tools/javac/diags/examples/MulticatchNotSupported.java + test/tools/javac/diags/examples/NameClashSameErasure.java + test/tools/javac/diags/examples/NameClashSameErasureNoOverride.java + test/tools/javac/diags/examples/NativeMethodCantHaveBody.java + test/tools/javac/diags/examples/NeitherConditionalSubtype.java + test/tools/javac/diags/examples/NewNotAllowedInAnno.java + test/tools/javac/diags/examples/NoArgs.java + test/tools/javac/diags/examples/NoExplicitAnnoProcRequested.java + test/tools/javac/diags/examples/NoInterfaceExpected.java + test/tools/javac/diags/examples/NoInterfaceHere.java + test/tools/javac/diags/examples/NoJavaLang.java + test/tools/javac/diags/examples/NoSuperclass.java + test/tools/javac/diags/examples/NonStaticCantBeRef.java + test/tools/javac/diags/examples/NotDefAccessClassIntfCantAccess/NotDefAccessClassIntfCantAccess.java + test/tools/javac/diags/examples/NotDefAccessClassIntfCantAccess/p/C.java + test/tools/javac/diags/examples/NotDefPublicCantAccess/NotDefPublicCantAccess.java + test/tools/javac/diags/examples/NotDefPublicCantAccess/p/C.java + test/tools/javac/diags/examples/NotEnclClass.java + test/tools/javac/diags/examples/NotLoopLabel.java + test/tools/javac/diags/examples/NotWithinBounds.java + test/tools/javac/diags/examples/Note.java + test/tools/javac/diags/examples/NoteProcMessager/NoteProcMessager.java + test/tools/javac/diags/examples/NoteProcMessager/processors/AnnoProc.java + test/tools/javac/diags/examples/OperatorCantBeApplied.java + test/tools/javac/diags/examples/Orphaned.java + test/tools/javac/diags/examples/OverrideDoesntThrow.java + test/tools/javac/diags/examples/OverrideIncompatibleReturn.java + test/tools/javac/diags/examples/OverrideMeth.java + test/tools/javac/diags/examples/OverrideStatic.java + test/tools/javac/diags/examples/OverrideUncheckedReturn.java + test/tools/javac/diags/examples/OverrideUncheckedThrown.java + test/tools/javac/diags/examples/OverrideVarargsExtra.java + test/tools/javac/diags/examples/OverrideVarargsMissing.java + test/tools/javac/diags/examples/OverrideWeakerAccess.java + test/tools/javac/diags/examples/PackageAnnos.java + test/tools/javac/diags/examples/PackageInfoAlreadySeen/p/package-info.java + test/tools/javac/diags/examples/PackageInfoAlreadySeen/package-info.java + test/tools/javac/diags/examples/PathElementNotFound.java + test/tools/javac/diags/examples/PkgClashWithClass/p/q.java + test/tools/javac/diags/examples/PkgClashWithClass/p/q/C.java + test/tools/javac/diags/examples/PossibleFallThrough.java + test/tools/javac/diags/examples/PossibleLossPrecision.java + test/tools/javac/diags/examples/PrematureEOF.java + test/tools/javac/diags/examples/PrintProcessorInfo/PrintProcessorInfo.java + test/tools/javac/diags/examples/PrintProcessorInfo/processors/AnnoProc.java + test/tools/javac/diags/examples/PrintRounds/PrintRounds.java + test/tools/javac/diags/examples/PrintRounds/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcCantFindClass/ProcCantFindClass.java + test/tools/javac/diags/examples/ProcCantFindClass/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcFileReopening/ProcFileReopening.java + test/tools/javac/diags/examples/ProcFileReopening/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcIllegalFileName/ProcIllegalFileName.java + test/tools/javac/diags/examples/ProcIllegalFileName/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcIncompatibleSourceVersion/ProcIncompatibleSourceVersion.java + test/tools/javac/diags/examples/ProcIncompatibleSourceVersion/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcOnlyNoProcs.java + test/tools/javac/diags/examples/ProcPackageDoesNotExist/ProcPackageDoesNotExist.java + test/tools/javac/diags/examples/ProcPackageDoesNotExist/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcTypeRecreate/ProcTypeRecreate.java + test/tools/javac/diags/examples/ProcTypeRecreate/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcUnclosedTypeFiles/ProcUnclosedTypeFiles.java + test/tools/javac/diags/examples/ProcUnclosedTypeFiles/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcUseImplicit/ProcUseImplicit.java + test/tools/javac/diags/examples/ProcUseImplicit/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcUseImplicit/sourcepath/p/SomeClass.java + test/tools/javac/diags/examples/ProcUseProcOrImplicit/ProcUseProcOrImplicit.java + test/tools/javac/diags/examples/ProcUseProcOrImplicit/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcUseProcOrImplicit/sourcepath/p/SomeClass.java + test/tools/javac/diags/examples/ProcessorCantInstantiate/ProcessorCantInstantiate.java + test/tools/javac/diags/examples/ProcessorCantInstantiate/processors/AnnoProc.java + test/tools/javac/diags/examples/ProcessorNotFound.java + test/tools/javac/diags/examples/ProcessorWrongType/ProcessorWrongType.java + test/tools/javac/diags/examples/ProcessorWrongType/processors/AnnoProc.java + test/tools/javac/diags/examples/QualifiedNewStaticClass.java + test/tools/javac/diags/examples/RawClassUse.java + test/tools/javac/diags/examples/RecursiveConstrInvocation.java + test/tools/javac/diags/examples/RedundantCast.java + test/tools/javac/diags/examples/RefAmbiguous.java + test/tools/javac/diags/examples/RepeatedAnnotationTarget.java + test/tools/javac/diags/examples/RepeatedInterface.java + test/tools/javac/diags/examples/RepeatedModifier.java + test/tools/javac/diags/examples/ReportAccess.java + test/tools/javac/diags/examples/ResourceClosed.java + test/tools/javac/diags/examples/ResourceMayNotBeAssigned.java + test/tools/javac/diags/examples/ResourceNotApplicableToType.java + test/tools/javac/diags/examples/ResourceNotReferenced.java + test/tools/javac/diags/examples/ReturnOutsideMethod.java + test/tools/javac/diags/examples/StaticImportNotSupported.java + test/tools/javac/diags/examples/StaticImportOnlyClassesAndInterfaces/Other.java + test/tools/javac/diags/examples/StaticImportOnlyClassesAndInterfaces/StaticImportOnlyClassesAndInterfaces.java + test/tools/javac/diags/examples/StaticNotQualifiedByType.java + test/tools/javac/diags/examples/StringConstRequired.java + test/tools/javac/diags/examples/StringSwitchNotSupported.java + test/tools/javac/diags/examples/SunApiFilename.java + test/tools/javac/diags/examples/SunApiFilenameAdditional.java + test/tools/javac/diags/examples/SunApiPlural/SunApiFilename.java + test/tools/javac/diags/examples/SunApiPlural/SunApiPlural.java + test/tools/javac/diags/examples/SunApiPluralAdditional/SunApiFilename.java + test/tools/javac/diags/examples/SunApiPluralAdditional/SunApiPlural.java + test/tools/javac/diags/examples/SunApiPluralAdditional/SunApiPluralAdditional.java + test/tools/javac/diags/examples/SunProprietary.java + test/tools/javac/diags/examples/SuperNotAllowedInEnum.java + test/tools/javac/diags/examples/ThrowsNotAllowedInAnno.java + test/tools/javac/diags/examples/TryResourceNotSupported.java + test/tools/javac/diags/examples/TryWithoutCatchOrFinally.java + test/tools/javac/diags/examples/TryWithoutCatchOrFinallyOrResource.java + test/tools/javac/diags/examples/TypeAnnotationsNotSupported.java + test/tools/javac/diags/examples/TypeFoundRequired.java + test/tools/javac/diags/examples/TypeNoParams.java + test/tools/javac/diags/examples/TypeReqClassArray.java + test/tools/javac/diags/examples/TypeReqRef.java + test/tools/javac/diags/examples/TypeVarCantBeDeref.java + test/tools/javac/diags/examples/TypeVarMayNotBeFollowedByOtherBounds.java + test/tools/javac/diags/examples/TypesIncompatible.java + test/tools/javac/diags/examples/UncheckedAssign.java + test/tools/javac/diags/examples/UncheckedAssignToVar.java + test/tools/javac/diags/examples/UncheckedCall.java + test/tools/javac/diags/examples/UncheckedCast.java + test/tools/javac/diags/examples/UncheckedClash.java + test/tools/javac/diags/examples/UncheckedFilename.java + test/tools/javac/diags/examples/UncheckedFilenameAdditional.java + test/tools/javac/diags/examples/UncheckedGenericArrayCreation.java + test/tools/javac/diags/examples/UncheckedImplement.java + test/tools/javac/diags/examples/UncheckedMethodInvocation.java + test/tools/javac/diags/examples/UncheckedPlural/UncheckedFilename.java + test/tools/javac/diags/examples/UncheckedPlural/UncheckedPlural.java + test/tools/javac/diags/examples/UncheckedPluralAdditional/UncheckedFilename1.java + test/tools/javac/diags/examples/UncheckedPluralAdditional/UncheckedFilename2.java + test/tools/javac/diags/examples/UncheckedPluralAdditional/UncheckedPluralAdditional.java + test/tools/javac/diags/examples/UnclosedBytecodeIdent.java + test/tools/javac/diags/examples/UnclosedCharLiteral.java + test/tools/javac/diags/examples/UnclosedComment.java + test/tools/javac/diags/examples/UnclosedStringLiteral.java + test/tools/javac/diags/examples/UndefinedLabel.java + test/tools/javac/diags/examples/UndeterminedType1.java + test/tools/javac/diags/examples/UnmatchedProcessorOptions/UnmatchedProcessorOptions.java + test/tools/javac/diags/examples/UnmatchedProcessorOptions/processors/AnnoProc.java + test/tools/javac/diags/examples/UnnamedPackage.java + test/tools/javac/diags/examples/UnreachableStatement.java + test/tools/javac/diags/examples/UnreportedException.java + test/tools/javac/diags/examples/UnreportedExceptionDefaultConstructor.java + test/tools/javac/diags/examples/UnsupportedBinaryLiteral.java + test/tools/javac/diags/examples/UnsupportedEncoding.java + test/tools/javac/diags/examples/UnsupportedFpLit.java + test/tools/javac/diags/examples/UnsupportedUnderscoreLiteral.java + test/tools/javac/diags/examples/VarMightAlreadyBeAssigned.java + test/tools/javac/diags/examples/VarMightNotHaveBeenInitialized.java + test/tools/javac/diags/examples/VarargsClash.java + test/tools/javac/diags/examples/VarargsFilename.java + test/tools/javac/diags/examples/VarargsFilenameAdditional.java + test/tools/javac/diags/examples/VarargsImplement.java + test/tools/javac/diags/examples/VarargsNonReifiableType.java + test/tools/javac/diags/examples/VarargsNotSupported.java + test/tools/javac/diags/examples/VarargsOverride.java + test/tools/javac/diags/examples/VarargsPlural/VarargsFilename.java + test/tools/javac/diags/examples/VarargsPlural/VarargsPlural.java + test/tools/javac/diags/examples/VarargsPluralAdditional/VarargsFilename.java + test/tools/javac/diags/examples/VarargsPluralAdditional/VarargsPlural.java + test/tools/javac/diags/examples/VarargsPluralAdditional/VarargsPluralAdditional.java + test/tools/javac/diags/examples/Verbose.java + test/tools/javac/diags/examples/VoidNotAllowed.java + test/tools/javac/diags/examples/WarnForwardRef.java + test/tools/javac/diags/examples/WarnProcMessager/WarnProcMessager.java + test/tools/javac/diags/examples/WarnProcMessager/processors/AnnoProc.java + test/tools/javac/diags/examples/WarnSelfRef.java + test/tools/javac/diags/examples/WarnSyntheticNameConflict.java + test/tools/javac/diags/examples/WarningAndWerror.java + test/tools/javac/diags/examples/WhereCaptured.java + test/tools/javac/diags/examples/WhereCaptured1.java + test/tools/javac/diags/examples/WhereIntersection.java + test/tools/javac/diags/examples/WhereTypeVar.java + test/tools/javac/diags/examples/WrongNumberTypeArgs.java From john.coomes at oracle.com Thu Jul 22 22:29:33 2010 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 23 Jul 2010 05:29:33 +0000 Subject: hg: jdk7/hotspot-rt: 4 new changesets Message-ID: <20100723052933.3F11547BCD@hg.openjdk.java.net> Changeset: 055626b50d2d Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/rev/055626b50d2d Added tag jdk7-b101 for changeset 4193eaf5f1b8 ! .hgtags Changeset: a191e79df156 Author: lana Date: 2010-06-29 10:48 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/rev/a191e79df156 Merge Changeset: 9cda7c220c08 Author: lana Date: 2010-07-12 19:35 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/rev/9cda7c220c08 Merge Changeset: a136a51f5113 Author: lana Date: 2010-07-20 22:17 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/rev/a136a51f5113 Merge From john.coomes at oracle.com Thu Jul 22 22:30:09 2010 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 23 Jul 2010 05:30:09 +0000 Subject: hg: jdk7/hotspot-rt/corba: 4 new changesets Message-ID: <20100723053013.D8C0847BCE@hg.openjdk.java.net> Changeset: d130544adab3 Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/corba/rev/d130544adab3 Added tag jdk7-b101 for changeset 86a239832646 ! .hgtags Changeset: 03fd3d78e344 Author: lana Date: 2010-06-29 10:48 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/corba/rev/03fd3d78e344 Merge Changeset: 98da66f47273 Author: lana Date: 2010-07-12 19:35 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/corba/rev/98da66f47273 Merge Changeset: 78561a957790 Author: lana Date: 2010-07-20 22:17 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/corba/rev/78561a957790 Merge From john.coomes at oracle.com Thu Jul 22 22:35:27 2010 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 23 Jul 2010 05:35:27 +0000 Subject: hg: jdk7/hotspot-rt/jaxp: 5 new changesets Message-ID: <20100723053527.8AAA447BD0@hg.openjdk.java.net> Changeset: c9bd73f6d584 Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxp/rev/c9bd73f6d584 Added tag jdk7-b101 for changeset 17f62a566a20 ! .hgtags Changeset: 34ed99f84832 Author: ohair Date: 2010-06-24 08:34 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxp/rev/34ed99f84832 6963941: Correct download link for source drop bundle Reviewed-by: darcy ! jaxp.properties Changeset: e46c304486c0 Author: lana Date: 2010-06-29 10:49 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxp/rev/e46c304486c0 Merge Changeset: 70c8a34e2eb6 Author: lana Date: 2010-07-12 19:37 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxp/rev/70c8a34e2eb6 Merge Changeset: 15573625af97 Author: lana Date: 2010-07-20 22:17 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxp/rev/15573625af97 Merge From john.coomes at oracle.com Thu Jul 22 22:36:03 2010 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 23 Jul 2010 05:36:03 +0000 Subject: hg: jdk7/hotspot-rt/jaxws: 4 new changesets Message-ID: <20100723053603.9FE2347BD1@hg.openjdk.java.net> Changeset: d1525c38428a Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxws/rev/d1525c38428a Added tag jdk7-b101 for changeset b55ce2744900 ! .hgtags Changeset: 2dd6394ddec2 Author: lana Date: 2010-06-29 10:49 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxws/rev/2dd6394ddec2 Merge Changeset: 2b7a1ec9562e Author: lana Date: 2010-07-12 19:37 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxws/rev/2b7a1ec9562e Merge Changeset: d8580443d181 Author: lana Date: 2010-07-20 22:17 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxws/rev/d8580443d181 Merge From john.coomes at oracle.com Thu Jul 22 22:38:47 2010 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 23 Jul 2010 05:38:47 +0000 Subject: hg: jdk7/hotspot-rt/jdk: 76 new changesets Message-ID: <20100723055105.5855547BD2@hg.openjdk.java.net> Changeset: 6c4450bbad6d Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/6c4450bbad6d Added tag jdk7-b101 for changeset d58354a69011 ! .hgtags Changeset: c801686d91f4 Author: prr Date: 2010-06-29 09:48 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/c801686d91f4 6943487: NPE in makeMultiCharsetString while printing on linux Reviewed-by: igor, jgodinez ! src/share/classes/sun/awt/PlatformFont.java ! src/share/classes/sun/java2d/HeadlessGraphicsEnvironment.java Changeset: 4da6837dd085 Author: lana Date: 2010-06-30 15:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/4da6837dd085 Merge Changeset: ab55cb957830 Author: igor Date: 2010-07-06 18:23 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/ab55cb957830 6967050: JDK build issues with cygwin/vc2010 Reviewed-by: prr, ohair ! make/common/shared/Defs-windows.gmk ! make/mkdemo/Makefile Changeset: e03065fc64e7 Author: igor Date: 2010-07-12 13:16 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/e03065fc64e7 6959998: Return of SurfaceData_InitOps point not checked in all cases (parfait found these) Reviewed-by: prr Contributed-by: ohair ! src/share/native/sun/awt/image/BufImgSurfaceData.c ! src/solaris/native/sun/java2d/opengl/GLXSurfaceData.c ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c ! src/windows/native/sun/java2d/opengl/WGLSurfaceData.c ! src/windows/native/sun/java2d/windows/GDIWindowSurfaceData.cpp Changeset: 2ad69cb576b4 Author: igor Date: 2010-07-12 15:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/2ad69cb576b4 6968373: FontUtilities static initializer throws AccessControlException Reviewed-by: prr ! src/share/classes/sun/font/FontUtilities.java ! test/java/awt/FontClass/FontPrivilege.java Changeset: 4a639bcd3361 Author: lana Date: 2010-07-12 19:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/4a639bcd3361 Merge Changeset: f5145c7119c2 Author: yan Date: 2010-06-24 11:50 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/f5145c7119c2 6957166: With XAWT, set arguments properly creating a MouseWheelEvent. Summary: swap some parameters to allow bigger values for click count. Reviewed-by: dav ! src/solaris/classes/sun/awt/X11/XWindow.java Changeset: bccf2a4ee318 Author: art Date: 2010-07-06 17:59 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/bccf2a4ee318 6424157: java.awt.EventQueue push/pop might cause threading issues Reviewed-by: ant, dcherepanov ! src/share/classes/java/awt/EventDispatchThread.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/sun/awt/SunToolkit.java ! test/java/awt/EventDispatchThread/HandleExceptionOnEDT/HandleExceptionOnEDT.java ! test/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.java + test/java/awt/EventDispatchThread/PreserveDispathThread/PreserveDispatchThread.java ! test/java/awt/EventQueue/PushPopDeadlock2/PushPopTest.java Changeset: 21b17c64df74 Author: dcherepanov Date: 2010-07-06 18:23 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/21b17c64df74 6966643: GTK FileDialog hangs when user manually closes it Reviewed-by: art ! src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.c Changeset: 9950dc616615 Author: dcherepanov Date: 2010-07-07 14:20 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/9950dc616615 6959174: Need to introduce sun.awt.disableGtkFileDialogs system property Reviewed-by: art, anthony ! src/share/classes/sun/awt/SunToolkit.java ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: 48aa2a1edd2b Author: lana Date: 2010-07-08 11:28 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/48aa2a1edd2b Merge Changeset: 2d8f060dd1c5 Author: lana Date: 2010-07-12 19:33 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/2d8f060dd1c5 Merge Changeset: 69ddf06e616a Author: malenkov Date: 2010-06-22 12:06 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/69ddf06e616a 6707234: Method returned by Introspector.internalFindMethod not necessarily most specific Reviewed-by: peterz ! src/share/classes/com/sun/beans/finder/MethodFinder.java ! src/share/classes/java/beans/EventSetDescriptor.java ! src/share/classes/java/beans/IndexedPropertyDescriptor.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/MethodDescriptor.java ! src/share/classes/java/beans/PropertyDescriptor.java + test/java/beans/Introspector/Test6707234.java Changeset: 5af3b0430bbe Author: peterz Date: 2010-06-22 14:36 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/5af3b0430bbe 6959260: javax/swing/JLabel/6501991/bug6501991.java failed on build 1.7.0-ea-b96 Reviewed-by: rupashka ! src/share/classes/sun/swing/SwingUtilities2.java ! test/ProblemList.txt ! test/com/sun/java/swing/plaf/gtk/Test6635110.java Changeset: dea63f6dda7a Author: alexp Date: 2010-06-22 19:38 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/dea63f6dda7a 6777378: NullPointerException in XPDefaultRenderer.paint() Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/basic/BasicTableHeaderUI.java + test/javax/swing/JTable/6777378/bug6777378.java Changeset: a05e047c5b98 Author: alexp Date: 2010-06-22 20:36 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/a05e047c5b98 6684401: JTree isExpanded should not call itself recursively Reviewed-by: rupashka ! src/share/classes/javax/swing/JTree.java Changeset: f1bafc4f249d Author: peterz Date: 2010-06-29 14:42 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/f1bafc4f249d 6963870: NPE in CompoundBorder.getInsets() Reviewed-by: alexp Contributed-by: jon.vanalten at redhat.com ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKPainter.java + test/com/sun/java/swing/plaf/gtk/Test6963870.java Changeset: c0e785f055a7 Author: lana Date: 2010-06-30 19:05 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/c0e785f055a7 Merge ! test/ProblemList.txt Changeset: d062afbe2107 Author: malenkov Date: 2010-07-01 18:09 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/d062afbe2107 4129681: Cannot get a title border to display its label as disabled Reviewed-by: alexp, rupashka ! src/share/classes/javax/swing/border/TitledBorder.java + test/javax/swing/border/Test4129681.html + test/javax/swing/border/Test4129681.java + test/javax/swing/border/Test4760089.html + test/javax/swing/border/Test4760089.java Changeset: 46306a419ba3 Author: malenkov Date: 2010-07-01 18:47 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/46306a419ba3 6959266: test javax/swing/JInternalFrame/6725409/bug6725409.java should be modified Reviewed-by: alexp ! test/javax/swing/JInternalFrame/6725409/bug6725409.java Changeset: e94a94d176f9 Author: alexp Date: 2010-07-02 19:28 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/e94a94d176f9 6711682: JCheckBox in JTable: checkbox doesn't alaways respond to the first mouse click Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/basic/BasicButtonListener.java + test/javax/swing/AbstractButton/6711682/bug6711682.java Changeset: 46d5aef470a3 Author: alexp Date: 2010-07-02 19:34 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/46d5aef470a3 6937415: Some components return undocumented default values under Nimbus LaF Reviewed-by: peterz ! src/share/classes/javax/swing/JSplitPane.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/plaf/nimbus/skin.laf Changeset: e12c92d2dc11 Author: rupashka Date: 2010-07-08 19:09 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/e12c92d2dc11 6520101: FileChooser will cause OutOfMemory when application will run long time Reviewed-by: peterz ! src/share/classes/com/sun/java/swing/plaf/motif/MotifFileChooserUI.java + test/javax/swing/JFileChooser/6520101/bug6520101.java Changeset: d0bcc9aa5a7a Author: malenkov Date: 2010-07-09 19:42 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/d0bcc9aa5a7a 6894597: test/closed/javax/swing/JPopupMenu/6495920/bug6495920.java fails Reviewed-by: alexp, peterz + test/javax/swing/JPopupMenu/6495920/bug6495920.java Changeset: 3dc686ecb4cd Author: malenkov Date: 2010-07-09 22:07 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/3dc686ecb4cd 6963811: Deadlock-prone locking changes in Introspector Reviewed-by: peterz, rupashka ! src/share/classes/com/sun/beans/finder/InstanceFinder.java ! src/share/classes/com/sun/beans/finder/PersistenceDelegateFinder.java ! src/share/classes/com/sun/beans/finder/PropertyEditorFinder.java ! src/share/classes/java/beans/Encoder.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/PropertyEditorManager.java + test/java/beans/Introspector/Test6963811.java + test/java/beans/PropertyEditor/Test6963811.java + test/java/beans/XMLEncoder/Test6963811.java Changeset: a93a7ed5018c Author: lana Date: 2010-07-12 19:35 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/a93a7ed5018c Merge Changeset: dd98b0b747ec Author: ohair Date: 2010-06-22 10:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/dd98b0b747ec 6931871: Rebranding of javadoc generation in makefiles 6951293: control docs target does not work on windows Reviewed-by: jjg + make/common/shared/Defs-javadoc.gmk ! make/docs/Makefile Changeset: d7fdaee81c14 Author: sherman Date: 2010-06-22 14:04 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/d7fdaee81c14 6963156: TEST_BUG: Several tests under sun/nio/cs failed Summary: Updated the test cases and removed them from ProblemList.txt Reviewed-by: alanb ! test/ProblemList.txt ! test/sun/nio/cs/FindDecoderBugs.java ! test/sun/nio/cs/TestX11CNS.java Changeset: 6fe3b86f4720 Author: sherman Date: 2010-06-22 14:22 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/6fe3b86f4720 Merge Changeset: 4e76be6e9fe1 Author: dcubed Date: 2010-06-22 10:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/4e76be6e9fe1 6942989: 2/2 Memory leak of java.lang.ref.WeakReference objects Summary: Use ReferenceQueues to manage WeakReferences in LogManager and Logger. Reviewed-by: dholmes, alanb, emcmanus, tonyp Contributed-by: jeremymanson at google.com ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/Logger.java + test/java/util/logging/AnonLoggerWeakRefLeak.java + test/java/util/logging/AnonLoggerWeakRefLeak.sh + test/java/util/logging/LoggerWeakRefLeak.java + test/java/util/logging/LoggerWeakRefLeak.sh Changeset: 600ef8b4a211 Author: dcubed Date: 2010-06-22 16:18 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/600ef8b4a211 Merge Changeset: 25fe5c3bf7b7 Author: ohair Date: 2010-06-22 17:07 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/25fe5c3bf7b7 6939022: Source code adjustments for parfait compilation Reviewed-by: jjg ! src/solaris/demo/jni/Poller/Poller.c Changeset: 848e69fcf2f3 Author: ohair Date: 2010-06-22 17:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/848e69fcf2f3 6933622: Duplicate class files in rt.jar and charsets.jar 6895003: JarReorder is not excluding a requested file. Reviewed-by: jjg ! make/common/Release.gmk ! make/tools/src/build/tools/jarreorder/JarReorder.java ! test/ProblemList.txt Changeset: 3c745249065f Author: ohair Date: 2010-06-22 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/3c745249065f Merge Changeset: 887e525597f8 Author: dsamersoff Date: 2010-06-23 17:25 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/887e525597f8 6931566: NetworkInterface is not working when interface name is more than 15 characters long Summary: Separate Linux and Solaris code, use lifreq under Solaris Reviewed-by: chegar ! src/solaris/native/java/net/NetworkInterface.c Changeset: eb84b89ef3ff Author: alanb Date: 2010-06-23 20:19 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/eb84b89ef3ff 6963027: TEST_BUG: channels and buffer tests need to run in samevm mode Reviewed-by: ohair, sherman, chegar ! test/Makefile ! test/ProblemList.txt ! test/java/nio/BufferPoolMXBean/Basic.java ! test/java/nio/MappedByteBuffer/Basic.java ! test/java/nio/MappedByteBuffer/Force.java ! test/java/nio/MappedByteBuffer/ZeroMap.java ! test/java/nio/channels/AsynchronousChannelGroup/GroupOfOne.java ! test/java/nio/channels/AsynchronousChannelGroup/Identity.java ! test/java/nio/channels/AsynchronousDatagramChannel/Basic.java ! test/java/nio/channels/AsynchronousFileChannel/Basic.java ! test/java/nio/channels/AsynchronousFileChannel/Lock.java ! test/java/nio/channels/AsynchronousFileChannel/LotsOfWrites.java ! test/java/nio/channels/AsynchronousSocketChannel/Basic.java ! test/java/nio/channels/Channels/Basic2.java ! test/java/nio/channels/Channels/Write.java ! test/java/nio/channels/DatagramChannel/AdaptDatagramSocket.java ! test/java/nio/channels/DatagramChannel/EmptyBuffer.java ! test/java/nio/channels/DatagramChannel/ReceiveISA.java ! test/java/nio/channels/DatagramChannel/SelectWhenRefused.java ! test/java/nio/channels/FileChannel/Args.java ! test/java/nio/channels/FileChannel/ClosedChannelTransfer.java ! test/java/nio/channels/FileChannel/ExpandingMap.java ! test/java/nio/channels/FileChannel/Lock.java ! test/java/nio/channels/FileChannel/MapOverEnd.java ! test/java/nio/channels/FileChannel/MapReadOnly.java ! test/java/nio/channels/FileChannel/MapTest.java ! test/java/nio/channels/FileChannel/Mode.java ! test/java/nio/channels/FileChannel/Position.java ! test/java/nio/channels/FileChannel/Pread.java ! test/java/nio/channels/FileChannel/Pwrite.java ! test/java/nio/channels/FileChannel/Read.java ! test/java/nio/channels/FileChannel/ReadFull.java ! test/java/nio/channels/FileChannel/ReadToLimit.java ! test/java/nio/channels/FileChannel/ReleaseOnCloseDeadlock.java ! test/java/nio/channels/FileChannel/ScatteringRead.java ! test/java/nio/channels/FileChannel/Size.java ! test/java/nio/channels/FileChannel/Transfer.java ! test/java/nio/channels/FileChannel/TransferToChannel.java ! test/java/nio/channels/FileChannel/TransferToNonWritable.java ! test/java/nio/channels/FileChannel/Transfers.java ! test/java/nio/channels/FileChannel/TryLock.java ! test/java/nio/channels/FileChannel/Write.java ! test/java/nio/channels/Pipe/NonBlocking.java ! test/java/nio/channels/Pipe/SelectPipe.java ! test/java/nio/channels/SelectionKey/AtomicAttachTest.java ! test/java/nio/channels/Selector/BasicAccept.java ! test/java/nio/channels/Selector/BasicConnect.java ! test/java/nio/channels/Selector/CheckLocking.java ! test/java/nio/channels/Selector/CloseInvalidatesKeys.java ! test/java/nio/channels/Selector/CloseWhenKeyIdle.java ! test/java/nio/channels/Selector/Connect.java ! test/java/nio/channels/Selector/ConnectWrite.java ! test/java/nio/channels/Selector/HelperSlowToDie.java ! test/java/nio/channels/Selector/KeysReady.java ! test/java/nio/channels/Selector/LotsOfChannels.java ! test/java/nio/channels/Selector/RegAfterPreClose.java ! test/java/nio/channels/Selector/SelectAndCancel.java ! test/java/nio/channels/Selector/SelectorLimit.java ! test/java/nio/channels/Selector/SelectorTest.java ! test/java/nio/channels/Selector/WakeupNow.java ! test/java/nio/channels/Selector/WakeupOverflow.java ! test/java/nio/channels/Selector/WakeupSpeed.java - test/java/nio/channels/ServerSocketChannel/AcceptAddress.java ! test/java/nio/channels/SocketChannel/AdaptSocket.java ! test/java/nio/channels/SocketChannel/Bind.java ! test/java/nio/channels/SocketChannel/Close.java ! test/java/nio/channels/SocketChannel/CloseRegisteredChannel.java ! test/java/nio/channels/SocketChannel/CloseTimeoutChannel.java ! test/java/nio/channels/SocketChannel/IsConnectable.java ! test/java/nio/channels/SocketChannel/LocalAddress.java ! test/java/nio/channels/SocketChannel/SocketInheritance.java ! test/java/nio/channels/SocketChannel/Trivial.java ! test/java/nio/channels/SocketChannel/UnboundSocketTests.java ! test/java/nio/channels/etc/Shadow.java ! test/java/nio/channels/spi/SelectorProvider/inheritedChannel/ClosedStreams.java ! test/sun/nio/ch/Basic.java ! test/sun/nio/ch/TempBuffer.java ! test/sun/nio/cs/ReadZero.java ! test/sun/nio/cs/Test4206507.java ! test/sun/nio/cs/TestStringCoding.java Changeset: 55aa27b8bb98 Author: alanb Date: 2010-06-23 21:22 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/55aa27b8bb98 Merge Changeset: c4d60bcce958 Author: darcy Date: 2010-06-23 17:03 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/c4d60bcce958 6911258: Project Coin: Add essential API support for Automatic Resource Management (ARM) blocks 6911261: Project Coin: Retrofit Automatic Resource Management (ARM) support onto platform APIs 6962571: Infinite loop in printing out Throwable stack traces with circular references Reviewed-by: darcy, alanb Contributed-by: jjb at google.com ! make/java/java/FILES_java.gmk ! src/share/classes/java/io/Closeable.java + src/share/classes/java/lang/AutoCloseable.java ! src/share/classes/java/lang/Throwable.java ! src/share/classes/java/nio/channels/FileLock.java ! src/share/classes/javax/imageio/stream/ImageInputStream.java + test/java/lang/Throwable/SuppressedExceptions.java Changeset: 706e2d1fc378 Author: weijun Date: 2010-06-24 14:26 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/706e2d1fc378 6958026: Problem with PKCS12 keystore Reviewed-by: mullan ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java + test/sun/security/pkcs12/PKCS12SameKeyId.java Changeset: 1da7dfca3e20 Author: weijun Date: 2010-06-24 14:26 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/1da7dfca3e20 6844907: krb5 etype order should be from strong to weak Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/Credentials.java ! src/share/classes/sun/security/krb5/internal/crypto/EType.java ! src/share/classes/sun/security/krb5/internal/ktab/KeyTab.java + test/sun/security/krb5/etype/ETypeOrder.java ! test/sun/security/krb5/ktab/HighestKvno.java Changeset: 9c0f542c8b37 Author: weijun Date: 2010-06-24 14:26 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/9c0f542c8b37 6946669: SSL/Krb5 should not call EncryptedData.reset(data, false) Reviewed-by: xuelei ! src/share/classes/sun/security/krb5/EncryptedData.java ! src/share/classes/sun/security/krb5/KrbApRep.java ! src/share/classes/sun/security/krb5/KrbApReq.java ! src/share/classes/sun/security/krb5/KrbAsRep.java ! src/share/classes/sun/security/krb5/KrbCred.java ! src/share/classes/sun/security/krb5/KrbPriv.java ! src/share/classes/sun/security/krb5/KrbTgsRep.java ! src/share/classes/sun/security/ssl/krb5/KerberosClientKeyExchangeImpl.java ! src/share/classes/sun/security/ssl/krb5/KerberosPreMasterSecret.java ! test/sun/security/krb5/auto/SSL.java Changeset: 2e9ef9a80d82 Author: ohair Date: 2010-06-25 08:44 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/2e9ef9a80d82 6964311: Build regression due to rt.jar contents change Summary: The fix for 6933622 regressed control builds, this is a workaround fix, filed 6964313 to find the right answer to why it happened and how to fix it correctly. Reviewed-by: alanb, darcy ! make/common/Release.gmk Changeset: 6bf403a14da4 Author: alanb Date: 2010-06-25 18:31 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/6bf403a14da4 6963828: TEST_BUG: java/nio/channels/FileTransfer.java takes too long (win) Reviewed-by: chegar ! test/java/nio/channels/FileChannel/Transfer.java Changeset: 0995c5a2dc6d Author: alanb Date: 2010-06-25 18:34 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/0995c5a2dc6d Merge Changeset: 6d274503d1b7 Author: chegar Date: 2010-06-28 14:55 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/6d274503d1b7 6954525: Testcase failure java/net/Authenticator/B4769350.java Reviewed-by: michaelm, weijun ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! test/java/net/Authenticator/B4769350.java Changeset: a89f8c292a5b Author: chegar Date: 2010-06-28 15:06 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/a89f8c292a5b Merge Changeset: 7c3da1f0e17c Author: chegar Date: 2010-06-28 20:52 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/7c3da1f0e17c 6961029: java/net/BindException/Test.java should not use wildcard address Reviewed-by: michaelm, alanb ! test/ProblemList.txt ! test/java/net/BindException/Test.java ! test/java/net/ipv6tests/Tests.java Changeset: a9e0a6fb6057 Author: ksrini Date: 2010-06-28 18:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/a9e0a6fb6057 6856415: Enabling java security manager will make programe thrown wrong exception ( main method not found ) Reviewed-by: darcy ! src/share/classes/sun/launcher/LauncherHelper.java + test/tools/launcher/VerifyExceptions.java Changeset: 5c5fe62d990d Author: alanb Date: 2010-06-29 17:11 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/5c5fe62d990d 6213702: (so) non-blocking sockets with TCP urgent disabled get still selected for read ops (win) Reviewed-by: michaelm, chegar ! src/windows/classes/sun/nio/ch/WindowsSelectorImpl.java ! src/windows/native/sun/nio/ch/WindowsSelectorImpl.c + test/java/nio/channels/Selector/OutOfBand.java Changeset: b318df97820f Author: lana Date: 2010-06-29 10:50 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/b318df97820f Merge Changeset: 4436a3e97a9b Author: martin Date: 2010-06-30 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/4436a3e97a9b 6934268: Better implementation of Character.isValidCodePoint Summary: Use the cleverest possible bit-twiddling micro-optimizations Reviewed-by: sherman Contributed-by: Ulf Zibis ! src/share/classes/java/lang/Character.java Changeset: 1776791f4fb9 Author: martin Date: 2010-06-30 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/1776791f4fb9 6934265: Add public method Character.isBmpCodePoint Summary: Move isBmpCodePoint from sun.nio.cs.Surrogate to Character Reviewed-by: sherman Contributed-by: Ulf Zibis ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/String.java ! src/share/classes/sun/io/CharToByteDBCS_ASCII.java ! src/share/classes/sun/io/CharToByteDBCS_EBCDIC.java ! src/share/classes/sun/nio/cs/Surrogate.java ! src/share/classes/sun/nio/cs/UTF_32Coder.java ! src/share/classes/sun/nio/cs/UTF_8.java ! src/share/classes/sun/nio/cs/ext/EUC_TW.java ! src/share/classes/sun/nio/cs/ext/GB18030.java ! src/share/classes/sun/nio/cs/ext/IBM33722.java ! src/share/classes/sun/nio/cs/ext/IBM964.java ! test/java/nio/charset/coders/BashStreams.java - test/java/nio/charset/coders/Surrogate.java ! test/java/nio/charset/coders/Surrogates.java Changeset: 5503dbb2e6cc Author: martin Date: 2010-06-30 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/5503dbb2e6cc 6937112: String.lastIndexOf confused by unpaired trailing surrogate Summary: Rewrite lastIndexOf for performance and correctness Reviewed-by: sherman Contributed-by: Reviewed by Ulf Zibis ! src/share/classes/java/lang/String.java ! test/java/lang/String/Supplementary.java ! test/java/lang/StringBuffer/Supplementary.java ! test/java/lang/StringBuilder/Supplementary.java Changeset: 5e9daa8fd04a Author: martin Date: 2010-06-30 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/5e9daa8fd04a 6940381: Wording improvements for String.indexOf, String.lastIndexOf Summary: Make wording of javadoc clearer and more consistent Reviewed-by: sherman ! src/share/classes/java/lang/String.java Changeset: 0d2bff3b2ca6 Author: martin Date: 2010-06-30 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/0d2bff3b2ca6 6963749: Minor improvements to Character.UnicodeBlock Summary: Fix surrogate area docs; make source more readable Reviewed-by: okutsu, sherman Contributed-by: Ulf Zibis ! src/share/classes/java/lang/Character.java Changeset: 4f1b4e3c6d1b Author: martin Date: 2010-06-30 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/4f1b4e3c6d1b 6934270: Remove javac warnings from Character.java Summary: Use generics and conform to coding style Reviewed-by: sherman Contributed-by: Ulf Zibis ! src/share/classes/java/lang/Character.java Changeset: 98186c162c1e Author: martin Date: 2010-06-30 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/98186c162c1e 6933322: Add methods highSurrogate(), lowSurrogate() to class Character Summary: Add public variants of methods Surrogate.high, Surrogate.low Reviewed-by: okutsu, sherman Contributed-by: Ulf Zibis ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/String.java ! src/share/classes/sun/nio/cs/Surrogate.java ! src/share/classes/sun/nio/cs/UTF_32Coder.java ! src/share/classes/sun/nio/cs/UTF_8.java ! src/share/classes/sun/nio/cs/UnicodeEncoder.java ! src/share/classes/sun/nio/cs/ext/EUC_TW.java ! test/java/nio/charset/coders/BashStreams.java Changeset: 838a21b99591 Author: martin Date: 2010-06-30 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/838a21b99591 6934271: Better handling of longer utf-8 sequences Summary: Various cleanups, including clever bit-twiddling Reviewed-by: sherman ! src/share/classes/sun/nio/cs/UTF_8.java Changeset: 9c80da212eaf Author: martin Date: 2010-06-30 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/9c80da212eaf 6935172: Optimize bit-twiddling in Bits.java Summary: Transformations to reduce size of bytecode Reviewed-by: sherman Contributed-by: Based on an idea by Ulf Zibis ! src/share/classes/java/io/Bits.java Changeset: ce0ba8da0bd1 Author: martin Date: 2010-06-30 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/ce0ba8da0bd1 6940258: (bf) Use intrinsified reverseBytes operation; elide no-op constructs Reviewed-by: alanb, sherman Contributed-by: Ulf Zibis ! src/share/classes/java/nio/Bits.java Changeset: a5a34c696d62 Author: alanb Date: 2010-07-01 16:28 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/a5a34c696d62 6947216: Even more Dual-pivot quicksort improvements Reviewed-by: jjb Contributed-by: vladimir.yaroslavskiy at sun.com ! src/share/classes/java/util/DualPivotQuicksort.java ! test/java/util/Arrays/Sorting.java Changeset: 9bffc32b645d Author: mullan Date: 2010-07-01 15:20 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/9bffc32b645d 6782979: Add JNLPAppletLauncher (6618105) to blacklist Reviewed-by: ohair ! make/java/security/Makefile Changeset: c0d2a097eb99 Author: mullan Date: 2010-07-01 15:30 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/c0d2a097eb99 Merge Changeset: 425960cef714 Author: darcy Date: 2010-07-06 18:58 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/425960cef714 6963723: Project Coin: Retrofit more JDK classes for ARM Reviewed-by: alanb, malenkov, prr, amenkov ! src/share/classes/java/beans/XMLDecoder.java ! src/share/classes/java/beans/XMLEncoder.java ! src/share/classes/java/io/ObjectInput.java ! src/share/classes/java/io/ObjectOutput.java ! src/share/classes/java/util/Scanner.java ! src/share/classes/javax/sound/midi/MidiDevice.java ! src/share/classes/javax/sound/midi/Receiver.java ! src/share/classes/javax/sound/midi/Transmitter.java ! src/share/classes/javax/sound/sampled/Line.java Changeset: d6f8ffc3c54a Author: ohair Date: 2010-07-07 10:17 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/d6f8ffc3c54a 6954517: Testcase failure tools/launcher/UnicodeTest.sh Reviewed-by: ksrini ! test/tools/launcher/UnicodeTest.sh Changeset: f13e94562d84 Author: ksrini Date: 2010-07-09 09:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/f13e94562d84 6930056: (launcher) Need to remove or build as part of test these liblibrary.so files Reviewed-by: ohair, darcy - test/tools/launcher/Makefile.SolarisRunpath - test/tools/launcher/lib/i386/lib32/lib32/liblibrary.so - test/tools/launcher/lib/i386/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib64/lib64/liblibrary.so - test/tools/launcher/lib/sparc/lib64/liblibrary.so Changeset: da8526047e5f Author: martin Date: 2010-07-09 18:55 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/da8526047e5f 6967533: Epoch bug: ExceptionInInitializerError on systems with uninitialized clock Summary: Remove (hopefully!) unnecessary check of currentTimeMillis Reviewed-by: dholmes Contributed-by: Jon VanAlten ! src/share/classes/java/lang/System.java Changeset: a7f8f269f741 Author: chegar Date: 2010-07-12 18:13 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/a7f8f269f741 6967937: Scope id no longer being set after 6931566 Reviewed-by: alanb, dsamersoff ! src/solaris/native/java/net/NetworkInterface.c ! test/java/net/Inet6Address/B6214234.java Changeset: 1371a2d5f3a8 Author: chegar Date: 2010-07-12 18:16 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/1371a2d5f3a8 6967684: httpserver using a non thread-safe SimpleDateFormat Reviewed-by: michaelm ! src/share/classes/sun/net/httpserver/ExchangeImpl.java Changeset: bb0b32ffefe9 Author: chegar Date: 2010-07-12 18:18 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/bb0b32ffefe9 6966846: Incorrect assertion in java.net.Inet6Address.readObject Reviewed-by: michaelm ! src/share/classes/java/net/Inet6Address.java Changeset: d3fa95d0710c Author: ksrini Date: 2010-07-09 11:04 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/d3fa95d0710c 6921472: RFE: java launcher code needs clean up Summary: This changeset also contains fixes for 6405284, 6753938 and 6922500 Reviewed-by: darcy ! src/share/bin/emessages.h ! src/share/bin/java.c ! src/share/bin/java.h ! src/share/bin/jli_util.c ! src/share/bin/jli_util.h ! src/solaris/bin/java_md.c ! src/windows/bin/java_md.c ! test/tools/launcher/Arrrghs.java Changeset: ddf825161d2d Author: dcubed Date: 2010-07-12 14:19 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/ddf825161d2d 6968401: 3/3 disable tests added by 6942989 until 6964018 is fixed Summary: Disable AnonLoggerWeakRefLeak.sh and LoggerWeakRefLeak.sh Reviewed-by: ohair ! test/java/util/logging/AnonLoggerWeakRefLeak.sh ! test/java/util/logging/LoggerWeakRefLeak.sh Changeset: 4e365ef6576d Author: dcubed Date: 2010-07-12 15:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/4e365ef6576d Merge Changeset: c5a436f053aa Author: lana Date: 2010-07-12 19:42 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/c5a436f053aa Merge ! test/ProblemList.txt - test/java/nio/channels/ServerSocketChannel/AcceptAddress.java - test/java/nio/charset/coders/Surrogate.java - test/tools/launcher/Makefile.SolarisRunpath - test/tools/launcher/lib/i386/lib32/lib32/liblibrary.so - test/tools/launcher/lib/i386/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib64/lib64/liblibrary.so - test/tools/launcher/lib/sparc/lib64/liblibrary.so Changeset: 13029a61b16b Author: lana Date: 2010-07-20 22:21 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/13029a61b16b Merge - test/java/nio/channels/ServerSocketChannel/AcceptAddress.java - test/java/nio/charset/coders/Surrogate.java - test/tools/launcher/Makefile.SolarisRunpath - test/tools/launcher/lib/i386/lib32/lib32/liblibrary.so - test/tools/launcher/lib/i386/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib64/lib64/liblibrary.so - test/tools/launcher/lib/sparc/lib64/liblibrary.so From john.coomes at oracle.com Thu Jul 22 23:02:35 2010 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 23 Jul 2010 06:02:35 +0000 Subject: hg: jdk7/hotspot-rt/langtools: 8 new changesets Message-ID: <20100723060252.7EC9047BD3@hg.openjdk.java.net> Changeset: f87f1f3e23e1 Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/f87f1f3e23e1 Added tag jdk7-b101 for changeset 20a8fe72ee7b ! .hgtags Changeset: be5cafeb318d Author: darcy Date: 2010-06-23 16:51 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/be5cafeb318d 6911258: Project Coin: Add essential API support for Automatic Resource Management (ARM) blocks Reviewed-by: darcy, alanb Contributed-by: jjb at google.com ! src/share/classes/javax/lang/model/element/ElementKind.java Changeset: d8a15fda7e3a Author: jjg Date: 2010-06-24 10:34 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/d8a15fda7e3a 6917288: Unnamed nested class is not generated Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/6917288/GraphicalInstaller.java + test/tools/javac/6917288/GraphicalInstallerTest.java + test/tools/javac/6917288/T6917288.java Changeset: 6386f0fd6205 Author: lana Date: 2010-06-29 12:06 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/6386f0fd6205 Merge ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/util/Names.java Changeset: d2b7ecf33b35 Author: jjg Date: 2010-06-30 18:06 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/d2b7ecf33b35 6964768: need test program to validate javac resource bundles Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/CheckResourceKeys.java ! test/tools/javac/literals/BadUnderscoreLiterals.6.out Changeset: 064468702a8d Author: jjg Date: 2010-07-12 16:37 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/064468702a8d 6968497: localized text appears in raw diagnostic Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/comp/Check.java ! test/tools/javac/generics/6946618/T6946618c.java ! test/tools/javac/generics/6946618/T6946618c.out Changeset: eaab979c8b36 Author: lana Date: 2010-07-12 19:43 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/eaab979c8b36 Merge Changeset: ff9c0a0bf7ed Author: lana Date: 2010-07-20 22:22 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/ff9c0a0bf7ed Merge From kevin.walls at oracle.com Tue Jul 20 05:20:48 2010 From: kevin.walls at oracle.com (Kevin Walls) Date: Tue, 20 Jul 2010 13:20:48 +0100 Subject: Review request: 6581734 CMS Old Gen's collection usage is zero after GC which is incorrect Message-ID: <4C4594A0.2030509@oracle.com> Hi - This is a review request for the issue where cms doesn't update the statistics used by the MemoryPoolMXBean system: only concurrent mode failures update the stats. We just aren't prepared for concurrent collections, so it takes a fair amount of customisation to add that flexibility... http://cr.openjdk.java.net/~kevinw/6581734/webrev/ Thanks Kevin From vincent.x.ryan at oracle.com Fri Jul 23 09:41:36 2010 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Fri, 23 Jul 2010 16:41:36 +0000 Subject: hg: jdk7/tl/jdk: 6676075: RegistryContext (com.sun.jndi.url.rmi.rmiURLContext) coding problem Message-ID: <20100723164145.8FF9A47BF7@hg.openjdk.java.net> Changeset: 748f004aeb5c Author: vinnie Date: 2010-07-23 17:41 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/748f004aeb5c 6676075: RegistryContext (com.sun.jndi.url.rmi.rmiURLContext) coding problem Reviewed-by: mullan ! src/share/classes/com/sun/jndi/rmi/registry/RegistryContext.java + test/com/sun/jndi/rmi/registry/RegistryContext/ContextWithNullProperties.java From mandy.chung at oracle.com Fri Jul 23 12:07:23 2010 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 23 Jul 2010 12:07:23 -0700 Subject: Review request: 6581734 CMS Old Gen's collection usage is zero after GC which is incorrect In-Reply-To: <4C4594A0.2030509@oracle.com> References: <4C4594A0.2030509@oracle.com> Message-ID: <4C49E86B.4000704@oracle.com> Kevin, As I know, you're revising the fix for the 6 update release. I'll review your revised webrev when it's ready. Thanks Mandy Kevin Walls wrote: > Hi - > > This is a review request for the issue where cms doesn't update the > statistics used by the MemoryPoolMXBean system: only concurrent mode > failures update the stats. We just aren't prepared for concurrent > collections, so it takes a fair amount of customisation to add that > flexibility... > > http://cr.openjdk.java.net/~kevinw/6581734/webrev/ > > Thanks > Kevin > > > > > From daniel.daugherty at oracle.com Fri Jul 23 17:48:02 2010 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Fri, 23 Jul 2010 18:48:02 -0600 Subject: need a code review for a quick test fix (6971847) Message-ID: <4C4A3842.4030103@oracle.com> Greetings, Porting my most recent batch of test fixes to OpenJDK6 revealed two new bugs: 6971847 4/4 jmap '-histo:live' option is necessary for proper leak detection 6971851 4/4 jmap prints an incorrect usage message when SA is not present 6971847 was partially introduced in the original bug that introduced these tests (6942989) and the remainder was introduced by the fix for 6964018 which fixed the tests on Linux. Yes, fixing the tests on Linux broke them for OpenJDK6 on Windows. 6971851 was introduced when then 'jmap -histo:live' option was added back in JDK6. I have a fix in hand for 6971847 and it gets the new AnonLoggerWeakRefLeak and LoggerWeakRefLeak tests working properly on OpenJDK6 on Windows. This should be (knock on wood) the last fix to these tests as the tests have now been checked out via JPRT on all the configs of interest. Here is the webrev URL: http://cr.openjdk.java.net/~dcubed/6971847-webrev/0/ Thanks, in advance, for any reviews. Dan From Alan.Bateman at oracle.com Sat Jul 24 05:14:41 2010 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Sat, 24 Jul 2010 13:14:41 +0100 Subject: need a code review for a quick test fix (6971847) In-Reply-To: <4C4A3842.4030103@oracle.com> References: <4C4A3842.4030103@oracle.com> Message-ID: <4C4AD931.2020708@oracle.com> Daniel D. Daugherty wrote: > Greetings, > > Porting my most recent batch of test fixes to OpenJDK6 revealed > two new bugs: > > 6971847 4/4 jmap '-histo:live' option is necessary for proper leak > detection > 6971851 4/4 jmap prints an incorrect usage message when SA is not > present > > 6971847 was partially introduced in the original bug that introduced > these tests (6942989) and the remainder was introduced by the fix > for 6964018 which fixed the tests on Linux. Yes, fixing the tests on > Linux broke them for OpenJDK6 on Windows. 6971851 was introduced when > then 'jmap -histo:live' option was added back in JDK6. > > I have a fix in hand for 6971847 and it gets the new > AnonLoggerWeakRefLeak > and LoggerWeakRefLeak tests working properly on OpenJDK6 on Windows. This > should be (knock on wood) the last fix to these tests as the tests have > now been checked out via JPRT on all the configs of interest. > > Here is the webrev URL: > > http://cr.openjdk.java.net/~dcubed/6971847-webrev/0/ > > Thanks, in advance, for any reviews. > > Dan I assume you are running into this because the SA bits weren't shipped with jdk6. For the issue at hand, then the simplest solution may be just remove the check for -histo:live from the tests. It shouldn't be needed anyway because the live sub-option is there since jdk6. -Alan. From xuelei.fan at sun.com Sat Jul 24 08:50:07 2010 From: xuelei.fan at sun.com (xuelei.fan at sun.com) Date: Sat, 24 Jul 2010 15:50:07 +0000 Subject: hg: jdk7/tl/jdk: 6867345: Turkish regional options cause NPE in sun.security.x509.AlgorithmId.algOID Message-ID: <20100724155038.B868B47C36@hg.openjdk.java.net> Changeset: 56217857ccd7 Author: xuelei Date: 2010-07-24 22:59 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/56217857ccd7 6867345: Turkish regional options cause NPE in sun.security.x509.AlgorithmId.algOID Reviewed-by: mullan, weijun ! src/share/classes/sun/security/krb5/Credentials.java ! src/share/classes/sun/security/pkcs/PKCS9Attribute.java ! src/share/classes/sun/security/pkcs11/P11Cipher.java ! src/share/classes/sun/security/pkcs11/P11RSACipher.java ! src/share/classes/sun/security/provider/certpath/URICertStore.java ! src/share/classes/sun/security/util/Debug.java ! src/share/classes/sun/security/x509/AVA.java ! src/share/classes/sun/security/x509/AlgorithmId.java ! src/share/classes/sun/security/x509/DNSName.java ! src/share/classes/sun/security/x509/RFC822Name.java + test/sun/security/x509/AlgorithmId/TurkishRegion.java From daniel.daugherty at oracle.com Sat Jul 24 09:57:33 2010 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Sat, 24 Jul 2010 10:57:33 -0600 Subject: need a code review for a quick test fix (6971847) In-Reply-To: <4C4AD931.2020708@oracle.com> References: <4C4A3842.4030103@oracle.com> <4C4AD931.2020708@oracle.com> Message-ID: <4C4B1B7D.7010808@oracle.com> On 7/24/2010 6:14 AM, Alan Bateman wrote: > Daniel D. Daugherty wrote: >> Greetings, >> >> Porting my most recent batch of test fixes to OpenJDK6 revealed >> two new bugs: >> >> 6971847 4/4 jmap '-histo:live' option is necessary for proper leak >> detection >> 6971851 4/4 jmap prints an incorrect usage message when SA is not >> present >> >> 6971847 was partially introduced in the original bug that introduced >> these tests (6942989) and the remainder was introduced by the fix >> for 6964018 which fixed the tests on Linux. Yes, fixing the tests on >> Linux broke them for OpenJDK6 on Windows. 6971851 was introduced when >> then 'jmap -histo:live' option was added back in JDK6. >> >> I have a fix in hand for 6971847 and it gets the new >> AnonLoggerWeakRefLeak >> and LoggerWeakRefLeak tests working properly on OpenJDK6 on Windows. >> This >> should be (knock on wood) the last fix to these tests as the tests have >> now been checked out via JPRT on all the configs of interest. >> >> Here is the webrev URL: >> >> http://cr.openjdk.java.net/~dcubed/6971847-webrev/0/ >> >> Thanks, in advance, for any reviews. >> >> Dan > I assume you are running into this because the SA bits weren't shipped > with jdk6. Yes and the fact that the jmap usage message is wrong (the other bug). > For the issue at hand, then the simplest solution may be just remove > the check for -histo:live from the tests. It shouldn't be needed > anyway because the live sub-option is there since jdk6. The 'histo:live' check gives me a helpful usage message rather than a vague one. I would prefer to keep the check. Would you be okay with the fix as is? Dan From Alan.Bateman at oracle.com Sat Jul 24 12:14:46 2010 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Sat, 24 Jul 2010 20:14:46 +0100 Subject: need a code review for a quick test fix (6971847) In-Reply-To: <4C4B1B7D.7010808@oracle.com> References: <4C4A3842.4030103@oracle.com> <4C4AD931.2020708@oracle.com> <4C4B1B7D.7010808@oracle.com> Message-ID: <4C4B3BA6.7020307@oracle.com> Daniel D. Daugherty wrote: > : > The 'histo:live' check gives me a helpful usage message rather > than a vague one. I would prefer to keep the check. Would you > be okay with the fix as is? I don't have a strong objection to the proposed change but the check seems to be only useful to catch the case where someone is running these jdk6 or jdk7 tests on jdk5. It was useful that it caught the problem with the usage message but I think the simplest fix is to just remove lines 55 and 58-65 from both tests. -Alan. From daniel.daugherty at oracle.com Sat Jul 24 12:33:03 2010 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Sat, 24 Jul 2010 13:33:03 -0600 Subject: need a code review for a quick test fix (6971847) In-Reply-To: <4C4B3BA6.7020307@oracle.com> References: <4C4A3842.4030103@oracle.com> <4C4AD931.2020708@oracle.com> <4C4B1B7D.7010808@oracle.com> <4C4B3BA6.7020307@oracle.com> Message-ID: <4C4B3FEF.2090204@oracle.com> On 7/24/2010 1:14 PM, Alan Bateman wrote: > Daniel D. Daugherty wrote: >> : >> The 'histo:live' check gives me a helpful usage message rather >> than a vague one. I would prefer to keep the check. Would you >> be okay with the fix as is? > I don't have a strong objection to the proposed change but the check > seems to be only useful to catch the case where someone is running > these jdk6 or jdk7 tests on jdk5. It was useful that it caught the > problem with the usage message but I think the simplest fix is to just > remove lines 55 and 58-65 from both tests. No argument about simpler. Yes, JDK5 is exactly what I'm worried about. Since the original bug (6942989) is escalated and the original problem goes all the way back to JDK1.4.0, I expect this fix to be backported to earlier releases. Rather than have a vague failure buried in the .jmap file, I would prefer a more clear message that says why the test isn't working. Dan From joe.darcy at oracle.com Fri Jul 23 09:38:34 2010 From: joe.darcy at oracle.com (Joe Darcy) Date: Fri, 23 Jul 2010 09:38:34 -0700 Subject: need a code review for a quick test fix (6971847) In-Reply-To: <4C4B3FEF.2090204@oracle.com> References: <4C4A3842.4030103@oracle.com> <4C4AD931.2020708@oracle.com> <4C4B1B7D.7010808@oracle.com> <4C4B3BA6.7020307@oracle.com> <4C4B3FEF.2090204@oracle.com> Message-ID: <4C49C58A.8080404@oracle.com> Daniel D. Daugherty wrote: > On 7/24/2010 1:14 PM, Alan Bateman wrote: >> Daniel D. Daugherty wrote: >>> : >>> The 'histo:live' check gives me a helpful usage message rather >>> than a vague one. I would prefer to keep the check. Would you >>> be okay with the fix as is? >> I don't have a strong objection to the proposed change but the check >> seems to be only useful to catch the case where someone is running >> these jdk6 or jdk7 tests on jdk5. It was useful that it caught the >> problem with the usage message but I think the simplest fix is to >> just remove lines 55 and 58-65 from both tests. > > No argument about simpler. > > Yes, JDK5 is exactly what I'm worried about. Since the original > bug (6942989) is escalated and the original problem goes all the > way back to JDK1.4.0, I expect this fix to be backported to > earlier releases. Rather than have a vague failure buried in > the .jmap file, I would prefer a more clear message that > says why the test isn't working. > If you'd like to keep the test code the same across releases, the current fix is fine for OpenJDK 6. Otherwise, Alan's suggestion could be followed. -Joe From daniel.daugherty at oracle.com Sun Jul 25 00:06:30 2010 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Sun, 25 Jul 2010 01:06:30 -0600 Subject: need a code review for a quick test fix (6971847) In-Reply-To: <4C49C58A.8080404@oracle.com> References: <4C4A3842.4030103@oracle.com> <4C4AD931.2020708@oracle.com> <4C4B1B7D.7010808@oracle.com> <4C4B3BA6.7020307@oracle.com> <4C4B3FEF.2090204@oracle.com> <4C49C58A.8080404@oracle.com> Message-ID: <4C4BE276.9040102@oracle.com> On 7/23/2010 10:38 AM, Joe Darcy wrote: > Daniel D. Daugherty wrote: >> On 7/24/2010 1:14 PM, Alan Bateman wrote: >>> Daniel D. Daugherty wrote: >>>> : >>>> The 'histo:live' check gives me a helpful usage message rather >>>> than a vague one. I would prefer to keep the check. Would you >>>> be okay with the fix as is? >>> I don't have a strong objection to the proposed change but the check >>> seems to be only useful to catch the case where someone is running >>> these jdk6 or jdk7 tests on jdk5. It was useful that it caught the >>> problem with the usage message but I think the simplest fix is to >>> just remove lines 55 and 58-65 from both tests. >> >> No argument about simpler. >> >> Yes, JDK5 is exactly what I'm worried about. Since the original >> bug (6942989) is escalated and the original problem goes all the >> way back to JDK1.4.0, I expect this fix to be backported to >> earlier releases. Rather than have a vague failure buried in >> the .jmap file, I would prefer a more clear message that >> says why the test isn't working. >> > > If you'd like to keep the test code the same across releases, the > current fix is fine for OpenJDK 6. Otherwise, Alan's suggestion could > be followed. Yes, I would prefer that the test code be the same across releases. Thanks for approval for OpenJDK6. Dan From Alan.Bateman at oracle.com Sun Jul 25 03:48:24 2010 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Sun, 25 Jul 2010 11:48:24 +0100 Subject: need a code review for a quick test fix (6971847) In-Reply-To: <4C4BE276.9040102@oracle.com> References: <4C4A3842.4030103@oracle.com> <4C4AD931.2020708@oracle.com> <4C4B1B7D.7010808@oracle.com> <4C4B3BA6.7020307@oracle.com> <4C4B3FEF.2090204@oracle.com> <4C49C58A.8080404@oracle.com> <4C4BE276.9040102@oracle.com> Message-ID: <4C4C1678.80108@oracle.com> Daniel D. Daugherty wrote: > : > Yes, I would prefer that the test code be the same across > releases. Thanks for approval for OpenJDK6. It makes sense to use the same test for jdk6 and jdk7 but it's not clear to me that these tests are useful for the older proprietary releases. For starters, we didn't have -histo:live so the test will fail. Also, I think Windows will bite you again because we didn't include jmap on Windows until jdk6. My guess is you'll need a completely different test. Anyway, as I said, I don't have any objection to the proposed test changes and I'm just pointing you that we shouldn't need any of this detection code in the tests checked into the jdk6 and jdk7 repos. -Alan. From daniel.daugherty at oracle.com Sun Jul 25 09:36:08 2010 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Sun, 25 Jul 2010 10:36:08 -0600 Subject: need a code review for a quick test fix (6971847) In-Reply-To: <4C4C1678.80108@oracle.com> References: <4C4A3842.4030103@oracle.com> <4C4AD931.2020708@oracle.com> <4C4B1B7D.7010808@oracle.com> <4C4B3BA6.7020307@oracle.com> <4C4B3FEF.2090204@oracle.com> <4C49C58A.8080404@oracle.com> <4C4BE276.9040102@oracle.com> <4C4C1678.80108@oracle.com> Message-ID: <4C4C67F8.5070902@oracle.com> On 7/25/2010 4:48 AM, Alan Bateman wrote: > Daniel D. Daugherty wrote: >> : >> Yes, I would prefer that the test code be the same across >> releases. Thanks for approval for OpenJDK6. > It makes sense to use the same test for jdk6 and jdk7 but it's not > clear to me that these tests are useful for the older proprietary > releases. For starters, we didn't have -histo:live so the test will > fail. Also, I think Windows will bite you again because we didn't > include jmap on Windows until jdk6. My guess is you'll need a > completely different test. Anyway, as I said, I don't have any > objection to the proposed test changes and I'm just pointing you that > we shouldn't need any of this detection code in the tests checked into > the jdk6 and jdk7 repos. Thanks Alan! Dan From andrei.pangin at sun.com Sun Jul 25 11:21:20 2010 From: andrei.pangin at sun.com (andrei.pangin at sun.com) Date: Sun, 25 Jul 2010 18:21:20 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 39 new changesets Message-ID: <20100725182226.BCF4547C6C@hg.openjdk.java.net> Changeset: f56e28f22410 Author: trims Date: 2010-06-03 18:18 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/f56e28f22410 6958458: Bump the HS19 build number to 03 Summary: Update the HS19 build number to 03 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 49242b3df6cd Author: mikejwre Date: 2010-06-03 13:30 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/49242b3df6cd Added tag jdk7-b96 for changeset 573e8ea5fd68 ! .hgtags Changeset: 5f42499e57ad Author: trims Date: 2010-06-04 11:43 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/5f42499e57ad Added tag hs19-b02 for changeset 573e8ea5fd68 ! .hgtags Changeset: b0e7cd862748 Author: mikejwre Date: 2010-06-10 13:58 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/b0e7cd862748 Added tag jdk7-b97 for changeset 5f42499e57ad ! .hgtags Changeset: 70191885f707 Author: prr Date: 2010-06-16 09:42 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/70191885f707 6961079: Build JDK7 for 64 bit Windows using free Windows 7.1 SDK 64 bit compilers Reviewed-by: ohair, jcoomes ! make/windows/makefiles/defs.make Changeset: 8a045b3f5c13 Author: mikejwre Date: 2010-06-16 15:48 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/8a045b3f5c13 Merge Changeset: 695c43156a9a Author: mikejwre Date: 2010-06-17 16:27 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/695c43156a9a Added tag jdk7-b98 for changeset 8a045b3f5c13 ! .hgtags Changeset: c69846936352 Author: trims Date: 2010-06-17 23:59 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/c69846936352 Merge Changeset: e848dd13e1b6 Author: trims Date: 2010-06-18 00:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/e848dd13e1b6 Merge Changeset: 606df121c181 Author: trims Date: 2010-06-04 11:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/606df121c181 Merge Changeset: 6a236384a379 Author: trims Date: 2010-06-18 00:19 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/6a236384a379 Merge Changeset: b34c75c0b6b8 Author: mikejwre Date: 2010-06-24 20:03 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/b34c75c0b6b8 Added tag jdk7-b99 for changeset 6a236384a379 ! .hgtags Changeset: e13a5c0ed5e2 Author: prr Date: 2010-06-29 16:33 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/e13a5c0ed5e2 6964882: 32 bit JDK does not build on 64 bit Windows platforms Reviewed-by: ohair, valeriep ! make/windows/makefiles/defs.make Changeset: ad1977f08c4d Author: mikejwre Date: 2010-06-30 18:57 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/ad1977f08c4d Merge Changeset: 871d2aa321f7 Author: trims Date: 2010-07-02 01:36 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/871d2aa321f7 Merge Changeset: 7cc68a696c62 Author: trims Date: 2010-07-02 01:37 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/7cc68a696c62 6966252: Bump the HS19 build number to 04 Summary: Update the HS19 build number to 04 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 56cc7e01da2f Author: trims Date: 2010-07-09 00:31 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/56cc7e01da2f Added tag hs19-b03 for changeset ad1977f08c4d ! .hgtags Changeset: 1dbaff4aa23a Author: trims Date: 2010-07-09 00:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/1dbaff4aa23a Merge Changeset: cf647374e044 Author: trims Date: 2010-07-09 00:35 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/cf647374e044 Merge Changeset: 6c3a919105b6 Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/6c3a919105b6 Added tag jdk7-b100 for changeset ad1977f08c4d ! .hgtags Changeset: a2b581345549 Author: trims Date: 2010-07-15 19:51 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/a2b581345549 Merge ! .hgtags Changeset: e55900b5c1b8 Author: trims Date: 2010-07-15 19:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/e55900b5c1b8 Merge - src/os/linux/vm/vtune_linux.cpp - src/os/solaris/vm/vtune_solaris.cpp - src/os/windows/vm/vtune_windows.cpp - src/share/vm/runtime/vtune.hpp Changeset: 75b254ea860e Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/75b254ea860e Added tag jdk7-b101 for changeset 6c3a919105b6 ! .hgtags Changeset: c5cadf1a0771 Author: trims Date: 2010-07-20 18:13 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/c5cadf1a0771 Merge ! .hgtags Changeset: e7ec8cd4dd8a Author: tonyp Date: 2010-06-28 14:13 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/e7ec8cd4dd8a 6962569: assembler_sparc.cpp:1969: assert(false) failed: error Summary: array_overlap_test() fails when the address range crosses the MSB boundary. Thanks to Tom and Vladimir for their help on this one. Reviewed-by: kvn, never, iveresov ! src/cpu/sparc/vm/stubGenerator_sparc.cpp Changeset: 4e5661ba9d98 Author: tonyp Date: 2010-06-28 14:13 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly Summary: G1 was not handling explicit GCs correctly in many ways. It does now. See the CR for the list of improvements contained in this changeset. Reviewed-by: iveresov, ysr, johnc ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.hpp ! src/share/vm/gc_implementation/includeDB_gc_g1 ! src/share/vm/gc_implementation/shared/vmGCOperations.hpp ! src/share/vm/gc_interface/gcCause.cpp ! src/share/vm/runtime/mutexLocker.cpp Changeset: 1a1ce2076047 Author: ysr Date: 2010-07-16 10:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/1a1ce2076047 Merge Changeset: ad7e433e2730 Author: ysr Date: 2010-07-20 16:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/ad7e433e2730 Merge - src/os/linux/vm/vtune_linux.cpp - src/os/solaris/vm/vtune_solaris.cpp - src/os/windows/vm/vtune_windows.cpp - src/share/vm/runtime/vtune.hpp Changeset: 131ed9a23d48 Author: ysr Date: 2010-07-21 09:57 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/131ed9a23d48 Merge Changeset: 083fde3b838e Author: jrose Date: 2010-07-15 18:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/083fde3b838e 6964498: JSR 292 invokedynamic sites need local bootstrap methods Summary: Add JVM_CONSTANT_InvokeDynamic records to constant pool to determine per-instruction BSMs. Reviewed-by: twisti ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPool.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/ClassConstants.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/ConstantTag.java ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/interpreter/bytecodeTracer.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/interpreter/linkResolver.hpp ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/oops/constantPoolOop.hpp ! src/share/vm/oops/cpCacheOop.cpp ! src/share/vm/oops/cpCacheOop.hpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/utilities/constantTag.cpp ! src/share/vm/utilities/constantTag.hpp Changeset: 01b172b8cd7c Author: never Date: 2010-07-16 08:29 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/01b172b8cd7c Merge Changeset: e0ba4e04c839 Author: jrose Date: 2010-07-16 18:14 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/e0ba4e04c839 6969574: invokedynamic call sites deoptimize instead of executing Reviewed-by: kvn ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/oops/cpCacheOop.cpp ! src/share/vm/oops/cpCacheOop.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/prims/methodHandleWalk.cpp Changeset: 7139e81efd2d Author: never Date: 2010-07-22 15:29 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/7139e81efd2d 6970566: runThese fails with SIGSEGV Reviewed-by: kvn ! src/share/vm/code/codeBlob.cpp ! src/share/vm/code/codeBlob.hpp Changeset: 5063ce716349 Author: never Date: 2010-07-23 10:21 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/5063ce716349 Merge Changeset: a93a9eda13f7 Author: jcoomes Date: 2010-07-16 21:33 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/a93a9eda13f7 6962947: shared TaskQueue statistics Reviewed-by: tonyp, ysr ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/gc_implementation/parNew/parOopClosures.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/utilities/globalDefinitions.hpp ! src/share/vm/utilities/taskqueue.cpp ! src/share/vm/utilities/taskqueue.hpp Changeset: 5cbac8938c4c Author: johnc Date: 2010-07-19 11:06 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/5cbac8938c4c 6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307 Summary: During concurrent refinment, filter cards in young regions after it has been determined that the region has been allocated from and the young type of the region has been set. Reviewed-by: iveresov, tonyp, jcoomes ! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp Changeset: 4f1fffe08c63 Author: ysr Date: 2010-07-21 12:45 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/4f1fffe08c63 Merge Changeset: 1890dc9151da Author: ysr Date: 2010-07-23 14:31 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/1890dc9151da Merge Changeset: 7f0fdccac34f Author: apangin Date: 2010-07-25 07:31 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/7f0fdccac34f Merge ! src/share/vm/classfile/verifier.cpp From weijun.wang at sun.com Mon Jul 26 02:22:52 2010 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Mon, 26 Jul 2010 09:22:52 +0000 Subject: hg: jdk7/tl/jdk: 6972005: ConfPlusProp.java test failure when DNS has info for realm Message-ID: <20100726092335.790C247C8A@hg.openjdk.java.net> Changeset: 402ff3e81922 Author: weijun Date: 2010-07-26 17:21 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/402ff3e81922 6972005: ConfPlusProp.java test failure when DNS has info for realm Reviewed-by: xuelei ! test/sun/security/krb5/ConfPlusProp.java ! test/sun/security/krb5/confplusprop.conf ! test/sun/security/krb5/confplusprop2.conf From martinrb at google.com Mon Jul 26 08:21:14 2010 From: martinrb at google.com (martinrb at google.com) Date: Mon, 26 Jul 2010 15:21:14 +0000 Subject: hg: jdk7/tl/jdk: 6717780: (coll spec) LinkedList api documentation provides the wrong method name Message-ID: <20100726152154.F3E9747C97@hg.openjdk.java.net> Changeset: db21b420d038 Author: martin Date: 2010-07-26 08:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db21b420d038 6717780: (coll spec) LinkedList api documentation provides the wrong method name Summary: Cleanup by simply making Deque equal status with List Reviewed-by: darcy ! src/share/classes/java/util/LinkedList.java From jonathan.gibbons at oracle.com Mon Jul 26 14:20:19 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 26 Jul 2010 21:20:19 +0000 Subject: hg: jdk7/tl/langtools: 6971882: Remove -XDstdout from javac test Message-ID: <20100726212021.A24C447CA5@hg.openjdk.java.net> Changeset: 4172cfff05f0 Author: jjg Date: 2010-07-26 14:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4172cfff05f0 6971882: Remove -XDstdout from javac test Reviewed-by: darcy ! test/tools/javac/4980495/static/Test.java ! test/tools/javac/4980495/std/Test.java ! test/tools/javac/6304921/T6304921.java ! test/tools/javac/6330920/T6330920.java ! test/tools/javac/6491592/T6491592.java ! test/tools/javac/6717241/T6717241a.java ! test/tools/javac/6717241/T6717241b.java ! test/tools/javac/ClassFileModifiers/ClassModifiers.java ! test/tools/javac/ClassFileModifiers/MemberModifiers.java ! test/tools/javac/CyclicInheritance.java ! test/tools/javac/Digits.java ! test/tools/javac/ExtendArray.java ! test/tools/javac/ExtendsAccess/ExtendsAccess.java ! test/tools/javac/FloatingPointChanges/BadConstructorModifiers.java ! test/tools/javac/IllegalAnnotation.java ! test/tools/javac/InnerNamedConstant_2.java ! test/tools/javac/InterfaceMemberClassModifiers.java ! test/tools/javac/LocalClasses_2.java ! test/tools/javac/NameCollision.java ! test/tools/javac/NestedInnerClassNames.java ! test/tools/javac/NonStaticFieldExpr1.java ! test/tools/javac/NonStaticFieldExpr2.java ! test/tools/javac/NonStaticFieldExpr3.java ! test/tools/javac/OverridePosition.java ! test/tools/javac/QualifiedAccess/QualifiedAccess_1.java ! test/tools/javac/QualifiedAccess/QualifiedAccess_2.java ! test/tools/javac/QualifiedAccess/QualifiedAccess_3.java ! test/tools/javac/StringsInSwitch/BadlyTypedLabel1.java ! test/tools/javac/StringsInSwitch/BadlyTypedLabel2.java ! test/tools/javac/StringsInSwitch/NonConstantLabel.java ! test/tools/javac/StringsInSwitch/RepeatedStringCaseLabels1.java ! test/tools/javac/StringsInSwitch/RepeatedStringCaseLabels2.java ! test/tools/javac/SynchronizedClass.java ! test/tools/javac/T4093617/T4093617.java ! test/tools/javac/T4906100.java ! test/tools/javac/T4994049/T4994049.java ! test/tools/javac/T5003235/T5003235a.java ! test/tools/javac/T5003235/T5003235b.java ! test/tools/javac/T5003235/T5003235c.java ! test/tools/javac/T5024091/T5024091.java ! test/tools/javac/T5048776.java ! test/tools/javac/T6214885.java ! test/tools/javac/T6224167.java ! test/tools/javac/T6227617.java ! test/tools/javac/T6230128.java ! test/tools/javac/T6231847.java ! test/tools/javac/T6241723.java ! test/tools/javac/T6245591.java ! test/tools/javac/T6247324.java ! test/tools/javac/T6394563.java ! test/tools/javac/annotations/6214965/T6214965.java ! test/tools/javac/annotations/6365854/T6365854.java ! test/tools/javac/danglingDep/DepX.java ! test/tools/javac/danglingDep/NoDepX.java ! test/tools/javac/danglingDep/Test1.java ! test/tools/javac/depDocComment/DeprecatedDocComment.java ! test/tools/javac/depDocComment/SuppressDeprecation.java ! test/tools/javac/depOverrides/annotation/Test1.java ! test/tools/javac/depOverrides/annotation/Test2.java ! test/tools/javac/depOverrides/annotation/Test3.java ! test/tools/javac/depOverrides/doccomment/Test1.java ! test/tools/javac/depOverrides/doccomment/Test2.java ! test/tools/javac/depOverrides/doccomment/Test3.java ! test/tools/javac/enum/6384542/T6384542.java ! test/tools/javac/enum/6384542/T6384542a.java ! test/tools/javac/enum/forwardRef/T6425594.java ! test/tools/javac/generics/5009937/T5009937.java ! test/tools/javac/generics/6207386/T6207386.java ! test/tools/javac/generics/6359951/T6359951.java ! test/tools/javac/generics/6677785/T6677785.java ! test/tools/javac/generics/6723444/T6723444.java ! test/tools/javac/generics/inference/6611449/T6611449.java ! test/tools/javac/generics/inference/6718364/T6718364.java ! test/tools/javac/generics/wildcards/6437894/T6437894.java ! test/tools/javac/lint/NoWarn.java ! test/tools/javac/mandatoryWarnings/deprecated/Test.java ! test/tools/javac/mandatoryWarnings/unchecked/Test.java ! test/tools/javac/miranda/T4666866.java ! test/tools/javac/missingSuperRecovery/MissingSuperRecovery.java ! test/tools/javac/policy/test1/Test1a.java ! test/tools/javac/policy/test2/Test.java ! test/tools/javac/positions/T6253161.java ! test/tools/javac/positions/T6253161a.java ! test/tools/javac/positions/T6264029.java ! test/tools/javac/processing/messager/6362067/T6362067.java ! test/tools/javac/processing/warnings/TestSourceVersionWarnings.java ! test/tools/javac/protectedAccess/ProtectedMemberAccess2.java ! test/tools/javac/protectedAccess/ProtectedMemberAccess3.java ! test/tools/javac/protectedAccess/ProtectedMemberAccess4.java ! test/tools/javac/rawDiags/Error.java ! test/tools/javac/rawDiags/Note.java ! test/tools/javac/rawDiags/Warning.java ! test/tools/javac/unicode/UnicodeNewline.java ! test/tools/javac/warnings/Deprecation.java ! test/tools/javac/warnings/DivZero.java ! test/tools/javac/warnings/FallThrough.java ! test/tools/javac/warnings/Unchecked.java From jonathan.gibbons at oracle.com Mon Jul 26 14:26:05 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 26 Jul 2010 21:26:05 +0000 Subject: hg: jdk7/tl/langtools: 6957438: improve code for generating warning messages containing option names Message-ID: <20100726212607.01F5247CA6@hg.openjdk.java.net> Changeset: d1bd93028447 Author: jjg Date: 2010-07-26 14:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d1bd93028447 6957438: improve code for generating warning messages containing option names Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/file/Paths.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/AbstractLog.java ! src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/MandatoryWarningHandler.java ! test/tools/javac/diags/examples/CountWarn.java ! test/tools/javac/diags/examples/CountWarnPlural.java ! test/tools/javac/diags/examples/Error.java From daniel.daugherty at oracle.com Mon Jul 26 14:44:18 2010 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Mon, 26 Jul 2010 21:44:18 +0000 Subject: hg: jdk7/tl/jdk: 6971847: 4/4 jmap '-histo:live' option is necessary for proper leak detection Message-ID: <20100726214427.EA96F47CA7@hg.openjdk.java.net> Changeset: 1bfa1c864553 Author: dcubed Date: 2010-07-26 09:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1bfa1c864553 6971847: 4/4 jmap '-histo:live' option is necessary for proper leak detection Summary: Add work around for 6971851. Abort if 'histo:live' option isn't supported. Reviewed-by: alanb, darcy ! test/java/util/logging/AnonLoggerWeakRefLeak.sh ! test/java/util/logging/LoggerWeakRefLeak.sh From xuelei.fan at sun.com Tue Jul 27 01:16:19 2010 From: xuelei.fan at sun.com (xuelei.fan at sun.com) Date: Tue, 27 Jul 2010 08:16:19 +0000 Subject: hg: jdk7/tl/jdk: 6870947: 15 sec delay detecting "socket closed" condition when a TCP connection is reset by an LDAP server Message-ID: <20100727081628.A284B47CC0@hg.openjdk.java.net> Changeset: 83be262e654c Author: xuelei Date: 2010-07-27 16:07 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/83be262e654c 6870947: 15 sec delay detecting "socket closed" condition when a TCP connection is reset by an LDAP server Reviewed-by: weijun ! src/share/classes/com/sun/jndi/ldap/Connection.java From vincent.x.ryan at oracle.com Tue Jul 27 04:51:52 2010 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Tue, 27 Jul 2010 11:51:52 +0000 Subject: hg: jdk7/tl/jdk: 6972409: Cease emitting LDAP filter debug messages Message-ID: <20100727115223.4B9DE47CC8@hg.openjdk.java.net> Changeset: 5ff8b884a92c Author: vinnie Date: 2010-07-27 11:40 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5ff8b884a92c 6972409: Cease emitting LDAP filter debug messages Reviewed-by: xuelei ! src/share/classes/com/sun/jndi/ldap/Filter.java From kevin.walls at oracle.com Tue Jul 27 06:31:44 2010 From: kevin.walls at oracle.com (Kevin Walls) Date: Tue, 27 Jul 2010 14:31:44 +0100 Subject: Review request: 6581734 CMS Old Gen's collection usage is zero after GC which is incorrect In-Reply-To: <4C49E86B.4000704@oracle.com> References: <4C4594A0.2030509@oracle.com> <4C49E86B.4000704@oracle.com> Message-ID: <4C4EDFC0.6000902@oracle.com> Hi Mandy, Yes, thanks for the discussions we've had so far. 8-) Here's an updated JDK7 version: http://cr.openjdk.java.net/~kevinw/6581734/webrev.01/ Thanks Kevin Mandy Chung wrote: > Kevin, > > As I know, you're revising the fix for the 6 update release. I'll > review your revised webrev when it's ready. > > Thanks > Mandy > > Kevin Walls wrote: >> Hi - >> >> This is a review request for the issue where cms doesn't update the >> statistics used by the MemoryPoolMXBean system: only concurrent mode >> failures update the stats. We just aren't prepared for concurrent >> collections, so it takes a fair amount of customisation to add that >> flexibility... >> >> http://cr.openjdk.java.net/~kevinw/6581734/webrev/ >> >> Thanks >> Kevin >> >> >> >> >> > From jonathan.gibbons at oracle.com Tue Jul 27 11:33:18 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 27 Jul 2010 18:33:18 +0000 Subject: hg: jdk7/tl/langtools: 6972327: JCTree.pos incorrect for annotations without modifiers and package Message-ID: <20100727183322.5C4D247CD7@hg.openjdk.java.net> Changeset: b29160d1b3e0 Author: jjg Date: 2010-07-27 11:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b29160d1b3e0 6972327: JCTree.pos incorrect for annotations without modifiers and package Reviewed-by: mcimadamore Contributed-by: jan.lahoda at sun.com ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java + test/tools/javac/T6972327.java From jonathan.gibbons at oracle.com Tue Jul 27 11:52:20 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 27 Jul 2010 18:52:20 +0000 Subject: hg: jdk7/tl/langtools: 6403456: -Werror should work with annotation processing Message-ID: <20100727185222.557A547CD8@hg.openjdk.java.net> Changeset: ed354a00f76b Author: jjg Date: 2010-07-27 11:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ed354a00f76b 6403456: -Werror should work with annotation processing Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/processing/JavacMessager.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + test/tools/javac/processing/werror/WError1.java + test/tools/javac/processing/werror/WError1.out + test/tools/javac/processing/werror/WErrorGen.java + test/tools/javac/processing/werror/WErrorGen.out + test/tools/javac/processing/werror/WErrorLast.java + test/tools/javac/processing/werror/WErrorLast.out From aph at redhat.com Wed Jul 28 09:40:02 2010 From: aph at redhat.com (aph at redhat.com) Date: Wed, 28 Jul 2010 16:40:02 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 6888526: Linux getCurrentThreadCpuTime is drastically slower than Windows Message-ID: <20100728164004.5FD2947D09@hg.openjdk.java.net> Changeset: 3d90023429ec Author: aph Date: 2010-07-28 17:38 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/3d90023429ec 6888526: Linux getCurrentThreadCpuTime is drastically slower than Windows Reviewed-by: dcubed, dholmes ! src/os/linux/vm/globals_linux.hpp ! src/share/vm/runtime/arguments.cpp From coleen.phillimore at oracle.com Wed Jul 28 17:57:00 2010 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Thu, 29 Jul 2010 00:57:00 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 6958465: Sparc aten build24.0: openjdk-7.ea-b96 failed Error: Formal argument ... requires an lvalue Message-ID: <20100729005703.DC90F47D1F@hg.openjdk.java.net> Changeset: a64438a2b7e8 Author: coleenp Date: 2010-07-28 17:57 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/a64438a2b7e8 6958465: Sparc aten build24.0: openjdk-7.ea-b96 failed Error: Formal argument ... requires an lvalue Summary: Fix compilation errors. Made non-const references const so can be assigned with lvalue. Reviewed-by: phh, xlu ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp From alan.bateman at oracle.com Thu Jul 29 06:33:59 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 29 Jul 2010 13:33:59 +0000 Subject: hg: jdk7/tl/jdk: 6934977: (bf) MappedByteBuffer.load can SIGBUS if file is truncated; ... Message-ID: <20100729133443.2AFCA47D4C@hg.openjdk.java.net> Changeset: 24741c4bf300 Author: alanb Date: 2010-07-29 13:08 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/24741c4bf300 6934977: (bf) MappedByteBuffer.load can SIGBUS if file is truncated 6799037: (fs) MappedByteBuffer.load crash with unaligned file-mapping (sol) Reviewed-by: chegar, forax ! src/share/classes/java/nio/Bits.java ! src/share/classes/java/nio/MappedByteBuffer.java ! src/solaris/native/java/nio/MappedByteBuffer.c ! src/windows/native/java/nio/MappedByteBuffer.c ! test/java/nio/MappedByteBuffer/Basic.java + test/java/nio/MappedByteBuffer/Truncate.java From maurizio.cimadamore at oracle.com Thu Jul 29 08:10:31 2010 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 29 Jul 2010 15:10:31 +0000 Subject: hg: jdk7/tl/langtools: 3 new changesets Message-ID: <20100729151037.22B5847D56@hg.openjdk.java.net> Changeset: 36c4ec4525b4 Author: mcimadamore Date: 2010-07-29 15:56 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/36c4ec4525b4 6938454: Unable to determine generic type in program that compiles under Java 6 Summary: a redundant dubtyping check causes spurious inference failure Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/generics/inference/6938454/T6938454a.java + test/tools/javac/generics/inference/6938454/T6938454b.java Changeset: e79e8efe1b3e Author: mcimadamore Date: 2010-07-29 15:57 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e79e8efe1b3e 6972747: CheckExamples fail when assertions are enabled Summary: The test calls the wrong version of JavacMessage constructor Reviewed-by: jjg ! test/tools/javac/diags/Example.java Changeset: 62f3f07002ea Author: mcimadamore Date: 2010-07-29 15:57 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/62f3f07002ea 6970833: Try-with-resource implementation throws an NPE during Flow analysis Summary: Updated logic not to rely upon Symbol.implementation (which check in superinterfaces) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java + test/tools/javac/TryWithResources/ResourceInterface.java + test/tools/javac/TryWithResources/ResourceInterface.out From chris.hegarty at oracle.com Thu Jul 29 09:05:58 2010 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 29 Jul 2010 16:05:58 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20100729160641.ACD2247D59@hg.openjdk.java.net> Changeset: a8a79f5b669e Author: chegar Date: 2010-07-29 10:02 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a8a79f5b669e 6972374: NetworkInterface.getNetworkInterfaces throws "java.net.SocketException" on Solaris zone Reviewed-by: alanb, dsamersoff ! src/solaris/native/java/net/NetworkInterface.c Changeset: d82ed433304e Author: chegar Date: 2010-07-29 17:04 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d82ed433304e Merge From John.Coomes at oracle.com Thu Jul 29 16:38:49 2010 From: John.Coomes at oracle.com (John Coomes) Date: Thu, 29 Jul 2010 16:38:49 -0700 Subject: hg: jdk7/hotspot-rt/hotspot: 6888526: Linux getCurrentThreadCpuTime is drastically slower than Windows In-Reply-To: <20100728164004.5FD2947D09@hg.openjdk.java.net> References: <20100728164004.5FD2947D09@hg.openjdk.java.net> Message-ID: <19538.4361.332053.908362@oracle.com> aph at redhat.com (aph at redhat.com) wrote: > Changeset: 3d90023429ec > Author: aph > Date: 2010-07-28 17:38 +0100 > URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/3d90023429ec > > 6888526: Linux getCurrentThreadCpuTime is drastically slower than Windows > Reviewed-by: dcubed, dholmes > > ! src/os/linux/vm/globals_linux.hpp > ! src/share/vm/runtime/arguments.cpp Hi Andrew, First, thanks for the fix. I also want to make sure you're aware of our requirements for pushing to hotspot, since this looks like something you pushed directly. All hotspot changes (even trivial ones) have to go through an automated build and test system that we call JPRT, which pushes your change only if all builds and test pass on all platforms. As of now that system is only available internally, so in the future when you have a hotspot change ready, ask on the appropriate hotspot-*-dev list and someone will submit the changeset for you. It's worth noting that all hotspot pushes from oracle engineers go through JPRT. I realize it's a slight inconvenience, but we had much too frequent build and test breakage before we required everyone to use JPRT. -John From daniel.daugherty at oracle.com Thu Jul 29 17:28:46 2010 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 29 Jul 2010 18:28:46 -0600 Subject: hg: jdk7/hotspot-rt/hotspot: 6888526: Linux getCurrentThreadCpuTime is drastically slower than Windows In-Reply-To: <19538.4361.332053.908362@oracle.com> References: <20100728164004.5FD2947D09@hg.openjdk.java.net> <19538.4361.332053.908362@oracle.com> Message-ID: <4C521CBE.4050601@oracle.com> On 7/29/2010 5:38 PM, John Coomes wrote: > aph at redhat.com (aph at redhat.com) wrote: > >> Changeset: 3d90023429ec >> Author: aph >> Date: 2010-07-28 17:38 +0100 >> URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/3d90023429ec >> >> 6888526: Linux getCurrentThreadCpuTime is drastically slower than Windows >> Reviewed-by: dcubed, dholmes >> >> ! src/os/linux/vm/globals_linux.hpp >> ! src/share/vm/runtime/arguments.cpp >> > > Hi Andrew, > > First, thanks for the fix. > > I also want to make sure you're aware of our requirements for pushing > to hotspot, since this looks like something you pushed directly. All > hotspot changes (even trivial ones) have to go through an automated > build and test system that we call JPRT, which pushes your change only > if all builds and test pass on all platforms. As of now that system > is only available internally, so in the future when you have a hotspot > change ready, ask on the appropriate hotspot-*-dev list and someone > will submit the changeset for you. It's worth noting that all hotspot > pushes from oracle engineers go through JPRT. > > I realize it's a slight inconvenience, but we had much too frequent > build and test breakage before we required everyone to use JPRT. > > -John > That's my fault. I gave Andrew permission to push the change to RT_Baseline. I guess I've spent too much time in T&L lately where external pushes happen without going thru JPRT. In any case, Coleen pushed a subsequent job through JPRT after Andrew's and I've thoroughly checked the nightly test results. In the future, I'll shepherd changes through JPRT (as I did for the stuff that AMD contributed)... Dan From jonathan.gibbons at oracle.com Thu Jul 29 18:07:23 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 30 Jul 2010 01:07:23 +0000 Subject: hg: jdk7/tl/langtools: 6972556: warning for using a file name instead of a binary name for Filer.createSourceFile Message-ID: <20100730010726.CDE1847D82@hg.openjdk.java.net> Changeset: 4a7979c3ce15 Author: jjg Date: 2010-07-29 18:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4a7979c3ce15 6972556: warning for using a file name instead of a binary name for Filer.createSourceFile Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/processing/JavacFiler.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/ProcSuspiciousClassName/ProcSuspiciousClassName.java + test/tools/javac/diags/examples/ProcSuspiciousClassName/processors/AnnoProc.java From jonathan.gibbons at oracle.com Thu Jul 29 19:27:50 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 30 Jul 2010 02:27:50 +0000 Subject: hg: jdk7/tl/langtools: 6340549: javax.tools.JavaCompilerTool.getStandardFileManager().list() includes directories Message-ID: <20100730022752.CF61D47D86@hg.openjdk.java.net> Changeset: 8a5c98a695ae Author: jjg Date: 2010-07-29 19:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8a5c98a695ae 6340549: javax.tools.JavaCompilerTool.getStandardFileManager().list() includes directories Reviewed-by: darcy + test/tools/javac/T6340549.java From jonathan.gibbons at oracle.com Thu Jul 29 19:30:40 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 30 Jul 2010 02:30:40 +0000 Subject: hg: jdk7/tl/langtools: 6966604: JavacFiler not correctly notified of lastRound Message-ID: <20100730023042.5EB2E47D87@hg.openjdk.java.net> Changeset: 2cf925ad67ab Author: jjg Date: 2010-07-29 19:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2cf925ad67ab 6966604: JavacFiler not correctly notified of lastRound Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/processing/JavacFiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/ProcFileCreateLastRound/ProcFileCreateLastRound.java + test/tools/javac/diags/examples/ProcFileCreateLastRound/processors/AnnoProc.java + test/tools/javac/processing/filer/TestLastRound.java + test/tools/javac/processing/filer/TestLastRound.out ! test/tools/javac/processing/werror/WErrorGen.java From John.Coomes at oracle.com Thu Jul 29 22:11:39 2010 From: John.Coomes at oracle.com (John Coomes) Date: Thu, 29 Jul 2010 22:11:39 -0700 Subject: hg: jdk7/hotspot-rt/hotspot: 6888526: Linux getCurrentThreadCpuTime is drastically slower than Windows In-Reply-To: <4C521CBE.4050601@oracle.com> References: <20100728164004.5FD2947D09@hg.openjdk.java.net> <19538.4361.332053.908362@oracle.com> <4C521CBE.4050601@oracle.com> Message-ID: <19538.24331.131605.628012@oracle.com> Daniel D. Daugherty (daniel.daugherty at oracle.com) wrote: > > > On 7/29/2010 5:38 PM, John Coomes wrote: > > aph at redhat.com (aph at redhat.com) wrote: > > > >> Changeset: 3d90023429ec > >> Author: aph > >> Date: 2010-07-28 17:38 +0100 > >> URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/3d90023429ec > >> > >> 6888526: Linux getCurrentThreadCpuTime is drastically slower than Windows > >> Reviewed-by: dcubed, dholmes > >> > >> ! src/os/linux/vm/globals_linux.hpp > >> ! src/share/vm/runtime/arguments.cpp > > > > Hi Andrew, > > > > First, thanks for the fix. > > > > I also want to make sure you're aware of our requirements for pushing > > to hotspot, since this looks like something you pushed directly. All > > hotspot changes (even trivial ones) have to go through an automated > > build and test system that we call JPRT, which pushes your change only > > if all builds and test pass on all platforms. As of now that system > > is only available internally, so in the future when you have a hotspot > > change ready, ask on the appropriate hotspot-*-dev list and someone > > will submit the changeset for you. It's worth noting that all hotspot > > pushes from oracle engineers go through JPRT. > > > > I realize it's a slight inconvenience, but we had much too frequent > > build and test breakage before we required everyone to use JPRT. > > That's my fault. I gave Andrew permission to push the change to > RT_Baseline. I guess I've spent too much time in T&L lately where > external pushes happen without going thru JPRT. In any case, > Coleen pushed a subsequent job through JPRT after Andrew's and > I've thoroughly checked the nightly test results. > > In the future, I'll shepherd changes through JPRT (as I did for > the stuff that AMD contributed)... Sounds good. And thanks for checking the nightlies; good to know that all's well. -John From lana.steuck at oracle.com Thu Jul 29 23:15:51 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 30 Jul 2010 06:15:51 +0000 Subject: hg: jdk7/tl: 9 new changesets Message-ID: <20100730061551.DB28D47D96@hg.openjdk.java.net> Changeset: 3b147bf5a0e9 Author: lana Date: 2010-06-21 22:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/3b147bf5a0e9 Merge Changeset: b218a53ec7d3 Author: lana Date: 2010-06-29 22:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/b218a53ec7d3 Merge Changeset: 4193eaf5f1b8 Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/4193eaf5f1b8 Added tag jdk7-b100 for changeset b218a53ec7d3 ! .hgtags Changeset: 055626b50d2d Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/055626b50d2d Added tag jdk7-b101 for changeset 4193eaf5f1b8 ! .hgtags Changeset: 9cda7c220c08 Author: lana Date: 2010-07-12 19:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/9cda7c220c08 Merge Changeset: a136a51f5113 Author: lana Date: 2010-07-20 22:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/a136a51f5113 Merge Changeset: 86a3df41c0c7 Author: mikejwre Date: 2010-07-23 16:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/86a3df41c0c7 Added tag jdk7-b102 for changeset a136a51f5113 ! .hgtags Changeset: f1ba69da5003 Author: ohair Date: 2010-07-26 14:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/f1ba69da5003 6972274: Fix the use of egrep -ci in the top level makefile sanity checks Reviewed-by: prr ! make/sanity-rules.gmk Changeset: be2aedc4e3b1 Author: mikejwre Date: 2010-07-28 21:03 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/be2aedc4e3b1 Merge From lana.steuck at oracle.com Thu Jul 29 23:15:57 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 30 Jul 2010 06:15:57 +0000 Subject: hg: jdk7/tl/corba: 7 new changesets Message-ID: <20100730061601.A0C9647D97@hg.openjdk.java.net> Changeset: 8eeca6e452de Author: lana Date: 2010-06-21 22:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/8eeca6e452de Merge Changeset: a56d734a1e97 Author: lana Date: 2010-06-29 22:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/a56d734a1e97 Merge Changeset: 86a239832646 Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/86a239832646 Added tag jdk7-b100 for changeset a56d734a1e97 ! .hgtags Changeset: d130544adab3 Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/d130544adab3 Added tag jdk7-b101 for changeset 86a239832646 ! .hgtags Changeset: 98da66f47273 Author: lana Date: 2010-07-12 19:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/98da66f47273 Merge Changeset: 78561a957790 Author: lana Date: 2010-07-20 22:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/78561a957790 Merge Changeset: 11e7678c3eb1 Author: mikejwre Date: 2010-07-23 16:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/11e7678c3eb1 Added tag jdk7-b102 for changeset 78561a957790 ! .hgtags From lana.steuck at oracle.com Thu Jul 29 23:20:21 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 30 Jul 2010 06:20:21 +0000 Subject: hg: jdk7/tl/hotspot: 56 new changesets Message-ID: <20100730062156.44E4E47D99@hg.openjdk.java.net> Changeset: e13a5c0ed5e2 Author: prr Date: 2010-06-29 16:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/e13a5c0ed5e2 6964882: 32 bit JDK does not build on 64 bit Windows platforms Reviewed-by: ohair, valeriep ! make/windows/makefiles/defs.make Changeset: ad1977f08c4d Author: mikejwre Date: 2010-06-30 18:57 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ad1977f08c4d Merge Changeset: 6c3a919105b6 Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/6c3a919105b6 Added tag jdk7-b100 for changeset ad1977f08c4d ! .hgtags Changeset: 75b254ea860e Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/75b254ea860e Added tag jdk7-b101 for changeset 6c3a919105b6 ! .hgtags Changeset: 136b78722a08 Author: jrose Date: 2010-06-09 18:50 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/136b78722a08 6939203: JSR 292 needs method handle constants Summary: Add new CP types CONSTANT_MethodHandle, CONSTANT_MethodType; extend 'ldc' bytecode. Reviewed-by: twisti, never ! agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeDisassembler.java ! agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeInvoke.java ! agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeLoadConstant.java ! agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeWithCPIndex.java ! agent/src/share/classes/sun/jvm/hotspot/interpreter/Bytecodes.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPool.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolCache.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolCacheEntry.java ! agent/src/share/classes/sun/jvm/hotspot/oops/GenerateOopMap.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/ClassConstants.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ByteCodeRewriter.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/ConstantTag.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/ci/ciCPCache.cpp ! src/share/vm/ci/ciCPCache.hpp ! src/share/vm/ci/ciClassList.hpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/ci/ciObjectFactory.hpp ! src/share/vm/ci/ciStreams.cpp ! src/share/vm/ci/ciStreams.hpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/classfile/verifier.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/includeDB_core ! src/share/vm/interpreter/bytecode.cpp ! src/share/vm/interpreter/bytecode.hpp ! src/share/vm/interpreter/bytecodeTracer.cpp ! src/share/vm/interpreter/bytecodes.cpp ! src/share/vm/interpreter/bytecodes.hpp ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/interpreter/templateTable.cpp ! src/share/vm/interpreter/templateTable.hpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/oops/constantPoolOop.hpp ! src/share/vm/oops/cpCacheOop.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/methodComparator.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/utilities/constantTag.cpp ! src/share/vm/utilities/constantTag.hpp Changeset: d93949c5bdcc Author: kvn Date: 2010-06-10 13:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d93949c5bdcc 6730276: JDI_REGRESSION tests fail with "Error: count must be non-zero" error on x86 Summary: Modify assembler code to check for 0 count for all copy routines. Reviewed-by: never, ysr, jcoomes ! src/os_cpu/linux_x86/vm/copy_linux_x86.inline.hpp ! src/os_cpu/linux_x86/vm/linux_x86_32.s ! src/os_cpu/solaris_x86/vm/solaris_x86_32.s ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vframeArray.cpp ! src/share/vm/utilities/copy.cpp ! src/share/vm/utilities/copy.hpp Changeset: b918d354830a Author: jrose Date: 2010-06-12 22:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b918d354830a 6960865: ldc of unloaded class throws an assert in ciTypeFlow Summary: Support java_mirror for unloaded klasses, arrays as well as instances. Simplify ciTypeFlow by removing unused path. Reviewed-by: kvn ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciKlass.cpp ! src/share/vm/ci/ciTypeFlow.cpp Changeset: d179e225c164 Author: twisti Date: 2010-06-14 00:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d179e225c164 6960550: Missing semicolon in Zero Summary: There is a missing semicolon in cppInterpreter_zero.cpp. Reviewed-by: twisti Contributed-by: Gary Benson ! src/cpu/zero/vm/cppInterpreter_zero.cpp Changeset: 0b4ee1df1b44 Author: never Date: 2010-06-15 12:03 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/0b4ee1df1b44 6952176: Remove debug flag from adlc makefile for 6Update trains Reviewed-by: kvn, twisti ! make/linux/makefiles/adlc.make Changeset: 78fc92dfd4ca Author: never Date: 2010-06-15 12:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/78fc92dfd4ca Merge Changeset: 2389669474a6 Author: jrose Date: 2010-06-15 15:57 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/2389669474a6 Merge ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/runtime/thread.cpp Changeset: 4311f23817fd Author: kvn Date: 2010-06-15 18:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/4311f23817fd 6959430: Make sure raw loads have control edge Summary: check that raw loads have control edge Reviewed-by: never, twisti ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/parse1.cpp Changeset: 79107c3a6bd5 Author: tonyp Date: 2010-05-07 13:14 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/79107c3a6bd5 6949307: G1: raise a vm error, do not core dump, if target pause time and target interval are inconsistent Summary: First, change the guarantee to raising a vm error. Second, set the interval dynamically, and based on the pause time target, if it is not set explicitly. Reviewed-by: ysr, johnc ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 215576b54709 Author: tonyp Date: 2010-04-22 15:20 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/215576b54709 6946048: G1: improvements to +PrintGCDetails output Summary: Small improvements to G1's PrintGCDetails output. It also includes minor formatting details. Reviewed-by: ysr, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp Changeset: fdde661c8e06 Author: jmasa Date: 2010-06-23 08:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/fdde661c8e06 6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008 Summary: Shrinking of a generation and the corresponding card table was causing part of the card table to be uncommitted. Reviewed-by: jcoomes ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.cpp ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.hpp ! src/share/vm/memory/cardTableModRefBS.cpp Changeset: 0d781caf0cbb Author: jmasa Date: 2010-06-23 15:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/0d781caf0cbb Merge Changeset: b8537b881421 Author: jmasa Date: 2010-06-24 15:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b8537b881421 Merge Changeset: ff38d05ea86f Author: never Date: 2010-06-18 16:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ff38d05ea86f 6956958: assert(is_clean() || is_call_to_compiled() || is_call_to_interpreted() || is_optimized() || is_megam Reviewed-by: kvn ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp Changeset: 38e8278318ca Author: never Date: 2010-06-21 14:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/38e8278318ca 6656830: assert((*p)->is_oop(),"expected an oop while scanning weak refs") Reviewed-by: dcubed, kvn, twisti ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/prims/jvmtiCodeBlobEvents.cpp ! src/share/vm/runtime/jniHandles.cpp Changeset: 9887b5e57f9e Author: iveresov Date: 2010-06-22 12:10 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/9887b5e57f9e 6962980: C1: stub area should take into account method handle deopt stub Reviewed-by: twisti, never ! src/share/vm/c1/c1_Compilation.cpp Changeset: 5f249b390094 Author: kvn Date: 2010-06-23 09:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5f249b390094 6947341: JVM Crash running Oracle ATG CRMDemo Summary: Missing protected page below heap with compressed oops on Linux with large pages use. Reviewed-by: never, phh, jcoomes ! src/share/vm/runtime/virtualspace.cpp Changeset: 5a297ea605c7 Author: jrose Date: 2010-06-26 00:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5a297ea605c7 Merge Changeset: d678e3277048 Author: kvn Date: 2010-06-28 10:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d678e3277048 6964479: widen normalization of small int and long values should be symmetric Summary: normalize widen value in xmeet() and xdual() methods for types Int and Long so the type meet will be symmetric. Reviewed-by: jrose ! src/share/vm/opto/type.cpp Changeset: 6027dddc26c6 Author: kvn Date: 2010-06-28 14:54 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/6027dddc26c6 6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist() Summary: Use replace_node() method instead of subsume_node(). Reviewed-by: jrose, never ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/opto/split_if.cpp ! src/share/vm/opto/superword.cpp Changeset: 76efbe666d6c Author: kvn Date: 2010-06-29 10:34 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/76efbe666d6c 6964774: Adjust optimization flags setting Summary: Adjust performance flags settings. Reviewed-by: never, phh ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/share/vm/runtime/arguments.cpp Changeset: fcbb92a1ab3b Author: jrose Date: 2010-06-29 16:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/fcbb92a1ab3b Merge ! src/share/vm/runtime/arguments.cpp Changeset: 726b40449bd2 Author: zgu Date: 2010-06-22 09:46 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/726b40449bd2 6939019: Source code adjustments for parfait compilation of hotspot Summary: Minor source code adjustments for parfait compilation, since it uses different compiler vs. JDK Reviewed-by: never, kamg ! src/os/solaris/vm/osThread_solaris.hpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp Changeset: 3e351982aac7 Author: zgu Date: 2010-06-22 10:03 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3e351982aac7 Merge Changeset: 1a11430e0326 Author: jcoomes Date: 2010-06-24 15:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1a11430e0326 6888573: class data sharing does not always disable large pages Reviewed-by: phh ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/runtime/arguments.cpp Changeset: c5f1ea9e15e8 Author: coleenp Date: 2010-06-28 12:03 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c5f1ea9e15e8 Merge ! src/share/vm/runtime/arguments.cpp Changeset: a00567c82f02 Author: coleenp Date: 2010-06-30 11:52 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a00567c82f02 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 871d2aa321f7 Author: trims Date: 2010-07-02 01:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/871d2aa321f7 Merge Changeset: 7cc68a696c62 Author: trims Date: 2010-07-02 01:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7cc68a696c62 6966252: Bump the HS19 build number to 04 Summary: Update the HS19 build number to 04 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 56cc7e01da2f Author: trims Date: 2010-07-09 00:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/56cc7e01da2f Added tag hs19-b03 for changeset ad1977f08c4d ! .hgtags Changeset: 1dbaff4aa23a Author: trims Date: 2010-07-09 00:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1dbaff4aa23a Merge Changeset: 65b0c03b165d Author: never Date: 2010-07-02 15:01 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/65b0c03b165d 6965671: fatal error: acquiring lock JNIGlobalHandle_lock/16 out of order with lock CodeCache_lock/1 Reviewed-by: kvn, dcubed ! src/share/vm/prims/jvmtiCodeBlobEvents.cpp Changeset: 60a14ad85270 Author: kvn Date: 2010-07-02 17:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/60a14ad85270 6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP Summary: Execute IGVN optimization before and after Escape Analysis Reviewed-by: never ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp Changeset: a693e51ac197 Author: never Date: 2010-07-07 12:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a693e51ac197 Merge Changeset: cf647374e044 Author: trims Date: 2010-07-09 00:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/cf647374e044 Merge Changeset: a2b581345549 Author: trims Date: 2010-07-15 19:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a2b581345549 Merge ! .hgtags Changeset: b2a00dd3117c Author: jcoomes Date: 2010-07-01 21:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b2a00dd3117c 6957084: simplify TaskQueue overflow handling Reviewed-by: ysr, jmasa ! src/share/vm/gc_implementation/includeDB_gc_parallelScavenge ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/utilities/taskqueue.cpp ! src/share/vm/utilities/taskqueue.hpp Changeset: 9ee05c8ab82f Author: ysr Date: 2010-07-12 12:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/9ee05c8ab82f Merge Changeset: bfc89697cccb Author: acorn Date: 2010-07-02 17:23 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/bfc89697cccb 6964164: MonitorInUseLists leak of contended objects Summary: fix MonitorInUseLists memory leak and MonitorBound now works Reviewed-by: chrisphi, dice ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/synchronizer.hpp ! src/share/vm/runtime/thread.hpp Changeset: 5087ecc10458 Author: acorn Date: 2010-07-07 14:12 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5087ecc10458 Merge Changeset: 0e7d2a08b605 Author: mchung Date: 2010-07-07 15:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/0e7d2a08b605 6967423: Hotspot support for modules image Summary: Add hotspot support for modules image Reviewed-by: acorn ! make/linux/makefiles/sa.make ! make/solaris/makefiles/sa.make ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/runtime/os.cpp Changeset: 1e7ec26380bd Author: apangin Date: 2010-07-14 17:52 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1e7ec26380bd Merge Changeset: 2a47bd84841f Author: never Date: 2010-07-08 14:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/2a47bd84841f 6965184: possible races in make_not_entrant_or_zombie Reviewed-by: kvn ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java - src/os/linux/vm/vtune_linux.cpp - src/os/solaris/vm/vtune_solaris.cpp - src/os/windows/vm/vtune_windows.cpp ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/code/codeBlob.cpp ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/code/vtableStubs.cpp ! src/share/vm/includeDB_core ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/init.cpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/stubCodeGenerator.cpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp ! src/share/vm/runtime/vmStructs.cpp - src/share/vm/runtime/vtune.hpp Changeset: 3941674cc7fa Author: never Date: 2010-07-12 10:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3941674cc7fa 6958668: repeated uncommon trapping for new of klass which is being initialized Reviewed-by: kvn, jrose ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciInstanceKlass.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parseHelper.cpp Changeset: 8d5934a77f10 Author: never Date: 2010-07-12 22:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/8d5934a77f10 6968385: malformed xml in sweeper logging Reviewed-by: kvn ! src/share/vm/runtime/sweeper.cpp Changeset: 079980c86f33 Author: kvn Date: 2010-07-14 14:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/079980c86f33 6968646: JVM crashes with SIGFPE during startup Summary: Check that cpuid returns valid values for processor topology (not zeros). Reviewed-by: never, twisti ! src/cpu/x86/vm/vm_version_x86.hpp Changeset: 8099e71601df Author: kvn Date: 2010-07-14 14:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/8099e71601df 6968368: SIGSEGV in the BCEscapeAnalyzer::copy_dependencies Summary: Use GrowableArray and VectorSet allocated in ciEnv arena. Reviewed-by: never, twisti ! src/share/vm/ci/bcEscapeAnalyzer.cpp ! src/share/vm/ci/bcEscapeAnalyzer.hpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/includeDB_compiler2 ! src/share/vm/includeDB_core Changeset: a528509c992b Author: never Date: 2010-07-15 08:54 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a528509c992b 6968336: VM crash guarantee(!nm->is_zombie()) failed: cannot lock a zombie method Reviewed-by: twisti ! src/share/vm/prims/jvmtiCodeBlobEvents.cpp Changeset: 61fdaf88f57f Author: never Date: 2010-07-15 13:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/61fdaf88f57f Merge - src/os/linux/vm/vtune_linux.cpp - src/os/solaris/vm/vtune_solaris.cpp - src/os/windows/vm/vtune_windows.cpp - src/share/vm/runtime/vtune.hpp Changeset: e55900b5c1b8 Author: trims Date: 2010-07-15 19:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/e55900b5c1b8 Merge - src/os/linux/vm/vtune_linux.cpp - src/os/solaris/vm/vtune_solaris.cpp - src/os/windows/vm/vtune_windows.cpp - src/share/vm/runtime/vtune.hpp Changeset: c5cadf1a0771 Author: trims Date: 2010-07-20 18:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c5cadf1a0771 Merge ! .hgtags Changeset: cb4250ef73b2 Author: mikejwre Date: 2010-07-23 16:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/cb4250ef73b2 Added tag jdk7-b102 for changeset c5cadf1a0771 ! .hgtags From lana.steuck at oracle.com Thu Jul 29 23:31:48 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 30 Jul 2010 06:31:48 +0000 Subject: hg: jdk7/tl/jaxp: 7 new changesets Message-ID: <20100730063148.B0C1447D9A@hg.openjdk.java.net> Changeset: 478835e100cd Author: lana Date: 2010-06-21 22:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/478835e100cd Merge Changeset: d524be5ef62e Author: lana Date: 2010-06-29 22:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/d524be5ef62e Merge Changeset: 17f62a566a20 Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/17f62a566a20 Added tag jdk7-b100 for changeset d524be5ef62e ! .hgtags Changeset: c9bd73f6d584 Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/c9bd73f6d584 Added tag jdk7-b101 for changeset 17f62a566a20 ! .hgtags Changeset: 70c8a34e2eb6 Author: lana Date: 2010-07-12 19:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/70c8a34e2eb6 Merge Changeset: 15573625af97 Author: lana Date: 2010-07-20 22:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/15573625af97 Merge Changeset: b7722e878864 Author: mikejwre Date: 2010-07-23 16:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/b7722e878864 Added tag jdk7-b102 for changeset 15573625af97 ! .hgtags From lana.steuck at oracle.com Thu Jul 29 23:31:53 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 30 Jul 2010 06:31:53 +0000 Subject: hg: jdk7/tl/jaxws: 7 new changesets Message-ID: <20100730063153.8225747D9B@hg.openjdk.java.net> Changeset: db63f482182d Author: lana Date: 2010-06-21 22:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/db63f482182d Merge Changeset: bd26d0ce0c3c Author: lana Date: 2010-06-29 22:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/bd26d0ce0c3c Merge Changeset: b55ce2744900 Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/b55ce2744900 Added tag jdk7-b100 for changeset bd26d0ce0c3c ! .hgtags Changeset: d1525c38428a Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/d1525c38428a Added tag jdk7-b101 for changeset b55ce2744900 ! .hgtags Changeset: 2b7a1ec9562e Author: lana Date: 2010-07-12 19:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/2b7a1ec9562e Merge Changeset: d8580443d181 Author: lana Date: 2010-07-20 22:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/d8580443d181 Merge Changeset: 267386d6b923 Author: mikejwre Date: 2010-07-23 16:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/267386d6b923 Added tag jdk7-b102 for changeset d8580443d181 ! .hgtags From lana.steuck at oracle.com Thu Jul 29 23:35:09 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 30 Jul 2010 06:35:09 +0000 Subject: hg: jdk7/tl/jdk: 58 new changesets Message-ID: <20100730064427.EA6BE47D9C@hg.openjdk.java.net> Changeset: 4d55419ce99e Author: andrew Date: 2010-06-08 17:52 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4d55419ce99e 6959123: Remove use of obsolete png_check_sig function in splashscreen_png.c Summary: Avoid use of deprecated libpng macro (removed in some 1.4.x releases) Reviewed-by: prr ! src/share/native/sun/awt/splashscreen/splashscreen_png.c Changeset: 2574d999704a Author: igor Date: 2010-06-10 15:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2574d999704a 6952043: Incorrect JNI calls in fontpath.c Reviewed-by: jgodinez, prr ! src/windows/native/sun/font/fontpath.c Changeset: ae887ea4c772 Author: lana Date: 2010-06-10 18:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ae887ea4c772 Merge - make/com/sun/inputmethods/Makefile - make/com/sun/inputmethods/indicim/Makefile - make/com/sun/inputmethods/thaiim/Makefile - src/share/classes/com/sun/inputmethods/internal/indicim/DevanagariInputMethodDescriptor.java - src/share/classes/com/sun/inputmethods/internal/indicim/DevanagariTables.java - src/share/classes/com/sun/inputmethods/internal/indicim/IndicInputMethod.java - src/share/classes/com/sun/inputmethods/internal/indicim/IndicInputMethodImpl.java - src/share/classes/com/sun/inputmethods/internal/indicim/java.awt.im.spi.InputMethodDescriptor - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_de.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_es.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_fr.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_it.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_ja.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_ko.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_sv.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_zh_CN.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_zh_TW.properties - src/share/classes/com/sun/inputmethods/internal/thaiim/ThaiInputMethod.java - src/share/classes/com/sun/inputmethods/internal/thaiim/ThaiInputMethodDescriptor.java - src/share/classes/com/sun/inputmethods/internal/thaiim/ThaiInputMethodImpl.java - src/share/classes/com/sun/inputmethods/internal/thaiim/ThaiRules.java - src/share/classes/com/sun/inputmethods/internal/thaiim/java.awt.im.spi.InputMethodDescriptor - src/share/classes/com/sun/inputmethods/internal/thaiim/resources/DisplayNames.properties - src/share/classes/javax/swing/text/html/parser/html32.bdtd - src/share/classes/sun/security/tools/PolicyTool.java Changeset: 8b55669c7b7a Author: neugens Date: 2010-06-16 20:46 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8b55669c7b7a 6961732: FontMetrics.getLeading() may be negative in freetype-based OpenJDK builds. Summary: Fix premature integer roundings to preserve correct height, width and descent values for fonts Reviewed-by: prr ! src/share/native/sun/font/freetypeScaler.c Changeset: 83c7768292d7 Author: prr Date: 2010-06-18 11:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/83c7768292d7 6961633: gui applications cause a jvm crash on windows Reviewed-by: ceisserer, bae ! make/sun/pisces/Makefile ! src/share/classes/sun/java2d/pisces/META-INF/services/sun.java2d.pipe.RenderingEngine + src/solaris/classes/sun/java2d/pisces/META-INF/services/sun.java2d.pipe.RenderingEngine Changeset: 31d25fccdf1c Author: lana Date: 2010-06-21 22:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/31d25fccdf1c Merge Changeset: c02096d7b70e Author: anthony Date: 2010-06-16 11:26 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c02096d7b70e 6959787: java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html failed on 7b94 Summary: Add a delay to the test to make sure the filename filters are called. Reviewed-by: dcherepanov, art ! test/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java Changeset: fa06ad055c43 Author: coffeys Date: 2010-06-16 16:15 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fa06ad055c43 6860491: WRAP_TIME_MILLIS incorrectly set Summary: Alter WRAP_TIME_MILLIS to be unsigned Reviewed-by: yan ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: 8722b75c9ccd Author: anthony Date: 2010-06-18 17:09 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8722b75c9ccd 6959165: JVM crash during execution FileDialogBufferOverflowTest.html Summary: Add proper synchronization Reviewed-by: art, dcherepanov ! src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.c Changeset: 05eb107d6891 Author: anthony Date: 2010-06-18 17:13 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/05eb107d6891 6961754: JCK tests CvsEventTest0001 and CvsEventTest0002 fail under FF 3.5 on OEL 5 Summary: Check the return value of XlibUtil.translateCoordinates() for null Reviewed-by: art, dcherepanov ! src/solaris/classes/sun/awt/X11/XEmbeddedFramePeer.java ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: ae16c200341a Author: lana Date: 2010-06-21 22:05 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ae16c200341a Merge Changeset: ad5f65797249 Author: rupashka Date: 2010-06-02 11:59 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ad5f65797249 6857057: api/javax_swing/text/GlyphView/index.html#Methods test fails Reviewed-by: peterz ! src/share/classes/javax/swing/text/Utilities.java ! src/share/classes/javax/swing/text/WrappedPlainView.java + test/javax/swing/text/WrappedPlainView/6857057/StubBranchElement.java + test/javax/swing/text/WrappedPlainView/6857057/StubLeafElement.java + test/javax/swing/text/WrappedPlainView/6857057/bug6857057.java Changeset: dc14ee238fe3 Author: rupashka Date: 2010-06-02 12:53 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dc14ee238fe3 6636983: Japanese text does not display correctly in a JEditorPane Reviewed-by: peterz ! src/share/classes/javax/swing/text/DefaultStyledDocument.java ! src/share/classes/javax/swing/text/GlyphView.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/sun/swing/SwingUtilities2.java + test/javax/swing/text/DefaultStyledDocument/6636983/bug6636983.java Changeset: d1c875d94263 Author: lana Date: 2010-06-10 14:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d1c875d94263 Merge - src/share/classes/sun/security/tools/PolicyTool.java Changeset: 7a3d8fc0d2cd Author: malenkov Date: 2010-06-15 17:39 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7a3d8fc0d2cd 5066685: BorderFactory lacks SoftBevelBorder support Reviewed-by: alexp ! src/share/classes/javax/swing/BorderFactory.java Changeset: cf13f6389bdd Author: alexp Date: 2010-06-15 19:05 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cf13f6389bdd 6788484: NPE in DefaultTableCellHeaderRenderer.getColumnSortOrder() with null table Reviewed-by: rupashka ! src/share/classes/sun/swing/table/DefaultTableCellHeaderRenderer.java + test/javax/swing/JTable/6788484/bug6788484.java Changeset: 5e4969391538 Author: alexp Date: 2010-06-15 19:10 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5e4969391538 6735259: NPE at WindowsComboBoxUI$XPComboBoxButton.getState(WindowsComboBoxUI.java:408) Reviewed-by: rupashka ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsComboBoxUI.java Changeset: cd565c554dc6 Author: alexp Date: 2010-06-15 21:28 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cd565c554dc6 6771547: SynthParser throws StringIndexOutOfBoundsException parsing custom ColorTypes Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/synth/SynthParser.java + test/javax/swing/plaf/synth/6771547/SynthTest.java + test/javax/swing/plaf/synth/6771547/synthconfig.xml Changeset: 4d93c409ce87 Author: alexp Date: 2010-06-15 21:32 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4d93c409ce87 6739756: JToolBar leaves space for non-visible items under Nimbus L&F Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/synth/SynthToolBarUI.java + test/javax/swing/plaf/synth/SynthToolBarUI/6739756/bug6739756.java Changeset: aaa62c1f221e Author: lana Date: 2010-06-21 22:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/aaa62c1f221e Merge Changeset: 5438223734aa Author: lana Date: 2010-06-21 22:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5438223734aa Merge Changeset: 10a6319c9c15 Author: lana Date: 2010-06-29 22:34 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/10a6319c9c15 Merge Changeset: 861213cb02c3 Author: prr Date: 2010-06-29 16:34 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/861213cb02c3 6964882: 32 bit JDK does not build on 64 bit Windows platforms Reviewed-by: ohair, valeriep ! make/sun/security/mscapi/Makefile ! make/sun/security/pkcs11/Makefile Changeset: 511ddf6938ea Author: mikejwre Date: 2010-06-30 18:57 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/511ddf6938ea Merge Changeset: 820b4e843d51 Author: ohair Date: 2010-07-07 10:21 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/820b4e843d51 6967036: Need to fix links with // in Javadoc comments Reviewed-by: mchung ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/Base64.java ! src/share/classes/com/sun/security/auth/LdapPrincipal.java ! src/share/classes/com/sun/security/sasl/CramMD5Client.java ! src/share/classes/com/sun/security/sasl/CramMD5Server.java ! src/share/classes/com/sun/security/sasl/ExternalClient.java ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Client.java ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Server.java ! src/share/classes/java/net/URI.java ! src/share/classes/java/nio/charset/package.html ! src/share/classes/javax/management/remote/JMXServiceURL.java ! src/share/classes/javax/naming/ldap/LdapName.java ! src/share/classes/javax/naming/ldap/Rdn.java ! src/share/classes/javax/net/ssl/SSLContext.java ! src/share/classes/javax/print/DocFlavor.java ! src/share/classes/sun/awt/image/PNGImageDecoder.java Changeset: 93c4e6d14010 Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/93c4e6d14010 Added tag jdk7-b100 for changeset 820b4e843d51 ! .hgtags Changeset: d58354a69011 Author: bpatel Date: 2010-07-14 15:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d58354a69011 6955341: Oracle rebranding changes for man pages Reviewed-by: darcy ! src/linux/doc/man/appletviewer.1 ! src/linux/doc/man/apt.1 ! src/linux/doc/man/extcheck.1 ! src/linux/doc/man/idlj.1 ! src/linux/doc/man/ja/appletviewer.1 ! src/linux/doc/man/ja/apt.1 ! src/linux/doc/man/ja/extcheck.1 ! src/linux/doc/man/ja/idlj.1 ! src/linux/doc/man/ja/jar.1 ! src/linux/doc/man/ja/jarsigner.1 ! src/linux/doc/man/ja/java.1 ! src/linux/doc/man/ja/javac.1 ! src/linux/doc/man/ja/javadoc.1 ! src/linux/doc/man/ja/javah.1 ! src/linux/doc/man/ja/javap.1 ! src/linux/doc/man/ja/javaws.1 ! src/linux/doc/man/ja/jconsole.1 ! src/linux/doc/man/ja/jdb.1 ! src/linux/doc/man/ja/jhat.1 ! src/linux/doc/man/ja/jinfo.1 ! src/linux/doc/man/ja/jmap.1 ! src/linux/doc/man/ja/jps.1 ! src/linux/doc/man/ja/jrunscript.1 ! src/linux/doc/man/ja/jsadebugd.1 ! src/linux/doc/man/ja/jstack.1 ! src/linux/doc/man/ja/jstat.1 ! src/linux/doc/man/ja/jstatd.1 ! src/linux/doc/man/ja/keytool.1 - src/linux/doc/man/ja/kinit.1 - src/linux/doc/man/ja/klist.1 - src/linux/doc/man/ja/ktab.1 ! src/linux/doc/man/ja/native2ascii.1 ! src/linux/doc/man/ja/orbd.1 ! src/linux/doc/man/ja/pack200.1 ! src/linux/doc/man/ja/policytool.1 ! src/linux/doc/man/ja/rmic.1 ! src/linux/doc/man/ja/rmid.1 ! src/linux/doc/man/ja/rmiregistry.1 ! src/linux/doc/man/ja/schemagen.1 ! src/linux/doc/man/ja/serialver.1 ! src/linux/doc/man/ja/servertool.1 ! src/linux/doc/man/ja/tnameserv.1 ! src/linux/doc/man/ja/unpack200.1 ! src/linux/doc/man/ja/wsgen.1 ! src/linux/doc/man/ja/wsimport.1 ! src/linux/doc/man/ja/xjc.1 ! src/linux/doc/man/jar.1 ! src/linux/doc/man/jarsigner.1 ! src/linux/doc/man/java.1 ! src/linux/doc/man/javac.1 ! src/linux/doc/man/javadoc.1 ! src/linux/doc/man/javah.1 ! src/linux/doc/man/javap.1 ! src/linux/doc/man/javaws.1 ! src/linux/doc/man/jconsole.1 ! src/linux/doc/man/jdb.1 ! src/linux/doc/man/jhat.1 ! src/linux/doc/man/jinfo.1 ! src/linux/doc/man/jmap.1 ! src/linux/doc/man/jps.1 ! src/linux/doc/man/jrunscript.1 ! src/linux/doc/man/jsadebugd.1 ! src/linux/doc/man/jstack.1 ! src/linux/doc/man/jstat.1 ! src/linux/doc/man/jstatd.1 ! src/linux/doc/man/keytool.1 ! src/linux/doc/man/native2ascii.1 ! src/linux/doc/man/orbd.1 ! src/linux/doc/man/pack200.1 ! src/linux/doc/man/policytool.1 ! src/linux/doc/man/rmic.1 ! src/linux/doc/man/rmid.1 ! src/linux/doc/man/rmiregistry.1 ! src/linux/doc/man/schemagen.1 ! src/linux/doc/man/serialver.1 ! src/linux/doc/man/servertool.1 ! src/linux/doc/man/tnameserv.1 ! src/linux/doc/man/unpack200.1 ! src/linux/doc/man/wsgen.1 ! src/linux/doc/man/wsimport.1 ! src/linux/doc/man/xjc.1 ! src/solaris/doc/sun/man/man1/appletviewer.1 ! src/solaris/doc/sun/man/man1/apt.1 ! src/solaris/doc/sun/man/man1/extcheck.1 ! src/solaris/doc/sun/man/man1/idlj.1 ! src/solaris/doc/sun/man/man1/ja/appletviewer.1 ! src/solaris/doc/sun/man/man1/ja/apt.1 ! src/solaris/doc/sun/man/man1/ja/extcheck.1 ! src/solaris/doc/sun/man/man1/ja/idlj.1 ! src/solaris/doc/sun/man/man1/ja/jar.1 ! src/solaris/doc/sun/man/man1/ja/jarsigner.1 ! src/solaris/doc/sun/man/man1/ja/java.1 ! src/solaris/doc/sun/man/man1/ja/javac.1 ! src/solaris/doc/sun/man/man1/ja/javadoc.1 ! src/solaris/doc/sun/man/man1/ja/javah.1 ! src/solaris/doc/sun/man/man1/ja/javap.1 ! src/solaris/doc/sun/man/man1/ja/javaws.1 ! src/solaris/doc/sun/man/man1/ja/jconsole.1 ! src/solaris/doc/sun/man/man1/ja/jdb.1 ! src/solaris/doc/sun/man/man1/ja/jhat.1 ! src/solaris/doc/sun/man/man1/ja/jinfo.1 ! src/solaris/doc/sun/man/man1/ja/jmap.1 ! src/solaris/doc/sun/man/man1/ja/jps.1 ! src/solaris/doc/sun/man/man1/ja/jrunscript.1 ! src/solaris/doc/sun/man/man1/ja/jsadebugd.1 ! src/solaris/doc/sun/man/man1/ja/jstack.1 ! src/solaris/doc/sun/man/man1/ja/jstat.1 ! src/solaris/doc/sun/man/man1/ja/jstatd.1 ! src/solaris/doc/sun/man/man1/ja/keytool.1 ! src/solaris/doc/sun/man/man1/ja/native2ascii.1 ! src/solaris/doc/sun/man/man1/ja/orbd.1 ! src/solaris/doc/sun/man/man1/ja/pack200.1 ! src/solaris/doc/sun/man/man1/ja/policytool.1 ! src/solaris/doc/sun/man/man1/ja/rmic.1 ! src/solaris/doc/sun/man/man1/ja/rmid.1 ! src/solaris/doc/sun/man/man1/ja/rmiregistry.1 ! src/solaris/doc/sun/man/man1/ja/schemagen.1 ! src/solaris/doc/sun/man/man1/ja/serialver.1 ! src/solaris/doc/sun/man/man1/ja/servertool.1 ! src/solaris/doc/sun/man/man1/ja/tnameserv.1 ! src/solaris/doc/sun/man/man1/ja/unpack200.1 ! src/solaris/doc/sun/man/man1/ja/wsgen.1 ! src/solaris/doc/sun/man/man1/ja/wsimport.1 ! src/solaris/doc/sun/man/man1/ja/xjc.1 ! src/solaris/doc/sun/man/man1/jar.1 ! src/solaris/doc/sun/man/man1/jarsigner.1 ! src/solaris/doc/sun/man/man1/java.1 ! src/solaris/doc/sun/man/man1/javac.1 ! src/solaris/doc/sun/man/man1/javadoc.1 ! src/solaris/doc/sun/man/man1/javah.1 ! src/solaris/doc/sun/man/man1/javap.1 ! src/solaris/doc/sun/man/man1/javaws.1 ! src/solaris/doc/sun/man/man1/jconsole.1 ! src/solaris/doc/sun/man/man1/jdb.1 ! src/solaris/doc/sun/man/man1/jhat.1 ! src/solaris/doc/sun/man/man1/jinfo.1 ! src/solaris/doc/sun/man/man1/jmap.1 ! src/solaris/doc/sun/man/man1/jps.1 ! src/solaris/doc/sun/man/man1/jrunscript.1 ! src/solaris/doc/sun/man/man1/jsadebugd.1 ! src/solaris/doc/sun/man/man1/jstack.1 ! src/solaris/doc/sun/man/man1/jstat.1 ! src/solaris/doc/sun/man/man1/jstatd.1 ! src/solaris/doc/sun/man/man1/keytool.1 ! src/solaris/doc/sun/man/man1/native2ascii.1 ! src/solaris/doc/sun/man/man1/orbd.1 ! src/solaris/doc/sun/man/man1/pack200.1 ! src/solaris/doc/sun/man/man1/policytool.1 ! src/solaris/doc/sun/man/man1/rmic.1 ! src/solaris/doc/sun/man/man1/rmid.1 ! src/solaris/doc/sun/man/man1/rmiregistry.1 ! src/solaris/doc/sun/man/man1/schemagen.1 ! src/solaris/doc/sun/man/man1/serialver.1 ! src/solaris/doc/sun/man/man1/servertool.1 ! src/solaris/doc/sun/man/man1/tnameserv.1 ! src/solaris/doc/sun/man/man1/unpack200.1 ! src/solaris/doc/sun/man/man1/wsgen.1 ! src/solaris/doc/sun/man/man1/wsimport.1 ! src/solaris/doc/sun/man/man1/xjc.1 Changeset: 6c4450bbad6d Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6c4450bbad6d Added tag jdk7-b101 for changeset d58354a69011 ! .hgtags Changeset: c801686d91f4 Author: prr Date: 2010-06-29 09:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c801686d91f4 6943487: NPE in makeMultiCharsetString while printing on linux Reviewed-by: igor, jgodinez ! src/share/classes/sun/awt/PlatformFont.java ! src/share/classes/sun/java2d/HeadlessGraphicsEnvironment.java Changeset: 4da6837dd085 Author: lana Date: 2010-06-30 15:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4da6837dd085 Merge Changeset: ab55cb957830 Author: igor Date: 2010-07-06 18:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ab55cb957830 6967050: JDK build issues with cygwin/vc2010 Reviewed-by: prr, ohair ! make/common/shared/Defs-windows.gmk ! make/mkdemo/Makefile Changeset: e03065fc64e7 Author: igor Date: 2010-07-12 13:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e03065fc64e7 6959998: Return of SurfaceData_InitOps point not checked in all cases (parfait found these) Reviewed-by: prr Contributed-by: ohair ! src/share/native/sun/awt/image/BufImgSurfaceData.c ! src/solaris/native/sun/java2d/opengl/GLXSurfaceData.c ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c ! src/windows/native/sun/java2d/opengl/WGLSurfaceData.c ! src/windows/native/sun/java2d/windows/GDIWindowSurfaceData.cpp Changeset: 2ad69cb576b4 Author: igor Date: 2010-07-12 15:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2ad69cb576b4 6968373: FontUtilities static initializer throws AccessControlException Reviewed-by: prr ! src/share/classes/sun/font/FontUtilities.java ! test/java/awt/FontClass/FontPrivilege.java Changeset: 4a639bcd3361 Author: lana Date: 2010-07-12 19:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4a639bcd3361 Merge Changeset: f5145c7119c2 Author: yan Date: 2010-06-24 11:50 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f5145c7119c2 6957166: With XAWT, set arguments properly creating a MouseWheelEvent. Summary: swap some parameters to allow bigger values for click count. Reviewed-by: dav ! src/solaris/classes/sun/awt/X11/XWindow.java Changeset: bccf2a4ee318 Author: art Date: 2010-07-06 17:59 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bccf2a4ee318 6424157: java.awt.EventQueue push/pop might cause threading issues Reviewed-by: ant, dcherepanov ! src/share/classes/java/awt/EventDispatchThread.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/sun/awt/SunToolkit.java ! test/java/awt/EventDispatchThread/HandleExceptionOnEDT/HandleExceptionOnEDT.java ! test/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.java + test/java/awt/EventDispatchThread/PreserveDispathThread/PreserveDispatchThread.java ! test/java/awt/EventQueue/PushPopDeadlock2/PushPopTest.java Changeset: 21b17c64df74 Author: dcherepanov Date: 2010-07-06 18:23 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/21b17c64df74 6966643: GTK FileDialog hangs when user manually closes it Reviewed-by: art ! src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.c Changeset: 9950dc616615 Author: dcherepanov Date: 2010-07-07 14:20 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9950dc616615 6959174: Need to introduce sun.awt.disableGtkFileDialogs system property Reviewed-by: art, anthony ! src/share/classes/sun/awt/SunToolkit.java ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: 48aa2a1edd2b Author: lana Date: 2010-07-08 11:28 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/48aa2a1edd2b Merge Changeset: 2d8f060dd1c5 Author: lana Date: 2010-07-12 19:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2d8f060dd1c5 Merge Changeset: 69ddf06e616a Author: malenkov Date: 2010-06-22 12:06 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/69ddf06e616a 6707234: Method returned by Introspector.internalFindMethod not necessarily most specific Reviewed-by: peterz ! src/share/classes/com/sun/beans/finder/MethodFinder.java ! src/share/classes/java/beans/EventSetDescriptor.java ! src/share/classes/java/beans/IndexedPropertyDescriptor.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/MethodDescriptor.java ! src/share/classes/java/beans/PropertyDescriptor.java + test/java/beans/Introspector/Test6707234.java Changeset: 5af3b0430bbe Author: peterz Date: 2010-06-22 14:36 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5af3b0430bbe 6959260: javax/swing/JLabel/6501991/bug6501991.java failed on build 1.7.0-ea-b96 Reviewed-by: rupashka ! src/share/classes/sun/swing/SwingUtilities2.java ! test/ProblemList.txt ! test/com/sun/java/swing/plaf/gtk/Test6635110.java Changeset: dea63f6dda7a Author: alexp Date: 2010-06-22 19:38 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dea63f6dda7a 6777378: NullPointerException in XPDefaultRenderer.paint() Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/basic/BasicTableHeaderUI.java + test/javax/swing/JTable/6777378/bug6777378.java Changeset: a05e047c5b98 Author: alexp Date: 2010-06-22 20:36 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a05e047c5b98 6684401: JTree isExpanded should not call itself recursively Reviewed-by: rupashka ! src/share/classes/javax/swing/JTree.java Changeset: f1bafc4f249d Author: peterz Date: 2010-06-29 14:42 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f1bafc4f249d 6963870: NPE in CompoundBorder.getInsets() Reviewed-by: alexp Contributed-by: jon.vanalten at redhat.com ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKPainter.java + test/com/sun/java/swing/plaf/gtk/Test6963870.java Changeset: c0e785f055a7 Author: lana Date: 2010-06-30 19:05 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c0e785f055a7 Merge ! test/ProblemList.txt Changeset: d062afbe2107 Author: malenkov Date: 2010-07-01 18:09 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d062afbe2107 4129681: Cannot get a title border to display its label as disabled Reviewed-by: alexp, rupashka ! src/share/classes/javax/swing/border/TitledBorder.java + test/javax/swing/border/Test4129681.html + test/javax/swing/border/Test4129681.java + test/javax/swing/border/Test4760089.html + test/javax/swing/border/Test4760089.java Changeset: 46306a419ba3 Author: malenkov Date: 2010-07-01 18:47 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/46306a419ba3 6959266: test javax/swing/JInternalFrame/6725409/bug6725409.java should be modified Reviewed-by: alexp ! test/javax/swing/JInternalFrame/6725409/bug6725409.java Changeset: e94a94d176f9 Author: alexp Date: 2010-07-02 19:28 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e94a94d176f9 6711682: JCheckBox in JTable: checkbox doesn't alaways respond to the first mouse click Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/basic/BasicButtonListener.java + test/javax/swing/AbstractButton/6711682/bug6711682.java Changeset: 46d5aef470a3 Author: alexp Date: 2010-07-02 19:34 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/46d5aef470a3 6937415: Some components return undocumented default values under Nimbus LaF Reviewed-by: peterz ! src/share/classes/javax/swing/JSplitPane.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/plaf/nimbus/skin.laf Changeset: e12c92d2dc11 Author: rupashka Date: 2010-07-08 19:09 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e12c92d2dc11 6520101: FileChooser will cause OutOfMemory when application will run long time Reviewed-by: peterz ! src/share/classes/com/sun/java/swing/plaf/motif/MotifFileChooserUI.java + test/javax/swing/JFileChooser/6520101/bug6520101.java Changeset: d0bcc9aa5a7a Author: malenkov Date: 2010-07-09 19:42 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d0bcc9aa5a7a 6894597: test/closed/javax/swing/JPopupMenu/6495920/bug6495920.java fails Reviewed-by: alexp, peterz + test/javax/swing/JPopupMenu/6495920/bug6495920.java Changeset: 3dc686ecb4cd Author: malenkov Date: 2010-07-09 22:07 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3dc686ecb4cd 6963811: Deadlock-prone locking changes in Introspector Reviewed-by: peterz, rupashka ! src/share/classes/com/sun/beans/finder/InstanceFinder.java ! src/share/classes/com/sun/beans/finder/PersistenceDelegateFinder.java ! src/share/classes/com/sun/beans/finder/PropertyEditorFinder.java ! src/share/classes/java/beans/Encoder.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/PropertyEditorManager.java + test/java/beans/Introspector/Test6963811.java + test/java/beans/PropertyEditor/Test6963811.java + test/java/beans/XMLEncoder/Test6963811.java Changeset: a93a7ed5018c Author: lana Date: 2010-07-12 19:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a93a7ed5018c Merge Changeset: c5a436f053aa Author: lana Date: 2010-07-12 19:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c5a436f053aa Merge ! test/ProblemList.txt - test/java/nio/channels/ServerSocketChannel/AcceptAddress.java - test/java/nio/charset/coders/Surrogate.java - test/tools/launcher/Makefile.SolarisRunpath - test/tools/launcher/lib/i386/lib32/lib32/liblibrary.so - test/tools/launcher/lib/i386/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib64/lib64/liblibrary.so - test/tools/launcher/lib/sparc/lib64/liblibrary.so Changeset: 13029a61b16b Author: lana Date: 2010-07-20 22:21 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/13029a61b16b Merge - test/java/nio/channels/ServerSocketChannel/AcceptAddress.java - test/java/nio/charset/coders/Surrogate.java - test/tools/launcher/Makefile.SolarisRunpath - test/tools/launcher/lib/i386/lib32/lib32/liblibrary.so - test/tools/launcher/lib/i386/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib64/lib64/liblibrary.so - test/tools/launcher/lib/sparc/lib64/liblibrary.so Changeset: 6488b70a23cc Author: mikejwre Date: 2010-07-23 16:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6488b70a23cc Added tag jdk7-b102 for changeset 13029a61b16b ! .hgtags Changeset: 48e6f4807e5f Author: lana Date: 2010-07-29 22:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/48e6f4807e5f Merge - src/linux/doc/man/ja/kinit.1 - src/linux/doc/man/ja/klist.1 - src/linux/doc/man/ja/ktab.1 ! test/ProblemList.txt From lana.steuck at oracle.com Fri Jul 30 00:00:21 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 30 Jul 2010 07:00:21 +0000 Subject: hg: jdk7/tl/langtools: 8 new changesets Message-ID: <20100730070034.DE75947D9E@hg.openjdk.java.net> Changeset: 4cca8d7ce6c1 Author: lana Date: 2010-06-21 22:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4cca8d7ce6c1 Merge Changeset: d1d7595fa824 Author: lana Date: 2010-06-29 22:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d1d7595fa824 Merge ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/util/Names.java Changeset: 20a8fe72ee7b Author: mikejwre Date: 2010-07-09 19:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/20a8fe72ee7b Added tag jdk7-b100 for changeset d1d7595fa824 ! .hgtags Changeset: f87f1f3e23e1 Author: mikejwre Date: 2010-07-15 20:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f87f1f3e23e1 Added tag jdk7-b101 for changeset 20a8fe72ee7b ! .hgtags Changeset: eaab979c8b36 Author: lana Date: 2010-07-12 19:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/eaab979c8b36 Merge Changeset: ff9c0a0bf7ed Author: lana Date: 2010-07-20 22:22 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ff9c0a0bf7ed Merge Changeset: bd85271c580c Author: mikejwre Date: 2010-07-23 16:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/bd85271c580c Added tag jdk7-b102 for changeset ff9c0a0bf7ed ! .hgtags Changeset: 077eb94c912d Author: lana Date: 2010-07-29 22:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/077eb94c912d Merge From mandy.chung at oracle.com Fri Jul 30 10:31:49 2010 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 30 Jul 2010 10:31:49 -0700 Subject: [Fwd: Re: Review request: 6581734 CMS Old Gen's collection usage is zero after GC which is incorrect] In-Reply-To: <4C52F53F.90407@oracle.com> References: <4C52F53F.90407@oracle.com> Message-ID: <4C530C85.4030402@oracle.com> Hi Kevin, Thanks for fixing this. Looks good with some minor comments: memoryManager.hpp line 181-182: get_last_gc_stat() returns gc_index but the comment says it returns the size of the array pool. management.cpp line 1908: if (!mgr->get_last_gc_stat(stat) == 0) { You forgot to take out "!" when you changed the get_last_gc_stat() to return size_t instead of bool. test/gc/6581734/Test6581734.java @run main/othervm -server -Xmx512m -verbose:gc ... Why do you need "-server"? We also want client VM to be tested, right? You can drop -verbose:gc and use MemoryMXBean.setVerbose(true) to turn on gc tracing if you like. The test source isn't formatted properly, e.g. line 49-56, 69-75, 79-124, 127, 131. Can you fix the formatting - using 4 spaces as indentation (not tab or 2 spaces)? Thanks Mandy Kevin Walls wrote: > > Hi Mandy, > > Yes, thanks for the discussions we've had so far. 8-) > > Here's an updated JDK7 version: > > http://cr.openjdk.java.net/~kevinw/6581734/webrev.01/ > > Thanks > Kevin > > Mandy Chung wrote: >> Kevin, >> >> As I know, you're revising the fix for the 6 update release. I'll >> review your revised webrev when it's ready. >> >> Thanks >> Mandy >> >> Kevin Walls wrote: >>> Hi - >>> >>> This is a review request for the issue where cms doesn't update the >>> statistics used by the MemoryPoolMXBean system: only concurrent mode >>> failures update the stats. We just aren't prepared for concurrent >>> collections, so it takes a fair amount of customisation to add that >>> flexibility... >>> >>> http://cr.openjdk.java.net/~kevinw/6581734/webrev/ >>> >>> Thanks >>> Kevin >>> >>> >>> >>> >>> >> > From kevin.walls at oracle.com Fri Jul 30 13:30:35 2010 From: kevin.walls at oracle.com (Kevin Walls) Date: Fri, 30 Jul 2010 21:30:35 +0100 Subject: [Fwd: Re: Review request: 6581734 CMS Old Gen's collection usage is zero after GC which is incorrect] In-Reply-To: <4C530C85.4030402@oracle.com> References: <4C52F53F.90407@oracle.com> <4C530C85.4030402@oracle.com> Message-ID: <4C53366B.6010802@oracle.com> Great, thanks - respun as http://cr.openjdk.java.net/~kevinw/6581734/webrev.02/ Mandy Chung wrote: > Hi Kevin, > > Thanks for fixing this. Looks good with some minor comments: > > memoryManager.hpp line 181-182: > get_last_gc_stat() returns gc_index but the comment says it returns > the size of the array pool. > > management.cpp line 1908: > if (!mgr->get_last_gc_stat(stat) == 0) { > > You forgot to take out "!" when you changed the get_last_gc_stat() to > return size_t instead of bool. > > test/gc/6581734/Test6581734.java > @run main/othervm -server -Xmx512m -verbose:gc ... > > Why do you need "-server"? We also want client VM to be tested, right? > > You can drop -verbose:gc and use MemoryMXBean.setVerbose(true) to turn > on gc tracing if you like. > > The test source isn't formatted properly, e.g. line 49-56, 69-75, > 79-124, 127, 131. Can you fix the formatting - using 4 spaces as > indentation (not tab or 2 spaces)? > > Thanks > Mandy > > Kevin Walls wrote: >> >> Hi Mandy, >> >> Yes, thanks for the discussions we've had so far. 8-) >> >> Here's an updated JDK7 version: >> >> http://cr.openjdk.java.net/~kevinw/6581734/webrev.01/ >> >> Thanks >> Kevin >> >> Mandy Chung wrote: >>> Kevin, >>> >>> As I know, you're revising the fix for the 6 update release. I'll >>> review your revised webrev when it's ready. >>> >>> Thanks >>> Mandy >>> >>> Kevin Walls wrote: >>>> Hi - >>>> >>>> This is a review request for the issue where cms doesn't update the >>>> statistics used by the MemoryPoolMXBean system: only concurrent >>>> mode failures update the stats. We just aren't prepared for >>>> concurrent collections, so it takes a fair amount of customisation >>>> to add that flexibility... >>>> >>>> http://cr.openjdk.java.net/~kevinw/6581734/webrev/ >>>> >>>> Thanks >>>> Kevin >>>> >>>> >>>> >>>> >>>> >>> >> > From mandy.chung at oracle.com Fri Jul 30 13:44:58 2010 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 30 Jul 2010 13:44:58 -0700 Subject: [Fwd: Re: Review request: 6581734 CMS Old Gen's collection usage is zero after GC which is incorrect] In-Reply-To: <4C53366B.6010802@oracle.com> References: <4C52F53F.90407@oracle.com> <4C530C85.4030402@oracle.com> <4C53366B.6010802@oracle.com> Message-ID: <4C5339CA.2080805@oracle.com> Kevin Walls wrote: > > Great, thanks - respun as > http://cr.openjdk.java.net/~kevinw/6581734/webrev.02/ > This looks better. Test6581734.java: All methods/fields in this class should have indented (currently not indented). Also line 118 has 3 extra spaces. Thanks Mandy > > > Mandy Chung wrote: >> Hi Kevin, >> >> Thanks for fixing this. Looks good with some minor comments: >> >> memoryManager.hpp line 181-182: >> get_last_gc_stat() returns gc_index but the comment says it returns >> the size of the array pool. >> >> management.cpp line 1908: >> if (!mgr->get_last_gc_stat(stat) == 0) { >> >> You forgot to take out "!" when you changed the get_last_gc_stat() to >> return size_t instead of bool. >> >> test/gc/6581734/Test6581734.java >> @run main/othervm -server -Xmx512m -verbose:gc ... >> >> Why do you need "-server"? We also want client VM to be tested, right? >> >> You can drop -verbose:gc and use MemoryMXBean.setVerbose(true) to >> turn on gc tracing if you like. >> >> The test source isn't formatted properly, e.g. line 49-56, 69-75, >> 79-124, 127, 131. Can you fix the formatting - using 4 spaces as >> indentation (not tab or 2 spaces)? >> >> Thanks >> Mandy >> >> Kevin Walls wrote: >>> >>> Hi Mandy, >>> >>> Yes, thanks for the discussions we've had so far. 8-) >>> >>> Here's an updated JDK7 version: >>> >>> http://cr.openjdk.java.net/~kevinw/6581734/webrev.01/ >>> >>> Thanks >>> Kevin >>> >>> Mandy Chung wrote: >>>> Kevin, >>>> >>>> As I know, you're revising the fix for the 6 update release. I'll >>>> review your revised webrev when it's ready. >>>> >>>> Thanks >>>> Mandy >>>> >>>> Kevin Walls wrote: >>>>> Hi - >>>>> >>>>> This is a review request for the issue where cms doesn't update >>>>> the statistics used by the MemoryPoolMXBean system: only >>>>> concurrent mode failures update the stats. We just aren't >>>>> prepared for concurrent collections, so it takes a fair amount of >>>>> customisation to add that flexibility... >>>>> >>>>> http://cr.openjdk.java.net/~kevinw/6581734/webrev/ >>>>> >>>>> Thanks >>>>> Kevin >>>>> >>>>> >>>>> >>>>> >>>>> >>>> >>> >> > From kevin.walls at oracle.com Fri Jul 30 14:13:03 2010 From: kevin.walls at oracle.com (Kevin Walls) Date: Fri, 30 Jul 2010 22:13:03 +0100 Subject: [Fwd: Re: Review request: 6581734 CMS Old Gen's collection usage is zero after GC which is incorrect] In-Reply-To: <4C5339CA.2080805@oracle.com> References: <4C52F53F.90407@oracle.com> <4C530C85.4030402@oracle.com> <4C53366B.6010802@oracle.com> <4C5339CA.2080805@oracle.com> Message-ID: <4C53405F.2040109@oracle.com> Of course... Uploaded in the same place. 8-) Mandy Chung wrote: > Kevin Walls wrote: >> >> Great, thanks - respun as >> http://cr.openjdk.java.net/~kevinw/6581734/webrev.02/ >> > > This looks better. > > Test6581734.java: > All methods/fields in this class should have indented (currently not > indented). Also line 118 has 3 extra spaces. > > Thanks > Mandy >> >> >> Mandy Chung wrote: >>> Hi Kevin, >>> >>> Thanks for fixing this. Looks good with some minor comments: >>> >>> memoryManager.hpp line 181-182: >>> get_last_gc_stat() returns gc_index but the comment says it >>> returns the size of the array pool. >>> >>> management.cpp line 1908: >>> if (!mgr->get_last_gc_stat(stat) == 0) { >>> >>> You forgot to take out "!" when you changed the get_last_gc_stat() >>> to return size_t instead of bool. >>> >>> test/gc/6581734/Test6581734.java >>> @run main/othervm -server -Xmx512m -verbose:gc ... >>> >>> Why do you need "-server"? We also want client VM to be tested, right? >>> >>> You can drop -verbose:gc and use MemoryMXBean.setVerbose(true) to >>> turn on gc tracing if you like. >>> >>> The test source isn't formatted properly, e.g. line 49-56, 69-75, >>> 79-124, 127, 131. Can you fix the formatting - using 4 spaces as >>> indentation (not tab or 2 spaces)? >>> >>> Thanks >>> Mandy >>> >>> Kevin Walls wrote: >>>> >>>> Hi Mandy, >>>> >>>> Yes, thanks for the discussions we've had so far. 8-) >>>> >>>> Here's an updated JDK7 version: >>>> >>>> http://cr.openjdk.java.net/~kevinw/6581734/webrev.01/ >>>> >>>> Thanks >>>> Kevin >>>> >>>> Mandy Chung wrote: >>>>> Kevin, >>>>> >>>>> As I know, you're revising the fix for the 6 update release. >>>>> I'll review your revised webrev when it's ready. >>>>> >>>>> Thanks >>>>> Mandy >>>>> >>>>> Kevin Walls wrote: >>>>>> Hi - >>>>>> >>>>>> This is a review request for the issue where cms doesn't update >>>>>> the statistics used by the MemoryPoolMXBean system: only >>>>>> concurrent mode failures update the stats. We just aren't >>>>>> prepared for concurrent collections, so it takes a fair amount of >>>>>> customisation to add that flexibility... >>>>>> >>>>>> http://cr.openjdk.java.net/~kevinw/6581734/webrev/ >>>>>> >>>>>> Thanks >>>>>> Kevin >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>> >>>> >>> >> > From mandy.chung at oracle.com Fri Jul 30 14:13:58 2010 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 30 Jul 2010 14:13:58 -0700 Subject: [Fwd: Re: Review request: 6581734 CMS Old Gen's collection usage is zero after GC which is incorrect] In-Reply-To: <4C53405F.2040109@oracle.com> References: <4C52F53F.90407@oracle.com> <4C530C85.4030402@oracle.com> <4C53366B.6010802@oracle.com> <4C5339CA.2080805@oracle.com> <4C53405F.2040109@oracle.com> Message-ID: <4C534096.4000405@oracle.com> Thumbs up. Thanks Mandy Kevin Walls wrote: > Of course... Uploaded in the same place. 8-) > > > Mandy Chung wrote: >> Kevin Walls wrote: >>> >>> Great, thanks - respun as >>> http://cr.openjdk.java.net/~kevinw/6581734/webrev.02/ >>> >> >> This looks better. >> >> Test6581734.java: >> All methods/fields in this class should have indented (currently >> not indented). Also line 118 has 3 extra spaces. >> >> Thanks >> Mandy >>> >>> >>> Mandy Chung wrote: >>>> Hi Kevin, >>>> >>>> Thanks for fixing this. Looks good with some minor comments: >>>> >>>> memoryManager.hpp line 181-182: >>>> get_last_gc_stat() returns gc_index but the comment says it >>>> returns the size of the array pool. >>>> >>>> management.cpp line 1908: >>>> if (!mgr->get_last_gc_stat(stat) == 0) { >>>> >>>> You forgot to take out "!" when you changed the get_last_gc_stat() >>>> to return size_t instead of bool. >>>> >>>> test/gc/6581734/Test6581734.java >>>> @run main/othervm -server -Xmx512m -verbose:gc ... >>>> >>>> Why do you need "-server"? We also want client VM to be tested, >>>> right? >>>> >>>> You can drop -verbose:gc and use MemoryMXBean.setVerbose(true) to >>>> turn on gc tracing if you like. >>>> >>>> The test source isn't formatted properly, e.g. line 49-56, 69-75, >>>> 79-124, 127, 131. Can you fix the formatting - using 4 spaces as >>>> indentation (not tab or 2 spaces)? >>>> >>>> Thanks >>>> Mandy >>>> >>>> Kevin Walls wrote: >>>>> >>>>> Hi Mandy, >>>>> >>>>> Yes, thanks for the discussions we've had so far. 8-) >>>>> >>>>> Here's an updated JDK7 version: >>>>> >>>>> http://cr.openjdk.java.net/~kevinw/6581734/webrev.01/ >>>>> >>>>> Thanks >>>>> Kevin >>>>> >>>>> Mandy Chung wrote: >>>>>> Kevin, >>>>>> >>>>>> As I know, you're revising the fix for the 6 update release. >>>>>> I'll review your revised webrev when it's ready. >>>>>> >>>>>> Thanks >>>>>> Mandy >>>>>> >>>>>> Kevin Walls wrote: >>>>>>> Hi - >>>>>>> >>>>>>> This is a review request for the issue where cms doesn't update >>>>>>> the statistics used by the MemoryPoolMXBean system: only >>>>>>> concurrent mode failures update the stats. We just aren't >>>>>>> prepared for concurrent collections, so it takes a fair amount >>>>>>> of customisation to add that flexibility... >>>>>>> >>>>>>> http://cr.openjdk.java.net/~kevinw/6581734/webrev/ >>>>>>> >>>>>>> Thanks >>>>>>> Kevin >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> > From michael.x.mcmahon at oracle.com Fri Jul 30 10:17:18 2010 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Fri, 30 Jul 2010 17:17:18 +0000 Subject: hg: jdk7/tl/jdk: 6510892: com/sun/net/httpserver/bugs/B6361557.java fails Message-ID: <20100730171728.1DD8347DBB@hg.openjdk.java.net> Changeset: 4d72d0ec83f5 Author: michaelm Date: 2010-07-30 18:16 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4d72d0ec83f5 6510892: com/sun/net/httpserver/bugs/B6361557.java fails Reviewed-by: chegar ! test/com/sun/net/httpserver/bugs/B6361557.java