Request for Review: 7120511: Add diagnostic commands
Frederic Parain
frederic.parain at oracle.com
Fri Jan 6 04:19:04 PST 2012
Thanks for the review, I've addressed the following points:
On 01/ 5/12 07:33 PM, Daniel D. Daugherty wrote:
> src/share/vm/services/attachListener.cpp
> The "out->cr()" on line 162 should follow line 160 (I think).
Makes sense, fixed.
> src/share/vm/services/management.cpp
> A comment above line 120 describing what the two boolean parameters
> to DCmdFactoryImp() mean would be helpful to the casual reader...
Comment added.
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: Frederic.Parain at Oracle.com
More information about the serviceability-dev
mailing list