Request for Review: 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

[David Holmes]

Hi Staffan,

I'm somewhat confused by this problem. 6938627 is the CR that changed 
from /tmp to use the java.io.tmpdir property, but that CR did not modify 
the files that you have modified - so what broke these files?

Looking at your fix, wouldn't it be simpler to just set the static 
tmpdir to /tmp and leave the rest of the code as-is? Why do you stop 
looking in the cwd in addition to changing the tmp location? Is it 
because hotspot will never write it there?

Thanks,
David

On 30/01/2012 8:05 PM, Staffan Larsen wrote:
> Please review the following fix.
>
> Webrev: http://cr.openjdk.java.net/~sla/7132199/webrev.00/
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7132199
>
> The problem is that HotSpot will always create the .java_pid1234
> socket/door file in /tmp (see CR 7009828).
>
> The JDK will currently look first in the current directory then in
> java.io.tmpdir. If java.io.tmpdir has the default value of /tmp this
> works, but if the user has set it to something else it doesn't.
>
> My fix hardcodes /tmp in LinuxVirtualMachine.java and
> SolarisVirtualMachine.java.
>
> The same fix will be needed in BsdVirtualMachine.java eventually.
>
> Thanks,
> /Staffan