RFR(S): 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'

Markus Grönlund markus.gronlund at oracle.com
Mon Jul 8 08:45:06 PDT 2013


Rickard,

I think it looks good (not a Reviewer).

Cheers
Markus

-----Original Message-----
From: Rickard Bäckman 
Sent: den 4 juli 2013 11:30
To: serviceability-dev at openjdk.java.net serviceability-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net
Subject: RFR(S): 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'

Hi,

can I please have a couple of reviews for this change?

The problem in this crash was that we were given an incorrect fp (in this case 0x0) and had a pc that matched the C -> Java entry frame. The code then dereferenced fp +- offset.

This change verifies that the fp +- offset is actually on the stack of the thread before doing the derefencing.

Webrev: http://cr.openjdk.java.net/~rbackman/8016131/

Thanks
/R


More information about the serviceability-dev mailing list