Code Review Request: 8016576: Overrides warnings in jdi and jconsole

Kurchi Hazra kurchi.subhra.hazra at oracle.com
Mon Jun 17 12:08:03 PDT 2013


>> - Maybe a webrev helps:
>> http://cr.openjdk.java.net/~khazra/8016576/webrev.01/
>> <http://cr.openjdk.java.net/%7Ekhazra/8016576/webrev.01/>
>
> Looks fine, but trivially remove the unnecessary null check in equals 
> before pushing. If 'o instanceof XObject', then it cannot be null. 
> Similar for SDE.equals
- For XObject I am checking if object is null which is a member of 
XObject (and not o) - I'll remove the null check in SDE.

>
> -Chris.

-- 
-Kurchi



More information about the serviceability-dev mailing list