RFR(S), SA, warnings from b116 for hotspot.agent.src.share.native: JNI exception pending

Staffan Larsen staffan.larsen at oracle.com
Tue Dec 2 19:51:53 UTC 2014


These two lines are wrong. The "!= NULL” should not be there:

241     if (!(*env)->ExceptionOccurred(env) != NULL) {
255   if (!(*env)->ExceptionOccurred(env) != NULL) {

Otherwise looks good.

/Staffan

> On 2 dec 2014, at 20:14, Dmitry Samersoff <dmitry.samersoff at oracle.com> wrote:
> 
> Please review the small fix.
> 
> http://cr.openjdk.java.net/~dsamersoff/JDK-8028773/webrev.01/
> 
> Added more missed exception checks to sadis.c
> 
> -- 
> Dmitry Samersoff
> Oracle Java development team, Saint Petersburg, Russia
> * I would love to change the world, but they won't give me the sources.



More information about the serviceability-dev mailing list