RFR: JDK-8071464: Clear up SVC jdk/test/* JRE layout dependencies other than those on tools.jar

Alexander Kulyakhtin alexander.kulyakhtin at oracle.com
Thu Jan 29 12:21:12 UTC 2015


Hi Katja, Stafan

I've corrected the alignment issue, per Stafan's review, and attached the patch.

Could it be possible to push the patch? 

Thank you very much for your help.

Best regards,
Alex

----- Original Message -----
From: staffan.larsen at oracle.com
To: alexander.kulyakhtin at oracle.com
Cc: serviceability-dev at openjdk.java.net
Sent: Thursday, January 29, 2015 11:02:12 AM GMT +04:00 Abu Dhabi / Muscat
Subject: Re: RFR: JDK-8071464: Clear up SVC jdk/test/* JRE layout dependencies other than those on tools.jar

Looks good!

nit: test/com/sun/jdi/ShellScaffold.sh:947, the alignment for ">&2” got broken.

Thanks,
/Staffan


> On 28 jan 2015, at 17:24, Alexander Kulyakhtin <alexander.kulyakhtin at oracle.com> wrote:
> 
> Hi,
> 
> Could you, please, review the fix below.
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8071464
> webrev: http://cr.openjdk.java.net/~eistepan/~akulyakhtin/8071464/webrev.01/
> 
> References to the jre layout are removed from ShellScaffold.sh and DemoRun.java. 
> Other files mentioned in the CR have not been changed as they don't contain any JRE-related artifacts anymore.
> 
> Thanks,
> Alex

-------------- next part --------------
A non-text attachment was scrubbed...
Name: jdk8071464.patch
Type: text/x-patch
Size: 2628 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20150129/8a68106b/jdk8071464.patch>


More information about the serviceability-dev mailing list