RFR: JDK-7107013: sun.jvm.hotspot.runtime.Bytes.swapLong conversion to long mishandled

[Bernd Eckenfels]

Hello,
Is the a reason why swapShort has a " lowbyte | highbyyte" and the other two methods the other way around? I would all write in the natural order of. Igendianess (I.e. Change the first).

Gruss
Bernd
-- 
http://bernd.eckenfels.net




On Thu, Nov 10, 2016 at 8:32 AM +0100, "Sharath Ballal" <sharath.ballal at oracle.com> wrote:










Thanks Dmitry.  I have made the changes in line 54.
http://cr.openjdk.java.net/~sballal/7107013/webrev.01/ 

I didn't change the recursive calls to swap functions because that looks more readable.

-Sharath Ballal


-----Original Message-----
From: Dmitry Samersoff 
Sent: Thursday, November 10, 2016 12:46 AM
To: Sharath Ballal; serviceability-dev at openjdk.java.net
Subject: Re: RFR: JDK-7107013: sun.jvm.hotspot.runtime.Bytes.swapLong conversion to long mishandled

Sharath,

Please, add (int) to ll. 54 for better readability.

PS:

Despite the fact that C2 does a great job eliminating useless code (multiple calls to if (!swap) in this case) it would be nice to use simple, well known arithmetic directly instead of subsequent calls to other swap functions.

-Dmitry

On 2016-11-09 19:30, Sharath Ballal wrote:
> Hello,
> 
> Pls review this small fix
> 
>  
> 
> Issue: https://bugs.openjdk.java.net/browse/JDK-7107013
> 
> Webrev: http://cr.openjdk.java.net/~sballal/7107013/webrev.00/
> 
>  
> 
>  
> 
> -Sharath Ballal
> 
>  
> 
>  
> 


--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20161110/3cfb9bc4/attachment.html>