RFR(S) 8205541: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatArrayCorrectnessTest.java fails

JC Beyler jcbeyler at google.com
Tue Jul 17 22:12:06 UTC 2018


Hi Alex,

Thanks for the review!

Here is now the new webrev, ready for a push:
http://cr.openjdk.java.net/~jcbeyler/8205541/webrev.03/

Thanks all,
Jc

On Tue, Jul 17, 2018 at 2:48 PM Alex Menkov <alexey.menkov at oracle.com>
wrote:

> Looks good to me as well
>
> --alex
>
> On 07/16/2018 16:06, serguei.spitsyn at oracle.com wrote:
> > Hi Jc,
> >
> > It looks good to me.
> >
> > Thanks,
> > Serguei
> >
> >
> > On 7/16/18 12:37, JC Beyler wrote:
> >> Hi all,
> >>
> >> Small RFR to update two HeapMonitor tests to remove test failures when
> >> resetting a test data structure and assuming wrongly that the data
> >> structure was empty afterwards due to a second thread adding something
> >> to it.
> >> The fix is to disable sampling then reset the storage before enabling
> >> it again.
> >>
> >> Bug associated is: JDK-8205541
> >> <https://bugs.openjdk.java.net/browse/JDK-8205541>
> >> Webrev is here:
> >> http://cr.openjdk.java.net/~jcbeyler/8205541/webrev.02/
> >> <http://cr.openjdk.java.net/%7Ejcbeyler/8205541/webrev.02/>
> >>
> >> Thanks all!
> >> Jc
> >
>


-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20180717/6c34bfac/attachment.html>


More information about the serviceability-dev mailing list