RFR (S) 8211432: [REDO] Handle JNIGlobalRefLocker.cpp

[Alex Menkov]

Looks good.

--alex

On 10/09/2018 16:09, JC Beyler wrote:
> Hi Paul,
> 
> Yes base_msg can be doubly const so I did that in my local version. I'll 
> push a new webrev once I get more reviews :)
> 
> Thanks!
> Jc
> 
> On Tue, Oct 9, 2018 at 3:54 PM Hohensee, Paul <hohensee at amazon.com 
> <mailto:hohensee at amazon.com>> wrote:
> 
>     Is the pointer itself constant? I.e., “const char* const base_msg”?____
> 
>     __ __
> 
>     Paul____
> 
>     __ __
> 
>     *From: *serviceability-dev
>     <serviceability-dev-bounces at openjdk.java.net
>     <mailto:serviceability-dev-bounces at openjdk.java.net>> on behalf of
>     JC Beyler <jcbeyler at google.com <mailto:jcbeyler at google.com>>
>     *Date: *Tuesday, October 9, 2018 at 5:23 PM
>     *To: *"serviceability-dev at openjdk.java.net
>     <mailto:serviceability-dev at openjdk.java.net>"
>     <serviceability-dev at openjdk.java.net
>     <mailto:serviceability-dev at openjdk.java.net>>
>     *Subject: *RFR (S) 8211432: [REDO] Handle JNIGlobalRefLocker.cpp____
> 
>     __ __
> 
>     Hi all, ____
> 
>     __ __
> 
>     When I pushed the fix for JDK-8210842
>     <https://bugs.openjdk.java.net/browse/JDK-8210842>, I failed to
>     realize there was seemingly an issue when using std::string. This
>     provoked a failure for Windows and Solaris builds described in the
>     bug for this fix.____
> 
>     __ __
> 
>     Therefore I offer a solution using const char* instead to not have
>     any issues:
>     ____
> 
>     __ __
> 
>     Webrev: http://cr.openjdk.java.net/~jcbeyler/8211432/webrev.00/
>     <http://cr.openjdk.java.net/%7Ejcbeyler/8211432/webrev.00/>____
> 
>     Bug: https://bugs.openjdk.java.net/browse/JDK-8211432____
> 
>     __ __
> 
>     The incremental between the previous fix and this one is here so
>     that it helps see the differences:____
> 
>     http://cr.openjdk.java.net/~jcbeyler/8211432/webrev.inc/
>     <http://cr.openjdk.java.net/%7Ejcbeyler/8211432/webrev.inc/>____
> 
>     __ __
> 
>     Finally, this has passed the submit-repo smoke-screen.____
> 
>     __ __
> 
>     Thanks,____
> 
>     Jc____
> 
> 
> 
> -- 
> 
> Thanks,
> Jc